@zeniai/client-epic-state 5.1.12 → 5.1.13

package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js

@@ -4,16 +4,25 @@ import { updateApprovalRules } from '../../../../../entity/approvalRule/approval
 import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
 import { updateAllUsers } from '../../../../../entity/user/userReducer';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
-import { toApprovalChangableInfoPayload } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
+import { toApprovalChangableInfoPayload, toApprovalChangableInfoPayloadV1, } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
 import { saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesFailure, saveRemiSetupApproverViewUpdatesSuccess, } from '../remiSetupApproverViewReducer';
-export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap(() => {
+export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap((action) => {
     const { remiSetupApproverViewState } = state$.value;
     const remiSetupApproverViewUpdateData = remiSetupApproverViewState.remiSetupApproverViewUpdateData;
     if (remiSetupApproverViewUpdateData != null &&
         remiSetupApproverViewUpdateData.data != null) {
-        const payload = toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data);
+        // Approval Rules 3.0 — gate URL + write-side payload mapper on
+        // the `approval_rule_v3_config` dynamic config. `useV3` arrives
+        // on the action payload from the screen connector.
+        const { useV3 } = action.payload;
+        const payload = useV3
+            ? toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data)
+            : toApprovalChangableInfoPayloadV1(remiSetupApproverViewUpdateData.data);
+        const endpoint = useV3
+            ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
+            : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
         return zeniAPI
-            .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`, payload)
+            .postAndGetJSON(endpoint, payload)
             .pipe(mergeMap((response) => {
             if (isSuccessResponse(response) && response.data != null) {
                 const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);

package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js

@@ -13,6 +13,7 @@ export const initialState = {
     newApprovalRuleId: undefined,
     approvalRulesDeleteStatusById: {},
     remiSetupApproverViewUpdateData: undefined,
+    reorderStatus: { fetchState: 'Not-Started', error: undefined },
     hasValidState() {
         return this.fetchState === 'Completed';
     },
@@ -26,12 +27,17 @@ const remiSetupApproverView = createSlice({
                 draft.fetchState = 'In-Progress';
                 draft.error = undefined;
             },
-            prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false) {
+            // Approval Rules 3.0 — `useV3` arrives from the screen connector
+            // ('approval_rule_v3_config' dynamic config) and picks v1 vs v2
+            // endpoint in the fetch epic. Required (no default) so a missing
+            // connector wire surfaces at compile time.
+            prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false, useV3) {
                 return {
                     payload: {
                         cacheOverride,
                         resolveAttributeToUser,
                         includeImplicitActors,
+                        useV3,
                     },
                 };
             },
@@ -134,8 +140,12 @@ const remiSetupApproverView = createSlice({
                     error: undefined,
                 };
             },
-            prepare(approvalRuleId) {
-                return { payload: { approvalRuleId } };
+            // Approval Rules 3.0 — `useV3` flows from the screen connector
+            // ('approval_rule_v3_config' dynamic config) so the delete epic
+            // can pick the v1 vs v2 endpoint. Required (no default) so a
+            // missing connector wire surfaces at compile time.
+            prepare(approvalRuleId, useV3) {
+                return { payload: { approvalRuleId, useV3 } };
             },
         },
         deleteRemiApprovalRuleSuccess: {
@@ -167,13 +177,72 @@ const remiSetupApproverView = createSlice({
                 };
             },
         },
-        saveRemiSetupApproverViewUpdates(draft) {
-            if (draft.remiSetupApproverViewUpdateData != null) {
-                draft.remiSetupApproverViewUpdateData.updateStatus = {
-                    fetchState: 'In-Progress',
-                    error: undefined,
-                };
-            }
+        /**
+         * Approval Rules 3.0 — list-page drag-and-drop reorder.
+         * See BillPay equivalent for the longer rationale.
+         */
+        reorderRemiApprovalRules: {
+            reducer(draft, action) {
+                const { approvalRuleIds } = action.payload;
+                const wasReorderInFlight = draft.reorderStatus.fetchState === 'In-Progress';
+                draft.reorderStatus = { fetchState: 'In-Progress', error: undefined };
+                // Stash the pre-reorder order for synchronous rollback on
+                // 'Failure'. See the BillPay reducer for the rationale,
+                // including the in-flight guard: a second drag before the
+                // first PUT lands must not overwrite the snapshot.
+                if (!wasReorderInFlight) {
+                    draft.reorderRollbackIds = draft.approvalRuleIds;
+                }
+                draft.approvalRuleIds = approvalRuleIds;
+            },
+            // Approval Rules 3.0 — `useV3` required so a missing wire
+            // surfaces at compile time. Mirror of BillPay's reorder.prepare.
+            prepare(approvalRuleIds, useV3) {
+                return { payload: { approvalRuleIds, useV3 } };
+            },
+        },
+        reorderRemiApprovalRulesSuccess: {
+            reducer(draft, action) {
+                const { approvalRuleIds } = action.payload;
+                draft.reorderStatus = { fetchState: 'Completed', error: undefined };
+                draft.approvalRuleIds = approvalRuleIds;
+                draft.reorderRollbackIds = undefined;
+            },
+            prepare(approvalRuleIds) {
+                return { payload: { approvalRuleIds } };
+            },
+        },
+        reorderRemiApprovalRulesFailure: {
+            reducer(draft, action) {
+                const { status } = action.payload;
+                draft.reorderStatus = { fetchState: 'Error', error: status };
+                if (draft.reorderRollbackIds != null) {
+                    draft.approvalRuleIds = draft.reorderRollbackIds;
+                    draft.reorderRollbackIds = undefined;
+                }
+            },
+            prepare(status) {
+                return { payload: { status } };
+            },
+        },
+        saveRemiSetupApproverViewUpdates: {
+            // Approval Rules 3.0 — `useV3` sourced from
+            // `approval_rule_v3_config` dynamic config in the screen
+            // connector; epic uses it to pick v1 vs v2 URL + mapper. The
+            // reducer doesn't read the action but the parameter must be
+            // declared so the action payload type carries downstream.
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
+            reducer(draft, _action) {
+                if (draft.remiSetupApproverViewUpdateData != null) {
+                    draft.remiSetupApproverViewUpdateData.updateStatus = {
+                        fetchState: 'In-Progress',
+                        error: undefined,
+                    };
+                }
+            },
+            prepare(useV3) {
+                return { payload: { useV3 } };
+            },
         },
         saveRemiSetupApproverViewUpdatesSuccess: {
             reducer(draft, action) {
@@ -262,5 +331,5 @@ const remiSetupApproverView = createSlice({
         },
     },
 });
-export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
+export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, reorderRemiApprovalRules, reorderRemiApprovalRulesSuccess, reorderRemiApprovalRulesFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
 export default remiSetupApproverView.reducer;

package/lib/esm/view/transactionDetail/epics/saveTransactionHelper.js

@@ -29,6 +29,7 @@ export const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDe
     const entityUpdates = {};
     const isTransactionMisCategorized = isTransactionMiscategorized(transaction, isExpenseAutomationEnabled);
     updates.memo = transactionDetailLocalData.memo;
+    updates.documentId = transactionDetailLocalData.documentId;
     const selectedEntity = transactionDetailLocalData.selectedEntity;
     const updatedEntityId = transactionDetailLocalData.updatePreviousTransactionsWithUpdatedVendor ===
         true

package/lib/esm/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -168,6 +168,12 @@ function preparePayload(transactionState, vendorState, transactionDetailState, t
 const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, vendorUpdates, customerUpdates, tranSelectedEntity) => {
     const transaction = Object.assign({}, detail);
     transaction.memo = updates.memo ?? '';
+    // Unlike `memo` (always reset to '' when absent), `documentId` falls back to
+    // the existing value rather than ''. Only the journal-entry title is
+    // user-editable; for every other transaction type `updates.documentId` is
+    // either the unchanged current value or undefined, and we must not send an
+    // empty `document_id` that the server would treat as clearing the number.
+    transaction.documentId = updates.documentId ?? transaction.documentId;
     const recommendationUpdates = {};
     for (const key in updates.updatesByLineId) {
         const lineUpdates = updates.updatesByLineId[key];

package/lib/esm/view/transactionDetail/transactionDetailLocalDataHelper.js

@@ -11,6 +11,7 @@ export const toTransactionDetailLocalData = (transaction, defaultVendorId, uncat
         ?.id;
     const vendorId = defaultVendorId ?? transaction.vendor?.id;
     transactionLocal.memo = transaction.memo;
+    transactionLocal.documentId = transaction.documentId;
     transactionLocal.vendorUpdates =
         isVendorTransaction(transaction) && vendorId != null
             ? {
@@ -421,6 +422,7 @@ export const toUpdateLineItemsOriginalCategoryClass = (transaction, transactionD
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         vendorDetails: transactionDetailLocalData.vendorDetails,
         vendorUpdates: transactionDetailLocalData.vendorUpdates,
@@ -524,6 +526,7 @@ export const toSetAllLineItemsToCategoryClass = (transaction, transactionDetailL
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         vendorUpdates: transactionDetailLocalData.vendorUpdates,
         vendorDetails: transactionDetailLocalData.vendorDetails,
@@ -568,6 +571,7 @@ export const toSetAllLineItemsLocalDataIsUpdateAllChecked = (transaction, transa
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         vendorDetails: transactionDetailLocalData.vendorDetails,
         vendorUpdates: transactionDetailLocalData.vendorUpdates,
@@ -724,6 +728,7 @@ export const setEntityRecommendationForLineIdInLocalData = (transaction, transac
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         vendorUpdates: transactionDetailLocalData.vendorUpdates,
         vendorDetails: transactionDetailLocalData.vendorDetails,
@@ -776,6 +781,7 @@ export const removeEntityRecommendationForLineIdInLocalData = (transaction, tran
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         vendorDetails: transactionDetailLocalData.vendorDetails,
         vendorUpdates: transactionDetailLocalData.vendorUpdates,
@@ -881,7 +887,6 @@ export const toSetAllLineItemsToVendor = (transaction, transactionDetailLocalDat
     }
     const newLocalData = {
         ...transactionDetailLocalData,
-        memo: transactionDetailLocalData.memo,
         lineItemById: newLineItems,
         isVendorUpdateAllChecked: true,
     };
@@ -996,6 +1001,7 @@ export const toUpdateLineItemsToOriginalVendor = (transaction, transactionDetail
     const newLocalData = {
         ...initialSupportedTransactionDetail.transactionDetailLocalData,
         memo: transactionDetailLocalData.memo,
+        documentId: transactionDetailLocalData.documentId,
         lineItemById: newLineItems,
         isVendorUpdateAllChecked: false,
         latestUpdatedLineWithEntity: transactionDetailLocalData.latestUpdatedLineWithEntity,