@zeniai/client-epic-state 5.1.0-betaSS3 → 5.1.0

package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js

@@ -13,6 +13,7 @@ export const initialState = {
     newApprovalRuleId: undefined,
     approvalRulesDeleteStatusById: {},
     remiSetupApproverViewUpdateData: undefined,
+    reorderStatus: { fetchState: 'Not-Started', error: undefined },
     hasValidState() {
         return this.fetchState === 'Completed';
     },
@@ -26,12 +27,17 @@ const remiSetupApproverView = createSlice({
                 draft.fetchState = 'In-Progress';
                 draft.error = undefined;
             },
-            prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false) {
+            // Approval Rules 3.0 — `useV3` arrives from the screen connector
+            // ('approval_rule_v3_config' dynamic config) and picks v1 vs v2
+            // endpoint in the fetch epic. Required (no default) so a missing
+            // connector wire surfaces at compile time.
+            prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false, useV3) {
                 return {
                     payload: {
                         cacheOverride,
                         resolveAttributeToUser,
                         includeImplicitActors,
+                        useV3,
                     },
                 };
             },
@@ -134,8 +140,12 @@ const remiSetupApproverView = createSlice({
                     error: undefined,
                 };
             },
-            prepare(approvalRuleId) {
-                return { payload: { approvalRuleId } };
+            // Approval Rules 3.0 — `useV3` flows from the screen connector
+            // ('approval_rule_v3_config' dynamic config) so the delete epic
+            // can pick the v1 vs v2 endpoint. Required (no default) so a
+            // missing connector wire surfaces at compile time.
+            prepare(approvalRuleId, useV3) {
+                return { payload: { approvalRuleId, useV3 } };
             },
         },
         deleteRemiApprovalRuleSuccess: {
@@ -167,13 +177,72 @@ const remiSetupApproverView = createSlice({
                 };
             },
         },
-        saveRemiSetupApproverViewUpdates(draft) {
-            if (draft.remiSetupApproverViewUpdateData != null) {
-                draft.remiSetupApproverViewUpdateData.updateStatus = {
-                    fetchState: 'In-Progress',
-                    error: undefined,
-                };
-            }
+        /**
+         * Approval Rules 3.0 — list-page drag-and-drop reorder.
+         * See BillPay equivalent for the longer rationale.
+         */
+        reorderRemiApprovalRules: {
+            reducer(draft, action) {
+                const { approvalRuleIds } = action.payload;
+                const wasReorderInFlight = draft.reorderStatus.fetchState === 'In-Progress';
+                draft.reorderStatus = { fetchState: 'In-Progress', error: undefined };
+                // Stash the pre-reorder order for synchronous rollback on
+                // 'Failure'. See the BillPay reducer for the rationale,
+                // including the in-flight guard: a second drag before the
+                // first PUT lands must not overwrite the snapshot.
+                if (!wasReorderInFlight) {
+                    draft.reorderRollbackIds = draft.approvalRuleIds;
+                }
+                draft.approvalRuleIds = approvalRuleIds;
+            },
+            // Approval Rules 3.0 — `useV3` required so a missing wire
+            // surfaces at compile time. Mirror of BillPay's reorder.prepare.
+            prepare(approvalRuleIds, useV3) {
+                return { payload: { approvalRuleIds, useV3 } };
+            },
+        },
+        reorderRemiApprovalRulesSuccess: {
+            reducer(draft, action) {
+                const { approvalRuleIds } = action.payload;
+                draft.reorderStatus = { fetchState: 'Completed', error: undefined };
+                draft.approvalRuleIds = approvalRuleIds;
+                draft.reorderRollbackIds = undefined;
+            },
+            prepare(approvalRuleIds) {
+                return { payload: { approvalRuleIds } };
+            },
+        },
+        reorderRemiApprovalRulesFailure: {
+            reducer(draft, action) {
+                const { status } = action.payload;
+                draft.reorderStatus = { fetchState: 'Error', error: status };
+                if (draft.reorderRollbackIds != null) {
+                    draft.approvalRuleIds = draft.reorderRollbackIds;
+                    draft.reorderRollbackIds = undefined;
+                }
+            },
+            prepare(status) {
+                return { payload: { status } };
+            },
+        },
+        saveRemiSetupApproverViewUpdates: {
+            // Approval Rules 3.0 — `useV3` sourced from
+            // `approval_rule_v3_config` dynamic config in the screen
+            // connector; epic uses it to pick v1 vs v2 URL + mapper. The
+            // reducer doesn't read the action but the parameter must be
+            // declared so the action payload type carries downstream.
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
+            reducer(draft, _action) {
+                if (draft.remiSetupApproverViewUpdateData != null) {
+                    draft.remiSetupApproverViewUpdateData.updateStatus = {
+                        fetchState: 'In-Progress',
+                        error: undefined,
+                    };
+                }
+            },
+            prepare(useV3) {
+                return { payload: { useV3 } };
+            },
         },
         saveRemiSetupApproverViewUpdatesSuccess: {
             reducer(draft, action) {
@@ -262,5 +331,5 @@ const remiSetupApproverView = createSlice({
         },
     },
 });
-export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
+export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, reorderRemiApprovalRules, reorderRemiApprovalRulesSuccess, reorderRemiApprovalRulesFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
 export default remiSetupApproverView.reducer;

package/lib/esm/view/spendManagement/treasury/treasurySetUp/epic/updateTreasuryPromoIntroClosedByOutsideClickEpic.js

@@ -0,0 +1,18 @@
+import { of } from 'rxjs';
+import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
+import { updateTreasuryPromoIntroClosedByOutsideClickForLoggedInUser } from '../../../../../entity/tenant/tenantReducer';
+import { createZeniAPIStatus, isSuccessStatus, } from '../../../../../responsePayload';
+import { updateTreasuryPromoIntroClosedByOutsideClick, updateTreasuryPromoIntroClosedByOutsideClickFailure, updateTreasuryPromoIntroClosedByOutsideClickSuccess, } from '../treasurySetupViewReducer';
+export const updateTreasuryPromoIntroClosedByOutsideClickEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(updateTreasuryPromoIntroClosedByOutsideClick.match), switchMap(() => {
+    return zeniAPI
+        .putAndGetJSON(`${zeniAPI.apiEndPoints.tenantMicroServiceBaseUrl}/1.0/user/self`, { is_treasury_promo_intro_closed_by_outside_click: true })
+        .pipe(mergeMap((response) => {
+        if (isSuccessStatus(response)) {
+            return of(updateTreasuryPromoIntroClosedByOutsideClickForLoggedInUser(), updateTreasuryPromoIntroClosedByOutsideClickSuccess());
+        }
+        else {
+            return of(updateTreasuryPromoIntroClosedByOutsideClickFailure(response.status));
+        }
+    }), catchError((error) => of(updateTreasuryPromoIntroClosedByOutsideClickFailure(createZeniAPIStatus('Unexpected error', 'Update treasury promo intro closed by outside click REST API call errored out' +
+        (error?.message ?? JSON.stringify(error)))))));
+}));

package/lib/esm/view/spendManagement/treasury/treasurySetUp/epic/updateTreasuryPromoRemindMeLaterClickedEpic.js

@@ -0,0 +1,18 @@
+import { of } from 'rxjs';
+import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
+import { updateTreasuryPromoRemindMeLaterClickedForLoggedInUser } from '../../../../../entity/tenant/tenantReducer';
+import { createZeniAPIStatus, isSuccessStatus, } from '../../../../../responsePayload';
+import { updateTreasuryPromoRemindMeLaterClicked, updateTreasuryPromoRemindMeLaterClickedFailure, updateTreasuryPromoRemindMeLaterClickedSuccess, } from '../treasurySetupViewReducer';
+export const updateTreasuryPromoRemindMeLaterClickedEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(updateTreasuryPromoRemindMeLaterClicked.match), switchMap(() => {
+    return zeniAPI
+        .putAndGetJSON(`${zeniAPI.apiEndPoints.tenantMicroServiceBaseUrl}/1.0/user/self`, { is_treasury_promo_video_remind_me_later_clicked: true })
+        .pipe(mergeMap((response) => {
+        if (isSuccessStatus(response)) {
+            return of(updateTreasuryPromoRemindMeLaterClickedForLoggedInUser(), updateTreasuryPromoRemindMeLaterClickedSuccess());
+        }
+        else {
+            return of(updateTreasuryPromoRemindMeLaterClickedFailure(response.status));
+        }
+    }), catchError((error) => of(updateTreasuryPromoRemindMeLaterClickedFailure(createZeniAPIStatus('Unexpected error', 'Update treasury promo remind me later REST API call errored out' +
+        (error?.message ?? JSON.stringify(error)))))));
+}));

package/lib/esm/view/spendManagement/treasury/treasurySetUp/epic/updateTreasuryVideoViewedEpic.js

@@ -14,5 +14,5 @@ export const updateTreasuryVideoViewedEpic = (actions$, _state$, zeniAPI) => act
             return of(updateTreasuryVideoViewedFailure(response.status));
         }
     }), catchError((error) => of(updateTreasuryVideoViewedFailure(createZeniAPIStatus('Unexpected error', 'Update treasury video viewed REST API call errored out' +
-        JSON.stringify(error))))));
+        (error?.message ?? JSON.stringify(error)))))));
 }));

package/lib/esm/view/spendManagement/treasury/treasurySetUp/treasurySetupViewReducer.js

@@ -33,6 +33,14 @@ export const initialState = {
         fetchState: 'Not-Started',
         error: undefined,
     },
+    updateTreasuryPromoIntroClosedByOutsideClickStatus: {
+        fetchState: 'Not-Started',
+        error: undefined,
+    },
+    updateTreasuryPromoRemindMeLaterClickedStatus: {
+        fetchState: 'Not-Started',
+        error: undefined,
+    },
     updateTreasuryVideoViewedStatus: {
         fetchState: 'Not-Started',
         error: undefined,
@@ -290,12 +298,48 @@ const treasurySetupView = createSlice({
                 error: action.payload,
             };
         },
+        updateTreasuryPromoRemindMeLaterClicked(draft) {
+            draft.updateTreasuryPromoRemindMeLaterClickedStatus = {
+                fetchState: 'In-Progress',
+                error: undefined,
+            };
+        },
+        updateTreasuryPromoRemindMeLaterClickedSuccess(draft) {
+            draft.updateTreasuryPromoRemindMeLaterClickedStatus = {
+                fetchState: 'Completed',
+                error: undefined,
+            };
+        },
+        updateTreasuryPromoRemindMeLaterClickedFailure(draft, action) {
+            draft.updateTreasuryPromoRemindMeLaterClickedStatus = {
+                fetchState: 'Error',
+                error: action.payload,
+            };
+        },
+        updateTreasuryPromoIntroClosedByOutsideClick(draft) {
+            draft.updateTreasuryPromoIntroClosedByOutsideClickStatus = {
+                fetchState: 'In-Progress',
+                error: undefined,
+            };
+        },
+        updateTreasuryPromoIntroClosedByOutsideClickSuccess(draft) {
+            draft.updateTreasuryPromoIntroClosedByOutsideClickStatus = {
+                fetchState: 'Completed',
+                error: undefined,
+            };
+        },
+        updateTreasuryPromoIntroClosedByOutsideClickFailure(draft, action) {
+            draft.updateTreasuryPromoIntroClosedByOutsideClickStatus = {
+                fetchState: 'Error',
+                error: action.payload,
+            };
+        },
         clearTreasurySetupView(draft) {
             Object.assign(draft, initialState);
         },
     },
 });
-export const { fetchTreasuryFunds, fetchTreasurySetupView, fetchTreasurySetupViewSuccess, fetchTreasurySetupViewFailure, acceptTreasuryTerms, acceptTreasuryTermsSuccess, acceptTreasuryTermsFailure, clearTreasurySetupView, updateTreasuryFundsSuccess, updateTreasuryFundsFailure, updatePortfolioAllocation, updatePortfolioAllocationSuccess, updatePortfolioAllocationFailure, fetchPortfolioAllocation, fetchPortfolioAllocationSuccess, fetchPortfolioAllocationFailure, updateFundAllocationLocalData, updateTreasuryVideoViewed, updateTreasuryVideoViewedSuccess, updateTreasuryVideoViewedFailure, } = treasurySetupView.actions;
+export const { fetchTreasuryFunds, fetchTreasurySetupView, fetchTreasurySetupViewSuccess, fetchTreasurySetupViewFailure, acceptTreasuryTerms, acceptTreasuryTermsSuccess, acceptTreasuryTermsFailure, clearTreasurySetupView, updateTreasuryFundsSuccess, updateTreasuryFundsFailure, updatePortfolioAllocation, updatePortfolioAllocationSuccess, updatePortfolioAllocationFailure, fetchPortfolioAllocation, fetchPortfolioAllocationSuccess, fetchPortfolioAllocationFailure, updateFundAllocationLocalData, updateTreasuryPromoIntroClosedByOutsideClick, updateTreasuryPromoIntroClosedByOutsideClickFailure, updateTreasuryPromoIntroClosedByOutsideClickSuccess, updateTreasuryPromoRemindMeLaterClicked, updateTreasuryPromoRemindMeLaterClickedFailure, updateTreasuryPromoRemindMeLaterClickedSuccess, updateTreasuryVideoViewed, updateTreasuryVideoViewedFailure, updateTreasuryVideoViewedSuccess, } = treasurySetupView.actions;
 export default treasurySetupView.reducer;
 function mapTreasuryFundsPayloadToFundData(fundsPayload) {
     return fundsPayload.funds.map((fund) => ({

package/lib/esm/view/transactionDetail/journalEntryLinesViewModel.js

@@ -0,0 +1,149 @@
+import orderBy from 'lodash/orderBy';
+import { stringToUnion } from '../../commonStateTypes/stringToUnion';
+import { LINE_TYPE_LINKED, } from '../../entity/transaction/stateTypes/transactionLine';
+/**
+ * View-model helpers for the new Journal Entry table view (see
+ * web-components `journalEntryTable`). Keeps presentation-agnostic
+ * logic — totals, sort, line-filter — colocated in epic-state so it
+ * is testable and reusable.
+ */
+// ---------------------------------------------------------------------------
+// Sort keys
+// ---------------------------------------------------------------------------
+export const JOURNAL_ENTRY_SORT_KEYS = [
+    'description',
+    'name',
+    'category',
+    'class',
+    'debit',
+    'credit',
+];
+export const toJournalEntrySortKey = (v) => stringToUnion(v, JOURNAL_ENTRY_SORT_KEYS);
+export const journalEntryDefaultSortConfig = {
+    sortKey: 'description',
+    sortOrder: 'ascending',
+};
+/**
+ * Sums the `amount.amount` field of every line and returns an `Amount`
+ * whose currencyCode/currencySymbol are taken from the first line.
+ * Returns `undefined` for an empty list, and also when the first line
+ * has no currency to carry — a stray bare number with no symbol is
+ * worse to render than nothing, so the caller is forced to handle the
+ * absence.
+ *
+ * **Precondition:** all input lines must share a currency. Journal
+ * entry lines on the same transaction always do, which is the only
+ * caller today. Mixed-currency input is summed numerically (no FX
+ * conversion) and tagged with the first line's currency, which will
+ * silently produce a wrong total — if this helper is ever reused for
+ * a cross-currency aggregate (e.g. a multi-transaction report), the
+ * caller must pre-group by currency before calling.
+ *
+ * Mirrors legacy `calculateTotal` in
+ * `web-components/src/components/transactionDetail/items/TransactionLinesJournalEntry.tsx`
+ * but without the `Object.assign` ceremony and with stable currency carry-over.
+ */
+export const sumJournalEntryAmounts = (lines) => {
+    if (lines.length === 0) {
+        return undefined;
+    }
+    const first = lines[0].amount;
+    if (first?.currencyCode == null || first?.currencySymbol == null) {
+        return undefined;
+    }
+    let total = 0;
+    for (const line of lines) {
+        total += line.amount?.amount ?? 0;
+    }
+    return {
+        amount: total,
+        currencyCode: first.currencyCode,
+        currencySymbol: first.currencySymbol,
+    };
+};
+/**
+ * Splits `lines` by `postingType` into a single debit total and a
+ * single credit total — the shape the new flat-table totals row
+ * (`JournalEntryTotalsRow` in `web-components`, Figma frame
+ * `5177:12750`) needs.
+ *
+ * The legacy `TransactionLinesJournalEntry` grouped lines into six
+ * `JournalEntryItemType` buckets (`debit` / `uncategorizedDebit` /
+ * `miscategorizedDebit` plus the credit triplet) for *visual banner
+ * headers* in the line list; its bottom totals row was already two
+ * combined numbers. The new flat table folds those banners away by
+ * design, so we don't surface a per-status breakdown here. If the
+ * design ever asks for sub-totals per status, that's a richer shape
+ * (`{debit: {total, uncategorized, miscategorized}, credit: {…}}`)
+ * and a follow-up — not a v1 of this helper.
+ *
+ * As a side effect, the legacy `calculateCombinedTotalAmount`
+ * `??`/`+` precedence bug (`totalAmount?.amount ?? 0 + (uncat ?? 0) +
+ * (miscat ?? 0)` parses as `totalAmount?.amount ?? (0 + uncat +
+ * miscat)`, silently dropping the uncat/miscat pieces whenever
+ * `totalAmount` was non-nullish) is gone by construction here: there
+ * is no separate combine step, just one pass over the lines.
+ */
+export const journalEntryTotalsByPostingSide = (lines) => {
+    const debitLines = [];
+    const creditLines = [];
+    for (const line of lines) {
+        if (line.postingType === 'debit') {
+            debitLines.push(line);
+        }
+        else if (line.postingType === 'credit') {
+            creditLines.push(line);
+        }
+    }
+    return {
+        debitTotal: sumJournalEntryAmounts(debitLines),
+        creditTotal: sumJournalEntryAmounts(creditLines),
+    };
+};
+// ---------------------------------------------------------------------------
+// Filter
+// ---------------------------------------------------------------------------
+/**
+ * Drops `linked_transaction_line` entries — equivalent to legacy
+ * `filterOutLinkedTransactionLine` in `transactionDetail.helpers.ts`.
+ *
+ * The literal lives in `LINE_TYPE_LINKED` next to `LineType` so the
+ * filter discriminant stays bound to the union at the type level.
+ * Other sites still inlining the literal (see `transactionDetailLocalDataHelper`,
+ * `transactionDetailState`, `transactionCategorizationLocalDataHelper`,
+ * `transactionLinePayload`, and the mocks) are a known follow-up.
+ */
+export const filterJournalEntryLinesExcludingLinked = (lines) => lines?.filter((line) => line.type !== LINE_TYPE_LINKED) ?? [];
+const sortOrderToLodash = (sortOrder) => sortOrder === 'descending' ? 'desc' : 'asc';
+/**
+ * Stable, accessor-driven sort over arbitrary line shapes. Lines that
+ * resolve to the same key value preserve their original relative order
+ * thanks to lodash's stable `orderBy`.
+ *
+ * Strings are lower-cased before comparison so the order is predictable
+ * across mixed-case data. Numbers (debit/credit) compare directly.
+ */
+export const sortJournalEntryLines = (lines, config, accessors) => {
+    const accessor = (line) => {
+        switch (config.sortKey) {
+            case 'description':
+                return accessors.description(line).toLowerCase();
+            case 'name':
+                return accessors.name(line).toLowerCase();
+            case 'category':
+                return accessors.category(line).toLowerCase();
+            case 'class':
+                return accessors.class(line).toLowerCase();
+            case 'debit':
+                return accessors.debit(line);
+            case 'credit':
+                return accessors.credit(line);
+            default:
+                // stringToUnion narrows permissively (returns `s as StringUnion` for
+                // non-member input, see commonStateTypes/stringToUnion.ts), so this
+                // branch is reachable at runtime — keep it as a description fallback.
+                return accessors.description(line).toLowerCase();
+        }
+    };
+    return orderBy([...lines], [accessor], [sortOrderToLodash(config.sortOrder)]);
+};

package/lib/esm/view/transactionDetail/transactionDetailSelector.js

@@ -8,6 +8,7 @@ import { getVendorsByVendorIds } from '../../entity/vendor/vendorSelector';
 import { dateNow } from '../../zeniDayJS';
 import { getAccountList, getNestedAccountListHierarchy, } from '../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../classList/classListSelector';
+import { getResolvedTransferAccounts } from '../createTransferEntry/createTransferEntrySelector';
 import { getProjectList, } from '../projectList/projectListSelector';
 import { getAllLinkedTransactions, getTransactionDetailKey, initialSupportedTransactionDetail, } from './transactionDetailState';
 // "Any line on this transaction is fetching category/class recommendations?"
@@ -31,7 +32,7 @@ export const getDetailInFlightRecommendations = (state, transactionId) => {
     return false;
 };
 export const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = true) => {
-    const { transactionDetailState, transactionState, vendorState, vendorListState, accountState, classState, classListState, accountListState, projectState, projectListState, } = state;
+    const { transactionDetailState, transactionState, vendorState, vendorListState, accountState, classState, classListState, accountListState, createTransferEntryState, projectState, projectListState, } = state;
     const detailKey = getTransactionDetailKey(transactionId);
     const transactionDetail = recordGet(transactionDetailState.transactionDetailById, detailKey);
     let fetchState = {
@@ -98,6 +99,7 @@ export const getTransactionDetail = (state, transactionId, fetchLinkedTransactio
         : [];
     const transactionDetailAnyUpdateStatus = reduceUpdateFetchStates(transactionDetail);
     const vendors = getVendorsByVendorIds(vendorState, vendorListState.vendorIds);
+    const { transferAccountsList, creditCardTransferAccountsList } = getResolvedTransferAccounts(state);
     const hasInFlightCategoryClassRecommendations = getDetailInFlightRecommendations(state, transactionId);
     return {
         reportId: 'transaction_detail',
@@ -116,6 +118,9 @@ export const getTransactionDetail = (state, transactionId, fetchLinkedTransactio
         classList: classList,
         hasInFlightCategoryClassRecommendations,
         isAccountingClassesEnabled,
+        createTransferEntryStatus: createTransferEntryState.createTransferEntryStatus,
+        creditCardTransferAccountsList,
+        transferAccounts: transferAccountsList,
         isAccountingProjectsEnabled,
         projectList,
         isUpdateNotAllowed: transactionDetail?.isUpdateNotAllowed,