@zeniai/client-epic-state 5.0.90-betaAR8 → 5.0.90-betaAR9

package/lib/esm/view/expenseAutomationView/transactionFilterHelpers.js

@@ -224,82 +224,86 @@ const resolveLineLevelPayee = (vendor, customer) => {
     return undefined;
 };
 /**
- * Per-line payee names for a transaction. Bridges the row's display
- * logic — Journal Entries (and any future transaction type that
- * carries vendor/customer per line) put the payee on each line, while
- * Bills, Expenses, and Checks carry it at the transaction level. The
- * single-scalar predecessor only consulted the transaction level, so
- * JE rows whose vendor lived on the line silently missed every payee
- * filter even though the row visibly displayed the vendor name (the
- * row's `TransactionCategorizationListRow` already reads
- * `line.vendor?.name` for non-vendor-typed transactions).
+ * All payee names that could legitimately identify a transaction, across
+ * every place TC stores payee data:
  *
- * Source precedence:
- *   1. localData `lineItemById` — locally-edited per-line vendor or
- *      customer. Lines with neither field set are dropped from the
- *      array; if at least one line has a name, that line set drives
- *      matching (we don't mix line-level localData with the transaction-
- *      level fallback below).
- *   2. Persisted `transaction.lines` — per-line vendor or customer on
- *      the three categorizable line shapes (see `isAccountAndClassLine`).
- *      Other line types (`linked_transaction_line`, etc.) are skipped.
- *   3. Transaction-level fallback — localData transaction-level
- *      vendor → localData transaction-level customer → `transaction.
- *      vendorName` → `transaction.customerName`. Wrapped in a single-
- *      element array so the rest of the matcher stays per-line shaped.
+ *   • localData `lineItemById[*].vendor` / `.customer` — per-line
+ *     vendor/customer the user has tagged in the grid. Populated for
+ *     JEs (where the row reads per-line vendor) and sometimes for
+ *     vendor-typed transactions too (e.g. when an AI vendor
+ *     recommendation lands on a line).
+ *   • Persisted `transaction.lines[*].vendor` / `.customer` — same
+ *     fields on the server snapshot of each line.
+ *   • localData transaction-level `vendor` / `customer` — what the row
+ *     displays for vendor-typed transactions (Bills / Expenses /
+ *     Checks).
+ *   • Top-level `transaction.vendorName` / `customerName` — pre-edit
+ *     server snapshot.
  *
- * Returns `[]` when every source resolves empty; the caller falls back
+ * The function collects names from ALL of these into a single set
+ * rather than picking exclusively from the highest-priority source.
+ * Two reasons:
+ *
+ *   1. Different transaction types put the displayed payee in different
+ *      places. JEs put it on the line; Bills put it at the transaction
+ *      level. A strict-precedence rule that returns early on the first
+ *      non-empty source ends up missing the OTHER place when both have
+ *      data with different values — which is exactly the
+ *      production failure mode that motivated this fix (a Bill whose
+ *      localData line item carried an AI-recommended vendor name was
+ *      excluded because the recommendation won priority over the
+ *      tx-level "Amazon" the row actually displayed).
+ *   2. The single-scalar predecessor missed JE rows entirely because
+ *      it only looked at the tx level. Unioning the line-level sources
+ *      in fixes that without re-introducing the "first source wins"
+ *      brittleness.
+ *
+ * False positives are bounded: a transaction matches `payee = X` only
+ * if `X` literally appears in one of its stored payee fields. Stale
+ * recommendation data being included means the filter is slightly more
+ * lenient than what the row displays, not arbitrary.
+ *
+ * Returns `[]` when no source carries any name; the caller falls back
  * to the absent-value contract (only `not_equal` matches; every other
  * operator excludes).
  */
 const getLinePayeesForTransaction = (transaction) => {
     const localData = transaction?.transactionLocalData?.transactionReviewLocalData;
-    // Priority 1: localData line-level vendor / customer
-    if (localData?.lineItemById != null) {
-        const lineItems = Object.values(localData.lineItemById);
-        if (lineItems.length > 0) {
-            const linePayees = lineItems
-                .map((lineItem) => resolveLineLevelPayee(lineItem?.vendor, lineItem?.customer))
-                .filter(isNonEmptyString);
-            if (linePayees.length > 0) {
-                return linePayees;
-            }
+    // Set used to dedupe — the same vendor name often appears in multiple
+    // sources (e.g. localData mirror of a persisted line) and we don't
+    // want it to be over-counted in the match list. Iteration order is
+    // insertion-order; `.some()` doesn't depend on order so this is fine.
+    const payees = new Set();
+    const addIfPresent = (name) => {
+        if (isNonEmptyString(name)) {
+            payees.add(name);
         }
+    };
+    // localData per-line vendor / customer
+    if (localData?.lineItemById != null) {
+        Object.values(localData.lineItemById).forEach((lineItem) => {
+            addIfPresent(resolveLineLevelPayee(lineItem?.vendor, lineItem?.customer));
+        });
     }
-    // Priority 2: persisted line-level vendor / customer
+    // Persisted per-line vendor / customer (only on the three line
+    // shapes that actually carry them — see `isAccountAndClassLine`).
     if (transaction?.transaction?.lines != null &&
         transaction.transaction.lines.length > 0) {
-        const linePayees = transaction.transaction.lines
-            .map((line) => {
+        transaction.transaction.lines.forEach((line) => {
             if (!isAccountAndClassLine(line)) {
-                return undefined;
+                return;
             }
             const typedLine = line;
-            return resolveLineLevelPayee(typedLine.vendor, typedLine.customer);
-        })
-            .filter(isNonEmptyString);
-        if (linePayees.length > 0) {
-            return linePayees;
-        }
-    }
-    // Priority 3: transaction-level fallback. localData wins over the
-    // top-level fields to keep the existing precedence intact: unsaved
-    // grid edits should drive the filter, not the pre-edit server state.
-    const localVendorName = localData?.vendor?.name;
-    if (isNonEmptyString(localVendorName)) {
-        return [localVendorName];
-    }
-    const localCustomerName = localData?.customer?.name;
-    if (isNonEmptyString(localCustomerName)) {
-        return [localCustomerName];
-    }
-    if (isNonEmptyString(transaction.vendorName)) {
-        return [transaction.vendorName];
-    }
-    if (isNonEmptyString(transaction.customerName)) {
-        return [transaction.customerName];
+            addIfPresent(resolveLineLevelPayee(typedLine.vendor, typedLine.customer));
+        });
     }
-    return [];
+    // Transaction-level: localData first so unsaved grid edits make it
+    // into the match set, then the pre-edit server fields.
+    addIfPresent(localData?.vendor?.name);
+    addIfPresent(localData?.customer?.name);
+    addIfPresent(transaction?.vendorName);
+    addIfPresent(transaction?.customerName);
+    return Array.from(payees);
 };
 /**
  * Resolve the comparable value for a transaction against a given filter field.

package/lib/view/expenseAutomationView/transactionFilterHelpers.js

@@ -227,82 +227,86 @@ const resolveLineLevelPayee = (vendor, customer) => {
     return undefined;
 };
 /**
- * Per-line payee names for a transaction. Bridges the row's display
- * logic — Journal Entries (and any future transaction type that
- * carries vendor/customer per line) put the payee on each line, while
- * Bills, Expenses, and Checks carry it at the transaction level. The
- * single-scalar predecessor only consulted the transaction level, so
- * JE rows whose vendor lived on the line silently missed every payee
- * filter even though the row visibly displayed the vendor name (the
- * row's `TransactionCategorizationListRow` already reads
- * `line.vendor?.name` for non-vendor-typed transactions).
+ * All payee names that could legitimately identify a transaction, across
+ * every place TC stores payee data:
  *
- * Source precedence:
- *   1. localData `lineItemById` — locally-edited per-line vendor or
- *      customer. Lines with neither field set are dropped from the
- *      array; if at least one line has a name, that line set drives
- *      matching (we don't mix line-level localData with the transaction-
- *      level fallback below).
- *   2. Persisted `transaction.lines` — per-line vendor or customer on
- *      the three categorizable line shapes (see `isAccountAndClassLine`).
- *      Other line types (`linked_transaction_line`, etc.) are skipped.
- *   3. Transaction-level fallback — localData transaction-level
- *      vendor → localData transaction-level customer → `transaction.
- *      vendorName` → `transaction.customerName`. Wrapped in a single-
- *      element array so the rest of the matcher stays per-line shaped.
+ *   • localData `lineItemById[*].vendor` / `.customer` — per-line
+ *     vendor/customer the user has tagged in the grid. Populated for
+ *     JEs (where the row reads per-line vendor) and sometimes for
+ *     vendor-typed transactions too (e.g. when an AI vendor
+ *     recommendation lands on a line).
+ *   • Persisted `transaction.lines[*].vendor` / `.customer` — same
+ *     fields on the server snapshot of each line.
+ *   • localData transaction-level `vendor` / `customer` — what the row
+ *     displays for vendor-typed transactions (Bills / Expenses /
+ *     Checks).
+ *   • Top-level `transaction.vendorName` / `customerName` — pre-edit
+ *     server snapshot.
  *
- * Returns `[]` when every source resolves empty; the caller falls back
+ * The function collects names from ALL of these into a single set
+ * rather than picking exclusively from the highest-priority source.
+ * Two reasons:
+ *
+ *   1. Different transaction types put the displayed payee in different
+ *      places. JEs put it on the line; Bills put it at the transaction
+ *      level. A strict-precedence rule that returns early on the first
+ *      non-empty source ends up missing the OTHER place when both have
+ *      data with different values — which is exactly the
+ *      production failure mode that motivated this fix (a Bill whose
+ *      localData line item carried an AI-recommended vendor name was
+ *      excluded because the recommendation won priority over the
+ *      tx-level "Amazon" the row actually displayed).
+ *   2. The single-scalar predecessor missed JE rows entirely because
+ *      it only looked at the tx level. Unioning the line-level sources
+ *      in fixes that without re-introducing the "first source wins"
+ *      brittleness.
+ *
+ * False positives are bounded: a transaction matches `payee = X` only
+ * if `X` literally appears in one of its stored payee fields. Stale
+ * recommendation data being included means the filter is slightly more
+ * lenient than what the row displays, not arbitrary.
+ *
+ * Returns `[]` when no source carries any name; the caller falls back
  * to the absent-value contract (only `not_equal` matches; every other
  * operator excludes).
  */
 const getLinePayeesForTransaction = (transaction) => {
     const localData = transaction?.transactionLocalData?.transactionReviewLocalData;
-    // Priority 1: localData line-level vendor / customer
-    if (localData?.lineItemById != null) {
-        const lineItems = Object.values(localData.lineItemById);
-        if (lineItems.length > 0) {
-            const linePayees = lineItems
-                .map((lineItem) => resolveLineLevelPayee(lineItem?.vendor, lineItem?.customer))
-                .filter(isNonEmptyString);
-            if (linePayees.length > 0) {
-                return linePayees;
-            }
+    // Set used to dedupe — the same vendor name often appears in multiple
+    // sources (e.g. localData mirror of a persisted line) and we don't
+    // want it to be over-counted in the match list. Iteration order is
+    // insertion-order; `.some()` doesn't depend on order so this is fine.
+    const payees = new Set();
+    const addIfPresent = (name) => {
+        if (isNonEmptyString(name)) {
+            payees.add(name);
         }
+    };
+    // localData per-line vendor / customer
+    if (localData?.lineItemById != null) {
+        Object.values(localData.lineItemById).forEach((lineItem) => {
+            addIfPresent(resolveLineLevelPayee(lineItem?.vendor, lineItem?.customer));
+        });
     }
-    // Priority 2: persisted line-level vendor / customer
+    // Persisted per-line vendor / customer (only on the three line
+    // shapes that actually carry them — see `isAccountAndClassLine`).
     if (transaction?.transaction?.lines != null &&
         transaction.transaction.lines.length > 0) {
-        const linePayees = transaction.transaction.lines
-            .map((line) => {
+        transaction.transaction.lines.forEach((line) => {
             if (!isAccountAndClassLine(line)) {
-                return undefined;
+                return;
             }
             const typedLine = line;
-            return resolveLineLevelPayee(typedLine.vendor, typedLine.customer);
-        })
-            .filter(isNonEmptyString);
-        if (linePayees.length > 0) {
-            return linePayees;
-        }
-    }
-    // Priority 3: transaction-level fallback. localData wins over the
-    // top-level fields to keep the existing precedence intact: unsaved
-    // grid edits should drive the filter, not the pre-edit server state.
-    const localVendorName = localData?.vendor?.name;
-    if (isNonEmptyString(localVendorName)) {
-        return [localVendorName];
-    }
-    const localCustomerName = localData?.customer?.name;
-    if (isNonEmptyString(localCustomerName)) {
-        return [localCustomerName];
-    }
-    if (isNonEmptyString(transaction.vendorName)) {
-        return [transaction.vendorName];
-    }
-    if (isNonEmptyString(transaction.customerName)) {
-        return [transaction.customerName];
+            addIfPresent(resolveLineLevelPayee(typedLine.vendor, typedLine.customer));
+        });
     }
-    return [];
+    // Transaction-level: localData first so unsaved grid edits make it
+    // into the match set, then the pre-edit server fields.
+    addIfPresent(localData?.vendor?.name);
+    addIfPresent(localData?.customer?.name);
+    addIfPresent(transaction?.vendorName);
+    addIfPresent(transaction?.customerName);
+    return Array.from(payees);
 };
 /**
  * Resolve the comparable value for a transaction against a given filter field.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.90-betaAR8",
+  "version": "5.0.90-betaAR9",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",