@zeniai/client-epic-state 5.0.90-betaAR6 → 5.0.90-betaAR7

package/lib/esm/view/expenseAutomationView/transactionFilterHelpers.js

@@ -224,21 +224,46 @@ const getCategoryValueForTransaction = (key, transaction) => {
             return undefined;
         }
         case 'payee': {
+            /*
+             * localData wins over the top-level transaction fields. Two reasons:
+             *
+             *   1. Matches what the row renders. `TransactionCategorizationListRow`
+             *      reads `transaction.transactionReviewLocalData.vendor?.name` as
+             *      its canonical payee source — not `transaction.vendorName`. If
+             *      the user has manually picked a vendor in the grid (still
+             *      unsaved), the row updates immediately but the pre-fix filter
+             *      kept comparing against the stale top-level value, so filtering
+             *      "Acme" against a row the user just relabeled to "Acme" would
+             *      silently exclude it.
+             *
+             *   2. Brings payee in line with the other content-bearing fields.
+             *      After this change, every field that has a localData mirror
+             *      (`amount`, `category`, `class`, `payee`) reads localData
+             *      first. The remaining fields (`payment_account_name`,
+             *      `payment_account_type`) don't have a localData equivalent
+             *      yet — when they do, this precedence becomes the universal
+             *      rule.
+             *
+             * vendor is checked before customer at each level — TC transactions
+             * are overwhelmingly expense-side, so vendor is the common case. A
+             * transaction with both a vendor AND a customer locally set is rare
+             * and the existing behavior (vendor wins) is preserved.
+             */
+            const localData = transaction.transactionLocalData?.transactionReviewLocalData;
+            const localVendorName = localData?.vendor?.name;
+            if (isNonEmptyString(localVendorName)) {
+                return localVendorName;
+            }
+            const localCustomerName = localData?.customer?.name;
+            if (isNonEmptyString(localCustomerName)) {
+                return localCustomerName;
+            }
             if (isNonEmptyString(transaction.vendorName)) {
                 return transaction.vendorName;
             }
             if (isNonEmptyString(transaction.customerName)) {
                 return transaction.customerName;
             }
-            const localData = transaction.transactionLocalData?.transactionReviewLocalData;
-            const vendorName = localData?.vendor?.name;
-            if (isNonEmptyString(vendorName)) {
-                return vendorName;
-            }
-            const customerName = localData?.customer?.name;
-            if (isNonEmptyString(customerName)) {
-                return customerName;
-            }
             return undefined;
         }
         case 'payment_account_name': {

package/lib/view/expenseAutomationView/transactionFilterHelpers.js

@@ -227,21 +227,46 @@ const getCategoryValueForTransaction = (key, transaction) => {
             return undefined;
         }
         case 'payee': {
+            /*
+             * localData wins over the top-level transaction fields. Two reasons:
+             *
+             *   1. Matches what the row renders. `TransactionCategorizationListRow`
+             *      reads `transaction.transactionReviewLocalData.vendor?.name` as
+             *      its canonical payee source — not `transaction.vendorName`. If
+             *      the user has manually picked a vendor in the grid (still
+             *      unsaved), the row updates immediately but the pre-fix filter
+             *      kept comparing against the stale top-level value, so filtering
+             *      "Acme" against a row the user just relabeled to "Acme" would
+             *      silently exclude it.
+             *
+             *   2. Brings payee in line with the other content-bearing fields.
+             *      After this change, every field that has a localData mirror
+             *      (`amount`, `category`, `class`, `payee`) reads localData
+             *      first. The remaining fields (`payment_account_name`,
+             *      `payment_account_type`) don't have a localData equivalent
+             *      yet — when they do, this precedence becomes the universal
+             *      rule.
+             *
+             * vendor is checked before customer at each level — TC transactions
+             * are overwhelmingly expense-side, so vendor is the common case. A
+             * transaction with both a vendor AND a customer locally set is rare
+             * and the existing behavior (vendor wins) is preserved.
+             */
+            const localData = transaction.transactionLocalData?.transactionReviewLocalData;
+            const localVendorName = localData?.vendor?.name;
+            if (isNonEmptyString(localVendorName)) {
+                return localVendorName;
+            }
+            const localCustomerName = localData?.customer?.name;
+            if (isNonEmptyString(localCustomerName)) {
+                return localCustomerName;
+            }
             if (isNonEmptyString(transaction.vendorName)) {
                 return transaction.vendorName;
             }
             if (isNonEmptyString(transaction.customerName)) {
                 return transaction.customerName;
             }
-            const localData = transaction.transactionLocalData?.transactionReviewLocalData;
-            const vendorName = localData?.vendor?.name;
-            if (isNonEmptyString(vendorName)) {
-                return vendorName;
-            }
-            const customerName = localData?.customer?.name;
-            if (isNonEmptyString(customerName)) {
-                return customerName;
-            }
             return undefined;
         }
         case 'payment_account_name': {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.90-betaAR6",
+  "version": "5.0.90-betaAR7",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",