@zeniai/client-epic-state 5.0.90-betaAR4 → 5.0.90-betaAR6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (69) hide show
  1. package/lib/entity/approvalRule/approvalRulePayload.d.ts +5 -34
  2. package/lib/entity/approvalRule/approvalRulePayload.js +10 -145
  3. package/lib/entity/approvalRule/approvalRuleSelector.d.ts +1 -25
  4. package/lib/entity/approvalRule/approvalRuleSelector.js +0 -40
  5. package/lib/entity/approvalRule/approvalRuleState.d.ts +7 -59
  6. package/lib/entity/snackbar/snackbarTypes.d.ts +1 -1
  7. package/lib/entity/snackbar/snackbarTypes.js +0 -2
  8. package/lib/epic.d.ts +1 -3
  9. package/lib/epic.js +1 -3
  10. package/lib/esm/entity/approvalRule/approvalRulePayload.js +10 -145
  11. package/lib/esm/entity/approvalRule/approvalRuleSelector.js +0 -35
  12. package/lib/esm/entity/snackbar/snackbarTypes.js +0 -2
  13. package/lib/esm/epic.js +1 -3
  14. package/lib/esm/index.js +5 -7
  15. package/lib/esm/view/expenseAutomationView/transactionFilterHelpers.js +163 -66
  16. package/lib/esm/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  17. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +12 -102
  18. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  19. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  20. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +7 -11
  21. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +4 -13
  22. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +16 -120
  23. package/lib/esm/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  24. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  25. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  26. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +7 -11
  27. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +4 -13
  28. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +11 -76
  29. package/lib/index.d.ts +6 -8
  30. package/lib/index.js +16 -27
  31. package/lib/view/companyTaskManagerView/companyTaskManagerViewReducer.d.ts +2 -2
  32. package/lib/view/companyView/types/cockpitTypes.d.ts +1 -1
  33. package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.d.ts +1 -1
  34. package/lib/view/expenseAutomationView/transactionFilterHelpers.js +163 -66
  35. package/lib/view/people/peopleTypes.d.ts +1 -1
  36. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.d.ts +0 -7
  37. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  38. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.d.ts +3 -14
  39. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +13 -103
  40. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewState.d.ts +0 -16
  41. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  42. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  43. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +6 -10
  44. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +3 -12
  45. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.d.ts +1 -59
  46. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +17 -122
  47. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonState.d.ts +5 -31
  48. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.d.ts +1 -8
  49. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  50. package/lib/view/spendManagement/chargeCards/chargeCardList/chargeCardList.d.ts +1 -1
  51. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  52. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  53. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +6 -10
  54. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +3 -12
  55. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.d.ts +3 -14
  56. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +12 -77
  57. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewState.d.ts +0 -12
  58. package/lib/view/taskManager/taskListView/taskList.d.ts +3 -3
  59. package/lib/view/transactionDetail/journalEntryLinesViewModel.d.ts +1 -1
  60. package/package.json +1 -1
  61. package/lib/entity/approvalRule/approvalRuleConflict.d.ts +0 -56
  62. package/lib/entity/approvalRule/approvalRuleConflict.js +0 -77
  63. package/lib/esm/entity/approvalRule/approvalRuleConflict.js +0 -74
  64. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -54
  65. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -49
  66. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.d.ts +0 -23
  67. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -58
  68. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.d.ts +0 -14
  69. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -53
@@ -1,48 +1,20 @@
1
1
  export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
2
- // Form-side criteria is a structured object with optional slots for
3
- // amount / vendor / department; flatten it into the wire format's
4
- // `conditions[]` array.
5
- let criteriaPayload;
2
+ let criteriaPayload = [];
6
3
  if (approverViewUpdateData.criteria != null) {
7
- const { amount, vendor, department } = approverViewUpdateData.criteria;
8
- const conditions = [];
9
- if (amount?.min != null) {
10
- conditions.push({
11
- field: 'amount',
12
- type: 'gte',
13
- value: amount.min.amount,
14
- });
15
- }
16
- if (amount?.max != null) {
17
- conditions.push({
18
- field: 'amount',
19
- type: 'lte',
20
- value: amount.max.amount,
21
- });
22
- }
23
- if (vendor != null && vendor.vendorIds.length > 0) {
24
- conditions.push({
25
- field: 'vendor_id',
26
- type: vendor.operator === 'is_not' ? 'not_in' : 'in',
27
- value: vendor.vendorIds,
28
- });
29
- }
30
- if (department != null && department.departmentIds.length > 0) {
31
- conditions.push({
32
- field: 'department_id',
33
- type: department.operator === 'is_not' ? 'not_in' : 'in',
34
- value: department.departmentIds,
35
- });
36
- }
37
- if (conditions.length > 0) {
38
- const currency = amount?.min ?? amount?.max ?? null;
39
- criteriaPayload = {
40
- conditions,
41
- criteria_operator: 'and',
42
- currency_code: currency?.currencyCode ?? 'USD',
43
- currency_symbol: currency?.currencySymbol ?? '$',
44
- };
45
- }
4
+ const criteria = approverViewUpdateData.criteria;
5
+ const { rangeType, rangeEntity, range } = criteria;
6
+ const { min, max } = range;
7
+ const { currencyCode, currencySymbol } = min;
8
+ criteriaPayload = [
9
+ {
10
+ type: rangeType,
11
+ range_entity: rangeEntity,
12
+ min: min.amount,
13
+ max: max?.amount ?? null,
14
+ currency_code: currencyCode,
15
+ currency_symbol: currencySymbol,
16
+ },
17
+ ];
46
18
  }
47
19
  const steps = approverViewUpdateData.steps.map((step) => {
48
20
  return {
@@ -63,86 +35,10 @@ export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
63
35
  });
64
36
  const isUpdate = approverViewUpdateData.approvalRuleId != null;
65
37
  const payload = {
38
+ criteria: criteriaPayload,
66
39
  steps,
67
40
  is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
68
41
  };
69
- if (criteriaPayload != null) {
70
- payload.criteria = criteriaPayload;
71
- }
72
- // Approval Rules 3.0 — surface rule-level fields when the form set them.
73
- // Send only what the user actually entered: an undefined value means
74
- // "no opinion" and stays off the wire.
75
- if (approverViewUpdateData.name != null) {
76
- payload.name = approverViewUpdateData.name;
77
- }
78
- if (approverViewUpdateData.description != null) {
79
- payload.description = approverViewUpdateData.description;
80
- }
81
- if (approverViewUpdateData.separationOfDuties != null) {
82
- payload.is_separation_of_duty_enabled =
83
- approverViewUpdateData.separationOfDuties;
84
- }
85
- if (approverViewUpdateData.isFallback != null) {
86
- payload.is_fallback = approverViewUpdateData.isFallback;
87
- }
88
- if (isUpdate) {
89
- payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
90
- }
91
- return payload;
92
- };
93
- /**
94
- * V1 wire mapper — used when 'approval_rule_v3_config' resolves to OFF
95
- * for the current tenant. Emits the legacy snake_case array shape that
96
- * '/approval-rules' historically consumed (see the V1 fixture in
97
- * 'entity/entityApprovalStatus/__mocks__/json/entityApprovalStatusPayload.json'):
98
- * criteria: [{type: 'range', range_entity: 'currency', min, max,
99
- * currency_code, currency_symbol}]
100
- *
101
- * Open-ended semantics are preserved on the wire: an absent 'min' or
102
- * 'max' is sent as 'null' rather than synthesised to '0' or
103
- * 'MAX_SAFE_INTEGER', so a 'greater_than' / 'less_than' rule stays
104
- * one-sided after rollback rather than collapsing into a closed range.
105
- *
106
- * The V1 backend does not understand vendor / department criteria or
107
- * the rule-level 3.0 fields, so those are dropped on the wire.
108
- */
109
- export const toApprovalChangableInfoPayloadV1 = (approverViewUpdateData) => {
110
- const amount = approverViewUpdateData.criteria?.amount;
111
- const minAmount = amount?.min;
112
- const maxAmount = amount?.max;
113
- const currencyCode = minAmount?.currencyCode ?? maxAmount?.currencyCode ?? 'USD';
114
- const currencySymbol = minAmount?.currencySymbol ?? maxAmount?.currencySymbol ?? '$';
115
- const steps = approverViewUpdateData.steps.map((step) => {
116
- return {
117
- action: step.action,
118
- operator: step.operator,
119
- actors: step.actors
120
- .filter((actor) => actor.subType !== 'admin')
121
- .map((actor) => {
122
- return {
123
- type: actor.type,
124
- id: actor.userId ?? null,
125
- sub_type: actor.subType ?? null,
126
- id_type: actor.idType ?? null,
127
- is_implicit_actor: actor.isImplicitActor ?? false,
128
- };
129
- }),
130
- };
131
- });
132
- const isUpdate = approverViewUpdateData.approvalRuleId != null;
133
- const criteriaEntry = {
134
- type: 'range',
135
- range_entity: 'currency',
136
- min: minAmount?.amount ?? null,
137
- max: maxAmount?.amount ?? null,
138
- currency_code: currencyCode,
139
- currency_symbol: currencySymbol,
140
- };
141
- const payload = {
142
- steps,
143
- is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
144
- criteria: [criteriaEntry],
145
- };
146
42
  if (isUpdate) {
147
43
  payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
148
44
  }
@@ -1,6 +1,5 @@
1
1
  import recordGet from 'lodash/get';
2
2
  import has from 'lodash/has';
3
- import { getAmountCriteria, getDepartmentCriteria, getVendorCriteria, } from '../../../../entity/approvalRule/approvalRuleSelector';
4
3
  import { reduceFetchState } from '../../../../commonStateTypes/reduceFetchState';
5
4
  import { getBankAccountByBankAccountId, getBankAccountsByBankAccountIds, } from '../../../../entity/bankAccount/bankAccountSelector';
6
5
  import { getContactById, getContactsByIds, } from '../../../../entity/billPay/contact/contactSelector';
@@ -357,14 +356,6 @@ export const getEditBillDetail = (state, isVendorRecommendationFeatureEnabled, i
357
356
  isDeleted,
358
357
  showAutofill,
359
358
  addBillAutoFields,
360
- // Bill-level accounting class. Approval Rules 3.0 'department'
361
- // criteria match against this. Lives on BillTransaction; not on
362
- // any sub-section. Empty-string is normalised to 'undefined'
363
- // so downstream readers treat "no class" uniformly regardless
364
- // of whether the wire used '' or omitted the field.
365
- classId: transaction?.classId != null && transaction.classId !== ''
366
- ? transaction.classId
367
- : undefined,
368
359
  billStage,
369
360
  deleteStatus,
370
361
  billActivities,
@@ -687,59 +678,12 @@ export const getDefaultWithdrawFromAccount = (state, depositAccounts, companyId,
687
678
  }
688
679
  return undefined;
689
680
  };
690
- export const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser, billVendorId, billDepartmentId) => {
681
+ export const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser) => {
691
682
  let isCreatorAlsoApprover = false;
692
- // Approval Rules 3.0 — a rule applies to a bill only when all of
693
- // its present criteria are satisfied. Criteria not declared on
694
- // the rule are treated as "no narrowing on this axis".
695
- //
696
- // Strict-match semantics for vendor / department: if the rule
697
- // narrows by an axis but the bill has no value on that axis, the
698
- // rule does NOT apply (an absent bill-side value can't satisfy
699
- // either 'is' or 'is_not'). Amount is always present on a rule
700
- // (the form enforces this), but bounds may be one-sided.
701
683
  const approvalRule = approvalRules.find((rule) => {
702
- const vendorCriteria = getVendorCriteria(rule.criteria);
703
- if (vendorCriteria != null) {
704
- if (billVendorId == null) {
705
- return false;
706
- }
707
- const includesVendor = vendorCriteria.vendorIds.includes(billVendorId);
708
- if (vendorCriteria.operator === 'is' && !includesVendor) {
709
- return false;
710
- }
711
- if (vendorCriteria.operator === 'is_not' && includesVendor) {
712
- return false;
713
- }
714
- }
715
- const departmentCriteria = getDepartmentCriteria(rule.criteria);
716
- if (departmentCriteria != null) {
717
- if (billDepartmentId == null) {
718
- return false;
719
- }
720
- const includesDepartment = departmentCriteria.departmentIds.includes(billDepartmentId);
721
- if (departmentCriteria.operator === 'is' && !includesDepartment) {
722
- return false;
723
- }
724
- if (departmentCriteria.operator === 'is_not' && includesDepartment) {
725
- return false;
726
- }
727
- }
728
- const amountCriteria = getAmountCriteria(rule.criteria);
729
- if (amountCriteria == null) {
730
- // The form guarantees an amount criterion on every rule, so
731
- // this branch is defensive against backend drift. Keep
732
- // pre-3.0 behaviour: a rule that doesn't declare amount
733
- // doesn't participate here.
734
- return false;
735
- }
736
- // Bounds use the wire's inclusive 'gte' / 'lte' semantics, and
737
- // either side may be absent for a one-sided 'greater_than' /
738
- // 'less_than' rule.
739
- const { min, max } = amountCriteria;
740
- const matchesMin = min == null || billAmount >= min.amount;
741
- const matchesMax = max == null || billAmount <= max.amount;
742
- return matchesMin && matchesMax;
684
+ const { max, min } = rule.criteria[0].range;
685
+ return (billAmount > min.amount &&
686
+ (max?.amount != null ? billAmount <= max?.amount : true));
743
687
  });
744
688
  if (approvalRule != null) {
745
689
  const requireApprovalSteps = approvalRule.steps.filter((step) => step.action === 'require_approval');
@@ -6,17 +6,9 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { deleteRemiApprovalRule, deleteRemiApprovalRuleFailure, deleteRemiApprovalRuleSuccess, } from '../remiSetupApproverViewReducer';
8
8
  export const deleteRemiApprovalRuleEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(deleteRemiApprovalRule.match), switchMap((action) => {
9
- const { approvalRuleId, useV3 } = action.payload;
10
- // Approval Rules 3.0 — flag-gated endpoint selection.
11
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
12
- // when RTK's payload type widens to `any` in some configs.
13
- const endpoint = useV3 === true
14
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
15
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
9
+ const { approvalRuleId } = action.payload;
16
10
  return zeniAPI
17
- .deleteAndGetJSON(endpoint, {
18
- approval_rule_id: approvalRuleId,
19
- })
11
+ .deleteAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`, { approval_rule_id: approvalRuleId })
20
12
  .pipe(mergeMap((response) => {
21
13
  if (isSuccessResponse(response) && response.data != null) {
22
14
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -6,7 +6,7 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { fetchRemiSetupApproverView, fetchRemiSetupApproverViewFailure, fetchRemiSetupApproverViewSuccess, } from '../remiSetupApproverViewReducer';
8
8
  export const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchRemiSetupApproverView.match), switchMap((action) => {
9
- const { cacheOverride, resolveAttributeToUser, includeImplicitActors, useV3, } = action.payload;
9
+ const { cacheOverride, resolveAttributeToUser, includeImplicitActors } = action.payload;
10
10
  const { remiSetupApproverViewState, approvalRuleState } = state$.value;
11
11
  const approvalRules = getApprovalRulesByIds(approvalRuleState, remiSetupApproverViewState.approvalRuleIds);
12
12
  if (cacheOverride === true ||
@@ -14,14 +14,8 @@ export const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => act
14
14
  remiSetupApproverViewState.approvalRuleIds.length ||
15
15
  (remiSetupApproverViewState.hasValidState() === false &&
16
16
  remiSetupApproverViewState.fetchState !== 'In-Progress')) {
17
- // Approval Rules 3.0 — flag-gated endpoint selection.
18
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
19
- // when RTK's payload type widens to `any` in some configs.
20
- const basePath = useV3 === true
21
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
22
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
23
17
  return zeniAPI
24
- .getJSON(`${basePath}?query={"is_include_implicit_actors": ${includeImplicitActors}, "is_resolve_attribute_to_user":${resolveAttributeToUser}}`)
18
+ .getJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules?query={"is_include_implicit_actors": ${includeImplicitActors}, "is_resolve_attribute_to_user":${resolveAttributeToUser}}`)
25
19
  .pipe(mergeMap((response) => {
26
20
  if (isSuccessResponse(response) && response.data != null) {
27
21
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -1,6 +1,6 @@
1
1
  import { from } from 'rxjs';
2
2
  import { filter, mergeMap } from 'rxjs/operators';
3
- import { getAmountCriteria, getApprovalRuleById, getDepartmentCriteria, getVendorCriteria, } from '../../../../../entity/approvalRule/approvalRuleSelector';
3
+ import { getApprovalRuleById } from '../../../../../entity/approvalRule/approvalRuleSelector';
4
4
  import { clearRemiSetupApproverViewUpdateData, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, } from '../remiSetupApproverViewReducer';
5
5
  export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$) => actions$.pipe(filter(initializeRemiSetupApproverViewUpdateData.match), mergeMap((action) => {
6
6
  const { approvalRuleId } = action.payload;
@@ -8,20 +8,16 @@ export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$)
8
8
  if (approvalRuleId != null) {
9
9
  const approvalRule = getApprovalRuleById(state$.value.approvalRuleState, approvalRuleId);
10
10
  if (approvalRule != null) {
11
+ const criteria = approvalRule.criteria[0];
12
+ const range = criteria?.range;
11
13
  const remiSetupApproverViewUpdateData = {
12
14
  approvalRuleId,
13
15
  steps: approvalRule.steps,
14
16
  criteria: {
15
- amount: getAmountCriteria(approvalRule.criteria),
16
- vendor: getVendorCriteria(approvalRule.criteria),
17
- department: getDepartmentCriteria(approvalRule.criteria),
17
+ rangeType: criteria?.rangeType,
18
+ rangeEntity: criteria?.rangeEntity,
19
+ range,
18
20
  },
19
- // Approval Rules 3.0 — seed rule-level fields so the form can
20
- // round-trip them on edit. Each may be undefined on legacy rules.
21
- name: approvalRule.name,
22
- description: approvalRule.description,
23
- separationOfDuties: approvalRule.separationOfDuties,
24
- isFallback: approvalRule.isFallback,
25
21
  };
26
22
  fetchActions.push(clearRemiSetupApproverViewUpdateData(), saveRemiSetupApproverViewUpdateData(remiSetupApproverViewUpdateData));
27
23
  }
@@ -29,7 +25,7 @@ export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$)
29
25
  else {
30
26
  const remiSetupApproverViewCreateData = {
31
27
  steps: [],
32
- criteria: {},
28
+ criteria: undefined,
33
29
  };
34
30
  fetchActions.push(clearRemiSetupApproverViewUpdateData(), saveRemiSetupApproverViewUpdateData(remiSetupApproverViewCreateData));
35
31
  }
@@ -4,25 +4,16 @@ import { updateApprovalRules } from '../../../../../entity/approvalRule/approval
4
4
  import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
5
5
  import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
- import { toApprovalChangableInfoPayload, toApprovalChangableInfoPayloadV1, } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
7
+ import { toApprovalChangableInfoPayload } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
8
8
  import { saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesFailure, saveRemiSetupApproverViewUpdatesSuccess, } from '../remiSetupApproverViewReducer';
9
- export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap((action) => {
9
+ export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap(() => {
10
10
  const { remiSetupApproverViewState } = state$.value;
11
11
  const remiSetupApproverViewUpdateData = remiSetupApproverViewState.remiSetupApproverViewUpdateData;
12
12
  if (remiSetupApproverViewUpdateData != null &&
13
13
  remiSetupApproverViewUpdateData.data != null) {
14
- // Approval Rules 3.0 — gate URL + write-side payload mapper on
15
- // the `approval_rule_v3_config` dynamic config. `useV3` arrives
16
- // on the action payload from the screen connector.
17
- const { useV3 } = action.payload;
18
- const payload = useV3
19
- ? toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data)
20
- : toApprovalChangableInfoPayloadV1(remiSetupApproverViewUpdateData.data);
21
- const endpoint = useV3
22
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
23
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
14
+ const payload = toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data);
24
15
  return zeniAPI
25
- .postAndGetJSON(endpoint, payload)
16
+ .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`, payload)
26
17
  .pipe(mergeMap((response) => {
27
18
  if (isSuccessResponse(response) && response.data != null) {
28
19
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -13,7 +13,6 @@ export const initialState = {
13
13
  newApprovalRuleId: undefined,
14
14
  approvalRulesDeleteStatusById: {},
15
15
  remiSetupApproverViewUpdateData: undefined,
16
- reorderStatus: { fetchState: 'Not-Started', error: undefined },
17
16
  hasValidState() {
18
17
  return this.fetchState === 'Completed';
19
18
  },
@@ -27,16 +26,12 @@ const remiSetupApproverView = createSlice({
27
26
  draft.fetchState = 'In-Progress';
28
27
  draft.error = undefined;
29
28
  },
30
- // Approval Rules 3.0 `useV3` arrives from the screen connector
31
- // (`approval_rule_v3_config` dynamic config) and picks v1 vs v2
32
- // endpoint in the fetch epic.
33
- prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false, useV3 = false) {
29
+ prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false) {
34
30
  return {
35
31
  payload: {
36
32
  cacheOverride,
37
33
  resolveAttributeToUser,
38
34
  includeImplicitActors,
39
- useV3,
40
35
  },
41
36
  };
42
37
  },
@@ -139,11 +134,8 @@ const remiSetupApproverView = createSlice({
139
134
  error: undefined,
140
135
  };
141
136
  },
142
- // Approval Rules 3.0 — `useV3` flows from the screen connector
143
- // (`approval_rule_v3_config` dynamic config) so the delete epic
144
- // can pick the v1 vs v2 endpoint.
145
- prepare(approvalRuleId, useV3 = false) {
146
- return { payload: { approvalRuleId, useV3 } };
137
+ prepare(approvalRuleId) {
138
+ return { payload: { approvalRuleId } };
147
139
  },
148
140
  },
149
141
  deleteRemiApprovalRuleSuccess: {
@@ -175,70 +167,13 @@ const remiSetupApproverView = createSlice({
175
167
  };
176
168
  },
177
169
  },
178
- /**
179
- * Approval Rules 3.0 list-page drag-and-drop reorder.
180
- * See BillPay equivalent for the longer rationale.
181
- */
182
- reorderRemiApprovalRules: {
183
- reducer(draft, action) {
184
- const { approvalRuleIds } = action.payload;
185
- const wasReorderInFlight = draft.reorderStatus.fetchState === 'In-Progress';
186
- draft.reorderStatus = { fetchState: 'In-Progress', error: undefined };
187
- // Stash the pre-reorder order for synchronous rollback on
188
- // 'Failure'. See the BillPay reducer for the rationale,
189
- // including the in-flight guard: a second drag before the
190
- // first PUT lands must not overwrite the snapshot.
191
- if (!wasReorderInFlight) {
192
- draft.reorderRollbackIds = draft.approvalRuleIds;
193
- }
194
- draft.approvalRuleIds = approvalRuleIds;
195
- },
196
- prepare(approvalRuleIds, useV3 = false) {
197
- return { payload: { approvalRuleIds, useV3 } };
198
- },
199
- },
200
- reorderRemiApprovalRulesSuccess: {
201
- reducer(draft, action) {
202
- const { approvalRuleIds } = action.payload;
203
- draft.reorderStatus = { fetchState: 'Completed', error: undefined };
204
- draft.approvalRuleIds = approvalRuleIds;
205
- draft.reorderRollbackIds = undefined;
206
- },
207
- prepare(approvalRuleIds) {
208
- return { payload: { approvalRuleIds } };
209
- },
210
- },
211
- reorderRemiApprovalRulesFailure: {
212
- reducer(draft, action) {
213
- const { status } = action.payload;
214
- draft.reorderStatus = { fetchState: 'Error', error: status };
215
- if (draft.reorderRollbackIds != null) {
216
- draft.approvalRuleIds = draft.reorderRollbackIds;
217
- draft.reorderRollbackIds = undefined;
218
- }
219
- },
220
- prepare(status) {
221
- return { payload: { status } };
222
- },
223
- },
224
- saveRemiSetupApproverViewUpdates: {
225
- // Approval Rules 3.0 — `useV3` sourced from
226
- // `approval_rule_v3_config` dynamic config in the screen
227
- // connector; epic uses it to pick v1 vs v2 URL + mapper. The
228
- // reducer doesn't read the action but the parameter must be
229
- // declared so the action payload type carries downstream.
230
- // eslint-disable-next-line @typescript-eslint/no-unused-vars
231
- reducer(draft, _action) {
232
- if (draft.remiSetupApproverViewUpdateData != null) {
233
- draft.remiSetupApproverViewUpdateData.updateStatus = {
234
- fetchState: 'In-Progress',
235
- error: undefined,
236
- };
237
- }
238
- },
239
- prepare(useV3) {
240
- return { payload: { useV3 } };
241
- },
170
+ saveRemiSetupApproverViewUpdates(draft) {
171
+ if (draft.remiSetupApproverViewUpdateData != null) {
172
+ draft.remiSetupApproverViewUpdateData.updateStatus = {
173
+ fetchState: 'In-Progress',
174
+ error: undefined,
175
+ };
176
+ }
242
177
  },
243
178
  saveRemiSetupApproverViewUpdatesSuccess: {
244
179
  reducer(draft, action) {
@@ -327,5 +262,5 @@ const remiSetupApproverView = createSlice({
327
262
  },
328
263
  },
329
264
  });
330
- export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, reorderRemiApprovalRules, reorderRemiApprovalRulesSuccess, reorderRemiApprovalRulesFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
265
+ export const { fetchRemiSetupApproverView, fetchRemiSetupApproverViewSuccess, fetchRemiSetupApproverViewFailure, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiApproversListSuccess, fetchRemiApproversListFailure, deleteRemiApprovalRule, deleteRemiApprovalRuleSuccess, deleteRemiApprovalRuleFailure, saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesSuccess, saveRemiSetupApproverViewUpdatesFailure, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, setListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, } = remiSetupApproverView.actions;
331
266
  export default remiSetupApproverView.reducer;
package/lib/index.d.ts CHANGED
@@ -52,9 +52,7 @@ import { AccountReconciliationEntity, getAccountReconByAccountIdAndSelectedPerio
52
52
  import { BalanceDataStatusCodeType, BankStatusCodeType, RecommendedActionCodeType, ReconciliationStatusCodeType, StatementDataStatusCodeType, StatementStatusCodeType, TransactionsToReview } from './entity/accountRecon/accountReconState';
53
53
  import { getAddressByAddressId } from './entity/address/addressSelector';
54
54
  import { Address } from './entity/address/addressState';
55
- import { Actor, ActorType, AmountComparator, AmountCriteria, ApprovalActionType, ApprovalRule, ApprovalRuleState, Approvers, AttributeType, ConditionType, Criteria, DepartmentCriteria, RoleType, Step, StepOperatorType, VendorCriteria, toAttributeOrRoleTypeStrict, toAttributeTypeStrict, toRoleTypeStrict } from './entity/approvalRule/approvalRuleState';
56
- import { getAmountCriteria, getApprovalRulesByEntityType, getDepartmentCriteria, getFallbackApprovalRule, getVendorCriteria } from './entity/approvalRule/approvalRuleSelector';
57
- import { DetectRuleOverlapInput, RuleForOverlapCheck, RuleOverlap, detectRuleOverlap } from './entity/approvalRule/approvalRuleConflict';
55
+ import { Actor, ActorType, ApprovalActionType, ApprovalRule, ApprovalRuleState, Approvers, AttributeType, RoleType, Step, StepOperatorType, toAttributeOrRoleTypeStrict, toAttributeTypeStrict, toRoleTypeStrict } from './entity/approvalRule/approvalRuleState';
58
56
  import { BankAccount } from './entity/bankAccount/bankAccount';
59
57
  import { BillPayInfo, BillPaymentRefundStatus, BillPaymentRefundStatusCodeType, BillPaymentStatus, BillPaymentStatusCodeType, BillStage, BillStageCodeType, BillStatus, BillStatusCodeType, BillTransaction, DeletionSourceType, InternationalTransferFeeBearerPaymentMethod, toOutsideZeniPaymentModeType } from './entity/billPay/billTransaction/billTransactionState';
60
58
  import { Contact } from './entity/billPay/contact/contact';
@@ -422,7 +420,7 @@ import { getInternationalSubConfigCodeKey } from './view/spendManagement/billPay
422
420
  import { AccountTypeSubConfigCodeKeyType, BILL_NEW_PAYMENT_METHODS, BillPayConfig, BillPaymentConfigCodeType, BillPaymentSubConfigCodeType, InternationalSubConfigCodeType, LOCAL_CURRENCY_INTERNATIONAL_METHOD_SUBTEXT, NEW_INTERNATIONAL_METHOD_SUBTEXT, SWIFT_OUR_INTERNATIONAL_METHOD_SUBTEXT, VendorCurrency } from './view/spendManagement/billPay/billPayConfig/billPayConfigState';
423
421
  import { clearBillPayReview, fetchDuplicateBill } from './view/spendManagement/billPay/billPayReview/billPayReviewReducer';
424
422
  import { BillPayReviewSelectorView, DuplicateBillsSelectorView, getReviewPageBillDetail } from './view/spendManagement/billPay/billPayReview/billPayReviewSelector';
425
- import { clearBillPaySetupApproverView, clearBillPaySetupApproverViewUpdateData, deleteBillPayApprovalRule, fetchBillPayApproversDetails, fetchBillPayApproversList, fetchBillPaySetupApproverView, initializeBillPaySetupApproverViewUpdateData, reorderBillPayApprovalRules, saveBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdates, setListeningToPusherEvent as setBillsSetupApproverViewListeningToPusherEvent } from './view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer';
423
+ import { clearBillPaySetupApproverView, clearBillPaySetupApproverViewUpdateData, deleteBillPayApprovalRule, fetchBillPayApproversDetails, fetchBillPayApproversList, fetchBillPaySetupApproverView, initializeBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdates, setListeningToPusherEvent as setBillsSetupApproverViewListeningToPusherEvent } from './view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer';
426
424
  import { getBillPaySetupApproverUpdateDataView, getBillPaySetupApproverView } from './view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewSelector';
427
425
  import { ApprovalRuleWithUser as BillPayApprovalRuleWithUser, BillPaySetupApproverUpdateDataView, BillPaySetupApproverView } from './view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewSelectorTypes';
428
426
  import { BillPaySetupApproverViewState } from './view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewState';
@@ -502,7 +500,7 @@ import { RemiListDownloadReport, getRemiDownloadList } from './view/spendManagem
502
500
  import { fetchRemiList, fetchRemiListPerTab, updateRemiDetailSaveRemiCode, updateRemiListDownloadUIState, updateFilterResult as updateRemiListFilterResult, updateSearchResult as updateRemiListSearchResult, updateSubTab as updateRemiListSubTab, updateTab as updateRemiListTab, updateRemiListUIState } from './view/spendManagement/reimbursement/remiListView/remiListReducer';
503
501
  import { ReimbursementView, RemiListReport, getRemiList } from './view/spendManagement/reimbursement/remiListView/remiListSelector';
504
502
  import { REIMBURSEMENT_FILTER_CATEGORIES, REIMBURSEMENT_FILTER_CATEGORIES_RESTRICTED, ReimbursementFilterCategory, ReimbursementFilters, ReimbursementViewSortKey, RemiBulkSelectExceptionInfoType, RemiListUIState, RemiListViewFilterCategoryField, RemiSubTabType, RemiTabType, toRemiSubTabType, toRemiSubTabTypeStrict, toRemiTabType, toRemiTabTypeStrict } from './view/spendManagement/reimbursement/remiListView/remiListState';
505
- import { clearRemiSetupApproverView, clearRemiSetupApproverViewUpdateData, deleteRemiApprovalRule, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiSetupApproverView, initializeRemiSetupApproverViewUpdateData, reorderRemiApprovalRules, saveRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdates, setListeningToPusherEvent as setRemiSetupApproverViewListeningToPusherEvent } from './view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer';
503
+ import { clearRemiSetupApproverView, clearRemiSetupApproverViewUpdateData, deleteRemiApprovalRule, fetchRemiApproversDetails, fetchRemiApproversList, fetchRemiSetupApproverView, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdates, setListeningToPusherEvent as setRemiSetupApproverViewListeningToPusherEvent } from './view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer';
506
504
  import { getRemiSetupApproverUpdateDataView, getRemiSetupApproverView } from './view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewSelector';
507
505
  import { ApprovalRuleWithUser as RemiApprovalRuleWithUser, RemiSetupApproverUpdateDataView, RemiSetupApproverView } from './view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewSelectorTypes';
508
506
  import { RemiSetupApproverViewState } from './view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewState';
@@ -812,9 +810,9 @@ export { RemiSetupViewState, RemiSetupViewLocalData, MileageDetailsLocalData, Mi
812
810
  export { PaymentAccount, Logo, VERIFIED_PAYMENT_ACCOUNT_PROVIDER_VERIFICATION_STATUS, };
813
811
  export { SubscriptionPaymentAccount };
814
812
  export { PreviousBillsSelectorView, InvoiceProcessingPayload, InvoiceProcessingResponse, isSuccessResponse, isInvalidSessionError, isAccessDeniedError, };
815
- export { Step, Actor as ApprovalRuleActor, ActorType, ApprovalActionType, StepOperatorType, ApprovalRuleState, ApprovalRule, AmountComparator, AmountCriteria, ConditionType, Criteria, DepartmentCriteria, VendorCriteria, AttributeType, Approvers, RoleType, EntityApprovalStatusState, EntityApprovalStatus, SpendManagementEntityType, SpendManagementEntityTypeWithOtherConnection, getAmountCriteria, getApprovalRulesByEntityType, getDepartmentCriteria, getFallbackApprovalRule, getVendorCriteria, toAttributeTypeStrict, toAttributeOrRoleTypeStrict, toRoleTypeStrict, DetectRuleOverlapInput, RuleForOverlapCheck, RuleOverlap, detectRuleOverlap, };
816
- export { ApprovalRuleUpdateData, ApprovalRuleCreateData, BillPayApprovalRuleWithUser, ApprovalUpdateActionType, ApproverViewUpdateData, BillPaySetupApproverViewState, BillPaySetupApproverView, BillPaySetupApproverUpdateDataView, getBillPaySetupApproverView, getBillPaySetupApproverUpdateDataView, fetchBillPaySetupApproverView, fetchBillPayApproversDetails, fetchBillPayApproversList, deleteBillPayApprovalRule, reorderBillPayApprovalRules, saveBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdates, setBillsSetupApproverViewListeningToPusherEvent, initializeBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverView, };
817
- export { RemiApprovalRuleWithUser, RemiSetupApproverViewState, RemiSetupApproverView, RemiSetupApproverUpdateDataView, getRemiSetupApproverView, getRemiSetupApproverUpdateDataView, fetchRemiSetupApproverView, fetchRemiApproversList, fetchRemiApproversDetails, deleteRemiApprovalRule, reorderRemiApprovalRules, saveRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdates, initializeRemiSetupApproverViewUpdateData, setRemiSetupApproverViewListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, };
813
+ export { Step, Actor as ApprovalRuleActor, ActorType, ApprovalActionType, StepOperatorType, ApprovalRuleState, ApprovalRule, AttributeType, Approvers, RoleType, EntityApprovalStatusState, EntityApprovalStatus, SpendManagementEntityType, SpendManagementEntityTypeWithOtherConnection, toAttributeTypeStrict, toAttributeOrRoleTypeStrict, toRoleTypeStrict, };
814
+ export { ApprovalRuleUpdateData, ApprovalRuleCreateData, BillPayApprovalRuleWithUser, ApprovalUpdateActionType, ApproverViewUpdateData, BillPaySetupApproverViewState, BillPaySetupApproverView, BillPaySetupApproverUpdateDataView, getBillPaySetupApproverView, getBillPaySetupApproverUpdateDataView, fetchBillPaySetupApproverView, fetchBillPayApproversDetails, fetchBillPayApproversList, deleteBillPayApprovalRule, saveBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdates, setBillsSetupApproverViewListeningToPusherEvent, initializeBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverView, };
815
+ export { RemiApprovalRuleWithUser, RemiSetupApproverViewState, RemiSetupApproverView, RemiSetupApproverUpdateDataView, getRemiSetupApproverView, getRemiSetupApproverUpdateDataView, fetchRemiSetupApproverView, fetchRemiApproversList, fetchRemiApproversDetails, deleteRemiApprovalRule, saveRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdates, initializeRemiSetupApproverViewUpdateData, setRemiSetupApproverViewListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, };
818
816
  export { RemiDetailViewSelector, getRemiDetailView, RemiActivity, RemiDetails, checkApproveRejectBtnShowForRemi, };
819
817
  export { RemiApprovalType, RemiDetailView, DuplicateLine };
820
818
  export { saveRealTimeApproval, updateIsEditModeRealTimeApprovals, RealTimeApprovalDetailLocalData, RealTimeStepsData, };