@zeniai/client-epic-state 5.0.81-betaAK1 → 5.0.81-betaAK3

package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.js

@@ -1,12 +1,29 @@
 import { zeroAmount } from '../../../../commonStateTypes/amount';
 import { reduceAllFetchState } from '../../../../commonStateTypes/reduceFetchState';
 import { getUpcomingPaymentEventsByIds } from '../../../../entity/upcomingPaymentEvent/upcomingPaymentEventSelector';
+/**
+ * Default account type used when the recommend payload has no movement to
+ * expose yet (e.g. before the first fetch resolves). Callers that care about
+ * the movement should also gate on `fetchState === 'Completed'`.
+ */
+const DEFAULT_BANK_ACCOUNT_TYPE = 'deposit_account';
+const DEFAULT_SUB_MOVEMENT_TYPE = 'push';
 export const getCashManagementOverviewBanner = (state) => {
     const { banner } = state.cashManagementOverviewState;
+    // The banner today surfaces a single recommended movement (the first one
+    // returned by the agent). When the agent returns multiple groups/movements
+    // we'll need to broaden this — for now consumers only render one.
+    const movement = banner.data?.moneyMovements[0]?.movements[0];
     return {
         fetchState: banner.fetchState,
         error: banner.error,
-        data: banner.data,
+        amount: movement?.amount ?? zeroAmount(),
+        destinationBankAccountId: movement?.destinationBankAccountId ?? '',
+        destinationBankAccountType: movement?.destinationBankAccountType ?? DEFAULT_BANK_ACCOUNT_TYPE,
+        reasoning: movement?.reasoning ?? '',
+        sourceBankAccountId: movement?.sourceBankAccountId ?? '',
+        sourceBankAccountType: movement?.sourceBankAccountType ?? DEFAULT_BANK_ACCOUNT_TYPE,
+        subMovementType: movement?.subMovementType ?? DEFAULT_SUB_MOVEMENT_TYPE,
         version: 0,
     };
 };
@@ -41,7 +58,6 @@ export const getCashManagementOverview = (state) => {
     const totalCash = addAmounts(treasuryBalance, cashBalance);
     return {
         banner: getCashManagementOverviewBanner(state),
-        bannerFetchState,
         cashBalance,
         horizonDays: cashManagementOverviewState.upcomingPaymentEvents.horizonDays,
         outflowEvents: getUpcomingPaymentEventsByIds(state.upcomingPaymentEventState, cashManagementOverviewState.upcomingPaymentEvents.eventIds),

package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.d.ts

@@ -3,13 +3,11 @@ import { FetchStateAndError } from '../../../../commonStateTypes/common';
 import { SelectorView } from '../../../../commonStateTypes/viewAndReport/viewAndReport';
 import { UpcomingPaymentEvent } from '../../../../entity/upcomingPaymentEvent/upcomingPaymentEventState';
 import { RootState } from '../../../../reducer';
-import { CashManagementBannerData } from './cashManagementOverviewState';
-export interface CashManagementOverviewBannerSelectorView extends SelectorView {
-    data?: CashManagementBannerData;
+import { CashManagementMovement } from './cashManagementOverviewState';
+export interface CashManagementOverviewBannerSelectorView extends SelectorView, CashManagementMovement {
 }
 export interface CashManagementOverviewSelectorView extends SelectorView {
     banner: CashManagementOverviewBannerSelectorView;
-    bannerFetchState: FetchStateAndError;
     cashBalance: Amount;
     horizonDays: number;
     outflowEvents: UpcomingPaymentEvent[];

package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.js

@@ -4,12 +4,29 @@ exports.getCashManagementOverview = exports.getCashManagementOverviewBanner = vo
 const amount_1 = require("../../../../commonStateTypes/amount");
 const reduceFetchState_1 = require("../../../../commonStateTypes/reduceFetchState");
 const upcomingPaymentEventSelector_1 = require("../../../../entity/upcomingPaymentEvent/upcomingPaymentEventSelector");
+/**
+ * Default account type used when the recommend payload has no movement to
+ * expose yet (e.g. before the first fetch resolves). Callers that care about
+ * the movement should also gate on `fetchState === 'Completed'`.
+ */
+const DEFAULT_BANK_ACCOUNT_TYPE = 'deposit_account';
+const DEFAULT_SUB_MOVEMENT_TYPE = 'push';
 const getCashManagementOverviewBanner = (state) => {
     const { banner } = state.cashManagementOverviewState;
+    // The banner today surfaces a single recommended movement (the first one
+    // returned by the agent). When the agent returns multiple groups/movements
+    // we'll need to broaden this — for now consumers only render one.
+    const movement = banner.data?.moneyMovements[0]?.movements[0];
     return {
         fetchState: banner.fetchState,
         error: banner.error,
-        data: banner.data,
+        amount: movement?.amount ?? (0, amount_1.zeroAmount)(),
+        destinationBankAccountId: movement?.destinationBankAccountId ?? '',
+        destinationBankAccountType: movement?.destinationBankAccountType ?? DEFAULT_BANK_ACCOUNT_TYPE,
+        reasoning: movement?.reasoning ?? '',
+        sourceBankAccountId: movement?.sourceBankAccountId ?? '',
+        sourceBankAccountType: movement?.sourceBankAccountType ?? DEFAULT_BANK_ACCOUNT_TYPE,
+        subMovementType: movement?.subMovementType ?? DEFAULT_SUB_MOVEMENT_TYPE,
         version: 0,
     };
 };
@@ -45,7 +62,6 @@ const getCashManagementOverview = (state) => {
     const totalCash = addAmounts(treasuryBalance, cashBalance);
     return {
         banner: (0, exports.getCashManagementOverviewBanner)(state),
-        bannerFetchState,
         cashBalance,
         horizonDays: cashManagementOverviewState.upcomingPaymentEvents.horizonDays,
         outflowEvents: (0, upcomingPaymentEventSelector_1.getUpcomingPaymentEventsByIds)(state.upcomingPaymentEventState, cashManagementOverviewState.upcomingPaymentEvents.eventIds),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.81-betaAK1",
+  "version": "5.0.81-betaAK3",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",
@@ -108,6 +108,7 @@
     "test:typecheck": "echo 'Typechecking test files...' && NODE_OPTIONS=--max-old-space-size=4096 time tsc -p tsconfig.typecheck.json",
     "test:typecheck-modified-files": "chmod +x ./scripts/tsc-modified-files.sh && ./scripts/tsc-modified-files.sh master tsconfig.typecheck.json",
     "test": "pnpm lint-modified-files && pnpm test:typecheck-modified-files && vitest run --typecheck",
+    "test:full": "vitest run --typecheck",
     "lint": "eslint . --ext .js,.jsx,.ts,.tsx --max-warnings 0 --fix",
     "lint-modified-files": "chmod +x ./scripts/lint-modified-files.sh && ./scripts/lint-modified-files.sh",
     "lint:fix-modified-files": "chmod +x ./scripts/lint-modified-files.sh && LINT_FIX=true ./scripts/lint-modified-files.sh",