@zeniai/client-epic-state 5.0.78 → 5.0.79

package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -3,21 +3,97 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.toTransactionView = exports.getCategorizationHasInFlightRecommendations = exports.getCategorizationInFlightRecommendationsByTransactionId = void 0;
 exports.getExpenseAutomationTransactionView = getExpenseAutomationTransactionView;
+const toolkit_1 = require("@reduxjs/toolkit");
 const omit_1 = __importDefault(require("lodash/omit"));
 const reduceFetchState_1 = require("../../../commonStateTypes/reduceFetchState");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const transactionHelper_1 = require("../../../entity/transaction/transactionHelper");
 const transactionSelector_1 = require("../../../entity/transaction/transactionSelector");
+const transactionFilterHelpers_1 = require("../transactionFilterHelpers");
 const accountListSelector_1 = require("../../accountList/accountListSelector");
 const classListSelector_1 = require("../../classList/classListSelector");
 const projectListSelector_1 = require("../../projectList/projectListSelector");
 const expenseAutomationViewSelectorTypes_1 = require("../selectorTypes/expenseAutomationViewSelectorTypes");
+// Walks the tab's transactionReviewLocalDataById map and returns
+// `{ [transactionId]: true }` for every transaction that has at least
+// one line whose targeted-fetch is In-Progress. Pulled out as a plain
+// function so each tab's createSelector can share it.
+const computeCategorizationInFlightRecommendations = (transactionReviewLocalDataById) => {
+    const result = {};
+    if (transactionReviewLocalDataById == null) {
+        return result;
+    }
+    for (const [transactionId, data] of Object.entries(transactionReviewLocalDataById)) {
+        const lineItems = Object.values(data.transactionReviewLocalData.lineItemById);
+        if (lineItems.some((lineItem) => lineItem.categoryClassRecommendationsFetchState?.fetchState ===
+            'In-Progress')) {
+            result[transactionId] = true;
+        }
+    }
+    return result;
+};
+// Per-tab createSelector instances. Each one is memoized on its OWN tab's
+// transactionReviewLocalDataById reference. Switching tabs A->B->A no
+// longer busts the memo for tab A — the dispatcher below just returns
+// whichever per-tab selector matches the active tab, and reselect keeps
+// the prior result alive as long as the underlying slice ref is stable.
+const getReviewInFlightRecommendationsByTransactionId = (0, toolkit_1.createSelector)((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
+    .review.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
+const getAutoCategorizedInFlightRecommendationsByTransactionId = (0, toolkit_1.createSelector)((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
+    .autoCategorized.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
+// Per-transaction "any line is fetching category/class recommendations?"
+// map for the active categorization tab. Dispatches to the per-tab
+// memoized selector above so steady state (no fetches in flight)
+// recomputes only when the active tab's local data changes; tab switches
+// are O(1) cache lookups.
+//
+// `default` guards against the union "lying" at runtime: `TransactionsTab`
+// is produced via `stringToUnion`, which falls back to `s as StringUnion`
+// for unrecognized strings, so an unexpected value can land in state. The
+// downstream `getCategorizationHasInFlightRecommendations` calls
+// `Object.keys` on this result, so we must always return an object.
+const getCategorizationInFlightRecommendationsByTransactionId = (state) => {
+    const tab = state.expenseAutomationTransactionsViewState
+        .selectedTransactionCategorizationTab;
+    switch (tab) {
+        case 'review':
+            return getReviewInFlightRecommendationsByTransactionId(state);
+        case 'autoCategorized':
+            return getAutoCategorizedInFlightRecommendationsByTransactionId(state);
+        default:
+            return {};
+    }
+};
+exports.getCategorizationInFlightRecommendationsByTransactionId = getCategorizationInFlightRecommendationsByTransactionId;
+// Page-level "any line on the active tab is in flight?" flag. Drives the
+// list-page Save disable.
+exports.getCategorizationHasInFlightRecommendations = (0, toolkit_1.createSelector)(exports.getCategorizationInFlightRecommendationsByTransactionId, (inFlightByTransactionId) => Object.keys(inFlightByTransactionId).length > 0);
+const toTransactionView = (transaction, transactionLocalData) => {
+    return {
+        id: transaction.id,
+        date: transaction.date,
+        amount: transaction.amount,
+        vendorName: transaction.vendorName,
+        customerName: transaction.customerName,
+        vendorId: transaction.vendorId,
+        customerId: transaction.customerId,
+        description: transaction.description,
+        memo: transaction.memo,
+        type: transaction.type,
+        typeName: transaction.typeName,
+        createTime: transaction.createTime,
+        transaction: transaction,
+        transactionLocalData,
+    };
+};
+exports.toTransactionView = toTransactionView;
 function getExpenseAutomationTransactionView(state) {
     const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { selectedTransactionCategorizationTab } = expenseAutomationTransactionsViewState;
-    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
+    const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
+    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, filters, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(accountState, accountListState, 'accountList');
     const accountList = (0, accountListSelector_1.getAccountList)(accountState, accountListState, 'accountList');
     const classList = (0, classListSelector_1.getClassList)(classState, classListState);
@@ -36,20 +112,58 @@ function getExpenseAutomationTransactionView(state) {
         ? transactionIdsBySelectedPeriod[monthYearPeriodId]
         : null;
     const transactionIds = transactionIdsForSelectedPeriod ?? [];
-    const transactionLocalData = transactionIds
-        .map((transactionId) => {
+    const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
+    const transactionsWithCOT = transactions.map((transaction) => (0, transactionHelper_1.getTransactionWithCOT)(transaction));
+    const transactionLocalDataMap = new Map();
+    transactionIds.forEach((transactionId) => {
         const transactionData = transactionReviewLocalDataById[transactionId];
         if (transactionData != null) {
-            return {
+            transactionLocalDataMap.set(transactionId, {
                 transactionId,
                 transactionReviewLocalData: transactionData.transactionReviewLocalData,
-            };
+            });
         }
-        return null;
-    })
-        .filter((transaction) => transaction != null);
-    const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
-    const transactionsWithCOT = transactions.map((transaction) => (0, transactionHelper_1.getTransactionWithCOT)(transaction));
+    });
+    // Step 2: Convert to TransactionView and apply advanced filters
+    const transactionViews = transactionsWithCOT.map((transaction) => {
+        const localData = transactionLocalDataMap.get(transaction.id);
+        return (0, exports.toTransactionView)(transaction, localData);
+    });
+    // Apply TC-specific filters (lives under expenseAutomationView, independent
+    // of the Spend Management filter pipeline).
+    const filteredTransactionViews = (0, transactionFilterHelpers_1.applyTransactionFilters)(transactionViews, filters);
+    // Convert back to TransactionWithCOT for return
+    const filteredTransactionsWithCOT = filteredTransactionViews.map((view) => view.transaction);
+    // Get transactionLocalData for filtered transactions
+    // Also include transactionLocalData for transactions that don't exist in transactionState
+    // but have local data (to match original behavior)
+    const filteredTransactionIds = new Set(filteredTransactionViews.map((view) => view.id));
+    // Pre-compute the membership set once. The previous implementation called
+    // `transactions.some(t => t.id === transactionId)` inside the per-id loop,
+    // turning the pipeline into O(n × m) — measurable on tenants with large
+    // transaction lists since this selector runs on every Redux dispatch.
+    const transactionExistsById = new Set(transactions.map((t) => t.id));
+    // `.flatMap` returns `X[]` directly when the callback returns `[]` for the
+    // skip case, so we don't need the trailing `.filter((d): d is X => …)` type
+    // predicate that the previous `map → filter` pipeline required.
+    const filteredTransactionLocalData = transactionIds.flatMap((transactionId) => {
+        const transactionData = transactionReviewLocalDataById[transactionId];
+        if (transactionData == null) {
+            return [];
+        }
+        // Include if transaction is in filtered results, or if transaction doesn't exist in state
+        // (to maintain backward compatibility with tests)
+        const transactionExists = transactionExistsById.has(transactionId);
+        if (filteredTransactionIds.has(transactionId) || !transactionExists) {
+            return [
+                {
+                    transactionId,
+                    transactionReviewLocalData: transactionData.transactionReviewLocalData,
+                },
+            ];
+        }
+        return [];
+    });
     const monthEndFetchState = monthYearPeriodId != null
         ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
         : { fetchState: 'Not-Started', error: undefined };
@@ -69,10 +183,27 @@ function getExpenseAutomationTransactionView(state) {
         .uiState.totalCount;
     const totalCountByAutoCat = expenseAutomationTransactionsViewState.transactionCategorizationView
         .autoCategorized.uiState.totalCount;
+    // Per-(sub-)tab counts powering pagination, in-list "showing X of Y", and
+    // any save/refresh round-trips. Sourced from `uiState.totalCount` which
+    // mirrors the response's `total_count` for whatever tab/sub-tab the user is
+    // viewing (e.g. only the Manual sub-tab rows for Completed → Manual).
     const totalCountByTab = {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
+    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
+    // listing response and used exclusively by the navbar / tab strip badges.
+    // Independent of which Completed sub-tab is active so the badge stays
+    // stable across sub-tab switches.
+    const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
+    const parentTabTotalCountByTab = {
+        review: monthYearPeriodId != null
+            ? (parentTotalCountByTab.review[monthYearPeriodId] ?? 0)
+            : 0,
+        autoCategorized: monthYearPeriodId != null
+            ? (parentTotalCountByTab.autoCategorized[monthYearPeriodId] ?? 0)
+            : 0,
+    };
     const fetchStateByTab = {
         review: {
             fetchState: expenseAutomationTransactionsViewState.transactionCategorizationView
@@ -92,11 +223,13 @@ function getExpenseAutomationTransactionView(state) {
         : [];
     const transactionCompletionStatus = allSteps.find((step) => step.step === 'transaction_categorization')?.completionStatus;
     const completionStatus = transactionCompletionStatus ?? 'incomplete';
+    const inFlightCategoryClassRecommendationsByTransactionId = (0, exports.getCategorizationInFlightRecommendationsByTransactionId)(state);
+    const hasInFlightCategoryClassRecommendations = (0, exports.getCategorizationHasInFlightRecommendations)(state);
     return {
         version: 0,
         fetchState: fetchStatus.fetchState,
         error: fetchStatus.error,
-        transactions: transactionsWithCOT,
+        transactions: filteredTransactionsWithCOT,
         selectedCheckBoxTransactionIds,
         transactionIdsWithUnsavedData,
         uncategorizedAccounts: uncategorizedIncomeExpense,
@@ -105,18 +238,22 @@ function getExpenseAutomationTransactionView(state) {
         classList: allClasses,
         accountsHierarchyList,
         classHierarchyList,
+        hasInFlightCategoryClassRecommendations,
+        inFlightCategoryClassRecommendationsByTransactionId,
         isAccountingProjectsEnabled,
         projectList,
-        transactionLocalData,
+        transactionLocalData: filteredTransactionLocalData,
         uiState,
         refreshStatus,
         saveStatus,
         markAsNotMiscategorizedStatus,
         completionStatus,
         totalCountByTab,
+        parentTabTotalCountByTab,
         fetchStateByTransactionTabs: fetchStateByTab,
         uploadReceiptStatusById,
         selectedTransactionId,
         selectedTransactionLineId,
+        selectedTransactionCategorizationCompletedSubTab,
     };
 }

package/lib/view/expenseAutomationView/transactionFilterHelpers.d.ts

@@ -0,0 +1,66 @@
+/**
+ * Filter machinery for the Transaction Categorization feature inside
+ * Expense Automation. Intentionally self-contained — does NOT import anything
+ * from `view/spendManagement/*`, because Transaction Categorization is not a
+ * Spend Management product. Shared primitives
+ * (`CategoryCombinationOperator`, `FilterCategoryType`) come from
+ * `commonStateTypes/filterPrimitives`, which both feature groups consume.
+ */
+import { Amount } from '../../commonStateTypes/amount';
+import { ID } from '../../commonStateTypes/common';
+import { CategoryCombinationOperator, FilterCategoryType } from '../../commonStateTypes/filterPrimitives';
+import { TransactionType } from '../../entity/transaction/stateTypes/transactionType';
+import { SupportedTransactionWithCOT } from '../../entity/transaction/transactionState';
+import { ZeniDate } from '../../zeniDayJS';
+import { TransactionReviewLocalDataSelectorView } from './selectorTypes/transactionsViewSelectorTypes';
+/**
+ * Re-exported here so the CES barrel can pull TC's primitives from the
+ * Expense Automation surface without reaching into `commonStateTypes`
+ * directly — keeps the barrel's existing import topology stable.
+ */
+export type { CategoryCombinationOperator, FilterCategoryType };
+export type TransactionFilterEntityType = 'transaction_categorization' | 'customer' | 'vendor' | 'merchant';
+export type TransactionFilterCategoryField = 'payment_account_name' | 'payment_account_type' | 'payee' | 'category' | 'class' | 'amount';
+export interface TransactionFilterCategoryDropdownOption {
+    value: TransactionFilterCategoryField;
+    multiple?: boolean;
+    type?: FilterCategoryType;
+}
+export declare const TRANSACTION_FILTER_CATEGORIES: TransactionFilterCategoryDropdownOption[];
+/** Amount filter operators for transaction_categorization. */
+export type TransactionFilterAmountMatchingOperator = 'equal' | 'not_equal' | 'less_than' | 'greater_than' | 'in_between';
+export interface TransactionFilterCategory {
+    field: TransactionFilterCategoryField;
+    matchingOperator: TransactionFilterAmountMatchingOperator;
+    values: (string | number)[];
+    valuesCombinationOperator: 'ANY';
+}
+export interface TransactionFilters {
+    categories: TransactionFilterCategory[];
+    categoryCombinationOperator: CategoryCombinationOperator;
+}
+export interface TransactionView {
+    amount: Amount;
+    createTime: ZeniDate;
+    date: ZeniDate;
+    description: string;
+    id: ID;
+    memo: string;
+    transaction: SupportedTransactionWithCOT;
+    type: TransactionType;
+    customerId?: ID;
+    customerName?: string;
+    transactionLocalData?: TransactionReviewLocalDataSelectorView;
+    typeName?: string;
+    vendorId?: ID;
+    vendorName?: string;
+}
+/**
+ * TC-only equivalent of `applyAdvancedFiltersOnList`. Filters a list of
+ * `TransactionView` items against a `TransactionFilters` object using the
+ * AND/OR combination semantics from `categoryCombinationOperator`.
+ *
+ * Independent of `view/spendManagement` — keeps the TC filter pipeline cleanly
+ * inside the Expense Automation feature group.
+ */
+export declare const applyTransactionFilters: (transactions: TransactionView[], filters?: TransactionFilters) => TransactionView[];

package/lib/view/expenseAutomationView/transactionFilterHelpers.js

@@ -0,0 +1,262 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.applyTransactionFilters = exports.TRANSACTION_FILTER_CATEGORIES = void 0;
+/**
+ * Narrowing type-guard for "has a non-empty string here". Used in place of
+ * raw `if (foo)` truthiness checks on `string | null | undefined` values so
+ * the `@typescript-eslint/strict-boolean-expressions` lint stays clean —
+ * empty strings should explicitly fall through to the next candidate
+ * (vendorName → customerName → localData.vendor.name → ...) rather than
+ * being implicitly coerced to falsy.
+ */
+const isNonEmptyString = (s) => s != null && s !== '';
+/**
+ * First line item in UI order. `lineItemById` is a Record whose iteration
+ * order is not guaranteed to match what the user sees; `sortedLineItems`
+ * is the canonical ordering used by the categorization list/detail views.
+ */
+const getFirstLineItemFromReviewLocalData = (localData) => {
+    const { sortedLineItems, lineItemById } = localData;
+    if (sortedLineItems.length > 0) {
+        return lineItemById[sortedLineItems[0]];
+    }
+    const lineItems = Object.values(lineItemById);
+    return lineItems.length > 0 ? lineItems[0] : undefined;
+};
+exports.TRANSACTION_FILTER_CATEGORIES = [
+    { value: 'payment_account_name', type: 'dropdown' },
+    { value: 'payment_account_type', type: 'dropdown' },
+    { value: 'payee', type: 'searchAutocomplete' },
+    { value: 'category', type: 'dropdown' },
+    { value: 'class', type: 'dropdown' },
+    { value: 'amount', type: 'numberRange' },
+];
+/**
+ * Resolve the comparable value for a transaction against a given filter field.
+ * Returns undefined when the transaction doesn't carry the field — callers
+ * decide whether absence counts as a match (for 'not_equal' it does).
+ */
+const getCategoryValueForTransaction = (key, transaction) => {
+    switch (key) {
+        case 'amount': {
+            // Prefer transactionLocalData line items (sum). Fall back to lines on
+            // the transaction itself. Final fallback: transaction-level amount.
+            const localDataForAmount = transaction.transactionLocalData?.transactionReviewLocalData;
+            if (localDataForAmount?.lineItemById) {
+                const lineItems = Object.values(localDataForAmount.lineItemById);
+                if (lineItems.length > 0) {
+                    return lineItems.reduce((sum, lineItem) => sum + (lineItem.amount?.amount ?? 0), 0);
+                }
+            }
+            if (transaction.transaction.lines &&
+                transaction.transaction.lines.length > 0) {
+                return transaction.transaction.lines.reduce((sum, line) => sum + (line.amount?.amount ?? 0), 0);
+            }
+            return transaction.amount.amount;
+        }
+        case 'payee': {
+            if (isNonEmptyString(transaction.vendorName)) {
+                return transaction.vendorName;
+            }
+            if (isNonEmptyString(transaction.customerName)) {
+                return transaction.customerName;
+            }
+            const localData = transaction.transactionLocalData?.transactionReviewLocalData;
+            const vendorName = localData?.vendor?.name;
+            if (isNonEmptyString(vendorName)) {
+                return vendorName;
+            }
+            const customerName = localData?.customer?.name;
+            if (isNonEmptyString(customerName)) {
+                return customerName;
+            }
+            return undefined;
+        }
+        case 'payment_account_name': {
+            // Match what TransactionCategorizationListRow renders for the cell.
+            return transaction.transaction.account?.accountName;
+        }
+        case 'payment_account_type': {
+            // Raw `paymentType` enum ("credit_card" / "check" / "cash"). Dropdown
+            // option values use the same enum; row uses `paymentTypeName` for the
+            // human label.
+            return transaction.transaction.paymentType;
+        }
+        case 'category': {
+            const localDataForCategory = transaction.transactionLocalData?.transactionReviewLocalData;
+            if (localDataForCategory != null) {
+                const firstLineItem = getFirstLineItemFromReviewLocalData(localDataForCategory);
+                const accountId = firstLineItem?.account?.accountId;
+                if (isNonEmptyString(accountId)) {
+                    return accountId;
+                }
+                const qboId = firstLineItem?.account?.qboId;
+                if (isNonEmptyString(qboId)) {
+                    return qboId;
+                }
+                const accountName = firstLineItem?.account?.accountName;
+                if (isNonEmptyString(accountName)) {
+                    return accountName;
+                }
+            }
+            const firstLineForCategory = transaction.transaction.lines?.[0];
+            if (firstLineForCategory?.type ===
+                'transaction_with_account_and_class_line' ||
+                firstLineForCategory?.type ===
+                    'transaction_with_product_or_service_line' ||
+                firstLineForCategory?.type === 'journal_entry_transaction_line') {
+                const account = firstLineForCategory.account;
+                return account?.accountId ?? account?.qboId ?? account?.accountName;
+            }
+            return undefined;
+        }
+        case 'class': {
+            const localDataForClass = transaction.transactionLocalData?.transactionReviewLocalData;
+            if (localDataForClass != null) {
+                const firstLineItemForClass = getFirstLineItemFromReviewLocalData(localDataForClass);
+                const classId = firstLineItemForClass?.class?.classId;
+                if (isNonEmptyString(classId)) {
+                    return classId;
+                }
+                const qboId = firstLineItemForClass?.class?.qboId;
+                if (isNonEmptyString(qboId)) {
+                    return qboId;
+                }
+                const className = firstLineItemForClass?.class?.className;
+                if (isNonEmptyString(className)) {
+                    return className;
+                }
+            }
+            const firstLineForClass = transaction.transaction.lines?.[0];
+            if (firstLineForClass?.type === 'transaction_with_account_and_class_line' ||
+                firstLineForClass?.type ===
+                    'transaction_with_product_or_service_line' ||
+                firstLineForClass?.type === 'journal_entry_transaction_line') {
+                const classData = firstLineForClass.class;
+                return classData?.classId ?? classData?.qboId ?? classData?.className;
+            }
+            return undefined;
+        }
+        default:
+            return undefined;
+    }
+};
+/**
+ * TC-only amount matcher. Supports all five operators TC defines, including
+ * the legacy "1000<->5000" range-string form (kept for backward compatibility
+ * with persisted filter state that may still contain that encoding).
+ *
+ * The `'equal' | 'not_equal'` branch matches if `amount` equals ANY of the
+ * configured values (consistent with how non-amount filters interpret a
+ * multi-value `values` array). `.some()` over the values array also makes
+ * the empty-values case behave correctly — empty array → `matched = false`
+ * — though in practice `applyTransactionFilters` strips empty-values
+ * categories before they reach this matcher. The trailing
+ * `op === 'not_equal' ? !matched : matched` line inverts for `not_equal`.
+ */
+const matchAmount = (amount, category) => {
+    const op = category.matchingOperator;
+    const values = category.values;
+    let matched = false;
+    if (op === 'in_between') {
+        if (values.length >= 2) {
+            const min = Number(values[0]);
+            const max = Number(values[1]);
+            matched = amount >= min && amount <= max;
+        }
+    }
+    else if (op === 'less_than') {
+        if (values.length >= 1) {
+            matched = amount < Number(values[0]);
+        }
+    }
+    else if (op === 'greater_than') {
+        if (values.length >= 1) {
+            matched = amount > Number(values[0]);
+        }
+    }
+    else if (op === 'equal' || op === 'not_equal') {
+        matched = values.some((v) => {
+            const s = String(v);
+            // Backward compatibility: legacy "low<->high" range-string form
+            // persisted under `matchingOperator: 'equal'`.
+            if (s.includes('<->')) {
+                const parts = s.split('<->');
+                return (amount >= Number(parts[0] ?? '') && amount <= Number(parts[1] ?? ''));
+            }
+            return amount === Number(v);
+        });
+    }
+    return op === 'not_equal' ? !matched : matched;
+};
+const transactionMatchesCategory = (transaction, category) => {
+    const value = getCategoryValueForTransaction(category.field, transaction);
+    if (value == null) {
+        // Absent-value semantics — pinning these down explicitly so the
+        // asymmetry isn't surprising:
+        //
+        //   not_equal: a missing value IS NOT EQUAL to any candidate, so the
+        //              transaction matches the filter (passes through).
+        //   equal:     a missing value is not equal to any candidate, so the
+        //              transaction does NOT match (filtered out).
+        //   less_than / greater_than: SQL-style three-valued logic — comparing
+        //              against a missing value is "unknown", which we treat as
+        //              "does not match" (filtered out). A user setting
+        //              "amount < $1000" probably wants transactions with a
+        //              concrete amount that satisfies the bound, not rows
+        //              where the amount can't be determined.
+        //   in_between: same as the single-sided comparators — missing values
+        //              are filtered out.
+        //
+        // Only the `not_equal` branch returns `true` here; everything else
+        // falls through to the `false` below.
+        return category.matchingOperator === 'not_equal';
+    }
+    if (category.field === 'amount') {
+        return matchAmount(Number(value), category);
+    }
+    const valueStr = value.toString();
+    const valueInList = category.values.some((v) => v.toString() === valueStr);
+    return category.matchingOperator === 'not_equal' ? !valueInList : valueInList;
+};
+/**
+ * TC-only equivalent of `applyAdvancedFiltersOnList`. Filters a list of
+ * `TransactionView` items against a `TransactionFilters` object using the
+ * AND/OR combination semantics from `categoryCombinationOperator`.
+ *
+ * Independent of `view/spendManagement` — keeps the TC filter pipeline cleanly
+ * inside the Expense Automation feature group.
+ */
+const applyTransactionFilters = (transactions, filters) => {
+    if (filters?.categories == null || filters.categories.length === 0) {
+        return transactions;
+    }
+    // Mirrors the predicate used by `getTransactionAppliedFiltersCount` on the
+    // webc side. A half-filled category — e.g. `in_between` with only the
+    // `min` typed — would otherwise survive the filter pass and produce zero
+    // matches because `Number("")` collapses to `0`, artificially emptying
+    // the list while editing. Skipping such categories keeps the filtered
+    // view stable while the user finishes typing.
+    const activeCategories = filters.categories.filter((c) => {
+        if (c.field == null || c.values.length === 0) {
+            return false;
+        }
+        if (c.field === 'amount' && c.matchingOperator === 'in_between') {
+            return (c.values.length >= 2 &&
+                String(c.values[0] ?? '').trim() !== '' &&
+                String(c.values[1] ?? '').trim() !== '');
+        }
+        return String(c.values[0] ?? '').trim() !== '';
+    });
+    if (activeCategories.length === 0) {
+        return transactions;
+    }
+    const op = filters.categoryCombinationOperator;
+    return transactions.filter((txn) => {
+        if (op === 'AND') {
+            return activeCategories.every((cat) => transactionMatchesCategory(txn, cat));
+        }
+        return activeCategories.some((cat) => transactionMatchesCategory(txn, cat));
+    });
+};
+exports.applyTransactionFilters = applyTransactionFilters;

package/lib/view/expenseAutomationView/types/completedSubTab.d.ts

@@ -0,0 +1,10 @@
+export declare const toCompletedSubTab: (v: string) => "all" | "manual" | "ai_accountant";
+export type CompletedSubTab = ReturnType<typeof toCompletedSubTab>;
+/**
+ * "No sub-tab filter" sentinel — single source of truth for the default
+ * value of {@link CompletedSubTab}. Use this constant in initial slice
+ * state and at any call site that needs to fall back to the parent-tab
+ * listing semantics (review tab requests, manual-search overrides, etc.)
+ * so a future rename of the union doesn't require chasing literals.
+ */
+export declare const DEFAULT_COMPLETED_SUB_TAB: CompletedSubTab;

package/lib/view/expenseAutomationView/types/completedSubTab.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DEFAULT_COMPLETED_SUB_TAB = exports.toCompletedSubTab = void 0;
+const stringToUnion_1 = require("../../../commonStateTypes/stringToUnion");
+/**
+ * Sub-tabs that can appear under any "Completed" tab in the Expense Automation
+ * surface (Transaction Categorization Completed and Missing Receipts Completed
+ * both use this exact union). Forwarded verbatim to listing APIs as `sub_tab`
+ * / `match_type`. `'all'` preserves parent-tab semantics on the backend.
+ */
+const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
+const toCompletedSubTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), COMPLETED_SUB_TABS);
+exports.toCompletedSubTab = toCompletedSubTab;
+/**
+ * "No sub-tab filter" sentinel — single source of truth for the default
+ * value of {@link CompletedSubTab}. Use this constant in initial slice
+ * state and at any call site that needs to fall back to the parent-tab
+ * listing semantics (review tab requests, manual-search overrides, etc.)
+ * so a future rename of the union doesn't require chasing literals.
+ */
+exports.DEFAULT_COMPLETED_SUB_TAB = 'all';

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.d.ts

@@ -1,6 +1,7 @@
 import { FetchStateAndError, FetchedState, ID } from '../../../commonStateTypes/common';
 import { SortOrder } from '../../../commonStateTypes/selectorTypes/sortOrderTypes';
 import { MonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
+import { CompletedSubTab } from './completedSubTab';
 export declare const toMissingReceiptsSortKey: (v: string) => "date" | "amount" | "vendor" | "category" | "class";
 export type MissingReceiptsSortKey = ReturnType<typeof toMissingReceiptsSortKey>;
 export interface MissingReceiptsViewUIState {
@@ -31,8 +32,6 @@ export declare const toBulkUploadResultsTab: (v: string) => "completed" | "unmat
 export type BulkUploadResultsTab = ReturnType<typeof toBulkUploadResultsTab>;
 export declare const toMissingReceiptsTab: (v: string) => "completed" | "unmatched" | "missing";
 export type MissingReceiptsTab = ReturnType<typeof toMissingReceiptsTab>;
-export declare const toCompletedSubTab: (v: string) => "all" | "manual" | "ai_accountant";
-export type CompletedSubTab = ReturnType<typeof toCompletedSubTab>;
 export declare const toMatchSource: (v: string) => "manual" | "ai";
 export type MatchSource = ReturnType<typeof toMatchSource>;
 export declare const toBulkUploadSortKey: (v: string) => "date" | "amount" | "vendor" | "category" | "class";

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.toBulkUploadSortKey = exports.toMatchSource = exports.toCompletedSubTab = exports.toMissingReceiptsTab = exports.toBulkUploadResultsTab = exports.toBulkUploadPhase = exports.toBatchFileStatus = exports.BATCH_FILE_STATUSES = exports.toBatchStatusValue = exports.MIN_MANUAL_TRANSACTION_SEARCH_LENGTH = exports.toMissingReceiptsSortKey = void 0;
+exports.toBulkUploadSortKey = exports.toMatchSource = exports.toMissingReceiptsTab = exports.toBulkUploadResultsTab = exports.toBulkUploadPhase = exports.toBatchFileStatus = exports.BATCH_FILE_STATUSES = exports.toBatchStatusValue = exports.MIN_MANUAL_TRANSACTION_SEARCH_LENGTH = exports.toMissingReceiptsSortKey = void 0;
 exports.isUnmatchedTabFileStatus = isUnmatchedTabFileStatus;
 const stringToUnion_1 = require("../../../commonStateTypes/stringToUnion");
 const MISSING_RECEIPTS_SORT_KEYS = [
@@ -49,9 +49,6 @@ exports.toBulkUploadResultsTab = toBulkUploadResultsTab;
 const MISSING_RECEIPTS_TABS = ['missing', 'completed', 'unmatched'];
 const toMissingReceiptsTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), MISSING_RECEIPTS_TABS);
 exports.toMissingReceiptsTab = toMissingReceiptsTab;
-const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
-const toCompletedSubTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), COMPLETED_SUB_TABS);
-exports.toCompletedSubTab = toCompletedSubTab;
 const MATCH_SOURCES = ['ai', 'manual'];
 const toMatchSource = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), MATCH_SOURCES);
 exports.toMatchSource = toMatchSource;