@zeniai/client-epic-state 5.0.77-betaAR1 → 5.0.77-betaAR3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (49) hide show
  1. package/lib/entity/approvalRule/approvalRulePayload.d.ts +27 -5
  2. package/lib/entity/approvalRule/approvalRulePayload.js +131 -10
  3. package/lib/entity/approvalRule/approvalRuleSelector.d.ts +25 -1
  4. package/lib/entity/approvalRule/approvalRuleSelector.js +40 -0
  5. package/lib/entity/approvalRule/approvalRuleState.d.ts +48 -7
  6. package/lib/esm/entity/approvalRule/approvalRulePayload.js +131 -10
  7. package/lib/esm/entity/approvalRule/approvalRuleSelector.js +35 -0
  8. package/lib/esm/index.js +2 -1
  9. package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/backgroundRefetchReviewTabEpic.js +1 -14
  10. package/lib/esm/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js +1 -12
  11. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +26 -11
  12. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +9 -2
  13. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +7 -4
  14. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +11 -7
  15. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +14 -4
  16. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +121 -16
  17. package/lib/esm/view/spendManagement/billPay/editBillView/editBillViewSelector.js +7 -2
  18. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +8 -2
  19. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +6 -2
  20. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +11 -7
  21. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +13 -4
  22. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +25 -10
  23. package/lib/index.d.ts +3 -2
  24. package/lib/index.js +22 -16
  25. package/lib/view/companyTaskManagerView/companyTaskManagerViewReducer.d.ts +2 -2
  26. package/lib/view/companyView/types/cockpitTypes.d.ts +1 -1
  27. package/lib/view/expenseAutomationView/epics/transactionCategorization/backgroundRefetchReviewTabEpic.js +1 -14
  28. package/lib/view/expenseAutomationView/epics/transactionCategorization/fetchTransactionCategorizationEpic.js +1 -12
  29. package/lib/view/expenseAutomationView/payload/transactionCategorizationPayload.d.ts +0 -10
  30. package/lib/view/people/peopleTypes.d.ts +1 -1
  31. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.d.ts +7 -3
  32. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +26 -11
  33. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +9 -2
  34. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +7 -4
  35. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +10 -6
  36. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +13 -3
  37. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.d.ts +48 -1
  38. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +123 -17
  39. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonState.d.ts +31 -5
  40. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.js +7 -2
  41. package/lib/view/spendManagement/chargeCards/chargeCardList/chargeCardList.d.ts +1 -1
  42. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +8 -2
  43. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +6 -2
  44. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +10 -6
  45. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +12 -3
  46. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.d.ts +7 -3
  47. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +25 -10
  48. package/lib/view/taskManager/taskListView/taskList.d.ts +3 -3
  49. package/package.json +1 -1
@@ -6,9 +6,16 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { deleteBillPayApprovalRule, deleteBillPayApprovalRuleFailure, deleteBillPayApprovalRuleSuccess, } from '../billPaySetupApproverViewReducer';
8
8
  export const deleteBillPayApprovalRuleEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(deleteBillPayApprovalRule.match), switchMap((action) => {
9
- const { approvalRuleId } = action.payload;
9
+ const { approvalRuleId, useV3 } = action.payload;
10
+ // Approval Rules 3.0 — flag-gated endpoint selection.
11
+ const endpoint = useV3
12
+ ? // ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
13
+ `https://dev.api.zeni.ai/version/approval/tarun/1.0/bill-pay/approval-rules-v2`
14
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
10
15
  return zeniAPI
11
- .deleteAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, { approval_rule_id: approvalRuleId })
16
+ .deleteAndGetJSON(endpoint, {
17
+ approval_rule_id: approvalRuleId,
18
+ })
12
19
  .pipe(mergeMap((response) => {
13
20
  if (isSuccessResponse(response) && response.data != null) {
14
21
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -6,7 +6,7 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { fetchBillPaySetupApproverView, fetchBillPaySetupApproverViewFailure, fetchBillPaySetupApproverViewSuccess, } from '../billPaySetupApproverViewReducer';
8
8
  export const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchBillPaySetupApproverView.match), switchMap((action) => {
9
- const { cacheOverride } = action.payload;
9
+ const { cacheOverride, useV3 } = action.payload;
10
10
  const { billPaySetupApproverViewState, approvalRuleState } = state$.value;
11
11
  const approvalRules = getApprovalRulesByIds(approvalRuleState, billPaySetupApproverViewState.approvalRuleIds);
12
12
  if (cacheOverride === true ||
@@ -14,9 +14,12 @@ export const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) =>
14
14
  billPaySetupApproverViewState.approvalRuleIds.length ||
15
15
  (billPaySetupApproverViewState.hasValidState() === false &&
16
16
  billPaySetupApproverViewState.fetchState !== 'In-Progress')) {
17
- return zeniAPI
18
- .getJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`)
19
- .pipe(mergeMap((response) => {
17
+ // Approval Rules 3.0 — flag-gated endpoint selection.
18
+ const endpoint = useV3
19
+ ? // ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
20
+ `https://dev.api.zeni.ai/version/approval/tarun/1.0/bill-pay/approval-rules-v2`
21
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
22
+ return zeniAPI.getJSON(endpoint).pipe(mergeMap((response) => {
20
23
  if (isSuccessResponse(response) && response.data != null) {
21
24
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
22
25
  const actions = [
@@ -1,6 +1,6 @@
1
1
  import { from } from 'rxjs';
2
2
  import { filter, mergeMap } from 'rxjs/operators';
3
- import { getApprovalRuleById } from '../../../../../entity/approvalRule/approvalRuleSelector';
3
+ import { getAmountCriteria, getApprovalRuleById, getDepartmentCriteria, getVendorCriteria, } from '../../../../../entity/approvalRule/approvalRuleSelector';
4
4
  import { clearBillPaySetupApproverViewUpdateData, initializeBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdateData, } from '../billPaySetupApproverViewReducer';
5
5
  export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state$) => actions$.pipe(filter(initializeBillPaySetupApproverViewUpdateData.match), mergeMap((action) => {
6
6
  const { approvalRuleId } = action.payload;
@@ -8,16 +8,20 @@ export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state
8
8
  if (approvalRuleId != null) {
9
9
  const approvalRule = getApprovalRuleById(state$.value.approvalRuleState, approvalRuleId);
10
10
  if (approvalRule != null) {
11
- const criteria = approvalRule.criteria[0];
12
- const range = criteria?.range;
13
11
  const billPaySetupApproverViewUpdateData = {
14
12
  approvalRuleId,
15
13
  steps: approvalRule.steps,
16
14
  criteria: {
17
- rangeType: criteria?.rangeType,
18
- rangeEntity: criteria?.rangeEntity,
19
- range,
15
+ amount: getAmountCriteria(approvalRule.criteria),
16
+ vendor: getVendorCriteria(approvalRule.criteria),
17
+ department: getDepartmentCriteria(approvalRule.criteria),
20
18
  },
19
+ // Approval Rules 3.0 — seed rule-level fields so the form can
20
+ // round-trip them on edit. Each may be undefined on legacy rules.
21
+ name: approvalRule.name,
22
+ description: approvalRule.description,
23
+ separationOfDuties: approvalRule.separationOfDuties,
24
+ isFallback: approvalRule.isFallback,
21
25
  };
22
26
  fetchActions.push(clearBillPaySetupApproverViewUpdateData(), saveBillPaySetupApproverViewUpdateData(billPaySetupApproverViewUpdateData));
23
27
  }
@@ -25,7 +29,7 @@ export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state
25
29
  else {
26
30
  const billPaySetupApproverViewCreateData = {
27
31
  steps: [],
28
- criteria: undefined,
32
+ criteria: {},
29
33
  };
30
34
  fetchActions.push(clearBillPaySetupApproverViewUpdateData(), saveBillPaySetupApproverViewUpdateData(billPaySetupApproverViewCreateData));
31
35
  }
@@ -5,15 +5,25 @@ import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
5
5
  import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { saveBillPaySetupApproverViewUpdates, saveBillPaySetupApproverViewUpdatesFailure, saveBillPaySetupApproverViewUpdatesSuccess, } from '../billPaySetupApproverViewReducer';
8
- import { toApprovalChangableInfoPayload } from '../types/commonPayload';
9
- export const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveBillPaySetupApproverViewUpdates.match), switchMap(() => {
8
+ import { toApprovalChangableInfoPayload, toApprovalChangableInfoPayloadV1, } from '../types/commonPayload';
9
+ export const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveBillPaySetupApproverViewUpdates.match), switchMap((action) => {
10
10
  const { billPaySetupApproverViewState } = state$.value;
11
11
  const billPaySetupApproverViewUpdateData = billPaySetupApproverViewState.billPaySetupApproverViewUpdateData;
12
12
  if (billPaySetupApproverViewUpdateData != null &&
13
13
  billPaySetupApproverViewUpdateData.data != null) {
14
- const payload = toApprovalChangableInfoPayload(billPaySetupApproverViewUpdateData.data);
14
+ // Approval Rules 3.0 — gate URL + write-side payload mapper on
15
+ // the `approval_rule_v3_config` dynamic config. `useV3` arrives
16
+ // on the action payload from the screen connector.
17
+ const { useV3 } = action.payload;
18
+ const payload = useV3
19
+ ? toApprovalChangableInfoPayload(billPaySetupApproverViewUpdateData.data)
20
+ : toApprovalChangableInfoPayloadV1(billPaySetupApproverViewUpdateData.data);
21
+ const endpoint = useV3
22
+ ? // ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
23
+ `https://dev.api.zeni.ai/version/approval/tarun/1.0/bill-pay/approval-rules-v2`
24
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
15
25
  return zeniAPI
16
- .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, payload)
26
+ .postAndGetJSON(endpoint, payload)
17
27
  .pipe(mergeMap((response) => {
18
28
  if (isSuccessResponse(response) && response.data != null) {
19
29
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -1,20 +1,48 @@
1
1
  export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
2
- let criteriaPayload = [];
2
+ // Form-side criteria is a structured object with optional slots for
3
+ // amount / vendor / department; flatten it into the wire format's
4
+ // `conditions[]` array.
5
+ let criteriaPayload;
3
6
  if (approverViewUpdateData.criteria != null) {
4
- const criteria = approverViewUpdateData.criteria;
5
- const { rangeType, rangeEntity, range } = criteria;
6
- const { min, max } = range;
7
- const { currencyCode, currencySymbol } = min;
8
- criteriaPayload = [
9
- {
10
- type: rangeType,
11
- range_entity: rangeEntity,
12
- min: min.amount,
13
- max: max?.amount ?? null,
14
- currency_code: currencyCode,
15
- currency_symbol: currencySymbol,
16
- },
17
- ];
7
+ const { amount, vendor, department } = approverViewUpdateData.criteria;
8
+ const conditions = [];
9
+ if (amount?.min != null) {
10
+ conditions.push({
11
+ field: 'amount',
12
+ type: 'gte',
13
+ value: amount.min.amount,
14
+ });
15
+ }
16
+ if (amount?.max != null) {
17
+ conditions.push({
18
+ field: 'amount',
19
+ type: 'lte',
20
+ value: amount.max.amount,
21
+ });
22
+ }
23
+ if (vendor != null && vendor.vendorIds.length > 0) {
24
+ conditions.push({
25
+ field: 'vendor_id',
26
+ type: vendor.operator === 'is_not' ? 'not_in' : 'in',
27
+ value: vendor.vendorIds,
28
+ });
29
+ }
30
+ if (department != null && department.departmentIds.length > 0) {
31
+ conditions.push({
32
+ field: 'department_id',
33
+ type: department.operator === 'is_not' ? 'not_in' : 'in',
34
+ value: department.departmentIds,
35
+ });
36
+ }
37
+ if (conditions.length > 0) {
38
+ const currency = amount?.min ?? amount?.max ?? null;
39
+ criteriaPayload = {
40
+ conditions,
41
+ criteria_operator: 'and',
42
+ currency_code: currency?.currencyCode ?? 'USD',
43
+ currency_symbol: currency?.currencySymbol ?? '$',
44
+ };
45
+ }
18
46
  }
19
47
  const steps = approverViewUpdateData.steps.map((step) => {
20
48
  return {
@@ -35,10 +63,87 @@ export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
35
63
  });
36
64
  const isUpdate = approverViewUpdateData.approvalRuleId != null;
37
65
  const payload = {
38
- criteria: criteriaPayload,
39
66
  steps,
40
67
  is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
41
68
  };
69
+ if (criteriaPayload != null) {
70
+ payload.criteria = criteriaPayload;
71
+ }
72
+ // Approval Rules 3.0 — surface rule-level fields when the form set them.
73
+ // Send only what the user actually entered: an undefined value means
74
+ // "no opinion" and stays off the wire.
75
+ if (approverViewUpdateData.name != null) {
76
+ payload.name = approverViewUpdateData.name;
77
+ }
78
+ if (approverViewUpdateData.description != null) {
79
+ payload.description = approverViewUpdateData.description;
80
+ }
81
+ if (approverViewUpdateData.separationOfDuties != null) {
82
+ payload.separation_of_duties = approverViewUpdateData.separationOfDuties;
83
+ }
84
+ if (approverViewUpdateData.isFallback != null) {
85
+ payload.is_fallback = approverViewUpdateData.isFallback;
86
+ }
87
+ if (isUpdate) {
88
+ payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
89
+ }
90
+ return payload;
91
+ };
92
+ /**
93
+ * V1 wire mapper — used when `approval_rule_v3_config` resolves to OFF
94
+ * for the current tenant. Translates the form-side amount criteria into
95
+ * the legacy `{rangeType, rangeEntity, range: {min, max}}` shape. The
96
+ * V1 backend does not understand vendor / department criteria or the
97
+ * rule-level 3.0 fields, so those are dropped on the wire.
98
+ *
99
+ * The form-side amount slot is always read as a `range`-style criteria
100
+ * here: V1 schemas only supported ranges, so an absent `min` or `max`
101
+ * falls back to `0` / `Number.MAX_SAFE_INTEGER`.
102
+ */
103
+ export const toApprovalChangableInfoPayloadV1 = (approverViewUpdateData) => {
104
+ const amount = approverViewUpdateData.criteria?.amount;
105
+ const minAmount = amount?.min;
106
+ const maxAmount = amount?.max;
107
+ const currencyCode = minAmount?.currencyCode ?? maxAmount?.currencyCode ?? 'USD';
108
+ const currencySymbol = minAmount?.currencySymbol ?? maxAmount?.currencySymbol ?? '$';
109
+ const steps = approverViewUpdateData.steps.map((step) => {
110
+ return {
111
+ action: step.action,
112
+ operator: step.operator,
113
+ actors: step.actors
114
+ .filter((actor) => actor.subType !== 'admin')
115
+ .map((actor) => {
116
+ return {
117
+ type: actor.type,
118
+ id: actor.userId ?? null,
119
+ sub_type: actor.subType ?? null,
120
+ id_type: actor.idType ?? null,
121
+ is_implicit_actor: actor.isImplicitActor ?? false,
122
+ };
123
+ }),
124
+ };
125
+ });
126
+ const isUpdate = approverViewUpdateData.approvalRuleId != null;
127
+ const payload = {
128
+ steps,
129
+ is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
130
+ criteria: {
131
+ rangeType: 'range',
132
+ rangeEntity: 'currency',
133
+ range: {
134
+ min: {
135
+ amount: minAmount?.amount ?? 0,
136
+ currencyCode,
137
+ currencySymbol,
138
+ },
139
+ max: {
140
+ amount: maxAmount?.amount ?? Number.MAX_SAFE_INTEGER,
141
+ currencyCode,
142
+ currencySymbol,
143
+ },
144
+ },
145
+ },
146
+ };
42
147
  if (isUpdate) {
43
148
  payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
44
149
  }
@@ -1,5 +1,6 @@
1
1
  import recordGet from 'lodash/get';
2
2
  import has from 'lodash/has';
3
+ import { getAmountCriteria } from '../../../../entity/approvalRule/approvalRuleSelector';
3
4
  import { reduceFetchState } from '../../../../commonStateTypes/reduceFetchState';
4
5
  import { getBankAccountByBankAccountId, getBankAccountsByBankAccountIds, } from '../../../../entity/bankAccount/bankAccountSelector';
5
6
  import { getContactById, getContactsByIds, } from '../../../../entity/billPay/contact/contactSelector';
@@ -681,9 +682,13 @@ export const getDefaultWithdrawFromAccount = (state, depositAccounts, companyId,
681
682
  export const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser) => {
682
683
  let isCreatorAlsoApprover = false;
683
684
  const approvalRule = approvalRules.find((rule) => {
684
- const { max, min } = rule.criteria[0].range;
685
+ const amountCriteria = getAmountCriteria(rule.criteria);
686
+ if (amountCriteria?.min == null) {
687
+ return false;
688
+ }
689
+ const { min, max } = amountCriteria;
685
690
  return (billAmount > min.amount &&
686
- (max?.amount != null ? billAmount <= max?.amount : true));
691
+ (max?.amount != null ? billAmount <= max.amount : true));
687
692
  });
688
693
  if (approvalRule != null) {
689
694
  const requireApprovalSteps = approvalRule.steps.filter((step) => step.action === 'require_approval');
@@ -6,9 +6,15 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { deleteRemiApprovalRule, deleteRemiApprovalRuleFailure, deleteRemiApprovalRuleSuccess, } from '../remiSetupApproverViewReducer';
8
8
  export const deleteRemiApprovalRuleEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(deleteRemiApprovalRule.match), switchMap((action) => {
9
- const { approvalRuleId } = action.payload;
9
+ const { approvalRuleId, useV3 } = action.payload;
10
+ // Approval Rules 3.0 — flag-gated endpoint selection.
11
+ const endpoint = useV3
12
+ ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
13
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
10
14
  return zeniAPI
11
- .deleteAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`, { approval_rule_id: approvalRuleId })
15
+ .deleteAndGetJSON(endpoint, {
16
+ approval_rule_id: approvalRuleId,
17
+ })
12
18
  .pipe(mergeMap((response) => {
13
19
  if (isSuccessResponse(response) && response.data != null) {
14
20
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -6,7 +6,7 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { fetchRemiSetupApproverView, fetchRemiSetupApproverViewFailure, fetchRemiSetupApproverViewSuccess, } from '../remiSetupApproverViewReducer';
8
8
  export const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchRemiSetupApproverView.match), switchMap((action) => {
9
- const { cacheOverride, resolveAttributeToUser, includeImplicitActors } = action.payload;
9
+ const { cacheOverride, resolveAttributeToUser, includeImplicitActors, useV3, } = action.payload;
10
10
  const { remiSetupApproverViewState, approvalRuleState } = state$.value;
11
11
  const approvalRules = getApprovalRulesByIds(approvalRuleState, remiSetupApproverViewState.approvalRuleIds);
12
12
  if (cacheOverride === true ||
@@ -14,8 +14,12 @@ export const fetchRemiSetupApproverViewEpic = (actions$, state$, zeniAPI) => act
14
14
  remiSetupApproverViewState.approvalRuleIds.length ||
15
15
  (remiSetupApproverViewState.hasValidState() === false &&
16
16
  remiSetupApproverViewState.fetchState !== 'In-Progress')) {
17
+ // Approval Rules 3.0 — flag-gated endpoint selection.
18
+ const basePath = useV3
19
+ ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
20
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
17
21
  return zeniAPI
18
- .getJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules?query={"is_include_implicit_actors": ${includeImplicitActors}, "is_resolve_attribute_to_user":${resolveAttributeToUser}}`)
22
+ .getJSON(`${basePath}?query={"is_include_implicit_actors": ${includeImplicitActors}, "is_resolve_attribute_to_user":${resolveAttributeToUser}}`)
19
23
  .pipe(mergeMap((response) => {
20
24
  if (isSuccessResponse(response) && response.data != null) {
21
25
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -1,6 +1,6 @@
1
1
  import { from } from 'rxjs';
2
2
  import { filter, mergeMap } from 'rxjs/operators';
3
- import { getApprovalRuleById } from '../../../../../entity/approvalRule/approvalRuleSelector';
3
+ import { getAmountCriteria, getApprovalRuleById, getDepartmentCriteria, getVendorCriteria, } from '../../../../../entity/approvalRule/approvalRuleSelector';
4
4
  import { clearRemiSetupApproverViewUpdateData, initializeRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdateData, } from '../remiSetupApproverViewReducer';
5
5
  export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$) => actions$.pipe(filter(initializeRemiSetupApproverViewUpdateData.match), mergeMap((action) => {
6
6
  const { approvalRuleId } = action.payload;
@@ -8,16 +8,20 @@ export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$)
8
8
  if (approvalRuleId != null) {
9
9
  const approvalRule = getApprovalRuleById(state$.value.approvalRuleState, approvalRuleId);
10
10
  if (approvalRule != null) {
11
- const criteria = approvalRule.criteria[0];
12
- const range = criteria?.range;
13
11
  const remiSetupApproverViewUpdateData = {
14
12
  approvalRuleId,
15
13
  steps: approvalRule.steps,
16
14
  criteria: {
17
- rangeType: criteria?.rangeType,
18
- rangeEntity: criteria?.rangeEntity,
19
- range,
15
+ amount: getAmountCriteria(approvalRule.criteria),
16
+ vendor: getVendorCriteria(approvalRule.criteria),
17
+ department: getDepartmentCriteria(approvalRule.criteria),
20
18
  },
19
+ // Approval Rules 3.0 — seed rule-level fields so the form can
20
+ // round-trip them on edit. Each may be undefined on legacy rules.
21
+ name: approvalRule.name,
22
+ description: approvalRule.description,
23
+ separationOfDuties: approvalRule.separationOfDuties,
24
+ isFallback: approvalRule.isFallback,
21
25
  };
22
26
  fetchActions.push(clearRemiSetupApproverViewUpdateData(), saveRemiSetupApproverViewUpdateData(remiSetupApproverViewUpdateData));
23
27
  }
@@ -25,7 +29,7 @@ export const initializeRemiSetupApproverViewUpdateDataEpic = (actions$, state$)
25
29
  else {
26
30
  const remiSetupApproverViewCreateData = {
27
31
  steps: [],
28
- criteria: undefined,
32
+ criteria: {},
29
33
  };
30
34
  fetchActions.push(clearRemiSetupApproverViewUpdateData(), saveRemiSetupApproverViewUpdateData(remiSetupApproverViewCreateData));
31
35
  }
@@ -4,16 +4,25 @@ import { updateApprovalRules } from '../../../../../entity/approvalRule/approval
4
4
  import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
5
5
  import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
- import { toApprovalChangableInfoPayload } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
7
+ import { toApprovalChangableInfoPayload, toApprovalChangableInfoPayloadV1, } from '../../../billPay/billPaySetupApproverView/types/commonPayload';
8
8
  import { saveRemiSetupApproverViewUpdates, saveRemiSetupApproverViewUpdatesFailure, saveRemiSetupApproverViewUpdatesSuccess, } from '../remiSetupApproverViewReducer';
9
- export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap(() => {
9
+ export const saveRemiSetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveRemiSetupApproverViewUpdates.match), switchMap((action) => {
10
10
  const { remiSetupApproverViewState } = state$.value;
11
11
  const remiSetupApproverViewUpdateData = remiSetupApproverViewState.remiSetupApproverViewUpdateData;
12
12
  if (remiSetupApproverViewUpdateData != null &&
13
13
  remiSetupApproverViewUpdateData.data != null) {
14
- const payload = toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data);
14
+ // Approval Rules 3.0 — gate URL + write-side payload mapper on
15
+ // the `approval_rule_v3_config` dynamic config. `useV3` arrives
16
+ // on the action payload from the screen connector.
17
+ const { useV3 } = action.payload;
18
+ const payload = useV3
19
+ ? toApprovalChangableInfoPayload(remiSetupApproverViewUpdateData.data)
20
+ : toApprovalChangableInfoPayloadV1(remiSetupApproverViewUpdateData.data);
21
+ const endpoint = useV3
22
+ ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules-v2`
23
+ : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`;
15
24
  return zeniAPI
16
- .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/reimbursements/approval-rules`, payload)
25
+ .postAndGetJSON(endpoint, payload)
17
26
  .pipe(mergeMap((response) => {
18
27
  if (isSuccessResponse(response) && response.data != null) {
19
28
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -26,12 +26,16 @@ const remiSetupApproverView = createSlice({
26
26
  draft.fetchState = 'In-Progress';
27
27
  draft.error = undefined;
28
28
  },
29
- prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false) {
29
+ // Approval Rules 3.0 `useV3` arrives from the screen connector
30
+ // (`approval_rule_v3_config` dynamic config) and picks v1 vs v2
31
+ // endpoint in the fetch epic.
32
+ prepare(cacheOverride = false, resolveAttributeToUser = false, includeImplicitActors = false, useV3 = false) {
30
33
  return {
31
34
  payload: {
32
35
  cacheOverride,
33
36
  resolveAttributeToUser,
34
37
  includeImplicitActors,
38
+ useV3,
35
39
  },
36
40
  };
37
41
  },
@@ -134,8 +138,11 @@ const remiSetupApproverView = createSlice({
134
138
  error: undefined,
135
139
  };
136
140
  },
137
- prepare(approvalRuleId) {
138
- return { payload: { approvalRuleId } };
141
+ // Approval Rules 3.0 — `useV3` flows from the screen connector
142
+ // (`approval_rule_v3_config` dynamic config) so the delete epic
143
+ // can pick the v1 vs v2 endpoint.
144
+ prepare(approvalRuleId, useV3 = false) {
145
+ return { payload: { approvalRuleId, useV3 } };
139
146
  },
140
147
  },
141
148
  deleteRemiApprovalRuleSuccess: {
@@ -167,13 +174,21 @@ const remiSetupApproverView = createSlice({
167
174
  };
168
175
  },
169
176
  },
170
- saveRemiSetupApproverViewUpdates(draft) {
171
- if (draft.remiSetupApproverViewUpdateData != null) {
172
- draft.remiSetupApproverViewUpdateData.updateStatus = {
173
- fetchState: 'In-Progress',
174
- error: undefined,
175
- };
176
- }
177
+ saveRemiSetupApproverViewUpdates: {
178
+ // Approval Rules 3.0 `useV3` sourced from
179
+ // `approval_rule_v3_config` dynamic config in the screen
180
+ // connector; epic uses it to pick v1 vs v2 URL + mapper.
181
+ reducer(draft, _action) {
182
+ if (draft.remiSetupApproverViewUpdateData != null) {
183
+ draft.remiSetupApproverViewUpdateData.updateStatus = {
184
+ fetchState: 'In-Progress',
185
+ error: undefined,
186
+ };
187
+ }
188
+ },
189
+ prepare(useV3) {
190
+ return { payload: { useV3 } };
191
+ },
177
192
  },
178
193
  saveRemiSetupApproverViewUpdatesSuccess: {
179
194
  reducer(draft, action) {
package/lib/index.d.ts CHANGED
@@ -52,7 +52,8 @@ import { AccountReconciliationEntity, getAccountReconByAccountIdAndSelectedPerio
52
52
  import { BalanceDataStatusCodeType, BankStatusCodeType, RecommendedActionCodeType, ReconciliationStatusCodeType, StatementDataStatusCodeType, StatementStatusCodeType, TransactionsToReview } from './entity/accountRecon/accountReconState';
53
53
  import { getAddressByAddressId } from './entity/address/addressSelector';
54
54
  import { Address } from './entity/address/addressState';
55
- import { Actor, ActorType, ApprovalActionType, ApprovalRule, ApprovalRuleState, Approvers, AttributeType, RoleType, Step, StepOperatorType, toAttributeOrRoleTypeStrict, toAttributeTypeStrict, toRoleTypeStrict } from './entity/approvalRule/approvalRuleState';
55
+ import { Actor, ActorType, AmountComparator, AmountCriteria, ApprovalActionType, ApprovalRule, ApprovalRuleState, Approvers, AttributeType, Criteria, DepartmentCriteria, RoleType, Step, StepOperatorType, VendorCriteria, toAttributeOrRoleTypeStrict, toAttributeTypeStrict, toRoleTypeStrict } from './entity/approvalRule/approvalRuleState';
56
+ import { getAmountCriteria, getApprovalRulesByEntityType, getDepartmentCriteria, getFallbackApprovalRule, getVendorCriteria } from './entity/approvalRule/approvalRuleSelector';
56
57
  import { BankAccount } from './entity/bankAccount/bankAccount';
57
58
  import { BillPayInfo, BillPaymentRefundStatus, BillPaymentRefundStatusCodeType, BillPaymentStatus, BillPaymentStatusCodeType, BillStage, BillStageCodeType, BillStatus, BillStatusCodeType, BillTransaction, DeletionSourceType, InternationalTransferFeeBearerPaymentMethod, toOutsideZeniPaymentModeType } from './entity/billPay/billTransaction/billTransactionState';
58
59
  import { Contact } from './entity/billPay/contact/contact';
@@ -808,7 +809,7 @@ export { RemiSetupViewState, RemiSetupViewLocalData, MileageDetailsLocalData, Mi
808
809
  export { PaymentAccount, Logo, VERIFIED_PAYMENT_ACCOUNT_PROVIDER_VERIFICATION_STATUS, };
809
810
  export { SubscriptionPaymentAccount };
810
811
  export { PreviousBillsSelectorView, InvoiceProcessingPayload, InvoiceProcessingResponse, isSuccessResponse, isInvalidSessionError, isAccessDeniedError, };
811
- export { Step, Actor as ApprovalRuleActor, ActorType, ApprovalActionType, StepOperatorType, ApprovalRuleState, ApprovalRule, AttributeType, Approvers, RoleType, EntityApprovalStatusState, EntityApprovalStatus, SpendManagementEntityType, SpendManagementEntityTypeWithOtherConnection, toAttributeTypeStrict, toAttributeOrRoleTypeStrict, toRoleTypeStrict, };
812
+ export { Step, Actor as ApprovalRuleActor, ActorType, ApprovalActionType, StepOperatorType, ApprovalRuleState, ApprovalRule, AmountComparator, AmountCriteria, Criteria, DepartmentCriteria, VendorCriteria, AttributeType, Approvers, RoleType, EntityApprovalStatusState, EntityApprovalStatus, SpendManagementEntityType, SpendManagementEntityTypeWithOtherConnection, getAmountCriteria, getApprovalRulesByEntityType, getDepartmentCriteria, getFallbackApprovalRule, getVendorCriteria, toAttributeTypeStrict, toAttributeOrRoleTypeStrict, toRoleTypeStrict, };
812
813
  export { ApprovalRuleUpdateData, ApprovalRuleCreateData, BillPayApprovalRuleWithUser, ApprovalUpdateActionType, ApproverViewUpdateData, BillPaySetupApproverViewState, BillPaySetupApproverView, BillPaySetupApproverUpdateDataView, getBillPaySetupApproverView, getBillPaySetupApproverUpdateDataView, fetchBillPaySetupApproverView, fetchBillPayApproversDetails, fetchBillPayApproversList, deleteBillPayApprovalRule, saveBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdates, setBillsSetupApproverViewListeningToPusherEvent, initializeBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverView, };
813
814
  export { RemiApprovalRuleWithUser, RemiSetupApproverViewState, RemiSetupApproverView, RemiSetupApproverUpdateDataView, getRemiSetupApproverView, getRemiSetupApproverUpdateDataView, fetchRemiSetupApproverView, fetchRemiApproversList, fetchRemiApproversDetails, deleteRemiApprovalRule, saveRemiSetupApproverViewUpdateData, saveRemiSetupApproverViewUpdates, initializeRemiSetupApproverViewUpdateData, setRemiSetupApproverViewListeningToPusherEvent, clearRemiSetupApproverViewUpdateData, clearRemiSetupApproverView, };
814
815
  export { RemiDetailViewSelector, getRemiDetailView, RemiActivity, RemiDetails, checkApproveRejectBtnShowForRemi, };