@zeniai/client-epic-state 5.0.75 → 5.0.76

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -3,8 +3,7 @@ import recordGet from 'lodash/get';
 import uniq from 'lodash/uniq';
 import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { isVendorTransaction } from '../../../entity/transaction/stateTypes/vendorTransaction';
-import { filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, shouldAutoSelectAndAdd, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
-import { DEFAULT_COMPLETED_SUB_TAB, } from '../types/completedSubTab';
+import { MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
 export const initialTransactionTabViewState = {
     saveStatus: {
         fetchState: 'Not-Started',
@@ -28,10 +27,6 @@ export const initialTransactionTabViewState = {
         totalCount: {},
         limit: 10,
     },
-    filters: {
-        categoryCombinationOperator: 'AND',
-        categories: [],
-    },
     fetchState: 'Not-Started',
     error: undefined,
     hasValidState() {
@@ -46,74 +41,12 @@ export const initialTransactionTabViewState = {
     selectedTransactionLineId: undefined,
 };
 export const initialState = {
-    autoCategorizedSubTabCache: {},
-    parentTotalCountByTab: {
-        review: {},
-        autoCategorized: {},
-    },
     selectedTransactionCategorizationTab: 'review',
-    selectedTransactionCategorizationCompletedSubTab: DEFAULT_COMPLETED_SUB_TAB,
     transactionCategorizationView: {
         review: { ...initialTransactionTabViewState },
         autoCategorized: { ...initialTransactionTabViewState },
     },
 };
-/**
- * Capture the autoCategorized tab's current paginated dataset for a sub-tab.
- * The mid-flight `'In-Progress'` state is normalised to `'Completed'` because
- * the in-flight request is cancelled by `switchMap` in the fetch epic when the
- * sub-tab changes — restoring `'In-Progress'` later would leave the UI stuck
- * showing a phantom loading state with no fetch actually running. Length-zero
- * datasets degrade to `'Not-Started'` so the next visit triggers a fresh
- * fetch from page 1 instead of short-circuiting on stale empty caches.
- *
- * Snapshot scope (deliberately narrow):
- * - Captured: `pageToken`, `totalCount`, `transactionIdsBySelectedPeriod`,
- *   `fetchState`, `error`, `scrollPosition`. The first five are the keys the
- *   fetch epic's cache check reads to decide whether to short-circuit a
- *   sub-tab revisit; `scrollPosition` is captured per sub-tab so revisiting
- *   restores the user's last offset and switching to a never-visited sub-tab
- *   starts at the top instead of inheriting the outgoing sub-tab's offset
- *   (which would land the user at a meaningless row index against a
- *   completely different list).
- * - Intentionally NOT captured (left in place on `autoCat` and inherited by
- *   the incoming sub-tab):
- *     - `uiState.searchString`, `uiState.sortKey`, `uiState.sortOrder`,
- *       `uiState.nodeCollapseState`, `uiState.limit` — search and sort are
- *       user-applied preferences that persist across sub-tabs by design (a
- *       search query stays active when the user toggles between Manual / AI
- *       Accountant).
- *     - `selectedCheckBoxTransactionIds` — selection state is intentionally
- *       cleared at the action source (the fetch epic / save flow), not
- *       by the snapshot path. Carrying selection across sub-tabs is safe
- *       because every sub-tab change goes through a fetch round-trip that
- *       reconciles selection against the new row IDs.
- *     - `transactionReviewLocalDataById`, `transactionIdsWithUnsavedData`,
- *       `uploadReceiptStatusById`, `saveStatus`, `refreshStatus`,
- *       `markAsNotMiscategorizedStatus` — these are per-row / per-flight
- *       caches that are write-through global state, not sub-tab-scoped.
- *
- * If the contract changes (e.g. selection should reset on every sub-tab
- * switch), update both this comment and the snapshot return shape together.
- */
-function snapshotAutoCategorizedTab(autoCat) {
-    const transactionIdsBySelectedPeriod = {
-        ...autoCat.transactionIdsBySelectedPeriod,
-    };
-    const hasAnyLoadedRows = Object.values(transactionIdsBySelectedPeriod).some((ids) => ids.length > 0);
-    let normalisedFetchState = autoCat.fetchState;
-    if (normalisedFetchState === 'In-Progress') {
-        normalisedFetchState = hasAnyLoadedRows ? 'Completed' : 'Not-Started';
-    }
-    return {
-        error: autoCat.error,
-        fetchState: normalisedFetchState,
-        pageToken: autoCat.uiState.pageToken,
-        scrollPosition: autoCat.uiState.scrollPosition,
-        totalCount: { ...autoCat.uiState.totalCount },
-        transactionIdsBySelectedPeriod,
-    };
-}
 const expenseAutomationTransactionsView = createSlice({
     name: 'expenseAutomationTransactionsView',
     initialState,
@@ -303,12 +236,6 @@ const expenseAutomationTransactionsView = createSlice({
                     uiState.totalCount;
             }
         },
-        updateTransactionFilters(draft, action) {
-            const { selectedTab, filters } = action.payload;
-            // `filters` is non-nullable per the payload type, so no runtime
-            // null-check is needed — dropping it removes a dead defensive branch.
-            draft.transactionCategorizationView[selectedTab].filters = filters;
-        },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
                 return {
@@ -333,55 +260,6 @@ const expenseAutomationTransactionsView = createSlice({
                 return { payload: { newSelectedTab } };
             },
         },
-        updateTransactionCategorizationCompletedSubTab: {
-            reducer(draft, action) {
-                const { newSubTab } = action.payload;
-                const previousSubTab = draft.selectedTransactionCategorizationCompletedSubTab;
-                if (previousSubTab === newSubTab) {
-                    return;
-                }
-                const autoCat = draft.transactionCategorizationView.autoCategorized;
-                // Snapshot the outgoing sub-tab so a future revisit can short-circuit
-                // the fetch epic (mirrors the parent-tab "don't refetch what's
-                // already cached" behaviour). Period-scoped data is preserved as-is
-                // because the snapshot itself is keyed only by sub-tab; the active
-                // tab's per-period maps remain the source of truth while live.
-                draft.autoCategorizedSubTabCache[previousSubTab] =
-                    snapshotAutoCategorizedTab(autoCat);
-                const cached = draft.autoCategorizedSubTabCache[newSubTab];
-                if (cached != null) {
-                    autoCat.uiState.pageToken = cached.pageToken;
-                    autoCat.uiState.totalCount = { ...cached.totalCount };
-                    autoCat.uiState.scrollPosition = cached.scrollPosition;
-                    autoCat.transactionIdsBySelectedPeriod = {
-                        ...cached.transactionIdsBySelectedPeriod,
-                    };
-                    autoCat.fetchState = cached.fetchState;
-                    autoCat.error = cached.error;
-                }
-                else {
-                    // Sub-tab has never been visited — clear the active slot so the
-                    // view-epic's `fetchState === 'Not-Started' || transactionIds.length
-                    // === 0` cache check falls through and triggers a fresh page-1
-                    // fetch for the new dataset. `scrollPosition` is reset to the top
-                    // so the incoming list isn't anchored to the outgoing sub-tab's
-                    // offset (different rows → previous offset is meaningless).
-                    autoCat.uiState.pageToken = null;
-                    autoCat.uiState.totalCount = {};
-                    autoCat.uiState.scrollPosition = {
-                        scrollTop: 0,
-                        scrollLeft: undefined,
-                    };
-                    autoCat.transactionIdsBySelectedPeriod = {};
-                    autoCat.fetchState = 'Not-Started';
-                    autoCat.error = undefined;
-                }
-                draft.selectedTransactionCategorizationCompletedSubTab = newSubTab;
-            },
-            prepare(newSubTab) {
-                return { payload: { newSubTab } };
-            },
-        },
         updateTransactionCategorization: {
             reducer(draft, action) {
                 const selectedTab = action.payload.selectedTab;
@@ -430,9 +308,12 @@ const expenseAutomationTransactionsView = createSlice({
                     const selectedCheckBoxTransactionIds = draft.transactionCategorizationView[selectedTab]
                         .selectedCheckBoxTransactionIds;
                     if (selectedTransaction != null &&
-                        shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                        checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
+                        selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
+                        selectedCheckBoxTransactionIds.includes(transactionId) === false) {
                         draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
-                            ...selectedCheckBoxTransactionIds,
+                            ...draft.transactionCategorizationView[selectedTab]
+                                .selectedCheckBoxTransactionIds,
                             transactionId,
                         ];
                     }
@@ -515,26 +396,9 @@ const expenseAutomationTransactionsView = createSlice({
                 const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
                     .transactionReviewLocalDataById, transactionId.id, undefined);
                 if (transactionLocalData != null) {
-                    const newLocalData = setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
-                    // Release the per-line fetch flag for every line this fetch
-                    // covered. Done in-place on the freshly returned local data
-                    // (the helper produces a new mutable object), before we write
-                    // it back to the draft.
-                    lineIds.forEach((lineId) => {
-                        const lineItem = newLocalData.lineItemById[lineId];
-                        if (lineItem != null) {
-                            newLocalData.lineItemById[lineId] = {
-                                ...lineItem,
-                                categoryClassRecommendationsFetchState: {
-                                    fetchState: 'Completed',
-                                    error: undefined,
-                                },
-                            };
-                        }
-                    });
                     draft.transactionCategorizationView[selectedTab].transactionReviewLocalDataById[transaction.id] = {
                         transactionId: transaction.id,
-                        transactionReviewLocalData: newLocalData,
+                        transactionReviewLocalData: setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled),
                     };
                     // Mark transaction as dirty (autofill happened)
                     if (!draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData.includes(transaction.id)) {
@@ -547,99 +411,6 @@ const expenseAutomationTransactionsView = createSlice({
                 }
             },
         },
-        // Start arm of the line-update recommendations fetch. Flips covered
-        // lines to In-Progress AND removes the transaction from
-        // selectedCheckBoxTransactionIds — the row is unchecked + disabled
-        // until either the success arm (recheck if limit allows) or the
-        // failure arm releases the per-line flag.
-        markCategoryClassRecommendationsInProgressForCategorization: {
-            reducer(draft, action) {
-                const { selectedTab, transactionId, lineIds } = action.payload;
-                const tab = draft.transactionCategorizationView[selectedTab];
-                const transactionLocalData = recordGet(tab.transactionReviewLocalDataById, transactionId.id, undefined);
-                if (transactionLocalData != null) {
-                    lineIds.forEach((lineId) => {
-                        const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
-                        if (lineItem != null) {
-                            transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
-                                ...lineItem,
-                                categoryClassRecommendationsFetchState: {
-                                    fetchState: 'In-Progress',
-                                    error: undefined,
-                                },
-                            };
-                        }
-                    });
-                }
-                // Uncheck on fetch start: the row's existing category/class are
-                // stale after a payee change, so we drop the auto-selection until
-                // fresh recommendations land.
-                if (tab.selectedCheckBoxTransactionIds.includes(transactionId.id)) {
-                    tab.selectedCheckBoxTransactionIds =
-                        tab.selectedCheckBoxTransactionIds.filter((id) => id !== transactionId.id);
-                }
-            },
-            prepare(selectedTab, transactionId, lineIds) {
-                return { payload: { selectedTab, transactionId, lineIds } };
-            },
-        },
-        // Completed arm. Used by the epic when the HTTP call succeeds but the
-        // server returned no per-line recommendations — we still need to
-        // release the In-Progress flag so the skeleton resolves. Successful
-        // responses with recommendations go through
-        // setEntityRecommendationForLineIdsForCategorization instead (which
-        // also flips the lines to Completed).
-        markCategoryClassRecommendationsCompletedForCategorization: {
-            reducer(draft, action) {
-                const { selectedTab, transactionId, lineIds } = action.payload;
-                const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
-                    .transactionReviewLocalDataById, transactionId.id, undefined);
-                if (transactionLocalData != null) {
-                    lineIds.forEach((lineId) => {
-                        const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
-                        if (lineItem != null) {
-                            transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
-                                ...lineItem,
-                                categoryClassRecommendationsFetchState: {
-                                    fetchState: 'Completed',
-                                    error: undefined,
-                                },
-                            };
-                        }
-                    });
-                }
-            },
-            prepare(selectedTab, transactionId, lineIds) {
-                return { payload: { selectedTab, transactionId, lineIds } };
-            },
-        },
-        // Failure arm. Flips covered lines to Error so the skeleton resolves
-        // and downstream UI can react to the failure. The transaction stays
-        // unchecked from the start-arm action.
-        markCategoryClassRecommendationsFailureForCategorization: {
-            reducer(draft, action) {
-                const { selectedTab, transactionId, lineIds, error } = action.payload;
-                const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
-                    .transactionReviewLocalDataById, transactionId.id, undefined);
-                if (transactionLocalData != null) {
-                    lineIds.forEach((lineId) => {
-                        const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
-                        if (lineItem != null) {
-                            transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
-                                ...lineItem,
-                                categoryClassRecommendationsFetchState: {
-                                    fetchState: 'Error',
-                                    error,
-                                },
-                            };
-                        }
-                    });
-                }
-            },
-            prepare(selectedTab, transactionId, lineIds, error) {
-                return { payload: { selectedTab, transactionId, lineIds, error } };
-            },
-        },
         fetchTransactionCategorizationSuccess(draft, action) {
             const { selectedTab, refreshViewInBackground } = action.payload;
             if (draft.transactionCategorizationView[selectedTab].fetchState ===
@@ -735,7 +506,9 @@ const expenseAutomationTransactionsView = createSlice({
                     .selectedCheckBoxTransactionIds;
                 if (newTransactionLocalData.customer != null &&
                     newTransactionLocalData.customer.id != null &&
-                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                    checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
+                    selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
+                    selectedCheckBoxTransactionIds.includes(transactionId) === false) {
                     draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
                         ...selectedCheckBoxTransactionIds,
                         transactionId,
@@ -809,7 +582,9 @@ const expenseAutomationTransactionsView = createSlice({
                     .selectedCheckBoxTransactionIds;
                 if (newTransactionLocalData.vendor != null &&
                     newTransactionLocalData.vendor.id != null &&
-                    shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
+                    checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
+                    selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
+                    selectedCheckBoxTransactionIds.includes(transactionId) === false) {
                     draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
                         ...selectedCheckBoxTransactionIds,
                         transactionId,
@@ -922,10 +697,6 @@ const expenseAutomationTransactionsView = createSlice({
             const { selectedTab, selectedPeriod, totalCount } = action.payload;
             draft.transactionCategorizationView[selectedTab].uiState.totalCount[toMonthYearPeriodId(selectedPeriod)] = totalCount;
         },
-        updateParentTotalCountForTab(draft, action) {
-            const { selectedTab, selectedPeriod, parentTotalCount } = action.payload;
-            draft.parentTotalCountByTab[selectedTab][toMonthYearPeriodId(selectedPeriod)] = parentTotalCount;
-        },
         updateSelectedCheckboxTransactionIds(draft, action) {
             const selectedTab = action.payload.selectedTab;
             const transactionIds = action.payload.transactionIds;
@@ -936,16 +707,6 @@ const expenseAutomationTransactionsView = createSlice({
             draft.transactionCategorizationView[selectedTab] = {
                 ...initialTransactionTabViewState,
             };
-            draft.parentTotalCountByTab[selectedTab] = {};
-            // The per-sub-tab snapshot cache lives at the slice root and is
-            // exclusively populated by the autoCategorized tab's sub-tab switching
-            // (see updateTransactionCategorizationCompletedSubTab). When that tab
-            // is reset, leaving stale snapshots behind would short-circuit the
-            // next sub-tab visit with phantom row IDs / page tokens that no longer
-            // correspond to anything in state — drop them in lockstep.
-            if (selectedTab === 'autoCategorized') {
-                draft.autoCategorizedSubTabCache = {};
-            }
         },
         clearExpenseAutomationTransactionsView(draft) {
             Object.assign(draft, initialState);
@@ -1042,5 +803,5 @@ const expenseAutomationTransactionsView = createSlice({
         },
     },
 });
-export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, updateTransactionFilters, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, updateParentTotalCountForTab, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, markCategoryClassRecommendationsInProgressForCategorization, markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
+export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
 export default expenseAutomationTransactionsView.reducer;

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -1,90 +1,17 @@
-import { createSelector } from '@reduxjs/toolkit';
 import omit from 'lodash/omit';
 import { reduceAllFetchState, reduceAnyFetchState, } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant, getIsAccountingClassesEnabled, getIsAccountingProjectsEnabled, } from '../../../entity/tenant/tenantSelector';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
 import { getSupportedTransactionsByIds } from '../../../entity/transaction/transactionSelector';
-import { applyTransactionFilters, } from '../transactionFilterHelpers';
 import { getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
 import { getProjectList } from '../../projectList/projectListSelector';
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
-// Walks the tab's transactionReviewLocalDataById map and returns
-// `{ [transactionId]: true }` for every transaction that has at least
-// one line whose targeted-fetch is In-Progress. Pulled out as a plain
-// function so each tab's createSelector can share it.
-const computeCategorizationInFlightRecommendations = (transactionReviewLocalDataById) => {
-    const result = {};
-    if (transactionReviewLocalDataById == null) {
-        return result;
-    }
-    for (const [transactionId, data] of Object.entries(transactionReviewLocalDataById)) {
-        const lineItems = Object.values(data.transactionReviewLocalData.lineItemById);
-        if (lineItems.some((lineItem) => lineItem.categoryClassRecommendationsFetchState?.fetchState ===
-            'In-Progress')) {
-            result[transactionId] = true;
-        }
-    }
-    return result;
-};
-// Per-tab createSelector instances. Each one is memoized on its OWN tab's
-// transactionReviewLocalDataById reference. Switching tabs A->B->A no
-// longer busts the memo for tab A — the dispatcher below just returns
-// whichever per-tab selector matches the active tab, and reselect keeps
-// the prior result alive as long as the underlying slice ref is stable.
-const getReviewInFlightRecommendationsByTransactionId = createSelector((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
-    .review.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
-const getAutoCategorizedInFlightRecommendationsByTransactionId = createSelector((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
-    .autoCategorized.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
-// Per-transaction "any line is fetching category/class recommendations?"
-// map for the active categorization tab. Dispatches to the per-tab
-// memoized selector above so steady state (no fetches in flight)
-// recomputes only when the active tab's local data changes; tab switches
-// are O(1) cache lookups.
-//
-// `default` guards against the union "lying" at runtime: `TransactionsTab`
-// is produced via `stringToUnion`, which falls back to `s as StringUnion`
-// for unrecognized strings, so an unexpected value can land in state. The
-// downstream `getCategorizationHasInFlightRecommendations` calls
-// `Object.keys` on this result, so we must always return an object.
-export const getCategorizationInFlightRecommendationsByTransactionId = (state) => {
-    const tab = state.expenseAutomationTransactionsViewState
-        .selectedTransactionCategorizationTab;
-    switch (tab) {
-        case 'review':
-            return getReviewInFlightRecommendationsByTransactionId(state);
-        case 'autoCategorized':
-            return getAutoCategorizedInFlightRecommendationsByTransactionId(state);
-        default:
-            return {};
-    }
-};
-// Page-level "any line on the active tab is in flight?" flag. Drives the
-// list-page Save disable.
-export const getCategorizationHasInFlightRecommendations = createSelector(getCategorizationInFlightRecommendationsByTransactionId, (inFlightByTransactionId) => Object.keys(inFlightByTransactionId).length > 0);
-export const toTransactionView = (transaction, transactionLocalData) => {
-    return {
-        id: transaction.id,
-        date: transaction.date,
-        amount: transaction.amount,
-        vendorName: transaction.vendorName,
-        customerName: transaction.customerName,
-        vendorId: transaction.vendorId,
-        customerId: transaction.customerId,
-        description: transaction.description,
-        memo: transaction.memo,
-        type: transaction.type,
-        typeName: transaction.typeName,
-        createTime: transaction.createTime,
-        transaction: transaction,
-        transactionLocalData,
-    };
-};
 export function getExpenseAutomationTransactionView(state) {
     const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, filters, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
+    const { selectedTransactionCategorizationTab } = expenseAutomationTransactionsViewState;
+    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = getUncategorizedAccounts(accountState, accountListState, 'accountList');
     const accountList = getAccountList(accountState, accountListState, 'accountList');
     const classList = getClassList(classState, classListState);
@@ -103,58 +30,20 @@ export function getExpenseAutomationTransactionView(state) {
         ? transactionIdsBySelectedPeriod[monthYearPeriodId]
         : null;
     const transactionIds = transactionIdsForSelectedPeriod ?? [];
-    const transactions = getSupportedTransactionsByIds(transactionState, transactionIds);
-    const transactionsWithCOT = transactions.map((transaction) => getTransactionWithCOT(transaction));
-    const transactionLocalDataMap = new Map();
-    transactionIds.forEach((transactionId) => {
+    const transactionLocalData = transactionIds
+        .map((transactionId) => {
         const transactionData = transactionReviewLocalDataById[transactionId];
         if (transactionData != null) {
-            transactionLocalDataMap.set(transactionId, {
+            return {
                 transactionId,
                 transactionReviewLocalData: transactionData.transactionReviewLocalData,
-            });
+            };
         }
-    });
-    // Step 2: Convert to TransactionView and apply advanced filters
-    const transactionViews = transactionsWithCOT.map((transaction) => {
-        const localData = transactionLocalDataMap.get(transaction.id);
-        return toTransactionView(transaction, localData);
-    });
-    // Apply TC-specific filters (lives under expenseAutomationView, independent
-    // of the Spend Management filter pipeline).
-    const filteredTransactionViews = applyTransactionFilters(transactionViews, filters);
-    // Convert back to TransactionWithCOT for return
-    const filteredTransactionsWithCOT = filteredTransactionViews.map((view) => view.transaction);
-    // Get transactionLocalData for filtered transactions
-    // Also include transactionLocalData for transactions that don't exist in transactionState
-    // but have local data (to match original behavior)
-    const filteredTransactionIds = new Set(filteredTransactionViews.map((view) => view.id));
-    // Pre-compute the membership set once. The previous implementation called
-    // `transactions.some(t => t.id === transactionId)` inside the per-id loop,
-    // turning the pipeline into O(n × m) — measurable on tenants with large
-    // transaction lists since this selector runs on every Redux dispatch.
-    const transactionExistsById = new Set(transactions.map((t) => t.id));
-    // `.flatMap` returns `X[]` directly when the callback returns `[]` for the
-    // skip case, so we don't need the trailing `.filter((d): d is X => …)` type
-    // predicate that the previous `map → filter` pipeline required.
-    const filteredTransactionLocalData = transactionIds.flatMap((transactionId) => {
-        const transactionData = transactionReviewLocalDataById[transactionId];
-        if (transactionData == null) {
-            return [];
-        }
-        // Include if transaction is in filtered results, or if transaction doesn't exist in state
-        // (to maintain backward compatibility with tests)
-        const transactionExists = transactionExistsById.has(transactionId);
-        if (filteredTransactionIds.has(transactionId) || !transactionExists) {
-            return [
-                {
-                    transactionId,
-                    transactionReviewLocalData: transactionData.transactionReviewLocalData,
-                },
-            ];
-        }
-        return [];
-    });
+        return null;
+    })
+        .filter((transaction) => transaction != null);
+    const transactions = getSupportedTransactionsByIds(transactionState, transactionIds);
+    const transactionsWithCOT = transactions.map((transaction) => getTransactionWithCOT(transaction));
     const monthEndFetchState = monthYearPeriodId != null
         ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
         : { fetchState: 'Not-Started', error: undefined };
@@ -174,27 +63,10 @@ export function getExpenseAutomationTransactionView(state) {
         .uiState.totalCount;
     const totalCountByAutoCat = expenseAutomationTransactionsViewState.transactionCategorizationView
         .autoCategorized.uiState.totalCount;
-    // Per-(sub-)tab counts powering pagination, in-list "showing X of Y", and
-    // any save/refresh round-trips. Sourced from `uiState.totalCount` which
-    // mirrors the response's `total_count` for whatever tab/sub-tab the user is
-    // viewing (e.g. only the Manual sub-tab rows for Completed → Manual).
     const totalCountByTab = {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
-    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
-    // listing response and used exclusively by the navbar / tab strip badges.
-    // Independent of which Completed sub-tab is active so the badge stays
-    // stable across sub-tab switches.
-    const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
-    const parentTabTotalCountByTab = {
-        review: monthYearPeriodId != null
-            ? (parentTotalCountByTab.review[monthYearPeriodId] ?? 0)
-            : 0,
-        autoCategorized: monthYearPeriodId != null
-            ? (parentTotalCountByTab.autoCategorized[monthYearPeriodId] ?? 0)
-            : 0,
-    };
     const fetchStateByTab = {
         review: {
             fetchState: expenseAutomationTransactionsViewState.transactionCategorizationView
@@ -214,13 +86,11 @@ export function getExpenseAutomationTransactionView(state) {
         : [];
     const transactionCompletionStatus = allSteps.find((step) => step.step === 'transaction_categorization')?.completionStatus;
     const completionStatus = transactionCompletionStatus ?? 'incomplete';
-    const inFlightCategoryClassRecommendationsByTransactionId = getCategorizationInFlightRecommendationsByTransactionId(state);
-    const hasInFlightCategoryClassRecommendations = getCategorizationHasInFlightRecommendations(state);
     return {
         version: 0,
         fetchState: fetchStatus.fetchState,
         error: fetchStatus.error,
-        transactions: filteredTransactionsWithCOT,
+        transactions: transactionsWithCOT,
         selectedCheckBoxTransactionIds,
         transactionIdsWithUnsavedData,
         uncategorizedAccounts: uncategorizedIncomeExpense,
@@ -229,22 +99,18 @@ export function getExpenseAutomationTransactionView(state) {
         classList: allClasses,
         accountsHierarchyList,
         classHierarchyList,
-        hasInFlightCategoryClassRecommendations,
-        inFlightCategoryClassRecommendationsByTransactionId,
         isAccountingProjectsEnabled,
         projectList,
-        transactionLocalData: filteredTransactionLocalData,
+        transactionLocalData,
         uiState,
         refreshStatus,
         saveStatus,
         markAsNotMiscategorizedStatus,
         completionStatus,
         totalCountByTab,
-        parentTabTotalCountByTab,
         fetchStateByTransactionTabs: fetchStateByTab,
         uploadReceiptStatusById,
         selectedTransactionId,
         selectedTransactionLineId,
-        selectedTransactionCategorizationCompletedSubTab,
     };
 }

package/lib/esm/view/expenseAutomationView/types/missingReceiptsViewState.js

@@ -39,6 +39,8 @@ const BULK_UPLOAD_RESULTS_TABS = ['completed', 'unmatched'];
 export const toBulkUploadResultsTab = (v) => stringToUnion(v.trim().toLowerCase(), BULK_UPLOAD_RESULTS_TABS);
 const MISSING_RECEIPTS_TABS = ['missing', 'completed', 'unmatched'];
 export const toMissingReceiptsTab = (v) => stringToUnion(v.trim().toLowerCase(), MISSING_RECEIPTS_TABS);
+const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
+export const toCompletedSubTab = (v) => stringToUnion(v.trim().toLowerCase(), COMPLETED_SUB_TABS);
 const MATCH_SOURCES = ['ai', 'manual'];
 export const toMatchSource = (v) => stringToUnion(v.trim().toLowerCase(), MATCH_SOURCES);
 const BULK_UPLOAD_SORT_KEYS = [

package/lib/esm/view/financeStatement/financeStatementSelector.js

@@ -2,7 +2,6 @@ import { createSelector } from '@reduxjs/toolkit';
 import { stripCompareAdditionalBalanceTypes } from '../../commonStateTypes/coaBalance/coaBalanceType';
 import { newBalancesFilter, newBalancesFilterForDateRange, } from '../../commonStateTypes/coaBalance/coaBalancesFilter';
 import { newBalancesFilterClassesView } from '../../commonStateTypes/coaBalance/coaBalancesFilterClassesView';
-import { newBalancesFilterProjectView } from '../../commonStateTypes/coaBalance/coaBalancesFilterProjectView';
 import { getNumberOfPeriods, } from '../../commonStateTypes/dataAvailable';
 import { reduceAnyCompletedFetchState } from '../../commonStateTypes/reduceFetchState';
 import { toTimeframeTick, } from '../../commonStateTypes/timeframeTick';
@@ -10,6 +9,7 @@ import { extractThisPeriod } from '../../commonStateTypes/viewAndReport/thisPeri
 import { getBalanceSheet } from '../balanceSheet/balanceSheetSelector';
 import { getCashFlow } from '../cashFlow/cashFlowSelector';
 import { getProfitAndLossReport, } from '../profitAndLoss/profitAndLossSelector';
+import { newBalancesFilterProjectView } from '../../commonStateTypes/coaBalance/coaBalancesFilterProjectView';
 import { getProfitAndLossClassesHorizontalView } from '../profitAndLossClassesView/profitAndLossClassesByClassHorizontalSelector';
 import { getProfitAndLossClassesView } from '../profitAndLossClassesView/profitAndLossClassesViewSelector';
 import { getProfitAndLossProjectView } from '../profitAndLossProjectView/profitAndLossProjectViewSelector';