@zeniai/client-epic-state 5.0.74 → 5.0.76

package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -4,14 +4,13 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.uploadTransactionCategorizationReceiptSuccess = exports.updateTransactionCategorizationUploadReceiptState = exports.backgroundRefetchReviewTab = exports.syncTransactionCategorizationFromDetailSave = exports.updateSelectedTransactionId = exports.setEntityRecommendationForLineIdsForCategorization = exports.clearExpenseAutomationTransactionsView = exports.clearExpenseAutomationTransactionsViewPerTabView = exports.updateSelectedCheckboxTransactionIds = exports.fetchTransactionCategorizationView = exports.resetOtherTabsFetchState = exports.fetchTransactionCategorizationSuccess = exports.updateParentTotalCountForTab = exports.updateTotalCountForTransactionCategorization = exports.setAllItemsToCategoryClassInLocalDataForCategorization = exports.updateSelectedCustomerForTransaction = exports.updateSelectedVendorForTransaction = exports.updateStatusForTransactionNotMiscategorizedUpdateForCategorization = exports.markTransactionAsNotMiscategorized = exports.updateTransactionCategorizationSaveStatus = exports.updateTransactionCategorizationCompletedSubTab = exports.updateCurrentSelectedTransactionCategorizationTab = exports.updateTransactionCategorization = exports.saveTransactionCategorization = exports.fetchTransactionCategorizationFailure = exports.saveTransactionCategorizationLocalData = exports.initializeTransactionCategorizationViewLocalData = exports.updateTransactionFilters = exports.updateTransactionCategorizationUIState = exports.fetchTransactionCategorization = exports.initialState = exports.initialTransactionTabViewState = void 0;
+exports.uploadTransactionCategorizationReceiptSuccess = exports.updateTransactionCategorizationUploadReceiptState = exports.backgroundRefetchReviewTab = exports.syncTransactionCategorizationFromDetailSave = exports.updateSelectedTransactionId = exports.setEntityRecommendationForLineIdsForCategorization = exports.clearExpenseAutomationTransactionsView = exports.clearExpenseAutomationTransactionsViewPerTabView = exports.updateSelectedCheckboxTransactionIds = exports.fetchTransactionCategorizationView = exports.resetOtherTabsFetchState = exports.fetchTransactionCategorizationSuccess = exports.updateTotalCountForTransactionCategorization = exports.setAllItemsToCategoryClassInLocalDataForCategorization = exports.updateSelectedCustomerForTransaction = exports.updateSelectedVendorForTransaction = exports.updateStatusForTransactionNotMiscategorizedUpdateForCategorization = exports.markTransactionAsNotMiscategorized = exports.updateTransactionCategorizationSaveStatus = exports.updateCurrentSelectedTransactionCategorizationTab = exports.updateTransactionCategorization = exports.saveTransactionCategorization = exports.fetchTransactionCategorizationFailure = exports.saveTransactionCategorizationLocalData = exports.initializeTransactionCategorizationViewLocalData = exports.updateTransactionCategorizationUIState = exports.fetchTransactionCategorization = exports.initialState = exports.initialTransactionTabViewState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const get_1 = __importDefault(require("lodash/get"));
 const uniq_1 = __importDefault(require("lodash/uniq"));
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const vendorTransaction_1 = require("../../../entity/transaction/stateTypes/vendorTransaction");
 const transactionCategorizationLocalDataHelper_1 = require("../helpers/transactionCategorizationLocalDataHelper");
-const completedSubTab_1 = require("../types/completedSubTab");
 exports.initialTransactionTabViewState = {
     saveStatus: {
         fetchState: 'Not-Started',
@@ -35,10 +34,6 @@ exports.initialTransactionTabViewState = {
         totalCount: {},
         limit: 10,
     },
-    filters: {
-        categoryCombinationOperator: 'AND',
-        categories: [],
-    },
     fetchState: 'Not-Started',
     error: undefined,
     hasValidState() {
@@ -53,74 +48,12 @@ exports.initialTransactionTabViewState = {
     selectedTransactionLineId: undefined,
 };
 exports.initialState = {
-    autoCategorizedSubTabCache: {},
-    parentTotalCountByTab: {
-        review: {},
-        autoCategorized: {},
-    },
     selectedTransactionCategorizationTab: 'review',
-    selectedTransactionCategorizationCompletedSubTab: completedSubTab_1.DEFAULT_COMPLETED_SUB_TAB,
     transactionCategorizationView: {
         review: { ...exports.initialTransactionTabViewState },
         autoCategorized: { ...exports.initialTransactionTabViewState },
     },
 };
-/**
- * Capture the autoCategorized tab's current paginated dataset for a sub-tab.
- * The mid-flight `'In-Progress'` state is normalised to `'Completed'` because
- * the in-flight request is cancelled by `switchMap` in the fetch epic when the
- * sub-tab changes — restoring `'In-Progress'` later would leave the UI stuck
- * showing a phantom loading state with no fetch actually running. Length-zero
- * datasets degrade to `'Not-Started'` so the next visit triggers a fresh
- * fetch from page 1 instead of short-circuiting on stale empty caches.
- *
- * Snapshot scope (deliberately narrow):
- * - Captured: `pageToken`, `totalCount`, `transactionIdsBySelectedPeriod`,
- *   `fetchState`, `error`, `scrollPosition`. The first five are the keys the
- *   fetch epic's cache check reads to decide whether to short-circuit a
- *   sub-tab revisit; `scrollPosition` is captured per sub-tab so revisiting
- *   restores the user's last offset and switching to a never-visited sub-tab
- *   starts at the top instead of inheriting the outgoing sub-tab's offset
- *   (which would land the user at a meaningless row index against a
- *   completely different list).
- * - Intentionally NOT captured (left in place on `autoCat` and inherited by
- *   the incoming sub-tab):
- *     - `uiState.searchString`, `uiState.sortKey`, `uiState.sortOrder`,
- *       `uiState.nodeCollapseState`, `uiState.limit` — search and sort are
- *       user-applied preferences that persist across sub-tabs by design (a
- *       search query stays active when the user toggles between Manual / AI
- *       Accountant).
- *     - `selectedCheckBoxTransactionIds` — selection state is intentionally
- *       cleared at the action source (the fetch epic / save flow), not
- *       by the snapshot path. Carrying selection across sub-tabs is safe
- *       because every sub-tab change goes through a fetch round-trip that
- *       reconciles selection against the new row IDs.
- *     - `transactionReviewLocalDataById`, `transactionIdsWithUnsavedData`,
- *       `uploadReceiptStatusById`, `saveStatus`, `refreshStatus`,
- *       `markAsNotMiscategorizedStatus` — these are per-row / per-flight
- *       caches that are write-through global state, not sub-tab-scoped.
- *
- * If the contract changes (e.g. selection should reset on every sub-tab
- * switch), update both this comment and the snapshot return shape together.
- */
-function snapshotAutoCategorizedTab(autoCat) {
-    const transactionIdsBySelectedPeriod = {
-        ...autoCat.transactionIdsBySelectedPeriod,
-    };
-    const hasAnyLoadedRows = Object.values(transactionIdsBySelectedPeriod).some((ids) => ids.length > 0);
-    let normalisedFetchState = autoCat.fetchState;
-    if (normalisedFetchState === 'In-Progress') {
-        normalisedFetchState = hasAnyLoadedRows ? 'Completed' : 'Not-Started';
-    }
-    return {
-        error: autoCat.error,
-        fetchState: normalisedFetchState,
-        pageToken: autoCat.uiState.pageToken,
-        scrollPosition: autoCat.uiState.scrollPosition,
-        totalCount: { ...autoCat.uiState.totalCount },
-        transactionIdsBySelectedPeriod,
-    };
-}
 const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
     name: 'expenseAutomationTransactionsView',
     initialState: exports.initialState,
@@ -310,12 +243,6 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                     uiState.totalCount;
             }
         },
-        updateTransactionFilters(draft, action) {
-            const { selectedTab, filters } = action.payload;
-            // `filters` is non-nullable per the payload type, so no runtime
-            // null-check is needed — dropping it removes a dead defensive branch.
-            draft.transactionCategorizationView[selectedTab].filters = filters;
-        },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
                 return {
@@ -340,55 +267,6 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                 return { payload: { newSelectedTab } };
             },
         },
-        updateTransactionCategorizationCompletedSubTab: {
-            reducer(draft, action) {
-                const { newSubTab } = action.payload;
-                const previousSubTab = draft.selectedTransactionCategorizationCompletedSubTab;
-                if (previousSubTab === newSubTab) {
-                    return;
-                }
-                const autoCat = draft.transactionCategorizationView.autoCategorized;
-                // Snapshot the outgoing sub-tab so a future revisit can short-circuit
-                // the fetch epic (mirrors the parent-tab "don't refetch what's
-                // already cached" behaviour). Period-scoped data is preserved as-is
-                // because the snapshot itself is keyed only by sub-tab; the active
-                // tab's per-period maps remain the source of truth while live.
-                draft.autoCategorizedSubTabCache[previousSubTab] =
-                    snapshotAutoCategorizedTab(autoCat);
-                const cached = draft.autoCategorizedSubTabCache[newSubTab];
-                if (cached != null) {
-                    autoCat.uiState.pageToken = cached.pageToken;
-                    autoCat.uiState.totalCount = { ...cached.totalCount };
-                    autoCat.uiState.scrollPosition = cached.scrollPosition;
-                    autoCat.transactionIdsBySelectedPeriod = {
-                        ...cached.transactionIdsBySelectedPeriod,
-                    };
-                    autoCat.fetchState = cached.fetchState;
-                    autoCat.error = cached.error;
-                }
-                else {
-                    // Sub-tab has never been visited — clear the active slot so the
-                    // view-epic's `fetchState === 'Not-Started' || transactionIds.length
-                    // === 0` cache check falls through and triggers a fresh page-1
-                    // fetch for the new dataset. `scrollPosition` is reset to the top
-                    // so the incoming list isn't anchored to the outgoing sub-tab's
-                    // offset (different rows → previous offset is meaningless).
-                    autoCat.uiState.pageToken = null;
-                    autoCat.uiState.totalCount = {};
-                    autoCat.uiState.scrollPosition = {
-                        scrollTop: 0,
-                        scrollLeft: undefined,
-                    };
-                    autoCat.transactionIdsBySelectedPeriod = {};
-                    autoCat.fetchState = 'Not-Started';
-                    autoCat.error = undefined;
-                }
-                draft.selectedTransactionCategorizationCompletedSubTab = newSubTab;
-            },
-            prepare(newSubTab) {
-                return { payload: { newSubTab } };
-            },
-        },
         updateTransactionCategorization: {
             reducer(draft, action) {
                 const selectedTab = action.payload.selectedTab;
@@ -826,10 +704,6 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
             const { selectedTab, selectedPeriod, totalCount } = action.payload;
             draft.transactionCategorizationView[selectedTab].uiState.totalCount[(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)] = totalCount;
         },
-        updateParentTotalCountForTab(draft, action) {
-            const { selectedTab, selectedPeriod, parentTotalCount } = action.payload;
-            draft.parentTotalCountByTab[selectedTab][(0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod)] = parentTotalCount;
-        },
         updateSelectedCheckboxTransactionIds(draft, action) {
             const selectedTab = action.payload.selectedTab;
             const transactionIds = action.payload.transactionIds;
@@ -840,16 +714,6 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
             draft.transactionCategorizationView[selectedTab] = {
                 ...exports.initialTransactionTabViewState,
             };
-            draft.parentTotalCountByTab[selectedTab] = {};
-            // The per-sub-tab snapshot cache lives at the slice root and is
-            // exclusively populated by the autoCategorized tab's sub-tab switching
-            // (see updateTransactionCategorizationCompletedSubTab). When that tab
-            // is reset, leaving stale snapshots behind would short-circuit the
-            // next sub-tab visit with phantom row IDs / page tokens that no longer
-            // correspond to anything in state — drop them in lockstep.
-            if (selectedTab === 'autoCategorized') {
-                draft.autoCategorizedSubTabCache = {};
-            }
         },
         clearExpenseAutomationTransactionsView(draft) {
             Object.assign(draft, exports.initialState);
@@ -946,5 +810,5 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
         },
     },
 });
-_a = expenseAutomationTransactionsView.actions, exports.fetchTransactionCategorization = _a.fetchTransactionCategorization, exports.updateTransactionCategorizationUIState = _a.updateTransactionCategorizationUIState, exports.updateTransactionFilters = _a.updateTransactionFilters, exports.initializeTransactionCategorizationViewLocalData = _a.initializeTransactionCategorizationViewLocalData, exports.saveTransactionCategorizationLocalData = _a.saveTransactionCategorizationLocalData, exports.fetchTransactionCategorizationFailure = _a.fetchTransactionCategorizationFailure, exports.saveTransactionCategorization = _a.saveTransactionCategorization, exports.updateTransactionCategorization = _a.updateTransactionCategorization, exports.updateCurrentSelectedTransactionCategorizationTab = _a.updateCurrentSelectedTransactionCategorizationTab, exports.updateTransactionCategorizationCompletedSubTab = _a.updateTransactionCategorizationCompletedSubTab, exports.updateTransactionCategorizationSaveStatus = _a.updateTransactionCategorizationSaveStatus, exports.markTransactionAsNotMiscategorized = _a.markTransactionAsNotMiscategorized, exports.updateStatusForTransactionNotMiscategorizedUpdateForCategorization = _a.updateStatusForTransactionNotMiscategorizedUpdateForCategorization, exports.updateSelectedVendorForTransaction = _a.updateSelectedVendorForTransaction, exports.updateSelectedCustomerForTransaction = _a.updateSelectedCustomerForTransaction, exports.setAllItemsToCategoryClassInLocalDataForCategorization = _a.setAllItemsToCategoryClassInLocalDataForCategorization, exports.updateTotalCountForTransactionCategorization = _a.updateTotalCountForTransactionCategorization, exports.updateParentTotalCountForTab = _a.updateParentTotalCountForTab, exports.fetchTransactionCategorizationSuccess = _a.fetchTransactionCategorizationSuccess, exports.resetOtherTabsFetchState = _a.resetOtherTabsFetchState, exports.fetchTransactionCategorizationView = _a.fetchTransactionCategorizationView, exports.updateSelectedCheckboxTransactionIds = _a.updateSelectedCheckboxTransactionIds, exports.clearExpenseAutomationTransactionsViewPerTabView = _a.clearExpenseAutomationTransactionsViewPerTabView, exports.clearExpenseAutomationTransactionsView = _a.clearExpenseAutomationTransactionsView, exports.setEntityRecommendationForLineIdsForCategorization = _a.setEntityRecommendationForLineIdsForCategorization, exports.updateSelectedTransactionId = _a.updateSelectedTransactionId, exports.syncTransactionCategorizationFromDetailSave = _a.syncTransactionCategorizationFromDetailSave, exports.backgroundRefetchReviewTab = _a.backgroundRefetchReviewTab, exports.updateTransactionCategorizationUploadReceiptState = _a.updateTransactionCategorizationUploadReceiptState, exports.uploadTransactionCategorizationReceiptSuccess = _a.uploadTransactionCategorizationReceiptSuccess;
+_a = expenseAutomationTransactionsView.actions, exports.fetchTransactionCategorization = _a.fetchTransactionCategorization, exports.updateTransactionCategorizationUIState = _a.updateTransactionCategorizationUIState, exports.initializeTransactionCategorizationViewLocalData = _a.initializeTransactionCategorizationViewLocalData, exports.saveTransactionCategorizationLocalData = _a.saveTransactionCategorizationLocalData, exports.fetchTransactionCategorizationFailure = _a.fetchTransactionCategorizationFailure, exports.saveTransactionCategorization = _a.saveTransactionCategorization, exports.updateTransactionCategorization = _a.updateTransactionCategorization, exports.updateCurrentSelectedTransactionCategorizationTab = _a.updateCurrentSelectedTransactionCategorizationTab, exports.updateTransactionCategorizationSaveStatus = _a.updateTransactionCategorizationSaveStatus, exports.markTransactionAsNotMiscategorized = _a.markTransactionAsNotMiscategorized, exports.updateStatusForTransactionNotMiscategorizedUpdateForCategorization = _a.updateStatusForTransactionNotMiscategorizedUpdateForCategorization, exports.updateSelectedVendorForTransaction = _a.updateSelectedVendorForTransaction, exports.updateSelectedCustomerForTransaction = _a.updateSelectedCustomerForTransaction, exports.setAllItemsToCategoryClassInLocalDataForCategorization = _a.setAllItemsToCategoryClassInLocalDataForCategorization, exports.updateTotalCountForTransactionCategorization = _a.updateTotalCountForTransactionCategorization, exports.fetchTransactionCategorizationSuccess = _a.fetchTransactionCategorizationSuccess, exports.resetOtherTabsFetchState = _a.resetOtherTabsFetchState, exports.fetchTransactionCategorizationView = _a.fetchTransactionCategorizationView, exports.updateSelectedCheckboxTransactionIds = _a.updateSelectedCheckboxTransactionIds, exports.clearExpenseAutomationTransactionsViewPerTabView = _a.clearExpenseAutomationTransactionsViewPerTabView, exports.clearExpenseAutomationTransactionsView = _a.clearExpenseAutomationTransactionsView, exports.setEntityRecommendationForLineIdsForCategorization = _a.setEntityRecommendationForLineIdsForCategorization, exports.updateSelectedTransactionId = _a.updateSelectedTransactionId, exports.syncTransactionCategorizationFromDetailSave = _a.syncTransactionCategorizationFromDetailSave, exports.backgroundRefetchReviewTab = _a.backgroundRefetchReviewTab, exports.updateTransactionCategorizationUploadReceiptState = _a.updateTransactionCategorizationUploadReceiptState, exports.uploadTransactionCategorizationReceiptSuccess = _a.uploadTransactionCategorizationReceiptSuccess;
 exports.default = expenseAutomationTransactionsView.reducer;

package/lib/view/expenseAutomationView/selectorTypes/missingReceiptsSelectorTypes.d.ts

@@ -2,8 +2,7 @@ import { CompletionStatusType, FetchStateAndError, ID } from '../../../commonSta
 import { SortOrder } from '../../../commonStateTypes/selectorTypes/sortOrderTypes';
 import { SelectorView } from '../../../commonStateTypes/viewAndReport/viewAndReport';
 import { SupportedTransaction } from '../../../entity/transaction/transactionState';
-import type { CompletedSubTab } from '../types/completedSubTab';
-import type { BatchFileStatus, BatchListItem, BatchStatus, BulkUploadPhase, BulkUploadResultsTab, BulkUploadSortKey, ManualSearchState, MatchSource, MissingReceiptsViewUIState } from '../types/missingReceiptsViewState';
+import type { BatchFileStatus, BatchListItem, BatchStatus, BulkUploadPhase, BulkUploadResultsTab, BulkUploadSortKey, CompletedSubTab, ManualSearchState, MatchSource, MissingReceiptsViewUIState } from '../types/missingReceiptsViewState';
 export interface CompletedTransactionsSelectorData {
     fetchState: FetchStateAndError;
     nextPageToken: string | null;

package/lib/view/expenseAutomationView/selectorTypes/transactionsViewSelectorTypes.d.ts

@@ -7,7 +7,6 @@ import { ClassBase } from '../../../entity/class/classState';
 import { SupportedTransactionWithCOT } from '../../../entity/transaction/transactionState';
 import { UncategorizedAccounts } from '../../accountList/accountListSelector';
 import { ProjectListSelectorView } from '../../projectList/projectListSelector';
-import { CompletedSubTab } from '../types/completedSubTab';
 import { TransactionReviewLocalData, TransactionsTab, TransactionsViewUIState } from '../types/transactionsViewState';
 export interface TransactionReviewLocalDataSelectorView {
     transactionId: ID;
@@ -22,23 +21,10 @@ export interface ExpenseAutomationTransactionViewSelector extends SelectorView {
     fetchStateByTransactionTabs: Record<TransactionsTab, FetchStateAndError>;
     isAccountingProjectsEnabled: boolean;
     markAsNotMiscategorizedStatus: FetchStateAndError;
-    /**
-     * Parent tab badge counts, sourced from the listing response's
-     * `parent_tab_total_count`. Used exclusively to drive the navbar / tab
-     * strip badge labels — every other count consumer (pagination, in-list
-     * "showing X of Y", save flows) keeps reading {@link totalCountByTab}.
-     */
-    parentTabTotalCountByTab: Record<TransactionsTab, number>;
     projectList: ProjectListSelectorView;
     refreshStatus: FetchStateAndError;
     saveStatus: FetchStateAndError;
     selectedCheckBoxTransactionIds: ID[];
-    selectedTransactionCategorizationCompletedSubTab: CompletedSubTab;
-    /**
-     * Per-(sub-)tab counts mirroring `total_count` from the listing response.
-     * Powers pagination via `InfiniteLoader.itemCount`, in-list count copy,
-     * and the `resetTransactionCategorizationLocalData` round-trip.
-     */
     totalCountByTab: Record<TransactionsTab, number>;
     transactionIdsWithUnsavedData: ID[];
     transactionLocalData: TransactionReviewLocalDataSelectorView[];

package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.d.ts

@@ -1,6 +1,3 @@
-import { TransactionWithCOT } from '../../../entity/transaction/stateTypes/transaction';
 import { RootState } from '../../../reducer';
-import { TransactionView } from '../transactionFilterHelpers';
-import { ExpenseAutomationTransactionViewSelector, TransactionReviewLocalDataSelectorView } from '../selectorTypes/transactionsViewSelectorTypes';
-export declare const toTransactionView: (transaction: TransactionWithCOT, transactionLocalData?: TransactionReviewLocalDataSelectorView) => TransactionView;
+import { ExpenseAutomationTransactionViewSelector } from '../selectorTypes/transactionsViewSelectorTypes';
 export declare function getExpenseAutomationTransactionView(state: RootState): ExpenseAutomationTransactionViewSelector;

package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -3,7 +3,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.toTransactionView = void 0;
 exports.getExpenseAutomationTransactionView = getExpenseAutomationTransactionView;
 const omit_1 = __importDefault(require("lodash/omit"));
 const reduceFetchState_1 = require("../../../commonStateTypes/reduceFetchState");
@@ -11,34 +10,14 @@ const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const transactionHelper_1 = require("../../../entity/transaction/transactionHelper");
 const transactionSelector_1 = require("../../../entity/transaction/transactionSelector");
-const transactionFilterHelpers_1 = require("../transactionFilterHelpers");
 const accountListSelector_1 = require("../../accountList/accountListSelector");
 const classListSelector_1 = require("../../classList/classListSelector");
 const projectListSelector_1 = require("../../projectList/projectListSelector");
 const expenseAutomationViewSelectorTypes_1 = require("../selectorTypes/expenseAutomationViewSelectorTypes");
-const toTransactionView = (transaction, transactionLocalData) => {
-    return {
-        id: transaction.id,
-        date: transaction.date,
-        amount: transaction.amount,
-        vendorName: transaction.vendorName,
-        customerName: transaction.customerName,
-        vendorId: transaction.vendorId,
-        customerId: transaction.customerId,
-        description: transaction.description,
-        memo: transaction.memo,
-        type: transaction.type,
-        typeName: transaction.typeName,
-        createTime: transaction.createTime,
-        transaction: transaction,
-        transactionLocalData,
-    };
-};
-exports.toTransactionView = toTransactionView;
 function getExpenseAutomationTransactionView(state) {
     const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
-    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, filters, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
+    const { selectedTransactionCategorizationTab } = expenseAutomationTransactionsViewState;
+    const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(accountState, accountListState, 'accountList');
     const accountList = (0, accountListSelector_1.getAccountList)(accountState, accountListState, 'accountList');
     const classList = (0, classListSelector_1.getClassList)(classState, classListState);
@@ -57,58 +36,20 @@ function getExpenseAutomationTransactionView(state) {
         ? transactionIdsBySelectedPeriod[monthYearPeriodId]
         : null;
     const transactionIds = transactionIdsForSelectedPeriod ?? [];
-    const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
-    const transactionsWithCOT = transactions.map((transaction) => (0, transactionHelper_1.getTransactionWithCOT)(transaction));
-    const transactionLocalDataMap = new Map();
-    transactionIds.forEach((transactionId) => {
+    const transactionLocalData = transactionIds
+        .map((transactionId) => {
         const transactionData = transactionReviewLocalDataById[transactionId];
         if (transactionData != null) {
-            transactionLocalDataMap.set(transactionId, {
+            return {
                 transactionId,
                 transactionReviewLocalData: transactionData.transactionReviewLocalData,
-            });
-        }
-    });
-    // Step 2: Convert to TransactionView and apply advanced filters
-    const transactionViews = transactionsWithCOT.map((transaction) => {
-        const localData = transactionLocalDataMap.get(transaction.id);
-        return (0, exports.toTransactionView)(transaction, localData);
-    });
-    // Apply TC-specific filters (lives under expenseAutomationView, independent
-    // of the Spend Management filter pipeline).
-    const filteredTransactionViews = (0, transactionFilterHelpers_1.applyTransactionFilters)(transactionViews, filters);
-    // Convert back to TransactionWithCOT for return
-    const filteredTransactionsWithCOT = filteredTransactionViews.map((view) => view.transaction);
-    // Get transactionLocalData for filtered transactions
-    // Also include transactionLocalData for transactions that don't exist in transactionState
-    // but have local data (to match original behavior)
-    const filteredTransactionIds = new Set(filteredTransactionViews.map((view) => view.id));
-    // Pre-compute the membership set once. The previous implementation called
-    // `transactions.some(t => t.id === transactionId)` inside the per-id loop,
-    // turning the pipeline into O(n × m) — measurable on tenants with large
-    // transaction lists since this selector runs on every Redux dispatch.
-    const transactionExistsById = new Set(transactions.map((t) => t.id));
-    // `.flatMap` returns `X[]` directly when the callback returns `[]` for the
-    // skip case, so we don't need the trailing `.filter((d): d is X => …)` type
-    // predicate that the previous `map → filter` pipeline required.
-    const filteredTransactionLocalData = transactionIds.flatMap((transactionId) => {
-        const transactionData = transactionReviewLocalDataById[transactionId];
-        if (transactionData == null) {
-            return [];
+            };
         }
-        // Include if transaction is in filtered results, or if transaction doesn't exist in state
-        // (to maintain backward compatibility with tests)
-        const transactionExists = transactionExistsById.has(transactionId);
-        if (filteredTransactionIds.has(transactionId) || !transactionExists) {
-            return [
-                {
-                    transactionId,
-                    transactionReviewLocalData: transactionData.transactionReviewLocalData,
-                },
-            ];
-        }
-        return [];
-    });
+        return null;
+    })
+        .filter((transaction) => transaction != null);
+    const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
+    const transactionsWithCOT = transactions.map((transaction) => (0, transactionHelper_1.getTransactionWithCOT)(transaction));
     const monthEndFetchState = monthYearPeriodId != null
         ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
         : { fetchState: 'Not-Started', error: undefined };
@@ -128,27 +69,10 @@ function getExpenseAutomationTransactionView(state) {
         .uiState.totalCount;
     const totalCountByAutoCat = expenseAutomationTransactionsViewState.transactionCategorizationView
         .autoCategorized.uiState.totalCount;
-    // Per-(sub-)tab counts powering pagination, in-list "showing X of Y", and
-    // any save/refresh round-trips. Sourced from `uiState.totalCount` which
-    // mirrors the response's `total_count` for whatever tab/sub-tab the user is
-    // viewing (e.g. only the Manual sub-tab rows for Completed → Manual).
     const totalCountByTab = {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
-    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
-    // listing response and used exclusively by the navbar / tab strip badges.
-    // Independent of which Completed sub-tab is active so the badge stays
-    // stable across sub-tab switches.
-    const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
-    const parentTabTotalCountByTab = {
-        review: monthYearPeriodId != null
-            ? (parentTotalCountByTab.review[monthYearPeriodId] ?? 0)
-            : 0,
-        autoCategorized: monthYearPeriodId != null
-            ? (parentTotalCountByTab.autoCategorized[monthYearPeriodId] ?? 0)
-            : 0,
-    };
     const fetchStateByTab = {
         review: {
             fetchState: expenseAutomationTransactionsViewState.transactionCategorizationView
@@ -172,7 +96,7 @@ function getExpenseAutomationTransactionView(state) {
         version: 0,
         fetchState: fetchStatus.fetchState,
         error: fetchStatus.error,
-        transactions: filteredTransactionsWithCOT,
+        transactions: transactionsWithCOT,
         selectedCheckBoxTransactionIds,
         transactionIdsWithUnsavedData,
         uncategorizedAccounts: uncategorizedIncomeExpense,
@@ -183,18 +107,16 @@ function getExpenseAutomationTransactionView(state) {
         classHierarchyList,
         isAccountingProjectsEnabled,
         projectList,
-        transactionLocalData: filteredTransactionLocalData,
+        transactionLocalData,
         uiState,
         refreshStatus,
         saveStatus,
         markAsNotMiscategorizedStatus,
         completionStatus,
         totalCountByTab,
-        parentTabTotalCountByTab,
         fetchStateByTransactionTabs: fetchStateByTab,
         uploadReceiptStatusById,
         selectedTransactionId,
         selectedTransactionLineId,
-        selectedTransactionCategorizationCompletedSubTab,
     };
 }

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.d.ts

@@ -1,7 +1,6 @@
 import { FetchStateAndError, FetchedState, ID } from '../../../commonStateTypes/common';
 import { SortOrder } from '../../../commonStateTypes/selectorTypes/sortOrderTypes';
 import { MonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
-import { CompletedSubTab } from './completedSubTab';
 export declare const toMissingReceiptsSortKey: (v: string) => "date" | "amount" | "vendor" | "category" | "class";
 export type MissingReceiptsSortKey = ReturnType<typeof toMissingReceiptsSortKey>;
 export interface MissingReceiptsViewUIState {
@@ -32,6 +31,8 @@ export declare const toBulkUploadResultsTab: (v: string) => "completed" | "unmat
 export type BulkUploadResultsTab = ReturnType<typeof toBulkUploadResultsTab>;
 export declare const toMissingReceiptsTab: (v: string) => "completed" | "unmatched" | "missing";
 export type MissingReceiptsTab = ReturnType<typeof toMissingReceiptsTab>;
+export declare const toCompletedSubTab: (v: string) => "all" | "manual" | "ai_accountant";
+export type CompletedSubTab = ReturnType<typeof toCompletedSubTab>;
 export declare const toMatchSource: (v: string) => "manual" | "ai";
 export type MatchSource = ReturnType<typeof toMatchSource>;
 export declare const toBulkUploadSortKey: (v: string) => "date" | "amount" | "vendor" | "category" | "class";

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.toBulkUploadSortKey = exports.toMatchSource = exports.toMissingReceiptsTab = exports.toBulkUploadResultsTab = exports.toBulkUploadPhase = exports.toBatchFileStatus = exports.BATCH_FILE_STATUSES = exports.toBatchStatusValue = exports.MIN_MANUAL_TRANSACTION_SEARCH_LENGTH = exports.toMissingReceiptsSortKey = void 0;
+exports.toBulkUploadSortKey = exports.toMatchSource = exports.toCompletedSubTab = exports.toMissingReceiptsTab = exports.toBulkUploadResultsTab = exports.toBulkUploadPhase = exports.toBatchFileStatus = exports.BATCH_FILE_STATUSES = exports.toBatchStatusValue = exports.MIN_MANUAL_TRANSACTION_SEARCH_LENGTH = exports.toMissingReceiptsSortKey = void 0;
 exports.isUnmatchedTabFileStatus = isUnmatchedTabFileStatus;
 const stringToUnion_1 = require("../../../commonStateTypes/stringToUnion");
 const MISSING_RECEIPTS_SORT_KEYS = [
@@ -49,6 +49,9 @@ exports.toBulkUploadResultsTab = toBulkUploadResultsTab;
 const MISSING_RECEIPTS_TABS = ['missing', 'completed', 'unmatched'];
 const toMissingReceiptsTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), MISSING_RECEIPTS_TABS);
 exports.toMissingReceiptsTab = toMissingReceiptsTab;
+const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
+const toCompletedSubTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), COMPLETED_SUB_TABS);
+exports.toCompletedSubTab = toCompletedSubTab;
 const MATCH_SOURCES = ['ai', 'manual'];
 const toMatchSource = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), MATCH_SOURCES);
 exports.toMatchSource = toMatchSource;

package/lib/view/expenseAutomationView/types/transactionsViewState.d.ts

@@ -1,5 +1,5 @@
 import { Amount } from '../../../commonStateTypes/amount';
-import { FetchState, FetchStateAndError, FetchedState, ID } from '../../../commonStateTypes/common';
+import { FetchStateAndError, FetchedState, ID } from '../../../commonStateTypes/common';
 import { Recommendation, RecommendationWithCOT } from '../../../commonStateTypes/recommendationBase';
 import { SortOrder } from '../../../commonStateTypes/selectorTypes/sortOrderTypes';
 import { MonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
@@ -7,18 +7,15 @@ import { PageToken } from '../../../commonStateTypes/viewAndReport/viewAndReport
 import { AccountBase } from '../../../entity/account/accountState';
 import { ClassBase } from '../../../entity/class/classState';
 import { CustomerBase } from '../../../entity/customer/customerState';
-import { Entity, EntityType } from '../../../entity/genericEntity/entity';
 import { ProjectBase } from '../../../entity/project/projectState';
+import { Entity, EntityType } from '../../../entity/genericEntity/entity';
 import { TransactionID } from '../../../entity/transaction/stateTypes/transaction';
 import { BillableStatus, CategorizationStatusType, PlatformLineDetailType, ProductOrService, TransactionLineBase } from '../../../entity/transaction/stateTypes/transactionLine';
 import { TransactionCategory, TransactionType } from '../../../entity/transaction/stateTypes/transactionType';
 import { VendorBase } from '../../../entity/vendor/vendorState';
-import { ZeniAPIStatus } from '../../../responsePayload';
 import { ZeniDate } from '../../../zeniDayJS';
 import { EntityRecommendationKey } from '../../recommendation/recommendationState';
-import { TransactionFilters } from '../transactionFilterHelpers';
 import { TransactionDetailKey } from '../../transactionDetail/transactionDetailState';
-import { CompletedSubTab } from './completedSubTab';
 export declare const toTransactionsSortKey: (v: string) => "date" | "amount" | "vendor" | "project" | "category" | "class" | "payment_account" | "transaction_type" | "memo_and_receipt";
 export type TransactionsSortKey = ReturnType<typeof toTransactionsSortKey>;
 export declare const TRANSACTIONS_TABS: readonly ["review", "autoCategorized"];
@@ -94,7 +91,6 @@ export interface SupportedTransactionCategorization {
 }
 export declare const initialSupportedTransactionCategorization: SupportedTransactionCategorization;
 export interface TransactionsTabViewState extends FetchedState {
-    filters: TransactionFilters;
     markAsNotMiscategorizedStatus: FetchStateAndError;
     refreshStatus: FetchStateAndError;
     saveStatus: FetchStateAndError;
@@ -107,44 +103,7 @@ export interface TransactionsTabViewState extends FetchedState {
     selectedTransactionId?: ID;
     selectedTransactionLineId?: ID;
 }
-/**
- * Snapshot of the autoCategorized tab's paginated dataset for a single
- * Completed sub-tab. Stored in {@link TransactionsViewState.autoCategorizedSubTabCache}
- * so revisiting an already-loaded sub-tab can short-circuit the fetch epic
- * (mirrors parent-tab caching). The snapshot is period-spanning — both the
- * `totalCount` map and `transactionIdsBySelectedPeriod` map preserve every
- * period the user has paged through under that sub-tab.
- *
- * `scrollPosition` is captured per sub-tab so revisiting a sub-tab restores
- * the user's last scroll offset; switching to a fresh / never-visited sub-tab
- * starts at the top instead of inheriting the previous sub-tab's offset.
- */
-export interface AutoCategorizedSubTabSnapshot {
-    error: ZeniAPIStatus | undefined;
-    fetchState: FetchState;
-    pageToken: PageToken;
-    scrollPosition: TransactionsViewUIState['scrollPosition'];
-    totalCount: Record<MonthYearPeriodId, number>;
-    transactionIdsBySelectedPeriod: Record<MonthYearPeriodId, ID[]>;
-}
 export type TransactionsViewState = {
-    /**
-     * Per-sub-tab snapshot cache for the Completed (autoCategorized) tab. Keyed
-     * by {@link CompletedSubTab}. Populated as the user navigates between
-     * sub-tabs and consulted on every switch — the active autoCategorized slot
-     * is restored from here when a snapshot exists, otherwise it is reset and
-     * the fetch epic loads page 1 fresh.
-     */
-    autoCategorizedSubTabCache: Partial<Record<CompletedSubTab, AutoCategorizedSubTabSnapshot>>;
-    /**
-     * Period-keyed parent tab counts, scoped per {@link TransactionsTab}.
-     * Sourced from the listing response's `parent_tab_total_count` and used
-     * exclusively to drive the parent tab badges on the UI — every other
-     * count consumer (pagination, sub-tab chips, in-tab "showing X of Y")
-     * keeps reading from {@link TransactionsViewUIState.totalCount}.
-     */
-    parentTotalCountByTab: Record<TransactionsTab, Record<MonthYearPeriodId, number>>;
-    selectedTransactionCategorizationCompletedSubTab: CompletedSubTab;
     selectedTransactionCategorizationTab: TransactionsTab;
     transactionCategorizationView: Record<TransactionsTab, TransactionsTabViewState>;
 };

package/lib/view/financeStatement/financeStatementSelector.js

@@ -5,7 +5,6 @@ const toolkit_1 = require("@reduxjs/toolkit");
 const coaBalanceType_1 = require("../../commonStateTypes/coaBalance/coaBalanceType");
 const coaBalancesFilter_1 = require("../../commonStateTypes/coaBalance/coaBalancesFilter");
 const coaBalancesFilterClassesView_1 = require("../../commonStateTypes/coaBalance/coaBalancesFilterClassesView");
-const coaBalancesFilterProjectView_1 = require("../../commonStateTypes/coaBalance/coaBalancesFilterProjectView");
 const dataAvailable_1 = require("../../commonStateTypes/dataAvailable");
 const reduceFetchState_1 = require("../../commonStateTypes/reduceFetchState");
 const timeframeTick_1 = require("../../commonStateTypes/timeframeTick");
@@ -13,6 +12,7 @@ const thisPeriodHelpers_1 = require("../../commonStateTypes/viewAndReport/thisPe
 const balanceSheetSelector_1 = require("../balanceSheet/balanceSheetSelector");
 const cashFlowSelector_1 = require("../cashFlow/cashFlowSelector");
 const profitAndLossSelector_1 = require("../profitAndLoss/profitAndLossSelector");
+const coaBalancesFilterProjectView_1 = require("../../commonStateTypes/coaBalance/coaBalancesFilterProjectView");
 const profitAndLossClassesByClassHorizontalSelector_1 = require("../profitAndLossClassesView/profitAndLossClassesByClassHorizontalSelector");
 const profitAndLossClassesViewSelector_1 = require("../profitAndLossClassesView/profitAndLossClassesViewSelector");
 const profitAndLossProjectViewSelector_1 = require("../profitAndLossProjectView/profitAndLossProjectViewSelector");

package/lib/view/profitAndLossProjectView/profitAndLossProjectViewSelectorTypes.d.ts

@@ -1,10 +1,10 @@
+import { SectionProjectViewReport } from '../../entity/sectionProjectView/sectionProjectViewSelectorTypes';
 import { COABalancesFilterProjectView } from '../../commonStateTypes/coaBalance/coaBalancesFilterProjectView';
 import { ID } from '../../commonStateTypes/common';
 import { DataAvailable } from '../../commonStateTypes/dataAvailable';
 import { CalculatedSection } from '../../commonStateTypes/selectorTypes/selectorTypes';
 import { SelectorReport } from '../../commonStateTypes/viewAndReport/viewAndReport';
 import { Project } from '../../entity/project/projectState';
-import { SectionProjectViewReport } from '../../entity/sectionProjectView/sectionProjectViewSelectorTypes';
 import { PandLReportViewCalculatedSectionID, PandLReportViewSectionID } from '../profitAndLossClassesView/profitAndLossClassesViewSelectorTypes';
 import { ProfitAndLossProjectViewUIState } from './profitAndLossProjectViewState';
 export interface ProfitAndLossProjectViewReport extends SelectorReport {

package/lib/view/spendManagement/billPay/billList/billListState.d.ts

@@ -45,7 +45,7 @@ export interface BillPayFilters {
 }
 export interface BillPayFilterCategory {
     field: BillListViewFilterCategoryField;
-    matchingOperator: 'equal' | 'not_equal';
+    matchingOperator: 'equal' | 'not-equal';
     values: (string | ZeniDate)[];
     valuesCombinationOperator: 'ANY';
 }

package/lib/view/spendManagement/chargeCards/cashbackDetail/cashbackDetailReducer.d.ts

@@ -2,9 +2,7 @@ import { ZeniAPIStatus } from '../../../../responsePayload';
 import { ChargeCardCashbackPayload } from './cashbackDetailPayload';
 import { CashbackDetailState, CashbackDetailUIState } from './cashbackDetailState';
 export declare const initialState: CashbackDetailState;
-export declare const fetchCashbackDetail: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[cacheOverride?: boolean | undefined], {
-    cacheOverride: boolean;
-}, "cashbackDetail/fetchCashbackDetail", never, never>, updateCashbackDetail: import("@reduxjs/toolkit").ActionCreatorWithPayload<ChargeCardCashbackPayload, "cashbackDetail/updateCashbackDetail">, updateCashbackDetailFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "cashbackDetail/updateCashbackDetailFailure">, updateCashbackDetailUIState: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+export declare const fetchCashbackDetail: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"cashbackDetail/fetchCashbackDetail">, updateCashbackDetail: import("@reduxjs/toolkit").ActionCreatorWithPayload<ChargeCardCashbackPayload, "cashbackDetail/updateCashbackDetail">, updateCashbackDetailFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "cashbackDetail/updateCashbackDetailFailure">, updateCashbackDetailUIState: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     uiState: Partial<CashbackDetailUIState>;
 }, "cashbackDetail/updateCashbackDetailUIState">, clearCashbackDetail: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"cashbackDetail/clearCashbackDetail">;
 declare const _default: import("redux").Reducer<CashbackDetailState>;

package/lib/view/spendManagement/chargeCards/cashbackDetail/cashbackDetailReducer.js

@@ -5,7 +5,6 @@ exports.clearCashbackDetail = exports.updateCashbackDetailUIState = exports.upda
 const toolkit_1 = require("@reduxjs/toolkit");
 const viewAndReportPayloadv2_1 = require("../../../../commonPayloadTypes/v2/viewAndReportPayloadv2");
 const amount_1 = require("../../../../commonStateTypes/amount");
-const cacheOverrideFetchReducer_1 = require("../../../../commonStateTypes/cacheOverrideFetchReducer");
 const cashbackDetailState_1 = require("./cashbackDetailState");
 exports.initialState = {
     fetchState: 'Not-Started',
@@ -32,10 +31,10 @@ const cashbackDetail = (0, toolkit_1.createSlice)({
     name: 'cashbackDetail',
     initialState: exports.initialState,
     reducers: {
-        fetchCashbackDetail: (0, cacheOverrideFetchReducer_1.createCacheOverrideFetchReducer)((draft) => {
+        fetchCashbackDetail(draft) {
             draft.fetchState = 'In-Progress';
             draft.error = undefined;
-        }),
+        },
         updateCashbackDetail(draft, action) {
             draft.cashbackByPeriod = toCashbackByPeriod(action.payload);
             draft.cashbackSummary = toCashbackSummary(action.payload);