@zeniai/client-epic-state 5.0.71-betaAK1 → 5.0.71-betaML41

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (73) hide show
  1. package/lib/commonStateTypes/amount.d.ts +0 -1
  2. package/lib/commonStateTypes/amount.js +1 -3
  3. package/lib/epic.d.ts +2 -4
  4. package/lib/epic.js +2 -4
  5. package/lib/esm/commonStateTypes/amount.js +0 -1
  6. package/lib/esm/epic.js +2 -4
  7. package/lib/esm/index.js +6 -8
  8. package/lib/esm/reducer.js +0 -6
  9. package/lib/esm/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.js +21 -1
  10. package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js +117 -14
  11. package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js +58 -0
  12. package/lib/esm/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.js +87 -0
  13. package/lib/esm/view/recommendation/recommendationHelper.js +29 -0
  14. package/lib/esm/view/recommendation/recommendationReducer.js +26 -1
  15. package/lib/esm/view/transactionDetail/transactionDetailReducer.js +121 -6
  16. package/lib/esm/view/transactionDetail/transactionDetailSelector.js +22 -0
  17. package/lib/index.d.ts +7 -9
  18. package/lib/index.js +35 -37
  19. package/lib/reducer.d.ts +0 -6
  20. package/lib/reducer.js +0 -6
  21. package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.d.ts +1 -0
  22. package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.js +23 -2
  23. package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.d.ts +14 -1
  24. package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.js +117 -14
  25. package/lib/view/expenseAutomationView/selectorTypes/transactionsViewSelectorTypes.d.ts +2 -0
  26. package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.d.ts +3 -0
  27. package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.js +60 -0
  28. package/lib/view/expenseAutomationView/types/transactionsViewState.d.ts +1 -0
  29. package/lib/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.d.ts +9 -0
  30. package/lib/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.js +91 -0
  31. package/lib/view/recommendation/recommendationHelper.d.ts +9 -0
  32. package/lib/view/recommendation/recommendationHelper.js +31 -1
  33. package/lib/view/recommendation/recommendationReducer.d.ts +20 -1
  34. package/lib/view/recommendation/recommendationReducer.js +27 -2
  35. package/lib/view/transactionDetail/transactionDetailReducer.d.ts +11 -1
  36. package/lib/view/transactionDetail/transactionDetailReducer.js +122 -7
  37. package/lib/view/transactionDetail/transactionDetailSelector.d.ts +2 -0
  38. package/lib/view/transactionDetail/transactionDetailSelector.js +24 -1
  39. package/lib/view/transactionDetail/transactionDetailTypes.d.ts +1 -0
  40. package/package.json +1 -1
  41. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventPayload.d.ts +0 -11
  42. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventPayload.js +0 -23
  43. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventReducer.d.ts +0 -6
  44. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventReducer.js +0 -31
  45. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventSelector.d.ts +0 -4
  46. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventSelector.js +0 -16
  47. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventState.d.ts +0 -13
  48. package/lib/entity/upcomingPaymentEvent/upcomingPaymentEventState.js +0 -2
  49. package/lib/esm/entity/upcomingPaymentEvent/upcomingPaymentEventPayload.js +0 -19
  50. package/lib/esm/entity/upcomingPaymentEvent/upcomingPaymentEventReducer.js +0 -27
  51. package/lib/esm/entity/upcomingPaymentEvent/upcomingPaymentEventSelector.js +0 -11
  52. package/lib/esm/entity/upcomingPaymentEvent/upcomingPaymentEventState.js +0 -1
  53. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewPayload.js +0 -1
  54. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewReducer.js +0 -82
  55. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.js +0 -93
  56. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewState.js +0 -14
  57. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementBannerEpic.js +0 -6
  58. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementOverviewPageEpic.js +0 -42
  59. package/lib/esm/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchUpcomingPaymentEventsEpic.js +0 -22
  60. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewPayload.d.ts +0 -10
  61. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewPayload.js +0 -2
  62. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewReducer.d.ts +0 -20
  63. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewReducer.js +0 -86
  64. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.d.ts +0 -20
  65. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewSelector.js +0 -98
  66. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewState.d.ts +0 -21
  67. package/lib/view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewState.js +0 -17
  68. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementBannerEpic.d.ts +0 -5
  69. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementBannerEpic.js +0 -10
  70. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementOverviewPageEpic.d.ts +0 -9
  71. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchCashManagementOverviewPageEpic.js +0 -46
  72. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchUpcomingPaymentEventsEpic.d.ts +0 -8
  73. package/lib/view/spendManagement/cashManagement/cashManagementOverview/epics/fetchUpcomingPaymentEventsEpic.js +0 -26
@@ -61,7 +61,6 @@ import tenant, { initialState as initialTenantState, } from './entity/tenant/ten
61
61
  import toastNotification, { initialState as initialToastNotificationState, } from './entity/toastNotification/toastNotificationReducer';
62
62
  import transaction, { initialState as initialTransactionState, } from './entity/transaction/transactionReducer';
63
63
  import transactionActivityLog, { initialState as initialTransactionActivityLogState, } from './entity/transactionActivityLog/transactionActivityLogReducer';
64
- import upcomingPaymentEvent, { initialState as initialUpcomingPaymentEventState, } from './entity/upcomingPaymentEvent/upcomingPaymentEventReducer';
65
64
  import user, { initialState as initialUserState, } from './entity/user/userReducer';
66
65
  import userGroups, { initialState as initialUserGroupsState, } from './entity/userGroups/userGroupsReducer';
67
66
  import userRole, { initialState as initialUserRoleState, } from './entity/userRole/userRoleReducer';
@@ -158,7 +157,6 @@ import internationalWireVerification, { initialState as initialInternationalWire
158
157
  import magicLinkView, { initialState as initialMagicLinkViewState, } from './view/spendManagement/billPay/magicLinkView/magicLinkViewReducer';
159
158
  import previousBills, { initialState as initialPreviousBillsState, } from './view/spendManagement/billPay/previousBills/previousBillsReducer';
160
159
  import wiseRedirect, { initialState as initialWiseRedirectState, } from './view/spendManagement/billPay/wiseRedirectView/wiseRedirectReducer';
161
- import cashManagementOverview, { initialState as initialCashManagementOverviewState, } from './view/spendManagement/cashManagement/cashManagementOverview/cashManagementOverviewReducer';
162
160
  import cardUserOnboarding, { initialState as initialCardUserOnboardingState, } from './view/spendManagement/chargeCards/cardUserOnboarding/cardUserOnboardingReducer';
163
161
  import cashbackDetail, { initialState as initialCashbackDetailState, } from './view/spendManagement/chargeCards/cashbackDetail/cashbackDetailReducer';
164
162
  import chargeCardConfig, { initialState as initialChargeCardConfigState, } from './view/spendManagement/chargeCards/chargeCardConfig/chargeCardConfigReducer';
@@ -289,7 +287,6 @@ const initialEntitiesState = {
289
287
  toastNotificationState: initialToastNotificationState,
290
288
  transactionActivityLogState: initialTransactionActivityLogState,
291
289
  transactionState: initialTransactionState,
292
- upcomingPaymentEventState: initialUpcomingPaymentEventState,
293
290
  userGroupsState: initialUserGroupsState,
294
291
  userRoleState: initialUserRoleState,
295
292
  userState: initialUserState,
@@ -329,7 +326,6 @@ const initialViewsState = {
329
326
  cashBalanceState: initialCashBalanceState,
330
327
  cashFlowState: initialCashFlowState,
331
328
  cashInCashOutState: initialCashInCashOutState,
332
- cashManagementOverviewState: initialCashManagementOverviewState,
333
329
  cashPositionState: initialCashPositionState,
334
330
  chargeCardConfigState: initialChargeCardConfigState,
335
331
  chargeCardDetailState: initialChargeCardDetailState,
@@ -527,7 +523,6 @@ const entityReducers = {
527
523
  toastNotificationState: toastNotification,
528
524
  transactionActivityLogState: transactionActivityLog,
529
525
  transactionState: transaction,
530
- upcomingPaymentEventState: upcomingPaymentEvent,
531
526
  userGroupsState: userGroups,
532
527
  userRoleState: userRole,
533
528
  userState: user,
@@ -566,7 +561,6 @@ const viewReducers = {
566
561
  cashBalanceState: cashBalance,
567
562
  cashFlowState: cashFlow,
568
563
  cashInCashOutState: cashInCashOut,
569
- cashManagementOverviewState: cashManagementOverview,
570
564
  cashPositionState: cashPosition,
571
565
  chargeCardConfigState: chargeCardConfig,
572
566
  chargeCardDetailState: chargeCardDetail,
@@ -59,6 +59,22 @@ export const filterAutoTabLineItems = (tabView, transactionId, updatedTransactio
59
59
  }
60
60
  };
61
61
  export const MAX_SELECTION_LIMIT = 5;
62
+ // Returns true when the transaction should be auto-added to the
63
+ // selectedCheckBoxTransactionIds list after a categorization-related
64
+ // state mutation: all line items are filled, the selection limit has
65
+ // not been hit, and the id isn't already in the list. Consolidates the
66
+ // triplet that was inlined at four sites (updateSelectedCustomer/Vendor,
67
+ // setAllItemsToCategoryClassInLocalDataForCategorization, and
68
+ // setEntityRecommendationForLineIdInLocalData below).
69
+ export const shouldAutoSelectAndAdd = (transaction, localData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) => {
70
+ if (selectedCheckBoxTransactionIds.includes(transaction.id)) {
71
+ return false;
72
+ }
73
+ if (selectedCheckBoxTransactionIds.length >= MAX_SELECTION_LIMIT) {
74
+ return false;
75
+ }
76
+ return checkIfAllLineItemsAreCategoryClassFilled(transaction, localData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
77
+ };
62
78
  export const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) => {
63
79
  const transactionLocal = {
64
80
  ...initialSupportedTransactionCategorization.transactionReviewLocalData,
@@ -544,10 +560,14 @@ export const setEntityRecommendationForLineIdInLocalData = (draft, transaction,
544
560
  selectedEntity: transactionDetailLocalData.selectedEntity,
545
561
  tabSpecificLineItems: transactionDetailLocalData.tabSpecificLineItems,
546
562
  };
563
+ // Auto-uncheck if not all line items are filled (the row's
564
+ // category/class became stale after the entity update). Otherwise
565
+ // route through shouldAutoSelectAndAdd so the MAX_SELECTION_LIMIT
566
+ // gate is consistently applied across all auto-add sites.
547
567
  if (!checkIfAllLineItemsAreCategoryClassFilled(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
548
568
  selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds.filter((id) => id !== transaction.id);
549
569
  }
550
- else if (selectedCheckBoxTransactionIds.includes(transaction.id) === false) {
570
+ else if (shouldAutoSelectAndAdd(transaction, newLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
551
571
  selectedCheckBoxTransactionIds.push(transaction.id);
552
572
  }
553
573
  draft.selectedCheckBoxTransactionIds = selectedCheckBoxTransactionIds;
@@ -3,7 +3,7 @@ import recordGet from 'lodash/get';
3
3
  import uniq from 'lodash/uniq';
4
4
  import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
5
5
  import { isVendorTransaction } from '../../../entity/transaction/stateTypes/vendorTransaction';
6
- import { MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
6
+ import { filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, shouldAutoSelectAndAdd, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
7
7
  import { DEFAULT_COMPLETED_SUB_TAB, } from '../types/completedSubTab';
8
8
  export const initialTransactionTabViewState = {
9
9
  saveStatus: {
@@ -420,12 +420,9 @@ const expenseAutomationTransactionsView = createSlice({
420
420
  const selectedCheckBoxTransactionIds = draft.transactionCategorizationView[selectedTab]
421
421
  .selectedCheckBoxTransactionIds;
422
422
  if (selectedTransaction != null &&
423
- checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
424
- selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
425
- selectedCheckBoxTransactionIds.includes(transactionId) === false) {
423
+ shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
426
424
  draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
427
- ...draft.transactionCategorizationView[selectedTab]
428
- .selectedCheckBoxTransactionIds,
425
+ ...selectedCheckBoxTransactionIds,
429
426
  transactionId,
430
427
  ];
431
428
  }
@@ -508,9 +505,26 @@ const expenseAutomationTransactionsView = createSlice({
508
505
  const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
509
506
  .transactionReviewLocalDataById, transactionId.id, undefined);
510
507
  if (transactionLocalData != null) {
508
+ const newLocalData = setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
509
+ // Release the per-line fetch flag for every line this fetch
510
+ // covered. Done in-place on the freshly returned local data
511
+ // (the helper produces a new mutable object), before we write
512
+ // it back to the draft.
513
+ lineIds.forEach((lineId) => {
514
+ const lineItem = newLocalData.lineItemById[lineId];
515
+ if (lineItem != null) {
516
+ newLocalData.lineItemById[lineId] = {
517
+ ...lineItem,
518
+ categoryClassRecommendationsFetchState: {
519
+ fetchState: 'Completed',
520
+ error: undefined,
521
+ },
522
+ };
523
+ }
524
+ });
511
525
  draft.transactionCategorizationView[selectedTab].transactionReviewLocalDataById[transaction.id] = {
512
526
  transactionId: transaction.id,
513
- transactionReviewLocalData: setEntityRecommendationForLineIdInLocalData(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled),
527
+ transactionReviewLocalData: newLocalData,
514
528
  };
515
529
  // Mark transaction as dirty (autofill happened)
516
530
  if (!draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData.includes(transaction.id)) {
@@ -523,6 +537,99 @@ const expenseAutomationTransactionsView = createSlice({
523
537
  }
524
538
  },
525
539
  },
540
+ // Start arm of the line-update recommendations fetch. Flips covered
541
+ // lines to In-Progress AND removes the transaction from
542
+ // selectedCheckBoxTransactionIds — the row is unchecked + disabled
543
+ // until either the success arm (recheck if limit allows) or the
544
+ // failure arm releases the per-line flag.
545
+ markCategoryClassRecommendationsInProgressForCategorization: {
546
+ reducer(draft, action) {
547
+ const { selectedTab, transactionId, lineIds } = action.payload;
548
+ const tab = draft.transactionCategorizationView[selectedTab];
549
+ const transactionLocalData = recordGet(tab.transactionReviewLocalDataById, transactionId.id, undefined);
550
+ if (transactionLocalData != null) {
551
+ lineIds.forEach((lineId) => {
552
+ const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
553
+ if (lineItem != null) {
554
+ transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
555
+ ...lineItem,
556
+ categoryClassRecommendationsFetchState: {
557
+ fetchState: 'In-Progress',
558
+ error: undefined,
559
+ },
560
+ };
561
+ }
562
+ });
563
+ }
564
+ // Uncheck on fetch start: the row's existing category/class are
565
+ // stale after a payee change, so we drop the auto-selection until
566
+ // fresh recommendations land.
567
+ if (tab.selectedCheckBoxTransactionIds.includes(transactionId.id)) {
568
+ tab.selectedCheckBoxTransactionIds =
569
+ tab.selectedCheckBoxTransactionIds.filter((id) => id !== transactionId.id);
570
+ }
571
+ },
572
+ prepare(selectedTab, transactionId, lineIds) {
573
+ return { payload: { selectedTab, transactionId, lineIds } };
574
+ },
575
+ },
576
+ // Completed arm. Used by the epic when the HTTP call succeeds but the
577
+ // server returned no per-line recommendations — we still need to
578
+ // release the In-Progress flag so the skeleton resolves. Successful
579
+ // responses with recommendations go through
580
+ // setEntityRecommendationForLineIdsForCategorization instead (which
581
+ // also flips the lines to Completed).
582
+ markCategoryClassRecommendationsCompletedForCategorization: {
583
+ reducer(draft, action) {
584
+ const { selectedTab, transactionId, lineIds } = action.payload;
585
+ const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
586
+ .transactionReviewLocalDataById, transactionId.id, undefined);
587
+ if (transactionLocalData != null) {
588
+ lineIds.forEach((lineId) => {
589
+ const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
590
+ if (lineItem != null) {
591
+ transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
592
+ ...lineItem,
593
+ categoryClassRecommendationsFetchState: {
594
+ fetchState: 'Completed',
595
+ error: undefined,
596
+ },
597
+ };
598
+ }
599
+ });
600
+ }
601
+ },
602
+ prepare(selectedTab, transactionId, lineIds) {
603
+ return { payload: { selectedTab, transactionId, lineIds } };
604
+ },
605
+ },
606
+ // Failure arm. Flips covered lines to Error so the skeleton resolves
607
+ // and downstream UI can react to the failure. The transaction stays
608
+ // unchecked from the start-arm action.
609
+ markCategoryClassRecommendationsFailureForCategorization: {
610
+ reducer(draft, action) {
611
+ const { selectedTab, transactionId, lineIds, error } = action.payload;
612
+ const transactionLocalData = recordGet(draft.transactionCategorizationView[selectedTab]
613
+ .transactionReviewLocalDataById, transactionId.id, undefined);
614
+ if (transactionLocalData != null) {
615
+ lineIds.forEach((lineId) => {
616
+ const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
617
+ if (lineItem != null) {
618
+ transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
619
+ ...lineItem,
620
+ categoryClassRecommendationsFetchState: {
621
+ fetchState: 'Error',
622
+ error,
623
+ },
624
+ };
625
+ }
626
+ });
627
+ }
628
+ },
629
+ prepare(selectedTab, transactionId, lineIds, error) {
630
+ return { payload: { selectedTab, transactionId, lineIds, error } };
631
+ },
632
+ },
526
633
  fetchTransactionCategorizationSuccess(draft, action) {
527
634
  const { selectedTab, refreshViewInBackground } = action.payload;
528
635
  if (draft.transactionCategorizationView[selectedTab].fetchState ===
@@ -618,9 +725,7 @@ const expenseAutomationTransactionsView = createSlice({
618
725
  .selectedCheckBoxTransactionIds;
619
726
  if (newTransactionLocalData.customer != null &&
620
727
  newTransactionLocalData.customer.id != null &&
621
- checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
622
- selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
623
- selectedCheckBoxTransactionIds.includes(transactionId) === false) {
728
+ shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
624
729
  draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
625
730
  ...selectedCheckBoxTransactionIds,
626
731
  transactionId,
@@ -694,9 +799,7 @@ const expenseAutomationTransactionsView = createSlice({
694
799
  .selectedCheckBoxTransactionIds;
695
800
  if (newTransactionLocalData.vendor != null &&
696
801
  newTransactionLocalData.vendor.id != null &&
697
- checkIfAllLineItemsAreCategoryClassFilled(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
698
- selectedCheckBoxTransactionIds.length < MAX_SELECTION_LIMIT &&
699
- selectedCheckBoxTransactionIds.includes(transactionId) === false) {
802
+ shouldAutoSelectAndAdd(selectedTransaction, newTransactionLocalData, selectedCheckBoxTransactionIds, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled)) {
700
803
  draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
701
804
  ...selectedCheckBoxTransactionIds,
702
805
  transactionId,
@@ -929,5 +1032,5 @@ const expenseAutomationTransactionsView = createSlice({
929
1032
  },
930
1033
  },
931
1034
  });
932
- export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, updateParentTotalCountForTab, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
1035
+ export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, updateParentTotalCountForTab, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, markCategoryClassRecommendationsInProgressForCategorization, markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
933
1036
  export default expenseAutomationTransactionsView.reducer;
@@ -1,3 +1,4 @@
1
+ import { createSelector } from '@reduxjs/toolkit';
1
2
  import omit from 'lodash/omit';
2
3
  import { reduceAllFetchState, reduceAnyFetchState, } from '../../../commonStateTypes/reduceFetchState';
3
4
  import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
@@ -8,6 +9,59 @@ import { getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts
8
9
  import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
9
10
  import { getProjectList } from '../../projectList/projectListSelector';
10
11
  import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
12
+ // Walks the tab's transactionReviewLocalDataById map and returns
13
+ // `{ [transactionId]: true }` for every transaction that has at least
14
+ // one line whose targeted-fetch is In-Progress. Pulled out as a plain
15
+ // function so each tab's createSelector can share it.
16
+ const computeCategorizationInFlightRecommendations = (transactionReviewLocalDataById) => {
17
+ const result = {};
18
+ if (transactionReviewLocalDataById == null) {
19
+ return result;
20
+ }
21
+ for (const [transactionId, data] of Object.entries(transactionReviewLocalDataById)) {
22
+ const lineItems = Object.values(data.transactionReviewLocalData.lineItemById);
23
+ if (lineItems.some((lineItem) => lineItem.categoryClassRecommendationsFetchState?.fetchState ===
24
+ 'In-Progress')) {
25
+ result[transactionId] = true;
26
+ }
27
+ }
28
+ return result;
29
+ };
30
+ // Per-tab createSelector instances. Each one is memoized on its OWN tab's
31
+ // transactionReviewLocalDataById reference. Switching tabs A->B->A no
32
+ // longer busts the memo for tab A — the dispatcher below just returns
33
+ // whichever per-tab selector matches the active tab, and reselect keeps
34
+ // the prior result alive as long as the underlying slice ref is stable.
35
+ const getReviewInFlightRecommendationsByTransactionId = createSelector((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
36
+ .review.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
37
+ const getAutoCategorizedInFlightRecommendationsByTransactionId = createSelector((state) => state.expenseAutomationTransactionsViewState.transactionCategorizationView
38
+ .autoCategorized.transactionReviewLocalDataById, computeCategorizationInFlightRecommendations);
39
+ // Per-transaction "any line is fetching category/class recommendations?"
40
+ // map for the active categorization tab. Dispatches to the per-tab
41
+ // memoized selector above so steady state (no fetches in flight)
42
+ // recomputes only when the active tab's local data changes; tab switches
43
+ // are O(1) cache lookups.
44
+ //
45
+ // `default` guards against the union "lying" at runtime: `TransactionsTab`
46
+ // is produced via `stringToUnion`, which falls back to `s as StringUnion`
47
+ // for unrecognized strings, so an unexpected value can land in state. The
48
+ // downstream `getCategorizationHasInFlightRecommendations` calls
49
+ // `Object.keys` on this result, so we must always return an object.
50
+ export const getCategorizationInFlightRecommendationsByTransactionId = (state) => {
51
+ const tab = state.expenseAutomationTransactionsViewState
52
+ .selectedTransactionCategorizationTab;
53
+ switch (tab) {
54
+ case 'review':
55
+ return getReviewInFlightRecommendationsByTransactionId(state);
56
+ case 'autoCategorized':
57
+ return getAutoCategorizedInFlightRecommendationsByTransactionId(state);
58
+ default:
59
+ return {};
60
+ }
61
+ };
62
+ // Page-level "any line on the active tab is in flight?" flag. Drives the
63
+ // list-page Save disable.
64
+ export const getCategorizationHasInFlightRecommendations = createSelector(getCategorizationInFlightRecommendationsByTransactionId, (inFlightByTransactionId) => Object.keys(inFlightByTransactionId).length > 0);
11
65
  export function getExpenseAutomationTransactionView(state) {
12
66
  const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
13
67
  const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
@@ -103,6 +157,8 @@ export function getExpenseAutomationTransactionView(state) {
103
157
  : [];
104
158
  const transactionCompletionStatus = allSteps.find((step) => step.step === 'transaction_categorization')?.completionStatus;
105
159
  const completionStatus = transactionCompletionStatus ?? 'incomplete';
160
+ const inFlightCategoryClassRecommendationsByTransactionId = getCategorizationInFlightRecommendationsByTransactionId(state);
161
+ const hasInFlightCategoryClassRecommendations = getCategorizationHasInFlightRecommendations(state);
106
162
  return {
107
163
  version: 0,
108
164
  fetchState: fetchStatus.fetchState,
@@ -116,6 +172,8 @@ export function getExpenseAutomationTransactionView(state) {
116
172
  classList: allClasses,
117
173
  accountsHierarchyList,
118
174
  classHierarchyList,
175
+ hasInFlightCategoryClassRecommendations,
176
+ inFlightCategoryClassRecommendationsByTransactionId,
119
177
  isAccountingProjectsEnabled,
120
178
  projectList,
121
179
  transactionLocalData,
@@ -0,0 +1,87 @@
1
+ import { concat, of, timer } from 'rxjs';
2
+ import { catchError, debounce, filter, groupBy, mergeMap, switchMap, } from 'rxjs/operators';
3
+ import { getIsAccountingClassesEnabled } from '../../entity/tenant/tenantSelector';
4
+ import { getTransactionWithCOT, getTransactionWithCOTFromRecommendations, } from '../../entity/transaction/transactionHelper';
5
+ import { createZeniAPIStatus, isSuccessResponse } from '../../responsePayload';
6
+ import { getUncategorizedAccounts } from '../accountList/accountListSelector';
7
+ import { markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, markCategoryClassRecommendationsInProgressForCategorization, setEntityRecommendationForLineIdsForCategorization, } from '../expenseAutomationView/reducers/transactionsViewReducer';
8
+ import { markCategoryClassRecommendationsCompletedForTransactionDetail, markCategoryClassRecommendationsFailureForTransactionDetail, markCategoryClassRecommendationsInProgressForTransactionDetail, setEntityRecommendationForLineIdsForTransactionDetail, } from '../transactionDetail/transactionDetailReducer';
9
+ import { buildRecommendationUrl, getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT, } from './recommendationHelper';
10
+ import { fetchEntityRecommendationsForLineUpdate } from './recommendationReducer';
11
+ // Close the per-target groupBy bucket after this much idle time so inactive
12
+ // groups don't accumulate forever (each group holds a Subject + a chain of
13
+ // active subscribers; without a duration selector groupBy retains them for
14
+ // the lifetime of the source observable, which is the lifetime of the app).
15
+ // Picked at 60s to leave a generous window for re-fetches on the same
16
+ // payee/transaction/line target while still bounding memory.
17
+ const GROUP_INACTIVITY_TIMEOUT_MS = 60000;
18
+ // Build the groupBy key. Same flow + same transaction + same line set
19
+ // share a target so switchMap can cancel an in-flight prior fetch. Use
20
+ // NUL (\u0000) as separator because it can never appear in transaction
21
+ // or line ids (vs the `|` used in an earlier WIP which collides with
22
+ // pipe-delimited synthetic ids).
23
+ const SEPARATOR = '\u0000';
24
+ const toGroupKey = (flowType, transactionId, lineIds) => `${flowType}${SEPARATOR}${transactionId}${SEPARATOR}${[...lineIds]
25
+ .sort((a, b) => a.localeCompare(b))
26
+ .join(SEPARATOR)}`;
27
+ // Targeted recommendations fetch that drives the per-line skeleton, the
28
+ // list-page row-checkbox uncheck/recheck, and the page-level Save
29
+ // disable.
30
+ //
31
+ // Concurrency model:
32
+ // - groupBy by (flowType, transactionId, sorted lineIds) so distinct
33
+ // targets run in parallel.
34
+ // - inside each group, switchMap so a re-fetch on the SAME target
35
+ // cancels any prior in-flight request for that target.
36
+ // - groupBy duration selector closes idle groups to bound memory.
37
+ export const fetchEntityRecommendationsForLineUpdateEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchEntityRecommendationsForLineUpdate.match), groupBy((action) => toGroupKey(action.payload.flowType, action.payload.transactionDetails.transactionId.id, action.payload.transactionDetails.lineIds), undefined, (group$) => group$.pipe(debounce(() => timer(GROUP_INACTIVITY_TIMEOUT_MS)))), mergeMap((group$) => group$.pipe(switchMap((action) => {
38
+ const payload = action.payload;
39
+ const { transactionId, transaction, lineIds } = payload.transactionDetails;
40
+ const { entity, amount, isFetchCOT, isUncategorizedExpenseCategoryEnabled, } = payload;
41
+ // Synchronously emit the start arm so the per-line skeleton +
42
+ // row uncheck happen before the HTTP request begins. The
43
+ // discriminated-union payload narrows `payload.selectedTab` to
44
+ // a non-optional `TransactionsTab` inside the `'categorization'`
45
+ // branch, so no defensive fallthrough is needed.
46
+ const startAction = payload.flowType === 'categorization'
47
+ ? markCategoryClassRecommendationsInProgressForCategorization(payload.selectedTab, transactionId, lineIds)
48
+ : markCategoryClassRecommendationsInProgressForTransactionDetail(transactionId, lineIds);
49
+ const url = buildRecommendationUrl(zeniAPI.apiEndPoints.accountMicroServiceBaseUrl, entity, amount, payload.transactionDetails, isFetchCOT === true);
50
+ const httpStream$ = zeniAPI
51
+ .getJSON(url)
52
+ .pipe(mergeMap((response) => {
53
+ if (!isSuccessResponse(response) || response.data == null) {
54
+ return of(payload.flowType === 'categorization'
55
+ ? markCategoryClassRecommendationsFailureForCategorization(payload.selectedTab, transactionId, lineIds, response.status)
56
+ : markCategoryClassRecommendationsFailureForTransactionDetail(transactionId, lineIds, response.status));
57
+ }
58
+ const recommendationWithCOTByLineId = getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT(response.data.recommendations, lineIds);
59
+ // HTTP 200 with no per-line recommendations: NOT an error.
60
+ // Flip lines to Completed so the skeleton resolves and
61
+ // downstream UI can treat this as "we tried, nothing to
62
+ // apply".
63
+ if (recommendationWithCOTByLineId == null) {
64
+ return of(payload.flowType === 'categorization'
65
+ ? markCategoryClassRecommendationsCompletedForCategorization(payload.selectedTab, transactionId, lineIds)
66
+ : markCategoryClassRecommendationsCompletedForTransactionDetail(transactionId, lineIds));
67
+ }
68
+ const transactionWithCOT = isFetchCOT === true
69
+ ? getTransactionWithCOTFromRecommendations(transaction, recommendationWithCOTByLineId)
70
+ : getTransactionWithCOT(transaction);
71
+ const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
72
+ if (payload.flowType === 'categorization') {
73
+ return of(setEntityRecommendationForLineIdsForCategorization(payload.selectedTab, transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, getIsAccountingClassesEnabled(state$.value)));
74
+ }
75
+ return of(setEntityRecommendationForLineIdsForTransactionDetail(transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense));
76
+ }), catchError((error) => {
77
+ const errorMessage = 'fetchEntityRecommendationsForLineUpdate failed: ' +
78
+ (error instanceof Error
79
+ ? error.message
80
+ : JSON.stringify(error));
81
+ const status = createZeniAPIStatus('Unexpected Error', errorMessage);
82
+ return of(payload.flowType === 'categorization'
83
+ ? markCategoryClassRecommendationsFailureForCategorization(payload.selectedTab, transactionId, lineIds, status)
84
+ : markCategoryClassRecommendationsFailureForTransactionDetail(transactionId, lineIds, status));
85
+ }));
86
+ return concat(of(startAction), httpStream$);
87
+ }))));
@@ -1,4 +1,5 @@
1
1
  import { transformRecommendation, transformRecommendationWithCOT, } from '../../entity/transaction/payloadTypes/transactionPayload';
2
+ import { getActualTransactionID } from '../transactionDetail/transactionDetailState';
2
3
  export const getRecommendationFromRecommendationPayload = (payload) => {
3
4
  if (payload == null || payload.length === 0) {
4
5
  return undefined;
@@ -37,6 +38,34 @@ export const getRecommendationWithCOTFromRecommendationPayloadWithCOT = (payload
37
38
  });
38
39
  return recommendations;
39
40
  };
41
+ // Pluralized URL segment for entity types. Mirrors the legacy
42
+ // fetchEntityRecommendationsByTransactionIdEpic.toEntityTypeURL.
43
+ const toEntityTypeUrlSegment = (entityType) => `${entityType}s`;
44
+ // Build the recommendations URL for a single entity + transaction target.
45
+ // Centralizes the URL shape so the legacy
46
+ // fetchEntityRecommendationsByTransactionIdEpic and the new
47
+ // fetchEntityRecommendationsForLineUpdateEpic stay in lockstep.
48
+ export const buildRecommendationUrl = (accountMicroServiceBaseUrl, entity, amount, transactionDetails, isFetchCOT) => {
49
+ const entityQuery = {
50
+ entity_name: entity.name,
51
+ entity_type: entity.type,
52
+ };
53
+ // Entity-id-null case: server expects entity_name / entity_type query
54
+ // instead of the {entityType}/{qboId}/recommendations path.
55
+ if (entity.qboId === entity.name) {
56
+ return `${accountMicroServiceBaseUrl}/1.0/recommendations?query=${encodeURIComponent(JSON.stringify(entityQuery))}`;
57
+ }
58
+ const query = {
59
+ amount,
60
+ transaction_id: getActualTransactionID(transactionDetails.transactionId.id),
61
+ transaction_type: transactionDetails.transaction.type,
62
+ line_ids: transactionDetails.lineIds,
63
+ };
64
+ if (isFetchCOT === true) {
65
+ query.include_cot = true;
66
+ }
67
+ return `${accountMicroServiceBaseUrl}/1.0/${toEntityTypeUrlSegment(entity.type)}/${entity.qboId}/recommendations?query=${encodeURIComponent(JSON.stringify(query))}`;
68
+ };
40
69
  export const getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT = (recommendationPayload, lineIds) => {
41
70
  if (recommendationPayload.length === 0) {
42
71
  return undefined;
@@ -33,6 +33,31 @@ const recommendation = createSlice({
33
33
  };
34
34
  },
35
35
  },
36
+ // Targeted recommendations fetch fired when the user changes the
37
+ // payee/customer on a single transaction line (or the JE sibling set
38
+ // for that change). Routed by `fetchEntityRecommendationsForLineUpdateEpic`
39
+ // which uses groupBy + switchMap to keep fetches for distinct targets
40
+ // running in parallel while same-target re-fetches still cancel each
41
+ // other. The flowType discriminator selects the categorization vs
42
+ // detail slice for the per-line In-Progress / Completed / Error state.
43
+ fetchEntityRecommendationsForLineUpdate: {
44
+ reducer(draft, action) {
45
+ const { entity } = action.payload;
46
+ const key = getEntityRecommendationKey(entity.type, entity.id);
47
+ // Unconditional flip to In-Progress; the previous variant only
48
+ // seeded when missing, which left stale fetchStates when a prior
49
+ // fetch had already populated the entity entry.
50
+ draft.recommendationByEntity[key] = {
51
+ ...(draft.recommendationByEntity[key] ??
52
+ initialEntityRecommendationState),
53
+ fetchState: 'In-Progress',
54
+ error: undefined,
55
+ };
56
+ },
57
+ prepare(args) {
58
+ return { payload: args };
59
+ },
60
+ },
36
61
  fetchRecommendationByEntityName: {
37
62
  reducer(draft, action) {
38
63
  const { entityName, entityType } = action.payload;
@@ -111,7 +136,7 @@ const recommendation = createSlice({
111
136
  },
112
137
  },
113
138
  });
114
- export const { fetchEntityRecommendationsByTransactionId, fetchRecommendationByEntityName, fetchRecommendationByEntityId, updateRecommendationForEntity, updateRecommendationForEntityFailure, indicateReadyToInitializeRecommendation, clearRecommendation, } = recommendation.actions;
139
+ export const { fetchEntityRecommendationsByTransactionId, fetchEntityRecommendationsForLineUpdate, fetchRecommendationByEntityName, fetchRecommendationByEntityId, updateRecommendationForEntity, updateRecommendationForEntityFailure, indicateReadyToInitializeRecommendation, clearRecommendation, } = recommendation.actions;
115
140
  export default recommendation.reducer;
116
141
  const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
117
142
  const key = getEntityRecommendationKey(entityType, entityId);