@zeniai/client-epic-state 5.0.69-betaML7 → 5.0.69-betaRR07

package/lib/view/transactionDetail/transactionDetailSelector.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getInitialUpdatablePeriodsForTransactionRecommendations = exports.getTransactionDetail = exports.getDetailInFlightRecommendations = void 0;
+exports.getInitialUpdatablePeriodsForTransactionRecommendations = exports.getTransactionDetail = void 0;
 exports.getTransactionDetailForTransaction = getTransactionDetailForTransaction;
 const get_1 = __importDefault(require("lodash/get"));
 const reduceFetchState_1 = require("../../commonStateTypes/reduceFetchState");
@@ -17,27 +17,6 @@ const accountListSelector_1 = require("../accountList/accountListSelector");
 const classListSelector_1 = require("../classList/classListSelector");
 const projectListSelector_1 = require("../projectList/projectListSelector");
 const transactionDetailState_1 = require("./transactionDetailState");
-// "Any line on this transaction is fetching category/class recommendations?"
-// Inlined as a plain function because the upstream selector
-// `getTransactionDetail` is also un-memoized and the iteration is O(lines)
-// — typically <10. Exported standalone so consumers that only need the
-// flag (e.g. footer save-disable) can avoid materializing the whole
-// detail report.
-const getDetailInFlightRecommendations = (state, transactionId) => {
-    const detailKey = (0, transactionDetailState_1.getTransactionDetailKey)(transactionId);
-    const detail = (0, get_1.default)(state.transactionDetailState.transactionDetailById, detailKey, undefined);
-    if (detail == null) {
-        return false;
-    }
-    for (const lineItem of Object.values(detail.transactionDetailLocalData.lineItemById)) {
-        if (lineItem.categoryClassRecommendationsFetchState?.fetchState ===
-            'In-Progress') {
-            return true;
-        }
-    }
-    return false;
-};
-exports.getDetailInFlightRecommendations = getDetailInFlightRecommendations;
 const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = true) => {
     const { transactionDetailState, transactionState, vendorState, vendorListState, accountState, classState, classListState, accountListState, projectState, projectListState, } = state;
     const detailKey = (0, transactionDetailState_1.getTransactionDetailKey)(transactionId);
@@ -106,7 +85,6 @@ const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = tr
         : [];
     const transactionDetailAnyUpdateStatus = reduceUpdateFetchStates(transactionDetail);
     const vendors = (0, vendorSelector_1.getVendorsByVendorIds)(vendorState, vendorListState.vendorIds);
-    const hasInFlightCategoryClassRecommendations = (0, exports.getDetailInFlightRecommendations)(state, transactionId);
     return {
         reportId: 'transaction_detail',
         reportTitle: 'Transaction Detail',
@@ -122,7 +100,6 @@ const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = tr
         classHierarchyList,
         accountsHierarchyList,
         classList: classList,
-        hasInFlightCategoryClassRecommendations,
         isAccountingClassesEnabled,
         isAccountingProjectsEnabled,
         projectList,

package/lib/view/transactionDetail/transactionDetailTypes.d.ts

@@ -14,7 +14,6 @@ export interface TransactionDetailLineItemData extends TransactionLineBase {
     isClassMiscategorized: boolean;
     account?: AccountBase;
     billable?: BillableStatus;
-    categoryClassRecommendationsFetchState?: FetchStateAndError;
     class?: ClassBase;
     customer?: CustomerBase;
     isCategoryUpdateSelected?: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.69-betaML7",
+  "version": "5.0.69-betaRR07",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/esm/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.js

@@ -1,83 +0,0 @@
-import { concat, of, timer } from 'rxjs';
-import { catchError, debounce, filter, groupBy, mergeMap, switchMap, } from 'rxjs/operators';
-import { getIsAccountingClassesEnabled } from '../../entity/tenant/tenantSelector';
-import { getTransactionWithCOT, getTransactionWithCOTFromRecommendations, } from '../../entity/transaction/transactionHelper';
-import { createZeniAPIStatus, isSuccessResponse } from '../../responsePayload';
-import { getUncategorizedAccounts } from '../accountList/accountListSelector';
-import { markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, markCategoryClassRecommendationsInProgressForCategorization, setEntityRecommendationForLineIdsForCategorization, } from '../expenseAutomationView/reducers/transactionsViewReducer';
-import { markCategoryClassRecommendationsCompletedForTransactionDetail, markCategoryClassRecommendationsFailureForTransactionDetail, markCategoryClassRecommendationsInProgressForTransactionDetail, setEntityRecommendationForLineIdsForTransactionDetail, } from '../transactionDetail/transactionDetailReducer';
-import { buildRecommendationUrl, getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT, } from './recommendationHelper';
-import { fetchEntityRecommendationsForLineUpdate } from './recommendationReducer';
-// Close the per-target groupBy bucket after this much idle time so inactive
-// groups don't accumulate forever (each group holds a Subject + a chain of
-// active subscribers; without a duration selector groupBy retains them for
-// the lifetime of the source observable, which is the lifetime of the app).
-// Picked at 60s to leave a generous window for re-fetches on the same
-// payee/transaction/line target while still bounding memory.
-const GROUP_INACTIVITY_TIMEOUT_MS = 60000;
-// Build the groupBy key. Same flow + same transaction + same line set
-// share a target so switchMap can cancel an in-flight prior fetch. Use
-// NUL (\u0000) as separator because it can never appear in transaction
-// or line ids (vs the `|` used in an earlier WIP which collides with
-// pipe-delimited synthetic ids).
-const SEPARATOR = '\u0000';
-const toGroupKey = (flowType, transactionId, lineIds) => `${flowType}${SEPARATOR}${transactionId}${SEPARATOR}${[...lineIds]
-    .sort((a, b) => a.localeCompare(b))
-    .join(SEPARATOR)}`;
-// Targeted recommendations fetch that drives the per-line skeleton, the
-// list-page row-checkbox uncheck/recheck, and the page-level Save
-// disable.
-//
-// Concurrency model:
-//   - groupBy by (flowType, transactionId, sorted lineIds) so distinct
-//     targets run in parallel.
-//   - inside each group, switchMap so a re-fetch on the SAME target
-//     cancels any prior in-flight request for that target.
-//   - groupBy duration selector closes idle groups to bound memory.
-export const fetchEntityRecommendationsForLineUpdateEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchEntityRecommendationsForLineUpdate.match), groupBy((action) => toGroupKey(action.payload.flowType, action.payload.transactionDetails.transactionId.id, action.payload.transactionDetails.lineIds), undefined, (group$) => group$.pipe(debounce(() => timer(GROUP_INACTIVITY_TIMEOUT_MS)))), mergeMap((group$) => group$.pipe(switchMap((action) => {
-    const { entity, amount, transactionDetails, flowType, selectedTab, isFetchCOT, isUncategorizedExpenseCategoryEnabled, } = action.payload;
-    const { transactionId, transaction, lineIds } = transactionDetails;
-    // Synchronously emit the start arm so the per-line skeleton +
-    // row uncheck happen before the HTTP request begins.
-    const startAction = flowType === 'categorization' && selectedTab != null
-        ? markCategoryClassRecommendationsInProgressForCategorization(selectedTab, transactionId, lineIds)
-        : markCategoryClassRecommendationsInProgressForTransactionDetail(transactionId, lineIds);
-    const url = buildRecommendationUrl(zeniAPI.apiEndPoints.accountMicroServiceBaseUrl, entity, amount, transactionDetails, isFetchCOT === true);
-    const httpStream$ = zeniAPI
-        .getJSON(url)
-        .pipe(mergeMap((response) => {
-        if (!isSuccessResponse(response) || response.data == null) {
-            return of(flowType === 'categorization' && selectedTab != null
-                ? markCategoryClassRecommendationsFailureForCategorization(selectedTab, transactionId, lineIds, response.status)
-                : markCategoryClassRecommendationsFailureForTransactionDetail(transactionId, lineIds, response.status));
-        }
-        const recommendationWithCOTByLineId = getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT(response.data.recommendations, lineIds);
-        // HTTP 200 with no per-line recommendations: NOT an error.
-        // Flip lines to Completed so the skeleton resolves and
-        // downstream UI can treat this as "we tried, nothing to
-        // apply".
-        if (recommendationWithCOTByLineId == null) {
-            return of(flowType === 'categorization' && selectedTab != null
-                ? markCategoryClassRecommendationsCompletedForCategorization(selectedTab, transactionId, lineIds)
-                : markCategoryClassRecommendationsCompletedForTransactionDetail(transactionId, lineIds));
-        }
-        const transactionWithCOT = isFetchCOT === true
-            ? getTransactionWithCOTFromRecommendations(transaction, recommendationWithCOTByLineId)
-            : getTransactionWithCOT(transaction);
-        const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
-        if (flowType === 'categorization' && selectedTab != null) {
-            return of(setEntityRecommendationForLineIdsForCategorization(selectedTab, transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, getIsAccountingClassesEnabled(state$.value)));
-        }
-        return of(setEntityRecommendationForLineIdsForTransactionDetail(transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense));
-    }), catchError((error) => {
-        const errorMessage = 'fetchEntityRecommendationsForLineUpdate failed: ' +
-            (error instanceof Error
-                ? error.message
-                : JSON.stringify(error));
-        const status = createZeniAPIStatus('Unexpected Error', errorMessage);
-        return of(flowType === 'categorization' && selectedTab != null
-            ? markCategoryClassRecommendationsFailureForCategorization(selectedTab, transactionId, lineIds, status)
-            : markCategoryClassRecommendationsFailureForTransactionDetail(transactionId, lineIds, status));
-    }));
-    return concat(of(startAction), httpStream$);
-}))));

package/lib/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.d.ts

@@ -1,9 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { RootState } from '../../reducer';
-import { ZeniAPI } from '../../zeniAPI';
-import { markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, markCategoryClassRecommendationsInProgressForCategorization, setEntityRecommendationForLineIdsForCategorization } from '../expenseAutomationView/reducers/transactionsViewReducer';
-import { markCategoryClassRecommendationsCompletedForTransactionDetail, markCategoryClassRecommendationsFailureForTransactionDetail, markCategoryClassRecommendationsInProgressForTransactionDetail, setEntityRecommendationForLineIdsForTransactionDetail } from '../transactionDetail/transactionDetailReducer';
-import { fetchEntityRecommendationsForLineUpdate } from './recommendationReducer';
-export type ActionType = ReturnType<typeof fetchEntityRecommendationsForLineUpdate> | ReturnType<typeof markCategoryClassRecommendationsInProgressForCategorization> | ReturnType<typeof markCategoryClassRecommendationsCompletedForCategorization> | ReturnType<typeof markCategoryClassRecommendationsFailureForCategorization> | ReturnType<typeof markCategoryClassRecommendationsInProgressForTransactionDetail> | ReturnType<typeof markCategoryClassRecommendationsCompletedForTransactionDetail> | ReturnType<typeof markCategoryClassRecommendationsFailureForTransactionDetail> | ReturnType<typeof setEntityRecommendationForLineIdsForCategorization> | ReturnType<typeof setEntityRecommendationForLineIdsForTransactionDetail>;
-export declare const fetchEntityRecommendationsForLineUpdateEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/fetchEntityRecommendationsForLineUpdateEpic.js

@@ -1,87 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchEntityRecommendationsForLineUpdateEpic = void 0;
-const rxjs_1 = require("rxjs");
-const operators_1 = require("rxjs/operators");
-const tenantSelector_1 = require("../../entity/tenant/tenantSelector");
-const transactionHelper_1 = require("../../entity/transaction/transactionHelper");
-const responsePayload_1 = require("../../responsePayload");
-const accountListSelector_1 = require("../accountList/accountListSelector");
-const transactionsViewReducer_1 = require("../expenseAutomationView/reducers/transactionsViewReducer");
-const transactionDetailReducer_1 = require("../transactionDetail/transactionDetailReducer");
-const recommendationHelper_1 = require("./recommendationHelper");
-const recommendationReducer_1 = require("./recommendationReducer");
-// Close the per-target groupBy bucket after this much idle time so inactive
-// groups don't accumulate forever (each group holds a Subject + a chain of
-// active subscribers; without a duration selector groupBy retains them for
-// the lifetime of the source observable, which is the lifetime of the app).
-// Picked at 60s to leave a generous window for re-fetches on the same
-// payee/transaction/line target while still bounding memory.
-const GROUP_INACTIVITY_TIMEOUT_MS = 60000;
-// Build the groupBy key. Same flow + same transaction + same line set
-// share a target so switchMap can cancel an in-flight prior fetch. Use
-// NUL (\u0000) as separator because it can never appear in transaction
-// or line ids (vs the `|` used in an earlier WIP which collides with
-// pipe-delimited synthetic ids).
-const SEPARATOR = '\u0000';
-const toGroupKey = (flowType, transactionId, lineIds) => `${flowType}${SEPARATOR}${transactionId}${SEPARATOR}${[...lineIds]
-    .sort((a, b) => a.localeCompare(b))
-    .join(SEPARATOR)}`;
-// Targeted recommendations fetch that drives the per-line skeleton, the
-// list-page row-checkbox uncheck/recheck, and the page-level Save
-// disable.
-//
-// Concurrency model:
-//   - groupBy by (flowType, transactionId, sorted lineIds) so distinct
-//     targets run in parallel.
-//   - inside each group, switchMap so a re-fetch on the SAME target
-//     cancels any prior in-flight request for that target.
-//   - groupBy duration selector closes idle groups to bound memory.
-const fetchEntityRecommendationsForLineUpdateEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.fetchEntityRecommendationsForLineUpdate.match), (0, operators_1.groupBy)((action) => toGroupKey(action.payload.flowType, action.payload.transactionDetails.transactionId.id, action.payload.transactionDetails.lineIds), undefined, (group$) => group$.pipe((0, operators_1.debounce)(() => (0, rxjs_1.timer)(GROUP_INACTIVITY_TIMEOUT_MS)))), (0, operators_1.mergeMap)((group$) => group$.pipe((0, operators_1.switchMap)((action) => {
-    const { entity, amount, transactionDetails, flowType, selectedTab, isFetchCOT, isUncategorizedExpenseCategoryEnabled, } = action.payload;
-    const { transactionId, transaction, lineIds } = transactionDetails;
-    // Synchronously emit the start arm so the per-line skeleton +
-    // row uncheck happen before the HTTP request begins.
-    const startAction = flowType === 'categorization' && selectedTab != null
-        ? (0, transactionsViewReducer_1.markCategoryClassRecommendationsInProgressForCategorization)(selectedTab, transactionId, lineIds)
-        : (0, transactionDetailReducer_1.markCategoryClassRecommendationsInProgressForTransactionDetail)(transactionId, lineIds);
-    const url = (0, recommendationHelper_1.buildRecommendationUrl)(zeniAPI.apiEndPoints.accountMicroServiceBaseUrl, entity, amount, transactionDetails, isFetchCOT === true);
-    const httpStream$ = zeniAPI
-        .getJSON(url)
-        .pipe((0, operators_1.mergeMap)((response) => {
-        if (!(0, responsePayload_1.isSuccessResponse)(response) || response.data == null) {
-            return (0, rxjs_1.of)(flowType === 'categorization' && selectedTab != null
-                ? (0, transactionsViewReducer_1.markCategoryClassRecommendationsFailureForCategorization)(selectedTab, transactionId, lineIds, response.status)
-                : (0, transactionDetailReducer_1.markCategoryClassRecommendationsFailureForTransactionDetail)(transactionId, lineIds, response.status));
-        }
-        const recommendationWithCOTByLineId = (0, recommendationHelper_1.getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT)(response.data.recommendations, lineIds);
-        // HTTP 200 with no per-line recommendations: NOT an error.
-        // Flip lines to Completed so the skeleton resolves and
-        // downstream UI can treat this as "we tried, nothing to
-        // apply".
-        if (recommendationWithCOTByLineId == null) {
-            return (0, rxjs_1.of)(flowType === 'categorization' && selectedTab != null
-                ? (0, transactionsViewReducer_1.markCategoryClassRecommendationsCompletedForCategorization)(selectedTab, transactionId, lineIds)
-                : (0, transactionDetailReducer_1.markCategoryClassRecommendationsCompletedForTransactionDetail)(transactionId, lineIds));
-        }
-        const transactionWithCOT = isFetchCOT === true
-            ? (0, transactionHelper_1.getTransactionWithCOTFromRecommendations)(transaction, recommendationWithCOTByLineId)
-            : (0, transactionHelper_1.getTransactionWithCOT)(transaction);
-        const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(state$.value.accountState, state$.value.accountListState, 'accountList');
-        if (flowType === 'categorization' && selectedTab != null) {
-            return (0, rxjs_1.of)((0, transactionsViewReducer_1.setEntityRecommendationForLineIdsForCategorization)(selectedTab, transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value)));
-        }
-        return (0, rxjs_1.of)((0, transactionDetailReducer_1.setEntityRecommendationForLineIdsForTransactionDetail)(transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense));
-    }), (0, operators_1.catchError)((error) => {
-        const errorMessage = 'fetchEntityRecommendationsForLineUpdate failed: ' +
-            (error instanceof Error
-                ? error.message
-                : JSON.stringify(error));
-        const status = (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', errorMessage);
-        return (0, rxjs_1.of)(flowType === 'categorization' && selectedTab != null
-            ? (0, transactionsViewReducer_1.markCategoryClassRecommendationsFailureForCategorization)(selectedTab, transactionId, lineIds, status)
-            : (0, transactionDetailReducer_1.markCategoryClassRecommendationsFailureForTransactionDetail)(transactionId, lineIds, status));
-    }));
-    return (0, rxjs_1.concat)((0, rxjs_1.of)(startAction), httpStream$);
-}))));
-exports.fetchEntityRecommendationsForLineUpdateEpic = fetchEntityRecommendationsForLineUpdateEpic;