@zeniai/client-epic-state 5.0.69-betaAR3 → 5.0.69-betaAR5

package/lib/commonStateTypes/filterPrimitives.d.ts

@@ -0,0 +1,23 @@
+/**
+ * Shared filter primitives — used by both Transaction Categorization and
+ * Spend Management filter pipelines.
+ *
+ * These types are deliberately decoupled from any specific feature group:
+ *
+ *   - `CategoryCombinationOperator` is how a `categories[]` array combines
+ *     (`AND` ⇒ every category must match; `OR` ⇒ any category matches).
+ *   - `FilterCategoryType` is the input-type tag a filter category uses to
+ *     pick its value-picker UI (text autocomplete, user picker, date range,
+ *     number range, plain dropdown).
+ *
+ * They used to be redeclared locally in both `transactionFilterHelpers.ts`
+ * and `spendManagementFilterHelpers.ts` to keep the feature groups
+ * independent. Centralising them here is consistent with Route B (which
+ * separated the *matching pipelines*, not the *shared primitive types*) and
+ * removes the maintenance trap of two identical type definitions drifting
+ * apart over time.
+ */
+/** How `categories[]` combines: AND requires every category to match, OR requires any. */
+export type CategoryCombinationOperator = 'AND' | 'OR';
+/** Input-type tag a filter category uses to pick its value-picker UI. */
+export type FilterCategoryType = 'searchAutocomplete' | 'user' | 'dateRange' | 'numberRange' | 'dropdown';

package/lib/commonStateTypes/filterPrimitives.js

@@ -0,0 +1,21 @@
+"use strict";
+/**
+ * Shared filter primitives — used by both Transaction Categorization and
+ * Spend Management filter pipelines.
+ *
+ * These types are deliberately decoupled from any specific feature group:
+ *
+ *   - `CategoryCombinationOperator` is how a `categories[]` array combines
+ *     (`AND` ⇒ every category must match; `OR` ⇒ any category matches).
+ *   - `FilterCategoryType` is the input-type tag a filter category uses to
+ *     pick its value-picker UI (text autocomplete, user picker, date range,
+ *     number range, plain dropdown).
+ *
+ * They used to be redeclared locally in both `transactionFilterHelpers.ts`
+ * and `spendManagementFilterHelpers.ts` to keep the feature groups
+ * independent. Centralising them here is consistent with Route B (which
+ * separated the *matching pipelines*, not the *shared primitive types*) and
+ * removes the maintenance trap of two identical type definitions drifting
+ * apart over time.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });

package/lib/esm/commonStateTypes/filterPrimitives.js

@@ -0,0 +1,20 @@
+/**
+ * Shared filter primitives — used by both Transaction Categorization and
+ * Spend Management filter pipelines.
+ *
+ * These types are deliberately decoupled from any specific feature group:
+ *
+ *   - `CategoryCombinationOperator` is how a `categories[]` array combines
+ *     (`AND` ⇒ every category must match; `OR` ⇒ any category matches).
+ *   - `FilterCategoryType` is the input-type tag a filter category uses to
+ *     pick its value-picker UI (text autocomplete, user picker, date range,
+ *     number range, plain dropdown).
+ *
+ * They used to be redeclared locally in both `transactionFilterHelpers.ts`
+ * and `spendManagementFilterHelpers.ts` to keep the feature groups
+ * independent. Centralising them here is consistent with Route B (which
+ * separated the *matching pipelines*, not the *shared primitive types*) and
+ * removes the maintenance trap of two identical type definitions drifting
+ * apart over time.
+ */
+export {};

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -305,9 +305,9 @@ const expenseAutomationTransactionsView = createSlice({
         },
         updateTransactionFilters(draft, action) {
             const { selectedTab, filters } = action.payload;
-            if (filters != null) {
-                draft.transactionCategorizationView[selectedTab].filters = filters;
-            }
+            // `filters` is non-nullable per the payload type, so no runtime
+            // null-check is needed — dropping it removes a dead defensive branch.
+            draft.transactionCategorizationView[selectedTab].filters = filters;
         },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {

package/lib/esm/view/expenseAutomationView/transactionFilterHelpers.js

@@ -176,7 +176,24 @@ const matchAmount = (amount, category) => {
 const transactionMatchesCategory = (transaction, category) => {
     const value = getCategoryValueForTransaction(category.field, transaction);
     if (value == null) {
-        // Absent values count as a match only under 'not_equal'.
+        // Absent-value semantics — pinning these down explicitly so the
+        // asymmetry isn't surprising:
+        //
+        //   not_equal: a missing value IS NOT EQUAL to any candidate, so the
+        //              transaction matches the filter (passes through).
+        //   equal:     a missing value is not equal to any candidate, so the
+        //              transaction does NOT match (filtered out).
+        //   less_than / greater_than: SQL-style three-valued logic — comparing
+        //              against a missing value is "unknown", which we treat as
+        //              "does not match" (filtered out). A user setting
+        //              "amount < $1000" probably wants transactions with a
+        //              concrete amount that satisfies the bound, not rows
+        //              where the amount can't be determined.
+        //   in_between: same as the single-sided comparators — missing values
+        //              are filtered out.
+        //
+        // Only the `not_equal` branch returns `true` here; everything else
+        // falls through to the `false` below.
         return category.matchingOperator === 'not_equal';
     }
     if (category.field === 'amount') {

package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -312,9 +312,9 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
         },
         updateTransactionFilters(draft, action) {
             const { selectedTab, filters } = action.payload;
-            if (filters != null) {
-                draft.transactionCategorizationView[selectedTab].filters = filters;
-            }
+            // `filters` is non-nullable per the payload type, so no runtime
+            // null-check is needed — dropping it removes a dead defensive branch.
+            draft.transactionCategorizationView[selectedTab].filters = filters;
         },
         saveTransactionCategorization: {
             prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {

package/lib/view/expenseAutomationView/transactionFilterHelpers.d.ts

@@ -2,22 +2,23 @@
  * Filter machinery for the Transaction Categorization feature inside
  * Expense Automation. Intentionally self-contained — does NOT import anything
  * from `view/spendManagement/*`, because Transaction Categorization is not a
- * Spend Management product. Generic primitives (`CategoryCombinationOperator`,
- * `FilterCategoryType`) are redeclared locally rather than imported across the
- * feature boundary; their definitions happen to coincide with the
- * spend-management equivalents, which is fine — they're the same primitive
- * concept used independently by both feature groups.
+ * Spend Management product. Shared primitives
+ * (`CategoryCombinationOperator`, `FilterCategoryType`) come from
+ * `commonStateTypes/filterPrimitives`, which both feature groups consume.
  */
 import { Amount } from '../../commonStateTypes/amount';
 import { ID } from '../../commonStateTypes/common';
+import { CategoryCombinationOperator, FilterCategoryType } from '../../commonStateTypes/filterPrimitives';
 import { TransactionType } from '../../entity/transaction/stateTypes/transactionType';
 import { SupportedTransactionWithCOT } from '../../entity/transaction/transactionState';
 import { ZeniDate } from '../../zeniDayJS';
 import { TransactionReviewLocalDataSelectorView } from './selectorTypes/transactionsViewSelectorTypes';
-/** Local copy of the generic combination operator — independent of SM. */
-export type CategoryCombinationOperator = 'AND' | 'OR';
-/** Local copy of the generic filter category-input type — independent of SM. */
-export type FilterCategoryType = 'searchAutocomplete' | 'user' | 'dateRange' | 'numberRange' | 'dropdown';
+/**
+ * Re-exported here so the CES barrel can pull TC's primitives from the
+ * Expense Automation surface without reaching into `commonStateTypes`
+ * directly — keeps the barrel's existing import topology stable.
+ */
+export type { CategoryCombinationOperator, FilterCategoryType };
 export type TransactionFilterEntityType = 'transaction_categorization' | 'customer' | 'vendor' | 'merchant';
 export type TransactionFilterCategoryField = 'payment_account_name' | 'payment_account_type' | 'payee' | 'category' | 'class' | 'amount';
 export interface TransactionFilterCategoryDropdownOption {

package/lib/view/expenseAutomationView/transactionFilterHelpers.js

@@ -179,7 +179,24 @@ const matchAmount = (amount, category) => {
 const transactionMatchesCategory = (transaction, category) => {
     const value = getCategoryValueForTransaction(category.field, transaction);
     if (value == null) {
-        // Absent values count as a match only under 'not_equal'.
+        // Absent-value semantics — pinning these down explicitly so the
+        // asymmetry isn't surprising:
+        //
+        //   not_equal: a missing value IS NOT EQUAL to any candidate, so the
+        //              transaction matches the filter (passes through).
+        //   equal:     a missing value is not equal to any candidate, so the
+        //              transaction does NOT match (filtered out).
+        //   less_than / greater_than: SQL-style three-valued logic — comparing
+        //              against a missing value is "unknown", which we treat as
+        //              "does not match" (filtered out). A user setting
+        //              "amount < $1000" probably wants transactions with a
+        //              concrete amount that satisfies the bound, not rows
+        //              where the amount can't be determined.
+        //   in_between: same as the single-sided comparators — missing values
+        //              are filtered out.
+        //
+        // Only the `not_equal` branch returns `true` here; everything else
+        // falls through to the `false` below.
         return category.matchingOperator === 'not_equal';
     }
     if (category.field === 'amount') {

package/lib/view/spendManagement/spendManagementFilterHelpers.d.ts

@@ -1,3 +1,4 @@
+import { CategoryCombinationOperator, FilterCategoryType } from '../../commonStateTypes/filterPrimitives';
 import { TimePeriod } from '../../commonStateTypes/timePeriod';
 import { UserRoleType } from '../../entity/userRole/userRoleType';
 import { RootState } from '../../reducer';
@@ -12,12 +13,20 @@ import { ReimbursementView } from './reimbursement/remiListView/remiListSelector
 import { ReimbursementFilters, RemiListViewFilterCategoryField } from './reimbursement/remiListView/remiListState';
 export type SpendManagementFiltersType = BillPayFilters | ReimbursementFilters | TaskListFilters | PaymentHistoryFilters;
 export type SpendManagementFilterEntityType = 'bill_pay' | 'reimbursement' | 'task_management' | 'charge_card_payment_history';
-export type FilterCategoryType = 'searchAutocomplete' | 'user' | 'dateRange' | 'numberRange' | 'dropdown';
+/**
+ * Re-exported here so consumers of `spendManagementFilterHelpers` keep
+ * their existing import path stable after the primitives moved to
+ * `commonStateTypes/filterPrimitives`. Downstream files (`taskList`,
+ * `remiListState`, `chargeCardPaymentHistory`, `billListState`) and the
+ * CES barrel still pull `CategoryCombinationOperator` / `FilterCategoryType`
+ * from this module — the source of truth is upstream but the surface is
+ * unchanged.
+ */
+export type { CategoryCombinationOperator, FilterCategoryType };
 export interface MatchingOperatorDropdownOption {
     label: 'is' | 'is not';
     value: 'equal' | 'not_equal';
 }
-export type CategoryCombinationOperator = 'AND' | 'OR';
 export interface BillPayFilterCategoryDropdownOption {
     value: BillListViewFilterCategoryField;
     multiple?: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.69-betaAR3",
+  "version": "5.0.69-betaAR5",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",