@zeniai/client-epic-state 5.0.55-betaSS1 → 5.0.55-betaVR1

package/lib/view/transactionDetail/journalEntryLinesViewModel.vitest.js

@@ -0,0 +1,245 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const vitest_1 = require("vitest");
+const journalEntryLinesViewModel_1 = require("./journalEntryLinesViewModel");
+const usd = (amount) => ({
+    amount,
+    currencyCode: 'USD',
+    currencySymbol: '$',
+});
+const debit = (n) => ({
+    amount: usd(n),
+    postingType: 'debit',
+});
+const credit = (n) => ({
+    amount: usd(n),
+    postingType: 'credit',
+});
+(0, vitest_1.describe)('sumJournalEntryAmounts', () => {
+    (0, vitest_1.it)('returns undefined for an empty list', () => {
+        (0, vitest_1.expect)((0, journalEntryLinesViewModel_1.sumJournalEntryAmounts)([])).toBeUndefined();
+    });
+    (0, vitest_1.it)('sums a single line as-is', () => {
+        (0, vitest_1.expect)((0, journalEntryLinesViewModel_1.sumJournalEntryAmounts)([{ amount: usd(42) }])).toEqual(usd(42));
+    });
+    (0, vitest_1.it)('sums multiple lines preserving the first line currency', () => {
+        const total = (0, journalEntryLinesViewModel_1.sumJournalEntryAmounts)([
+            { amount: usd(10) },
+            { amount: usd(20.5) },
+            { amount: usd(0.5) },
+        ]);
+        (0, vitest_1.expect)(total).toEqual(usd(31));
+    });
+    (0, vitest_1.it)('treats nullish amount.amount as 0 without crashing', () => {
+        const total = (0, journalEntryLinesViewModel_1.sumJournalEntryAmounts)([
+            { amount: usd(10) },
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            { amount: { currencyCode: 'USD', currencySymbol: '$' } },
+            { amount: usd(5) },
+        ]);
+        (0, vitest_1.expect)(total).toEqual(usd(15));
+    });
+    (0, vitest_1.it)('uses an empty currency code/symbol when first line lacks them', () => {
+        const total = (0, journalEntryLinesViewModel_1.sumJournalEntryAmounts)([
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            { amount: { amount: 7 } },
+            { amount: usd(3) },
+        ]);
+        (0, vitest_1.expect)(total).toEqual({ amount: 10, currencyCode: '', currencySymbol: '' });
+    });
+});
+(0, vitest_1.describe)('journalEntryTotalsByPostingSide', () => {
+    (0, vitest_1.it)('returns undefined totals for an empty list', () => {
+        (0, vitest_1.expect)((0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([])).toEqual({
+            debitTotal: undefined,
+            creditTotal: undefined,
+        });
+    });
+    (0, vitest_1.it)('sums debits and credits separately when both sides present', () => {
+        const { debitTotal, creditTotal } = (0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([
+            debit(100),
+            debit(50),
+            credit(120),
+            credit(30),
+        ]);
+        (0, vitest_1.expect)(debitTotal).toEqual(usd(150));
+        (0, vitest_1.expect)(creditTotal).toEqual(usd(150));
+    });
+    (0, vitest_1.it)('returns only the populated side when one side is missing', () => {
+        const onlyDebits = (0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([debit(10), debit(20)]);
+        (0, vitest_1.expect)(onlyDebits.debitTotal).toEqual(usd(30));
+        (0, vitest_1.expect)(onlyDebits.creditTotal).toBeUndefined();
+        const onlyCredits = (0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([credit(99)]);
+        (0, vitest_1.expect)(onlyCredits.creditTotal).toEqual(usd(99));
+        (0, vitest_1.expect)(onlyCredits.debitTotal).toBeUndefined();
+    });
+    /**
+     * Regression test for the operator-precedence bug in legacy
+     * `calculateCombinedTotalAmount` where
+     * `totalAmount?.amount ?? 0 + (uncategorized?.amount ?? 0) + (miscategorized?.amount ?? 0)`
+     * parses as `totalAmount?.amount ?? (0 + ... + ...)`. With the bug,
+     * an existing `totalAmount` would short-circuit and the uncat/miscat
+     * pieces would be ignored. The new implementation always adds every
+     * matching line, so 100 (cat) + 25 (uncat) + 10 (miscat) = 135.
+     */
+    (0, vitest_1.it)('does not drop uncategorized/miscategorized contributions (precedence-bug regression)', () => {
+        const { debitTotal } = (0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([
+            debit(100),
+            debit(25),
+            debit(10),
+        ]);
+        (0, vitest_1.expect)(debitTotal).toEqual(usd(135));
+    });
+    (0, vitest_1.it)('ignores lines with neither debit nor credit posting type', () => {
+        const totals = (0, journalEntryLinesViewModel_1.journalEntryTotalsByPostingSide)([
+            debit(40),
+            credit(40),
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            { amount: usd(999), postingType: 'unknown' },
+        ]);
+        (0, vitest_1.expect)(totals.debitTotal).toEqual(usd(40));
+        (0, vitest_1.expect)(totals.creditTotal).toEqual(usd(40));
+    });
+});
+(0, vitest_1.describe)('filterJournalEntryLinesExcludingLinked', () => {
+    (0, vitest_1.it)('returns [] for undefined input', () => {
+        (0, vitest_1.expect)((0, journalEntryLinesViewModel_1.filterJournalEntryLinesExcludingLinked)(undefined)).toEqual([]);
+    });
+    (0, vitest_1.it)('filters out linked_transaction_line entries', () => {
+        const lines = [
+            { id: 'a', type: 'journal_entry_transaction_line' },
+            { id: 'b', type: 'linked_transaction_line' },
+            { id: 'c', type: 'journal_entry_transaction_line' },
+        ];
+        const filtered = (0, journalEntryLinesViewModel_1.filterJournalEntryLinesExcludingLinked)(lines);
+        (0, vitest_1.expect)(filtered).toHaveLength(2);
+        (0, vitest_1.expect)(filtered[0].id).toBe('a');
+        (0, vitest_1.expect)(filtered[1].id).toBe('c');
+    });
+    (0, vitest_1.it)('returns input unchanged when no linked lines exist', () => {
+        const lines = [
+            { id: 'a', type: 'journal_entry_transaction_line' },
+            { id: 'b', type: 'journal_entry_transaction_line' },
+        ];
+        (0, vitest_1.expect)((0, journalEntryLinesViewModel_1.filterJournalEntryLinesExcludingLinked)(lines)).toHaveLength(2);
+    });
+});
+(0, vitest_1.describe)('sortJournalEntryLines', () => {
+    const accessors = {
+        description: (r) => r.description,
+        name: (r) => r.name,
+        category: (r) => r.category,
+        class: (r) => r.class,
+        debit: (r) => r.debit,
+        credit: (r) => r.credit,
+    };
+    const rows = [
+        {
+            id: '1',
+            description: 'Beta',
+            name: 'Acme',
+            category: 'Rent',
+            class: 'Ops',
+            debit: 100,
+            credit: 0,
+        },
+        {
+            id: '2',
+            description: 'alpha',
+            name: 'Beta Co',
+            category: 'Travel',
+            class: 'GA',
+            debit: 200,
+            credit: 0,
+        },
+        {
+            id: '3',
+            description: 'Gamma',
+            name: 'acme',
+            category: 'Rent',
+            class: 'Sales',
+            debit: 0,
+            credit: 50,
+        },
+    ];
+    (0, vitest_1.it)('exposes every supported sort key via JOURNAL_ENTRY_SORT_KEYS', () => {
+        (0, vitest_1.expect)([...journalEntryLinesViewModel_1.JOURNAL_ENTRY_SORT_KEYS]).toEqual([
+            'description',
+            'name',
+            'category',
+            'class',
+            'debit',
+            'credit',
+        ]);
+    });
+    (0, vitest_1.it)('sorts by description case-insensitively ascending by default', () => {
+        const sorted = (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(rows, journalEntryLinesViewModel_1.journalEntryDefaultSortConfig, accessors);
+        (0, vitest_1.expect)(sorted.map((r) => r.id)).toEqual(['2', '1', '3']);
+    });
+    (0, vitest_1.it)('sorts by description descending when configured', () => {
+        const config = {
+            sortKey: 'description',
+            sortOrder: 'descending',
+        };
+        const sorted = (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(rows, config, accessors);
+        (0, vitest_1.expect)(sorted.map((r) => r.id)).toEqual(['3', '1', '2']);
+    });
+    vitest_1.it.each([
+        ['name', 'ascending', ['1', '3', '2']],
+        ['name', 'descending', ['2', '1', '3']],
+        ['category', 'ascending', ['1', '3', '2']],
+        ['class', 'ascending', ['2', '1', '3']],
+        ['debit', 'ascending', ['3', '1', '2']],
+        ['debit', 'descending', ['2', '1', '3']],
+        ['credit', 'ascending', ['1', '2', '3']],
+        ['credit', 'descending', ['3', '1', '2']],
+    ])('sorts by %s %s producing the expected order', (key, order, expected) => {
+        const config = {
+            sortKey: key,
+            sortOrder: order,
+        };
+        const sorted = (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(rows, config, accessors);
+        (0, vitest_1.expect)(sorted.map((r) => r.id)).toEqual([...expected]);
+    });
+    (0, vitest_1.it)('keeps stable order for ties on the sort key', () => {
+        const tied = [
+            {
+                id: 'a',
+                description: 'same',
+                name: '',
+                category: '',
+                class: '',
+                debit: 0,
+                credit: 0,
+            },
+            {
+                id: 'b',
+                description: 'same',
+                name: '',
+                category: '',
+                class: '',
+                debit: 0,
+                credit: 0,
+            },
+            {
+                id: 'c',
+                description: 'same',
+                name: '',
+                category: '',
+                class: '',
+                debit: 0,
+                credit: 0,
+            },
+        ];
+        const sortedAsc = (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(tied, { sortKey: 'description', sortOrder: 'ascending' }, accessors);
+        (0, vitest_1.expect)(sortedAsc.map((r) => r.id)).toEqual(['a', 'b', 'c']);
+        const sortedDesc = (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(tied, { sortKey: 'description', sortOrder: 'descending' }, accessors);
+        (0, vitest_1.expect)(sortedDesc.map((r) => r.id)).toEqual(['a', 'b', 'c']);
+    });
+    (0, vitest_1.it)('does not mutate the input array', () => {
+        const input = [...rows];
+        const before = input.map((r) => r.id);
+        (0, journalEntryLinesViewModel_1.sortJournalEntryLines)(input, { sortKey: 'description', sortOrder: 'descending' }, accessors);
+        (0, vitest_1.expect)(input.map((r) => r.id)).toEqual(before);
+    });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.55-betaSS1",
+  "version": "5.0.55-betaVR1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",
@@ -111,7 +111,7 @@
     "find-dead-code": "ts-prune | grep -v '(used in module)'",
     "find-unused-exports": "ts-unused-exports ./tsconfig.json",
     "circular-dependency": "npx madge --circular --extensions ts ./src",
-    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\" \"echo 'Running tests and typecheck...' && pnpm test\" && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
+    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\"",
     "only-build": "eslint . --ext .js,.jsx,.ts,.tsx && time tsc && tsc -p tsconfig.esm.json && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "only-build-dev": "eslint . --ext .js,.jsx,.ts,.tsx && time tsc -p tsconfig.dev.json && tsc -p tsconfig.esm.dev.json && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "format": "prettier --write --ignore-unknown \"src/**/*\" && pnpm lint",

package/lib/esm/view/expenseAutomationView/types/completedSubTab.js

@@ -1,9 +0,0 @@
-import { stringToUnion } from '../../../commonStateTypes/stringToUnion';
-/**
- * Sub-tabs that can appear under any "Completed" tab in the Expense Automation
- * surface (Transaction Categorization Completed and Missing Receipts Completed
- * both use this exact union). Forwarded verbatim to listing APIs as `sub_tab`
- * / `match_type`. `'all'` preserves parent-tab semantics on the backend.
- */
-const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
-export const toCompletedSubTab = (v) => stringToUnion(v.trim().toLowerCase(), COMPLETED_SUB_TABS);

package/lib/view/expenseAutomationView/types/completedSubTab.d.ts

@@ -1,2 +0,0 @@
-export declare const toCompletedSubTab: (v: string) => "all" | "manual" | "ai_accountant";
-export type CompletedSubTab = ReturnType<typeof toCompletedSubTab>;

package/lib/view/expenseAutomationView/types/completedSubTab.js

@@ -1,13 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.toCompletedSubTab = void 0;
-const stringToUnion_1 = require("../../../commonStateTypes/stringToUnion");
-/**
- * Sub-tabs that can appear under any "Completed" tab in the Expense Automation
- * surface (Transaction Categorization Completed and Missing Receipts Completed
- * both use this exact union). Forwarded verbatim to listing APIs as `sub_tab`
- * / `match_type`. `'all'` preserves parent-tab semantics on the backend.
- */
-const COMPLETED_SUB_TABS = ['all', 'ai_accountant', 'manual'];
-const toCompletedSubTab = (v) => (0, stringToUnion_1.stringToUnion)(v.trim().toLowerCase(), COMPLETED_SUB_TABS);
-exports.toCompletedSubTab = toCompletedSubTab;