@zeniai/client-epic-state 5.0.53-betaML4 → 5.0.54

package/lib/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -8,7 +8,6 @@ exports.uploadTransactionCategorizationReceiptSuccess = exports.updateTransactio
 const toolkit_1 = require("@reduxjs/toolkit");
 const get_1 = __importDefault(require("lodash/get"));
 const uniq_1 = __importDefault(require("lodash/uniq"));
-const recommendationReducer_1 = require("../../recommendation/recommendationReducer");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const vendorTransaction_1 = require("../../../entity/transaction/stateTypes/vendorTransaction");
 const transactionCategorizationLocalDataHelper_1 = require("../helpers/transactionCategorizationLocalDataHelper");
@@ -404,53 +403,10 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                 const transactionLocalData = (0, get_1.default)(draft.transactionCategorizationView[selectedTab]
                     .transactionReviewLocalDataById, transactionId.id, undefined);
                 if (transactionLocalData != null) {
-                    // Snapshot the pre-fetch selection. setEntityRecommendationForLineIdInLocalData
-                    // mutates selectedCheckBoxTransactionIds internally (auto-add when
-                    // all-filled, auto-remove otherwise) but does not enforce
-                    // MAX_SELECTION_LIMIT. We restore from this snapshot below and let
-                    // the reducer-level gate own the selection contract so the cap is
-                    // honored and the gate mirrors the original auto-add gate from
-                    // updateSelectedVendor/CustomerForTransaction.
-                    const selectionBeforeFetch = [
-                        ...draft.transactionCategorizationView[selectedTab]
-                            .selectedCheckBoxTransactionIds,
-                    ];
-                    const newLocalData = (0, transactionCategorizationLocalDataHelper_1.setEntityRecommendationForLineIdInLocalData)(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled);
-                    // Flip the per-line "fetching" flag to Completed for the lines this
-                    // fetch covered. Reads as the success arm of the
-                    // fetchEntityRecommendationsForCategorization → epic → reducer cycle.
-                    lineIds.forEach((lineId) => {
-                        const lineItem = newLocalData.lineItemById[lineId];
-                        if (lineItem != null) {
-                            newLocalData.lineItemById[lineId] = {
-                                ...lineItem,
-                                categoryClassRecommendationsFetchState: {
-                                    fetchState: 'Completed',
-                                    error: undefined,
-                                },
-                            };
-                        }
-                    });
                     draft.transactionCategorizationView[selectedTab].transactionReviewLocalDataById[transaction.id] = {
                         transactionId: transaction.id,
-                        transactionReviewLocalData: newLocalData,
+                        transactionReviewLocalData: (0, transactionCategorizationLocalDataHelper_1.setEntityRecommendationForLineIdInLocalData)(draft.transactionCategorizationView[selectedTab], transaction, transactionLocalData.transactionReviewLocalData, entity, lineIds, uncategorizedAccounts, action.payload.recommendationWithCOTByLineId, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled),
                     };
-                    // Auto-add the transaction to the bulk-save selection now that
-                    // fresh recs have landed and all required fields are filled. This
-                    // is the success-arm of the deferral noted in
-                    // updateSelectedVendor/CustomerForTransaction: their auto-add was
-                    // suppressed because pre-fetch category/class were stale; we run
-                    // the same gate here against newLocalData so the checkbox flips
-                    // on against fresh recs.
-                    draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = selectionBeforeFetch;
-                    if ((0, transactionCategorizationLocalDataHelper_1.checkIfAllLineItemsAreCategoryClassFilled)(transaction, newLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true &&
-                        selectionBeforeFetch.length < transactionCategorizationLocalDataHelper_1.MAX_SELECTION_LIMIT &&
-                        selectionBeforeFetch.includes(transaction.id) === false) {
-                        draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
-                            ...selectionBeforeFetch,
-                            transaction.id,
-                        ];
-                    }
                     // Mark transaction as dirty (autofill happened)
                     if (!draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData.includes(transaction.id)) {
                         draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData = [
@@ -504,13 +460,7 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                 action.payload.status;
         },
         updateSelectedCustomerForTransaction(draft, action) {
-            const { transactionId, lineId, updatedCustomer, selectedTransaction, selectedTab,
-            // uncategorizedAccounts, isAccountingClassesEnabled, and
-            // isUncategorizedExpenseCategoryEnabled remain in the payload type for
-            // backward compatibility but are no longer read here — the post-fetch
-            // success reducer (setEntityRecommendationForLineIdsForCategorization)
-            // owns the all-fields-filled check that drives auto-selection.
-             } = action.payload;
+            const { transactionId, lineId, updatedCustomer, selectedTransaction, selectedTab, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
             const transactionLocalData = (0, get_1.default)(draft.transactionCategorizationView[selectedTab]
                 .transactionReviewLocalDataById, transactionId, undefined);
             if (transactionLocalData != null) {
@@ -559,13 +509,18 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                     transactionReviewLocalData: newTransactionLocalData,
                     transactionId,
                 };
-                // Auto-selection of the row checkbox is intentionally deferred to
-                // setEntityRecommendationForLineIdsForCategorization (success path of
-                // the recommendations fetch). On a payee change the existing
-                // category/class are stale, so auto-selecting against them would
-                // either trigger save flows on the wrong data or rely on a later
-                // recommendations write to fix it. Letting the success reducer do the
-                // auto-add keeps "checkbox flips on" aligned with "fresh recs are in".
+                const selectedCheckBoxTransactionIds = draft.transactionCategorizationView[selectedTab]
+                    .selectedCheckBoxTransactionIds;
+                if (newTransactionLocalData.customer != null &&
+                    newTransactionLocalData.customer.id != null &&
+                    (0, transactionCategorizationLocalDataHelper_1.checkIfAllLineItemsAreCategoryClassFilled)(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
+                    selectedCheckBoxTransactionIds.length < transactionCategorizationLocalDataHelper_1.MAX_SELECTION_LIMIT &&
+                    selectedCheckBoxTransactionIds.includes(transactionId) === false) {
+                    draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
+                        ...selectedCheckBoxTransactionIds,
+                        transactionId,
+                    ];
+                }
                 // Mark transaction as dirty (customer updated)
                 if (!draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData.includes(transactionId)) {
                     draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData = [
@@ -577,11 +532,7 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
             }
         },
         updateSelectedVendorForTransaction(draft, action) {
-            const { transactionId, lineId, updatedVendor, selectedTransaction, selectedTab,
-            // See updateSelectedCustomerForTransaction for why
-            // uncategorizedAccounts, isAccountingClassesEnabled, and
-            // isUncategorizedExpenseCategoryEnabled are no longer destructured.
-             } = action.payload;
+            const { transactionId, lineId, updatedVendor, selectedTransaction, selectedTab, uncategorizedAccounts, isAccountingClassesEnabled, isUncategorizedExpenseCategoryEnabled, } = action.payload;
             const transactionLocalData = (0, get_1.default)(draft.transactionCategorizationView[selectedTab]
                 .transactionReviewLocalDataById, transactionId, undefined);
             if (transactionLocalData != null) {
@@ -634,8 +585,18 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
                     },
                     transactionId,
                 };
-                // See updateSelectedCustomerForTransaction above for why auto-select
-                // is deferred to setEntityRecommendationForLineIdsForCategorization.
+                const selectedCheckBoxTransactionIds = draft.transactionCategorizationView[selectedTab]
+                    .selectedCheckBoxTransactionIds;
+                if (newTransactionLocalData.vendor != null &&
+                    newTransactionLocalData.vendor.id != null &&
+                    (0, transactionCategorizationLocalDataHelper_1.checkIfAllLineItemsAreCategoryClassFilled)(selectedTransaction, newTransactionLocalData, uncategorizedAccounts, isUncategorizedExpenseCategoryEnabled, isAccountingClassesEnabled) === true && // check if all line items are filled
+                    selectedCheckBoxTransactionIds.length < transactionCategorizationLocalDataHelper_1.MAX_SELECTION_LIMIT &&
+                    selectedCheckBoxTransactionIds.includes(transactionId) === false) {
+                    draft.transactionCategorizationView[selectedTab].selectedCheckBoxTransactionIds = [
+                        ...selectedCheckBoxTransactionIds,
+                        transactionId,
+                    ];
+                }
                 // Mark transaction as dirty (vendor updated)
                 if (!draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData.includes(transactionId)) {
                     draft.transactionCategorizationView[selectedTab].transactionIdsWithUnsavedData = [
@@ -848,54 +809,6 @@ const expenseAutomationTransactionsView = (0, toolkit_1.createSlice)({
             },
         },
     },
-    extraReducers: (builder) => {
-        // Start arm of the categorization-only recommendations fetch. Marks every
-        // affected line's per-line flag as In-Progress. The epic uses
-        // groupBy(transactionId+lineIds) + switchMap, so concurrent fetches for
-        // distinct (transaction, lineIds-set) targets do not cancel each other —
-        // there's no need for a global cleanup sweep here.
-        builder.addCase(recommendationReducer_1.fetchEntityRecommendationsForCategorization, (draft, action) => {
-            const { selectedTab, transactionDetails } = action.payload;
-            const { transactionId, lineIds } = transactionDetails;
-            const transactionLocalData = (0, get_1.default)(draft.transactionCategorizationView[selectedTab]
-                .transactionReviewLocalDataById, transactionId.id, undefined);
-            if (transactionLocalData != null) {
-                lineIds.forEach((lineId) => {
-                    const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
-                    if (lineItem != null) {
-                        transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
-                            ...lineItem,
-                            categoryClassRecommendationsFetchState: {
-                                fetchState: 'In-Progress',
-                                error: undefined,
-                            },
-                        };
-                    }
-                });
-            }
-        });
-        // Failure arm. Flips the affected lines' per-line flag to Error so the
-        // skeleton resolves and the queued checkbox re-evaluation drops the entry.
-        builder.addCase(recommendationReducer_1.setCategoryClassRecommendationsForCategorizationFailure, (draft, action) => {
-            const { selectedTab, transactionId, lineIds, error } = action.payload;
-            const transactionLocalData = (0, get_1.default)(draft.transactionCategorizationView[selectedTab]
-                .transactionReviewLocalDataById, transactionId.id, undefined);
-            if (transactionLocalData != null) {
-                lineIds.forEach((lineId) => {
-                    const lineItem = transactionLocalData.transactionReviewLocalData.lineItemById[lineId];
-                    if (lineItem != null) {
-                        transactionLocalData.transactionReviewLocalData.lineItemById[lineId] = {
-                            ...lineItem,
-                            categoryClassRecommendationsFetchState: {
-                                fetchState: 'Error',
-                                error,
-                            },
-                        };
-                    }
-                });
-            }
-        });
-    },
 });
 _a = expenseAutomationTransactionsView.actions, exports.fetchTransactionCategorization = _a.fetchTransactionCategorization, exports.updateTransactionCategorizationUIState = _a.updateTransactionCategorizationUIState, exports.initializeTransactionCategorizationViewLocalData = _a.initializeTransactionCategorizationViewLocalData, exports.saveTransactionCategorizationLocalData = _a.saveTransactionCategorizationLocalData, exports.fetchTransactionCategorizationFailure = _a.fetchTransactionCategorizationFailure, exports.saveTransactionCategorization = _a.saveTransactionCategorization, exports.updateTransactionCategorization = _a.updateTransactionCategorization, exports.updateCurrentSelectedTransactionCategorizationTab = _a.updateCurrentSelectedTransactionCategorizationTab, exports.updateTransactionCategorizationSaveStatus = _a.updateTransactionCategorizationSaveStatus, exports.markTransactionAsNotMiscategorized = _a.markTransactionAsNotMiscategorized, exports.updateStatusForTransactionNotMiscategorizedUpdateForCategorization = _a.updateStatusForTransactionNotMiscategorizedUpdateForCategorization, exports.updateSelectedVendorForTransaction = _a.updateSelectedVendorForTransaction, exports.updateSelectedCustomerForTransaction = _a.updateSelectedCustomerForTransaction, exports.setAllItemsToCategoryClassInLocalDataForCategorization = _a.setAllItemsToCategoryClassInLocalDataForCategorization, exports.updateTotalCountForTransactionCategorization = _a.updateTotalCountForTransactionCategorization, exports.fetchTransactionCategorizationSuccess = _a.fetchTransactionCategorizationSuccess, exports.resetOtherTabsFetchState = _a.resetOtherTabsFetchState, exports.fetchTransactionCategorizationView = _a.fetchTransactionCategorizationView, exports.updateSelectedCheckboxTransactionIds = _a.updateSelectedCheckboxTransactionIds, exports.clearExpenseAutomationTransactionsViewPerTabView = _a.clearExpenseAutomationTransactionsViewPerTabView, exports.clearExpenseAutomationTransactionsView = _a.clearExpenseAutomationTransactionsView, exports.setEntityRecommendationForLineIdsForCategorization = _a.setEntityRecommendationForLineIdsForCategorization, exports.updateSelectedTransactionId = _a.updateSelectedTransactionId, exports.syncTransactionCategorizationFromDetailSave = _a.syncTransactionCategorizationFromDetailSave, exports.backgroundRefetchReviewTab = _a.backgroundRefetchReviewTab, exports.updateTransactionCategorizationUploadReceiptState = _a.updateTransactionCategorizationUploadReceiptState, exports.uploadTransactionCategorizationReceiptSuccess = _a.uploadTransactionCategorizationReceiptSuccess;
 exports.default = expenseAutomationTransactionsView.reducer;

package/lib/view/expenseAutomationView/selectorTypes/transactionsViewSelectorTypes.d.ts

@@ -19,7 +19,6 @@ export interface ExpenseAutomationTransactionViewSelector extends SelectorView {
     classList: ClassBase[];
     completionStatus: CompletionStatusType;
     fetchStateByTransactionTabs: Record<TransactionsTab, FetchStateAndError>;
-    hasInFlightCategoryClassRecommendations: boolean;
     isAccountingProjectsEnabled: boolean;
     markAsNotMiscategorizedStatus: FetchStateAndError;
     projectList: ProjectListSelectorView;

package/lib/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -48,11 +48,6 @@ function getExpenseAutomationTransactionView(state) {
         return null;
     })
         .filter((transaction) => transaction != null);
-    // True if any visible line is currently fetching category/class
-    // recommendations because the user changed the payee. Used to disable Save
-    // and to defer manual checkbox selection.
-    const hasInFlightCategoryClassRecommendations = transactionLocalData.some((transaction) => Object.values(transaction.transactionReviewLocalData.lineItemById).some((lineItem) => lineItem.categoryClassRecommendationsFetchState?.fetchState ===
-        'In-Progress'));
     const transactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, transactionIds);
     const transactionsWithCOT = transactions.map((transaction) => (0, transactionHelper_1.getTransactionWithCOT)(transaction));
     const monthEndFetchState = monthYearPeriodId != null
@@ -123,6 +118,5 @@ function getExpenseAutomationTransactionView(state) {
         uploadReceiptStatusById,
         selectedTransactionId,
         selectedTransactionLineId,
-        hasInFlightCategoryClassRecommendations,
     };
 }

package/lib/view/expenseAutomationView/types/transactionsViewState.d.ts

@@ -46,7 +46,6 @@ export interface TransactionCategorizationLineItemData extends TransactionLineBa
     transactionId: ID;
     account?: AccountBase;
     categorizationStatus?: CategorizationStatusType;
-    categoryClassRecommendationsFetchState?: FetchStateAndError;
     class?: ClassBase;
     customer?: CustomerBase;
     item?: ProductOrService;

package/lib/view/recommendation/recommendationReducer.d.ts

@@ -22,27 +22,7 @@ export declare const fetchEntityRecommendationsByTransactionId: import("@reduxjs
     isTransactionCategorizationFlow: any;
     isFetchCOT: any;
     isUncategorizedExpenseCategoryEnabled: boolean | undefined;
-}, "recommendation/fetchEntityRecommendationsByTransactionId", never, never>, fetchEntityRecommendationsForCategorization: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entity: Entity, amount: number, transactionDetails: {
-    lineIds: ID[];
-    transaction: SupportedTransaction;
-    transactionId: TransactionID;
-}, selectedTab: "review" | "autoCategorized", isFetchCOT?: any, isUncategorizedExpenseCategoryEnabled?: boolean | undefined], {
-    entity: Entity;
-    amount: number;
-    transactionDetails: {
-        lineIds: ID[];
-        transaction: SupportedTransaction;
-        transactionId: TransactionID;
-    };
-    selectedTab: "review" | "autoCategorized";
-    isFetchCOT: any;
-    isUncategorizedExpenseCategoryEnabled: boolean | undefined;
-}, "recommendation/fetchEntityRecommendationsForCategorization", never, never>, setCategoryClassRecommendationsForCategorizationFailure: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[selectedTab: "review" | "autoCategorized", transactionId: TransactionID, lineIds: string[], error: ZeniAPIStatus<Record<string, unknown>>], {
-    selectedTab: "review" | "autoCategorized";
-    transactionId: TransactionID;
-    lineIds: string[];
-    error: ZeniAPIStatus<Record<string, unknown>>;
-}, "recommendation/setCategoryClassRecommendationsForCategorizationFailure", never, never>, fetchRecommendationByEntityName: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityName: string, entityType: EntityType], {
+}, "recommendation/fetchEntityRecommendationsByTransactionId", never, never>, fetchRecommendationByEntityName: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityName: string, entityType: EntityType], {
     entityName: string;
     entityType: EntityType;
 }, "recommendation/fetchRecommendationByEntityName", never, never>, fetchRecommendationByEntityId: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[entityId: string, entityType: EntityType], {

package/lib/view/recommendation/recommendationReducer.js

@@ -1,7 +1,7 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.clearRecommendation = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.setCategoryClassRecommendationsForCategorizationFailure = exports.fetchEntityRecommendationsForCategorization = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
+exports.clearRecommendation = exports.indicateReadyToInitializeRecommendation = exports.updateRecommendationForEntityFailure = exports.updateRecommendationForEntity = exports.fetchRecommendationByEntityId = exports.fetchRecommendationByEntityName = exports.fetchEntityRecommendationsByTransactionId = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const recommendationState_1 = require("./recommendationState");
 exports.initialState = {
@@ -110,63 +110,12 @@ const recommendation = (0, toolkit_1.createSlice)({
                 };
             },
         },
-        // Categorization-list-only fetch action. Mirrors the
-        // fetchEntityRecommendationsByTransactionId payload but is observed by a
-        // separate epic (with groupBy + switchMap, keyed on
-        // transactionId+lineIds-set) so concurrent fetches for distinct targets do
-        // not cancel each other. Reducer hooks in transactionsViewReducer use this
-        // to drive the per-line categoryClassRecommendationsFetchState flag.
-        fetchEntityRecommendationsForCategorization: {
-            reducer(draft, action) {
-                const { entity } = action.payload;
-                const key = (0, recommendationState_1.getEntityRecommendationKey)(entity.type, entity.id);
-                const existingRecommendation = draft.recommendationByEntity[key];
-                if (existingRecommendation == null) {
-                    draft.recommendationByEntity[key] = {
-                        ...recommendationState_1.initialEntityRecommendationState,
-                        fetchState: 'In-Progress',
-                    };
-                }
-            },
-            prepare(entity, amount, transactionDetails, selectedTab, isFetchCOT = false, isUncategorizedExpenseCategoryEnabled) {
-                return {
-                    payload: {
-                        entity,
-                        amount,
-                        transactionDetails,
-                        selectedTab,
-                        isFetchCOT,
-                        isUncategorizedExpenseCategoryEnabled,
-                    },
-                };
-            },
-        },
-        setCategoryClassRecommendationsForCategorizationFailure: {
-            reducer(
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
-            _draft, 
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
-            _action) {
-                // The transactionsViewReducer handles the per-line flag flip; this
-                // reducer slice has no recommendation cache to update for the failure.
-            },
-            prepare(selectedTab, transactionId, lineIds, error) {
-                return {
-                    payload: {
-                        selectedTab,
-                        transactionId,
-                        lineIds,
-                        error,
-                    },
-                };
-            },
-        },
         clearRecommendation(draft) {
             Object.assign(draft, exports.initialState);
         },
     },
 });
-_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchEntityRecommendationsForCategorization = _a.fetchEntityRecommendationsForCategorization, exports.setCategoryClassRecommendationsForCategorizationFailure = _a.setCategoryClassRecommendationsForCategorizationFailure, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.clearRecommendation = _a.clearRecommendation;
+_a = recommendation.actions, exports.fetchEntityRecommendationsByTransactionId = _a.fetchEntityRecommendationsByTransactionId, exports.fetchRecommendationByEntityName = _a.fetchRecommendationByEntityName, exports.fetchRecommendationByEntityId = _a.fetchRecommendationByEntityId, exports.updateRecommendationForEntity = _a.updateRecommendationForEntity, exports.updateRecommendationForEntityFailure = _a.updateRecommendationForEntityFailure, exports.indicateReadyToInitializeRecommendation = _a.indicateReadyToInitializeRecommendation, exports.clearRecommendation = _a.clearRecommendation;
 exports.default = recommendation.reducer;
 const doUpdateRecommendationForEntity = (draft, entityId, entityType, payload) => {
     const key = (0, recommendationState_1.getEntityRecommendationKey)(entityType, entityId);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.53-betaML4",
+  "version": "5.0.54",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/esm/view/recommendation/fetchEntityRecommendationsForCategorizationEpic.js

@@ -1,83 +0,0 @@
-import { from, of } from 'rxjs';
-import { catchError, filter, groupBy, mergeMap, switchMap } from 'rxjs/operators';
-import { getIsAccountingClassesEnabled } from '../../entity/tenant/tenantSelector';
-import { getTransactionWithCOT, getTransactionWithCOTFromRecommendations, } from '../../entity/transaction/transactionHelper';
-import { createZeniAPIStatus, isSuccessResponse } from '../../responsePayload';
-import { setEntityRecommendationForLineIdsForCategorization } from '../../view/expenseAutomationView/reducers/transactionsViewReducer';
-import { getUncategorizedAccounts } from '../accountList/accountListSelector';
-import { getActualTransactionID } from '../transactionDetail/transactionDetailState';
-import { getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT, getRecommendationFromRecommendationPayload, } from './recommendationHelper';
-import { fetchEntityRecommendationsForCategorization, setCategoryClassRecommendationsForCategorizationFailure, updateRecommendationForEntity, } from './recommendationReducer';
-// Categorization-list-only recommendations fetch.
-//
-// Concurrency model: groupBy on (transactionId.id, sorted lineIds) → switchMap
-// inside each group → mergeMap to flatten groups. This means:
-//   • Same target (same transaction + same lineIds-set) — newer fetch cancels
-//     the prior in-flight fetch. Avoids the same-line stale-response race.
-//   • Different targets — run fully in parallel. Avoids the silent
-//     "stuck spinner" cancellation that the global-switchMap epic suffers
-//     from when the user moves between rows or JE lines mid-flight.
-//
-// The transactionsViewReducer's per-line categoryClassRecommendationsFetchState
-// flag is set to In-Progress when the action enters this epic (start arm in
-// extraReducers), Completed via setEntityRecommendationForLineIdsForCategorization,
-// or Error via setCategoryClassRecommendationsForCategorizationFailure.
-export const fetchEntityRecommendationsForCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchEntityRecommendationsForCategorization.match), groupBy((action) => {
-    const { transactionId, lineIds } = action.payload.transactionDetails;
-    return `${transactionId.id}|${[...lineIds].sort().join('|')}`;
-}), mergeMap((group$) => group$.pipe(switchMap((action) => {
-    const { entity, amount, transactionDetails, isFetchCOT, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
-    const query = {
-        amount,
-        transaction_id: getActualTransactionID(transactionDetails.transactionId.id),
-        transaction_type: transactionDetails.transaction.type,
-        line_ids: transactionDetails.lineIds,
-    };
-    if (isFetchCOT === true) {
-        query.include_cot = true;
-    }
-    const entityQuery = {
-        entity_name: entity.name,
-        entity_type: entity.type,
-    };
-    const recommendationUrl = entity.qboId === entity.name // entity id null case
-        ? `${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/recommendations?query=${encodeURIComponent(JSON.stringify(entityQuery))}`
-        : `${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/${toEntityTypeURL(entity.type)}/${entity.qboId}/recommendations?query=${encodeURIComponent(JSON.stringify(query))}`;
-    return zeniAPI
-        .getJSON(recommendationUrl)
-        .pipe(mergeMap((response) => {
-        if (isSuccessResponse(response) && response.data != null) {
-            const actions = [];
-            const { transactionId, transaction, lineIds } = transactionDetails;
-            const recommendationWithCOTByLineId = getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT(response.data.recommendations, lineIds);
-            const recommendations = getRecommendationFromRecommendationPayload(response.data.recommendations);
-            const transactionWithCOT = isFetchCOT === true &&
-                recommendationWithCOTByLineId != null
-                ? getTransactionWithCOTFromRecommendations(transaction, recommendationWithCOTByLineId)
-                : getTransactionWithCOT(transaction);
-            actions.push(updateRecommendationForEntity({
-                entityId: entity.id,
-                entityType: entity.type,
-                recommendations,
-            }));
-            if (recommendationWithCOTByLineId != null) {
-                const uncategorizedIncomeExpense = getUncategorizedAccounts(state$.value.accountState, state$.value.accountListState, 'accountList');
-                actions.push(setEntityRecommendationForLineIdsForCategorization(selectedTab, transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, getIsAccountingClassesEnabled(state$.value)));
-            }
-            else {
-                // Successful HTTP but no per-line recommendations — still
-                // need to clear the In-Progress flag, otherwise the
-                // skeleton sticks. Treat as a "no recommendations" success
-                // by firing the failure action with a benign error so the
-                // line flag flips out of In-Progress.
-                actions.push(setCategoryClassRecommendationsForCategorizationFailure(selectedTab, transactionId, lineIds, createZeniAPIStatus('Unexpected Error', 'Recommendations response missing per-line data')));
-            }
-            return from(actions);
-        }
-        else {
-            return of(setCategoryClassRecommendationsForCategorizationFailure(selectedTab, transactionDetails.transactionId, transactionDetails.lineIds, response.status));
-        }
-    }), catchError((error) => of(setCategoryClassRecommendationsForCategorizationFailure(selectedTab, transactionDetails.transactionId, transactionDetails.lineIds, createZeniAPIStatus('Unexpected Error', 'Fetch recommendations for categorization REST API call errored out' +
-        JSON.stringify(error))))));
-}))));
-const toEntityTypeURL = (entityType) => `${entityType}s`;

package/lib/view/recommendation/fetchEntityRecommendationsForCategorizationEpic.d.ts

@@ -1,8 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { RootState } from '../../reducer';
-import { setEntityRecommendationForLineIdsForCategorization } from '../../view/expenseAutomationView/reducers/transactionsViewReducer';
-import { ZeniAPI } from '../../zeniAPI';
-import { fetchEntityRecommendationsForCategorization, setCategoryClassRecommendationsForCategorizationFailure, updateRecommendationForEntity } from './recommendationReducer';
-export type ActionType = ReturnType<typeof updateRecommendationForEntity> | ReturnType<typeof fetchEntityRecommendationsForCategorization> | ReturnType<typeof setCategoryClassRecommendationsForCategorizationFailure> | ReturnType<typeof setEntityRecommendationForLineIdsForCategorization>;
-export declare const fetchEntityRecommendationsForCategorizationEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/recommendation/fetchEntityRecommendationsForCategorizationEpic.js

@@ -1,87 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchEntityRecommendationsForCategorizationEpic = void 0;
-const rxjs_1 = require("rxjs");
-const operators_1 = require("rxjs/operators");
-const tenantSelector_1 = require("../../entity/tenant/tenantSelector");
-const transactionHelper_1 = require("../../entity/transaction/transactionHelper");
-const responsePayload_1 = require("../../responsePayload");
-const transactionsViewReducer_1 = require("../../view/expenseAutomationView/reducers/transactionsViewReducer");
-const accountListSelector_1 = require("../accountList/accountListSelector");
-const transactionDetailState_1 = require("../transactionDetail/transactionDetailState");
-const recommendationHelper_1 = require("./recommendationHelper");
-const recommendationReducer_1 = require("./recommendationReducer");
-// Categorization-list-only recommendations fetch.
-//
-// Concurrency model: groupBy on (transactionId.id, sorted lineIds) → switchMap
-// inside each group → mergeMap to flatten groups. This means:
-//   • Same target (same transaction + same lineIds-set) — newer fetch cancels
-//     the prior in-flight fetch. Avoids the same-line stale-response race.
-//   • Different targets — run fully in parallel. Avoids the silent
-//     "stuck spinner" cancellation that the global-switchMap epic suffers
-//     from when the user moves between rows or JE lines mid-flight.
-//
-// The transactionsViewReducer's per-line categoryClassRecommendationsFetchState
-// flag is set to In-Progress when the action enters this epic (start arm in
-// extraReducers), Completed via setEntityRecommendationForLineIdsForCategorization,
-// or Error via setCategoryClassRecommendationsForCategorizationFailure.
-const fetchEntityRecommendationsForCategorizationEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(recommendationReducer_1.fetchEntityRecommendationsForCategorization.match), (0, operators_1.groupBy)((action) => {
-    const { transactionId, lineIds } = action.payload.transactionDetails;
-    return `${transactionId.id}|${[...lineIds].sort().join('|')}`;
-}), (0, operators_1.mergeMap)((group$) => group$.pipe((0, operators_1.switchMap)((action) => {
-    const { entity, amount, transactionDetails, isFetchCOT, selectedTab, isUncategorizedExpenseCategoryEnabled, } = action.payload;
-    const query = {
-        amount,
-        transaction_id: (0, transactionDetailState_1.getActualTransactionID)(transactionDetails.transactionId.id),
-        transaction_type: transactionDetails.transaction.type,
-        line_ids: transactionDetails.lineIds,
-    };
-    if (isFetchCOT === true) {
-        query.include_cot = true;
-    }
-    const entityQuery = {
-        entity_name: entity.name,
-        entity_type: entity.type,
-    };
-    const recommendationUrl = entity.qboId === entity.name // entity id null case
-        ? `${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/recommendations?query=${encodeURIComponent(JSON.stringify(entityQuery))}`
-        : `${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/${toEntityTypeURL(entity.type)}/${entity.qboId}/recommendations?query=${encodeURIComponent(JSON.stringify(query))}`;
-    return zeniAPI
-        .getJSON(recommendationUrl)
-        .pipe((0, operators_1.mergeMap)((response) => {
-        if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
-            const actions = [];
-            const { transactionId, transaction, lineIds } = transactionDetails;
-            const recommendationWithCOTByLineId = (0, recommendationHelper_1.getRecommendationByLineIdWithCOTFromRecommendationPayloadWithCOT)(response.data.recommendations, lineIds);
-            const recommendations = (0, recommendationHelper_1.getRecommendationFromRecommendationPayload)(response.data.recommendations);
-            const transactionWithCOT = isFetchCOT === true &&
-                recommendationWithCOTByLineId != null
-                ? (0, transactionHelper_1.getTransactionWithCOTFromRecommendations)(transaction, recommendationWithCOTByLineId)
-                : (0, transactionHelper_1.getTransactionWithCOT)(transaction);
-            actions.push((0, recommendationReducer_1.updateRecommendationForEntity)({
-                entityId: entity.id,
-                entityType: entity.type,
-                recommendations,
-            }));
-            if (recommendationWithCOTByLineId != null) {
-                const uncategorizedIncomeExpense = (0, accountListSelector_1.getUncategorizedAccounts)(state$.value.accountState, state$.value.accountListState, 'accountList');
-                actions.push((0, transactionsViewReducer_1.setEntityRecommendationForLineIdsForCategorization)(selectedTab, transactionId, transactionWithCOT, lineIds, entity, amount, recommendationWithCOTByLineId, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, (0, tenantSelector_1.getIsAccountingClassesEnabled)(state$.value)));
-            }
-            else {
-                // Successful HTTP but no per-line recommendations — still
-                // need to clear the In-Progress flag, otherwise the
-                // skeleton sticks. Treat as a "no recommendations" success
-                // by firing the failure action with a benign error so the
-                // line flag flips out of In-Progress.
-                actions.push((0, recommendationReducer_1.setCategoryClassRecommendationsForCategorizationFailure)(selectedTab, transactionId, lineIds, (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Recommendations response missing per-line data')));
-            }
-            return (0, rxjs_1.from)(actions);
-        }
-        else {
-            return (0, rxjs_1.of)((0, recommendationReducer_1.setCategoryClassRecommendationsForCategorizationFailure)(selectedTab, transactionDetails.transactionId, transactionDetails.lineIds, response.status));
-        }
-    }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, recommendationReducer_1.setCategoryClassRecommendationsForCategorizationFailure)(selectedTab, transactionDetails.transactionId, transactionDetails.lineIds, (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Fetch recommendations for categorization REST API call errored out' +
-        JSON.stringify(error))))));
-}))));
-exports.fetchEntityRecommendationsForCategorizationEpic = fetchEntityRecommendationsForCategorizationEpic;
-const toEntityTypeURL = (entityType) => `${entityType}s`;