@zeniai/client-epic-state 5.0.12-betaVR1 → 5.0.12

package/lib/view/expenseAutomationView/epics/missingReceipts/fetchCompletedTransactionsEpic.js

@@ -33,15 +33,11 @@ const fetchCompletedTransactionsEpic = (actions$, state$, zeniAPI) => actions$.p
     const queryPayload = {
         start_date: period.start,
         end_date: period.end,
+        sort_by: sortKey,
+        sort_order: sortOrder === 'ascending' ? 'asc' : 'desc',
         page_token: action.payload.pageToken ?? null,
         page_size: 25,
     };
-    if (sortKey != null) {
-        queryPayload.sort_by = sortKey;
-    }
-    if (sortOrder != null) {
-        queryPayload.sort_order = sortOrder === 'ascending' ? 'asc' : 'desc';
-    }
     if (completedSubTab !== 'all') {
         queryPayload.match_type = completedSubTab;
     }

package/lib/view/expenseAutomationView/epics/missingReceipts/searchTransactionsForManualMatchEpic.js

@@ -35,17 +35,12 @@ const searchTransactionsForManualMatchEpic = (actions$, state$, zeniAPI) => {
         const state = state$.value;
         const { expenseAutomationMissingReceiptsViewState: { bulkUpload: { manualSearch, sortKey, sortOrder }, }, } = state;
         const { end, start } = (0, rollingCalendarDateRangeInclusive_1.rollingCalendarDateRangeInclusive)(MANUAL_SEARCH_TRANSACTION_DATE_RANGE_DAYS);
-        // Manual search is independent of the Completed tab's optional sort: when the
-        // bulk upload sort is neutral (no user-applied sort), fall back to date/desc so
-        // search results stay deterministic for the matching UX.
-        const manualSearchSortKey = sortKey ?? 'date';
-        const manualSearchSortOrder = sortOrder ?? 'descending';
         const queryParam = {
             start_date: start,
             end_date: end,
             auto_categorized: exports.MANUAL_TRANSACTION_SEARCH_AUTO_CATEGORIZED,
-            sort_by: (0, transactionsViewState_1.toTransactionsSortKey)(manualSearchSortKey),
-            sort_order: manualSearchSortOrder === 'ascending' ? 'asc' : 'desc',
+            sort_by: (0, transactionsViewState_1.toTransactionsSortKey)(sortKey),
+            sort_order: sortOrder === 'ascending' ? 'asc' : 'desc',
             page_token: pageToken ?? null,
             page_size: manualSearch.pageSize,
             search_text: query,

package/lib/view/expenseAutomationView/reducers/missingReceiptsViewReducer.d.ts

@@ -7,7 +7,7 @@ import { TransactionPayload } from '../../../entity/transaction/payloadTypes/tra
 import { SupportedTransactionPayload } from '../../../entity/transaction/transactionState';
 import { ZeniAPIStatus } from '../../../responsePayload';
 import { type BatchDetails, type BatchListItem, type BatchStatus, type BulkUploadResultsTab, type BulkUploadSortKey, type BulkUploadState, type CompletedSubTab, type ManualSearchResult, type MissingReceiptsViewState, type MissingReceiptsViewUIState } from '../types/missingReceiptsViewState';
-export declare const getCompletedTransactionsCacheKey: (periodId: MonthYearPeriodId, sortKey: BulkUploadSortKey | undefined, sortOrder: SortOrder | undefined, subTab: CompletedSubTab) => string;
+export declare const getCompletedTransactionsCacheKey: (periodId: MonthYearPeriodId, sortKey: BulkUploadSortKey, sortOrder: SortOrder, subTab: CompletedSubTab) => string;
 export declare const initialBulkUploadState: BulkUploadState;
 export declare const initialState: MissingReceiptsViewState;
 /** Epic trigger only; batch-details fetch is handled in epics. */
@@ -85,8 +85,8 @@ export declare const fetchMissingReceipts: import("@reduxjs/toolkit").ActionCrea
 }, "expenseAutomationMissingReceiptsView/confirmBulkUploadMatchSuccess">, confirmBulkUploadMatchFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     error: ZeniAPIStatus;
 }, "expenseAutomationMissingReceiptsView/confirmBulkUploadMatchFailure">, setBulkUploadResultsTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"completed" | "unmatched", "expenseAutomationMissingReceiptsView/setBulkUploadResultsTab">, setBulkUploadCompletedSubTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"all" | "manual" | "ai_accountant", "expenseAutomationMissingReceiptsView/setBulkUploadCompletedSubTab">, setBulkUploadSortConfig: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
-    sortKey: BulkUploadSortKey | undefined;
-    sortOrder: SortOrder | undefined;
+    sortKey: BulkUploadSortKey;
+    sortOrder: SortOrder;
 }, "expenseAutomationMissingReceiptsView/setBulkUploadSortConfig">, clearBulkUpload: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"expenseAutomationMissingReceiptsView/clearBulkUpload">, searchTransactionsForManualMatch: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[query: string, pageToken?: string | null | undefined], {
     query: string;
     pageToken: string | undefined;
@@ -105,16 +105,16 @@ export declare const fetchMissingReceipts: import("@reduxjs/toolkit").ActionCrea
     isInitialLoad: boolean;
     nextPageToken: string | null;
     selectedPeriod: MonthYearPeriod;
-    sortKey: BulkUploadSortKey | undefined;
-    sortOrder: SortOrder | undefined;
+    sortKey: BulkUploadSortKey;
+    sortOrder: SortOrder;
     totalCount: number;
     transactionIds: ID[];
 }, "expenseAutomationMissingReceiptsView/fetchCompletedTransactionsSuccess">, fetchCompletedTransactionsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     completedSubTab: CompletedSubTab;
     error: ZeniAPIStatus;
     selectedPeriod: MonthYearPeriod;
-    sortKey: BulkUploadSortKey | undefined;
-    sortOrder: SortOrder | undefined;
+    sortKey: BulkUploadSortKey;
+    sortOrder: SortOrder;
 }, "expenseAutomationMissingReceiptsView/fetchCompletedTransactionsFailure">;
 declare const _default: import("redux").Reducer<MissingReceiptsViewState>;
 export default _default;

package/lib/view/expenseAutomationView/reducers/missingReceiptsViewReducer.js

@@ -5,11 +5,7 @@ exports.fetchCompletedTransactionsFailure = exports.fetchCompletedTransactionsSu
 const toolkit_1 = require("@reduxjs/toolkit");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const missingReceiptsViewState_1 = require("../types/missingReceiptsViewState");
-const getCompletedTransactionsCacheKey = (periodId, sortKey, sortOrder, subTab) => {
-    const sortKeyPart = sortKey ?? 'none';
-    const sortOrderPart = sortOrder == null ? 'none' : sortOrder === 'ascending' ? 'asc' : 'desc';
-    return `completed-${subTab}-${sortKeyPart}-${sortOrderPart}-${periodId}`;
-};
+const getCompletedTransactionsCacheKey = (periodId, sortKey, sortOrder, subTab) => `completed-${subTab}-${sortKey}-${sortOrder === 'ascending' ? 'asc' : 'desc'}-${periodId}`;
 exports.getCompletedTransactionsCacheKey = getCompletedTransactionsCacheKey;
 exports.initialBulkUploadState = {
     batchDetailsById: {},
@@ -34,8 +30,8 @@ exports.initialBulkUploadState = {
         totalCount: 0,
     },
     phase: 'idle',
-    sortKey: undefined,
-    sortOrder: undefined,
+    sortKey: 'date',
+    sortOrder: 'descending',
     uploadedFileCount: 0,
     uploadProgress: 0,
     uploadStatus: { fetchState: 'Not-Started', error: undefined },

package/lib/view/expenseAutomationView/selectorTypes/missingReceiptsSelectorTypes.d.ts

@@ -48,8 +48,8 @@ export interface BulkUploadSelectorData {
         processed: number;
         total: number;
     };
-    sortKey: BulkUploadSortKey | undefined;
-    sortOrder: SortOrder | undefined;
+    sortKey: BulkUploadSortKey;
+    sortOrder: SortOrder;
     unmatchedFiles: ResolvedBatchFile[];
     uploadedFileCount: number;
     uploadProgress: number;

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.d.ts

@@ -145,8 +145,8 @@ export interface BulkUploadState {
     manualSearch: ManualSearchState;
     manualSearchUiResetKey: number;
     phase: BulkUploadPhase;
-    sortKey: BulkUploadSortKey | undefined;
-    sortOrder: SortOrder | undefined;
+    sortKey: BulkUploadSortKey;
+    sortOrder: SortOrder;
     uploadedFileCount: number;
     uploadProgress: number;
     uploadStatus: FetchStateAndError;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.0.12-betaVR1",
+  "version": "5.0.12",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",
@@ -111,7 +111,7 @@
     "find-dead-code": "ts-prune | grep -v '(used in module)'",
     "find-unused-exports": "ts-unused-exports ./tsconfig.json",
     "circular-dependency": "npx madge --circular --extensions ts ./src",
-    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\"",
+    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\" \"echo 'Running tests and typecheck...' && pnpm test\" && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "only-build": "eslint . --ext .js,.jsx,.ts,.tsx && time tsc && tsc -p tsconfig.esm.json && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "only-build-dev": "eslint . --ext .js,.jsx,.ts,.tsx && time tsc -p tsconfig.dev.json && tsc -p tsconfig.esm.dev.json && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "format": "prettier --write --ignore-unknown \"src/**/*\" && pnpm lint",