@zeniai/client-epic-state 5.0.100 → 5.1.0-betaSS1

package/lib/esm/view/expenseAutomationView/expenseAutomationViewReducer.js

@@ -18,20 +18,37 @@ const expenseAutomationView = createSlice({
             reducer() {
                 //do nothing
             },
-            prepare(cacheOverride = false, refreshViewInBackground = false, isUncategorizedExpenseCategoryEnabled = false) {
+            /**
+             * `statuses` / `countOnlyStatuses` carry the Statsig-resolved values
+             * for the currently selected transaction-categorization tab. The
+             * host (`ExpenseAutomationScreen`) resolves them via
+             * `useDynamicConfig` + `resolveTransactionCategorizationStatuses`
+             * and passes them in so the downstream bootstrap fetch hits the
+             * listing API with the correct status filter. Optional only as a
+             * defensive type concession for non-categorization callers (the
+             * action is also used to bootstrap the missing-receipts / reconciliation
+             * / month-end views, which don't consume these args).
+             */
+            prepare(cacheOverride = false, refreshViewInBackground = false, isUncategorizedExpenseCategoryEnabled = false, statuses, countOnlyStatuses) {
                 return {
                     payload: {
                         cacheOverride,
                         refreshViewInBackground,
                         isUncategorizedExpenseCategoryEnabled,
+                        statuses,
+                        countOnlyStatuses,
                     },
                 };
             },
         },
         refreshExpenseAutomationCurrentTab: {
-            prepare(isUncategorizedExpenseCategoryEnabled) {
+            prepare(isUncategorizedExpenseCategoryEnabled, statuses, countOnlyStatuses) {
                 return {
-                    payload: { isUncategorizedExpenseCategoryEnabled },
+                    payload: {
+                        isUncategorizedExpenseCategoryEnabled,
+                        statuses,
+                        countOnlyStatuses,
+                    },
                 };
             },
             reducer() {

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -5,7 +5,6 @@ import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { isVendorTransaction } from '../../../entity/transaction/stateTypes/vendorTransaction';
 import { filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, shouldAutoSelectAndAdd, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
 import { DEFAULT_COMPLETED_SUB_TAB, } from '../types/completedSubTab';
-import { TRANSACTIONS_TABS, } from '../types/transactionsViewState';
 export const initialTransactionTabViewState = {
     saveStatus: {
         fetchState: 'Not-Started',
@@ -121,7 +120,7 @@ const expenseAutomationTransactionsView = createSlice({
     reducers: {
         fetchTransactionCategorizationView: {
             prepare(selectedTab, period, cacheOverride = false, keepExistingListItems = false, searchString, // when this is defined the output should go to search result IDs
-            pageToken, refreshViewInBackground = false, resetListItems = false, isUncategorizedExpenseCategoryEnabled) {
+            pageToken, refreshViewInBackground = false, resetListItems = false, isUncategorizedExpenseCategoryEnabled, statuses, countOnlyStatuses) {
                 return {
                     payload: {
                         selectedTab,
@@ -133,6 +132,8 @@ const expenseAutomationTransactionsView = createSlice({
                         refreshViewInBackground,
                         resetListItems,
                         isUncategorizedExpenseCategoryEnabled,
+                        statuses,
+                        countOnlyStatuses,
                     },
                 };
             },
@@ -181,7 +182,7 @@ const expenseAutomationTransactionsView = createSlice({
                 }
             },
             prepare(selectedTab, period, cacheOverride = false, keepExistingListItems = false, searchString, // when this is defined the output should go to search result IDs
-            pageToken, refreshViewInBackground = false, resetListItems, isUncategorizedExpenseCategoryEnabled) {
+            pageToken, refreshViewInBackground = false, resetListItems, isUncategorizedExpenseCategoryEnabled, statuses, countOnlyStatuses) {
                 return {
                     payload: {
                         selectedTab,
@@ -193,6 +194,8 @@ const expenseAutomationTransactionsView = createSlice({
                         refreshViewInBackground,
                         resetListItems,
                         isUncategorizedExpenseCategoryEnabled,
+                        statuses,
+                        countOnlyStatuses,
                     },
                 };
             },
@@ -311,13 +314,25 @@ const expenseAutomationTransactionsView = createSlice({
             draft.transactionCategorizationView[selectedTab].filters = filters;
         },
         saveTransactionCategorization: {
-            prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
+            /**
+             * `reviewStatuses` carries the Statsig-resolved Review-tab statuses
+             * forwarded by `ExpenseAutomationScreen`.
+             * `saveTransactionCategorizationEpic` threads them downstream into
+             * `updateTransactionCategorization` -> `markTransactionAsNotMiscategorized`
+             * so the conditional background Review-tab refetch in
+             * `markTransactionAsNotMiscategorizedEpic` can request the correct
+             * status set without reading Statsig from epic-land. Optional during
+             * the deprecation window so un-migrated callers continue to work via
+             * slice fallback.
+             */
+            prepare(selectedTab, transactionIds, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled, reviewStatuses) {
                 return {
                     payload: {
                         selectedTab,
                         transactionIds,
                         cotTrackingByTransactionId,
                         isUncategorizedExpenseCategoryEnabled,
+                        reviewStatuses,
                     },
                 };
             },
@@ -391,9 +406,16 @@ const expenseAutomationTransactionsView = createSlice({
                     fetchState: 'In-Progress',
                 };
             },
-            prepare(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled) {
+            /**
+             * `reviewStatuses` carries the Statsig-resolved Review-tab statuses
+             * forwarded from `saveTransactionCategorization`.
+             * `updateTransactionCategorizationEpic` threads them downstream into
+             * `markTransactionAsNotMiscategorized`.
+             */
+            prepare(selectedTab, transactionIds, transactionSaveUpdates, cotTrackingByTransactionId, isUncategorizedExpenseCategoryEnabled, reviewStatuses) {
                 return {
                     payload: {
+                        reviewStatuses,
                         selectedTab,
                         transactionIds,
                         transactionSaveUpdates,
@@ -858,12 +880,20 @@ const expenseAutomationTransactionsView = createSlice({
                     error: undefined,
                 };
             },
-            prepare(selectedTab, transactionsInReview, isUncategorizedExpenseCategoryEnabled) {
+            /**
+             * `reviewStatuses` carries the Statsig-resolved Review-tab statuses
+             * forwarded from the EA-screen save chain.
+             * `markTransactionAsNotMiscategorizedEpic` reads this payload value
+             * when dispatching the conditional background Review-tab refetch via
+             * `fetchTransactionCategorizationView`.
+             */
+            prepare(selectedTab, transactionsInReview, isUncategorizedExpenseCategoryEnabled, reviewStatuses) {
                 return {
                     payload: {
                         selectedTab,
                         transactionsInReview,
                         isUncategorizedExpenseCategoryEnabled,
+                        reviewStatuses,
                     },
                 };
             },
@@ -925,6 +955,9 @@ const expenseAutomationTransactionsView = createSlice({
         },
         updateParentTotalCountForTab(draft, action) {
             const { selectedTab, selectedPeriod, parentTotalCount } = action.payload;
+            if (parentTotalCount == null) {
+                return;
+            }
             draft.parentTotalCountByTab[selectedTab][toMonthYearPeriodId(selectedPeriod)] = parentTotalCount;
         },
         updateSelectedCheckboxTransactionIds(draft, action) {
@@ -973,7 +1006,7 @@ const expenseAutomationTransactionsView = createSlice({
             },
         },
         syncTransactionCategorizationFromDetailSave: {
-            prepare(transactionId, updatedTransaction, pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) {
+            prepare(transactionId, updatedTransaction, pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled, reviewStatuses) {
                 return {
                     payload: {
                         transactionId,
@@ -981,6 +1014,7 @@ const expenseAutomationTransactionsView = createSlice({
                         pendingReviewLineIds,
                         uncategorizedIncomeExpense,
                         isUncategorizedExpenseCategoryEnabled,
+                        reviewStatuses,
                     },
                 };
             },
@@ -1026,11 +1060,12 @@ const expenseAutomationTransactionsView = createSlice({
             },
         },
         backgroundRefetchReviewTab: {
-            prepare(period, isUncategorizedExpenseCategoryEnabled) {
+            prepare(period, isUncategorizedExpenseCategoryEnabled, reviewStatuses) {
                 return {
                     payload: {
                         period,
                         isUncategorizedExpenseCategoryEnabled,
+                        reviewStatuses,
                     },
                 };
             },
@@ -1041,18 +1076,7 @@ const expenseAutomationTransactionsView = createSlice({
                 };
             },
         },
-        removeTransactionFromAllTabs: {
-            prepare(transactionId) {
-                return { payload: { transactionId } };
-            },
-            reducer(draft, action) {
-                const { transactionId } = action.payload;
-                for (const tab of TRANSACTIONS_TABS) {
-                    removeTransactionFromTabView(draft.transactionCategorizationView[tab], transactionId);
-                }
-            },
-        },
     },
 });
-export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, updateTransactionFilters, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, updateParentTotalCountForTab, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, markCategoryClassRecommendationsInProgressForCategorization, markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, removeTransactionFromAllTabs, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
+export const { fetchTransactionCategorization, updateTransactionCategorizationUIState, updateTransactionFilters, initializeTransactionCategorizationViewLocalData, saveTransactionCategorizationLocalData, fetchTransactionCategorizationFailure, saveTransactionCategorization, updateTransactionCategorization, updateCurrentSelectedTransactionCategorizationTab, updateTransactionCategorizationCompletedSubTab, updateTransactionCategorizationSaveStatus, markTransactionAsNotMiscategorized, updateStatusForTransactionNotMiscategorizedUpdateForCategorization, updateSelectedVendorForTransaction, updateSelectedCustomerForTransaction, setAllItemsToCategoryClassInLocalDataForCategorization, updateTotalCountForTransactionCategorization, updateParentTotalCountForTab, fetchTransactionCategorizationSuccess, resetOtherTabsFetchState, fetchTransactionCategorizationView, updateSelectedCheckboxTransactionIds, clearExpenseAutomationTransactionsViewPerTabView, clearExpenseAutomationTransactionsView, setEntityRecommendationForLineIdsForCategorization, markCategoryClassRecommendationsInProgressForCategorization, markCategoryClassRecommendationsCompletedForCategorization, markCategoryClassRecommendationsFailureForCategorization, updateSelectedTransactionId, syncTransactionCategorizationFromDetailSave, backgroundRefetchReviewTab, updateTransactionCategorizationUploadReceiptState, uploadTransactionCategorizationReceiptSuccess, } = expenseAutomationTransactionsView.actions;
 export default expenseAutomationTransactionsView.reducer;

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -8,7 +8,6 @@ import { getSupportedTransactionsByIds } from '../../../entity/transaction/trans
 import { applyTransactionFilters, } from '../transactionFilterHelpers';
 import { getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
-import { getResolvedTransferAccounts } from '../../createTransferEntry/createTransferEntrySelector';
 import { getProjectList } from '../../projectList/projectListSelector';
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 // Walks the tab's transactionReviewLocalDataById map and returns
@@ -82,11 +81,8 @@ export const toTransactionView = (transaction, transactionLocalData) => {
         transactionLocalData,
     };
 };
-// Re-exported here for back-compat. New code should import from
-// `view/createTransferEntry/createTransferEntrySelector`.
-export { getLastTransferEntryReplacement } from '../../createTransferEntry/createTransferEntrySelector';
 export function getExpenseAutomationTransactionView(state) {
-    const { accountState, classState, classListState, accountListState, createTransferEntryState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, projectState, projectListState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
     const { selectedTransactionCategorizationCompletedSubTab, selectedTransactionCategorizationTab, } = expenseAutomationTransactionsViewState;
     const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, filters, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = getUncategorizedAccounts(accountState, accountListState, 'accountList');
@@ -186,10 +182,11 @@ export function getExpenseAutomationTransactionView(state) {
         review: monthYearPeriodId != null ? totalCountByReview[monthYearPeriodId] : 0,
         autoCategorized: monthYearPeriodId != null ? totalCountByAutoCat[monthYearPeriodId] : 0,
     };
-    // Parent-tab badge counts. Sourced from `parent_tab_total_count` in the
-    // listing response and used exclusively by the navbar / tab strip badges.
-    // Independent of which Completed sub-tab is active so the badge stays
-    // stable across sub-tab switches.
+    // Parent-tab badge counts. Sourced from the listing response's optional
+    // `count_only_total` (only emitted when the request supplied
+    // `count_only_statuses`) and used exclusively by the navbar / tab strip
+    // badges. Independent of which Completed sub-tab is active so the badge
+    // stays stable across sub-tab switches.
     const parentTotalCountByTab = expenseAutomationTransactionsViewState.parentTotalCountByTab;
     const parentTabTotalCountByTab = {
         review: monthYearPeriodId != null
@@ -218,7 +215,6 @@ export function getExpenseAutomationTransactionView(state) {
         : [];
     const transactionCompletionStatus = allSteps.find((step) => step.step === 'transaction_categorization')?.completionStatus;
     const completionStatus = transactionCompletionStatus ?? 'incomplete';
-    const { transferAccountsList, creditCardTransferAccountsList } = getResolvedTransferAccounts(state);
     const inFlightCategoryClassRecommendationsByTransactionId = getCategorizationInFlightRecommendationsByTransactionId(state);
     const hasInFlightCategoryClassRecommendations = getCategorizationHasInFlightRecommendations(state);
     return {
@@ -243,7 +239,6 @@ export function getExpenseAutomationTransactionView(state) {
         refreshStatus,
         saveStatus,
         markAsNotMiscategorizedStatus,
-        createTransferEntryStatus: createTransferEntryState.createTransferEntryStatus,
         completionStatus,
         totalCountByTab,
         parentTabTotalCountByTab,
@@ -251,8 +246,6 @@ export function getExpenseAutomationTransactionView(state) {
         uploadReceiptStatusById,
         selectedTransactionId,
         selectedTransactionLineId,
-        creditCardTransferAccountsList,
-        transferAccounts: transferAccountsList,
         selectedTransactionCategorizationCompletedSubTab,
     };
 }

package/lib/esm/view/expenseAutomationView/transactionFilterHelpers.js

@@ -28,87 +28,28 @@ export const TRANSACTION_FILTER_CATEGORIES = [
     { value: 'class', type: 'dropdown' },
     { value: 'amount', type: 'numberRange' },
 ];
-/**
- * Per-line amounts for a transaction, preserving the canonical source
- * precedence:
- *
- *   1. `transactionLocalData.transactionReviewLocalData.lineItemById` —
- *      the locally-edited line items the user sees in the grid. Reflects
- *      unsaved edits so the filter matches what the user actually has on
- *      screen, not the pre-edit server state.
- *   2. `transaction.transaction.lines` — persisted lines from the
- *      transaction payload.
- *   3. `[transaction.amount.amount]` — single-element fallback for
- *      transactions that don't have a `lines` array at all (treat the
- *      transaction-level amount as a one-line transaction).
- *
- * Returned as an array so the amount filter in `transactionMatchesCategory`
- * can OR-combine per-line `matchAmount` results: a transaction is included
- * if ANY of its lines satisfies the operator, and the full row (with all
- * lines, matching or not) renders downstream. Before the per-line change
- * this helper's predecessor in `getCategoryValueForTransaction` summed
- * these values into a single aggregate and compared the sum.
- *
- * **Missing amounts.** Lines (or transactions) whose amount field is
- * `null` / `undefined` / `NaN` are *dropped* from the returned array
- * rather than coerced to `0`. Coercing to `0` would silently make a
- * row with no amount data match operators like `less_than 100`, even
- * though we genuinely don't know what the amount is — a semantic
- * regression flagged in PR review. By filtering instead, the empty-array
- * case bubbles up to `transactionMatchesCategory`, which falls back to
- * the same "absent value: only `not_equal` matches" contract used by
- * non-amount fields.
- *
- * The defensive `?.` chains stay in place so a partial payload (state
- * init, Pusher mid-sync, partially-resolved server response) doesn't
- * throw; the difference is `?? 0` → filter-out.
- */
-const getLineAmountsForTransaction = (transaction) => {
-    const localData = transaction?.transactionLocalData?.transactionReviewLocalData;
-    if (localData?.lineItemById != null) {
-        const lineItems = Object.values(localData.lineItemById);
-        if (lineItems.length > 0) {
-            return lineItems
-                .map((lineItem) => lineItem?.amount?.amount)
-                .filter(isFiniteNumber);
-        }
-    }
-    if (transaction?.transaction?.lines != null &&
-        transaction.transaction.lines.length > 0) {
-        return transaction.transaction.lines
-            .map((line) => line?.amount?.amount)
-            .filter(isFiniteNumber);
-    }
-    const txAmount = transaction?.amount?.amount;
-    return isFiniteNumber(txAmount) ? [txAmount] : [];
-};
-/**
- * Type guard that survives an `Array<number | undefined>.filter(...)` and
- * narrows the result to `number[]`. Also rejects `NaN` so downstream
- * `matchAmount` never sees a value that fails every operator silently
- * (because every comparison with `NaN` is false, `NaN < 100`, `NaN > 100`,
- * `NaN === N` all yield `false` — the row would silently slip through
- * `not_equal` but fail every other operator, which is exactly the
- * absent-value contract we want to apply explicitly via an empty array
- * instead).
- */
-const isFiniteNumber = (value) => typeof value === 'number' && Number.isFinite(value);
 /**
  * Resolve the comparable value for a transaction against a given filter field.
  * Returns undefined when the transaction doesn't carry the field — callers
  * decide whether absence counts as a match (for 'not_equal' it does).
- *
- * NOTE: the `'amount'` field is NOT handled here. Amount matching is
- * per-line (see `getLineAmountsForTransaction` + the early-return in
- * `transactionMatchesCategory`) and would otherwise need to return a
- * non-scalar value that doesn't fit this helper's contract.
  */
 const getCategoryValueForTransaction = (key, transaction) => {
     switch (key) {
         case 'amount': {
-            // Handled per-line in `transactionMatchesCategory` — see the note on
-            // this function's JSDoc and `getLineAmountsForTransaction` above.
-            return undefined;
+            // Prefer transactionLocalData line items (sum). Fall back to lines on
+            // the transaction itself. Final fallback: transaction-level amount.
+            const localDataForAmount = transaction.transactionLocalData?.transactionReviewLocalData;
+            if (localDataForAmount?.lineItemById) {
+                const lineItems = Object.values(localDataForAmount.lineItemById);
+                if (lineItems.length > 0) {
+                    return lineItems.reduce((sum, lineItem) => sum + (lineItem.amount?.amount ?? 0), 0);
+                }
+            }
+            if (transaction.transaction.lines &&
+                transaction.transaction.lines.length > 0) {
+                return transaction.transaction.lines.reduce((sum, line) => sum + (line.amount?.amount ?? 0), 0);
+            }
+            return transaction.amount.amount;
         }
         case 'payee': {
             if (isNonEmptyString(transaction.vendorName)) {
@@ -246,37 +187,6 @@ const matchAmount = (amount, category) => {
     return op === 'not_equal' ? !matched : matched;
 };
 const transactionMatchesCategory = (transaction, category) => {
-    if (category.field === 'amount') {
-        // Per-line matching: the transaction is included if ANY of its lines
-        // satisfies the operator. This is what the user expects when a
-        // multi-line transaction contains lines at different amounts — they
-        // want the row to surface if even one line falls in the filter's
-        // range. The full row (with non-matching lines too) renders
-        // downstream; this matcher only decides row inclusion. Same
-        // operator + sign semantics as the aggregate version, just applied
-        // per line.
-        //
-        // `not_equal` deserves a sanity-check: `matchAmount` already inverts
-        // internally for that operator, so for a line whose amount is NOT
-        // in the filter's `values`, matchAmount returns true; for a line
-        // whose amount IS in the values, it returns false. `.some()` over
-        // lines therefore means "the transaction has at least one line that
-        // is not equal to any of the filter values" — which is the right
-        // match-any-line interpretation of `not_equal` (a transaction
-        // matches if it has a line that satisfies the negation).
-        const lineAmounts = getLineAmountsForTransaction(transaction);
-        if (lineAmounts.length === 0) {
-            // No valid (finite) amount data on the transaction or its lines —
-            // apply the same absent-value contract the generic branch below
-            // uses for non-amount fields: only `not_equal` matches a missing
-            // value, every other operator excludes it. Coercing missing
-            // amounts to `0` upstream (the previous behavior) would have made
-            // such rows silently match `less_than 100`, `in_between [0, 50]`,
-            // etc., which the PR review correctly flagged as a regression.
-            return category.matchingOperator === 'not_equal';
-        }
-        return lineAmounts.some((lineAmount) => matchAmount(lineAmount, category));
-    }
     const value = getCategoryValueForTransaction(category.field, transaction);
     if (value == null) {
         // Absent-value semantics — pinning these down explicitly so the
@@ -296,10 +206,12 @@ const transactionMatchesCategory = (transaction, category) => {
         //              are filtered out.
         //
         // Only the `not_equal` branch returns `true` here; everything else
-        // falls through to the `false` below. Note: 'amount' never lands here
-        // because it short-circuits to the per-line path above.
+        // falls through to the `false` below.
         return category.matchingOperator === 'not_equal';
     }
+    if (category.field === 'amount') {
+        return matchAmount(Number(value), category);
+    }
     const valueStr = value.toString();
     const valueInList = category.values.some((v) => v.toString() === valueStr);
     return category.matchingOperator === 'not_equal' ? !valueInList : valueInList;

package/lib/esm/view/spendManagement/autotransferRules/autoTransferRulesSelector.js

@@ -1,29 +1,10 @@
 import recordGet from 'lodash/get';
 import { reduceAllFetchState } from '../../../commonStateTypes/reduceFetchState';
-import { getDepositAccountByDepositAccountId } from '../../../entity/depositAccount/depositAccountSelector';
-import { getAllFundingAccounts, mapDepositAccToFundingAccount, } from '../commonSetup/setupViewSelector';
+import { getAllFundingAccounts, } from '../commonSetup/setupViewSelector';
 import { getAllDepositAccounts } from '../zeniAccounts/depositAccountList/depositAccountListSelector';
 import { getAllPaymentAccounts } from '../zeniAccounts/paymentAccountList/paymentAccountListSelector';
-const buildCashManagementRule = (autoSweepFlowState, depositAccountState, treasuryDetailState) => {
-    const { settingsId, bufferAmount, frequency, memo, primaryFundingAccountId, nextTransferDate } = autoSweepFlowState;
-    if (settingsId == null || primaryFundingAccountId == null) {
-        return undefined;
-    }
-    const depositAccount = getDepositAccountByDepositAccountId(depositAccountState, primaryFundingAccountId);
-    return {
-        bufferAmount,
-        frequency,
-        memo,
-        settingsId,
-        primaryFundingAccount: depositAccount != null
-            ? mapDepositAccToFundingAccount(depositAccount)
-            : undefined,
-        treasurySummary: treasuryDetailState.accountSummary,
-        nextTransferDate,
-    };
-};
 export const getAutoTransferRules = (state) => {
-    const { autotransferRulesState, autoSweepFlowState, depositAccountState, paymentAccountState, depositAccountListState, paymentAccountListState, treasuryDetailState, } = state;
+    const { autotransferRulesState, depositAccountState, paymentAccountState, depositAccountListState, paymentAccountListState, treasuryDetailState, } = state;
     const { rules, error, historyByRuleId, ruleUpdateLocalData, ruleUpdateStatusById, ruleDeleteStatusById, createRuleFetchState, autoTransferReviewDetail, } = autotransferRulesState;
     const depositAccountsView = getAllDepositAccounts(depositAccountState, depositAccountListState);
     const paymentAccountsView = getAllPaymentAccounts(paymentAccountState, paymentAccountListState);
@@ -58,7 +39,6 @@ export const getAutoTransferRules = (state) => {
         transferMoneyParties,
         transferMoneyPartiesFetchState,
         createRuleFetchState,
-        cashManagementRule: buildCashManagementRule(autoSweepFlowState, depositAccountState, treasuryDetailState),
         fetchState,
         error,
         version: 0,

package/lib/esm/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js

@@ -52,12 +52,6 @@ export const getReviewPageBillDetail = (state, billId) => {
     let recurringConfig;
     let billPayInfo;
     let isBillMarkedForRetry = false;
-    // Bill-level accounting class id. Approval Rules 3.0 'department'
-    // criteria match against this. Sourced from BillTransaction so
-    // any selector that needs it (e.g. creator-as-approver lookup)
-    // can read it off the view rather than reaching into
-    // 'state.billTransactionState' itself.
-    let classId;
     const zeniAssistRetryStatus = billId != null
         ? billDetailViewState.billDetailById[key].zeniAssist.retryStatus
         : undefined;
@@ -68,13 +62,6 @@ export const getReviewPageBillDetail = (state, billId) => {
             transaction?.billPayInfo.isCollectToAccountInfoFromVendorContact ?? false;
         isRecurring = transaction?.isRecurring ?? false;
         billPayInfo = transaction?.billPayInfo;
-        // Normalise empty-string to undefined so downstream readers
-        // treat "no class" uniformly regardless of whether the wire
-        // used '' or omitted the field.
-        classId =
-            transaction?.classId != null && transaction.classId !== ''
-                ? transaction.classId
-                : undefined;
         if (isRecurring &&
             transaction?.recurringBillConfigId != null &&
             transaction.recurringBillInstance != null) {
@@ -191,6 +178,5 @@ export const getReviewPageBillDetail = (state, billId) => {
         zeniAssistRetryStatus,
         billPayInfo,
         outsideZeniPaymentInfo,
-        classId,
     };
 };