@zeniai/client-epic-state 4.20.1-beta11ND → 4.20.1

package/lib/view/profitAndLossClassesView/profitAndLossHorizontalEnrichment.js

@@ -2,7 +2,6 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.enrichProfitAndLossByClassHorizontalReport = enrichProfitAndLossByClassHorizontalReport;
 const currencyHelper_1 = require("../../commonStateTypes/currencyHelper");
-const horizontalSectionEmptyBalancesSlice_1 = require("./horizontalSectionEmptyBalancesSlice");
 const profitAndLossClassesByClassHorizontalSelectorTypes_1 = require("./profitAndLossClassesByClassHorizontalSelectorTypes");
 /**
  * Populates `sectionHeaderBalancesSlice`, and per-account `accountReportData`, so the
@@ -43,17 +42,17 @@ function enrichHorizontalSection(report, section) {
     };
     const siblingsPerRow = buildSiblingIndicesPerRow(section.accounts, parentIndices);
     const hasChildFlags = computeHorizontalHasChildFlags(parentIndices);
-    for (let accountIndex = 0; accountIndex < section.accounts.length; accountIndex++) {
-        const row = section.accounts[accountIndex];
+    for (let i = 0; i < section.accounts.length; i++) {
+        const row = section.accounts[i];
         // Same column order as `report.classColumns` (see `pivotSectionToHorizontal`).
-        const classRowAmounts = row.classBalances.map((classBalance) => classBalance.balance.amount);
+        const classRowAmounts = row.classBalances.map((b) => b.balance.amount);
         row.accountReportData = {
             accountId: row.accountId,
             accountName: row.accountName,
             accountType: row.accountType,
             depth: row.depth,
             balancesInTimeframe: buildHorizontalClassColumnBalancesSlice(report, classRowAmounts, row.rowTotal.amount),
-            horizontalTreeView: buildHorizontalTreeViewFromPrecomputed(section.accounts, accountIndex, parentIndices, siblingsPerRow, hasChildFlags),
+            horizontalTreeView: buildHorizontalTreeViewFromPrecomputed(section.accounts, i, parentIndices, siblingsPerRow, hasChildFlags),
         };
     }
 }
@@ -71,14 +70,23 @@ function buildHorizontalClassColumnBalancesSlice(report, classAmounts, totalAmou
     const currencyCode = firstHeader?.balance.currencyCode ?? fallback.currencyCode;
     const currencySymbol = firstHeader?.balance.currencySymbol ?? fallback.currencySymbol;
     const timeframe = firstHeader?.balanceTimeFrame ?? 'month';
-    const emptySlice = (0, horizontalSectionEmptyBalancesSlice_1.getEmptyHorizontalSectionBalancesSlice)(report.firstMonthOfFY, timeframe);
+    const emptySlice = {
+        balances: [],
+        additionalBalances: [],
+        filter: {
+            firstMonthOfFY: report.firstMonthOfFY,
+            timeframe,
+            balancesRange: { numberOfPeriods: 0, orderBy: 'ascending_date' },
+            additionalBalances: [],
+        },
+    };
     if (report.selectedPeriod == null) {
         return emptySlice;
     }
     const { startDate, endDate } = report.selectedPeriod;
-    const balances = report.classColumns.map((col, columnIndex) => ({
+    const balances = report.classColumns.map((col, i) => ({
         balance: {
-            amount: classAmounts[columnIndex] ?? 0,
+            amount: classAmounts[i] ?? 0,
             currencyCode,
             currencySymbol,
         },
@@ -129,22 +137,22 @@ function computeHorizontalAccountParentIndices(rows) {
         if (accountRow == null) {
             continue;
         }
-        const depth = accountRow.depth;
+        const d = accountRow.depth;
         while (stack.length > 0) {
             const topRow = rows[stack[stack.length - 1]];
             if (topRow == null) {
                 stack.pop();
                 continue;
             }
-            if (topRow.depth < depth) {
+            if (topRow.depth < d) {
                 break;
             }
             stack.pop();
         }
-        if (depth > 2 && stack.length > 0) {
+        if (d > 2 && stack.length > 0) {
             const peek = stack[stack.length - 1];
             const parentRow = rows[peek];
-            if (parentRow != null && parentRow.depth === depth - 1) {
+            if (parentRow != null && parentRow.depth === d - 1) {
                 parentIndex[rowIndex] = peek;
             }
         }
@@ -163,12 +171,12 @@ function buildSiblingIndicesPerRow(rows, parentIndices) {
             continue;
         }
         const key = `${parentRowIndex}:${accountRow.depth}`;
-        let siblingGroup = keyToIndices.get(key);
-        if (siblingGroup == null) {
-            siblingGroup = [];
-            keyToIndices.set(key, siblingGroup);
+        let g = keyToIndices.get(key);
+        if (g == null) {
+            g = [];
+            keyToIndices.set(key, g);
         }
-        siblingGroup.push(rowIndex);
+        g.push(rowIndex);
     }
     const siblingsPerRow = new Array(accountRowCount);
     for (let rowIndex = 0; rowIndex < accountRowCount; rowIndex++) {
@@ -236,14 +244,14 @@ function buildHorizontalTreeViewFromPrecomputed(dfsOrderedAccountRows, currentRo
     const hasChildrenFlag = hasChildFlags[currentRowIndex];
     const treeDepth = accountRow != null ? Math.max(0, accountRow.depth - 2) : 0;
     const hasChildren = hasChildrenFlag === true;
-    const siblings = siblingIndices ?? [currentRowIndex];
+    const sibs = siblingIndices ?? [currentRowIndex];
     return {
         subAccountAncestorMetadata: buildHorizontalSubAccountAncestorMetadataFromPrecomputed(dfsOrderedAccountRows, currentRowIndex, parentIndices, siblingsPerRow, hasChildFlags),
         treeDepth,
         hasChildren,
-        hasSiblings: siblings.length > 1,
+        hasSiblings: sibs.length > 1,
         isLeaf: !hasChildren,
-        isLastNode: currentRowIndex === siblings[siblings.length - 1],
+        isLastNode: currentRowIndex === sibs[sibs.length - 1],
     };
 }
 function buildHorizontalAccountChildIndicesByParent(parentIndices) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "4.20.1-beta11ND",
+  "version": "4.20.1",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/esm/view/profitAndLossClassesView/horizontalSectionEmptyBalancesSlice.js

@@ -1,17 +0,0 @@
-/**
- * Empty `COABalancesSlice` for horizontal P&L-by-class section / calculated headers when
- * enrichment has not produced balances yet, or for UI mapping fallbacks.
- * Structure matches {@link enrichProfitAndLossByClassHorizontalReport} output.
- */
-export function getEmptyHorizontalSectionBalancesSlice(firstMonthOfFY, timeframe = 'month') {
-    return {
-        balances: [],
-        additionalBalances: [],
-        filter: {
-            firstMonthOfFY,
-            timeframe,
-            balancesRange: { numberOfPeriods: 0, orderBy: 'ascending_date' },
-            additionalBalances: [],
-        },
-    };
-}

package/lib/view/profitAndLossClassesView/horizontalSectionEmptyBalancesSlice.d.ts

@@ -1,9 +0,0 @@
-import { COABalanceTimeFrame } from '../../commonStateTypes/coaBalance/coaBalance';
-import { COABalancesSlice } from '../../commonStateTypes/coaBalance/coaBalancesFilter';
-import { Month } from '../../commonStateTypes/timePeriod';
-/**
- * Empty `COABalancesSlice` for horizontal P&L-by-class section / calculated headers when
- * enrichment has not produced balances yet, or for UI mapping fallbacks.
- * Structure matches {@link enrichProfitAndLossByClassHorizontalReport} output.
- */
-export declare function getEmptyHorizontalSectionBalancesSlice(firstMonthOfFY: Month, timeframe?: COABalanceTimeFrame): COABalancesSlice;

package/lib/view/profitAndLossClassesView/horizontalSectionEmptyBalancesSlice.js

@@ -1,20 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.getEmptyHorizontalSectionBalancesSlice = getEmptyHorizontalSectionBalancesSlice;
-/**
- * Empty `COABalancesSlice` for horizontal P&L-by-class section / calculated headers when
- * enrichment has not produced balances yet, or for UI mapping fallbacks.
- * Structure matches {@link enrichProfitAndLossByClassHorizontalReport} output.
- */
-function getEmptyHorizontalSectionBalancesSlice(firstMonthOfFY, timeframe = 'month') {
-    return {
-        balances: [],
-        additionalBalances: [],
-        filter: {
-            firstMonthOfFY,
-            timeframe,
-            balancesRange: { numberOfPeriods: 0, orderBy: 'ascending_date' },
-            additionalBalances: [],
-        },
-    };
-}