@zeniai/client-epic-state 4.19.99-betaRD21 → 4.19.99-betaRD4

package/lib/esm/view/aiAccountantView/epics/triggerAiAccountantJobEpic.js

@@ -0,0 +1,39 @@
+import { from, of } from 'rxjs';
+import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
+import { fetchAiAccountantCustomers, triggerAiAccountantJob, triggerAiAccountantJobFailure, triggerAiAccountantJobSuccess, } from '../aiAccountantViewReducer';
+export const triggerAiAccountantJobEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(triggerAiAccountantJob.match), mergeMap((action) => {
+    const { operationType, params, triggeredBy } = action.payload;
+    const rootState = state$.value;
+    const selectedTenantIds = rootState.aiAccountantViewState.selectedTenantIdsForJobTrigger;
+    const entityState = rootState.aiAccountantCustomerState;
+    const customers = selectedTenantIds
+        .map((tenantId) => {
+        const customer = entityState.customerByTenantId[tenantId];
+        return customer != null
+            ? { company_id: customer.companyId, tenant_id: customer.tenantId }
+            : undefined;
+    })
+        .filter((entry) => entry != null);
+    const base = `${zeniAPI.apiEndPoints.tenantMicroServiceBaseUrl}/1.0/cockpit-panels`;
+    const url = `${base}/ai-accountant/jobs`;
+    return zeniAPI
+        .postAndGetJSON(url, {
+        customers,
+        operation_type: operationType,
+        params: params ?? {},
+        triggered_by: triggeredBy ?? 'cockpit-ui',
+    })
+        .pipe(mergeMap((response) => {
+        if (isSuccessResponse(response)) {
+            return from([
+                triggerAiAccountantJobSuccess(),
+                fetchAiAccountantCustomers(),
+            ]);
+        }
+        else {
+            return of(triggerAiAccountantJobFailure(response.status));
+        }
+    }), catchError((error) => of(triggerAiAccountantJobFailure(createZeniAPIStatus('Unexpected error', 'AI Accountant trigger job failed: ' +
+        JSON.stringify(error))))));
+}));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchJeSchedulesEpic.js

@@ -21,13 +21,13 @@ export const fetchJeSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe
         if (isSuccessResponse(response) && response.data != null) {
             const updateActions = [];
             updateActions.push(updateJESchedules([
-                ...response.data.je_schedules,
+                ...response.data.draft_je_schedules,
                 ...response.data.failed_je_postings.je_schedules,
             ]), updateJESchedulesDetails([...response.data.failed_je_postings.je_schedules], response.data.failed_je_postings.scheduled_journal_entries), initializeJeScheduleLocalData([
                 ...response.data.failed_je_postings.je_schedules,
             ]));
             updateActions.push(fetchJeSchedulesSuccess({
-                jeSchedules: [...response.data.je_schedules],
+                jeSchedules: [...response.data.draft_je_schedules],
                 failedJeSchedules: [
                     ...response.data.failed_je_postings.je_schedules,
                 ],

package/lib/esm/view/expenseAutomationView/epics/missingReceipts/bulkUploadReceiptsEpic.js

@@ -1,9 +1,9 @@
 import { concat, of, timer } from 'rxjs';
-import { catchError, filter, mergeMap, switchMap } from 'rxjs/operators';
+import { catchError, filter, mergeMap } from 'rxjs/operators';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
 import { BULK_UPLOAD_BAR_COMPLETE_HOLD_MS } from '../../bulkUploadTiming';
 import { bulkUploadReceipts, bulkUploadReceiptsFailure, bulkUploadReceiptsSuccess, updateBulkUploadProgress, } from '../../reducers/missingReceiptsViewReducer';
-export const bulkUploadReceiptsEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(bulkUploadReceipts.match), switchMap((action) => {
+export const bulkUploadReceiptsEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(bulkUploadReceipts.match), mergeMap((action) => {
     const { files } = action.payload;
     const formData = new FormData();
     for (const file of files) {

package/lib/esm/view/expenseAutomationView/epics/missingReceipts/watchBulkUploadBatchStatusEpic.js

@@ -25,7 +25,7 @@ export const pusherBatchStatusCompletionEpic = (actions$) => actions$.pipe(filte
  * force `phase` to `completed` (dismiss automatching banner) and refresh the batch list.
  * Cancels when the batch completes normally, bulk state is cleared, or another upload supersedes.
  */
-export const bulkUploadAutomatchingTimeoutEpic = (actions$, state$) => actions$.pipe(filter(bulkUploadReceiptsSuccess.match), switchMap((action) => {
+export const bulkUploadAutomatchingTimeoutEpic = (actions$, state$) => actions$.pipe(filter(bulkUploadReceiptsSuccess.match), mergeMap((action) => {
     const { batchId } = action.payload;
     return timer(BULK_UPLOAD_AUTOMATCHING_TIMEOUT_MS).pipe(mergeMap(() => {
         const bulk = state$.value.expenseAutomationMissingReceiptsViewState.bulkUpload;
@@ -44,11 +44,10 @@ export const bulkUploadAutomatchingTimeoutEpic = (actions$, state$) => actions$.
  * error snackbar per upload session (first failure only) so the user is not spammed every
  * interval; Pusher or a later successful poll still completes the flow.
  */
-export const pollBulkUploadBatchStatusEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(bulkUploadReceiptsSuccess.match), switchMap((action) => {
+export const pollBulkUploadBatchStatusEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(bulkUploadReceiptsSuccess.match), mergeMap((action) => {
     const { batchId } = action.payload;
     let pollErrorNotified = false;
-    return timer(FALLBACK_FIRST_DELAY_MS, FALLBACK_POLL_INTERVAL_MS).pipe(takeUntil(merge(actions$.pipe(filter(clearBulkUpload.match)), actions$.pipe(filter(pusherBatchStatusUpdate.match), filter((action) => action.payload.batchId === batchId &&
-        action.payload.status === 'completed')), actions$.pipe(filter(fetchBulkUploadBatchDetailsSuccess.match), filter((action) => action.payload.batchId === batchId)), actions$.pipe(filter(bulkUploadAutomatchingTimedOut.match), filter((action) => action.payload.batchId === batchId)))), switchMap(() => zeniAPI
+    return timer(FALLBACK_FIRST_DELAY_MS, FALLBACK_POLL_INTERVAL_MS).pipe(takeUntil(merge(actions$.pipe(filter(clearBulkUpload.match)), actions$.pipe(filter(pusherBatchStatusUpdate.match), filter((action) => action.payload.batchId === batchId)), actions$.pipe(filter(fetchBulkUploadBatchDetailsSuccess.match), filter((action) => action.payload.batchId === batchId)), actions$.pipe(filter(bulkUploadAutomatchingTimedOut.match), filter((action) => action.payload.batchId === batchId)))), switchMap(() => zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.communicationAgentMicroServiceBaseUrl}/1.0/batches/${batchId}`)
         .pipe(mergeMap((response) => {
         /** Same batch-details URL; polls until `status` is completed (Pusher may win first). */

package/lib/esm/view/expenseAutomationView/expenseAutomationViewSelector.js

@@ -91,6 +91,7 @@ export function getExpenseAutomationView(state) {
     const fetchStateVariables = [
         expenseAutomationMissingReceiptsViewState,
         expenseAutomationJESchedulesViewState,
+        monthEndCloseChecksView,
         expenseAutomationTransactionsView,
         expenseAutomationReconciliationViewState,
     ];

package/lib/esm/view/expenseAutomationView/selectors/fluxAnalysisViewSelector.js

@@ -1,4 +1,3 @@
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getAccountBase } from '../../../entity/account/accountSelector';
 import { getClassById } from '../../../entity/class/classSelector';
@@ -7,7 +6,7 @@ import { getUserByUserId } from '../../../entity/user/userSelector';
 import { getVendorByVendorId } from '../../../entity/vendor/vendorSelector';
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 export function getExpenseAutomationFluxAnalysisView(state) {
-    const { expenseAutomationFluxAnalysisViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { expenseAutomationFluxAnalysisViewState, monthEndCloseChecksState } = state;
     const { fetchState, error, refreshStatus, uiState, reviewOperatingExpenseIdsByPeriod, selectedSectionIdsByPeriod, groupsBySelectedPeriod, fluxAnalysisEntities, bulkReviewStatus, currency, totalBalancesAndVariance, } = expenseAutomationFluxAnalysisViewState;
     const fetchStateAndError = {
         fetchState,
@@ -92,17 +91,10 @@ export function getExpenseAutomationFluxAnalysisView(state) {
         },
     };
     const completionStatus = fluxCompletionStatus != null ? fluxCompletionStatus : 'incomplete';
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        fetchStateAndError,
-        monthEndFetchState,
-    ]);
     return {
         sections,
         totalBalancesAndVariance,
-        fetchStatus: reducedFetchStatus,
+        fetchStatus: fetchStateAndError,
         bulkReviewStatus,
         reviewOperatingExpensesIds,
         selectedSectionIds,

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -1,6 +1,5 @@
 import omit from 'lodash/omit';
 import orderBy from 'lodash/orderBy';
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getAccountIdsForTypes } from '../../../entity/account/accountSelector';
 import { getJEScheduledTransactionByJEScheduleTransactionKey, } from '../../../entity/jeSchedules/jeSchedulesSelector';
@@ -20,8 +19,6 @@ function getJEScheduleSortAccessor(sortKey) {
             return (s) => s.jeDebit.account?.accountName?.toLowerCase();
         case 'class':
             return (s) => s.jeDebit.accountingClass?.className?.toLowerCase();
-        case 'depCategory':
-            return (s) => s.jeCredit.account?.accountName?.toLowerCase();
         case 'scheduleCategory':
             return (s) => s.jeScheduleType;
         case 'startMonth':
@@ -53,7 +50,7 @@ function sortJEScheduledTransactions(transactions, sortKey, sortOrder) {
 export function getExpenseAutomationJESchedulesView(state) {
     const jeScheduledTransaction = [];
     const failedJeScheduledTransaction = [];
-    const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, } = state;
     const { jeScheduleTransactionKeysByPeriod, failedJeScheduleTransactionKeysByPeriod, jeScheduleLocalDataById, postStatusById, ignoreStatusById, uiState, error, fetchState, refreshStatus, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
     const currentTenant = getCurrentTenant(state);
@@ -119,13 +116,6 @@ export function getExpenseAutomationJESchedulesView(state) {
         : [];
     const jeCompletionStatus = allSteps.find((step) => step.step === 'je_schedules')?.completionStatus;
     const completionStatus = jeCompletionStatus != null ? jeCompletionStatus : 'incomplete';
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        { fetchState, error },
-        monthEndFetchState,
-    ]);
     return {
         uncategorizedAccounts,
         allDepreciationAccountList: filteredDepAccounts,
@@ -141,10 +131,10 @@ export function getExpenseAutomationJESchedulesView(state) {
         accountSettingsView,
         postStatusById: postStatusById,
         ignoreStatusById: ignoreStatusById,
-        fetchState: reducedFetchStatus.fetchState,
+        fetchState: fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,
-        error: reducedFetchStatus.error,
+        error: error,
         refreshStatus,
         completionStatus,
     };

package/lib/esm/view/expenseAutomationView/selectors/missingReceiptsSelector.js

@@ -1,5 +1,4 @@
 import orderBy from 'lodash/orderBy';
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { getSupportedTransactionById, getSupportedTransactionsByIds, } from '../../../entity/transaction/transactionSelector';
@@ -8,7 +7,7 @@ import { getCompletedTransactionsCacheKey } from '../reducers/missingReceiptsVie
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 import { isUnmatchedTabFileStatus, } from '../types/missingReceiptsViewState';
 export function getExpenseAutomationMissingReceiptsView(state) {
-    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, } = state;
     const currentTenant = getCurrentTenant(state);
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
@@ -176,16 +175,9 @@ export function getExpenseAutomationMissingReceiptsView(state) {
             vendorLogo: result.vendorLogo ?? transaction?.logo?.href,
         };
     });
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        { fetchState, error },
-        monthEndFetchState,
-    ]);
     return {
-        fetchState: reducedFetchStatus.fetchState,
-        error: reducedFetchStatus.error,
+        fetchState,
+        error,
         uploadReceiptStatusById,
         uiState,
         refreshStatus,

package/lib/esm/view/expenseAutomationView/selectors/reconciliationViewSelector.js

@@ -13,7 +13,7 @@ import { getAccountList, getNestedAccountListHierarchy, } from '../../accountLis
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
 import { initialActionFetchState, initialReconciliationTabsState, initialState, } from '../reducers/reconciliationViewReducer';
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
-export const getExpenseAutomationReconciliationView = createSelector((state) => state, (state) => getCurrentTenant(state), (state) => state.expenseAutomationReconciliationViewState, (state) => state.expenseAutomationViewState, (state) => state.plaidAccountViewState, (state) => state.accountListState, (state) => state.accountState, (state) => state.classListState, (state) => state.classState, (state) => state.monthEndCloseChecksState, (state) => state.vendorState, (state) => state.monthEndCloseChecksViewState, (state, currentTenant, reconciliationViewState, expenseAutomationViewState, plaidAccountViewState, accountListState, accountState, classListState, classState, monthEndCloseChecksState, vendorState, monthEndCloseChecksViewState) => {
+export const getExpenseAutomationReconciliationView = createSelector((state) => state, (state) => getCurrentTenant(state), (state) => state.expenseAutomationReconciliationViewState, (state) => state.expenseAutomationViewState, (state) => state.plaidAccountViewState, (state) => state.accountListState, (state) => state.accountState, (state) => state.classListState, (state) => state.classState, (state) => state.monthEndCloseChecksState, (state) => state.vendorState, (state, currentTenant, reconciliationViewState, expenseAutomationViewState, plaidAccountViewState, accountListState, accountState, classListState, classState, monthEndCloseChecksState, vendorState) => {
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const reconcileTabUiState = reconciliationViewState.reconTabsState.reconcile.uiState;
     const reviewTabUiState = reconciliationViewState.reconTabsState.review.uiState;
@@ -35,13 +35,6 @@ export const getExpenseAutomationReconciliationView = createSelector((state) =>
         }
         return acc;
     }, []);
-    const monthYearPeriodId = selectedPeriod != null ? toMonthYearPeriodId(selectedPeriod) : null;
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? {
-            fetchState: 'Not-Started',
-            error: undefined,
-        })
-        : { fetchState: 'Not-Started', error: undefined };
     if (accountReconForMonthYearPeriod == null) {
         return {
             bankAccounts: [],
@@ -51,13 +44,10 @@ export const getExpenseAutomationReconciliationView = createSelector((state) =>
             classListNestedAccountHierarchy: [],
             allAccountList: [],
             allClassList: [],
-            fetchStatus: reduceAnyFetchState([
-                {
-                    fetchState: reconciliationViewState.fetchState,
-                    error: reconciliationViewState.error,
-                },
-                monthEndFetchState,
-            ]),
+            fetchStatus: {
+                fetchState: reconciliationViewState.fetchState,
+                error: reconciliationViewState.error,
+            },
             plaidConnectionDetails: plaidAccountViewState['expense_automation_reconcile']
                 .plaidConnectionDetails,
             completionStatus: 'incomplete',
@@ -280,13 +270,10 @@ export const getExpenseAutomationReconciliationView = createSelector((state) =>
         bankAccounts: uniqueBankAccounts,
         creditCards: uniqueCreditCards,
         accountReconciliationsByAccountID: reconList,
-        fetchStatus: reduceAnyFetchState([
-            {
-                fetchState: reconciliationViewState.fetchState,
-                error: reconciliationViewState.error,
-            },
-            monthEndFetchState,
-        ]),
+        fetchStatus: {
+            fetchState: reconciliationViewState.fetchState,
+            error: reconciliationViewState.error,
+        },
         plaidConnectionDetails: plaidAccountViewState['expense_automation_reconcile']
             .plaidConnectionDetails,
         reconciliationTabsState: reconciliationViewState.reconTabsState,

package/lib/esm/view/expenseAutomationView/selectors/transactionCategorizationSelector.js

@@ -1,5 +1,5 @@
 import omit from 'lodash/omit';
-import { reduceAllFetchState, reduceAnyFetchState, } from '../../../commonStateTypes/reduceFetchState';
+import { reduceAllFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { getTransactionWithCOT } from '../../../entity/transaction/transactionHelper';
@@ -8,7 +8,7 @@ import { getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
 import { getAllSteps } from '../selectorTypes/expenseAutomationViewSelectorTypes';
 export function getExpenseAutomationTransactionView(state) {
-    const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { accountState, classState, classListState, accountListState, expenseAutomationTransactionsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, } = state;
     const { selectedTransactionCategorizationTab } = expenseAutomationTransactionsViewState;
     const { uiState, refreshStatus, saveStatus, markAsNotMiscategorizedStatus, transactionIdsBySelectedPeriod, transactionReviewLocalDataById, selectedCheckBoxTransactionIds, transactionIdsWithUnsavedData, uploadReceiptStatusById, selectedTransactionId, selectedTransactionLineId, } = expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab];
     const uncategorizedIncomeExpense = getUncategorizedAccounts(accountState, accountListState, 'accountList');
@@ -41,16 +41,10 @@ export function getExpenseAutomationTransactionView(state) {
         .filter((transaction) => transaction != null);
     const transactions = getSupportedTransactionsByIds(transactionState, transactionIds);
     const transactionsWithCOT = transactions.map((transaction) => getTransactionWithCOT(transaction));
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const fetchStatus = reduceAnyFetchState([
-        reduceAllFetchState([
-            accountList,
-            classList,
-            expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab],
-        ]),
-        monthEndFetchState,
+    const fetchStatus = reduceAllFetchState([
+        accountList,
+        classList,
+        expenseAutomationTransactionsViewState.transactionCategorizationView[selectedTransactionCategorizationTab],
     ]);
     const totalCountByReview = expenseAutomationTransactionsViewState.transactionCategorizationView.review
         .uiState.totalCount;

package/lib/esm/view/expenseAutomationView/types/jeSchedulesViewState.js

@@ -3,7 +3,6 @@ const JE_SCHEDULE_SORT_KEYS = [
     'vendor',
     'category',
     'class',
-    'depCategory',
     'scheduleCategory',
     'startMonth',
     'type',

package/lib/esm/view/profitAndLossClassesView/profitAndLossClassesByClassHorizontalSelector.js

@@ -49,11 +49,16 @@ export const getProfitAndLossClassesHorizontalView = (filter, accountState, clas
     const calculatedSections = {};
     let reportCurrency = defaultCustomerCurrency;
     if (fetchState.fetchState === 'Completed' && selectedPeriod != null) {
+        // Get section reports using existing selector infrastructure
+        const sectionReports = {};
+        HORIZONTAL_PANDL_SECTION_IDS.forEach((sectionId) => {
+            sectionReports[sectionId] = getSectionClassesViewReport(accountState, classState, sectionsState, { reportId, sectionId }, filter);
+        });
         reportCurrency =
             profitAndLossClassesViewState.currency ?? defaultCustomerCurrency;
-        // Fetch each section and pivot class→account to account→class in one pass
+        // Pivot each section from class→account to account→class
         HORIZONTAL_PANDL_SECTION_IDS.forEach((sectionId) => {
-            const sectionReport = getSectionClassesViewReport(accountState, classState, sectionsState, { reportId, sectionId }, filter);
+            const sectionReport = sectionReports[sectionId];
             if (sectionReport != null) {
                 sections[sectionId] = pivotSectionToHorizontal(sectionReport, classColumns, SECTION_TITLES[sectionId] ?? sectionId, reportCurrency);
             }
@@ -256,7 +261,7 @@ function sumBalancesInSlice(balances) {
     if (balances.length === 0) {
         return 0;
     }
-    const summed = getSummationFreeRangeTotalBalance(balances);
+    const summed = getSummationFreeRangeTotalBalance([...balances]);
     return summed?.balance.amount ?? 0;
 }
 /**

package/lib/esm/view/profitAndLossClassesView/profitAndLossHorizontalEnrichment.js

@@ -25,31 +25,30 @@ function enrichHorizontalSection(report, section) {
         return total?.balance.amount ?? 0;
     });
     section.sectionHeaderBalancesSlice = buildHorizontalClassColumnBalancesSlice(report, classAmounts, section.sectionTotal.amount);
-    const parentIndices = computeHorizontalAccountParentIndices(section.accounts);
-    const childrenRowIndicesByParent = buildHorizontalAccountChildIndicesByParent(parentIndices);
+    const childrenRowIndicesByParent = buildHorizontalAccountChildIndicesByParent(section.accounts);
     const childrenRecord = {};
     childrenRowIndicesByParent.forEach((childIndices, parentIndex) => {
         childrenRecord[parentIndex] = childIndices;
     });
     section.treeLayout = {
         rootAccountRowIndices: section.accounts
-            .map((_, i) => (parentIndices[i] === -1 ? i : -1))
+            .map((_, i) => findHorizontalAccountParentIndex(section.accounts, i) === -1 ? i : -1)
             .filter((i) => i >= 0),
         childrenRowIndicesByParent: childrenRecord,
     };
-    const siblingsPerRow = buildSiblingIndicesPerRow(section.accounts, parentIndices);
-    const hasChildFlags = computeHorizontalHasChildFlags(parentIndices);
-    for (let accountIndex = 0; accountIndex < section.accounts.length; accountIndex++) {
-        const row = section.accounts[accountIndex];
-        // Same column order as `report.classColumns` (see `pivotSectionToHorizontal`).
-        const classRowAmounts = row.classBalances.map((classBalance) => classBalance.balance.amount);
+    for (let i = 0; i < section.accounts.length; i++) {
+        const row = section.accounts[i];
+        const classRowAmounts = report.classColumns.map((col) => {
+            const cb = row.classBalances.find((b) => b.classId === col.classId);
+            return cb?.balance.amount ?? 0;
+        });
         row.accountReportData = {
             accountId: row.accountId,
             accountName: row.accountName,
             accountType: row.accountType,
             depth: row.depth,
             balancesInTimeframe: buildHorizontalClassColumnBalancesSlice(report, classRowAmounts, row.rowTotal.amount),
-            horizontalTreeView: buildHorizontalTreeViewFromPrecomputed(section.accounts, accountIndex, parentIndices, siblingsPerRow, hasChildFlags),
+            horizontalTreeView: buildHorizontalTreeView(section.accounts, i),
         };
     }
 }
@@ -81,9 +80,9 @@ function buildHorizontalClassColumnBalancesSlice(report, classAmounts, totalAmou
         return emptySlice;
     }
     const { startDate, endDate } = report.selectedPeriod;
-    const balances = report.classColumns.map((col, columnIndex) => ({
+    const balances = report.classColumns.map((col, i) => ({
         balance: {
-            amount: classAmounts[columnIndex] ?? 0,
+            amount: classAmounts[i] ?? 0,
             currencyCode,
             currencySymbol,
         },
@@ -121,157 +120,64 @@ function buildHorizontalClassColumnBalancesSlice(report, classAmounts, totalAmou
         },
     };
 }
-/**
- * Parent index per DFS row — O(n). Matches the scan in the former
- * `findHorizontalAccountParentIndex` (depth &lt;= 2 rows have no parent).
- */
-function computeHorizontalAccountParentIndices(rows) {
-    const accountRowCount = rows.length;
-    const parentIndex = new Array(accountRowCount).fill(-1);
-    const stack = [];
-    for (let rowIndex = 0; rowIndex < accountRowCount; rowIndex++) {
-        const accountRow = rows[rowIndex];
-        if (accountRow == null) {
-            continue;
-        }
-        const depth = accountRow.depth;
-        while (stack.length > 0) {
-            const topIndex = stack[stack.length - 1];
-            if (topIndex == null) {
-                break;
-            }
-            const topRow = rows[topIndex];
-            if (topRow == null) {
-                stack.pop();
-                continue;
-            }
-            if (topRow.depth < depth) {
-                break;
-            }
-            stack.pop();
-        }
-        if (depth <= 2) {
-            parentIndex[rowIndex] = -1;
-        }
-        else if (stack.length === 0) {
-            parentIndex[rowIndex] = -1;
-        }
-        else {
-            const peek = stack[stack.length - 1];
-            if (peek == null) {
-                parentIndex[rowIndex] = -1;
-            }
-            else {
-                const parentRow = rows[peek];
-                parentIndex[rowIndex] =
-                    parentRow != null && parentRow.depth === depth - 1 ? peek : -1;
+function findHorizontalAccountParentIndex(dfsOrderedAccountRows, childRowIndex) {
+    const childDepth = dfsOrderedAccountRows[childRowIndex].depth;
+    if (childDepth <= 2) {
+        return -1;
+    }
+    for (let earlierRowIndex = childRowIndex - 1; earlierRowIndex >= 0; earlierRowIndex--) {
+        const earlierDepth = dfsOrderedAccountRows[earlierRowIndex].depth;
+        if (earlierDepth < childDepth) {
+            if (earlierDepth === childDepth - 1) {
+                return earlierRowIndex;
             }
+            return -1;
         }
-        stack.push(rowIndex);
     }
-    return parentIndex;
+    return -1;
 }
-/** Sibling row indices (same parent + depth), in traversal order — O(n). */
-function buildSiblingIndicesPerRow(rows, parentIndices) {
-    const accountRowCount = rows.length;
-    const keyToIndices = new Map();
-    for (let rowIndex = 0; rowIndex < accountRowCount; rowIndex++) {
-        const parentRowIndex = parentIndices[rowIndex];
-        const accountRow = rows[rowIndex];
-        if (parentRowIndex == null || accountRow == null) {
-            continue;
-        }
-        const key = `${parentRowIndex}:${accountRow.depth}`;
-        let siblingGroup = keyToIndices.get(key);
-        if (siblingGroup == null) {
-            siblingGroup = [];
-            keyToIndices.set(key, siblingGroup);
+function getHorizontalAccountSiblingIndices(dfsOrderedAccountRows, rowIndex) {
+    const parentRowIndex = findHorizontalAccountParentIndex(dfsOrderedAccountRows, rowIndex);
+    const rowDepth = dfsOrderedAccountRows[rowIndex].depth;
+    const siblings = [];
+    for (let i = 0; i < dfsOrderedAccountRows.length; i++) {
+        if (dfsOrderedAccountRows[i].depth === rowDepth &&
+            findHorizontalAccountParentIndex(dfsOrderedAccountRows, i) ===
+                parentRowIndex) {
+            siblings.push(i);
         }
-        siblingGroup.push(rowIndex);
     }
-    const siblingsPerRow = new Array(accountRowCount);
-    for (let rowIndex = 0; rowIndex < accountRowCount; rowIndex++) {
-        const parentRowIndex = parentIndices[rowIndex];
-        const accountRow = rows[rowIndex];
-        if (parentRowIndex == null || accountRow == null) {
-            siblingsPerRow[rowIndex] = [rowIndex];
-            continue;
-        }
-        const key = `${parentRowIndex}:${accountRow.depth}`;
-        const group = keyToIndices.get(key);
-        siblingsPerRow[rowIndex] = group != null ? group : [rowIndex];
-    }
-    return siblingsPerRow;
+    return siblings;
 }
-function computeHorizontalHasChildFlags(parentIndices) {
-    const rowCount = parentIndices.length;
-    const flags = new Array(rowCount).fill(false);
-    for (let rowIndex = 0; rowIndex < rowCount; rowIndex++) {
-        const parentRowIndex = parentIndices[rowIndex];
-        if (parentRowIndex != null &&
-            parentRowIndex >= 0 &&
-            parentRowIndex < rowCount) {
-            flags[parentRowIndex] = true;
-        }
-    }
-    return flags;
+function horizontalAccountHasChildRows(dfsOrderedAccountRows, parentRowIndex) {
+    return dfsOrderedAccountRows.some((_, rowIndex) => findHorizontalAccountParentIndex(dfsOrderedAccountRows, rowIndex) ===
+        parentRowIndex);
 }
-function buildHorizontalSubAccountAncestorMetadataFromPrecomputed(dfsOrderedAccountRows, currentRowIndex, parentIndices, siblingsPerRow, hasChildFlags) {
-    const chain = [];
+function buildHorizontalSubAccountAncestorMetadata(dfsOrderedAccountRows, currentRowIndex) {
+    const ancestorRowIndicesRootToLeaf = [];
     let walkRowIndex = currentRowIndex;
     while (walkRowIndex >= 0) {
-        chain.unshift(walkRowIndex);
-        const parentRowIndex = parentIndices[walkRowIndex];
-        if (parentRowIndex == null) {
-            break;
-        }
-        walkRowIndex = parentRowIndex;
+        ancestorRowIndicesRootToLeaf.unshift(walkRowIndex);
+        walkRowIndex = findHorizontalAccountParentIndex(dfsOrderedAccountRows, walkRowIndex);
     }
-    return chain.map((rowIndex) => {
-        const accountRow = dfsOrderedAccountRows[rowIndex];
-        const siblingIndices = siblingsPerRow[rowIndex];
-        const hasChild = hasChildFlags[rowIndex];
-        if (accountRow == null || siblingIndices == null) {
-            return {
-                depth: 0,
-                hasSibling: false,
-                hasChildren: hasChild === true,
-                isLastNode: true,
-                name: '',
-            };
-        }
+    return ancestorRowIndicesRootToLeaf.map((rowIndex) => {
+        const siblingIndices = getHorizontalAccountSiblingIndices(dfsOrderedAccountRows, rowIndex);
         return {
-            depth: accountRow.depth - 2,
+            depth: dfsOrderedAccountRows[rowIndex].depth - 2,
             hasSibling: siblingIndices.length > 1,
-            hasChildren: hasChild === true,
+            hasChildren: horizontalAccountHasChildRows(dfsOrderedAccountRows, rowIndex),
             isLastNode: rowIndex === siblingIndices[siblingIndices.length - 1],
-            name: accountRow.accountName,
+            name: dfsOrderedAccountRows[rowIndex].accountName,
         };
     });
 }
-function buildHorizontalTreeViewFromPrecomputed(dfsOrderedAccountRows, currentRowIndex, parentIndices, siblingsPerRow, hasChildFlags) {
-    const siblingIndices = siblingsPerRow[currentRowIndex];
-    const accountRow = dfsOrderedAccountRows[currentRowIndex];
-    const hasChildrenFlag = hasChildFlags[currentRowIndex];
-    const treeDepth = accountRow != null ? Math.max(0, accountRow.depth - 2) : 0;
-    const hasChildren = hasChildrenFlag === true;
-    const siblings = siblingIndices ?? [currentRowIndex];
-    return {
-        subAccountAncestorMetadata: buildHorizontalSubAccountAncestorMetadataFromPrecomputed(dfsOrderedAccountRows, currentRowIndex, parentIndices, siblingsPerRow, hasChildFlags),
-        treeDepth,
-        hasChildren,
-        hasSiblings: siblings.length > 1,
-        isLeaf: !hasChildren,
-        isLastNode: currentRowIndex === siblings[siblings.length - 1],
-    };
-}
-function buildHorizontalAccountChildIndicesByParent(parentIndices) {
+function buildHorizontalAccountChildIndicesByParent(dfsOrderedAccountRows) {
     const childIndicesByParentRowIndex = new Map();
-    for (let rowIndex = 0; rowIndex < parentIndices.length; rowIndex++) {
-        const parentRowIndex = parentIndices[rowIndex];
-        if (parentRowIndex != null && parentRowIndex >= 0) {
+    for (let rowIndex = 0; rowIndex < dfsOrderedAccountRows.length; rowIndex++) {
+        const parentRowIndex = findHorizontalAccountParentIndex(dfsOrderedAccountRows, rowIndex);
+        if (parentRowIndex >= 0) {
             let childRowIndices = childIndicesByParentRowIndex.get(parentRowIndex);
-            if (childRowIndices == null) {
+            if (childRowIndices === undefined) {
                 childRowIndices = [];
                 childIndicesByParentRowIndex.set(parentRowIndex, childRowIndices);
             }
@@ -280,3 +186,16 @@ function buildHorizontalAccountChildIndicesByParent(parentIndices) {
     }
     return childIndicesByParentRowIndex;
 }
+function buildHorizontalTreeView(dfsOrderedAccountRows, currentRowIndex) {
+    const treeDepth = Math.max(0, dfsOrderedAccountRows[currentRowIndex].depth - 2);
+    const siblingIndices = getHorizontalAccountSiblingIndices(dfsOrderedAccountRows, currentRowIndex);
+    const hasChildren = horizontalAccountHasChildRows(dfsOrderedAccountRows, currentRowIndex);
+    return {
+        subAccountAncestorMetadata: buildHorizontalSubAccountAncestorMetadata(dfsOrderedAccountRows, currentRowIndex),
+        treeDepth,
+        hasChildren,
+        hasSiblings: siblingIndices.length > 1,
+        isLeaf: !hasChildren,
+        isLastNode: currentRowIndex === siblingIndices[siblingIndices.length - 1],
+    };
+}