@zeniai/client-epic-state 4.19.88-beta1ND → 4.19.88-beta2ND

package/lib/esm/view/profitAndLossClassesView/profitAndLossClassesByClassHorizontalSelector.js

@@ -52,7 +52,7 @@ export const getProfitAndLossClassesHorizontalView = (filter, accountState, clas
         sectionIds.forEach((sectionId) => {
             const sectionReport = sectionReports[sectionId];
             if (sectionReport != null) {
-                sections[sectionId] = pivotSectionToHorizontal(sectionReport, classColumns, selectedPeriod, SECTION_TITLES[sectionId] ?? sectionId);
+                sections[sectionId] = pivotSectionToHorizontal(sectionReport, classColumns, SECTION_TITLES[sectionId] ?? sectionId);
             }
         });
         // Calculate derived sections
@@ -116,7 +116,7 @@ function buildClassColumns(classHierarchy, classesToFilterOut) {
 /**
  * Pivot a section from class→account→balances to account→class→balance (single period).
  */
-function pivotSectionToHorizontal(section, classColumns, selectedPeriod, title) {
+function pivotSectionToHorizontal(section, classColumns, title) {
     // Map: accountId -> { accountName, classId -> balance }
     const accountMap = new Map();
     // Also track class totals
@@ -129,11 +129,11 @@ function pivotSectionToHorizontal(section, classColumns, selectedPeriod, title)
         if (!classColumns.some((col) => col.classId === classId)) {
             return;
         }
-        // Get the class-level balance for this period (total for the class in this section)
-        const classBalance = findBalanceForPeriod(classReport.childrenBalancesTotal.balances, selectedPeriod);
+        // Sum all sliced period balances (same slice as vertical columns; multi-period = range total)
+        const classBalance = sumBalancesInSlice(classReport.childrenBalancesTotal.balances);
         classTotalMap.set(classId, classBalance);
         // Iterate through accounts in this class
-        collectAccountsFromClass(classReport, classId, selectedPeriod, accountMap);
+        collectAccountsFromClass(classReport, classId, accountMap);
     });
     // Build account rows
     const accounts = [];
@@ -166,19 +166,19 @@ function pivotSectionToHorizontal(section, classColumns, selectedPeriod, title)
 /**
  * Recursively collect account balances from a NestedClassReportV2 into accountMap.
  */
-function collectAccountsFromClass(classReport, classId, selectedPeriod, accountMap) {
+function collectAccountsFromClass(classReport, classId, accountMap) {
     // Process accounts directly on this class
     classReport.class.accounts.forEach((nestedAccount) => {
-        collectAccountsFromNestedAccount(nestedAccount, classId, selectedPeriod, accountMap);
+        collectAccountsFromNestedAccount(nestedAccount, classId, accountMap);
     });
 }
 /**
  * Recursively collect accounts from NestedAccountReport (handles sub-accounts).
  */
-function collectAccountsFromNestedAccount(nestedAccount, classId, selectedPeriod, accountMap) {
+function collectAccountsFromNestedAccount(nestedAccount, classId, accountMap) {
     const accountId = nestedAccount.account.accountId;
     const accountName = nestedAccount.account.accountName;
-    const balance = findBalanceForPeriod(nestedAccount.account.balancesInTimeframe.balances, selectedPeriod);
+    const balance = sumBalancesInSlice(nestedAccount.account.balancesInTimeframe.balances);
     if (!accountMap.has(accountId)) {
         accountMap.set(accountId, {
             accountName,
@@ -193,27 +193,22 @@ function collectAccountsFromNestedAccount(nestedAccount, classId, selectedPeriod
     accountData.classBalances.set(classId, existing + balance);
     // Process sub-accounts
     nestedAccount.children.forEach((child) => {
-        collectAccountsFromNestedAccount(child, classId, selectedPeriod, accountMap);
+        collectAccountsFromNestedAccount(child, classId, accountMap);
     });
 }
 /**
- * Find the balance amount for a specific period from a COABalance array.
- * Uses the same period match as sliceCOABalances: start must match
- * `thisPeriod` on the day, and end may equal or extend past `thisPeriod.endDate`
- * (API rows sometimes use a later exclusive boundary than the UI tick).
+ * Total amount for the current report slice. `balances` is already narrowed by
+ * `getCOABalances` / `sliceCOABalances` to the selected range; summing matches
+ * multi-period selections and avoids mismatches when `thisPeriod` does not
+ * align with a row (e.g. slice fallback) or when several period rows are shown.
  */
-function findBalanceForPeriod(balances, selectedPeriod) {
+function sumBalancesInSlice(balances) {
+    let sum = 0;
     for (const bal of balances) {
         const b = bal;
-        if (b.startDate != null && b.endDate != null) {
-            if (b.startDate.isSame(selectedPeriod.startDate, 'day') &&
-                (b.endDate.isSame(selectedPeriod.endDate, 'day') ||
-                    b.endDate.isAfter(selectedPeriod.endDate, 'day'))) {
-                return b.balance?.amount ?? 0;
-            }
-        }
+        sum += b.balance?.amount ?? 0;
     }
-    return 0;
+    return sum;
 }
 /**
  * Compute a calculated section by adding or subtracting two sets of class totals.