@zeniai/client-epic-state 4.19.84-betaVR7 → 4.19.84-betaVR8

package/lib/view/expenseAutomationView/epics/missingReceipts/bulkUploadReceiptsEpic.js

@@ -15,9 +15,13 @@ const bulkUploadReceiptsEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0,
         .postFormData(`${zeniAPI.apiEndPoints.communicationAgentMicroServiceBaseUrl}/1.0/receipts/bulk-upload`, formData)
         .pipe((0, operators_1.mergeMap)((response) => {
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
-            return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.bulkUploadReceiptsSuccess)({
-                batchId: response.data.batch_id,
-            }));
+            const batchId = String(response.data.batch_id ?? '').trim();
+            if (batchId === '') {
+                return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.bulkUploadReceiptsFailure)({
+                    error: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Bulk upload succeeded but batch_id was missing or empty.'),
+                }));
+            }
+            return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.bulkUploadReceiptsSuccess)({ batchId }));
         }
         return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.bulkUploadReceiptsFailure)({ error: response.status }));
     }), (0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.bulkUploadReceiptsFailure)({

package/lib/view/expenseAutomationView/epics/missingReceipts/watchBulkUploadBatchStatusEpic.d.ts

@@ -1,13 +1,19 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
 import { Observable } from 'rxjs';
+import { openSnackbar } from '../../../../entity/snackbar/snackbarReducer';
 import { updateTransactions } from '../../../../entity/transaction/transactionReducer';
 import { RootState } from '../../../../reducer';
 import { ZeniAPI } from '../../../../zeniAPI';
 import { bulkUploadReceiptsSuccess, clearBulkUpload, fetchBulkUploadBatchDetailsSuccess, fetchBulkUploadBatches, pusherBatchStatusUpdate, requestMissingReceiptsTabNavigation } from '../../reducers/missingReceiptsViewReducer';
-export type ActionType = ReturnType<typeof bulkUploadReceiptsSuccess> | ReturnType<typeof pusherBatchStatusUpdate> | ReturnType<typeof fetchBulkUploadBatchDetailsSuccess> | ReturnType<typeof fetchBulkUploadBatches> | ReturnType<typeof requestMissingReceiptsTabNavigation> | ReturnType<typeof updateTransactions> | ReturnType<typeof clearBulkUpload>;
+export type ActionType = ReturnType<typeof bulkUploadReceiptsSuccess> | ReturnType<typeof pusherBatchStatusUpdate> | ReturnType<typeof fetchBulkUploadBatchDetailsSuccess> | ReturnType<typeof fetchBulkUploadBatches> | ReturnType<typeof requestMissingReceiptsTabNavigation> | ReturnType<typeof updateTransactions> | ReturnType<typeof clearBulkUpload> | ReturnType<typeof openSnackbar>;
 /**
  * On Pusher batch completion: refresh batch list (then fetchMultipleBatchDetailsEpic runs),
  * and request switching to the Unmatched tab. Debounced to reduce duplicate refreshes.
  */
 export declare const pusherBatchStatusCompletionEpic: (actions$: ActionsObservable<ActionType>) => Observable<ActionType>;
+/**
+ * Fallback polling when Pusher is slow or unavailable. Network errors on a poll tick show one
+ * error snackbar per upload session (first failure only) so the user is not spammed every
+ * interval; Pusher or a later successful poll still completes the flow.
+ */
 export declare const pollBulkUploadBatchStatusEpic: (actions$: ActionsObservable<ActionType>, _state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/missingReceipts/watchBulkUploadBatchStatusEpic.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.pollBulkUploadBatchStatusEpic = exports.pusherBatchStatusCompletionEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
+const snackbarReducer_1 = require("../../../../entity/snackbar/snackbarReducer");
 const transactionReducer_1 = require("../../../../entity/transaction/transactionReducer");
 const responsePayload_1 = require("../../../../responsePayload");
 const missingReceiptsPayload_1 = require("../../payload/missingReceiptsPayload");
@@ -22,8 +23,14 @@ const pusherBatchStatusCompletionEpic = (actions$) => actions$.pipe((0, operator
     (0, missingReceiptsViewReducer_1.requestMissingReceiptsTabNavigation)({ tab: 'unmatched' }),
 ])));
 exports.pusherBatchStatusCompletionEpic = pusherBatchStatusCompletionEpic;
+/**
+ * Fallback polling when Pusher is slow or unavailable. Network errors on a poll tick show one
+ * error snackbar per upload session (first failure only) so the user is not spammed every
+ * interval; Pusher or a later successful poll still completes the flow.
+ */
 const pollBulkUploadBatchStatusEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(missingReceiptsViewReducer_1.bulkUploadReceiptsSuccess.match), (0, operators_1.mergeMap)((action) => {
     const { batchId } = action.payload;
+    let pollErrorNotified = false;
     return (0, rxjs_1.timer)(FALLBACK_FIRST_DELAY_MS, FALLBACK_POLL_INTERVAL_MS).pipe((0, operators_1.takeUntil)((0, rxjs_1.merge)(actions$.pipe((0, operators_1.filter)(missingReceiptsViewReducer_1.clearBulkUpload.match)), actions$.pipe((0, operators_1.filter)(missingReceiptsViewReducer_1.pusherBatchStatusUpdate.match), (0, operators_1.filter)((a) => a.payload.batchId === batchId)), actions$.pipe((0, operators_1.filter)(missingReceiptsViewReducer_1.fetchBulkUploadBatchDetailsSuccess.match), (0, operators_1.filter)((a) => a.payload.batchId === batchId)))), (0, operators_1.switchMap)(() => zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.communicationAgentMicroServiceBaseUrl}/1.0/batches/${batchId}`)
         .pipe((0, operators_1.mergeMap)((response) => {
@@ -42,6 +49,16 @@ const pollBulkUploadBatchStatusEpic = (actions$, _state$, zeniAPI) => actions$.p
             }
         }
         return rxjs_1.EMPTY;
-    }), (0, operators_1.catchError)(() => (0, rxjs_1.of)()))));
+    }), (0, operators_1.catchError)(() => {
+        if (!pollErrorNotified) {
+            pollErrorNotified = true;
+            return (0, rxjs_1.of)((0, snackbarReducer_1.openSnackbar)({
+                messageSection: 'receipts_upload',
+                messageText: 'failed',
+                type: 'error',
+            }));
+        }
+        return rxjs_1.EMPTY;
+    }))));
 }));
 exports.pollBulkUploadBatchStatusEpic = pollBulkUploadBatchStatusEpic;

package/lib/view/expenseAutomationView/payload/missingReceiptsPayload.d.ts

@@ -78,6 +78,17 @@ export interface BatchDetailsResponsePayload {
     };
 }
 export type BatchDetailsResponse = ZeniAPIResponse<BatchDetailsResponsePayload>;
+/**
+ * Maps batch-details API `files[].status` strings to canonical {@link BatchFile} statuses.
+ * The service may send aliases (`unmatched`, `possible_match`) or different separators; the UI
+ * only treats `un_matched` / `no_match` as work for the Unmatched tab.
+ *
+ * **Unknown values:** Any string not matched below is returned as-is (typed as
+ * {@link BatchFile} status). Callers should not assume exhaustiveness—treat unknown statuses in
+ * UI as “other” (e.g. show a generic label or fall back to a safe bucket) until the API contract
+ * adds an explicit mapping.
+ */
+export declare function normalizeBatchFileStatus(raw: string): BatchFile['status'];
 export declare function toBatchFile(payload: BatchFilePayload, filesEndPoint?: string): BatchFile;
 export declare function extractTransactionPayloadsFromBatchFiles(files: BatchFilePayload[]): SupportedTransactionPayload[];
 export declare function toBatchSummary(payload: BatchDetailsResponsePayload['summary']): BatchSummary;

package/lib/view/expenseAutomationView/payload/missingReceiptsPayload.js

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.normalizeBatchFileStatus = normalizeBatchFileStatus;
 exports.toBatchFile = toBatchFile;
 exports.extractTransactionPayloadsFromBatchFiles = extractTransactionPayloadsFromBatchFiles;
 exports.toBatchSummary = toBatchSummary;
@@ -14,6 +15,36 @@ exports.supportedTransactionPayloadToManualSearchResult = supportedTransactionPa
 const urlPayload_1 = require("../../../commonPayloadTypes/urlPayload");
 const transactionPayload_1 = require("../../../entity/transaction/payloadTypes/transactionPayload");
 // -- Converter functions --
+/**
+ * Maps batch-details API `files[].status` strings to canonical {@link BatchFile} statuses.
+ * The service may send aliases (`unmatched`, `possible_match`) or different separators; the UI
+ * only treats `un_matched` / `no_match` as work for the Unmatched tab.
+ *
+ * **Unknown values:** Any string not matched below is returned as-is (typed as
+ * {@link BatchFile} status). Callers should not assume exhaustiveness—treat unknown statuses in
+ * UI as “other” (e.g. show a generic label or fall back to a safe bucket) until the API contract
+ * adds an explicit mapping.
+ */
+function normalizeBatchFileStatus(raw) {
+    const s = raw.trim().toLowerCase().replace(/-/g, '_');
+    switch (s) {
+        case 'un_matched':
+        case 'unmatched':
+            return 'un_matched';
+        case 'no_match':
+        case 'nomatch':
+            return 'no_match';
+        case 'matched':
+            return 'matched';
+        case 'failed':
+            return 'failed';
+        case 'possible_match':
+        case 'possiblematch':
+            return 'un_matched';
+        default:
+            return raw;
+    }
+}
 function toBatchFile(payload, filesEndPoint) {
     return {
         attachmentId: payload.attachment_id,
@@ -29,7 +60,7 @@ function toBatchFile(payload, filesEndPoint) {
         filename: payload.filename,
         matchSource: payload.match_source,
         matchedTransactionId: payload.matched_transaction?.transaction_id,
-        status: payload.status,
+        status: normalizeBatchFileStatus(payload.status),
     };
 }
 function extractTransactionPayloadsFromBatchFiles(files) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "4.19.84-betaVR7",
+  "version": "4.19.84-betaVR8",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",