@zeniai/client-epic-state 4.19.77-betaAK8 → 4.19.77-betaAS2

package/lib/view/transactionDetail/epics/transactionDetailEpic.js

@@ -27,7 +27,7 @@ const fetchTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe(
     const detailKey = (0, transactionDetailState_1.getTransactionDetailKey)(transactionId);
     const transactionActions = [];
     if (cacheOverride === true) {
-        const transaction = (0, transactionSelector_1.getSupportedTransactionById)(state$.value.transactionState, transactionId.id);
+        const transaction = (0, transactionSelector_1.getSupportedTransactionById)(state$.value.transactionState, detailKey);
         transactionActions.push(...removeCompleteTransaction(transactionId, transaction));
     }
     const transactionDetail = (0, get_1.default)(state$.value.transactionDetailState.transactionDetailById, detailKey, undefined);
@@ -46,27 +46,6 @@ const fetchTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe(
             transactionActions.push((0, classListReducer_1.fetchClassList)());
         }
         transactionActions.push((0, transactionDetailReducer_1.updateTransactionDetailFetchState)(transactionId, 'In-Progress'));
-        // If the transaction already exists in the entity store (e.g. fetched by the
-        // list page), initialize local data immediately so the UI can render whatever
-        // data is available while the full detail fetch completes in parallel.
-        //
-        // The entity store canonical key is the full zeni ID (transactionId.id),
-        // which is the same key used by all list-fetch epics.
-        //
-        // DEPENDENCY: The web-components TransactionDetailPage sets effectiveIsDisabled
-        // to "disabled" while fetchState !== "Completed". This prevents any user edits
-        // between this early init and the second init dispatched on API response (below).
-        // If that guard is ever removed, user edits made against partial list data will
-        // be silently overwritten when the full detail response arrives.
-        if (cacheOverride !== true) {
-            const existingTransaction = (0, transactionSelector_1.getSupportedTransactionById)(state$.value.transactionState, transactionId.id);
-            if (existingTransaction != null) {
-                transactionActions.push((0, transactionDetailReducer_1.initializeTransactionDetailLocalData)({
-                    transactionId,
-                    vendorId: existingTransaction.vendorId,
-                }));
-            }
-        }
         const query = { transaction_type: transactionId.type };
         const getTransactionDetail$ = zeniAPI
             .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${transactionId.id}?query=${encodeURIComponent(JSON.stringify(query))}`)
@@ -74,7 +53,7 @@ const fetchTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe(
             if ((0, responsePayload_1.isSuccessResponse)(response) &&
                 response.data?.transaction?.transaction_id != null) {
                 const updateActions = [];
-                const responseTransactionId = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction);
+                const transcationId = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction);
                 const responseData = {
                     ...response.data,
                     vendors: response.data.vendors?.map((vendor) => ({
@@ -85,15 +64,13 @@ const fetchTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe(
                 if (responseData.vendors.length > 0) {
                     updateActions.push((0, vendorReducer_1.updateVendors)(responseData.vendors, 'merge'));
                 }
-                // Use the full zeni ID as the entity store key so it matches
-                // how all list-fetch epics save transactions, avoiding
-                // duplicate entries under different key formats.
-                updateActions.push((0, transactionReducer_1.updateTransaction)(responseTransactionId.id, responseData.transaction));
+                const transactionDetailKeyForResponse = (0, transactionDetailState_1.getTransactionDetailKey)(transcationId);
+                updateActions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, responseData.transaction));
                 updateActions.push((0, transactionDetailReducer_1.initializeTransactionDetailLocalData)({
-                    transactionId: responseTransactionId,
+                    transactionId: transcationId,
                     vendorId: responseData.vendors[0]?.vendor_id,
                 }));
-                updateActions.push((0, transactionDetailReducer_1.updateTransactionDetailFetchState)(responseTransactionId, 'Completed'));
+                updateActions.push((0, transactionDetailReducer_1.updateTransactionDetailFetchState)(transcationId, 'Completed'));
                 // IMPORTANT: Fetch linked transactions..
                 updateActions.push(...getAllFetchLinkedTransactionDetailActions(responseData.transaction, state$.value));
                 if (responseData.vendors.length > 0) {
@@ -129,15 +106,12 @@ function removeCompleteTransaction(transactionId, transaction) {
     const actions = [];
     actions.push((0, transactionDetailReducer_1.removeTransactionDetail)(transactionId));
     if (transaction != null) {
-        // Use transactionId.id (full zeni ID) — the canonical entity store key.
-        // getTransactionDetailKey produces a different composite key used only by
-        // transactionDetailState, not the entity store.
-        actions.push((0, transactionReducer_1.removeTransaction)(transactionId.id));
+        actions.push((0, transactionReducer_1.removeTransaction)((0, transactionDetailState_1.getTransactionDetailKey)(transactionId)));
         // remove all the linked transactions too..
         const linkedTransactions = (0, transactionDetailState_1.getAllLinkedTransactions)(transaction);
         linkedTransactions.forEach((linkedTransaction) => {
             actions.push((0, transactionDetailReducer_1.removeTransactionDetail)(linkedTransaction));
-            actions.push((0, transactionReducer_1.removeTransaction)(linkedTransaction.id));
+            actions.push((0, transactionReducer_1.removeTransaction)((0, transactionDetailState_1.getTransactionDetailKey)(linkedTransaction)));
         });
     }
     return actions;

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.d.ts

@@ -1,10 +1,10 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
-import { updateTransaction } from '../../../entity/transaction/transactionReducer';
+import { updateTransaction, updateTransactions } from '../../../entity/transaction/transactionReducer';
 import { updateVendors } from '../../../entity/vendor/vendorReducer';
 import { RootState } from '../../../reducer';
 import { ZeniAPI } from '../../../zeniAPI';
 import { syncTransactionCategorizationFromDetailSave } from '../../expenseAutomationView/reducers/transactionsViewReducer';
 import { initializeTransactionDetailLocalData, markTransactionAsNotMiscategorized, updateStatusConsolidatedSaveTransactionDetail, updateTransactionDetail, updateTransactionDetailSaveStatus, updateTransactionStateIfUpdateActionNotAllowed } from '../transactionDetailReducer';
-export type ActionType = ReturnType<typeof updateTransactionDetail> | ReturnType<typeof updateTransaction> | ReturnType<typeof updateTransactionStateIfUpdateActionNotAllowed> | ReturnType<typeof openSnackbar> | ReturnType<typeof updateTransactionDetailSaveStatus> | ReturnType<typeof updateStatusConsolidatedSaveTransactionDetail> | ReturnType<typeof initializeTransactionDetailLocalData> | ReturnType<typeof updateVendors> | ReturnType<typeof markTransactionAsNotMiscategorized> | ReturnType<typeof syncTransactionCategorizationFromDetailSave>;
+export type ActionType = ReturnType<typeof updateTransactionDetail> | ReturnType<typeof updateTransaction> | ReturnType<typeof updateTransactions> | ReturnType<typeof updateTransactionStateIfUpdateActionNotAllowed> | ReturnType<typeof openSnackbar> | ReturnType<typeof updateTransactionDetailSaveStatus> | ReturnType<typeof updateStatusConsolidatedSaveTransactionDetail> | ReturnType<typeof initializeTransactionDetailLocalData> | ReturnType<typeof updateVendors> | ReturnType<typeof markTransactionAsNotMiscategorized> | ReturnType<typeof syncTransactionCategorizationFromDetailSave>;
 export declare const updateTransactionDetailEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<ActionType>;

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -40,8 +40,7 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
         if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
             const transactionIdResp = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction);
             const transactionDetailKeyForResponse = (0, transactionDetailState_1.getTransactionDetailKey)(transactionIdResp);
-            const tranDetail = (0, get_1.default)(transactionDetailState.transactionDetailById, transactionDetailKeyForResponse, // detail key is correct for transactionDetailState
-            undefined);
+            const tranDetail = (0, get_1.default)(transactionDetailState.transactionDetailById, transactionDetailKeyForResponse, undefined);
             const tranVendorUpdates = tranDetail?.transactionDetailLocalData.vendorUpdates;
             let vendorUpdates = undefined;
             if (tranVendorUpdates?.qboId != null) {
@@ -63,7 +62,7 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
             if (response.data.vendors != null) {
                 actions.push((0, vendorReducer_1.updateVendors)(response.data.vendors, 'merge'));
             }
-            actions.push((0, transactionReducer_1.updateTransaction)(transactionIdResp.id, response.data.transaction));
+            actions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, response.data.transaction));
             actions.push((0, transactionDetailReducer_1.initializeTransactionDetailLocalData)({
                 transactionId: transactionIdResp,
                 vendorId: response.data.vendors?.[0]?.vendor_id,
@@ -112,12 +111,9 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
                     }));
                 }
             }
-            // No separate updateTransactions call needed: updateTransaction above
-            // writes under transactionIdResp.id (the full zeni ID). This is the same
-            // key all list-fetch epics use, so list selectors will read fresh data.
-            // ASSUMPTION: toTransactionID(response).id === the transaction_id value
-            // that list-fetch epics pass to updateTransactions. If these ever diverge,
-            // list rows will go stale after a detail save.
+            // Sync transaction categorization list state from detail save
+            // Updates list-keyed canonical entity so the list selector reads fresh data
+            actions.push((0, transactionReducer_1.updateTransactions)([response.data.transaction], (value) => value.transaction_id, 'merge'));
             const transactionWithCOT = (0, transactionHelper_1.getTransactionWithCOT)(transaction);
             const pendingReviewLineIds = (0, transactionCategorizationLocalDataHelper_1.getPendingReviewLineIdsFromTransaction)(transactionWithCOT);
             actions.push((0, transactionsViewReducer_1.syncTransactionCategorizationFromDetailSave)(transactionIdResp, transactionWithCOT, pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled));
@@ -136,8 +132,7 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
 exports.updateTransactionDetailEpic = updateTransactionDetailEpic;
 function preparePayload(transactionState, vendorState, transactionDetailState, transactionId, saveUpdates, cotTransactionTracking) {
     const transactionDetailKey = (0, transactionDetailState_1.getTransactionDetailKey)(transactionId);
-    const detail = (0, transactionSelector_1.getSupportedTransactionById)(transactionState, transactionId.id // entity store uses full zeni ID as canonical key
-    );
+    const detail = (0, transactionSelector_1.getSupportedTransactionById)(transactionState, transactionDetailKey);
     const tranDetail = (0, get_1.default)(transactionDetailState.transactionDetailById, transactionDetailKey, undefined);
     const tranVendorUpdates = tranDetail?.transactionDetailLocalData.vendorUpdates;
     const tranCustomerUpdates = tranDetail?.transactionDetailLocalData.customerUpdates;

package/lib/view/transactionDetail/epics/uploadMissingAttachmentSuccessEpic.js

@@ -7,13 +7,14 @@ const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
 const transactionIDPayload_1 = require("../../../entity/transaction/payloadTypes/transactionIDPayload");
 const transactionReducer_1 = require("../../../entity/transaction/transactionReducer");
 const transactionDetailReducer_1 = require("../transactionDetailReducer");
+const transactionDetailState_1 = require("../transactionDetailState");
 const uploadMissingAttachmentSuccessEpic = (actions$) => actions$.pipe((0, operators_1.filter)(transactionDetailReducer_1.uploadMissingAttachmentSuccess.match), (0, operators_1.switchMap)((action) => {
     const transactionId = (0, transactionIDPayload_1.toTransactionID)(action.payload.payload);
+    const transactionDetailKeyForResponse = (0, transactionDetailState_1.getTransactionDetailKey)(transactionId);
     return (0, rxjs_1.of)((0, snackbarReducer_1.openSnackbar)({
         messageSection: 'receipts_upload',
         messageText: 'success',
         type: 'success',
-    }), (0, transactionReducer_1.updateTransaction)(transactionId.id, // entity store uses full zeni ID as canonical key
-    action.payload.payload));
+    }), (0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, action.payload.payload));
 }));
 exports.uploadMissingAttachmentSuccessEpic = uploadMissingAttachmentSuccessEpic;

package/lib/view/transactionDetail/transactionDetailSelector.js

@@ -23,8 +23,7 @@ const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = tr
         fetchState: transactionDetail?.fetchState ?? 'Not-Started',
         error: transactionDetail?.error,
     };
-    const transaction = (0, transactionSelector_1.getSupportedTransactionById)(transactionState, transactionId.id // entity store uses full zeni ID as canonical key
-    );
+    const transaction = (0, transactionSelector_1.getSupportedTransactionById)(transactionState, detailKey);
     let linkedTransactions = [];
     if (transactionDetail?.fetchState === 'Completed' && transaction != null) {
         // IMPORTANT: filtering out unsupported linked transactions
@@ -44,9 +43,8 @@ const getTransactionDetail = (state, transactionId, fetchLinkedTransactions = tr
             linkedTransactionsFetchState.fetchState === 'Completed') {
             linkedTransactions = linkedTransactionDetails
                 .map((linkedTranDetail) => {
-                const linkedTranId = linkedTranDetail.transactionId; // eslint-disable-line @typescript-eslint/no-non-null-assertion
-                return (0, transactionSelector_1.getSupportedTransactionById)(transactionState, linkedTranId.id // entity store uses full zeni ID as canonical key
-                );
+                const key = (0, transactionDetailState_1.getTransactionDetailKey)(linkedTranDetail.transactionId); // eslint-disable-line @typescript-eslint/no-non-null-assertion
+                return (0, transactionSelector_1.getSupportedTransactionById)(transactionState, key);
             })
                 .filter((value) => {
                 if (value == null) {

package/lib/view/transactionDetail/transactionDetailState.d.ts

@@ -11,7 +11,7 @@ import { TransactionDetailLocalData } from './transactionDetailTypes';
 export declare const getTransactionDetailKey: (transactionId: TransactionID) => `${string}_bill` | `${string}_expense` | `${string}_check` | `${string}_refund` | `${string}_invoice` | `${string}_payment` | `${string}_credit_memo` | `${string}_sales_receipt` | `${string}_delayed_credit` | `${string}_delayed_charge` | `${string}_bill_payment` | `${string}_bill_payment_check` | `${string}_bill_payment_credit_card` | `${string}_vendor_credit` | `${string}_credit_card_credit` | `${string}_transfer` | `${string}_credit_card_payment` | `${string}_deposit` | `${string}_journal_entry`;
 export type TransactionDetailKey = ReturnType<typeof getTransactionDetailKey>;
 export declare const getZeniTransactionDetailKey: (transactionId: TransactionID) => `${string}_bill` | `${string}_expense` | `${string}_check` | `${string}_refund` | `${string}_invoice` | `${string}_payment` | `${string}_credit_memo` | `${string}_sales_receipt` | `${string}_delayed_credit` | `${string}_delayed_charge` | `${string}_bill_payment` | `${string}_bill_payment_check` | `${string}_bill_payment_credit_card` | `${string}_vendor_credit` | `${string}_credit_card_credit` | `${string}_transfer` | `${string}_credit_card_payment` | `${string}_deposit` | `${string}_journal_entry`;
-export type ZeniTransactionDetailKey = ReturnType<typeof getZeniTransactionDetailKey>;
+export type ZeniTransactionDetailKey = ReturnType<typeof getTransactionDetailKey>;
 export declare const getThirdPartyIdFromTransactionId: (transactionId: TransactionID) => string;
 /**
  * Returns actual QBO transaction ID.

package/lib/view/transactionDetail/transactionDetailState.js

@@ -2,22 +2,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.initialSupportedTransactionDetail = exports.getActualTransactionID = exports.getThirdPartyIdFromTransactionId = exports.getZeniTransactionDetailKey = exports.getTransactionDetailKey = void 0;
 exports.getAllLinkedTransactions = getAllLinkedTransactions;
-// TWO-KEY SYSTEM — read before touching transaction lookups:
-//
-// 1. transactionDetailState.transactionDetailById  →  keyed by getTransactionDetailKey()
-//    Format: "<qbo_id>_<type>"  (strips the "tran_<uuid>:" prefix)
-//    Used by: all transactionDetail epics/selectors for detail metadata (fetch state, local data, etc.)
-//
-// 2. transactionState.transactionById  →  keyed by transactionId.id  (full zeni ID, e.g. "tran_<uuid>:<qbo_id>")
-//    Used by: all list-fetch epics, getSupportedTransactionById, and all entity store reads/writes
-//
-// IMPORTANT: Never use getTransactionDetailKey() to look up or remove from transactionState.
-// Always use transactionId.id for the entity store.
-// Produces the transactionDetailState key: "<qbo_id>_<type>"
+// This transaction key only extracts the third party ID and uses that
+// for the ID
 const getTransactionDetailKey = (transactionId) => `${(0, exports.getActualTransactionID)(transactionId.id)}_${transactionId.type}`;
 exports.getTransactionDetailKey = getTransactionDetailKey;
-// Produces the full-zeni-ID-based key: "<tran_uuid:qbo_id>_<type>"
-// Note: this key format is not used by the entity store (which uses transactionId.id directly).
 const getZeniTransactionDetailKey = (transactionId) => `${transactionId.id}_${transactionId.type}`;
 exports.getZeniTransactionDetailKey = getZeniTransactionDetailKey;
 const getThirdPartyIdFromTransactionId = (transactionId) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "4.19.77-betaAK8",
+  "version": "4.19.77-betaAS2",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",