@zeniai/client-epic-state 4.19.46 → 4.19.48

package/lib/esm/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.js

@@ -30,6 +30,34 @@ export const removeTransactionFromTabView = (tabView, transactionId) => {
     tabView.transactionIdsWithUnsavedData =
         tabView.transactionIdsWithUnsavedData.filter((id) => id !== transactionId);
 };
+/**
+ * Filters the autoCategorized tab's line items for a transaction, retaining only
+ * lines whose categorizationStatus is still `auto_reviewed` or `auto_categorized`.
+ * If no lines are retained, removes the transaction from the tab entirely.
+ * Intended for use within Immer reducer drafts (mutates in place).
+ */
+export const filterAutoTabLineItems = (tabView, transactionId, updatedTransaction) => {
+    const localData = tabView.transactionReviewLocalDataById[transactionId];
+    if (localData == null) {
+        return;
+    }
+    const currentAutoLineIds = localData.transactionReviewLocalData.tabSpecificLineItems
+        .autoCategorized ?? [];
+    const linesById = new Map(updatedTransaction.lines?.map((l) => [l.id, l]));
+    const retainedLineIds = currentAutoLineIds.filter((lineId) => {
+        const line = linesById.get(lineId);
+        return (line?.categorizationStatus === 'auto_reviewed' ||
+            line?.categorizationStatus === 'auto_categorized');
+    });
+    if (retainedLineIds.length === 0) {
+        removeTransactionFromTabView(tabView, transactionId);
+    }
+    else {
+        localData.transactionReviewLocalData.tabSpecificLineItems = {
+            autoCategorized: retainedLineIds,
+        };
+    }
+};
 export const MAX_SELECTION_LIMIT = 5;
 export const toTransactionDetailLocalData = (transaction, selectedTab, lineItemsByTransactionIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled) => {
     const transactionLocal = {

package/lib/esm/view/expenseAutomationView/reducers/transactionsViewReducer.js

@@ -3,7 +3,7 @@ import recordGet from 'lodash/get';
 import uniq from 'lodash/uniq';
 import { toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { isVendorTransaction } from '../../../entity/transaction/stateTypes/vendorTransaction';
-import { MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
+import { MAX_SELECTION_LIMIT, checkIfAllLineItemsAreCategoryClassFilled, filterAutoTabLineItems, mergeTabSpecificLineItems, removeTransactionFromTabView, setEntityRecommendationForLineIdInLocalData, toSetAllLineItemsToCategoryClass, toTransactionDetailLocalData, } from '../helpers/transactionCategorizationLocalDataHelper';
 export const initialTransactionTabViewState = {
     saveStatus: {
         fetchState: 'Not-Started',
@@ -721,24 +721,18 @@ const expenseAutomationTransactionsView = createSlice({
                 if (!existsInReview && !existsInAuto) {
                     return;
                 }
+                // Auto tab: retain only lines still auto_reviewed or auto_categorized
+                if (existsInAuto) {
+                    filterAutoTabLineItems(autoTabView, txnId, updatedTransaction);
+                }
                 const allReviewed = pendingReviewLineIds.length === 0;
                 if (allReviewed) {
                     if (existsInReview) {
                         removeTransactionFromTabView(reviewTabView, txnId);
                     }
-                    if (existsInAuto) {
-                        removeTransactionFromTabView(autoTabView, txnId);
-                    }
                     return;
                 }
-                // Partially reviewed — auto-only: remove transaction from auto tab entirely
-                // since pending_review lines don't belong in auto tab and review_complete lines are done
-                const isAutoOnly = existsInAuto && !existsInReview;
-                if (isAutoOnly) {
-                    removeTransactionFromTabView(autoTabView, txnId);
-                    return;
-                }
-                // Review-only or both-tabs: rebuild review tab local data with pending review lines
+                // Partially reviewed: rebuild review tab local data with pending review lines
                 if (existsInReview) {
                     const newLocalData = toTransactionDetailLocalData(updatedTransaction, 'review', pendingReviewLineIds, uncategorizedIncomeExpense, isUncategorizedExpenseCategoryEnabled);
                     reviewTabView.transactionReviewLocalDataById[txnId] = {
@@ -756,10 +750,6 @@ const expenseAutomationTransactionsView = createSlice({
                     reviewTabView.transactionIdsWithUnsavedData =
                         reviewTabView.transactionIdsWithUnsavedData.filter((id) => id !== txnId);
                 }
-                // If both tabs, remove from auto tab entirely
-                if (existsInAuto) {
-                    removeTransactionFromTabView(autoTabView, txnId);
-                }
             },
         },
         backgroundRefetchReviewTab: {

package/lib/esm/view/transactionDetail/epics/markTransactionAsNotMiscategorizedEpic.js

@@ -24,20 +24,35 @@ export const markTransactionAsNotMiscategorizedEpic = (actions$, state$, zeniAPI
                 const currentTenant = getCurrentTenant(state$.value);
                 const { selectedPeriodByTenantId } = expenseAutomationViewState;
                 const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
+                const txnId = action.payload.transactionId.id;
+                const autoTabLineItems = transactionCategorizationView.autoCategorized
+                    .transactionReviewLocalDataById[txnId]
+                    ?.transactionReviewLocalData.tabSpecificLineItems
+                    .autoCategorized ?? [];
+                const hasAutoLines = autoTabLineItems.length > 0;
                 const { uiState } = transactionCategorizationView[selectedTransactionCategorizationTab];
-                const totalCountByPeriod = uiState.totalCount[toMonthYearPeriodId(selectedPeriod)];
-                const updatedTotalCount = totalCountByPeriod === 0
-                    ? totalCountByPeriod
-                    : totalCountByPeriod - 1;
-                actions.push(updateStatusForTransactionNotMiscategorizedUpdateForCategorization(selectedTransactionCategorizationTab, [action.payload.transactionId.id], [action.payload.transactionId.id], selectedPeriod, 'Completed'));
-                actions.push(removeTransactionCategorization({
-                    transactionIds: [action.payload.transactionId.id],
-                }));
-                actions.push(updateTotalCountForTransactionCategorization({
-                    selectedPeriod,
-                    selectedTab: selectedTransactionCategorizationTab,
-                    totalCount: updatedTotalCount,
-                }));
+                const removeIdsFromPeriod = selectedTransactionCategorizationTab === 'review'
+                    ? [txnId]
+                    : hasAutoLines
+                        ? []
+                        : [txnId];
+                actions.push(updateStatusForTransactionNotMiscategorizedUpdateForCategorization(selectedTransactionCategorizationTab, [txnId], removeIdsFromPeriod, selectedPeriod, 'Completed'));
+                if (!hasAutoLines) {
+                    actions.push(removeTransactionCategorization({
+                        transactionIds: [txnId],
+                    }));
+                }
+                if (removeIdsFromPeriod.length > 0) {
+                    const totalCountByPeriod = uiState.totalCount[toMonthYearPeriodId(selectedPeriod)];
+                    const updatedTotalCount = totalCountByPeriod === 0
+                        ? totalCountByPeriod
+                        : totalCountByPeriod - 1;
+                    actions.push(updateTotalCountForTransactionCategorization({
+                        selectedPeriod,
+                        selectedTab: selectedTransactionCategorizationTab,
+                        totalCount: updatedTotalCount,
+                    }));
+                }
             }
             actions.push(updateStatusConsolidatedSaveTransactionDetail({
                 transactionId: action.payload.transactionId,