@zeniai/client-epic-state 4.19.37-betaVR18 → 4.19.37-betaVR2

package/lib/view/expenseAutomationView/reducers/missingReceiptsViewReducer.js

@@ -1,14 +1,11 @@
 "use strict";
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchCompletedTransactionsFailure = exports.fetchCompletedTransactionsSuccess = exports.fetchCompletedTransactions = exports.clearManualSearchResults = exports.searchTransactionsForManualMatchFailure = exports.searchTransactionsForManualMatchSuccess = exports.searchTransactionsForManualMatch = exports.clearBulkUpload = exports.setBulkUploadSortConfig = exports.setBulkUploadCompletedSubTab = exports.setBulkUploadResultsTab = exports.confirmBulkUploadMatchFailure = exports.confirmBulkUploadMatchSuccess = exports.confirmBulkUploadMatch = exports.fetchBulkUploadBatchesFailure = exports.fetchBulkUploadBatchesSuccess = exports.fetchBulkUploadBatches = exports.fetchMoreBatchDetailsFailure = exports.fetchMoreBatchDetailsComplete = exports.fetchMoreBatchDetails = exports.setInitialBatchDetailsLoading = exports.batchDetailFetchFailed = exports.storeBatchDetails = exports.fetchBulkUploadBatchDetailsFailure = exports.fetchBulkUploadBatchDetailsSuccess = exports.fetchBulkUploadBatchDetails = exports.clearMissingReceiptsTabNavigation = exports.requestMissingReceiptsTabNavigation = exports.pusherBatchStatusUpdate = exports.bulkUploadReceiptsFailure = exports.bulkUploadReceiptsSuccess = exports.updateBulkUploadProgress = exports.bulkUploadReceipts = exports.clearExpenseAutomationMissingReceiptsView = exports.markMissingReceiptAsDone = exports.updateMissingReceiptsUIState = exports.updateMissingReceiptUploadState = exports.uploadMissingReceiptSuccess = exports.fetchMissingReceiptsFailure = exports.fetchMissingReceiptsSuccess = exports.fetchMissingReceipts = exports.initialState = exports.initialBulkUploadState = exports.getCompletedTransactionsCacheKey = void 0;
+exports.fetchCompletedTransactionsFailure = exports.fetchCompletedTransactionsSuccess = exports.fetchCompletedTransactions = exports.clearManualSearchResults = exports.searchTransactionsForManualMatchFailure = exports.searchTransactionsForManualMatchSuccess = exports.searchTransactionsForManualMatch = exports.clearBulkUpload = exports.setBulkUploadSortConfig = exports.setBulkUploadCompletedSubTab = exports.setBulkUploadResultsTab = exports.confirmBulkUploadMatchFailure = exports.confirmBulkUploadMatchSuccess = exports.confirmBulkUploadMatch = exports.fetchBulkUploadBatchesFailure = exports.fetchBulkUploadBatchesSuccess = exports.fetchBulkUploadBatches = exports.storeBatchDetails = exports.fetchBulkUploadBatchDetailsFailure = exports.fetchBulkUploadBatchDetailsSuccess = exports.fetchBulkUploadBatchDetails = exports.pusherBatchStatusUpdate = exports.updateBulkUploadBatchStatus = exports.bulkUploadReceiptsFailure = exports.bulkUploadReceiptsSuccess = exports.updateBulkUploadProgress = exports.bulkUploadReceipts = exports.clearExpenseAutomationMissingReceiptsView = exports.markMissingReceiptAsDone = exports.updateMissingReceiptsUIState = exports.updateMissingReceiptUploadState = exports.uploadMissingReceiptSuccess = exports.fetchMissingReceiptsFailure = exports.fetchMissingReceiptsSuccess = exports.fetchMissingReceipts = exports.initialState = exports.initialBulkUploadState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
-const getCompletedTransactionsCacheKey = (periodId, sortKey, sortOrder, subTab) => `completed-${subTab}-${sortKey}-${sortOrder === 'ascending' ? 'asc' : 'desc'}-${periodId}`;
-exports.getCompletedTransactionsCacheKey = getCompletedTransactionsCacheKey;
 exports.initialBulkUploadState = {
     batchDetailsById: {},
-    batchDetailsPaginationState: { fetchState: 'Not-Started', error: undefined },
     batchListByPeriod: {},
     batchListFetchState: { fetchState: 'Not-Started', error: undefined },
     batchStatusById: {},
@@ -17,7 +14,6 @@ exports.initialBulkUploadState = {
     confirmMatchStatus: { fetchState: 'Not-Started', error: undefined },
     currentBatchId: undefined,
     currentResultsTab: 'unmatched',
-    failedBatchDetailIds: [],
     manualSearch: {
         fetchState: { fetchState: 'Not-Started', error: undefined },
         results: [],
@@ -31,7 +27,6 @@ exports.initialBulkUploadState = {
 };
 exports.initialState = {
     bulkUpload: exports.initialBulkUploadState,
-    pendingMissingReceiptsTabNavigation: null,
     uploadReceiptStatusById: {},
     refreshStatus: {
         fetchState: 'Not-Started',
@@ -184,15 +179,13 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
             };
             draft.bulkUpload.phase = 'idle';
         },
-        pusherBatchStatusUpdate(draft, action) {
+        updateBulkUploadBatchStatus(draft, action) {
             const batchStatus = action.payload;
             draft.bulkUpload.batchStatusById[batchStatus.batchId] = batchStatus;
         },
-        requestMissingReceiptsTabNavigation(draft, action) {
-            draft.pendingMissingReceiptsTabNavigation = action.payload.tab;
-        },
-        clearMissingReceiptsTabNavigation(draft) {
-            draft.pendingMissingReceiptsTabNavigation = null;
+        pusherBatchStatusUpdate(draft, action) {
+            const batchStatus = action.payload;
+            draft.bulkUpload.batchStatusById[batchStatus.batchId] = batchStatus;
         },
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         fetchBulkUploadBatchDetails(_draft) {
@@ -211,36 +204,6 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
             const details = action.payload;
             draft.bulkUpload.batchDetailsById[details.batchId] = details;
         },
-        batchDetailFetchFailed(draft, action) {
-            const { batchId } = action.payload;
-            if (!draft.bulkUpload.failedBatchDetailIds.includes(batchId)) {
-                draft.bulkUpload.failedBatchDetailIds.push(batchId);
-            }
-        },
-        setInitialBatchDetailsLoading(draft) {
-            draft.bulkUpload.batchDetailsPaginationState = {
-                fetchState: 'In-Progress',
-                error: undefined,
-            };
-        },
-        fetchMoreBatchDetails(_draft) {
-            _draft.bulkUpload.batchDetailsPaginationState = {
-                fetchState: 'In-Progress',
-                error: undefined,
-            };
-        },
-        fetchMoreBatchDetailsComplete(draft) {
-            draft.bulkUpload.batchDetailsPaginationState = {
-                fetchState: 'Completed',
-                error: undefined,
-            };
-        },
-        fetchMoreBatchDetailsFailure(draft, action) {
-            draft.bulkUpload.batchDetailsPaginationState = {
-                fetchState: 'Error',
-                error: action.payload.error,
-            };
-        },
         fetchBulkUploadBatches: {
             // eslint-disable-next-line @typescript-eslint/no-unused-vars
             reducer(draft, _action) {
@@ -314,6 +277,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
         },
         setBulkUploadCompletedSubTab(draft, action) {
             draft.bulkUpload.completedSubTab = action.payload;
+            draft.bulkUpload.completedTransactionsByPeriod = {};
         },
         setBulkUploadSortConfig(draft, action) {
             draft.bulkUpload.sortKey = action.payload.sortKey;
@@ -321,7 +285,6 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
         },
         clearBulkUpload(draft) {
             Object.assign(draft.bulkUpload, exports.initialBulkUploadState);
-            draft.pendingMissingReceiptsTabNavigation = null;
         },
         searchTransactionsForManualMatch: {
             reducer(draft, action) {
@@ -369,16 +332,15 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
                     }
                 }
             },
-            prepare(pageToken, cacheOverride) {
-                return { payload: { pageToken, cacheOverride } };
+            prepare(pageToken) {
+                return { payload: { pageToken } };
             },
         },
         fetchCompletedTransactionsSuccess(draft, action) {
             const { transactionIds, nextPageToken, totalCount, selectedPeriod, isInitialLoad } = action.payload;
             const periodId = (0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod);
-            const cacheKey = (0, exports.getCompletedTransactionsCacheKey)(periodId, draft.bulkUpload.sortKey, draft.bulkUpload.sortOrder, draft.bulkUpload.completedSubTab);
             if (isInitialLoad) {
-                draft.bulkUpload.completedTransactionsByPeriod[cacheKey] = {
+                draft.bulkUpload.completedTransactionsByPeriod[periodId] = {
                     transactionIds,
                     nextPageToken,
                     totalCount,
@@ -386,7 +348,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
                 };
             }
             else {
-                const existing = draft.bulkUpload.completedTransactionsByPeriod[cacheKey];
+                const existing = draft.bulkUpload.completedTransactionsByPeriod[periodId];
                 if (existing != null) {
                     existing.transactionIds.push(...transactionIds);
                     existing.nextPageToken = nextPageToken;
@@ -394,7 +356,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
                     existing.fetchState = { fetchState: 'Completed', error: undefined };
                 }
                 else {
-                    draft.bulkUpload.completedTransactionsByPeriod[cacheKey] = {
+                    draft.bulkUpload.completedTransactionsByPeriod[periodId] = {
                         transactionIds,
                         nextPageToken,
                         totalCount,
@@ -405,8 +367,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
         },
         fetchCompletedTransactionsFailure(draft, action) {
             const periodId = (0, timePeriod_1.toMonthYearPeriodId)(action.payload.selectedPeriod);
-            const cacheKey = (0, exports.getCompletedTransactionsCacheKey)(periodId, draft.bulkUpload.sortKey, draft.bulkUpload.sortOrder, draft.bulkUpload.completedSubTab);
-            const existing = draft.bulkUpload.completedTransactionsByPeriod[cacheKey];
+            const existing = draft.bulkUpload.completedTransactionsByPeriod[periodId];
             if (existing != null) {
                 existing.fetchState = {
                     fetchState: 'Error',
@@ -414,7 +375,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
                 };
             }
             else {
-                draft.bulkUpload.completedTransactionsByPeriod[cacheKey] = {
+                draft.bulkUpload.completedTransactionsByPeriod[periodId] = {
                     fetchState: { fetchState: 'Error', error: action.payload.error },
                     nextPageToken: null,
                     totalCount: 0,
@@ -426,7 +387,7 @@ const expenseAutomationMissingReceiptsView = (0, toolkit_1.createSlice)({
 });
 _a = expenseAutomationMissingReceiptsView.actions, exports.fetchMissingReceipts = _a.fetchMissingReceipts, exports.fetchMissingReceiptsSuccess = _a.fetchMissingReceiptsSuccess, exports.fetchMissingReceiptsFailure = _a.fetchMissingReceiptsFailure, exports.uploadMissingReceiptSuccess = _a.uploadMissingReceiptSuccess, exports.updateMissingReceiptUploadState = _a.updateMissingReceiptUploadState, exports.updateMissingReceiptsUIState = _a.updateMissingReceiptsUIState, exports.markMissingReceiptAsDone = _a.markMissingReceiptAsDone, exports.clearExpenseAutomationMissingReceiptsView = _a.clearExpenseAutomationMissingReceiptsView, 
 // Bulk Upload
-exports.bulkUploadReceipts = _a.bulkUploadReceipts, exports.updateBulkUploadProgress = _a.updateBulkUploadProgress, exports.bulkUploadReceiptsSuccess = _a.bulkUploadReceiptsSuccess, exports.bulkUploadReceiptsFailure = _a.bulkUploadReceiptsFailure, exports.pusherBatchStatusUpdate = _a.pusherBatchStatusUpdate, exports.requestMissingReceiptsTabNavigation = _a.requestMissingReceiptsTabNavigation, exports.clearMissingReceiptsTabNavigation = _a.clearMissingReceiptsTabNavigation, exports.fetchBulkUploadBatchDetails = _a.fetchBulkUploadBatchDetails, exports.fetchBulkUploadBatchDetailsSuccess = _a.fetchBulkUploadBatchDetailsSuccess, exports.fetchBulkUploadBatchDetailsFailure = _a.fetchBulkUploadBatchDetailsFailure, exports.storeBatchDetails = _a.storeBatchDetails, exports.batchDetailFetchFailed = _a.batchDetailFetchFailed, exports.setInitialBatchDetailsLoading = _a.setInitialBatchDetailsLoading, exports.fetchMoreBatchDetails = _a.fetchMoreBatchDetails, exports.fetchMoreBatchDetailsComplete = _a.fetchMoreBatchDetailsComplete, exports.fetchMoreBatchDetailsFailure = _a.fetchMoreBatchDetailsFailure, exports.fetchBulkUploadBatches = _a.fetchBulkUploadBatches, exports.fetchBulkUploadBatchesSuccess = _a.fetchBulkUploadBatchesSuccess, exports.fetchBulkUploadBatchesFailure = _a.fetchBulkUploadBatchesFailure, exports.confirmBulkUploadMatch = _a.confirmBulkUploadMatch, exports.confirmBulkUploadMatchSuccess = _a.confirmBulkUploadMatchSuccess, exports.confirmBulkUploadMatchFailure = _a.confirmBulkUploadMatchFailure, exports.setBulkUploadResultsTab = _a.setBulkUploadResultsTab, exports.setBulkUploadCompletedSubTab = _a.setBulkUploadCompletedSubTab, exports.setBulkUploadSortConfig = _a.setBulkUploadSortConfig, exports.clearBulkUpload = _a.clearBulkUpload, exports.searchTransactionsForManualMatch = _a.searchTransactionsForManualMatch, exports.searchTransactionsForManualMatchSuccess = _a.searchTransactionsForManualMatchSuccess, exports.searchTransactionsForManualMatchFailure = _a.searchTransactionsForManualMatchFailure, exports.clearManualSearchResults = _a.clearManualSearchResults, 
+exports.bulkUploadReceipts = _a.bulkUploadReceipts, exports.updateBulkUploadProgress = _a.updateBulkUploadProgress, exports.bulkUploadReceiptsSuccess = _a.bulkUploadReceiptsSuccess, exports.bulkUploadReceiptsFailure = _a.bulkUploadReceiptsFailure, exports.updateBulkUploadBatchStatus = _a.updateBulkUploadBatchStatus, exports.pusherBatchStatusUpdate = _a.pusherBatchStatusUpdate, exports.fetchBulkUploadBatchDetails = _a.fetchBulkUploadBatchDetails, exports.fetchBulkUploadBatchDetailsSuccess = _a.fetchBulkUploadBatchDetailsSuccess, exports.fetchBulkUploadBatchDetailsFailure = _a.fetchBulkUploadBatchDetailsFailure, exports.storeBatchDetails = _a.storeBatchDetails, exports.fetchBulkUploadBatches = _a.fetchBulkUploadBatches, exports.fetchBulkUploadBatchesSuccess = _a.fetchBulkUploadBatchesSuccess, exports.fetchBulkUploadBatchesFailure = _a.fetchBulkUploadBatchesFailure, exports.confirmBulkUploadMatch = _a.confirmBulkUploadMatch, exports.confirmBulkUploadMatchSuccess = _a.confirmBulkUploadMatchSuccess, exports.confirmBulkUploadMatchFailure = _a.confirmBulkUploadMatchFailure, exports.setBulkUploadResultsTab = _a.setBulkUploadResultsTab, exports.setBulkUploadCompletedSubTab = _a.setBulkUploadCompletedSubTab, exports.setBulkUploadSortConfig = _a.setBulkUploadSortConfig, exports.clearBulkUpload = _a.clearBulkUpload, exports.searchTransactionsForManualMatch = _a.searchTransactionsForManualMatch, exports.searchTransactionsForManualMatchSuccess = _a.searchTransactionsForManualMatchSuccess, exports.searchTransactionsForManualMatchFailure = _a.searchTransactionsForManualMatchFailure, exports.clearManualSearchResults = _a.clearManualSearchResults, 
 // Completed Transactions
 exports.fetchCompletedTransactions = _a.fetchCompletedTransactions, exports.fetchCompletedTransactionsSuccess = _a.fetchCompletedTransactionsSuccess, exports.fetchCompletedTransactionsFailure = _a.fetchCompletedTransactionsFailure;
 exports.default = expenseAutomationMissingReceiptsView.reducer;

package/lib/view/expenseAutomationView/selectorTypes/missingReceiptsSelectorTypes.d.ts

@@ -15,11 +15,9 @@ export interface ResolvedCandidate {
 }
 export interface ResolvedBatchFile {
     attachmentId: ID;
-    batchId: ID;
-    fileDownloadUrl: string | null;
     fileId: ID;
     filename: string;
-    filePreviewUrl: string | null;
+    filePreviewUrl: string;
     status: BatchFileStatus;
     candidates?: ResolvedCandidate[];
     matchedTransaction?: SupportedTransaction;
@@ -27,7 +25,6 @@ export interface ResolvedBatchFile {
 }
 export interface BulkUploadSelectorData {
     batchDetails: ResolvedBatchDetails | undefined;
-    batchDetailsPaginationState: FetchStateAndError;
     batchList: BatchListItem[];
     batchListFetchState: FetchStateAndError;
     batchStatus: BatchStatus | undefined;
@@ -35,7 +32,6 @@ export interface BulkUploadSelectorData {
     completedTransactions: CompletedTransactionsSelectorData;
     confirmMatchStatus: FetchStateAndError;
     currentResultsTab: BulkUploadResultsTab;
-    hasMoreBatchDetails: boolean;
     manualSearch: ManualSearchState;
     matchedFiles: ResolvedBatchFile[];
     pastBatches: BatchListItem[];
@@ -68,8 +64,6 @@ export interface ResolvedBatchDetails {
 export interface ExpenseAutomationMissingReceiptsViewSelector extends SelectorView {
     bulkUpload: BulkUploadSelectorData;
     completionStatus: CompletionStatusType;
-    /** When set, UI should switch bulk-upload sub-tab once (e.g. Unmatched on batch completion). */
-    pendingMissingReceiptsTabNavigation: BulkUploadResultsTab | null;
     refreshStatus: FetchStateAndError;
     transactions: SupportedTransaction[];
     uiState: MissingReceiptsViewUIState;

package/lib/view/expenseAutomationView/selectors/missingReceiptsSelector.js

@@ -9,8 +9,6 @@ const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const transactionSelector_1 = require("../../../entity/transaction/transactionSelector");
 const expenseAutomationViewSelectorTypes_1 = require("../selectorTypes/expenseAutomationViewSelectorTypes");
-const missingReceiptsPayload_1 = require("../payload/missingReceiptsPayload");
-const missingReceiptsViewReducer_1 = require("../reducers/missingReceiptsViewReducer");
 function getExpenseAutomationMissingReceiptsView(state) {
     const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, } = state;
     const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state);
@@ -55,34 +53,14 @@ function getExpenseAutomationMissingReceiptsView(state) {
     const completionStatus = missingReceiptsCompletionStatus != null
         ? missingReceiptsCompletionStatus
         : 'incomplete';
-    const { bulkUpload, pendingMissingReceiptsTabNavigation, } = expenseAutomationMissingReceiptsViewState;
+    const { bulkUpload } = expenseAutomationMissingReceiptsViewState;
     const currentBatchStatus = bulkUpload.currentBatchId != null
         ? bulkUpload.batchStatusById[bulkUpload.currentBatchId]
         : undefined;
-    const batchList = monthYearPeriodId != null
-        ? bulkUpload.batchListByPeriod[monthYearPeriodId] ?? []
-        : [];
-    /** API returns newest-first (`sort_order: desc`); primary batch uses oldest-first order. */
-    const batchListChronological = (0, orderBy_1.default)(batchList, (b) => new Date(b.createdAt).valueOf(), 'asc');
-    /**
-     * Primary "Unmatched" batch = first completed batch in chronological order, preferring the
-     * first batch that still has un_matched/no_match work when any completed batch has such work.
-     * Batches without details yet: wait if the list row still reports unmatched work; otherwise skip
-     * so we do not block the whole tab while older rows are not fetched yet.
-     */
-    const primaryBatchIdFromDetailsOrder = getPrimaryBatchIdFromBatchListOrder(batchListChronological, bulkUpload.batchDetailsById, bulkUpload.failedBatchDetailIds);
-    /** During upload/matching, the in-flight batch may not appear in batchList yet — prefer currentBatchId. */
-    const unmatchedSectionBatchId = bulkUpload.phase === 'matching' || bulkUpload.phase === 'uploading'
-        ? bulkUpload.currentBatchId ?? primaryBatchIdFromDetailsOrder
-        : primaryBatchIdFromDetailsOrder;
-    const completedBatchesInApiOrder = batchList.filter((b) => (0, missingReceiptsPayload_1.isBatchListStatusCompleted)(b.status));
-    const currentBatchDetails = unmatchedSectionBatchId != null
-        ? bulkUpload.batchDetailsById[unmatchedSectionBatchId]
+    const currentBatchDetails = bulkUpload.currentBatchId != null
+        ? bulkUpload.batchDetailsById[bulkUpload.currentBatchId]
         : undefined;
-    const resolvedFiles = currentBatchDetails?.files.map((file) => resolveBatchFile(file, currentBatchDetails.batchId, transactionState));
-    const failedIds = new Set(bulkUpload.failedBatchDetailIds);
-    const hasMoreBatchDetails = completedBatchesInApiOrder.some((b) => bulkUpload.batchDetailsById[b.batchId] == null &&
-        !failedIds.has(b.batchId));
+    const resolvedFiles = currentBatchDetails?.files.map((file) => resolveBatchFile(file, transactionState));
     const getSortValue = (file) => {
         const t = file.matchedTransaction;
         if (t == null) {
@@ -120,14 +98,11 @@ function getExpenseAutomationMissingReceiptsView(state) {
                 : 0,
         }
         : { total: 0, processed: 0, percentage: 0 };
+    const batchList = monthYearPeriodId != null
+        ? bulkUpload.batchListByPeriod[monthYearPeriodId] ?? []
+        : [];
     const batchListFetchState = bulkUpload.batchListFetchState;
-    /**
-     * When primary batch is not resolved yet, still aggregate unmatched files from every batch
-     * that has details loaded (otherwise past is empty and receipts vanish from the UI).
-     */
-    const pastBatches = unmatchedSectionBatchId != null
-        ? batchList.filter((b) => b.batchId !== unmatchedSectionBatchId)
-        : batchList;
+    const pastBatches = batchList.filter((b) => b.batchId !== bulkUpload.currentBatchId);
     const pastUnmatchedFiles = pastBatches.flatMap((b) => {
         const details = bulkUpload.batchDetailsById[b.batchId];
         if (details == null) {
@@ -135,13 +110,10 @@ function getExpenseAutomationMissingReceiptsView(state) {
         }
         return details.files
             .filter((f) => f.status === 'un_matched' || f.status === 'no_match')
-            .map((f) => resolveBatchFile(f, b.batchId, transactionState));
+            .map((f) => resolveBatchFile(f, transactionState));
     });
-    const completedTransactionsCacheKey = monthYearPeriodId != null
-        ? (0, missingReceiptsViewReducer_1.getCompletedTransactionsCacheKey)(monthYearPeriodId, bulkUpload.sortKey, bulkUpload.sortOrder, bulkUpload.completedSubTab)
-        : undefined;
-    const completedTransactionsForPeriod = completedTransactionsCacheKey != null
-        ? bulkUpload.completedTransactionsByPeriod[completedTransactionsCacheKey]
+    const completedTransactionsForPeriod = monthYearPeriodId != null
+        ? bulkUpload.completedTransactionsByPeriod[monthYearPeriodId]
         : undefined;
     const completedTransactionIds = completedTransactionsForPeriod?.transactionIds ?? [];
     const resolvedCompletedTransactions = (0, transactionSelector_1.getSupportedTransactionsByIds)(transactionState, completedTransactionIds);
@@ -162,7 +134,6 @@ function getExpenseAutomationMissingReceiptsView(state) {
         refreshStatus,
         transactions: sortedTransactions,
         completionStatus,
-        pendingMissingReceiptsTabNavigation: pendingMissingReceiptsTabNavigation ?? null,
         bulkUpload: {
             phase: bulkUpload.phase,
             uploadStatus: bulkUpload.uploadStatus,
@@ -189,68 +160,12 @@ function getExpenseAutomationMissingReceiptsView(state) {
             pastBatches,
             pastUnmatchedFiles,
             confirmMatchStatus: bulkUpload.confirmMatchStatus,
-            hasMoreBatchDetails,
-            batchDetailsPaginationState: bulkUpload.batchDetailsPaginationState,
             manualSearch: bulkUpload.manualSearch,
             uploadProgress: bulkUpload.uploadProgress,
         },
     };
 }
-function batchDetailsHasUnmatchedWork(details) {
-    return details.files.some((f) => f.status === 'un_matched' || f.status === 'no_match');
-}
-/** List row summary before batch details load — aligns with unmatched / possible-match work. */
-function batchListItemHasUnmatchedWork(batch) {
-    return batch.noMatchCount > 0 || batch.possibleMatchesCount > 0;
-}
-/**
- * `batchList` must be in chronological order (oldest first). Picks the primary batch for the
- * top "Unmatched" section. Skips failed detail fetches.
- *
- * If details are not loaded for an older batch but the list row reports no unmatched work, we
- * skip that batch so newer batches with loaded details can be primary (avoids an empty tab when
- * the first fetch page only loaded newer batches). If the list reports unmatched work but details
- * are still loading, we wait (undefined) so primary order stays correct once details arrive.
- */
-function getPrimaryBatchIdFromBatchListOrder(batchListChronological, batchDetailsById, failedBatchDetailIds) {
-    const failedIds = new Set(failedBatchDetailIds);
-    const anyCompletedBatchHasUnmatchedWork = batchListChronological.some((b) => {
-        if (failedIds.has(b.batchId)) {
-            return false;
-        }
-        const d = batchDetailsById[b.batchId];
-        if (d != null &&
-            d.status === 'completed' &&
-            batchDetailsHasUnmatchedWork(d)) {
-            return true;
-        }
-        return d == null && batchListItemHasUnmatchedWork(b);
-    });
-    for (const batch of batchListChronological) {
-        if (failedIds.has(batch.batchId)) {
-            continue;
-        }
-        const details = batchDetailsById[batch.batchId];
-        if (details == null) {
-            if (batchListItemHasUnmatchedWork(batch)) {
-                return undefined;
-            }
-            continue;
-        }
-        if (details.status !== 'completed') {
-            continue;
-        }
-        if (anyCompletedBatchHasUnmatchedWork) {
-            if (batchDetailsHasUnmatchedWork(details)) {
-                return batch.batchId;
-            }
-            continue;
-        }
-        return batch.batchId;
-    }
-    return undefined;
-}
-function resolveBatchFile(file, batchId, transactionState) {
+function resolveBatchFile(file, transactionState) {
     const matchedTransaction = file.matchedTransactionId != null
         ? (0, transactionSelector_1.getSupportedTransactionById)(transactionState, file.matchedTransactionId)
         : undefined;
@@ -264,8 +179,6 @@ function resolveBatchFile(file, batchId, transactionState) {
         .filter((c) => c != null);
     return {
         attachmentId: file.attachmentId,
-        batchId,
-        fileDownloadUrl: file.fileDownloadUrl,
         fileId: file.fileId,
         filename: file.filename,
         filePreviewUrl: file.filePreviewUrl,

package/lib/view/expenseAutomationView/types/missingReceiptsViewState.d.ts

@@ -36,10 +36,9 @@ export interface MatchCandidate {
 }
 export interface BatchFile {
     attachmentId: ID;
-    fileDownloadUrl: string | null;
     fileId: ID;
     filename: string;
-    filePreviewUrl: string | null;
+    filePreviewUrl: string;
     status: BatchFileStatus;
     candidates?: CandidateRef[];
     matchedTransactionId?: ID;
@@ -101,15 +100,13 @@ export interface CompletedTransactionsState {
 }
 export interface BulkUploadState {
     batchDetailsById: Record<ID, BatchDetails>;
-    batchDetailsPaginationState: FetchStateAndError;
     batchListByPeriod: Record<MonthYearPeriodId, BatchListItem[]>;
     batchListFetchState: FetchStateAndError;
     batchStatusById: Record<ID, BatchStatus>;
     completedSubTab: CompletedSubTab;
-    completedTransactionsByPeriod: Record<string, CompletedTransactionsState>;
+    completedTransactionsByPeriod: Record<MonthYearPeriodId, CompletedTransactionsState>;
     confirmMatchStatus: FetchStateAndError;
     currentResultsTab: BulkUploadResultsTab;
-    failedBatchDetailIds: ID[];
     manualSearch: ManualSearchState;
     phase: BulkUploadPhase;
     sortKey: BulkUploadSortKey;
@@ -120,11 +117,6 @@ export interface BulkUploadState {
 }
 export interface MissingReceiptsViewState extends FetchedState {
     bulkUpload: BulkUploadState;
-    /**
-     * When set, the app shell should switch the Missing Receipts sub-tab (e.g. to Unmatched)
-     * once, then clear via `clearMissingReceiptsTabNavigation`.
-     */
-    pendingMissingReceiptsTabNavigation: BulkUploadResultsTab | null;
     refreshStatus: FetchStateAndError;
     transactionIdsBySelectedPeriod: Record<MonthYearPeriodId, ID[]>;
     uiState: MissingReceiptsViewUIState;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "4.19.37-betaVR18",
+  "version": "4.19.37-betaVR2",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",
@@ -111,7 +111,7 @@
     "find-dead-code": "ts-prune | grep -v '(used in module)'",
     "find-unused-exports": "ts-unused-exports ./tsconfig.json",
     "circular-dependency": "npx madge --circular --extensions ts ./src",
-    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\"",
+    "build": "concurrently --kill-others-on-fail --handle-input \"echo 'Running ESLint...' && eslint . --ext .js,.jsx,.ts,.tsx\" \"echo 'TypeScript build in progress...' && time tsc && echo 'ESM build...' && tsc -p tsconfig.esm.json\" \"echo 'Running tests and typecheck...' && pnpm test\" && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "only-build": "eslint . --ext .js,.jsx,.ts,.tsx && time tsc && tsc -p tsconfig.esm.json && rimraf \"lib/**/__mocks__\" \"lib/**/__testHelpers__\"",
     "format": "prettier --write --ignore-unknown \"src/**/*\" && pnpm lint",
     "format-watch": "(git diff --name-only --diff-filter=ACM && git ls-files --others --exclude-standard) | grep -E '\\.(ts|tsx)$' | xargs prettier --write",

package/lib/esm/view/expenseAutomationView/epics/missingReceipts/fetchMoreBatchDetailsEpic.js

@@ -1,36 +0,0 @@
-import orderBy from 'lodash/orderBy';
-import { concat, of } from 'rxjs';
-import { catchError, exhaustMap, filter } from 'rxjs/operators';
-import { toMonthYearPeriodId } from '../../../../commonStateTypes/timePeriod';
-import { getCurrentTenant } from '../../../../entity/tenant/tenantSelector';
-import { createZeniAPIStatus } from '../../../../responsePayload';
-import { isBatchListStatusCompleted } from '../../payload/missingReceiptsPayload';
-import { fetchMoreBatchDetails, fetchMoreBatchDetailsComplete, fetchMoreBatchDetailsFailure, } from '../../reducers/missingReceiptsViewReducer';
-import { fetchBatchDetailsByIds } from './fetchMultipleBatchDetailsEpic';
-const MORE_BATCH_PAGE_SIZE = 4;
-export const fetchMoreBatchDetailsEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchMoreBatchDetails.match), 
-/** One page at a time — avoids duplicate loads if IO + scroll fallback both fire. */
-exhaustMap(() => {
-    const state = state$.value;
-    const { expenseAutomationViewState: { selectedPeriodByTenantId }, expenseAutomationMissingReceiptsViewState: { bulkUpload }, } = state;
-    const currentTenant = getCurrentTenant(state);
-    const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
-    if (selectedPeriod == null) {
-        return of(fetchMoreBatchDetailsComplete());
-    }
-    const periodId = toMonthYearPeriodId(selectedPeriod);
-    const batchList = bulkUpload.batchListByPeriod[periodId] ?? [];
-    const failedIds = new Set(bulkUpload.failedBatchDetailIds);
-    const unfetchedBatches = batchList.filter((batch) => isBatchListStatusCompleted(batch.status) &&
-        bulkUpload.batchDetailsById[batch.batchId] == null &&
-        !failedIds.has(batch.batchId));
-    const unfetchedBatchIds = orderBy(unfetchedBatches, (b) => new Date(b.createdAt).valueOf(), 'asc').map((batch) => batch.batchId);
-    if (unfetchedBatchIds.length === 0) {
-        return of(fetchMoreBatchDetailsComplete());
-    }
-    const nextPage = unfetchedBatchIds.slice(0, MORE_BATCH_PAGE_SIZE);
-    return concat(fetchBatchDetailsByIds(nextPage, zeniAPI), of(fetchMoreBatchDetailsComplete())).pipe(catchError((error) => of(fetchMoreBatchDetailsFailure({
-        error: createZeniAPIStatus('Unexpected Error', 'Fetch more batch details errored out: ' +
-            JSON.stringify(error)),
-    }))));
-}));

package/lib/view/expenseAutomationView/epics/missingReceipts/fetchMoreBatchDetailsEpic.d.ts

@@ -1,8 +0,0 @@
-import { ActionsObservable, StateObservable } from 'redux-observable';
-import { Observable } from 'rxjs';
-import { updateTransactions } from '../../../../entity/transaction/transactionReducer';
-import { RootState } from '../../../../reducer';
-import { ZeniAPI } from '../../../../zeniAPI';
-import { batchDetailFetchFailed, fetchBulkUploadBatchesSuccess, fetchMoreBatchDetails, fetchMoreBatchDetailsComplete, fetchMoreBatchDetailsFailure, setInitialBatchDetailsLoading, storeBatchDetails } from '../../reducers/missingReceiptsViewReducer';
-export type ActionType = ReturnType<typeof fetchBulkUploadBatchesSuccess> | ReturnType<typeof fetchMoreBatchDetails> | ReturnType<typeof fetchMoreBatchDetailsComplete> | ReturnType<typeof fetchMoreBatchDetailsFailure> | ReturnType<typeof batchDetailFetchFailed> | ReturnType<typeof setInitialBatchDetailsLoading> | ReturnType<typeof storeBatchDetails> | ReturnType<typeof updateTransactions>;
-export declare const fetchMoreBatchDetailsEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => Observable<ActionType>;

package/lib/view/expenseAutomationView/epics/missingReceipts/fetchMoreBatchDetailsEpic.js

@@ -1,43 +0,0 @@
-"use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.fetchMoreBatchDetailsEpic = void 0;
-const orderBy_1 = __importDefault(require("lodash/orderBy"));
-const rxjs_1 = require("rxjs");
-const operators_1 = require("rxjs/operators");
-const timePeriod_1 = require("../../../../commonStateTypes/timePeriod");
-const tenantSelector_1 = require("../../../../entity/tenant/tenantSelector");
-const responsePayload_1 = require("../../../../responsePayload");
-const missingReceiptsPayload_1 = require("../../payload/missingReceiptsPayload");
-const missingReceiptsViewReducer_1 = require("../../reducers/missingReceiptsViewReducer");
-const fetchMultipleBatchDetailsEpic_1 = require("./fetchMultipleBatchDetailsEpic");
-const MORE_BATCH_PAGE_SIZE = 4;
-const fetchMoreBatchDetailsEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(missingReceiptsViewReducer_1.fetchMoreBatchDetails.match), 
-/** One page at a time — avoids duplicate loads if IO + scroll fallback both fire. */
-(0, operators_1.exhaustMap)(() => {
-    const state = state$.value;
-    const { expenseAutomationViewState: { selectedPeriodByTenantId }, expenseAutomationMissingReceiptsViewState: { bulkUpload }, } = state;
-    const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state);
-    const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
-    if (selectedPeriod == null) {
-        return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.fetchMoreBatchDetailsComplete)());
-    }
-    const periodId = (0, timePeriod_1.toMonthYearPeriodId)(selectedPeriod);
-    const batchList = bulkUpload.batchListByPeriod[periodId] ?? [];
-    const failedIds = new Set(bulkUpload.failedBatchDetailIds);
-    const unfetchedBatches = batchList.filter((batch) => (0, missingReceiptsPayload_1.isBatchListStatusCompleted)(batch.status) &&
-        bulkUpload.batchDetailsById[batch.batchId] == null &&
-        !failedIds.has(batch.batchId));
-    const unfetchedBatchIds = (0, orderBy_1.default)(unfetchedBatches, (b) => new Date(b.createdAt).valueOf(), 'asc').map((batch) => batch.batchId);
-    if (unfetchedBatchIds.length === 0) {
-        return (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.fetchMoreBatchDetailsComplete)());
-    }
-    const nextPage = unfetchedBatchIds.slice(0, MORE_BATCH_PAGE_SIZE);
-    return (0, rxjs_1.concat)((0, fetchMultipleBatchDetailsEpic_1.fetchBatchDetailsByIds)(nextPage, zeniAPI), (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.fetchMoreBatchDetailsComplete)())).pipe((0, operators_1.catchError)((error) => (0, rxjs_1.of)((0, missingReceiptsViewReducer_1.fetchMoreBatchDetailsFailure)({
-        error: (0, responsePayload_1.createZeniAPIStatus)('Unexpected Error', 'Fetch more batch details errored out: ' +
-            JSON.stringify(error)),
-    }))));
-}));
-exports.fetchMoreBatchDetailsEpic = fetchMoreBatchDetailsEpic;