@zeniai/client-epic-state 4.11.4 → 4.11.6

package/lib/view/transactionDetail/epics/saveTransactionHelper.js

@@ -257,7 +257,10 @@ const isTransactionMiscategorized = (transaction) => {
             line.type === 'transaction_with_product_or_service_line' ||
             line.type === 'journal_entry_transaction_line') {
             const lineItem = line;
-            if (lineItem.isCategoryMiscategorized || lineItem.isClassMiscategorized) {
+            if (lineItem.isCategoryMiscategorized ||
+                lineItem.isClassMiscategorized ||
+                (lineItem.vendor == null && lineItem.customer == null) // This ensures that neither vendor or customer is present at line level, safe to say miscat line due to vendor/customer
+            ) {
                 isTransactionMisCategorized = true;
             }
         }

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -30,10 +30,9 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
     return zeniAPI
         .putAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/transactions/${action.payload.transactionId.id}/categorize`, preparePayload(transactionState, vendorState, transactionDetailState, action.payload.transactionId, action.payload.transactionSaveUpdates))
         .pipe((0, operators_1.mergeMap)((response) => {
-        var _a, _b, _c, _d, _e;
-        if ((0, responsePayload_1.isSuccessResponse)(response)) {
-            const transactionIdResp = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction // eslint-disable-line @typescript-eslint/no-non-null-assertion
-            );
+        var _a, _b;
+        if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
+            const transactionIdResp = (0, transactionIDPayload_1.toTransactionID)(response.data.transaction);
             const transactionDetailKeyForResponse = (0, transactionDetailState_1.getTransactionDetailKey)(transactionIdResp);
             const tranDetail = (0, get_1.default)(transactionDetailState.transactionDetailById, transactionDetailKeyForResponse, undefined);
             const tranVendorUpdates = tranDetail === null || tranDetail === void 0 ? void 0 : tranDetail.transactionDetailLocalData.vendorUpdates;
@@ -54,22 +53,21 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
                 }
             }
             const actions = [];
-            if (((_a = response.data) === null || _a === void 0 ? void 0 : _a.vendors) != null) {
+            if (response.data.vendors != null) {
                 actions.push((0, vendorReducer_1.updateVendors)(response.data.vendors, 'merge'));
             }
-            actions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, 
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-            response.data.transaction));
+            actions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, response.data.transaction));
             actions.push((0, transactionDetailReducer_1.initializeTransactionDetailLocalData)({
                 transactionId: transactionIdResp,
-                vendorId: (_d = (_c = (_b = response.data) === null || _b === void 0 ? void 0 : _b.vendors) === null || _c === void 0 ? void 0 : _c[0]) === null || _d === void 0 ? void 0 : _d.vendor_id,
+                vendorId: (_b = (_a = response.data.vendors) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.vendor_id,
             }));
             actions.push((0, transactionDetailReducer_1.updateTransactionDetailSaveStatus)(transactionIdResp, 'Completed'));
             let callMarkTransactionAsNotMiscategorized = true;
             // NOTE: If tran is vendorType transaction and there is no vendor chosen on this tranaction while saving,
             // then we need to skip mark-miscategorized-as-correct api call
-            if ((0, transactionType_1.toVendorTransactionTypeStrict)((_e = response.data) === null || _e === void 0 ? void 0 : _e.transaction.transaction_type) != null) {
-                if ((vendorUpdates === null || vendorUpdates === void 0 ? void 0 : vendorUpdates.id) == null) {
+            if ((0, transactionType_1.toVendorTransactionTypeStrict)(response.data.transaction.transaction_type) != null) {
+                const isAnyClassMissing = checkIfClassMissingForAnyLineItem(response.data.transaction);
+                if ((vendorUpdates === null || vendorUpdates === void 0 ? void 0 : vendorUpdates.id) == null || isAnyClassMissing == true) {
                     callMarkTransactionAsNotMiscategorized = false;
                 }
             }
@@ -196,6 +194,18 @@ const toTransactionUpdatePayload = (updates, detail, vendorUpdates) => {
         return (0, transactionPayload_1.toTransactionPayload)(transaction);
     }
 };
+const checkIfClassMissingForAnyLineItem = (transactionPayload) => {
+    let isAnyClassMissing = false;
+    if ((transactionPayload === null || transactionPayload === void 0 ? void 0 : transactionPayload.lines) != null) {
+        transactionPayload.lines.forEach((line) => {
+            var _a;
+            if (((_a = line.line_detail) === null || _a === void 0 ? void 0 : _a.class.accounting_class_id) == null) {
+                isAnyClassMissing = true;
+            }
+        });
+    }
+    return isAnyClassMissing;
+};
 const toEntityUpdatePayload = (entityUpdates) => {
     const entityUpdatesPayload = [];
     let entityKey;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "4.11.4",
+  "version": "4.11.6",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",