@zendeskgarden/eslint-config 33.0.0 → 35.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zendeskgarden/eslint-config",
-  "version": "33.0.0",
+  "version": "35.0.0",
   "description": "Garden ESLint config",
   "license": "Apache-2.0",
   "author": "Zendesk Garden <garden@zendesk.com>",
@@ -16,34 +16,34 @@
   ],
   "scripts": {
     "format": "prettier-package-json --write",
-    "lint": "eslint index.js plugins/*.js rules/*.js",
+    "lint": "eslint index.js plugins/*.js rules/*.js --max-warnings 0",
     "prepare": "husky install",
     "tag": "[ `git rev-parse --abbrev-ref HEAD` = 'main' ] && standard-version --no-verify",
-    "test": "yarn lint && yarn format && git diff --quiet"
+    "test": "npm run format && npm run lint && git diff --quiet"
   },
   "peerDependencies": {
     "@babel/eslint-parser": "^7.15.0",
-    "eslint": "^8.29.0",
+    "eslint": "^8.50.0",
     "eslint-plugin-node": "^11.1.0"
   },
   "devDependencies": {
-    "@babel/core": "7.22.8",
-    "@babel/eslint-parser": "7.22.7",
-    "@typescript-eslint/eslint-plugin": "5.61.0",
-    "@typescript-eslint/parser": "5.61.0",
-    "eslint": "8.44.0",
-    "eslint-plugin-jest": "27.2.2",
+    "@babel/core": "7.23.0",
+    "@babel/eslint-parser": "7.22.15",
+    "@typescript-eslint/eslint-plugin": "6.7.2",
+    "@typescript-eslint/parser": "6.7.2",
+    "eslint": "8.50.0",
+    "eslint-plugin-jest": "27.4.0",
     "eslint-plugin-jsx-a11y": "6.7.1",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-notice": "0.9.10",
-    "eslint-plugin-react": "7.32.2",
+    "eslint-plugin-react": "7.33.2",
     "eslint-plugin-react-hooks": "4.6.0",
     "husky": "8.0.3",
-    "jest": "29.6.1",
+    "jest": "29.7.0",
     "prettier-package-json": "2.8.0",
     "react": "18.2.0",
     "standard-version": "9.5.0",
-    "typescript": "5.1.6"
+    "typescript": "5.2.2"
   },
   "keywords": [
     "eslint",

package/plugins/typescript-semantics.js

@@ -17,7 +17,6 @@ module.exports = {
     'dot-notation': 0,
     'key-spacing': 0,
     'no-implied-eval': 0,
-    'no-return-await': 0,
     'no-throw-literal': 0,
     'require-await': 0,
 
@@ -96,8 +95,6 @@ module.exports = {
     '@typescript-eslint/restrict-plus-operands': 2,
     // enforce template literal expressions to be of string type
     '@typescript-eslint/restrict-template-expressions': 2,
-    // enforces consistent returning of awaited values
-    '@typescript-eslint/return-await': bestPractices['no-return-await'],
     // restricts the types allowed in boolean expressions
     '@typescript-eslint/strict-boolean-expressions': 1,
     // exhaustiveness checking in switch with union type

package/plugins/typescript.js

@@ -17,6 +17,7 @@ module.exports = {
   rules: {
     // Disable ESLint rules that are handled by TypeScript
     'brace-style': 0,
+    'class-methods-use-this': 0,
     'comma-dangle': 0,
     'comma-spacing': 0,
     'constructor-super': 0,
@@ -32,7 +33,6 @@ module.exports = {
     'no-dupe-args': 0,
     'no-dupe-class-members': 0,
     'no-dupe-keys': 0,
-    'no-duplicate-imports': 0,
     'no-empty-function': 0,
     'no-extra-parens': 0,
     'no-extra-semi': 0,
@@ -77,6 +77,9 @@ module.exports = {
     '@typescript-eslint/brace-style': stylisticIssues['brace-style'],
     // ensures that literals on classes are exposed in a consistent style
     '@typescript-eslint/class-literal-property-style': 2,
+    // enforce that class methods utilize `this`
+    '@typescript-eslint/class-methods-use-this':
+      bestPractices['class-methods-use-this'],
     // require or disallow trailing comma
     '@typescript-eslint/comma-dangle': stylisticIssues['comma-dangle'],
     // enforces consistent spacing before and after commas
@@ -144,8 +147,6 @@ module.exports = {
     '@typescript-eslint/no-confusing-non-null-assertion': 2,
     // disallow duplicate class members
     '@typescript-eslint/no-dupe-class-members': es6['no-dupe-class-members'],
-    // disallow duplicate imports
-    '@typescript-eslint/no-duplicate-imports': es6['no-duplicate-imports'],
     // disallow the delete operator with computed key expressions
     '@typescript-eslint/no-dynamic-delete': 2,
     // disallow empty functions
@@ -162,8 +163,6 @@ module.exports = {
     '@typescript-eslint/no-extra-semi': possibleErrors['no-extra-semi'],
     // forbids the use of classes as namespaces
     '@typescript-eslint/no-extraneous-class': 2,
-    // disallow usage of the implicit `any` type in catch clauses
-    '@typescript-eslint/no-implicit-any-catch': 1,
     // disallows explicit type declarations for variables or parameters initialized to a number, string, or boolean
     '@typescript-eslint/no-inferrable-types': 2,
     // disallow `this` keywords outside of classes or class-like objects
@@ -187,8 +186,6 @@ module.exports = {
     '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 2,
     // disallows non-null assertions using the `!` postfix operator
     '@typescript-eslint/no-non-null-assertion': 0,
-    // disallow the use of parameter properties in class constructors
-    '@typescript-eslint/no-parameter-properties': 1,
     // disallow variable redeclaration
     '@typescript-eslint/no-redeclare': bestPractices['no-redeclare'],
     // disallows invocation of `require()`
@@ -242,8 +239,6 @@ module.exports = {
     '@typescript-eslint/quotes': stylisticIssues.quotes,
     // require or disallow semicolons instead of ASI
     '@typescript-eslint/semi': stylisticIssues.semi,
-    // enforces that members of a type union/intersection are sorted alphabetically
-    '@typescript-eslint/sort-type-union-intersection-members': 0,
     // enforces consistent spacing before function parenthesis
     '@typescript-eslint/space-before-function-paren':
       stylisticIssues['space-before-function-paren'],

package/rules/best-practices.js

@@ -119,8 +119,6 @@ module.exports = {
     'no-restricted-properties': 0,
     // disallow use of assignment in `return` statement
     'no-return-assign': 2,
-    // disallow unnecessary `return await`
-    'no-return-await': 2,
     // disallow use of `javascript:` urls.
     'no-script-url': 2,
     // disallow assignments where both sides are exactly the same

package/rules/stylistic-issues.js

@@ -128,8 +128,8 @@ module.exports = {
     'no-negated-condition': 2,
     // disallow nested ternary expressions
     'no-nested-ternary': 2,
-    // disallow use of the `Object` constructor
-    'no-new-object': 2,
+    // disallow calls to the `Object` constructor without an argument
+    'no-object-constructor': 2,
     // disallow use of unary operators, `++` and `--`
     'no-plusplus': 0,
     // disallow use of certain syntax in code