@zendeskgarden/eslint-config 31.0.0 → 32.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zendeskgarden/eslint-config",
-  "version": "31.0.0",
+  "version": "32.0.0",
   "description": "Garden ESLint config",
   "license": "Apache-2.0",
   "author": "Zendesk Garden <garden@zendesk.com>",

package/plugins/react.js

@@ -19,6 +19,9 @@ module.exports = {
     }
   },
   rules: {
+    // enforces using semantic DOM elements over the ARIA role property.
+    'jsx-a11y/prefer-tag-over-role': 2,
+
     // enforces consistent naming for boolean props
     'react/boolean-prop-naming': 1,
     // forbid "button" element without an explicit "type" attribute
@@ -117,8 +120,6 @@ module.exports = {
     'react/jsx-props-no-multi-spaces': 2,
     // prevent JSX prop spreading
     'react/jsx-props-no-spreading': 0,
-    // enforce default props alphabetical sorting
-    'react/jsx-sort-default-props': 0,
     // enforce props alphabetical sorting
     'react/jsx-sort-props': 0,
     // validate whitespace in and around the JSX opening and closing brackets
@@ -161,6 +162,8 @@ module.exports = {
     'react/no-multi-comp': 0,
     // enforces the absence of a namespace in React elements (e.g. `<svg:circle />`)
     'react/no-namespace': 2,
+    // disallow usage of referential-type variables as default param in functional components
+    'react/no-object-type-as-default-prop': 0,
     // flag shouldComponentUpdate when extending PureComponent
     'react/no-redundant-should-component-update': 2,
     // prevent usage of the return value of React.render
@@ -209,6 +212,8 @@ module.exports = {
     'react/self-closing-comp': 2,
     // enforce component methods order
     'react/sort-comp': 0,
+    // enforce default props alphabetical sorting
+    'react/sort-default-props': 0,
     // enforce propTypes declarations alphabetical sorting
     'react/sort-prop-types': 0,
     // state initialization in an ES6 class component should be in a constructor

package/plugins/typescript-semantics.js

@@ -7,6 +7,7 @@
 
 const bestPractices = require('../rules/best-practices').rules;
 const possibleErrors = require('../rules/possible-errors').rules;
+const stylisticIssues = require('../rules/stylistic-issues').rules;
 
 module.exports = {
   plugins: ['@typescript-eslint'],
@@ -14,6 +15,7 @@ module.exports = {
   rules: {
     // Disable ESLint rules that are handled by TypeScript
     'dot-notation': 0,
+    'key-spacing': 0,
     'no-implied-eval': 0,
     'no-return-await': 0,
     'no-throw-literal': 0,
@@ -23,6 +25,8 @@ module.exports = {
     '@typescript-eslint/await-thenable': 2,
     // enforce dot notation whenever possible
     '@typescript-eslint/dot-notation': bestPractices['dot-notation'],
+    // enforce consistent spacing between keys and values in object literal properties
+    '@typescript-eslint/key-spacing': stylisticIssues['key-spacing'],
     // requires that `.toString()` is only called on objects which provide useful information when stringified
     '@typescript-eslint/no-base-to-string': 2,
     // requires expressions of type void to appear in statement position