@zedtech/zedkit-ai 0.0.0-stage → 0.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (95) hide show
  1. package/LICENSE +21 -0
  2. package/README.md +175 -2
  3. package/kit/AGENTS.template.md +96 -0
  4. package/kit/THIRD_PARTY_NOTICES.md +63 -0
  5. package/kit/agents/architect.md +48 -0
  6. package/kit/agents/explorer.md +33 -0
  7. package/kit/agents/improver.md +34 -0
  8. package/kit/agents/plan-challenger.md +50 -0
  9. package/kit/agents/security-reviewer.md +33 -0
  10. package/kit/agents/verifier.md +39 -0
  11. package/kit/commands/challenge.md +5 -0
  12. package/kit/commands/handoff.md +5 -0
  13. package/kit/commands/implement.md +5 -0
  14. package/kit/commands/plan.md +5 -0
  15. package/kit/commands/pr.md +5 -0
  16. package/kit/commands/review.md +5 -0
  17. package/kit/commands/setup-ai.md +5 -0
  18. package/kit/kit.json +47 -0
  19. package/kit/skills/LICENSE-humanlayer-Apache-2.0 +202 -0
  20. package/kit/skills/LICENSE-mattpocock-skills-MIT +21 -0
  21. package/kit/skills/LICENSE-ponytail-MIT +21 -0
  22. package/kit/skills/adversarial-tests/SKILL.md +64 -0
  23. package/kit/skills/challenge/SKILL.md +18 -0
  24. package/kit/skills/code-review/SKILL.md +74 -0
  25. package/kit/skills/code-review/agents/openai.yaml +3 -0
  26. package/kit/skills/codebase-design/DEEPENING.md +37 -0
  27. package/kit/skills/codebase-design/DESIGN-IT-TWICE.md +44 -0
  28. package/kit/skills/codebase-design/SKILL.md +114 -0
  29. package/kit/skills/codebase-design/agents/openai.yaml +3 -0
  30. package/kit/skills/definition-of-done/SKILL.md +53 -0
  31. package/kit/skills/diagnosing-bugs/SKILL.md +138 -0
  32. package/kit/skills/diagnosing-bugs/agents/openai.yaml +3 -0
  33. package/kit/skills/diagnosing-bugs/scripts/hitl-loop.template.sh +44 -0
  34. package/kit/skills/domain-modeling/ADR-FORMAT.md +47 -0
  35. package/kit/skills/domain-modeling/GLOSSARY-FORMAT.md +60 -0
  36. package/kit/skills/domain-modeling/SKILL.md +74 -0
  37. package/kit/skills/domain-modeling/agents/openai.yaml +3 -0
  38. package/kit/skills/ground-truth/SKILL.md +50 -0
  39. package/kit/skills/handoff/SKILL.md +16 -0
  40. package/kit/skills/handoff/agents/openai.yaml +5 -0
  41. package/kit/skills/implement/SKILL.md +25 -0
  42. package/kit/skills/implement/agents/openai.yaml +5 -0
  43. package/kit/skills/implement-spec/SKILL.md +42 -0
  44. package/kit/skills/implement-spec/agents/openai.yaml +5 -0
  45. package/kit/skills/improve-codebase-architecture/HTML-REPORT.md +123 -0
  46. package/kit/skills/improve-codebase-architecture/SKILL.md +71 -0
  47. package/kit/skills/improve-codebase-architecture/agents/openai.yaml +5 -0
  48. package/kit/skills/parallel-work/SKILL.md +61 -0
  49. package/kit/skills/persona-review/SKILL.md +38 -0
  50. package/kit/skills/plan/SKILL.md +38 -0
  51. package/kit/skills/ponytail/SKILL.md +53 -0
  52. package/kit/skills/ponytail-audit/SKILL.md +103 -0
  53. package/kit/skills/ponytail-debt/SKILL.md +44 -0
  54. package/kit/skills/ponytail-gain/SKILL.md +52 -0
  55. package/kit/skills/ponytail-help/SKILL.md +76 -0
  56. package/kit/skills/ponytail-review/SKILL.md +119 -0
  57. package/kit/skills/pr/CREDITS.md +3 -0
  58. package/kit/skills/pr/SKILL.md +170 -0
  59. package/kit/skills/pr/agents/openai.yaml +3 -0
  60. package/kit/skills/research/SKILL.md +12 -0
  61. package/kit/skills/research/agents/openai.yaml +3 -0
  62. package/kit/skills/retro/SKILL.md +44 -0
  63. package/kit/skills/retro/agents/openai.yaml +5 -0
  64. package/kit/skills/review/SKILL.md +37 -0
  65. package/kit/skills/rules-upkeep/SKILL.md +55 -0
  66. package/kit/skills/setup-ai/SKILL.md +139 -0
  67. package/kit/skills/setup-matt-pocock-skills/SKILL.md +118 -0
  68. package/kit/skills/setup-matt-pocock-skills/agents/openai.yaml +5 -0
  69. package/kit/skills/setup-matt-pocock-skills/domain.md +51 -0
  70. package/kit/skills/setup-matt-pocock-skills/issue-tracker-github.md +46 -0
  71. package/kit/skills/setup-matt-pocock-skills/issue-tracker-gitlab.md +46 -0
  72. package/kit/skills/setup-matt-pocock-skills/issue-tracker-local.md +30 -0
  73. package/kit/skills/setup-matt-pocock-skills/triage-labels.md +15 -0
  74. package/kit/skills/setup-ts-deep-modules/SKILL.md +102 -0
  75. package/kit/skills/setup-ts-deep-modules/agents/openai.yaml +5 -0
  76. package/kit/skills/setup-ts-deep-modules/dependency-cruiser.config.cjs +95 -0
  77. package/kit/skills/tdd/SKILL.md +38 -0
  78. package/kit/skills/tdd/agents/openai.yaml +3 -0
  79. package/kit/skills/tdd/mocking.md +59 -0
  80. package/kit/skills/tdd/tests.md +77 -0
  81. package/kit/skills/to-spec/SKILL.md +75 -0
  82. package/kit/skills/to-spec/agents/openai.yaml +5 -0
  83. package/kit/skills/to-tickets/SKILL.md +105 -0
  84. package/kit/skills/to-tickets/agents/openai.yaml +5 -0
  85. package/kit/skills/triage/AGENT-BRIEF.md +207 -0
  86. package/kit/skills/triage/OUT-OF-SCOPE.md +105 -0
  87. package/kit/skills/triage/SKILL.md +112 -0
  88. package/kit/skills/triage/agents/openai.yaml +5 -0
  89. package/kit/skills/use-zedkit/SKILL.md +32 -0
  90. package/kit/skills/wayfinder/SKILL.md +128 -0
  91. package/kit/skills/wayfinder/agents/openai.yaml +5 -0
  92. package/kit/skills/writing-for-agents/SKILL-MECHANICS.md +22 -0
  93. package/kit/skills/writing-for-agents/SKILL.md +81 -0
  94. package/kit/skills/writing-for-agents/agents/openai.yaml +3 -0
  95. package/package.json +48 -3
package/kit/kit.json ADDED
@@ -0,0 +1,47 @@
1
+ {
2
+ "presets": {
3
+ "core": [
4
+ "ponytail",
5
+ "ponytail-review",
6
+ "ground-truth",
7
+ "parallel-work",
8
+ "definition-of-done",
9
+ "adversarial-tests",
10
+ "rules-upkeep",
11
+ "tdd",
12
+ "code-review",
13
+ "diagnosing-bugs",
14
+ "handoff",
15
+ "persona-review",
16
+ "codebase-design",
17
+ "pr",
18
+ "setup-ai",
19
+ "review",
20
+ "plan",
21
+ "challenge",
22
+ "implement",
23
+ "to-spec",
24
+ "to-tickets",
25
+ "wayfinder",
26
+ "domain-modeling"
27
+ ],
28
+ "full": "*"
29
+ },
30
+ "agents": [
31
+ "explorer",
32
+ "architect",
33
+ "plan-challenger",
34
+ "verifier",
35
+ "improver",
36
+ "security-reviewer"
37
+ ],
38
+ "commands": [
39
+ "review",
40
+ "plan",
41
+ "challenge",
42
+ "implement",
43
+ "setup-ai",
44
+ "pr",
45
+ "handoff"
46
+ ]
47
+ }
@@ -0,0 +1,202 @@
1
+
2
+ Apache License
3
+ Version 2.0, January 2004
4
+ http://www.apache.org/licenses/
5
+
6
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
7
+
8
+ 1. Definitions.
9
+
10
+ "License" shall mean the terms and conditions for use, reproduction,
11
+ and distribution as defined by Sections 1 through 9 of this document.
12
+
13
+ "Licensor" shall mean the copyright owner or entity authorized by
14
+ the copyright owner that is granting the License.
15
+
16
+ "Legal Entity" shall mean the union of the acting entity and all
17
+ other entities that control, are controlled by, or are under common
18
+ control with that entity. For the purposes of this definition,
19
+ "control" means (i) the power, direct or indirect, to cause the
20
+ direction or management of such entity, whether by contract or
21
+ otherwise, or (ii) ownership of fifty percent (50%) or more of the
22
+ outstanding shares, or (iii) beneficial ownership of such entity.
23
+
24
+ "You" (or "Your") shall mean an individual or Legal Entity
25
+ exercising permissions granted by this License.
26
+
27
+ "Source" form shall mean the preferred form for making modifications,
28
+ including but not limited to software source code, documentation
29
+ source, and configuration files.
30
+
31
+ "Object" form shall mean any form resulting from mechanical
32
+ transformation or translation of a Source form, including but
33
+ not limited to compiled object code, generated documentation,
34
+ and conversions to other media types.
35
+
36
+ "Work" shall mean the work of authorship, whether in Source or
37
+ Object form, made available under the License, as indicated by a
38
+ copyright notice that is included in or attached to the work
39
+ (an example is provided in the Appendix below).
40
+
41
+ "Derivative Works" shall mean any work, whether in Source or Object
42
+ form, that is based on (or derived from) the Work and for which the
43
+ editorial revisions, annotations, elaborations, or other modifications
44
+ represent, as a whole, an original work of authorship. For the purposes
45
+ of this License, Derivative Works shall not include works that remain
46
+ separable from, or merely link (or bind by name) to the interfaces of,
47
+ the Work and Derivative Works thereof.
48
+
49
+ "Contribution" shall mean any work of authorship, including
50
+ the original version of the Work and any modifications or additions
51
+ to that Work or Derivative Works thereof, that is intentionally
52
+ submitted to Licensor for inclusion in the Work by the copyright owner
53
+ or by an individual or Legal Entity authorized to submit on behalf of
54
+ the copyright owner. For the purposes of this definition, "submitted"
55
+ means any form of electronic, verbal, or written communication sent
56
+ to the Licensor or its representatives, including but not limited to
57
+ communication on electronic mailing lists, source code control systems,
58
+ and issue tracking systems that are managed by, or on behalf of, the
59
+ Licensor for the purpose of discussing and improving the Work, but
60
+ excluding communication that is conspicuously marked or otherwise
61
+ designated in writing by the copyright owner as "Not a Contribution."
62
+
63
+ "Contributor" shall mean Licensor and any individual or Legal Entity
64
+ on behalf of whom a Contribution has been received by Licensor and
65
+ subsequently incorporated within the Work.
66
+
67
+ 2. Grant of Copyright License. Subject to the terms and conditions of
68
+ this License, each Contributor hereby grants to You a perpetual,
69
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
70
+ copyright license to reproduce, prepare Derivative Works of,
71
+ publicly display, publicly perform, sublicense, and distribute the
72
+ Work and such Derivative Works in Source or Object form.
73
+
74
+ 3. Grant of Patent License. Subject to the terms and conditions of
75
+ this License, each Contributor hereby grants to You a perpetual,
76
+ worldwide, non-exclusive, no-charge, royalty-free, irrevocable
77
+ (except as stated in this section) patent license to make, have made,
78
+ use, offer to sell, sell, import, and otherwise transfer the Work,
79
+ where such license applies only to those patent claims licensable
80
+ by such Contributor that are necessarily infringed by their
81
+ Contribution(s) alone or by combination of their Contribution(s)
82
+ with the Work to which such Contribution(s) was submitted. If You
83
+ institute patent litigation against any entity (including a
84
+ cross-claim or counterclaim in a lawsuit) alleging that the Work
85
+ or a Contribution incorporated within the Work constitutes direct
86
+ or contributory patent infringement, then any patent licenses
87
+ granted to You under this License for that Work shall terminate
88
+ as of the date such litigation is filed.
89
+
90
+ 4. Redistribution. You may reproduce and distribute copies of the
91
+ Work or Derivative Works thereof in any medium, with or without
92
+ modifications, and in Source or Object form, provided that You
93
+ meet the following conditions:
94
+
95
+ (a) You must give any other recipients of the Work or
96
+ Derivative Works a copy of this License; and
97
+
98
+ (b) You must cause any modified files to carry prominent notices
99
+ stating that You changed the files; and
100
+
101
+ (c) You must retain, in the Source form of any Derivative Works
102
+ that You distribute, all copyright, patent, trademark, and
103
+ attribution notices from the Source form of the Work,
104
+ excluding those notices that do not pertain to any part of
105
+ the Derivative Works; and
106
+
107
+ (d) If the Work includes a "NOTICE" text file as part of its
108
+ distribution, then any Derivative Works that You distribute must
109
+ include a readable copy of the attribution notices contained
110
+ within such NOTICE file, excluding those notices that do not
111
+ pertain to any part of the Derivative Works, in at least one
112
+ of the following places: within a NOTICE text file distributed
113
+ as part of the Derivative Works; within the Source form or
114
+ documentation, if provided along with the Derivative Works; or,
115
+ within a display generated by the Derivative Works, if and
116
+ wherever such third-party notices normally appear. The contents
117
+ of the NOTICE file are for informational purposes only and
118
+ do not modify the License. You may add Your own attribution
119
+ notices within Derivative Works that You distribute, alongside
120
+ or as an addendum to the NOTICE text from the Work, provided
121
+ that such additional attribution notices cannot be construed
122
+ as modifying the License.
123
+
124
+ You may add Your own copyright statement to Your modifications and
125
+ may provide additional or different license terms and conditions
126
+ for use, reproduction, or distribution of Your modifications, or
127
+ for any such Derivative Works as a whole, provided Your use,
128
+ reproduction, and distribution of the Work otherwise complies with
129
+ the conditions stated in this License.
130
+
131
+ 5. Submission of Contributions. Unless You explicitly state otherwise,
132
+ any Contribution intentionally submitted for inclusion in the Work
133
+ by You to the Licensor shall be under the terms and conditions of
134
+ this License, without any additional terms or conditions.
135
+ Notwithstanding the above, nothing herein shall supersede or modify
136
+ the terms of any separate license agreement you may have executed
137
+ with Licensor regarding such Contributions.
138
+
139
+ 6. Trademarks. This License does not grant permission to use the trade
140
+ names, trademarks, service marks, or product names of the Licensor,
141
+ except as required for reasonable and customary use in describing the
142
+ origin of the Work and reproducing the content of the NOTICE file.
143
+
144
+ 7. Disclaimer of Warranty. Unless required by applicable law or
145
+ agreed to in writing, Licensor provides the Work (and each
146
+ Contributor provides its Contributions) on an "AS IS" BASIS,
147
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
148
+ implied, including, without limitation, any warranties or conditions
149
+ of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
150
+ PARTICULAR PURPOSE. You are solely responsible for determining the
151
+ appropriateness of using or redistributing the Work and assume any
152
+ risks associated with Your exercise of permissions under this License.
153
+
154
+ 8. Limitation of Liability. In no event and under no legal theory,
155
+ whether in tort (including negligence), contract, or otherwise,
156
+ unless required by applicable law (such as deliberate and grossly
157
+ negligent acts) or agreed to in writing, shall any Contributor be
158
+ liable to You for damages, including any direct, indirect, special,
159
+ incidental, or consequential damages of any character arising as a
160
+ result of this License or out of the use or inability to use the
161
+ Work (including but not limited to damages for loss of goodwill,
162
+ work stoppage, computer failure or malfunction, or any and all
163
+ other commercial damages or losses), even if such Contributor
164
+ has been advised of the possibility of such damages.
165
+
166
+ 9. Accepting Warranty or Additional Liability. While redistributing
167
+ the Work or Derivative Works thereof, You may choose to offer,
168
+ and charge a fee for, acceptance of support, warranty, indemnity,
169
+ or other liability obligations and/or rights consistent with this
170
+ License. However, in accepting such obligations, You may act only
171
+ on Your own behalf and on Your sole responsibility, not on behalf
172
+ of any other Contributor, and only if You agree to indemnify,
173
+ defend, and hold each Contributor harmless for any liability
174
+ incurred by, or claims asserted against, such Contributor by reason
175
+ of your accepting any such warranty or additional liability.
176
+
177
+ END OF TERMS AND CONDITIONS
178
+
179
+ APPENDIX: How to apply the Apache License to your work.
180
+
181
+ To apply the Apache License to your work, attach the following
182
+ boilerplate notice, with the fields enclosed by brackets "[]"
183
+ replaced with your own identifying information. (Don't include
184
+ the brackets!) The text should be enclosed in the appropriate
185
+ comment syntax for the file format. We also recommend that a
186
+ file or class name and description of purpose be included on the
187
+ same "printed page" as the copyright notice for easier
188
+ identification within third-party archives.
189
+
190
+ Copyright [yyyy] [name of copyright owner]
191
+
192
+ Licensed under the Apache License, Version 2.0 (the "License");
193
+ you may not use this file except in compliance with the License.
194
+ You may obtain a copy of the License at
195
+
196
+ http://www.apache.org/licenses/LICENSE-2.0
197
+
198
+ Unless required by applicable law or agreed to in writing, software
199
+ distributed under the License is distributed on an "AS IS" BASIS,
200
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
201
+ See the License for the specific language governing permissions and
202
+ limitations under the License.
@@ -0,0 +1,21 @@
1
+ MIT License
2
+
3
+ Copyright (c) 2026 Matt Pocock
4
+
5
+ Permission is hereby granted, free of charge, to any person obtaining a copy
6
+ of this software and associated documentation files (the "Software"), to deal
7
+ in the Software without restriction, including without limitation the rights
8
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9
+ copies of the Software, and to permit persons to whom the Software is
10
+ furnished to do so, subject to the following conditions:
11
+
12
+ The above copyright notice and this permission notice shall be included in all
13
+ copies or substantial portions of the Software.
14
+
15
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21
+ SOFTWARE.
@@ -0,0 +1,21 @@
1
+ MIT License
2
+
3
+ Copyright (c) 2026 DietrichGebert
4
+
5
+ Permission is hereby granted, free of charge, to any person obtaining a copy
6
+ of this software and associated documentation files (the "Software"), to deal
7
+ in the Software without restriction, including without limitation the rights
8
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9
+ copies of the Software, and to permit persons to whom the Software is
10
+ furnished to do so, subject to the following conditions:
11
+
12
+ The above copyright notice and this permission notice shall be included in all
13
+ copies or substantial portions of the Software.
14
+
15
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21
+ SOFTWARE.
@@ -0,0 +1,64 @@
1
+ ---
2
+ name: adversarial-tests
3
+ description: "Find the edge cases a change must be tested against: boundary inputs, bad shapes, failing dependencies, duplicates, state order. Use when writing or reviewing tests for new or changed logic, handlers, consumers, endpoints or repositories."
4
+ ---
5
+
6
+ # Adversarial tests
7
+
8
+ Tests that only show the code working prove little. Aim them at how it breaks. A suite of happy paths gives false confidence.
9
+
10
+ ## Pick the test type first
11
+
12
+ | Test | Use it for | Not for |
13
+ |---|---|---|
14
+ | Unit | one decision: guard, branch, mapping, error classification | full flows, wiring |
15
+ | Integration (real DB, real queue or in-memory fake that behaves) | data access, transactions, constraints | logic branches |
16
+ | End-to-end through the public entry (HTTP, message, CLI) | the contract: the success case, each documented failure, garbage input | every internal branch |
17
+
18
+ Do not mock the database or the thing under test. Fake only what you do not own (network, clock, third parties).
19
+
20
+ ## Attack list
21
+
22
+ Take every item that applies to the code. At least one test per relevant item.
23
+
24
+ **Inputs**
25
+ - Each optional parameter as `null`, as `undefined`, and omitted. `false` and `0` versus missing.
26
+ - Empty string, array, object. Zero, negative, `NaN`, `Infinity`, max safe integer.
27
+ - Too long, odd characters, unicode, injection strings.
28
+
29
+ **Shapes**
30
+ - Required field missing. Present but `null`. Wrong type. Extra unknown fields. Array where one value is expected, and the reverse.
31
+
32
+ **Dependencies**
33
+ - Throws: is the error propagated, not swallowed or rewrapped?
34
+ - Returns `undefined`, an empty list, or a value missing optional fields.
35
+ - Slow, timing out, answering 5xx or a malformed body.
36
+
37
+ **State and time**
38
+ - Calling again with identical input: is the second call harmless?
39
+ - Two concurrent calls: race, lost update?
40
+ - Wrong order: finish before start, act on a deleted item.
41
+ - Unknown enum or version value: a newer producer must not crash an older consumer.
42
+
43
+ **Business rules**
44
+ - Valid shape that breaks a rule. Cross-tenant or cross-user access: denied and indistinguishable from "not found".
45
+
46
+ ## Rules
47
+
48
+ - A bug fix starts with a test that fails for the right reason.
49
+ - Name tests by behavior ("rejects expired token"), not by function.
50
+ - One reason to fail per test. No logic (loops, branches) inside tests.
51
+ - Deterministic: no real network, no wall clock, no shared state between tests.
52
+ - Removing or loosening a test needs a written reason in the PR.
53
+
54
+ ## Self-check before done
55
+
56
+ For each function, handler or endpoint written or changed:
57
+
58
+ - [ ] Happy path, in the right test type
59
+ - [ ] Each guard clause and early exit is exercised by a test
60
+ - [ ] Each error type it can raise is asserted somewhere
61
+ - [ ] Null, empty and unknown-value inputs, where accepted
62
+ - [ ] Each collaborator failing, and returning nothing
63
+ - [ ] Duplicate delivery or repeat call, where it can happen
64
+ - [ ] A test that would fail if the main branch of the code were deleted
@@ -0,0 +1,18 @@
1
+ ---
2
+ name: challenge
3
+ description: "Pre-implementation attack on a plan: ranked objections plus domain and design checks. Use after planning and before writing code."
4
+ ---
5
+
6
+ One command for "is this plan sound". It tries to kill the plan before the
7
+ plan wastes implementation effort.
8
+
9
+ ## Process
10
+
11
+ 1. Run the `plan-challenger` subagent on the plan: needed parts only,
12
+ verified claims, production failure modes. Ranked objections, no code.
13
+ Reject a plan whose ladder table is missing or weak.
14
+ 2. Check the domain language with `domain-modeling` (terms sharp, glossary
15
+ and ADRs current) and the module shape with `codebase-design` (deep
16
+ modules, seams in the right place).
17
+ 3. Merge into one list: objections ranked by blast radius, each with the fix
18
+ or the question that resolves it. Verdict: proceed, amend, or replan.
@@ -0,0 +1,74 @@
1
+ ---
2
+ name: code-review
3
+ description: "Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\"."
4
+ ---
5
+
6
+ Two-axis review of the diff between `HEAD` and a fixed point the user supplies:
7
+
8
+ - **Standards**: does the code conform to this repo's documented coding standards?
9
+ - **Spec**: does the code faithfully implement the originating issue / spec?
10
+
11
+ Both axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings.
12
+
13
+ The issue tracker should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
14
+
15
+ ## Process
16
+
17
+ ### 1. Pin the fixed point
18
+
19
+ Whatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.
20
+
21
+ Capture the diff command once: `git diff <fixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log <fixed-point>..HEAD --oneline`.
22
+
23
+ Before going further, confirm the fixed point resolves (`git rev-parse <fixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents.
24
+
25
+ ### 2. Identify the spec source
26
+
27
+ Look for the originating spec, in this order:
28
+
29
+ 1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in the tracker doc.
30
+ 2. A path the user passed as an argument.
31
+ 3. A spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature.
32
+ 4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report "no spec available".
33
+
34
+ ### 3. Identify the standards sources
35
+
36
+ Search the repo for every file that documents how code should be written. When `CODING_STANDARDS.md` or `CONTRIBUTING.md` exists, it must be on the list.
37
+
38
+ On top of whatever the repo documents, the Standards axis always applies the **`ponytail-review` skill**: correctness, safety, behavior under load, tested risk, speed, and whether every line is needed. It replaces any ad-hoc smell list — one reusable review skill, referenced here, never copied. Its ladder is part of the checklist: every new piece of code, file, or dependency in the diff must name the first rung that holds. Two rules bind it:
39
+
40
+ - **The repo overrides.** A documented repo standard always wins; where it endorses something the review would flag, suppress the finding.
41
+ - **Always a judgement call.** Each finding is a labelled heuristic ("possible Feature Envy"), never a hard violation. Like any standard here, skip anything tooling already enforces.
42
+
43
+ ### 4. Spawn both sub-agents in parallel
44
+
45
+ Issue both sub-agent calls together, in the foreground, and aggregate the reports they return.
46
+
47
+ **Standards sub-agent prompt** should include:
48
+
49
+ - The full diff command and commit list.
50
+ - The list of standards-source files you found in step 3, **plus the instruction to apply the `ponytail-review` skill** (the sub-agent reads it itself from the installed skills).
51
+ - The brief: "Report, per file/hunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) the `ponytail-review` findings: name the check and quote the hunk, including the ladder verdict per new piece (first rung that holds). Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but `ponytail-review` findings are always judgement calls, and a documented repo standard overrides them. Skip anything tooling enforces. Under 400 words."
52
+
53
+ **Spec sub-agent prompt** should include:
54
+
55
+ - The diff command and commit list.
56
+ - The path or fetched contents of the spec.
57
+ - The brief: "Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong; (d) when the spec/plan carries a ladder table, each built piece verified against its row — a piece that skipped a higher rung is a finding. Quote the spec line for each finding. Under 400 words."
58
+
59
+ If the spec is missing, skip the Spec sub-agent and note this in the final report.
60
+
61
+ ### 5. Aggregate
62
+
63
+ Present the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).
64
+
65
+ End with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.
66
+
67
+ ## Why two axes
68
+
69
+ A change can pass one axis and fail the other:
70
+
71
+ - Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**
72
+ - Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**
73
+
74
+ Reporting them separately stops one axis from masking the other.
@@ -0,0 +1,3 @@
1
+ interface:
2
+ display_name: "Code Review"
3
+ short_description: "Review a diff on standards and spec"
@@ -0,0 +1,37 @@
1
+ # Deepening
2
+
3
+ How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**.
4
+
5
+ ## Dependency categories
6
+
7
+ When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
8
+
9
+ ### 1. In-process
10
+
11
+ Pure computation, in-memory state, no I/O. Always deepenable: merge the modules and test through the new interface directly. No adapter needed.
12
+
13
+ ### 2. Local-substitutable
14
+
15
+ Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
16
+
17
+ ### 3. Remote but owned (Ports & Adapters)
18
+
19
+ Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
20
+
21
+ Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
22
+
23
+ ### 4. True external (Mock)
24
+
25
+ Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
26
+
27
+ ## Seam discipline
28
+
29
+ - **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
30
+ - **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
31
+
32
+ ## Testing strategy: replace, don't layer
33
+
34
+ - Old unit tests on shallow modules become waste once tests at the deepened module's interface exist; delete them.
35
+ - Write new tests at the deepened module's interface. The **interface is the test surface**.
36
+ - Tests assert on observable outcomes through the interface, not internal state.
37
+ - Tests should survive internal refactors, since they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.
@@ -0,0 +1,44 @@
1
+ # Design It Twice
2
+
3
+ When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout): your first idea is unlikely to be the best.
4
+
5
+ Uses the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**, **leverage**.
6
+
7
+ ## Process
8
+
9
+ ### 1. Frame the problem space
10
+
11
+ Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
12
+
13
+ - The constraints any new interface would need to satisfy
14
+ - The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md))
15
+ - A rough illustrative code sketch to ground the constraints, not a proposal, just a way to make the constraints concrete
16
+
17
+ Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
18
+
19
+ ### 2. Spawn sub-agents
20
+
21
+ Spawn 3+ sub-agents in parallel. Each must produce a **radically different** interface for the deepened module.
22
+
23
+ Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
24
+
25
+ - Agent 1: "Minimize the interface: aim for 1–3 entry points max. Maximise leverage per entry point."
26
+ - Agent 2: "Maximise flexibility: support many use cases and extension."
27
+ - Agent 3: "Optimise for the most common caller: make the default case trivial."
28
+ - Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
29
+
30
+ Include both [SKILL.md](SKILL.md) vocabulary and GLOSSARY.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
31
+
32
+ Each sub-agent outputs:
33
+
34
+ 1. Interface (types, methods, params, plus invariants, ordering, error modes)
35
+ 2. Usage example showing how callers use it
36
+ 3. What the implementation hides behind the seam
37
+ 4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md))
38
+ 5. Trade-offs: where leverage is high, where it's thin
39
+
40
+ ### 3. Present and compare
41
+
42
+ Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
43
+
44
+ After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated: the user wants a strong read, not a menu.
@@ -0,0 +1,114 @@
1
+ ---
2
+ name: codebase-design
3
+ description: Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary.
4
+ ---
5
+
6
+ # Codebase Design
7
+
8
+ Design **deep modules**: a lot of behaviour behind a small interface, placed at a clean seam, testable through that interface. Use this language and these principles wherever code is being designed or restructured. The aim is leverage for callers, locality for maintainers, and testability for everyone.
9
+
10
+ ## Glossary
11
+
12
+ Use these terms exactly: don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point.
13
+
14
+ **Module**: anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service.
15
+
16
+ **Interface**: everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow, they refer only to the type-level surface).
17
+
18
+ **Implementation**: what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise.
19
+
20
+ **Depth**: leverage at the interface. The amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation.
21
+
22
+ **Seam** _(Michael Feathers)_: a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context).
23
+
24
+ **Adapter**: a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside).
25
+
26
+ **Leverage**: what callers get from depth. More capability per unit of interface they learn. One implementation pays back across N call sites and M tests.
27
+
28
+ **Locality**: what maintainers get from depth. Change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere.
29
+
30
+ ## Deep vs shallow
31
+
32
+ **Deep module** = small interface + lots of implementation:
33
+
34
+ ```
35
+ ┌─────────────────────┐
36
+ │ Small Interface │ ← Few methods, simple params
37
+ ├─────────────────────┤
38
+ │ │
39
+ │ Deep Implementation│ ← Complex logic hidden
40
+ │ │
41
+ └─────────────────────┘
42
+ ```
43
+
44
+ **Shallow module** = large interface + little implementation (avoid):
45
+
46
+ ```
47
+ ┌─────────────────────────────────┐
48
+ │ Large Interface │ ← Many methods, complex params
49
+ ├─────────────────────────────────┤
50
+ │ Thin Implementation │ ← Just passes through
51
+ └─────────────────────────────────┘
52
+ ```
53
+
54
+ When designing an interface, ask:
55
+
56
+ - Can I reduce the number of methods?
57
+ - Can I simplify the parameters?
58
+ - Can I hide more complexity inside?
59
+
60
+ ## Principles
61
+
62
+ - **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts; they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface.
63
+ - **The deletion test.** Imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep.
64
+ - **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape.
65
+ - **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it.
66
+
67
+ ## Designing for testability
68
+
69
+ Good interfaces make testing natural:
70
+
71
+ 1. **Accept dependencies, don't create them.**
72
+
73
+ ```typescript
74
+ // Testable
75
+ function processOrder(order, paymentGateway) {}
76
+
77
+ // Hard to test
78
+ function processOrder(order) {
79
+ const gateway = new StripeGateway();
80
+ }
81
+ ```
82
+
83
+ 2. **Return results, don't produce side effects.**
84
+
85
+ ```typescript
86
+ // Testable
87
+ function calculateDiscount(cart): Discount {}
88
+
89
+ // Hard to test
90
+ function applyDiscount(cart): void {
91
+ cart.total -= discount;
92
+ }
93
+ ```
94
+
95
+ 3. **Small surface area.** Fewer methods = fewer tests needed. Fewer params = simpler test setup.
96
+
97
+ ## Relationships
98
+
99
+ - A **Module** has exactly one **Interface** (the surface it presents to callers and tests).
100
+ - **Depth** is a property of a **Module**, measured against its **Interface**.
101
+ - A **Seam** is where a **Module**'s **Interface** lives.
102
+ - An **Adapter** sits at a **Seam** and satisfies the **Interface**.
103
+ - **Depth** produces **Leverage** for callers and **Locality** for maintainers.
104
+
105
+ ## Rejected framings
106
+
107
+ - **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead.
108
+ - **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow: interface here includes every fact a caller must know.
109
+ - **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**.
110
+
111
+ ## Going deeper
112
+
113
+ - **Deepening a cluster given its dependencies**, see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing.
114
+ - **Exploring alternative interfaces**, see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement.