@zcy2nn/agent-forge 1.1.3 → 1.1.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (44) hide show
  1. package/README.md +247 -247
  2. package/agent-forge.schema.json +2 -133
  3. package/dist/cli/index.js +109 -204
  4. package/dist/cli/providers.d.ts +0 -44
  5. package/dist/config/constants.d.ts +3 -4
  6. package/dist/config/index.d.ts +0 -1
  7. package/dist/config/schema.d.ts +2 -72
  8. package/dist/index.js +191 -995
  9. package/dist/tools/index.d.ts +0 -1
  10. package/dist/tui.js +5 -18
  11. package/package.json +104 -104
  12. package/src/skills/brainstorming/SKILL.md +185 -186
  13. package/src/skills/brainstorming/scripts/frame-template.html +214 -214
  14. package/src/skills/brainstorming/scripts/server.cjs +354 -354
  15. package/src/skills/brainstorming/spec-document-reviewer-prompt.md +1 -1
  16. package/src/skills/codemap/README.md +3 -3
  17. package/src/skills/codemap/SKILL.md +5 -5
  18. package/src/skills/codemap/codemap.md +4 -4
  19. package/src/skills/codemap/scripts/codemap.mjs +1 -1
  20. package/src/skills/codemap/scripts/codemap.test.ts +1 -1
  21. package/src/skills/requesting-code-review/SKILL.md +1 -1
  22. package/src/skills/subagent-driven-development/SKILL.md +1 -1
  23. package/src/skills/systematic-debugging/SKILL.md +318 -318
  24. package/src/skills/test-driven-development/SKILL.md +392 -392
  25. package/src/skills/verification-before-completion/SKILL.md +153 -153
  26. package/src/skills/writing-plans/SKILL.md +2 -2
  27. package/src/skills/writing-skills/graphviz-conventions.dot +171 -171
  28. package/dist/agents/council.d.ts +0 -27
  29. package/dist/agents/councillor.d.ts +0 -2
  30. package/dist/agents/designer.d.ts +0 -2
  31. package/dist/agents/explorer.d.ts +0 -2
  32. package/dist/agents/fixer.d.ts +0 -2
  33. package/dist/agents/implementer.d.ts +0 -2
  34. package/dist/agents/librarian.d.ts +0 -2
  35. package/dist/agents/observer.d.ts +0 -2
  36. package/dist/agents/oracle.d.ts +0 -2
  37. package/dist/agents/reviewer.d.ts +0 -2
  38. package/dist/cli/migration.d.ts +0 -46
  39. package/dist/config/council-schema.d.ts +0 -127
  40. package/dist/council/council-manager.d.ts +0 -49
  41. package/dist/council/index.d.ts +0 -1
  42. package/dist/skills/systematic-debugging/condition-based-waiting-example.d.ts +0 -51
  43. package/dist/tools/council.d.ts +0 -10
  44. package/src/skills/using-git-worktrees/SKILL.md +0 -226
@@ -1,153 +1,153 @@
1
- ---
2
- name: verification-before-completion
3
- description: Use when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always
4
- ---
5
-
6
- # Verification Before Completion
7
-
8
- ## Overview
9
-
10
- Claiming work is complete without verification is dishonesty, not efficiency.
11
-
12
- **Core principle:** Evidence before claims, always.
13
-
14
- **Violating the letter of this rule is violating the spirit of this rule.**
15
-
16
- ## The Iron Law
17
-
18
- ```
19
- NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE
20
- ```
21
-
22
- If you haven't run the verification command in this message, you cannot claim it passes.
23
-
24
- **This applies at ALL complexity tiers.** What varies is the depth of verification:
25
- - **Simple tasks:** Run the relevant verification command (tests, linter, build) and confirm it passes
26
- - **Medium/Complex tasks:** Run full verification suite, check coverage, verify edge cases, review against requirements
27
-
28
- ## The Gate Function
29
-
30
- ```
31
- BEFORE claiming any status or expressing satisfaction:
32
-
33
- 1. IDENTIFY: What command proves this claim?
34
- 2. RUN: Execute the FULL command (fresh, complete)
35
- 3. READ: Full output, check exit code, count failures
36
- 4. VERIFY: Does output confirm the claim?
37
- - If NO: State actual status with evidence
38
- - If YES: State claim WITH evidence
39
- 5. ONLY THEN: Make the claim
40
-
41
- Skip any step = lying, not verifying
42
- ```
43
-
44
- ## Common Failures
45
-
46
- | Claim | Requires | Not Sufficient |
47
- |-------|----------|----------------|
48
- | Tests pass | Test command output: 0 failures | Previous run, "should pass" |
49
- | Linter clean | Linter output: 0 errors | Partial check, extrapolation |
50
- | Build succeeds | Build command: exit 0 | Linter passing, logs look good |
51
- | Bug fixed | Test original symptom: passes | Code changed, assumed fixed |
52
- | Regression test works | Red-green cycle verified | Test passes once |
53
- | Agent completed | VCS diff shows changes | Agent reports "success" |
54
- | Requirements met | Line-by-line checklist | Tests passing |
55
-
56
- ## Red Flags - STOP
57
-
58
- - Using "should", "probably", "seems to"
59
- - Expressing satisfaction before verification ("Great!", "Perfect!", "Done!", etc.)
60
- - About to commit/push/PR without verification
61
- - Trusting agent success reports
62
- - Relying on partial verification
63
- - Thinking "just this once"
64
- - Tired and wanting work over
65
- - **ANY wording implying success without having run verification**
66
-
67
- ## Rationalization Prevention
68
-
69
- | Excuse | Reality |
70
- |--------|---------|
71
- | "Should work now" | RUN the verification |
72
- | "I'm confident" | Confidence ≠ evidence |
73
- | "Just this once" | No exceptions |
74
- | "Linter passed" | Linter ≠ compiler |
75
- | "Agent said success" | Verify independently |
76
- | "I'm tired" | Exhaustion ≠ excuse |
77
- | "Partial check is enough" | Partial proves nothing |
78
- | "Different words so rule doesn't apply" | Spirit over letter |
79
-
80
- ## Key Patterns
81
-
82
- **Tests:**
83
- ```
84
- ✅ [Run test command] [See: 34/34 pass] "All tests pass"
85
- ❌ "Should pass now" / "Looks correct"
86
- ```
87
-
88
- **Regression tests (TDD Red-Green):**
89
- ```
90
- ✅ Write → Run (pass) → Revert fix → Run (MUST FAIL) → Restore → Run (pass)
91
- ❌ "I've written a regression test" (without red-green verification)
92
- ```
93
-
94
- **Build:**
95
- ```
96
- ✅ [Run build] [See: exit 0] "Build passes"
97
- ❌ "Linter passed" (linter doesn't check compilation)
98
- ```
99
-
100
- **Requirements:**
101
- ```
102
- ✅ Re-read plan → Create checklist → Verify each → Report gaps or completion
103
- ❌ "Tests pass, phase complete"
104
- ```
105
-
106
- **Agent delegation:**
107
- ```
108
- ✅ Agent reports success → Check VCS diff → Verify changes → Report actual state
109
- ❌ Trust agent report
110
- ```
111
-
112
- ## Why This Matters
113
-
114
- From 24 failure memories:
115
- - your human partner said "I don't believe you" - trust broken
116
- - Undefined functions shipped - would crash
117
- - Missing requirements shipped - incomplete features
118
- - Time wasted on false completion → redirect → rework
119
- - Violates: "Honesty is a core value. If you lie, you'll be replaced."
120
-
121
- ## When To Apply
122
-
123
- **ALWAYS before:**
124
- - ANY variation of success/completion claims
125
- - ANY expression of satisfaction
126
- - ANY positive statement about work state
127
- - Committing, PR creation, task completion
128
- - Moving to next task
129
- - Delegating to agents
130
-
131
- **Rule applies to:**
132
- - Exact phrases
133
- - Paraphrases and synonyms
134
- - Implications of success
135
- - ANY communication suggesting completion/correctness
136
-
137
- ## Complexity Assessment
138
-
139
- **Lightweight usage:**
140
- - Run core tests, confirm pass
141
- - Applies when session-bootstrap classifies the task as Simple
142
-
143
- **Standard usage:**
144
- - Run all tests + check coverage + verify edge cases
145
-
146
- **Deep usage:**
147
- - Standard + requirements checklist + line-by-line verification + cross-reference with design spec
148
-
149
- ## The Bottom Line
150
-
151
- **No shortcuts for verification.** The principle is non-negotiable; the depth adapts to complexity.
152
-
153
- Run the command. Read the output. THEN claim the result. Whether you run one test or the full suite depends on the task's complexity tier, but you must ALWAYS run something before claiming completion.
1
+ ---
2
+ name: verification-before-completion
3
+ description: Use when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always
4
+ ---
5
+
6
+ # Verification Before Completion
7
+
8
+ ## Overview
9
+
10
+ Claiming work is complete without verification is dishonesty, not efficiency.
11
+
12
+ **Core principle:** Evidence before claims, always.
13
+
14
+ **Violating the letter of this rule is violating the spirit of this rule.**
15
+
16
+ ## The Iron Law
17
+
18
+ ```
19
+ NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE
20
+ ```
21
+
22
+ If you haven't run the verification command in this message, you cannot claim it passes.
23
+
24
+ **This applies at ALL complexity tiers.** What varies is the depth of verification:
25
+ - **Simple tasks:** Run the relevant verification command (tests, linter, build) and confirm it passes
26
+ - **Medium/Complex tasks:** Run full verification suite, check coverage, verify edge cases, review against requirements
27
+
28
+ ## The Gate Function
29
+
30
+ ```
31
+ BEFORE claiming any status or expressing satisfaction:
32
+
33
+ 1. IDENTIFY: What command proves this claim?
34
+ 2. RUN: Execute the FULL command (fresh, complete)
35
+ 3. READ: Full output, check exit code, count failures
36
+ 4. VERIFY: Does output confirm the claim?
37
+ - If NO: State actual status with evidence
38
+ - If YES: State claim WITH evidence
39
+ 5. ONLY THEN: Make the claim
40
+
41
+ Skip any step = lying, not verifying
42
+ ```
43
+
44
+ ## Common Failures
45
+
46
+ | Claim | Requires | Not Sufficient |
47
+ |-------|----------|----------------|
48
+ | Tests pass | Test command output: 0 failures | Previous run, "should pass" |
49
+ | Linter clean | Linter output: 0 errors | Partial check, extrapolation |
50
+ | Build succeeds | Build command: exit 0 | Linter passing, logs look good |
51
+ | Bug fixed | Test original symptom: passes | Code changed, assumed fixed |
52
+ | Regression test works | Red-green cycle verified | Test passes once |
53
+ | Agent completed | VCS diff shows changes | Agent reports "success" |
54
+ | Requirements met | Line-by-line checklist | Tests passing |
55
+
56
+ ## Red Flags - STOP
57
+
58
+ - Using "should", "probably", "seems to"
59
+ - Expressing satisfaction before verification ("Great!", "Perfect!", "Done!", etc.)
60
+ - About to commit/push/PR without verification
61
+ - Trusting agent success reports
62
+ - Relying on partial verification
63
+ - Thinking "just this once"
64
+ - Tired and wanting work over
65
+ - **ANY wording implying success without having run verification**
66
+
67
+ ## Rationalization Prevention
68
+
69
+ | Excuse | Reality |
70
+ |--------|---------|
71
+ | "Should work now" | RUN the verification |
72
+ | "I'm confident" | Confidence ≠ evidence |
73
+ | "Just this once" | No exceptions |
74
+ | "Linter passed" | Linter ≠ compiler |
75
+ | "Agent said success" | Verify independently |
76
+ | "I'm tired" | Exhaustion ≠ excuse |
77
+ | "Partial check is enough" | Partial proves nothing |
78
+ | "Different words so rule doesn't apply" | Spirit over letter |
79
+
80
+ ## Key Patterns
81
+
82
+ **Tests:**
83
+ ```
84
+ ✅ [Run test command] [See: 34/34 pass] "All tests pass"
85
+ ❌ "Should pass now" / "Looks correct"
86
+ ```
87
+
88
+ **Regression tests (TDD Red-Green):**
89
+ ```
90
+ ✅ Write → Run (pass) → Revert fix → Run (MUST FAIL) → Restore → Run (pass)
91
+ ❌ "I've written a regression test" (without red-green verification)
92
+ ```
93
+
94
+ **Build:**
95
+ ```
96
+ ✅ [Run build] [See: exit 0] "Build passes"
97
+ ❌ "Linter passed" (linter doesn't check compilation)
98
+ ```
99
+
100
+ **Requirements:**
101
+ ```
102
+ ✅ Re-read plan → Create checklist → Verify each → Report gaps or completion
103
+ ❌ "Tests pass, phase complete"
104
+ ```
105
+
106
+ **Agent delegation:**
107
+ ```
108
+ ✅ Agent reports success → Check VCS diff → Verify changes → Report actual state
109
+ ❌ Trust agent report
110
+ ```
111
+
112
+ ## Why This Matters
113
+
114
+ From 24 failure memories:
115
+ - your human partner said "I don't believe you" - trust broken
116
+ - Undefined functions shipped - would crash
117
+ - Missing requirements shipped - incomplete features
118
+ - Time wasted on false completion → redirect → rework
119
+ - Violates: "Honesty is a core value. If you lie, you'll be replaced."
120
+
121
+ ## When To Apply
122
+
123
+ **ALWAYS before:**
124
+ - ANY variation of success/completion claims
125
+ - ANY expression of satisfaction
126
+ - ANY positive statement about work state
127
+ - Committing, PR creation, task completion
128
+ - Moving to next task
129
+ - Delegating to agents
130
+
131
+ **Rule applies to:**
132
+ - Exact phrases
133
+ - Paraphrases and synonyms
134
+ - Implications of success
135
+ - ANY communication suggesting completion/correctness
136
+
137
+ ## Complexity Assessment
138
+
139
+ **Lightweight usage:**
140
+ - Run core tests, confirm pass
141
+ - Applies when session-bootstrap classifies the task as Simple
142
+
143
+ **Standard usage:**
144
+ - Run all tests + check coverage + verify edge cases
145
+
146
+ **Deep usage:**
147
+ - Standard + requirements checklist + line-by-line verification + cross-reference with design spec
148
+
149
+ ## The Bottom Line
150
+
151
+ **No shortcuts for verification.** The principle is non-negotiable; the depth adapts to complexity.
152
+
153
+ Run the command. Read the output. THEN claim the result. Whether you run one test or the full suite depends on the task's complexity tier, but you must ALWAYS run something before claiming completion.
@@ -15,7 +15,7 @@ Assume they are a skilled developer, but know almost nothing about our toolset o
15
15
 
16
16
  **Context:** This should be run in a dedicated worktree (created by brainstorming skill).
17
17
 
18
- **Save plans to:** `docs/superpowers/plans/YYYY-MM-DD-<feature-name>.md`
18
+ **Save plans to:** `docs/agent-forge/plans/YYYY-MM-DD-<feature-name>.md`
19
19
  - (User preferences for plan location override this default)
20
20
 
21
21
  ## Scope Check
@@ -148,7 +148,7 @@ If you find issues, fix them inline. No need to re-review — just fix and move
148
148
 
149
149
  After saving the plan, offer execution choice:
150
150
 
151
- **"Plan complete and saved to `docs/superpowers/plans/<filename>.md`. Two execution options:**
151
+ **"Plan complete and saved to `docs/agent-forge/plans/<filename>.md`. Two execution options:**
152
152
 
153
153
  **1. Subagent-Driven (recommended)** - I dispatch a fresh subagent per task, review between tasks, fast iteration
154
154