@zapier/zapier-sdk 0.8.2 → 0.9.0

package/src/plugins/listAuthentications/index.test.ts

@@ -6,7 +6,6 @@ import {
 import { listAuthenticationsPlugin } from "./index";
 import { createSdk } from "../../sdk";
 import type { ApiClient } from "../../api";
-import type { AppItem } from "../../types/domain";
 
 const mockAuthenticationsResponse = {
   results: [
@@ -42,15 +41,6 @@ const mockAuthenticationsResponse = {
   previous: null,
 };
 
-const mockSlackApp: AppItem = {
-  title: "Slack",
-  key: "SlackCLIAPI",
-  current_implementation_id: "SlackCLIAPI@1.21.1",
-  version: "1.21.1",
-  description: "Team communication platform",
-  slug: "slack",
-};
-
 describe("listAuthentications plugin", () => {
   let mockApiClient: ApiClient;
   let mockGetVersionedImplementationId: any;
@@ -72,15 +62,14 @@ describe("listAuthentications plugin", () => {
     },
   });
 
+  const mockResolveAppKeys = vi.fn().mockResolvedValue([]);
+
   const manifestPlugin = () => ({
     context: {
       manifest: null,
       getVersionedImplementationId: mockGetVersionedImplementationId,
-      getManifestEntry: () => ({
-        implementationName: "SlackCLIAPI",
-        version: "1.21.1",
-      }),
-      getImplementation: vi.fn().mockResolvedValue(mockSlackApp),
+      resolveAppKeys: mockResolveAppKeys,
+      updateManifestEntry: vi.fn().mockResolvedValue(["test-key", {}]),
     },
   });
 
@@ -152,6 +141,21 @@ describe("listAuthentications plugin", () => {
       }).toThrow(ZapierValidationError);
     });
 
+    it("should throw validation error for invalid authenticationIds type", () => {
+      const sdk = createTestSdk();
+      expect(() => {
+        sdk.listAuthentications({
+          authenticationIds: "123" as any, // Should be array of strings
+        });
+      }).toThrow(ZapierValidationError);
+
+      expect(() => {
+        sdk.listAuthentications({
+          authenticationIds: [123] as any, // Should be array of strings, not numbers
+        });
+      }).toThrow(ZapierValidationError);
+    });
+
     it("should throw validation error for invalid pageSize", () => {
       const sdk = createTestSdk();
       expect(() => {
@@ -186,6 +190,7 @@ describe("listAuthentications plugin", () => {
       const sdk = createTestSdk();
       const result = await sdk.listAuthentications({
         appKey: "slack",
+        authenticationIds: ["123", "456"],
         search: "workspace",
         title: "My Slack Workspace",
         accountId: "acc_123",
@@ -336,6 +341,38 @@ describe("listAuthentications plugin", () => {
         }),
       );
     });
+
+    it("should pass authenticationIds as ids parameter to API", async () => {
+      const sdk = createTestSdk();
+      await sdk.listAuthentications({
+        authenticationIds: ["123", "456", "789"],
+      });
+
+      expect(mockApiClient.get).toHaveBeenCalledWith(
+        "/api/v4/authentications/",
+        expect.objectContaining({
+          searchParams: expect.objectContaining({
+            ids: "123,456,789",
+          }),
+        }),
+      );
+    });
+
+    it("should not include ids parameter when authenticationIds is empty", async () => {
+      const sdk = createTestSdk();
+      await sdk.listAuthentications({
+        authenticationIds: [],
+      });
+
+      expect(mockApiClient.get).toHaveBeenCalledWith(
+        "/api/v4/authentications/",
+        expect.objectContaining({
+          searchParams: expect.not.objectContaining({
+            ids: expect.anything(),
+          }),
+        }),
+      );
+    });
   });
 
   describe("pagination", () => {

package/src/plugins/listAuthentications/index.ts

@@ -36,11 +36,11 @@ export interface ListAuthenticationsPluginProvides {
 }
 
 export const listAuthenticationsPlugin: Plugin<
-  GetSdkType<ManifestPluginProvides>, // requires getApp in SDK
+  GetSdkType<ManifestPluginProvides>,
   {
     api: ApiClient;
     getVersionedImplementationId: GetVersionedImplementationId;
-  }, // requires api in context
+  },
   ListAuthenticationsPluginProvides
 > = ({ context }) => {
   const listAuthentications = createPaginatedFunction(
@@ -64,6 +64,11 @@ export const listAuthenticationsPlugin: Plugin<
         }
       }
 
+      // Add authenticationIds as ids parameter if provided
+      if (options.authenticationIds && options.authenticationIds.length > 0) {
+        searchParams.ids = options.authenticationIds.join(",");
+      }
+
       // Add other query parameters if provided
       // Use title as search if no explicit search provided
       if (options.search) {

package/src/plugins/listAuthentications/schemas.ts

@@ -16,6 +16,10 @@ export const ListAuthenticationsSchema = z
     appKey: AppKeyPropertySchema.optional().describe(
       "App key of authentications to list (e.g., 'SlackCLIAPI')",
     ),
+    authenticationIds: z
+      .array(z.string())
+      .optional()
+      .describe("List of authentication IDs to filter by"),
     search: z
       .string()
       .optional()