@zapier/zapier-sdk-cli 0.13.11 → 0.13.13

package/src/generators/ast-generator.ts

@@ -8,7 +8,7 @@ import type {
   ManifestPluginProvides,
   AppItem,
 } from "@zapier/zapier-sdk";
-import { toSnakeCase } from "@zapier/zapier-sdk";
+import { toSnakeCase, batch } from "@zapier/zapier-sdk";
 
 interface ActionWithInputFields extends Omit<Action, "inputFields" | "type"> {
   inputFields: InputFieldItem[];
@@ -58,53 +58,61 @@ export class AstTypeGenerator {
     // Fetch input fields for each action
     const actionsWithFields: ActionWithInputFields[] = [];
 
-    if (authenticationId) {
-      for (const action of actions) {
-        try {
-          const fieldsResult = await sdk.listInputFields({
-            appKey: app.implementation_id,
-            actionKey: action.key,
-            actionType: action.action_type,
-            authenticationId: authenticationId,
-          });
-
-          const fields = fieldsResult.data as InputFieldItem[];
-          actionsWithFields.push({
-            ...action,
-            inputFields: fields,
-            name: action.title || action.key,
-          });
-        } catch {
-          // If we can't get fields for an action, include it without fields
-          actionsWithFields.push({
-            ...action,
-            inputFields: [],
-            name: action.title || action.key,
-          });
-        }
+    // Fetch all input fields with concurrency limiting for better reliability
+    // Using batch() instead of Promise.allSettled() prevents overwhelming the API
+    // and triggering rate limits when apps have many actions
+    const inputFieldsTasks = actions.map(
+      (action) => () =>
+        sdk.listInputFields({
+          appKey: app.implementation_id,
+          actionKey: action.key,
+          actionType: action.action_type,
+          authenticationId: authenticationId,
+        }),
+    );
+
+    const results = await batch(inputFieldsTasks, {
+      concurrency: 50, // Limit to 50 concurrent requests
+      retry: true, // Automatically retry transient failures
+      timeoutMs: 180_000, // 3 minute overall timeout
+      taskTimeoutMs: 30_000, // 30 seconds per-task timeout (API calls shouldn't take longer)
+    });
+
+    const failedActions: string[] = [];
+
+    results.forEach((result, i) => {
+      const action = actions[i];
+
+      if (result.status === "fulfilled") {
+        actionsWithFields.push({
+          ...action,
+          inputFields: result.value.data as InputFieldItem[],
+          name: action.title || action.key,
+        });
+      } else {
+        failedActions.push(
+          `${action.key} (${action.action_type}): ${result.reason?.message || "Unknown error"}`,
+        );
+        actionsWithFields.push({
+          ...action,
+          inputFields: [],
+          name: action.title || action.key,
+          app_key: action.app_key || app.implementation_id,
+          action_type: (action.action_type as Action["type"]) || "write",
+          title: action.title || action.key,
+          type: "action" as const,
+          description: action.description || "",
+        });
       }
-    } else {
-      // Convert actions to have empty input fields (will generate generic types)
-      actions.forEach(
-        (action: {
-          key: string;
-          title?: string;
-          app_key?: string;
-          action_type?: string;
-          description?: string;
-        }) => {
-          actionsWithFields.push({
-            ...action,
-            inputFields: [],
-            name: action.title || action.key,
-            app_key: action.app_key || app.implementation_id,
-            action_type: (action.action_type as Action["type"]) || "write",
-            title: action.title || action.key,
-            type: "action" as const,
-            description: action.description || "",
-          });
-        },
+    });
+
+    if (failedActions.length > 0) {
+      console.warn(
+        `Failed to fetch input fields for ${failedActions.length} action(s):`,
       );
+      failedActions.forEach((failedAction) => {
+        console.warn(`  - ${failedAction}`);
+      });
     }
 
     // Generate TypeScript AST nodes