@zambon-dev/framework 1.3.0 → 1.4.0

package/CHANGELOG.md

@@ -23,6 +23,62 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### ⚠ Breaking Changes / Migration
 
+## [1.4.0] - 2026-09-16
+
+### Changed
+
+- **`framework-button-filters` no longer submits the labels of catalog selections.** A filters
+  form reads its values straight off the form, so the display control `lib-catalog-select` adds
+  for its own use went to the backend beside the real filters — a request filtering by employee
+  carried `employeeName: "753 - ADEMILSON LOPES MAGALHAES"` next to `employeeID: 125`.
+
+  They were ignored, being filters no service declares, but the day one does filter by a name it
+  would receive the formatted label rather than the stored value and quietly match nothing.
+
+  The labels are still **kept** for the modal: reopening it patches them back into the form, and a
+  catalog select backed by a `searchEndpoint` cannot recover its text from the identifier alone —
+  it only resolves a display out of a local entries list. Dropping them from what is stored would
+  have left the field showing a selection with nothing written in it.
+
+### ⚠ Breaking Changes / Migration
+
+- **Upgrade `@zambon-dev/library` together with this release.** The peer range moved from
+  `^1.0.0` to `^1.6.0`, because `framework-button-filters` now imports `DisplayControls` from it.
+  On an older library that export does not exist, and the filters button fails — at build time if
+  the bundler checks exports, otherwise the first time a filter is submitted. The old range would
+  have let npm resolve that combination without a word of warning.
+
+- **A backend no longer receives the label of a catalog selection.** If one of your services
+  filters by a key that a `lib-catalog-select` uses as its `displayControlName` — the `xxxName`
+  that comes paired with an `xxxID` — that filter now arrives empty and the query stops narrowing,
+  silently returning more rows than before rather than failing.
+
+  To check, take each filters form and, for every `lib-catalog-select` in it, note the
+  `displayControlName`. Then look for a `TryFilter` on that name in the service behind the list.
+  Any hit has to move to the identifier instead: the label was never the stored value — it is what
+  the catalog chose to display, so filtering by it was already matching on formatting.
+
+## [1.3.1] - 2026-09-10
+
+### Fixed
+
+- **Returning to an already-open tab no longer crashes with `Maximum call stack size exceeded`.**
+  It affected any screen whose route nests two empty-path levels — the shape every list screen uses:
+  `path: ''` with `DefaultTabViewComponent`, and a child `path: ''` with the list component.
+
+  `CustomReuseStrategy` keyed its detached-view cache on `route.component.name`, and a production
+  build renames every class: esbuild wraps each component as `X = (() => { class i { } return i; })()`,
+  so the name is one mangled letter that the whole chunk shares. An empty path contributes no URL
+  segment, so both levels also resolved to the same URL — which left the two cache keys identical.
+  Storing one handle overwrote the other, both route levels were then handed the same detached view,
+  and Angular blew the stack building a router state whose node was its own descendant.
+
+  The key is now built from the component's **identity** and the route's depth rather than its name.
+  Applications need to change nothing. Worth knowing when reading old reports of this crash: it only
+  ever reproduced in a minified build — `ng serve` keeps real class names — and only on the screens
+  whose chunk happened to mangle to the same letter as the framework's, so a rebuild could move the
+  symptom from one screen to another.
+
 ## [1.3.0] - 2026-07-30
 
 ### Added
@@ -121,7 +177,9 @@ None.
   available via [GitHub Releases](https://github.com/RicardoZambon/ZLibraries/releases) and the
   `framework-v*` tags.
 
-[Unreleased]: https://github.com/RicardoZambon/ZLibraries/compare/framework-v1.3.0...HEAD
+[Unreleased]: https://github.com/RicardoZambon/ZLibraries/compare/framework-v1.4.0...HEAD
+[1.4.0]: https://github.com/RicardoZambon/ZLibraries/releases/tag/framework-v1.4.0
+[1.3.1]: https://github.com/RicardoZambon/ZLibraries/releases/tag/framework-v1.3.1
 [1.3.0]: https://github.com/RicardoZambon/ZLibraries/releases/tag/framework-v1.3.0
 [1.2.1]: https://github.com/RicardoZambon/ZLibraries/releases/tag/framework-v1.2.1
 [1.2.0]: https://github.com/RicardoZambon/ZLibraries/releases/tag/framework-v1.2.0

package/fesm2022/zambon-dev-framework.mjs

@@ -1,7 +1,7 @@
 import * as i0 from '@angular/core';
 import { inject, ApplicationRef, Inject, Injectable, Component, ViewChild, Input, EventEmitter, Output, NgModule, forwardRef, ChangeDetectorRef, InjectionToken } from '@angular/core';
 import * as i1$2 from '@zambon-dev/library';
-import { RibbonGroupChild, RibbonButtonComponent, DataProviderService, FormService, ModalComponent, DataGridDataset, MultiSelectResultDataset, RouterFormatter, MultiEditorComponent, MultiEditorDataset, MultiSelectComponent, RibbonComponent, GroupContainerComponent, RibbonGroupComponent, DataGridConfigsProvider } from '@zambon-dev/library';
+import { RibbonGroupChild, RibbonButtonComponent, DataProviderService, FormService, ModalComponent, DataGridDataset, DisplayControls, MultiSelectResultDataset, RouterFormatter, MultiEditorComponent, MultiEditorDataset, MultiSelectComponent, RibbonComponent, GroupContainerComponent, RibbonGroupComponent, DataGridConfigsProvider } from '@zambon-dev/library';
 export { DateValidators } from '@zambon-dev/library';
 import { ReplaySubject, take, map, switchMap, of, Subject, takeUntil, filter, skip, tap, throwError } from 'rxjs';
 import { __decorate } from 'tslib';
@@ -121,6 +121,8 @@ let CustomReuseStrategy = class CustomReuseStrategy {
     tabService;
     applicationRef = inject(ApplicationRef);
     cachedHandles = {};
+    componentIDs = new WeakMap();
+    nextComponentID = 1;
     //#endregion
     //#region Properties
     //#endregion
@@ -193,8 +195,39 @@ let CustomReuseStrategy = class CustomReuseStrategy {
         if (this.clones[url]) {
             url = this.clones[url];
         }
-        const componentName = route.component?.name ?? '';
-        return `${url}-${componentName}`;
+        // The component is identified by identity, never by name. A production build renames every
+        // class: esbuild wraps each component as `X = (() => { class i { } return i; })()`, so
+        // `component.name` is a single mangled letter that the whole chunk shares. Nested empty-path
+        // routes already resolve to the same URL, because an empty path contributes no segment, so a
+        // key built from the name collapsed a screen's tab view and its list into one entry: storing
+        // one overwrote the other, both levels were then handed the same detached view, and Angular
+        // blew the stack building a router state whose node was its own descendant. That reproduced
+        // only in a minified build, and only on the screens whose chunk happened to mangle to the
+        // same letter as the framework's.
+        //
+        // The depth is part of the key too, so two sibling routes sharing a component type under one
+        // URL cannot collide either.
+        return `${url}-${this.getRouteDepth(route)}-${this.getComponentID(route.component)}`;
+    }
+    getComponentID(component) {
+        if (typeof component !== 'function') {
+            return 0;
+        }
+        let componentID = this.componentIDs.get(component);
+        if (componentID === undefined) {
+            componentID = this.nextComponentID++;
+            this.componentIDs.set(component, componentID);
+        }
+        return componentID;
+    }
+    getRouteDepth(route) {
+        let depth = 0;
+        let current = route.parent;
+        while (current) {
+            depth++;
+            current = current.parent;
+        }
+        return depth;
     }
     getUrlFromRoute(route) {
         const segments = [];
@@ -1430,14 +1463,35 @@ class ButtonFiltersComponent extends BaseButton {
     //#endregion
     //#region Public methods
     setFilters(filters) {
+        // Kept whole, because reopening the modal patches this straight back into the form and a
+        // catalog select backed by a search endpoint cannot recover its label from the identifier --
+        // it only resolves a display from a local entries list. Dropping the labels here would leave
+        // the field showing a selection with no text.
         this.filters = filters;
         if (this.hasFiltersApplied) {
-            this.gridDataset.setFilters(filters);
+            this.gridDataset.setFilters(this.withoutDisplayControls(filters));
         }
         else {
             this.gridDataset.setFilters();
         }
     }
+    //#endregion
+    //#region Private methods
+    /**
+     * Drops the controls that only hold a catalog selection's label.
+     *
+     * They are half of how `lib-catalog-select` works and are created by it, so a screen never asked
+     * for them and a backend has no filter behind them. Sent anyway they are dead weight, and worse:
+     * the day a service does filter by a name, it would receive the formatted label rather than the
+     * stored value and quietly match nothing.
+     *
+     * @param filters The filters as submitted.
+     * @returns The filters a backend should receive.
+     */
+    withoutDisplayControls(filters) {
+        return Object.fromEntries(Object.entries(filters)
+            .filter(([key]) => !DisplayControls.isDisplayControl(this.formGroup.form.get(key))));
+    }
     static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "19.1.6", ngImport: i0, type: ButtonFiltersComponent, deps: [], target: i0.ɵɵFactoryTarget.Component });
     static ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0", version: "19.1.6", type: ButtonFiltersComponent, isStandalone: true, selector: "framework-button-filters", inputs: { modalSize: "modalSize", modalTitle: "modalTitle", validateFormFunction: "validateFormFunction" }, providers: [
             FormService,