@yuneta/gobj-ui 7.26.37 → 7.26.39

package/README.md

@@ -3325,6 +3325,38 @@ keeps working afterwards. With no guard a modal closes exactly as it always
 did, and the returned `close()` always closes **unconditionally** — the veto is
 for the user's dismiss, not for the code's.
 
+**A guard that ASKS returns the question's promise** (7.26.38+). It is a veto
+too, and it tells the modal when the question is over: a browser Back that
+asked gets its history entry back THEN, below nothing. Opening the question and
+returning `false` put the entry back at once, above the question's own -- so the
+next Back, the one meant for the question, reached the modal, which asked
+again, and on a phone (where Back is a gesture) every Back stacked one more
+question.
+
+```js
+const sheet = yui_shell_show_modal(shell, $body, {
+    dialog:       true,
+    title:        "device settings",
+    t:            t,
+    before_close: () => {
+        const kw = {};
+        gobj_send_event(form, "EV_WINDOW_TO_CLOSE", kw, gobj);
+        if(!kw.abort_close) {
+            return true;
+        }
+        return yui_shell_confirm_yesnocancel(shell, "all changes will be lost", {t})
+            .then((answer) => {
+                if(answer === "yes") {
+                    gobj_send_event(gobj, "EV_CLOSE_SHEET", {}, gobj);  // its action: sheet.close()
+                }
+            });
+    },
+    on_close:     () => {
+        gobj_send_event(gobj, "EV_SHEET_CLOSED", {}, gobj);  // its action: destroy the form
+    }
+});
+```
+
 ### Confirmations — and the red one, `yui_shell_confirm_danger`
 
 `yui_shell_confirm_yesno(shell, message, opts)` asks a question and resolves to
@@ -3362,6 +3394,26 @@ the middle, and **a toolbar left with a single group is centred**. An unknown
 name is reported, not silently dropped: a typo would otherwise remove the save
 button with no trace of why.
 
+### `C_YUI_FORM` — what closing it asks about
+
+`changes` says the form is not what is stored: the reader changed it, or the
+record lacks a field that has a default, and the form shows the default. The
+save lights with it. **`edited`** (7.26.39+) says the READER changed it --
+typed, cleared, pasted -- since it was loaded, saved or undone, and it is the
+only thing a close asks about: the form answers `EV_WINDOW_TO_CLOSE` with
+`abort_close` and the warning *"all changes will be lost"* when `edited` is
+true. A record that lacks a defaulted field opens changed and closes without
+a question; until 7.26.39 it asked on every close, about nothing the reader
+would lose.
+
+```js
+const kw = {abort_close: false};
+gobj_send_event(form, "EV_WINDOW_TO_CLOSE", kw, gobj);
+if(kw.abort_close) {
+    // the reader changed it: ask kw.warning before closing
+}
+```
+
 ### `C_YUI_FORM` — which field is editable, and the one `writable` does not govern
 
 A form opened to LOOK at a record has no editable field: that is a property of

package/dist/gobj-ui.cjs.js

@@ -3970,6 +3970,10 @@ function yui_shell_show_modal(shell, content, opts) {
 			(0, _yuneta_gobj_js.log_warning)(`yui_shell_show_modal: before_close threw: ${e}`);
 			allow = true;
 		}
+		if (allow && typeof allow.then === "function") {
+			if (typeof on_veto === "function") allow.then(on_veto, on_veto);
+			return;
+		}
 		if (allow === false) {
 			if (typeof on_veto === "function") on_veto();
 			return;
@@ -3981,7 +3985,7 @@ function yui_shell_show_modal(shell, content, opts) {
 	};
 	let on_back = function() {
 		guarded_close(function() {
-			overlay = yui_shell_register_overlay(shell, on_back);
+			if (!closed) overlay = yui_shell_register_overlay(shell, on_back);
 		});
 	};
 	escape_handler = request_close;
@@ -9479,6 +9483,7 @@ var attrs_table$17 = [
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_STRING, "form_id", 0, "", "Form identifier"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_BOOLEAN, "initialized", 0, false, "Indicates if it is initialized"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_BOOLEAN, "changes", 0, false, "Indicates if changes have been made"),
+	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_BOOLEAN, "edited", 0, false, "The reader changed the form (typed, cleared, pasted) since it was loaded, saved or undone: what closing it would lose. A field the record lacks, filled with its default, is a change of the form (`changes`) and not of the reader"),
 	(0, _yuneta_gobj_js.SDATA_END)()
 ];
 var PRIVATE_DATA$17 = {
@@ -9572,6 +9577,7 @@ function set_changed_stated(gobj, changed) {
 		});
 	} else {
 		(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "changes", false);
+		(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "edited", false);
 		enable($button_save, false, OFF_COLOR);
 		enable($button_undo, false, OFF_COLOR);
 		if (gobj.priv.rearm_timer) clearTimeout(gobj.priv.rearm_timer);
@@ -9595,6 +9601,16 @@ function set_changed_stated(gobj, changed) {
 	}
 }
 /************************************************************
+*  A change the READER made -- typed, cleared, pasted: what
+*  closing the form would lose (ac_window_to_close). Clearing
+*  and pasting wrote their values and marked nothing, so a form
+*  cleared or pasted into kept its save off.
+************************************************************/
+function set_edited_by_reader(gobj) {
+	set_changed_stated(gobj, true);
+	(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "edited", true);
+}
+/************************************************************
 *
 ************************************************************/
 async function readClipboard$1(gobj) {
@@ -11976,10 +11992,16 @@ function form_value_2_treedb_value(gobj, field_desc, value) {
 *      Actions
 ***************************/
 /************************************************************
-*  From Window parent, is going to close
+*  From Window parent, is going to close.
+*
+*  It asks only for what the READER changed (`edited`). A record
+*  that lacks a field opens CHANGED -- the default fills it, and
+*  the save lights to store it -- but the reader did nothing, and
+*  the question asked of every such record, on every close, was
+*  about nothing they would lose.
 ************************************************************/
 function ac_window_to_close(gobj, event, kw, src) {
-	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "changes")) {
+	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "edited")) {
 		kw.abort_close = true;
 		kw.warning = "all changes will be lost";
 	}
@@ -11995,6 +12017,7 @@ function ac_load_record(gobj, event, kw, src) {
 	let modified = set_form_values(gobj, (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "template"), $form, kw);
 	apply_form_mode(gobj, $form);
 	set_changed_stated(gobj, modified);
+	(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "edited", false);
 	(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "initialized", true);
 	return 0;
 }
@@ -12038,6 +12061,7 @@ function ac_clear_record(gobj, event, kw, src) {
 	let $form = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "$container").querySelector("form");
 	clear_validation(gobj, $form);
 	clear_data(gobj, $form);
+	set_edited_by_reader(gobj);
 	return 0;
 }
 /************************************************************
@@ -12116,7 +12140,7 @@ function ac_add_table_row(gobj, event, kw, src) {
 *  Internal event
 ************************************************************/
 function ac_record_changed(gobj, event, kw, src) {
-	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "initialized")) set_changed_stated(gobj, true);
+	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "initialized")) set_edited_by_reader(gobj);
 	return 0;
 }
 /************************************************************
@@ -12139,6 +12163,7 @@ function ac_paste_record(gobj, event, kw, src) {
 	if ((0, _yuneta_gobj_js.is_object)(record)) {
 		(0, _yuneta_gobj_js.gobj_write_bool_attr)(gobj, "initialized", true);
 		set_form_values(gobj, (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "template"), $form, record);
+		set_edited_by_reader(gobj);
 	}
 	return 0;
 }
@@ -31549,19 +31574,19 @@ function open_form_dialog(gobj, mode, record) {
 }
 /************************************************************
 *  Unsaved-changes guard for the dialog's `before_close` hook.
-*  Returns true to allow the dismiss; false to VETO it (the form
-*  has pending edits) and pop the confirm — which, on "yes",
-*  closes the modal itself (EV_WINDOW_TO_CLOSE contract).
+*  Returns true to allow the dismiss; otherwise the form has
+*  pending edits, and it asks: the confirm's promise is a VETO
+*  that tells the dialog when the question is over (a Back that
+*  asked gets its history entry back then, below nothing). On
+*  "yes" the confirm closes the modal itself (EV_WINDOW_TO_CLOSE
+*  contract).
 ************************************************************/
 function form_may_close(gobj) {
 	let priv = gobj.priv;
 	if (priv.form) {
 		let kw = {};
 		(0, _yuneta_gobj_js.gobj_send_event)(priv.form, "EV_WINDOW_TO_CLOSE", kw, gobj);
-		if (kw.abort_close) {
-			confirm_then$1(gobj, kw.warning || "all changes will be lost", { what: "close_form" });
-			return false;
-		}
+		if (kw.abort_close) return confirm_then$1(gobj, kw.warning || "all changes will be lost", { what: "close_form" });
 	}
 	return true;
 }
@@ -31595,10 +31620,11 @@ function teardown_form_child(gobj) {
 *  it, and a gobj, a Tabulator row or a DOM node in there is a
 *  circular structure that breaks the very trace the FSM feeds.
 *
-*  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then().
+*  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then(). Answers
+*  the promise of the question, settled once it is over.
 ************************************************************/
 function confirm_then$1(gobj, message, kw) {
-	yui_shell_confirm_yesnocancel(yui_shell_of(gobj), message, {
+	return yui_shell_confirm_yesnocancel(yui_shell_of(gobj), message, {
 		t: i18next.t,
 		yes_label: "yes",
 		no_label: "no",

package/dist/gobj-ui.es.js

@@ -3965,6 +3965,10 @@ function yui_shell_show_modal(shell, content, opts) {
 			log_warning(`yui_shell_show_modal: before_close threw: ${e}`);
 			allow = true;
 		}
+		if (allow && typeof allow.then === "function") {
+			if (typeof on_veto === "function") allow.then(on_veto, on_veto);
+			return;
+		}
 		if (allow === false) {
 			if (typeof on_veto === "function") on_veto();
 			return;
@@ -3976,7 +3980,7 @@ function yui_shell_show_modal(shell, content, opts) {
 	};
 	let on_back = function() {
 		guarded_close(function() {
-			overlay = yui_shell_register_overlay(shell, on_back);
+			if (!closed) overlay = yui_shell_register_overlay(shell, on_back);
 		});
 	};
 	escape_handler = request_close;
@@ -9474,6 +9478,7 @@ var attrs_table$17 = [
 	SDATA(data_type_t.DTP_STRING, "form_id", 0, "", "Form identifier"),
 	SDATA(data_type_t.DTP_BOOLEAN, "initialized", 0, false, "Indicates if it is initialized"),
 	SDATA(data_type_t.DTP_BOOLEAN, "changes", 0, false, "Indicates if changes have been made"),
+	SDATA(data_type_t.DTP_BOOLEAN, "edited", 0, false, "The reader changed the form (typed, cleared, pasted) since it was loaded, saved or undone: what closing it would lose. A field the record lacks, filled with its default, is a change of the form (`changes`) and not of the reader"),
 	SDATA_END()
 ];
 var PRIVATE_DATA$17 = {
@@ -9567,6 +9572,7 @@ function set_changed_stated(gobj, changed) {
 		});
 	} else {
 		gobj_write_bool_attr(gobj, "changes", false);
+		gobj_write_bool_attr(gobj, "edited", false);
 		enable($button_save, false, OFF_COLOR);
 		enable($button_undo, false, OFF_COLOR);
 		if (gobj.priv.rearm_timer) clearTimeout(gobj.priv.rearm_timer);
@@ -9590,6 +9596,16 @@ function set_changed_stated(gobj, changed) {
 	}
 }
 /************************************************************
+*  A change the READER made -- typed, cleared, pasted: what
+*  closing the form would lose (ac_window_to_close). Clearing
+*  and pasting wrote their values and marked nothing, so a form
+*  cleared or pasted into kept its save off.
+************************************************************/
+function set_edited_by_reader(gobj) {
+	set_changed_stated(gobj, true);
+	gobj_write_bool_attr(gobj, "edited", true);
+}
+/************************************************************
 *
 ************************************************************/
 async function readClipboard$1(gobj) {
@@ -11971,10 +11987,16 @@ function form_value_2_treedb_value(gobj, field_desc, value) {
 *      Actions
 ***************************/
 /************************************************************
-*  From Window parent, is going to close
+*  From Window parent, is going to close.
+*
+*  It asks only for what the READER changed (`edited`). A record
+*  that lacks a field opens CHANGED -- the default fills it, and
+*  the save lights to store it -- but the reader did nothing, and
+*  the question asked of every such record, on every close, was
+*  about nothing they would lose.
 ************************************************************/
 function ac_window_to_close(gobj, event, kw, src) {
-	if (gobj_read_bool_attr(gobj, "changes")) {
+	if (gobj_read_bool_attr(gobj, "edited")) {
 		kw.abort_close = true;
 		kw.warning = "all changes will be lost";
 	}
@@ -11990,6 +12012,7 @@ function ac_load_record(gobj, event, kw, src) {
 	let modified = set_form_values(gobj, gobj_read_attr(gobj, "template"), $form, kw);
 	apply_form_mode(gobj, $form);
 	set_changed_stated(gobj, modified);
+	gobj_write_bool_attr(gobj, "edited", false);
 	gobj_write_bool_attr(gobj, "initialized", true);
 	return 0;
 }
@@ -12033,6 +12056,7 @@ function ac_clear_record(gobj, event, kw, src) {
 	let $form = gobj_read_attr(gobj, "$container").querySelector("form");
 	clear_validation(gobj, $form);
 	clear_data(gobj, $form);
+	set_edited_by_reader(gobj);
 	return 0;
 }
 /************************************************************
@@ -12111,7 +12135,7 @@ function ac_add_table_row(gobj, event, kw, src) {
 *  Internal event
 ************************************************************/
 function ac_record_changed(gobj, event, kw, src) {
-	if (gobj_read_bool_attr(gobj, "initialized")) set_changed_stated(gobj, true);
+	if (gobj_read_bool_attr(gobj, "initialized")) set_edited_by_reader(gobj);
 	return 0;
 }
 /************************************************************
@@ -12134,6 +12158,7 @@ function ac_paste_record(gobj, event, kw, src) {
 	if (is_object(record)) {
 		gobj_write_bool_attr(gobj, "initialized", true);
 		set_form_values(gobj, gobj_read_attr(gobj, "template"), $form, record);
+		set_edited_by_reader(gobj);
 	}
 	return 0;
 }
@@ -31544,19 +31569,19 @@ function open_form_dialog(gobj, mode, record) {
 }
 /************************************************************
 *  Unsaved-changes guard for the dialog's `before_close` hook.
-*  Returns true to allow the dismiss; false to VETO it (the form
-*  has pending edits) and pop the confirm — which, on "yes",
-*  closes the modal itself (EV_WINDOW_TO_CLOSE contract).
+*  Returns true to allow the dismiss; otherwise the form has
+*  pending edits, and it asks: the confirm's promise is a VETO
+*  that tells the dialog when the question is over (a Back that
+*  asked gets its history entry back then, below nothing). On
+*  "yes" the confirm closes the modal itself (EV_WINDOW_TO_CLOSE
+*  contract).
 ************************************************************/
 function form_may_close(gobj) {
 	let priv = gobj.priv;
 	if (priv.form) {
 		let kw = {};
 		gobj_send_event(priv.form, "EV_WINDOW_TO_CLOSE", kw, gobj);
-		if (kw.abort_close) {
-			confirm_then$1(gobj, kw.warning || "all changes will be lost", { what: "close_form" });
-			return false;
-		}
+		if (kw.abort_close) return confirm_then$1(gobj, kw.warning || "all changes will be lost", { what: "close_form" });
 	}
 	return true;
 }
@@ -31590,10 +31615,11 @@ function teardown_form_child(gobj) {
 *  it, and a gobj, a Tabulator row or a DOM node in there is a
 *  circular structure that breaks the very trace the FSM feeds.
 *
-*  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then().
+*  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then(). Answers
+*  the promise of the question, settled once it is over.
 ************************************************************/
 function confirm_then$1(gobj, message, kw) {
-	yui_shell_confirm_yesnocancel(yui_shell_of(gobj), message, {
+	return yui_shell_confirm_yesnocancel(yui_shell_of(gobj), message, {
 		t,
 		yes_label: "yes",
 		no_label: "no",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yuneta/gobj-ui",
-  "version": "7.26.37",
+  "version": "7.26.39",
   "type": "module",
   "main": "dist/gobj-ui.cjs.js",
   "module": "dist/gobj-ui.es.js",

package/src/c_yui_form.js

@@ -167,6 +167,7 @@ SDATA(data_type_t.DTP_POINTER,  "$container",       0,  null,   "Container eleme
 SDATA(data_type_t.DTP_STRING,   "form_id",          0,  "",     "Form identifier"),
 SDATA(data_type_t.DTP_BOOLEAN,  "initialized",      0,  false,  "Indicates if it is initialized"),
 SDATA(data_type_t.DTP_BOOLEAN,  "changes",          0,  false,  "Indicates if changes have been made"),
+SDATA(data_type_t.DTP_BOOLEAN,  "edited",           0,  false,  "The reader changed the form (typed, cleared, pasted) since it was loaded, saved or undone: what closing it would lose. A field the record lacks, filled with its default, is a change of the form (`changes`) and not of the reader"),
 SDATA_END()
 ];
 
@@ -349,6 +350,7 @@ function set_changed_stated(gobj, changed)
          *  Data not changed, disable buttons to save/undo
          */
         gobj_write_bool_attr(gobj, "changes", false);
+        gobj_write_bool_attr(gobj, "edited", false);
 
         enable($button_save, false, OFF_COLOR);
         enable($button_undo, false, OFF_COLOR);
@@ -390,6 +392,18 @@ function set_changed_stated(gobj, changed)
     }
 }
 
+/************************************************************
+ *  A change the READER made -- typed, cleared, pasted: what
+ *  closing the form would lose (ac_window_to_close). Clearing
+ *  and pasting wrote their values and marked nothing, so a form
+ *  cleared or pasted into kept its save off.
+ ************************************************************/
+function set_edited_by_reader(gobj)
+{
+    set_changed_stated(gobj, true);
+    gobj_write_bool_attr(gobj, "edited", true);
+}
+
 /************************************************************
  *
  ************************************************************/
@@ -3606,11 +3620,17 @@ function form_value_2_treedb_value(gobj, field_desc, value)
 
 
 /************************************************************
- *  From Window parent, is going to close
+ *  From Window parent, is going to close.
+ *
+ *  It asks only for what the READER changed (`edited`). A record
+ *  that lacks a field opens CHANGED -- the default fills it, and
+ *  the save lights to store it -- but the reader did nothing, and
+ *  the question asked of every such record, on every close, was
+ *  about nothing they would lose.
  ************************************************************/
 function ac_window_to_close(gobj, event, kw, src)
 {
-    if(gobj_read_bool_attr(gobj, "changes")) {
+    if(gobj_read_bool_attr(gobj, "edited")) {
         kw.abort_close = true; // Don't close the window until fields repaired
         /*  An i18n KEY, not a sentence: the dialog renders its message with
          *  `i18n: message`. The English sentence that was here was a key
@@ -3634,6 +3654,7 @@ function ac_load_record(gobj, event, kw, src)
     let modified = set_form_values(gobj, gobj_read_attr(gobj, "template"), $form, kw);
     apply_form_mode(gobj, $form);
     set_changed_stated(gobj, modified);
+    gobj_write_bool_attr(gobj, "edited", false);
     gobj_write_bool_attr(gobj, "initialized", true);
 
     return 0;
@@ -3707,6 +3728,7 @@ function ac_clear_record(gobj, event, kw, src)
     let $form = $container.querySelector('form');
     clear_validation(gobj, $form);
     clear_data(gobj, $form);
+    set_edited_by_reader(gobj);
     return 0;
 }
 
@@ -3820,7 +3842,7 @@ function ac_add_table_row(gobj, event, kw, src)
 function ac_record_changed(gobj, event, kw, src)
 {
     if(gobj_read_bool_attr(gobj, "initialized")) {
-        set_changed_stated(gobj, true);
+        set_edited_by_reader(gobj);
     }
     return 0;
 }
@@ -3854,6 +3876,7 @@ function ac_paste_record(gobj, event, kw, src)
     if(is_object(record)) {
         gobj_write_bool_attr(gobj, "initialized", true);
         set_form_values(gobj, gobj_read_attr(gobj, "template"), $form, record);
+        set_edited_by_reader(gobj);
     }
     return 0;
 }

package/src/c_yui_treedb_topic_with_form.js

@@ -2554,9 +2554,12 @@ function open_form_dialog(gobj, mode, record)
 
 /************************************************************
  *  Unsaved-changes guard for the dialog's `before_close` hook.
- *  Returns true to allow the dismiss; false to VETO it (the form
- *  has pending edits) and pop the confirm — which, on "yes",
- *  closes the modal itself (EV_WINDOW_TO_CLOSE contract).
+ *  Returns true to allow the dismiss; otherwise the form has
+ *  pending edits, and it asks: the confirm's promise is a VETO
+ *  that tells the dialog when the question is over (a Back that
+ *  asked gets its history entry back then, below nothing). On
+ *  "yes" the confirm closes the modal itself (EV_WINDOW_TO_CLOSE
+ *  contract).
  ************************************************************/
 function form_may_close(gobj)
 {
@@ -2570,9 +2573,8 @@ function form_may_close(gobj)
              *  a second key to define — and the one that was here had never
              *  been defined in any locale, which renders as the English
              *  sentence itself, in every language, for ever. */
-            confirm_then(gobj, /* i18n: C_YUI_FORM_I18N_KEYS */ kw.warning || "all changes will be lost",
+            return confirm_then(gobj, /* i18n: C_YUI_FORM_I18N_KEYS */ kw.warning || "all changes will be lost",
                 {what: "close_form"});
-            return false;
         }
     }
     return true;
@@ -2612,11 +2614,12 @@ function teardown_form_child(gobj)
  *  it, and a gobj, a Tabulator row or a DOM node in there is a
  *  circular structure that breaks the very trace the FSM feeds.
  *
- *  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then().
+ *  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then(). Answers
+ *  the promise of the question, settled once it is over.
  ************************************************************/
 function confirm_then(gobj, message, kw)
 {
-    yui_shell_confirm_yesnocancel(
+    return yui_shell_confirm_yesnocancel(
         yui_shell_of(gobj), message,
         {t: t, yes_label: "yes", no_label: "no", cancel_label: "cancel"}
     ).then(function(answer) {

package/src/form_close_asks_for_edits.wiring.test.js

@@ -0,0 +1,197 @@
+/***********************************************************************
+ *          form_close_asks_for_edits.wiring.test.js
+ *
+ *      Closing a C_YUI_FORM asks "all changes will be lost" only for what
+ *      the READER changed. A field the record lacks is filled with its
+ *      default when the record is loaded: the form then differs from what
+ *      is stored, and its save lights (`changes`) -- but the reader did
+ *      nothing, and the close asked all the same. In estadodelaire that
+ *      was every device whose alarm colours a save had wiped (16 of 19),
+ *      on every close of its settings. What the reader does -- types,
+ *      clears, pastes -- is `edited`, and that is what the close asks
+ *      about.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {describe, test, expect, beforeAll, beforeEach} from "vitest";
+import {install_dom_double} from "../test/dom_double.js";
+
+install_dom_double();
+
+if(typeof globalThis.ResizeObserver === "undefined") {
+    globalThis.ResizeObserver = class {
+        observe() {}
+        unobserve() {}
+        disconnect() {}
+    };
+}
+
+const {
+    SDATA_END, gclass_create,
+    gobj_start_up, gobj_create_yuno, gobj_create_pure_child,
+    gobj_start, gobj_send_event, gobj_read_attr,
+    set_log_callback,
+} = await import("@yuneta/gobj-js");
+const {register_c_yui_form} = await import("./c_yui_form.js");
+
+const logged = [];
+let yuno = null;
+
+/*  The settings template of an estadodelaire device type, cut down: a
+ *  field with a default beside a sub-form of three.  */
+const TEMPLATE = {
+    template_version: {
+        type: "integer",
+        default: 7,
+        flag: ["hidden", "persistent"]
+    },
+    alarm_colors: {
+        type: "object",
+        flag: ["writable", "persistent", "template"],
+        template: {
+            active_not_validated: {
+                type: "string",
+                default: "red",
+                flag: ["writable", "persistent", "color"]
+            },
+            active_validated: {
+                type: "string",
+                default: "#e5a50a",
+                flag: ["writable", "persistent", "color"]
+            },
+            not_active_not_validated: {
+                type: "string",
+                default: "Fuchsia",
+                flag: ["writable", "persistent", "color"]
+            }
+        }
+    }
+};
+
+const COMPLETE = {
+    template_version: 7,
+    alarm_colors: {
+        active_not_validated: "#ff0000",
+        active_validated: "#e5a50a",
+        not_active_not_validated: "#ff00ff"
+    }
+};
+
+beforeAll(async () => {
+    const i18next = (await import("i18next")).default;
+    await i18next.init({lng: "en", resources: {}});
+    gobj_start_up(null, null, null, null, null, null, null);
+    set_log_callback((level, msg) => {
+        logged.push({level: String(level), msg: String(msg)});
+    });
+    gclass_create("C_TEST_CLOSE_HOST", [], [["ST_IDLE", []]], {}, 0, [SDATA_END()], {}, 0, 0, 0, 0);
+    gclass_create(
+        "C_TEST_CLOSE_APP",
+        [["EV_SAVE_RECORD", 0]],
+        [["ST_IDLE", [
+            ["EV_SAVE_RECORD", () => 0, null],
+        ]]],
+        {}, 0, [SDATA_END()], {}, 0, 0, 0, 0
+    );
+    register_c_yui_form();
+    yuno = gobj_create_yuno("form_close_yuno", "C_TEST_CLOSE_HOST", {});
+    gobj_start(yuno);
+});
+
+beforeEach(() => {
+    logged.length = 0;
+});
+
+let seq = 0;
+
+function build(record)
+{
+    const app = gobj_create_pure_child(`capp${++seq}`, "C_TEST_CLOSE_APP", {}, yuno);
+    gobj_start(app);
+    const form = gobj_create_pure_child(`cform${seq}`, "C_YUI_FORM", {
+        template: TEMPLATE,
+        record: record,
+        editable: true,
+    }, app);
+    gobj_start(form);
+    return form;
+}
+
+/*  What a window or a sheet asks the form before it closes.  */
+function close_asks(form)
+{
+    const kw = {abort_close: false};
+    gobj_send_event(form, "EV_WINDOW_TO_CLOSE", kw, form);
+    return kw.abort_close ? (kw.warning || "(no warning)") : "";
+}
+
+function errors()
+{
+    return logged.filter(l => /error/i.test(l.level) || /ERROR/.test(l.msg));
+}
+
+describe("the close of a form asks for what the reader changed", () => {
+    test("a record that lacks a defaulted field opens changed, and closes without asking", () => {
+        const form = build({template_version: 7, alarm_colors: null});
+        expect(gobj_read_attr(form, "changes")).toBe(true);
+        expect(gobj_read_attr(form, "edited")).toBe(false);
+        expect(close_asks(form)).toBe("");
+        expect(errors()).toEqual([]);
+    });
+
+    test("a change of the reader makes it ask", () => {
+        const form = build(COMPLETE);
+        expect(gobj_read_attr(form, "changes")).toBe(false);
+        expect(close_asks(form)).toBe("");
+
+        gobj_send_event(form, "EV_RECORD_CHANGED", {}, form);
+        expect(gobj_read_attr(form, "changes")).toBe(true);
+        expect(gobj_read_attr(form, "edited")).toBe(true);
+        expect(close_asks(form)).toBe("all changes will be lost");
+        expect(errors()).toEqual([]);
+    });
+
+    test("an undo, a save or a record loaded end what the close would lose", () => {
+        const form = build(COMPLETE);
+
+        gobj_send_event(form, "EV_RECORD_CHANGED", {}, form);
+        gobj_send_event(form, "EV_UNDO_RECORD", {}, form);
+        expect(gobj_read_attr(form, "edited")).toBe(false);
+        expect(close_asks(form)).toBe("");
+
+        gobj_send_event(form, "EV_RECORD_CHANGED", {}, form);
+        gobj_send_event(form, "EV_SAVE_RECORD", {}, form);
+        expect(gobj_read_attr(form, "edited")).toBe(false);
+        expect(close_asks(form)).toBe("");
+
+        gobj_send_event(form, "EV_RECORD_CHANGED", {}, form);
+        gobj_send_event(form, "EV_LOAD_RECORD", {template_version: 7, alarm_colors: null}, form);
+        expect(gobj_read_attr(form, "changes")).toBe(true);     // the defaults again
+        expect(gobj_read_attr(form, "edited")).toBe(false);
+        expect(close_asks(form)).toBe("");
+        expect(errors()).toEqual([]);
+    });
+
+    test("clearing and pasting are changes of the reader", () => {
+        const cleared = build(COMPLETE);
+        gobj_send_event(cleared, "EV_CLEAR_RECORD", {}, cleared);
+        expect(gobj_read_attr(cleared, "changes")).toBe(true);
+        expect(gobj_read_attr(cleared, "edited")).toBe(true);
+        expect(close_asks(cleared)).toBe("all changes will be lost");
+
+        const pasted = build(COMPLETE);
+        gobj_send_event(pasted, "EV_PASTE_RECORD", {record: {
+            template_version: 7,
+            alarm_colors: {
+                active_not_validated: "#00ff00",
+                active_validated: "#e5a50a",
+                not_active_not_validated: "#ff00ff"
+            }
+        }}, pasted);
+        expect(gobj_read_attr(pasted, "changes")).toBe(true);
+        expect(gobj_read_attr(pasted, "edited")).toBe(true);
+        expect(close_asks(pasted)).toBe("all changes will be lost");
+        expect(errors()).toEqual([]);
+    });
+});

package/src/modal_guard_back.wiring.test.js

@@ -0,0 +1,193 @@
+/***********************************************************************
+ *          modal_guard_back.wiring.test.js
+ *
+ *      A modal whose `before_close` guard ASKS (unsaved changes). The
+ *      browser Back takes the modal's history entry before the guard
+ *      runs; the guard opens a question, and the modal stays. When the
+ *      modal took its entry back at once, it went ABOVE the question's
+ *      own entry: the next Back -- the one meant for the question --
+ *      reached the modal, which asked again, and every Back stacked
+ *      one more question. A guard that asks answers the question's
+ *      promise, and the modal takes its entry back once the question
+ *      is over.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {describe, test, expect, beforeAll, beforeEach} from "vitest";
+import {install_dom_double} from "../test/dom_double.js";
+
+install_dom_double();
+
+const {
+    SDATA_END, gclass_create,
+    gobj_start_up, gobj_create_yuno, gobj_create, gobj_start,
+    set_log_callback,
+} = await import("@yuneta/gobj-js");
+const {register_c_yui_shell} = await import("./c_yui_shell.js");
+const {
+    yui_shell_show_modal,
+    yui_shell_confirm_yesnocancel,
+} = await import("./shell_modals.js");
+
+const logged = [];
+let yuno = null;
+let seq = 0;
+
+beforeAll(async () => {
+    const i18next = (await import("i18next")).default;
+    await i18next.init({lng: "en", resources: {}});
+    gobj_start_up(null, null, null, null, null, null, null);
+    set_log_callback((level, msg) => {
+        logged.push({level: String(level), msg: String(msg)});
+    });
+    gclass_create("C_TEST_GUARD_HOST", [], [["ST_IDLE", []]], {}, 0, [SDATA_END()], {}, 0, 0, 0, 0);
+    register_c_yui_shell();
+    yuno = gobj_create_yuno("guard_yuno", "C_TEST_GUARD_HOST", {});
+    gobj_start(yuno);
+});
+
+beforeEach(() => {
+    logged.length = 0;
+    /*  What a failed test left open belongs to its own shell.  */
+    for(const $n of document.querySelectorAll(".CONFIRM, .TEST_SHEET")) {
+        if($n.parentNode) {
+            $n.parentNode.removeChild($n);
+        }
+    }
+});
+
+function errors()
+{
+    return logged.filter((l) => l.level === "error").map((l) => l.msg);
+}
+
+/*  Same Back as window_veto_back: a Back off a marker lands on the entry
+ *  under it, which the shell stamped with the TOP overlay's id.  */
+function press_back(shell)
+{
+    const stack = shell.priv.overlay_stack;
+    const ev = new Event("popstate");
+    ev.state = {__yui_below__: stack.length ? stack[stack.length - 1].id : 0};
+    window.dispatchEvent(ev);
+}
+
+function settle()
+{
+    return new Promise(resolve => setTimeout(resolve, 0));
+}
+
+function sheets()
+{
+    return document.querySelectorAll(".TEST_SHEET").length;
+}
+
+function questions()
+{
+    return document.querySelectorAll(".CONFIRM").length;
+}
+
+/*  A shell, and a sheet over it whose guard asks while `state.dirty`.  */
+function open_guarded_sheet(state)
+{
+    seq++;
+    const app = gobj_create(`gapp${seq}`, "C_TEST_GUARD_HOST", {}, yuno);
+    gobj_start(app);
+    const shell = gobj_create(`gshell${seq}`, "C_YUI_SHELL",
+        {config: {shell: {}}, default_route: "/home", subscriber: app}, app);
+    gobj_start(shell);
+    logged.length = 0;     /*  the shell's own start: no route table here  */
+
+    const handle = yui_shell_show_modal(shell, "the sheet", {
+        dialog:        true,
+        logical_class: "TEST_SHEET",
+        title:         "settings",
+        before_close:  function() {
+            if(!state.dirty) {
+                return true;
+            }
+            state.asked++;
+            return yui_shell_confirm_yesnocancel(shell, "all changes will be lost", {
+                yes_label: "yes", no_label: "no", cancel_label: "cancel"
+            }).then(function(answer) {
+                if(answer === "yes") {
+                    handle.close();
+                }
+            });
+        }
+    });
+    return {shell, handle};
+}
+
+describe("a modal whose guard asks before it closes", () => {
+    test("Back asks ONCE, and the next Back takes the question, not the modal", async () => {
+        const state = {dirty: true, asked: 0};
+        const {shell, handle} = open_guarded_sheet(state);
+        expect(shell.priv.overlay_stack.length).toBe(1);
+
+        /*  Back: the guard asks. The modal stays, and only the question
+         *  is on the stack -- the modal's entry went with the Back.  */
+        press_back(shell);
+        expect(sheets()).toBe(1);
+        expect(questions()).toBe(1);
+        expect(state.asked).toBe(1);
+        expect(shell.priv.overlay_stack.length).toBe(1);
+
+        /*  Back again: it is the question that goes (its safe default,
+         *  cancel), and the modal takes its entry back only then.  */
+        press_back(shell);
+        await settle();
+        expect(questions()).toBe(0);
+        expect(sheets()).toBe(1);
+        expect(state.asked).toBe(1);
+        expect(shell.priv.overlay_stack.length).toBe(1);
+
+        /*  And a third Back asks again: one question, not two.  */
+        press_back(shell);
+        expect(questions()).toBe(1);
+        expect(state.asked).toBe(2);
+        press_back(shell);
+        await settle();
+        expect(questions()).toBe(0);
+        expect(sheets()).toBe(1);
+        expect(errors()).toEqual([]);
+
+        handle.close();
+        expect(sheets()).toBe(0);
+    });
+
+    test("the back arrow that asks leaves the modal's entry UNDER the question", async () => {
+        const state = {dirty: true, asked: 0};
+        const {shell, handle} = open_guarded_sheet(state);
+        const entry = shell.priv.overlay_stack[0];
+
+        document.querySelector(".TEST_SHEET .yui-dialog-back").click();
+        expect(questions()).toBe(1);
+        expect(shell.priv.overlay_stack.length).toBe(2);
+        expect(shell.priv.overlay_stack[0]).toBe(entry);
+
+        press_back(shell);
+        await settle();
+        expect(questions()).toBe(0);
+        expect(sheets()).toBe(1);
+        expect(shell.priv.overlay_stack).toEqual([entry]);
+        expect(errors()).toEqual([]);
+
+        handle.close();
+        expect(sheets()).toBe(0);
+    });
+
+    test("with nothing to lose, Back closes it at once", async () => {
+        const state = {dirty: false, asked: 0};
+        const {shell} = open_guarded_sheet(state);
+        expect(sheets()).toBe(1);
+
+        press_back(shell);
+        await settle();
+        expect(sheets()).toBe(0);
+        expect(questions()).toBe(0);
+        expect(state.asked).toBe(0);
+        expect(shell.priv.overlay_stack).toEqual([]);
+        expect(errors()).toEqual([]);
+    });
+});

package/src/shell_modals.js

@@ -386,7 +386,17 @@ export function yui_shell_show_modal(shell, content, opts)
      *  VETO — the modal stays up and the caller takes over (e.g. an
      *  unsaved-changes prompt that calls close() itself on confirm). Return
      *  true/undefined to let it close. Absent guard ⇒ always closes, so
-     *  existing callers are unaffected. */
+     *  existing callers are unaffected.
+     *
+     *  A guard that ASKS first returns the question's PROMISE: a veto, and
+     *  the modal is told when the question is over. It matters on browser
+     *  Back, which took the modal's history entry before the guard ran:
+     *  the entry goes back once the question is gone, never above it.
+     *  Returned false after opening the question, the entry went back at
+     *  once, over the question's own, and the next Back -- the one meant
+     *  for the question -- reached the modal, which asked again: every
+     *  Back stacked one more question. Same contract as the `asking`
+     *  close of C_YUI_WINDOW. */
     let guarded_close = function(on_veto) {
         if(closed) {
             return;
@@ -400,6 +410,12 @@ export function yui_shell_show_modal(shell, content, opts)
                 allow = true;
             }
         }
+        if(allow && typeof allow.then === "function") {
+            if(typeof on_veto === "function") {
+                allow.then(on_veto, on_veto);
+            }
+            return;
+        }
         if(allow === false) {
             if(typeof on_veto === "function") {
                 on_veto();
@@ -412,10 +428,13 @@ export function yui_shell_show_modal(shell, content, opts)
         guarded_close(null);
     };
     /*  Browser Back already consumed the history entry; if the guard vetoes,
-     *  re-arm a fresh entry so a later Back still targets this modal. */
+     *  re-arm a fresh entry so a later Back still targets this modal --
+     *  unless the answer to its question closed it.  */
     let on_back = function() {
         guarded_close(function() {
-            overlay = yui_shell_register_overlay(shell, on_back);
+            if(!closed) {
+                overlay = yui_shell_register_overlay(shell, on_back);
+            }
         });
     };