@yuneta/gobj-ui 7.26.28 → 7.26.30

package/src/yui_badge.js

@@ -0,0 +1,145 @@
+/***********************************************************************
+ *          yui_badge.js
+ *
+ *      The BADGE: the little count a control carries -- unread
+ *      notifications, active alarms.  The toolbar items of C_YUI_SHELL
+ *      and the menu items of C_YUI_NAV build and paint theirs here, so
+ *      the two follow the same rules and cannot drift apart:
+ *
+ *      EMPTY IS 0, "" AND null ALIKE (false and undefined too): a badge
+ *      reading "0" is worse than no badge -- it draws the eye to say
+ *      nothing.  A count is only worth a pixel when there IS something.
+ *
+ *      CAPPED AT 99+: a badge sits in a row of fixed width (the app bar,
+ *      a bottom icon bar), and a four digit pill pushes the items next
+ *      to it off a phone screen.  A string passes through, for the
+ *      states that are not counts ("!", "…").
+ *
+ *      ALWAYS RENDERED, hidden when empty, so the runtime setters have a
+ *      node to write into and never rebuild the control that holds it.
+ *
+ *      role="status" and NOT aria-hidden, deliberately.  The control
+ *      carries an explicit aria-label, and an explicit label REPLACES
+ *      the element's content for a screen reader -- so a badge inside
+ *      it would be silent.  As its own live region it is both read and
+ *      announced when the count changes, which is the whole point of a
+ *      badge that means "something needs you".  For the same reason a
+ *      write that changes nothing touches no DOM: rewriting the same
+ *      number would have it announced again on every tick.
+ *
+ *      A TONE, optional: one of BADGE_TONES, drawn as Bulma's
+ *      `is-<tone>` on the badge.  It says HOW BAD the count is -- the
+ *      alarms of an app coloured by the worst state among them.  No
+ *      tone is the default look (the danger colour: a badge exists to
+ *      pull the eye).  An unknown tone is the caller's error: it is
+ *      logged, and the default look is drawn instead.
+ *
+ *      The text is a Text node, never a string: a value that came from
+ *      outside must not reach createElement2() as markup.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {log_error} from "@yuneta/gobj-js";
+
+import {text_node} from "./yui_text.js";
+
+
+/***************************************************************
+ *              Constants
+ ***************************************************************/
+export const BADGE_TONES = Object.freeze([
+    "danger", "warning", "info", "success", "primary", "link"
+]);
+
+
+/************************************************************
+ *  The text a badge shows for `value`, "" when it shows none.
+ ************************************************************/
+export function badge_text(value)
+{
+    if(value === null || value === undefined || value === false) {
+        return "";
+    }
+    if(typeof value === "number") {
+        if(!isFinite(value) || value <= 0) {
+            return "";
+        }
+        return (value > 99) ? "99+" : String(Math.floor(value));
+    }
+    return String(value).trim();
+}
+
+/************************************************************
+ *  The tone to draw: `tone` when it is one of BADGE_TONES, ""
+ *  (the default look) when it is empty.  Anything else is logged,
+ *  naming `who`, and answers "".
+ ************************************************************/
+export function badge_tone(tone, who)
+{
+    if(tone === undefined || tone === null || tone === "") {
+        return "";
+    }
+    if(BADGE_TONES.indexOf(tone) < 0) {
+        log_error(
+            `${who}: unknown badge tone '${tone}', drawn with the default look ` +
+            `(the tones: ${BADGE_TONES.join(", ")})`
+        );
+        return "";
+    }
+    return tone;
+}
+
+/************************************************************
+ *  The createElement2() description of a badge.  `classes` are
+ *  the host's (its logical name, `yui-badge` for the look, and
+ *  where it sits); `who` names the item in the log of an unknown
+ *  tone.
+ ************************************************************/
+export function badge_node(value, tone, classes, who)
+{
+    let text = badge_text(value);
+    let known = badge_tone(tone, who);
+    let attrs = {
+        class: known ? `${classes} is-${known}` : classes,
+        role:  "status"
+    };
+    if(!text) {
+        attrs.hidden = "hidden";
+    }
+    return ["span", attrs, text_node(text)];
+}
+
+/************************************************************
+ *  Write a badge that is already in the DOM, as badge_node()
+ *  draws it.  `tone` is one badge_tone() answered: the setter
+ *  checks it once for all the badges it paints.
+ ************************************************************/
+export function paint_badge($badge, value, tone)
+{
+    for(let known of BADGE_TONES) {
+        let cls = `is-${known}`;
+        if(known === tone) {
+            if(!$badge.classList.contains(cls)) {
+                $badge.classList.add(cls);
+            }
+        } else if($badge.classList.contains(cls)) {
+            $badge.classList.remove(cls);
+        }
+    }
+
+    let text = badge_text(value);
+    if(!text) {
+        $badge.textContent = "";
+        $badge.setAttribute("hidden", "hidden");
+        return;
+    }
+    /*  Do not touch the DOM when nothing changed: role="status" is a
+     *  live region, and rewriting the same number would have a screen
+     *  reader announce it again on every tick. */
+    if($badge.textContent === text && !$badge.hasAttribute("hidden")) {
+        return;
+    }
+    $badge.textContent = text;
+    $badge.removeAttribute("hidden");
+}

package/src/yui_badge.test.js

@@ -0,0 +1,148 @@
+/***********************************************************************
+ *          yui_badge.test.js
+ *
+ *      The badge shared by the toolbar items of C_YUI_SHELL and the
+ *      menu items of C_YUI_NAV: what it shows for a value, which tones
+ *      it takes, how it is drawn and how it is repainted. The text is a
+ *      Text node, so a document double is installed.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {describe, test, expect, beforeAll, beforeEach} from "vitest";
+import {install_dom_double} from "../test/dom_double.js";
+
+install_dom_double();
+
+const {createElement2, set_log_callback} = await import("@yuneta/gobj-js");
+const {
+    BADGE_TONES, badge_text, badge_tone, badge_node, paint_badge,
+} = await import("./yui_badge.js");
+
+const logged = [];
+
+beforeAll(() => {
+    set_log_callback((level, msg) => {
+        logged.push({level: String(level), msg: String(msg)});
+    });
+});
+
+beforeEach(() => {
+    logged.length = 0;
+});
+
+function errors()
+{
+    return logged.filter((l) => l.level === "error").map((l) => l.msg);
+}
+
+function tones_of($badge)
+{
+    return BADGE_TONES.filter((tone) => $badge.classList.contains(`is-${tone}`));
+}
+
+
+describe("badge_text", () => {
+    test("empty is 0, '', null, false and undefined alike", () => {
+        for(const v of [0, "", null, false, undefined, -3, NaN, Infinity, "   "]) {
+            expect(badge_text(v), String(v)).toBe("");
+        }
+    });
+
+    test("a count, capped at 99+, and a text passes through", () => {
+        expect(badge_text(1)).toBe("1");
+        expect(badge_text(99)).toBe("99");
+        expect(badge_text(100)).toBe("99+");
+        expect(badge_text(2.7)).toBe("2");
+        expect(badge_text(" ! ")).toBe("!");
+        expect(badge_text("3")).toBe("3");
+    });
+});
+
+describe("badge_tone", () => {
+    test("the six tones, and no tone, pass without a word", () => {
+        expect(BADGE_TONES).toEqual(["danger", "warning", "info", "success", "primary", "link"]);
+        for(const tone of BADGE_TONES) {
+            expect(badge_tone(tone, "who")).toBe(tone);
+        }
+        expect(badge_tone(undefined, "who")).toBe("");
+        expect(badge_tone(null, "who")).toBe("");
+        expect(badge_tone("", "who")).toBe("");
+        expect(errors()).toEqual([]);
+    });
+
+    test("an unknown one is logged, naming who asked, and answers the default", () => {
+        expect(badge_tone("red", "C_TEST: item 'x'")).toBe("");
+        expect(badge_tone("Danger", "C_TEST: item 'x'")).toBe("");
+        expect(badge_tone(3, "C_TEST: item 'x'")).toBe("");
+        let e = errors();
+        expect(e.length).toBe(3);
+        expect(e[0]).toContain("C_TEST: item 'x'");
+        expect(e[0]).toContain("'red'");
+    });
+});
+
+describe("badge_node", () => {
+    test("a live region with the host's classes, its tone and its text as text", () => {
+        let $b = createElement2(badge_node(3, "warning", "X_BADGE yui-badge", "who"));
+        expect($b.tagName).toBe("SPAN");
+        expect($b.getAttribute("role")).toBe("status");
+        expect($b.hasAttribute("hidden")).toBe(false);
+        expect([...$b.classList]).toEqual(["X_BADGE", "yui-badge", "is-warning"]);
+        expect($b.textContent).toBe("3");
+        expect($b.firstChild.nodeType).toBe(3);
+    });
+
+    test("empty: drawn all the same, hidden, so a setter can write into it", () => {
+        let $b = createElement2(badge_node(0, "", "X_BADGE yui-badge", "who"));
+        expect($b.hasAttribute("hidden")).toBe(true);
+        expect($b.textContent).toBe("");
+        expect(tones_of($b)).toEqual([]);
+    });
+
+    test("markup in a value is text", () => {
+        let $b = createElement2(badge_node("<img src=x>", "", "X_BADGE", "who"));
+        expect($b.children.length).toBe(0);
+        expect($b.textContent).toBe("<img src=x>");
+    });
+
+    test("an unknown tone is logged and drawn with the default look", () => {
+        let $b = createElement2(badge_node(3, "red", "X_BADGE", "C_TEST: item 'x'"));
+        expect(tones_of($b)).toEqual([]);
+        expect(errors().length).toBe(1);
+    });
+});
+
+describe("paint_badge", () => {
+    test("sets, changes and clears the tone, one at a time", () => {
+        let $b = createElement2(badge_node(3, "danger", "X_BADGE", "who"));
+        paint_badge($b, 3, "info");
+        expect(tones_of($b)).toEqual(["info"]);
+        paint_badge($b, 3, "");
+        expect(tones_of($b)).toEqual([]);
+        paint_badge($b, 3, "success");
+        expect(tones_of($b)).toEqual(["success"]);
+    });
+
+    test("hides on empty, shows again on a count", () => {
+        let $b = createElement2(badge_node(3, "", "X_BADGE", "who"));
+        paint_badge($b, 0, "");
+        expect($b.hasAttribute("hidden")).toBe(true);
+        expect($b.textContent).toBe("");
+        paint_badge($b, 150, "");
+        expect($b.hasAttribute("hidden")).toBe(false);
+        expect($b.textContent).toBe("99+");
+    });
+
+    test("the same text again, or only a new tone, does not rewrite the text", () => {
+        let $b = createElement2(badge_node(5, "", "X_BADGE", "who"));
+        let text = $b.firstChild;
+        paint_badge($b, 5, "");
+        paint_badge($b, 5, "warning");
+        expect($b.firstChild).toBe(text);
+        expect(tones_of($b)).toEqual(["warning"]);
+        paint_badge($b, 6, "warning");
+        expect($b.firstChild).not.toBe(text);
+        expect($b.textContent).toBe("6");
+    });
+});

package/src/yui_gclass_view.js

@@ -197,7 +197,7 @@ function open_gclass_view(host, gclass_name, opts)
             dialog:        true,
             logical_class: "GCLASS_VIEW_SHEET",
             title_prefix:  opts.title_prefix || "",
-            title:         /* i18n: data */ gclass_name,
+            title:         gclass_name,
             t:             t,
             on_close:      on_close,
         });

package/src/yui_time.js

@@ -544,7 +544,7 @@ function period_name(period, t)
 {
     let spec = period_spec(period);
     if(!spec) {
-        return tr(t, /* i18n: data */ String((period && period.id) || period || ""));
+        return tr(t, String((period && period.id) || period || ""));
     }
     return tr(t, /* i18n: YUI_TIME_I18N_KEYS */ spec.id);
 }