@yuneta/gobj-ui 7.26.27 → 7.26.28

package/src/g6_nodes_tree_i18n_keys.test.js

@@ -1,10 +1,20 @@
 /***********************************************************************
  *          g6_nodes_tree_i18n_keys.test.js
  *
- *      The shape tables of c_g6_nodes_tree.js reach t() as DATA, so the
- *      view publishes their keys in G6_NODES_TREE_I18N_KEYS, which a
- *      consumer's validate-locales asks the locales for. A shape added to
- *      a table and not to the list would render raw in every language.
+ *      The keys of c_g6_nodes_tree.js that reach t() as DATA or as an
+ *      ARGUMENT -- the shape tables, the labels and buttons of the
+ *      popovers, the names of the floating buttons, the shell's error
+ *      messages -- are invisible to a consumer's validate-locales, which
+ *      only sees `t('<literal>')` and the `data-i18n*` / `i18n:` forms.
+ *      So the view publishes them in G6_NODES_TREE_I18N_KEYS, and a key
+ *      missing from that list renders raw in every language with the
+ *      validator green (REV-CLOUD V20.5.1: "some records were gone
+ *      before the delete").
+ *
+ *      The module is read as a syntax tree, so every CALL is checked,
+ *      not only the tables: a key handed to one of those helpers and
+ *      not published fails here, and so does a new helper that hands
+ *      t() a variable this test does not know the source of.
  *
  *          Copyright (c) 2026, ArtGins.
  *          All Rights Reserved.
@@ -13,8 +23,10 @@ import {describe, test, expect} from "vitest";
 import {readFileSync} from "node:fs";
 import {dirname, join} from "node:path";
 import {fileURLToPath} from "node:url";
+import {parse} from "acorn";
 
 const SRC = readFileSync(join(dirname(fileURLToPath(import.meta.url)), "c_g6_nodes_tree.js"), "utf8");
+const AST = parse(SRC, {ecmaVersion: "latest", sourceType: "module"});
 
 function array_of(name)
 {
@@ -23,7 +35,130 @@ function array_of(name)
     return [...m[1].matchAll(/'([^']+)'/g)].map((x) => x[1]);
 }
 
-describe("c_g6_nodes_tree publishes the keys of its shape tables", () => {
+/*  The helpers that hand t() a key they were given, and which argument
+ *  carries it. A call passes a literal (it must be published) or the
+ *  parameter of another of these (it passes the key through).  */
+const KEY_ARGS = {
+    create_form_label:      [1],
+    create_floating_icon:   [4],
+    show_dual_icons:        [3, 5],
+    show_confirm_popover:   [3],
+    yui_shell_show_error:   [1],
+};
+
+/*  The functions that call t() with something other than a literal,
+ *  each with the place its keys come from:
+ *    create_form_label, create_floating_icon: an argument (KEY_ARGS);
+ *    name_form_control: the `data-i18n` create_form_label wrote;
+ *    create_form_select, create_form_button_row: an `i18n:` property.  */
+const VARIABLE_T_CALLERS = [
+    "create_floating_icon",
+    "create_form_button_row",
+    "create_form_label",
+    "create_form_select",
+    "name_form_control",
+];
+
+/*  The tables whose items reach `i18n:` through a `.map()`: the first
+ *  test of this file checks that their keys are published.  */
+const KEY_TABLES = ["NODE_SHAPES", "PORT_SHAPES"];
+
+/*  Every node of the tree, with the stack of the nodes above it.  */
+function each_node(node, visit, stack = [])
+{
+    visit(node, stack);
+    stack.push(node);
+    for(const k of Object.keys(node)) {
+        const v = node[k];
+        if(Array.isArray(v)) {
+            for(const c of v) {
+                if(c && typeof c.type === "string") {
+                    each_node(c, visit, stack);
+                }
+            }
+        } else if(v && typeof v.type === "string") {
+            each_node(v, visit, stack);
+        }
+    }
+    stack.pop();
+}
+
+function is_string_literal(n)
+{
+    if(!n) {
+        return false;
+    }
+    if(n.type === "Literal" && typeof n.value === "string") {
+        return true;
+    }
+    return n.type === "TemplateLiteral" && n.expressions.length === 0;
+}
+
+function literal_value(n)
+{
+    if(n.type === "Literal") {
+        return n.value;
+    }
+    return n.quasis[0].value.cooked;
+}
+
+function is_function(n)
+{
+    return n.type === "FunctionDeclaration" || n.type === "FunctionExpression" ||
+        n.type === "ArrowFunctionExpression";
+}
+
+function has_param(fn, name)
+{
+    return fn.params.some((p) => p.type === "Identifier" && p.name === name);
+}
+
+/*  The innermost function above, that declares `name` as a parameter.  */
+function function_with_param(stack, name)
+{
+    for(let i = stack.length - 1; i >= 0; i--) {
+        if(is_function(stack[i]) && has_param(stack[i], name)) {
+            return {fn: stack[i], parent: stack[i - 1]};
+        }
+    }
+    return null;
+}
+
+function enclosing_declaration(stack)
+{
+    for(let i = stack.length - 1; i >= 0; i--) {
+        if(stack[i].type === "FunctionDeclaration") {
+            return stack[i].id.name;
+        }
+    }
+    return "<module>";
+}
+
+function line_of(n)
+{
+    return SRC.slice(0, n.start).split("\n").length;
+}
+
+/*  A key handed on by name is the parameter of one of the KEY_ARGS
+ *  helpers (passed through), or the item of a KEY_TABLES `.map()`.  */
+function variable_key_is_known(stack, name)
+{
+    const found = function_with_param(stack, name);
+    if(!found) {
+        return false;
+    }
+    if(found.fn.type === "FunctionDeclaration" && KEY_ARGS[found.fn.id.name]) {
+        return true;
+    }
+    const call = found.parent;
+    return !!(call && call.type === "CallExpression" && call.arguments[0] === found.fn &&
+        call.callee.type === "MemberExpression" &&
+        call.callee.property.name === "map" &&
+        call.callee.object.type === "Identifier" &&
+        KEY_TABLES.includes(call.callee.object.name));
+}
+
+describe("c_g6_nodes_tree publishes the keys it hands to t() as data", () => {
     test("every node and port shape is in G6_NODES_TREE_I18N_KEYS", () => {
         const published = new Set(array_of("G6_NODES_TREE_I18N_KEYS"));
         for(const shape of [...array_of("NODE_SHAPES"), ...array_of("PORT_SHAPES")]) {
@@ -36,4 +171,105 @@ describe("c_g6_nodes_tree publishes the keys of its shape tables", () => {
         expect(SRC).toMatch(/o\.setAttribute\('data-i18n', opt\.i18n\)/);
         expect(SRC).not.toMatch(/label: t\('/);
     });
+
+    test("every function that hands t() a variable is one whose keys are checked here", () => {
+        const callers = new Set();
+        each_node(AST, (n, stack) => {
+            if(n.type === "CallExpression" && n.callee.type === "Identifier" &&
+                    n.callee.name === "t" && !is_string_literal(n.arguments[0])) {
+                callers.add(enclosing_declaration(stack));
+            }
+        });
+        /*  A new one fails here: teach KEY_ARGS (or the `i18n:` check
+         *  below) where its keys come from, and publish them.  */
+        expect([...callers].sort()).toEqual(VARIABLE_T_CALLERS);
+    });
+
+    test("every key handed to those helpers by argument is published", () => {
+        const published = new Set(array_of("G6_NODES_TREE_I18N_KEYS"));
+        const missing = [];
+        const unknowable = [];
+        let calls = 0;
+        each_node(AST, (n, stack) => {
+            if(n.type !== "CallExpression" || n.callee.type !== "Identifier" ||
+                    !KEY_ARGS[n.callee.name]) {
+                return;
+            }
+            calls++;
+            for(const i of KEY_ARGS[n.callee.name]) {
+                const arg = n.arguments[i];
+                if(is_string_literal(arg)) {
+                    if(!published.has(literal_value(arg))) {
+                        missing.push(`${n.callee.name}('${literal_value(arg)}') :${line_of(n)}`);
+                    }
+                } else if(!(arg && arg.type === "Identifier" &&
+                        variable_key_is_known(stack, arg.name))) {
+                    unknowable.push(`${n.callee.name} argument ${i} :${line_of(n)}`);
+                }
+            }
+        });
+        expect(calls).toBeGreaterThan(10);
+        expect(missing).toEqual([]);
+        expect(unknowable).toEqual([]);
+    });
+
+    test("an `i18n:` property is a literal, or a key the checks above reach", () => {
+        const unknowable = [];
+        each_node(AST, (n, stack) => {
+            if(n.type !== "Property" || n.shorthand || n.key.type !== "Identifier" ||
+                    n.key.name !== "i18n" || stack[stack.length - 1].type !== "ObjectExpression") {
+                return;
+            }
+            if(is_string_literal(n.value)) {
+                return;     /* validate-locales reads `i18n: '<key>'` */
+            }
+            if(!(n.value.type === "Identifier" && variable_key_is_known(stack, n.value.name))) {
+                unknowable.push(`i18n: ${SRC.slice(n.value.start, n.value.end)} :${line_of(n)}`);
+            }
+        });
+        expect(unknowable).toEqual([]);
+    });
+
+    test("a toolbar item's `title_key` is the key of its `title`", () => {
+        /*  toolbar_item_html() writes `title` as the name and
+         *  `title_key` as its data-i18n-title / -aria-label: two
+         *  writings of one key, which must not drift apart. Every
+         *  object with a `title: t('<key>')` is a toolbar item here.  */
+        const prop = (obj, name) => obj.properties.find((p) => p.type === "Property" &&
+            !p.computed && p.key.type === "Identifier" && p.key.name === name);
+        const bad = [];
+        let items = 0;
+        each_node(AST, (n) => {
+            if(n.type !== "ObjectExpression") {
+                return;
+            }
+            const title = prop(n, "title");
+            const key = prop(n, "title_key");
+            if(!title && !key) {
+                return;
+            }
+            const is_t = title && title.value.type === "CallExpression" &&
+                title.value.callee.type === "Identifier" && title.value.callee.name === "t" &&
+                is_string_literal(title.value.arguments[0]);
+            if(!is_t) {
+                return;     /* not a translated title: nothing to key */
+            }
+            items++;
+            const want = literal_value(title.value.arguments[0]);
+            if(!key || !is_string_literal(key.value) || literal_value(key.value) !== want) {
+                bad.push(`title: t('${want}') without title_key '${want}' :${line_of(n)}`);
+            }
+        });
+        expect(items).toBeGreaterThan(15);
+        expect(bad).toEqual([]);
+    });
+
+    test("the published list holds the keys REV-CLOUD V20.5.1 found missing", () => {
+        const published = new Set(array_of("G6_NODES_TREE_I18N_KEYS"));
+        for(const key of ["some records were gone before the delete",
+                          "node properties", "delete node", "edge properties",
+                          "unlink", "link to hook", "port properties"]) {
+            expect(published.has(key), key).toBe(true);
+        }
+    });
 });

package/src/i18n_key_functions.js

@@ -0,0 +1,146 @@
+/***********************************************************************
+ *          i18n_key_functions.js
+ *
+ *          The gobj-ui functions that RECEIVE an i18n key as an
+ *          argument, and where it goes. Pure data: no import, no code.
+ *
+ *          A key handed to a function -- `yui_shell_show_error(shell,
+ *          "the connection dropped")`, `icon_button(gobj, "yi-copy",
+ *          "EV_COPY_ALL", "copy json")` -- reaches t() inside the function,
+ *          by a parameter, where no scan of `t("...")` can see it. Up to
+ *          gobj-ui 7.26.27 such a key was invisible to validate-locales,
+ *          and several shipped untranslated (REV-CLOUD V20.5.1). This table
+ *          names every such function: validate-locales reads the string
+ *          literals given at these positions as keys the source asks for,
+ *          in the app's own source and in the gobj-ui modules it mounts.
+ *
+ *          An entry:
+ *
+ *              module      the src/ module that defines the function
+ *              name        its name
+ *              exported    true: an app or another module imports it, and
+ *                          every call bound to that import is read;
+ *                          false: a helper of its own module, read there
+ *              keys        where the keys are, one string per position:
+ *                            "1"            the second argument
+ *                            "2.title"      property `title` of an object
+ *                                           literal given as the third
+ *                            "1.actions[].label"
+ *                                           `label` of each object literal
+ *                                           of the array `actions`
+ *                          A position may also hold DOM or nothing: only
+ *                          a string there is a key.
+ *
+ *          What is read at a position: a string literal, a template with
+ *          no `${}`, every branch of a `?:`, `||`, `??` (the right one of
+ *          `&&`), and what the reader follows -- a const to its value, a
+ *          property of a const object, the element of a const array a
+ *          `.map()` or a for...of walks. A `let`, a parameter or data is
+ *          not read: its keys are published in an exported
+ *          `<NAME>_I18N_KEYS` array, and the call is MARKED with a comment
+ *          right before what it hands over, `i18n: <NAME>_I18N_KEYS` (the
+ *          list) or `i18n: data` (no key a list can hold). A marked `let`
+ *          is held to its marker: every literal it is given is read and
+ *          must be in the list, and one given nothing but literals fails
+ *          (write it as a const, which the reader follows).
+ *
+ *          A test (i18n_key_functions.test.js) holds the library to it,
+ *          per CALL: a key position given anything else than a literal, a
+ *          const the reader follows, a key position of the enclosing
+ *          table function handed on, or a marked value fails, with the
+ *          file and the line. Publishing a list exempts no module.
+ *
+ *          A function added to the library that hands one of its
+ *          parameters to t(), to `i18n`, or to a `data-i18n*` attribute
+ *          goes in this table.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+
+export const I18N_KEY_FUNCTIONS = Object.freeze([
+    /*
+     *  Exported: an app calls them
+     */
+    /*  shell_modals.js -- a string message IS a key (DOM is drawn as it is)  */
+    {module: "shell_modals.js", name: "yui_shell_show_info",    exported: true, keys: ["1"]},
+    {module: "shell_modals.js", name: "yui_shell_show_warning", exported: true, keys: ["1"]},
+    {module: "shell_modals.js", name: "yui_shell_show_error",   exported: true, keys: ["1"]},
+    {module: "shell_modals.js", name: "yui_shell_show_modal",   exported: true, keys: ["1", "2.title"]},
+    {module: "shell_modals.js", name: "yui_shell_confirm_ok",   exported: true,
+        keys: ["1", "2.title", "2.ok_label"]},
+    {module: "shell_modals.js", name: "yui_shell_confirm_yesno", exported: true,
+        keys: ["1", "2.title", "2.yes_label", "2.no_label"]},
+    {module: "shell_modals.js", name: "yui_shell_confirm_danger", exported: true,
+        keys: ["1", "2.title", "2.confirm_label", "2.cancel_label"]},
+    {module: "shell_modals.js", name: "yui_shell_confirm_yesnocancel", exported: true,
+        keys: ["1", "2.title", "2.yes_label", "2.no_label", "2.cancel_label"]},
+    /*  yui_install.js  */
+    {module: "yui_install.js", name: "yui_install_ask_once", exported: true,
+        keys: ["1.message", "1.yes_label", "1.no_label"]},
+    /*  yui_table_select.js -- the actions of the selection bar  */
+    {module: "yui_table_select.js", name: "yui_selection_bar", exported: true,
+        keys: ["1.actions[].label"]},
+    /*  yui_asset.js -- the marker of a missing asset  */
+    {module: "yui_asset.js", name: "yui_asset_missing", exported: true, keys: ["1.key"]},
+    {module: "yui_asset.js", name: "yui_asset_element", exported: true, keys: ["1.key"]},
+    /*  table_cell_text.js -- the tooltip key of a hook cell  */
+    {module: "table_cell_text.js", name: "hook_cell_spec", exported: true, keys: ["4"]},
+    /*  yui_time.js -- a granularity names itself by its id  */
+    {module: "yui_time.js", name: "period_name", exported: true, keys: ["0", "0.id"]},
+
+    /*
+     *  Helpers of their own module
+     */
+    {module: "shell_modals.js", name: "show_notification", exported: false, keys: ["2"]},
+    {module: "shell_modals.js", name: "build_dialog", exported: false,
+        keys: ["1", "2[].label", "3.title"]},
+    {module: "yui_time.js", name: "tr", exported: false, keys: ["1"]},
+    {module: "yui_tabulator_i18n.js", name: "tr", exported: false, keys: ["0"]},
+    {module: "yui_toolbar.js", name: "arrow_button", exported: false, keys: ["2"]},
+    {module: "yui_graph_camera.js", name: "camera_button", exported: false, keys: ["3"]},
+    {module: "c_yui_json.js", name: "icon_button", exported: false, keys: ["3"]},
+    {module: "c_yui_json_pad.js", name: "pad_button", exported: false, keys: ["3"]},
+    {module: "c_yui_json_pad.js", name: "build_pane", exported: false, keys: ["2"]},
+    {module: "c_yui_gclass.js", name: "icon_button", exported: false, keys: ["3"]},
+    {module: "c_yui_gclass.js", name: "empty_line", exported: false, keys: ["0"]},
+    {module: "c_yui_gclass.js", name: "build_zone", exported: false, keys: ["1.key"]},
+    {module: "c_yui_period.js", name: "nav_button", exported: false, keys: ["3"]},
+    {module: "c_yui_period.js", name: "mode_name", exported: false, keys: ["0.id", "0.roll.label"]},
+    {module: "c_yui_form.js", name: "cell_icon", exported: false, keys: ["1"]},
+    {module: "c_yui_treedb_graph.js", name: "step_button", exported: false, keys: ["2"]},
+    {module: "c_yui_treedb_graph.js", name: "layout_step_button", exported: false, keys: ["3"]},
+    {module: "c_yui_treedb_graph.js", name: "answer_print_tranger_refused", exported: false,
+        keys: ["2.i18n"]},
+    {module: "c_yui_treedb_topics.js", name: "answer_print_tranger_refused", exported: false,
+        keys: ["2.i18n"]},
+    {module: "c_yui_treedb_topics.js", name: "card_action_anchor", exported: false, keys: ["2"]},
+    {module: "c_yui_treedb_topics.js", name: "push_meta", exported: false, keys: ["0"]},
+    {module: "c_yui_treedb_topics.js", name: "relation", exported: false, keys: ["1"]},
+    {module: "c_yui_treedb_topic_with_form.js", name: "confirm_then", exported: false, keys: ["1"]},
+    {module: "c_yui_treedb_topic_with_form.js", name: "present_json_popup", exported: false,
+        keys: ["2.title"]},
+    {module: "c_yui_schema_editor.js", name: "show_notice", exported: false, keys: ["1"]},
+    {module: "c_yui_schema_editor.js", name: "toolbar_button", exported: false, keys: ["2"]},
+    {module: "c_yui_schema_editor.js", name: "row_icon", exported: false, keys: ["3"]},
+    {module: "c_yui_schema_editor.js", name: "name_control", exported: false, keys: ["1"]},
+    {module: "c_yui_schema_editor.js", name: "named", exported: false, keys: ["1"]},
+    {module: "c_yui_schema_editor.js", name: "name_attrs", exported: false, keys: ["0"]},
+    {module: "c_yui_schema_editor.js", name: "field", exported: false, keys: ["2", "4"]},
+    {module: "c_yui_schema_editor.js", name: "row", exported: false, keys: ["0"]},
+    {module: "c_yui_schema_editor.js", name: "confirm_then", exported: false, keys: ["1"]},
+    {module: "c_yui_schema_editor.js", name: "end_writes", exported: false, keys: ["1"]},
+    {module: "c_yui_schema_editor.js", name: "open_dialog", exported: false, keys: ["2"]},
+    {module: "c_g6_nodes_tree.js", name: "create_floating_icon", exported: false, keys: ["4"]},
+    {module: "c_g6_nodes_tree.js", name: "show_dual_icons", exported: false, keys: ["3", "5"]},
+    {module: "c_g6_nodes_tree.js", name: "create_form_label", exported: false, keys: ["1"]},
+    {module: "c_g6_nodes_tree.js", name: "create_form_select", exported: false, keys: ["1[].i18n"]},
+    {module: "c_g6_nodes_tree.js", name: "create_form_button_row", exported: false, keys: ["1[].i18n"]},
+    {module: "c_g6_nodes_tree.js", name: "show_confirm_popover", exported: false, keys: ["3"]},
+    {module: "yui_dev.js", name: "mk_view", exported: false, keys: ["1"]},
+    {module: "yui_dev.js", name: "mk_out", exported: false, keys: ["1"]},
+    {module: "yui_dev.js", name: "mk_expand", exported: false, keys: ["1"]},
+    {module: "yui_dev.js", name: "mk_dir", exported: false, keys: ["3"]},
+    {module: "yui_dev.js", name: "grp", exported: false, keys: ["0"]},
+    {module: "yui_dev.js", name: "grp_scroll", exported: false, keys: ["0"]},
+]);