@yuneta/gobj-ui 7.25.13 → 7.25.15

package/src/c_yui_treedb_topics.js

@@ -160,10 +160,11 @@ function mt_create(gobj)
      *  and serial (form_writes_in_flight): answered refused when the
      *  transport closes under them.  */
     gobj.priv.form_writes = {};
-    /*  The topics a write cut by a DROP left unknown: the table may show
-     *  what was typed and the store what it had. Read again when the
-     *  session is back (reload_owed_topics), never out of session.  */
-    gobj.priv.reload_on_session = {};
+    /*  The session dropped since the tables were read: every open table
+     *  may be stale (a write the drop cut, node events published while
+     *  nobody heard them). Read again when the session is back
+     *  (reread_open_topics), never out of session.  */
+    gobj.priv.reread_on_session = false;
     gobj.priv.conn_shell = null;    /*  the shell whose EV_CONNECTION_STATE we hear  */
 
     build_ui(gobj);
@@ -187,7 +188,7 @@ function mt_start(gobj)
      *  (yui_shell_set_connection_state). A write in flight when it drops
      *  is never answered, and its form waited for ever in every host
      *  that did not forward EV_TRANSPORT_STATE -- wattyzer and yunovatios
-     *  among them (M8 of the 2026-09-23 review). The transport itself is
+     *  among them. The transport itself is
      *  not subscribed to: see ac_transport_state().  */
     let shell = yui_shell_of(gobj);
     if(shell) {
@@ -2111,7 +2112,7 @@ function ac_mt_command_answer(gobj, event, kw, src)
                         log_warning(`${gobj_short_name(gobj)}: the write of ` +
                             `'${failed_topic}' was cut by the drop: the topic is ` +
                             `read again when the session is back`);
-                        gobj.priv.reload_on_session[failed_topic] = true;
+                        gobj.priv.reread_on_session = true;
                     }
                 }
                 /*  Answered once: the transport closing may have answered
@@ -2475,18 +2476,17 @@ function ac_transport_state(gobj, event, kw, src)
 
     /*
      *  A write in flight when the transport closes is never answered by
-     *  the backend: its form stayed open and busy for ever (N8 of the
-     *  2026-09-22 review). Answered refused: the form stays open on what
+     *  the backend: its form stayed open and busy for ever. Answered
+     *  refused: the form stays open on what
      *  was typed, and the person saves again when the session is back.
      */
     if(!connected) {
+        /*  What happens in the store while the session is down reaches
+         *  no table: its node events are published to nobody. Every open
+         *  table is read again when the session is back.  */
+        gobj.priv.reread_on_session = true;
         abandon_form_writes(gobj.priv.form_writes).forEach((w) => {
             log_warning(`${gobj_short_name(gobj)}: transport closed, the write ${w.form_write} of '${w.topic_name}' is lost`);
-            /*  Whether it reached the store is unknown: read it again
-             *  when the session is back.  */
-            if(w.topic_name) {
-                gobj.priv.reload_on_session[w.topic_name] = true;
-            }
             answer_form_write(
                 gobj,
                 get_gobj_formtable(gobj, w.topic_name),
@@ -2495,32 +2495,37 @@ function ac_transport_state(gobj, event, kw, src)
             );
         });
     } else {
-        reload_owed_topics(gobj);
+        reread_open_topics(gobj);
     }
     return 0;
 }
 
 /************************************************************
- *  The session is back: read again the topics a drop left
- *  unknown. Only when the TRANSPORT says so too -- the app's
- *  connection (EV_CONNECTION_STATE) can report "up" before the
- *  transport of this view is in session, and a read asked then is
- *  refused. What is owed stays owed until an edge finds the
- *  transport in session; each topic is read once.
+ *  The session is back after a drop: read every open table again,
+ *  as the schema editor reloads its model. A drop cuts the writes
+ *  in flight AND the node events published meanwhile, so any
+ *  table may be stale, not only the one a cut write left.
+ *
+ *  Only when the TRANSPORT says so too -- the app's connection
+ *  (EV_CONNECTION_STATE) can report "up" before the transport of
+ *  this view is in session, and a read asked then is refused. The
+ *  read waits for an edge that finds the transport in session, and
+ *  is done once, though both edges report the same "up".
  ************************************************************/
-function reload_owed_topics(gobj)
+function reread_open_topics(gobj)
 {
     let priv = gobj.priv;
-    if(!is_connected(gobj)) {
+    if(!priv.reread_on_session || !is_connected(gobj)) {
         return;
     }
-    let topics = Object.keys(priv.reload_on_session);
-    priv.reload_on_session = {};
-    topics.forEach((topic_name) => {
-        if(!get_gobj_formtable(gobj, topic_name)) {
-            return;     /*  its table is closed: opening it reads it  */
+    priv.reread_on_session = false;
+    gobj_match_children(gobj, {
+        __gclass_name__: "C_YUI_TREEDB_TOPIC_WITH_FORM"
+    }).forEach((form) => {
+        let topic_name = gobj_read_attr(form, "topic_name");
+        if(topic_name) {
+            gobj_send_event(gobj, "EV_REFRESH_TOPIC", {topic_name: topic_name}, gobj);
         }
-        gobj_send_event(gobj, "EV_REFRESH_TOPIC", {topic_name: topic_name}, gobj);
     });
 }
 
@@ -2643,8 +2648,8 @@ function ac_create_record(gobj, event, kw, src)
 
     /*  `create_only`: +New makes a NEW record. With `create` alone a taken
      *  id was an update -- the record overwritten and, through autolink
-     *  with the selects empty, unlinked, answered "Node update!" (M28 of
-     *  the 2026-09-21 review). A backend older than the option ignores it
+     *  with the selects empty, unlinked, answered "Node update!". A
+     *  backend older than the option ignores it
      *  and keeps the old upsert.  */
     let options = {
         list_dict: true,
@@ -2890,8 +2895,8 @@ function ac_update_record(gobj, event, kw, src)
 /************************************************************
  *  A write sent with no session never leaves: C_IEVENT_CLI logs
  *  "Not in session" and answers null, as it does when the command
- *  went -- so a form waiting for the answer waited for ever (N8 of
- *  the 2026-09-22 review). Refused before it is sent, aloud.
+ *  went -- so a form waiting for the answer waited for ever. Refused
+ *  before it is sent, aloud.
  ************************************************************/
 function refuse_without_session(gobj, topic_name)
 {

package/src/form_busy.js

@@ -10,9 +10,8 @@
  *          that back. So a second busy(true) while already busy must not
  *          run at all -- it read the buttons it had just disabled as
  *          "disabled on their own", and the busy(false) of a refused write
- *          left Save and Cancel dead (N9 of the 2026-09-22 review: a record
- *          with a picked file went busy for the read, then busy again for
- *          the write). The caller owns `state` ({busy}) for the form's life.
+ *          left Save and Cancel dead (a record with a picked file went
+ *          busy for the read, then busy again for the write). The caller owns `state` ({busy}) for the form's life.
  *
  *          Copyright (c) 2026, ArtGins.
  *          All Rights Reserved.

package/src/form_time_value.js

@@ -37,7 +37,7 @@
  *  A Date -> the value of a `datetime-local` input, in local time,
  *  WITH seconds: the input is built with `step: 1`, which is what
  *  lets it hold them. Written as "YYYY-MM-DDTHH:mm" it lost them on
- *  every save of any field (M26 of the 2026-09-21 review).
+ *  every save of any field.
  ************************************************************/
 function date_to_datetime_local(value)
 {

package/src/form_time_value.test.js

@@ -4,7 +4,7 @@ import {date_to_datetime_local, datetime_local_to_epoch} from "./form_time_value
 describe("form_time_value", () => {
 
     it("an epoch with seconds survives a round trip through the input", () => {
-        /*  M26 of the 2026-09-21 review: the input was written without
+        /*  The input was written without
          *  seconds, so every save of ANY field moved a writable time
          *  column back up to 59 s. */
         const epoch = 1790000037;   // :37 seconds

package/src/form_writes_in_flight.js

@@ -7,8 +7,7 @@
  *          answers, so the host has to answer EVERY way a write ends --
  *          and the transport closing under a write in flight, or a
  *          command that never left because there was no session, are two
- *          of them that nobody answered: the form stayed busy for ever
- *          (N8 of the 2026-09-22 review).
+ *          of them that nobody answered: the form stayed busy for ever.
  *
  *          A write is known by its TOPIC and its `form_write` serial,
  *          never by the serial alone: each topic has its own form, and

package/src/g6_nodes_tree_fsm.test.js

@@ -0,0 +1,33 @@
+/***********************************************************************
+ *          g6_nodes_tree_fsm.test.js
+ *
+ *      The machine of the real C_G6_NODES_TREE: the events its host
+ *      sends it are declared, and each has an action. The host's own
+ *      tests drive a fake engine, which cannot see this.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {describe, test, expect} from "vitest";
+import {install_dom_double} from "../test/dom_double.js";
+
+install_dom_double();
+
+const {
+    gclass_find_by_name, gclass_event_type, gclass_check_fsm,
+} = await import("@yuneta/gobj-js");
+const {register_c_g6_nodes_tree} = await import("./c_g6_nodes_tree.js");
+
+describe("C_G6_NODES_TREE", () => {
+
+    test("hears EV_GRAPHS_WRITE_REFUSED, the host's word on a __graphs__ write", () => {
+        register_c_g6_nodes_tree();
+        const gclass = gclass_find_by_name("C_G6_NODES_TREE", false);
+        expect(gclass).toBeTruthy();
+        expect(gclass_event_type(gclass, "EV_GRAPHS_WRITE_REFUSED")).toBeTruthy();
+        const idle = gclass.dl_states.find((st) => st.state_name === "ST_IDLE");
+        expect(idle.dl_actions.some((a) => a.event_name === "EV_GRAPHS_WRITE_REFUSED" &&
+            typeof a.action === "function")).toBe(true);
+        expect(gclass_check_fsm(gclass)).toBe(0);
+    });
+});

package/src/graph_save_plan.js

@@ -140,7 +140,35 @@ function apply_graphs_echo(live, saved, records, rec)
     }
 }
 
+/***************************************************************
+ *  A write of one topic's arrangement did NOT land: the backend
+ *  refused it, the transport refused it on the way out, or there
+ *  was no session to send it on.
+ *
+ *      saved       {topic_name: properties}  what the backend has
+ *      topic_name  the topic of the refused record
+ *
+ *  The view records a write as saved BEFORE it leaves, because
+ *  nothing answers it when it lands. So a refused one left the view
+ *  believing the backend held an arrangement it does not, and the
+ *  next Save found nothing to write. What the backend holds for the
+ *  topic is not known any more, so it is forgotten: the next Save
+ *  writes the topic again (plan_graph_saves()).
+ *
+ *  Returns TRUE if there was something to forget.
+ ***************************************************************/
+function forget_refused_graphs_write(saved, topic_name)
+{
+    if(!is_object(saved) || !topic_name ||
+            !Object.prototype.hasOwnProperty.call(saved, topic_name)) {
+        return false;
+    }
+    delete saved[topic_name];
+    return true;
+}
+
 export {
+    forget_refused_graphs_write,
     apply_graphs_echo,
     plan_graph_saves,
     topic_arrangement_changed,

package/src/graph_save_plan.test.js

@@ -18,7 +18,8 @@
  ***********************************************************************/
 import {describe, test, expect} from "vitest";
 import {
-    plan_graph_saves, topic_arrangement_changed, arrangement_of, apply_graphs_echo
+    plan_graph_saves, topic_arrangement_changed, arrangement_of, apply_graphs_echo,
+    forget_refused_graphs_write
 } from "./graph_save_plan.js";
 
 const ORIGIN = "f3163a9f-1f37-412a-b8c9-87a4341f14de";
@@ -150,7 +151,7 @@ describe("arrangement_of", () => {
  *  save by another browser, sends back. It used to rebuild the saved
  *  snapshot of EVERY topic, taking the copies from the live objects the
  *  view had already rearranged: what was unsaved in OTHER topics counted
- *  as saved, and the next Save skipped it (M32 of the 2026-09-21 review).
+ *  as saved, and the next Save skipped it.
  */
 describe("an echo of one __graphs__ record", () => {
     function state()
@@ -200,3 +201,36 @@ describe("an echo of one __graphs__ record", () => {
         expect(live.yunos).toBeDefined();
     });
 });
+
+/*
+ *  A write of `__graphs__` that the backend REFUSED. The view takes the
+ *  write for granted before it leaves (nothing answers it when it lands),
+ *  so a refused one was recorded as saved: the next Save found nothing to
+ *  write, and the arrangement was never stored.
+ */
+describe("a refused __graphs__ write", () => {
+
+    test("is planned again by the next Save", () => {
+        let live = five_topics();
+        let saved = five_topics();
+        live.yunos.nodes["1"].x = 500;
+        expect(plan_graph_saves(live, saved)).toEqual(["yunos"]);
+
+        /*  What save_topic_graph_properties() does before the publish.  */
+        saved.yunos = JSON.parse(JSON.stringify(live.yunos));
+        expect(plan_graph_saves(live, saved)).toEqual([]);
+
+        expect(forget_refused_graphs_write(saved, "yunos")).toBe(true);
+        expect(plan_graph_saves(live, saved)).toEqual(["yunos"]);
+        expect(Object.keys(saved)).not.toContain("yunos");
+        expect(Object.keys(saved).length).toBe(4);
+    });
+
+    test("a topic the view never believed saved: nothing to forget", () => {
+        let saved = five_topics();
+        expect(forget_refused_graphs_write(saved, "nothing")).toBe(false);
+        expect(forget_refused_graphs_write(saved, "")).toBe(false);
+        expect(forget_refused_graphs_write(null, "yunos")).toBe(false);
+        expect(Object.keys(saved).length).toBe(5);
+    });
+});

package/src/host_drafts.js

@@ -7,9 +7,8 @@
  *          it, and that mark lived in the memory of the session only:
  *          a reload of the page, a reconnect or a refresh of the model
  *          lost the chip, the banner and the export warning while
- *          __system__ still differed from the file in use (N13 of the
- *          2026-09-22 review). The host reads that difference from
- *          C_TREEDB's `saved-schema` (`draft_changed`, by treedb) and
+ *          __system__ still differed from the file in use. The host
+ *          reads that difference from C_TREEDB's `saved-schema` (`draft_changed`, by treedb) and
  *          hands it here; the editor applies it to its model, in place
  *          of what the host said before.
  *

package/src/schema_editor_drafts.wiring.test.js

@@ -4,7 +4,7 @@
  *      EV_DRAFTS driven through a real C_YUI_SCHEMA_EDITOR on a document
  *      double. The helper was right and tested; the ACTION folded the
  *      host's marks into the session's, so a topic the host named before
- *      a Save stayed a draft after it (M1 of the 2026-09-23 review).
+ *      a Save stayed a draft after it.
  *
  *          Copyright (c) 2026, ArtGins.
  *          All Rights Reserved.