@yuneta/gobj-ui 7.23.195 → 7.23.196

package/src/c_yui_schema_editor.js

@@ -19,13 +19,15 @@
  *      fkey, the order of a new sibling, the version that publishes
  *      the change.
  *
- *      THE VERSION IS THE POINT, not a detail. A topic whose columns
- *      changed and whose `topic_version` did not is a topic whose
- *      persisted `topic_cols.json` masks the whole edit: the restart
- *      succeeds and nothing moved. Nothing in the store says so, and
- *      the log that would is on the node. So every write here raises
- *      the version of the topic it touched, and the toolbar says which
- *      topics are waiting for a restart.
+ *      AN EDIT IS A DRAFT. A write here moves no version and reaches no
+ *      treedb: the host SAVES it (C_TREEDB's save-schema raises the
+ *      topic_version of what changed and the schema_version, once) and
+ *      APPLIES it (apply-schema + a restart of the owning yuno). Until
+ *      the owner's design of M36 (2026-09-21 review) every write here
+ *      raised both versions, so an edit half made was already the
+ *      schema of the next start. The topic list marks what this session
+ *      wrote and has not saved; the host's EV_REFRESH after a save is
+ *      what forgets it.
  *
  *      WHAT ELSE IS HERE, and why each is here and not somewhere else:
  *
@@ -572,21 +574,23 @@ function start_measuring(gobj)
 }
 
 /***************************************************************
- *  "This topic was written and its version did not move."
+ *  "This topic was written in this session and is not saved."
  *
- *  ONE predicate, because it is asked in two places -- the topic
- *  list draws a chip with it and the column view draws a banner --
- *  and two copies of a rule is how they drift.
+ *  An edit is a DRAFT: it moves no version and reaches no treedb
+ *  until the host saves it (C_TREEDB's save-schema, which raises the
+ *  versions of what changed) -- and the save makes the host send
+ *  EV_REFRESH, whose reload is what forgets the drafts.
+ *
+ *  ONE predicate, because it is asked in three places -- the topic
+ *  list draws a chip with it, the column view a banner, the export
+ *  a warning -- and copies of a rule are how they drift.
  ***************************************************************/
-function needs_version_bump(written, baseline, topic)
+function topic_is_draft(written, topic)
 {
-    if(!topic || !written || !baseline) {
-        return false;
-    }
-    if(!written[topic.id]) {
+    if(!topic || !written) {
         return false;
     }
-    return String(baseline[topic.id]) === String(topic.topic_version);
+    return written[topic.id]? true: false;
 }
 
 /***************************************************************
@@ -1041,7 +1045,7 @@ function render_topics(gobj, $body)
     let twice = repeated_names(treedb.topics);
     let $rows = [];
     for(let topic of treedb.topics) {
-        let pending = needs_version_bump(priv.written, priv.baseline, topic);
+        let pending = topic_is_draft(priv.written, topic);
         /*  Two topics of one name: the id is what tells them apart, and
          *  it is what the url has to carry — addressing by name would
          *  open the first one whichever row was clicked.  */
@@ -1192,7 +1196,7 @@ function render_columns(gobj, $body)
      *  The version banner: the one thing that makes
      *  an edit succeed and change nothing.
      *----------------------------------------------*/
-    let $banner = version_banner(gobj, topic);
+    let $banner = draft_banner(gobj, topic);
     if($banner) {
         $wrap.appendChild($banner);
     }
@@ -1235,48 +1239,34 @@ function render_columns(gobj, $body)
 }
 
 /***************************************************************
- *  "This topic changed and its version did not."
+ *  "This topic has changes that are not saved."
  *
- *  Only shown when it is TRUE — the topic was written in this
- *  session and its `topic_version` still reads what it read when
- *  the model loaded. Every write this view makes raises it, so
- *  the banner is for the case where something else did not: an
- *  edit made from the raw tables, or a bump undone by hand.
+ *  A draft, not an error: the edit is in __system__ and moves no
+ *  version, so the treedb does not see it until the host saves it
+ *  (and applies it). The banner says so and offers nothing -- the
+ *  save is the host's, one level up, because it publishes the whole
+ *  treedb and not one topic.
  ***************************************************************/
-function version_banner(gobj, topic)
+function draft_banner(gobj, topic)
 {
     let priv = gobj.priv;
 
-    if(!needs_version_bump(priv.written, priv.baseline, topic)) {
+    if(!topic_is_draft(priv.written, topic)) {
         return null;
     }
     if(is_readonly(gobj)) {
         return null;
     }
 
-    let $banner = createElement2(
-        ["div", {class: "SCHEMA_VERSION_BANNER notification is-warning is-light p-3 mb-3 " +
+    return createElement2(
+        ["div", {class: "SCHEMA_DRAFT_BANNER notification is-warning is-light p-3 mb-3 " +
                         "is-flex is-align-items-center", style: "gap:.5rem;"}, [
             ["span", {class: "icon"}, [["i", {class: "yi-triangle-exclamation"}]]],
-            ["span", {class: "SCHEMA_VERSION_TEXT is-size-7", i18n: "version not raised"},
-                t("version not raised")],
-            ["button", {class: "SCHEMA_VERSION_BUMP button is-warning",
-                        type: "button",
-                        style: "margin-left:auto;",
-                        title: t("raise the version"), "aria-label": t("raise the version"),
-                        "data-i18n-title": "raise the version",
-                        "data-i18n-aria-label": "raise the version"}, [
-                ["span", {class: "icon"}, [["i", {class: "yi-circle-up"}]]],
-                ["span", {i18n: "raise"}, t("raise")]
-            ]]
+            ["span", {class: "SCHEMA_DRAFT_TEXT is-size-7",
+                      i18n: "unsaved schema changes: save to publish them"},
+                t("unsaved schema changes: save to publish them")]
         ]]
     );
-    let $bump = $banner.querySelector(".SCHEMA_VERSION_BUMP");
-    $bump.addEventListener("click", (evt) => {
-        evt.stopPropagation();
-        gobj_send_event(gobj, "EV_BUMP_VERSION", {topic: topic.name}, gobj);
-    });
-    return $banner;
 }
 
 /***************************************************************
@@ -2001,6 +1991,8 @@ function open_report(gobj, findings, treedb_id)
  ***************************************************************/
 function open_export(gobj, treedb)
 {
+    let priv = gobj.priv;
+    let drafts = treedb.topics.some((topic) => topic_is_draft(priv.written, topic));
     let c_text = schema_to_c(treedb);
     let json_text = JSON.stringify(schema_to_json(treedb), null, 4);
 
@@ -2017,11 +2009,20 @@ function open_export(gobj, treedb)
             ["p", {class: "SCHEMA_EXPORT_HELP help mb-2",
                    i18n: "an edit made here works and lives in no source: this is what to paste back"},
                 t("an edit made here works and lives in no source: this is what to paste back")],
+            drafts
+                ? ["p", {class: "SCHEMA_EXPORT_DRAFTS notification is-warning is-light p-2 mb-2 is-size-7",
+                         i18n: "unsaved changes: save first, so the literal carries the versions that publish it"},
+                    t("unsaved changes: save first, so the literal carries the versions that publish it")]
+                : ["span", {}, ""],
             ["textarea", {class: "SCHEMA_EXPORT_TEXT textarea is-small is-family-monospace",
-                          rows: "18", readonly: "readonly", spellcheck: "false"}, c_text],
+                          rows: "18", readonly: "readonly", spellcheck: "false",
+                          title: t("schema"), "data-i18n-title": "schema",
+                          "aria-label": t("schema"), "data-i18n-aria-label": "schema"}, c_text],
             ["div", {class: "SCHEMA_EXPORT_ACTIONS is-flex mt-3",
                      style: "gap:.5rem; justify-content:flex-end;"}, [
-                ["button", {class: "SCHEMA_EXPORT_COPY button", type: "button"}, [
+                ["button", {class: "SCHEMA_EXPORT_COPY button", type: "button",
+                            title: t("copy"), "data-i18n-title": "copy",
+                            "aria-label": t("copy"), "data-i18n-aria-label": "copy"}, [
                     ["span", {class: "icon"}, [["i", {class: "yi-copy"}]]],
                     ["span", {i18n: "copy"}, t("copy")]
                 ]]
@@ -2240,51 +2241,6 @@ function open_orphans(gobj)
 
 
 
-/***************************************************************
- *  THE TWO VERSIONS A SCHEMA EDIT HAS TO RAISE, and why both.
- *
- *  `topic_version` is what publishes a change of a topic's
- *  columns: leave it and the persisted `topic_cols.json` masks
- *  the edit, the restart succeeds and nothing moved.
- *
- *  `schema_version` is what publishes the schema as a whole —
- *  "the stored one wins on ties, and the incoming one has to be
- *  strictly newer to take over" (c_treedb.c). It is safe to
- *  raise: re-projection from C compares `c_schema_version`, the
- *  version of the LITERAL, precisely so that an edit made here
- *  survives every start until a newer literal arrives.
- *
- *  So every write that changes a schema carries both, and the
- *  operator is never asked to remember either.
- ***************************************************************/
-function version_writes(gobj, topic)
-{
-    let treedb = current_treedb(gobj);
-    let writes = [];
-
-    if(topic) {
-        let version = Number(topic.topic_version);
-        if(!isFinite(version)) {
-            version = 0;
-        }
-        writes.push({
-            op: "update", topic_name: T_TOPICS,
-            record: {id: topic.id, topic_version: version + 1}
-        });
-    }
-    if(treedb) {
-        let version = Number(treedb.schema_version);
-        if(!isFinite(version)) {
-            version = 0;
-        }
-        writes.push({
-            op: "update", topic_name: T_TREEDBS,
-            record: {id: treedb.id, schema_version: version + 1}
-        });
-    }
-    return writes;
-}
-
 /***************************************************************
  *  WHERE THE COLUMNS WERE before this session started moving them.
  *
@@ -2968,7 +2924,7 @@ function ac_save_column(gobj, event, kw, src)
         op:         kw.creating ? "create" : "update",
         topic_name: T_COLS,
         record:     column_record(gobj, topic, col, values)
-    }].concat(version_writes(gobj, topic)));
+    }]);
 }
 
 function ac_delete_column(gobj, event, kw, src)
@@ -3026,7 +2982,7 @@ function ac_move_column(gobj, event, kw, src)
     if(writes.length === 0) {
         return 0;       /*  dropped where it already was  */
     }
-    return queue_writes(gobj, writes.concat(version_writes(gobj, topic)));
+    return queue_writes(gobj, writes);
 }
 
 /***************************************************************
@@ -3055,7 +3011,7 @@ function ac_undo_order(gobj, event, kw, src)
     }
     /*  Spent: what it named is where the columns are about to be. */
     delete priv.order_undo[topic.id];
-    return queue_writes(gobj, writes.concat(version_writes(gobj, topic)));
+    return queue_writes(gobj, writes);
 }
 
 /***************************************************************
@@ -3127,7 +3083,7 @@ function ac_save_topic(gobj, event, kw, src)
         op:         kw.creating ? "create" : "update",
         topic_name: T_TOPICS,
         record:     topic_record(gobj, treedb, topic, values)
-    }].concat(version_writes(gobj, null)));
+    }]);
 }
 
 function ac_delete_topic(gobj, event, kw, src)
@@ -3148,25 +3104,6 @@ function ac_delete_topic(gobj, event, kw, src)
     return 0;
 }
 
-/***************************************************************
- *  Raising a version by hand: what the banner offers when
- *  something else wrote the topic and left its version alone.
- ***************************************************************/
-function ac_bump_version(gobj, event, kw, src)
-{
-    let priv = gobj.priv;
-    let topic = find_topic(priv.model, priv.treedb_id, kw.topic);
-
-    if(refuse_if_readonly(gobj, event)) {
-        return -1;
-    }
-    if(!topic) {
-        log_error(`${gobj_short_name(gobj)}: ${event} names no topic: ${kw.topic}`);
-        return -1;
-    }
-    return queue_writes(gobj, version_writes(gobj, topic));
-}
-
 /***************************************************************
  *  Deleting a leftover.
  ***************************************************************/
@@ -3339,7 +3276,7 @@ function ac_confirmed(gobj, event, kw, src)
             return {op: "delete", topic_name: T_COLS, record: {id: col.id}};
         });
         writes.push({op: "delete", topic_name: T_TOPICS, record: {id: topic.id}});
-        return queue_writes(gobj, writes.concat(version_writes(gobj, null)));
+        return queue_writes(gobj, writes);
     }
     if(kw.what === "column") {
         let topic = find_topic(priv.model, priv.treedb_id, kw.topic);
@@ -3350,7 +3287,7 @@ function ac_confirmed(gobj, event, kw, src)
         }
         return queue_writes(gobj, [{
             op: "delete", topic_name: T_COLS, record: {id: col.id}
-        }].concat(version_writes(gobj, topic)));
+        }]);
     }
 
     log_error(`${gobj_short_name(gobj)}: ${event} of nothing this view asked about: ${kw.what}`);
@@ -3450,8 +3387,7 @@ function create_gclass(gclass_name)
             ["EV_DELETE_COLUMN",    ac_delete_column,       null],
             ["EV_SAVE_COLUMN",      ac_save_column,         null],
             ["EV_MOVE_COLUMN",      ac_move_column,         null],
-            ["EV_UNDO_ORDER",       ac_undo_order,          null],
-            ["EV_BUMP_VERSION",     ac_bump_version,        null]
+            ["EV_UNDO_ORDER",       ac_undo_order,          null]
         ])],
 
         /*  A write, or a plan of them, in flight. Only the answers and
@@ -3494,7 +3430,6 @@ function create_gclass(gclass_name)
         ["EV_SAVE_COLUMN",          0],
         ["EV_MOVE_COLUMN",          0],
         ["EV_UNDO_ORDER",           0],
-        ["EV_BUMP_VERSION",         0],
         ["EV_VALIDATE",             0],
         ["EV_EXPORT",               0],
         ["EV_IMPORT",               0],
@@ -3549,5 +3484,5 @@ export {
     register_c_yui_schema_editor,
     /*  Exported for its test: the rule that decides whether a topic still
      *  owes a version bump, which is asked in two places.  */
-    needs_version_bump
+    topic_is_draft
 };

package/src/schema_validate.js

@@ -16,10 +16,11 @@
  *                  operator drew does nothing at all. Restarting on
  *                  this is an outage with no gain.
  *        `warning` the schema opens and something is not what it looks
- *                  like — an unbumped `topic_version` masking the whole
- *                  edit is the one that costs the most time, because
- *                  the restart SUCCEEDS and the change is simply not
- *                  there.
+ *                  like.
+ *
+ *      A version is not checked here: an edit is a DRAFT and moves no
+ *      version, and C_TREEDB's save-schema raises the versions of what
+ *      changed when it publishes it.
  *
  *      Every `code` is an i18n key: the caller renders, this decides.
  *
@@ -69,8 +70,6 @@ function validate_schema(treedb, options)
 {
     let findings = [];
     let opts = options || {};
-    let written = Array.isArray(opts.written_topics) ? opts.written_topics : [];
-    let baseline = opts.baseline || {};
 
     if(!treedb || !Array.isArray(treedb.topics)) {
         return findings;
@@ -117,17 +116,6 @@ function validate_schema(treedb, options)
             }
         }
 
-        /*  A version that did not move republishes nothing: the stored
-         *  topic_cols.json masks the whole edit and the restart looks
-         *  like it worked.  */
-        if(written.indexOf(topic.id) >= 0) {
-            let before = baseline[topic.id];
-            if(before !== undefined && String(before) === String(topic.topic_version)) {
-                add("warning", "topic version not bumped", topic.name, "",
-                    String(topic.topic_version));
-            }
-        }
-
         for(let col of topic.cols) {
             let flags = col_flags(col.record);
             let type = col.record ? col.record.type : "";

package/src/schema_validate.test.js

@@ -221,34 +221,14 @@ describe("the column itself", () => {
     });
 });
 
-describe("the version that did not move", () => {
-    test("a written topic whose topic_version is unchanged is reported", () => {
+describe("a version is not the validator's", () => {
+    test("a written topic whose topic_version did not move is NOT reported", () => {
+        /*  An edit is a draft; save-schema raises the version.  */
         const f = validate_schema(schema(), {
             written_topics: ["db.departments"],
             baseline: {"db.departments": 1}
         });
-        const v = f.filter(x => x.code === "topic version not bumped");
-        expect(v.length).toBe(1);
-        expect(v[0].topic).toBe("departments");
-        expect(v[0].severity).toBe("warning");
-    });
-
-    test("a bumped version says nothing", () => {
-        expect(validate_schema(schema({dep_version: 2}), {
-            written_topics: ["db.departments"],
-            baseline: {"db.departments": 1}
-        })).toEqual([]);
-    });
-
-    test("a topic nobody wrote is not asked about its version", () => {
-        expect(validate_schema(schema(), {baseline: {"db.departments": 1}})).toEqual([]);
-    });
-
-    test("a version compared across types still matches (2 vs '2')", () => {
-        expect(validate_schema(schema({dep_version: "1"}), {
-            written_topics: ["db.departments"],
-            baseline: {"db.departments": 1}
-        }).length).toBe(1);
+        expect(f.filter(x => x.code === "topic version not bumped")).toEqual([]);
     });
 });
 

package/src/schema_version_bump.test.js

@@ -1,92 +1,35 @@
 /***********************************************************************
  *          schema_version_bump.test.js
  *
- *      "This topic was written and its version did not move."
+ *      "This topic was written in this session and is not saved."
  *
- *      THE RULE MEASURES AGAINST A BASELINE, AND THE BASELINE MUST NOT
- *      MOVE WITH IT.  It used to be re-taken inside build_model(), which
- *      runs again on the patch after EVERY write -- so it came back as
- *      the version the write had just raised, the rule read TRUE for a
- *      topic whose version HAD moved, and the banner that says so
- *      offered a Raise button that wrote another version and was
- *      measured against itself again.
- *
- *      The banner could not be dismissed.  One operator pressed it
- *      thirty-three times on a single column delete, and that is why
- *      schema versions climbed by tens with the schema unchanged.
+ *      An edit is a DRAFT (M36 of yunetas' 2026-09-21 review): it moves
+ *      no version, and the host's save-schema raises the versions of what
+ *      changed. So "written" alone is the whole question -- the version is
+ *      no longer measured against a baseline, which is also why the old
+ *      "Raise" button and the loop it fed are gone.
  *
  *          Copyright (c) 2026, ArtGins.
  *          All Rights Reserved.
  ***********************************************************************/
 import {describe, it, expect} from "vitest";
-import {needs_version_bump} from "./c_yui_schema_editor.js";
+import {topic_is_draft} from "./c_yui_schema_editor.js";
 
 const TOPIC = {id: "device_groups", topic_version: 5};
 
-describe("needs_version_bump", () => {
+describe("topic_is_draft", () => {
     it("says nothing about a topic this session never wrote", () => {
-        expect(needs_version_bump({}, {device_groups: 5}, TOPIC)).toBe(false);
+        expect(topic_is_draft({}, TOPIC)).toBe(false);
     });
 
-    it("asks for the bump when the version sits where it was found", () => {
-        expect(needs_version_bump({device_groups: true}, {device_groups: 5}, TOPIC))
+    it("a written topic is a draft, whatever its version says", () => {
+        expect(topic_is_draft({device_groups: true}, TOPIC)).toBe(true);
+        expect(topic_is_draft({device_groups: true}, {id: "device_groups", topic_version: 6}))
             .toBe(true);
     });
 
-    it("STOPS asking once the version has moved past the baseline", () => {
-        /*  The case the loop got wrong: the write raised it to 6 and the
-         *  baseline still says 5, so there is nothing left to raise.  */
-        expect(needs_version_bump(
-            {device_groups: true}, {device_groups: 5}, {id: "device_groups", topic_version: 6}
-        )).toBe(false);
-    });
-
-    it("compares as text, so 5 and '5' are the same version", () => {
-        expect(needs_version_bump(
-            {device_groups: true}, {device_groups: "5"}, TOPIC
-        )).toBe(true);
-        expect(needs_version_bump(
-            {device_groups: true}, {device_groups: 5}, {id: "device_groups", topic_version: "5"}
-        )).toBe(true);
-    });
-
     it("answers false rather than throwing on a missing half", () => {
-        expect(needs_version_bump(null, {device_groups: 5}, TOPIC)).toBe(false);
-        expect(needs_version_bump({device_groups: true}, null, TOPIC)).toBe(false);
-        expect(needs_version_bump({device_groups: true}, {device_groups: 5}, null)).toBe(false);
-    });
-
-    it("a topic with no baseline entry is not owed a bump", () => {
-        expect(needs_version_bump({device_groups: true}, {}, TOPIC)).toBe(false);
-    });
-});
-
-describe("the loop it came from", () => {
-    /*
-     *  What the editor does per bump: raise the version by one. With the
-     *  baseline left alone, ONE press settles it; with the baseline
-     *  re-taken each time -- the old bug -- it never settles.
-     */
-    function press_raise(state) {
-        return {written: state.written, baseline: state.baseline,
-                topic: {id: "t", topic_version: Number(state.topic.topic_version) + 1}};
-    }
-
-    it("settles after a single press", () => {
-        let st = {written: {t: true}, baseline: {t: 5}, topic: {id: "t", topic_version: 5}};
-        expect(needs_version_bump(st.written, st.baseline, st.topic)).toBe(true);
-        st = press_raise(st);
-        expect(needs_version_bump(st.written, st.baseline, st.topic)).toBe(false);
-    });
-
-    it("never settles if the baseline is re-taken with the version", () => {
-        let st = {written: {t: true}, baseline: {t: 5}, topic: {id: "t", topic_version: 5}};
-        let presses = 0;
-        while(needs_version_bump(st.written, st.baseline, st.topic) && presses < 40) {
-            st = press_raise(st);
-            st.baseline = {t: st.topic.topic_version};   /*  the bug  */
-            presses++;
-        }
-        expect(presses).toBe(40);       /*  it ran to the guard: no way out  */
+        expect(topic_is_draft(null, TOPIC)).toBe(false);
+        expect(topic_is_draft({device_groups: true}, null)).toBe(false);
     });
 });