@yuneta/gobj-ui 7.23.168 → 7.23.170

package/src/c_yui_treedb_topic_with_form.js

@@ -23,6 +23,7 @@ import {
     json_deep_copy,
     createElement2,
     gobj_send_event,
+    gobj_post_event,
     clean_name,
     is_array,
     is_string,
@@ -95,7 +96,9 @@ import {t} from "i18next";
 
 import {yui_toolbar_icon} from "./yui_toolbar.js";
 
-import {plan_treedb_writes, READONLY_FORM_TOOLBAR} from "./treedb_write_plan.js";
+import {
+    plan_treedb_writes, READONLY_FORM_TOOLBAR, col_goes_back_to_treedb
+} from "./treedb_write_plan.js";
 import {
     yui_file_read, yui_files_manifest, yui_file_id_label, yui_file_size_label
 } from "./yui_file_field.js";
@@ -209,8 +212,8 @@ SDATA(data_type_t.DTP_BOOLEAN,  "editable",             0,  false,  "Edit state"
 SDATA(data_type_t.DTP_BOOLEAN,  "with_checkbox",        0,  true,   "Auxiliary first column to select rows"),
 SDATA(data_type_t.DTP_BOOLEAN,  "with_radio",           0,  false,  "Auxiliary first column to select one row"),
 SDATA(data_type_t.DTP_BOOLEAN,  "with_selection_bar",   0,  false,  "Show the shared selection bar (\"N selected\" + a way out) above the table while in edition mode. OFF by default: the bar takes its words from the HOST's i18n, and a host that has not defined \"{{n}} selected\" and \"clear selection\" would render the keys"),
-SDATA(data_type_t.DTP_BOOLEAN,  "broadcast_select_rows_event",   0,  false, "Broadcast select rows event"),
-SDATA(data_type_t.DTP_BOOLEAN,  "broadcast_unselect_rows_event", 0,  false, "Broadcast unselect rows event"),
+SDATA(data_type_t.DTP_BOOLEAN,  "broadcast_select_rows_event",   0,  false, "Publish EV_SELECT_ROWS to the subscriber. OFF by default: the event is an OUTPUT event, so a host that turns it on must declare EV_SELECT_ROWS in its own FSM or it answers \"Event NOT DEFINED in state\" on every selected row"),
+SDATA(data_type_t.DTP_BOOLEAN,  "broadcast_unselect_rows_event", 0,  false, "Publish EV_UNSELECT_ROWS to the subscriber. Same contract as broadcast_select_rows_event, and INDEPENDENT of it: a host that wants both sets both"),
 
 /*---------------- Tabulator Defaults ----------------*/
 SDATA(data_type_t.DTP_JSON,     "tabulator_settings",   0,  {
@@ -605,7 +608,9 @@ function build_ui(gobj)
              *  instead of being pushed away from the harmless ones. Do not
              *  reorder this group as if they were peer actions.  */
             let $edit_button = createElement2(
-                ['button', {id: ``, class: 'button button-edit-record mr-1'}, [
+                ['button', {id: ``, class: 'button button-edit-record mr-1',
+                                title: t('edit'), 'data-i18n-title': 'edit',
+                                'aria-label': t('edit'), 'data-i18n-aria-label': 'edit'}, [
                     yui_toolbar_icon('yi-pen'),
                     ['span',
                         {
@@ -631,7 +636,9 @@ function build_ui(gobj)
 
             if(with_new_button) {
                 let $new_button = createElement2(
-                    ['button', {id: ``, class: 'button button-new-record mr-1', disabled: true}, [
+                    ['button', {id: ``, class: 'button button-new-record mr-1',
+                                title: t('new'), 'data-i18n-title': 'new',
+                                'aria-label': t('new'), 'data-i18n-aria-label': 'new', disabled: true}, [
                         yui_toolbar_icon('yi-plus'),
                         ['span',
                             {
@@ -651,7 +658,9 @@ function build_ui(gobj)
 
             if(with_delete_button) {
                 let $delete_button = createElement2(
-                    ['button', {id: ``, class: 'button button-delete-record mr-1', disabled: true}, [
+                    ['button', {id: ``, class: 'button button-delete-record mr-1',
+                                title: t('delete'), 'data-i18n-title': 'delete',
+                                'aria-label': t('delete'), 'data-i18n-aria-label': 'delete', disabled: true}, [
                         yui_toolbar_icon('yi-trash'),
                         ['span',
                             {
@@ -672,7 +681,9 @@ function build_ui(gobj)
 
             if(with_copy_button) {
                 let $copy_button = createElement2(
-                    ['button', {id: ``, class: 'button button-copy-record mr-1', disabled: true}, [
+                    ['button', {id: ``, class: 'button button-copy-record mr-1',
+                                title: t('copy'), 'data-i18n-title': 'copy',
+                                'aria-label': t('copy'), 'data-i18n-aria-label': 'copy', disabled: true}, [
                         yui_toolbar_icon('yi-copy'),
                         ['span',
                             {
@@ -693,7 +704,9 @@ function build_ui(gobj)
 
             if(with_paste_button) {
                 let $paste_button = createElement2(
-                    ['button', {id: ``, class: 'button button-paste-record mr-1', disabled: true}, [
+                    ['button', {id: ``, class: 'button button-paste-record mr-1',
+                                title: t('paste'), 'data-i18n-title': 'paste',
+                                'aria-label': t('paste'), 'data-i18n-aria-label': 'paste', disabled: true}, [
                         yui_toolbar_icon('yi-paste'),
                         ['span',
                             {
@@ -745,9 +758,17 @@ function build_ui(gobj)
                     type: 'text',
                     /*  The placeholder is not a text node, so the
                      *  data-i18n walk cannot reach it — it needs its own
-                     *  key or it stays English for good. */
+                     *  key or it stays English for good.
+                     *
+                     *  And a placeholder is not a NAME: it goes away the
+                     *  moment something is typed, and a reader is not
+                     *  obliged to announce it. The box carries no <label>
+                     *  either, so without the two below it is an unnamed
+                     *  text field. */
                     placeholder: t('search'),
-                    'data-i18n-placeholder': 'search'
+                    'data-i18n-placeholder': 'search',
+                    title: t('search'), 'data-i18n-title': 'search',
+                    'aria-label': t('search'), 'data-i18n-aria-label': 'search'
                 }],
                 ['span', {class: 'icon is-left'}, [
                     yui_toolbar_icon('yi-magnifying-glass')
@@ -776,7 +797,9 @@ function build_ui(gobj)
 
     if(with_refresh_button) {
         let $refresh = createElement2(
-            ['button', {class: 'button mr-1', title: t('refresh'), 'data-i18n-title': 'refresh'}, [
+            ['button', {class: 'button mr-1',
+                        title: t('refresh'), 'data-i18n-title': 'refresh',
+                        'aria-label': t('refresh'), 'data-i18n-aria-label': 'refresh'}, [
                 yui_toolbar_icon('yi-arrows-rotate'),
                 ['span', {class: 'is-hidden-mobile', i18n: 'refresh', style: 'padding-left:5px;'}, 'refresh']
             ], {
@@ -1485,7 +1508,7 @@ function create_tabulator(gobj)
                 let index = cell.getRow().getPosition();
                 if(e.target.closest('.edit')) {
                     e.stopPropagation();
-                    show_edit_form(gobj, row, index);
+                    gobj_send_event(gobj, "EV_EDIT_RECORD", {index: index}, gobj);
                 } else if(e.target.closest('.remove')) {
                     e.stopPropagation();
                     gobj_send_event(gobj, "EV_DELETE_ROWS", {index: index, row: row}, gobj);
@@ -2263,15 +2286,31 @@ function open_form_dialog(gobj, mode, record)
         return;
     }
 
-    /*  Title says what you are doing: "new <topic>" on create,
-     *  "<topic> — <pkey>" on update. */
+    /*  The title says WHAT YOU ARE DOING, and it has to survive a
+     *  language change.
+     *
+     *  It used to be composed here -- `t("new") + " " + t(topic_name)`
+     *  -- and handed to the dialog as its `title`, which the header
+     *  renders as an i18n KEY. So the composed sentence was looked up
+     *  as a key, found nothing, and rendered as itself: right the first
+     *  time, because both halves had been translated already, and
+     *  FROZEN in that language for the life of the dialog. Switching
+     *  language left "Nuevo usuarios" on an English page.
+     *
+     *  The header carries two halves and only one of them can hold a
+     *  key: `title_prefix` is DATA and is never translated, `title` is
+     *  the KIND and re-translates. So the record id goes in the prefix
+     *  -- it is the one part no language touches -- and the kind takes
+     *  the key. The topic name leaves the title: it is what the TAB
+     *  behind the dialog says, and the form's own fields say it again,
+     *  while "new"/"edit"/"view" is what only this header can tell you.
+     *  All three are keys this library already uses.  */
     let pkey = desc.pkey || "id";
-    let title;
-    if(mode === "create") {
-        title = t("new") + " " + t(topic_name);
-    } else {
+    let title = (mode === "create")? "new" : ((mode === "view")? "view" : "edit");
+    let title_prefix = "";
+    if(mode !== "create") {
         let rid = record ? String(record[pkey] ?? "") : "";
-        title = t(topic_name) + (empty_string(rid) ? "" : " — " + rid);
+        title_prefix = empty_string(rid)? "" : rid;
     }
 
     /*  "view" is an "update" that writes nothing: same title, same pkey
@@ -2334,6 +2373,7 @@ function open_form_dialog(gobj, mode, record)
     priv.form_modal = yui_shell_show_modal(shell, $body, {
         dialog:        true,
         logical_class: "TREEDB_FORM_SHEET",
+        title_prefix:  title_prefix,
         title:         title,
         t:             t,
         before_close:  function() {
@@ -2382,15 +2422,8 @@ function form_may_close(gobj)
              *  a second key to define — and the one that was here had never
              *  been defined in any locale, which renders as the English
              *  sentence itself, in every language, for ever. */
-            yui_shell_confirm_yesnocancel(
-                yui_shell_of(gobj),
-                kw.warning || "all changes will be lost",
-                {t: t, yes_label: "yes", no_label: "no", cancel_label: "cancel"}
-            ).then(function(answer) {
-                if(answer === "yes" && priv.form_modal) {
-                    priv.form_modal.close();
-                }
-            });
+            confirm_then(gobj, kw.warning || "all changes will be lost",
+                {what: "close_form"});
             return false;
         }
     }
@@ -2416,6 +2449,33 @@ function teardown_form_child(gobj)
     priv.form_modal = null;
 }
 
+/************************************************************
+ *  Ask, and turn the answer into an EVENT.
+ *
+ *  A dialog's promise settles outside the machine: acting from its
+ *  `.then` puts the decision -- delete these records, throw these
+ *  edits away -- in a callback the `machine` trace never sees, and
+ *  in a view that may be gone by the time the person answers.
+ *
+ *  `kw` carries an IDENTITY and never an object: the trace dumps
+ *  it, and a gobj, a Tabulator row or a DOM node in there is a
+ *  circular structure that breaks the very trace the FSM feeds.
+ *
+ *  Same shape as C_YUI_SCHEMA_EDITOR's confirm_then().
+ ************************************************************/
+function confirm_then(gobj, message, kw)
+{
+    yui_shell_confirm_yesnocancel(
+        yui_shell_of(gobj), message,
+        {t: t, yes_label: "yes", no_label: "no", cancel_label: "cancel"}
+    ).then(function(answer) {
+        if(answer !== "yes" || gobj_is_destroying(gobj)) {
+            return;
+        }
+        gobj_send_event(gobj, "EV_CONFIRMED", kw, gobj);
+    });
+}
+
 /************************************************************
  *  Force the dialog down (bypasses the unsaved guard): used after a
  *  successful save and on teardown. Closing the modal runs its
@@ -3130,7 +3190,7 @@ function pkey_is_rowid(gobj)
  *  Show the edit "update" form of a row (record)
  *  internally called from the icon edit at Op column
  ************************************************************/
-function show_edit_form(gobj, row, index)
+function show_edit_form(gobj, row)
 {
     /*  a rowid pkey has no "update": every save appends a new
      *  instance (timeranger semantics) — open in create mode  */
@@ -3204,42 +3264,6 @@ function get_schema_col(gobj, id)
     return null;
 }
 
-/************************************************************
- *  Does column `col` travel back to treedb on a write?
- *
- *  The form SHOWS every field and sends back only what the topic
- *  accepts: the writable cols, the fkeys (a link is edited by
- *  linking) and the pkey, which is not written but is what
- *  ADDRESSES the record.
- *
- *  It matters because `treedb_update_node()` does not check
- *  `writable` -- it writes any col it is handed -- so a read-only
- *  field travelling back is written with whatever the form made of
- *  it, and the fields that describe a record are exactly the ones
- *  that do not survive a round trip through a widget: a `time` is an
- *  integer rendered as a `datetime-local`, with no seconds, so every
- *  save moved it back up to 59 s. Nothing looked wrong until the
- *  stored timestamp had moved.
- *
- *  `is_file` and not the type: a `file` column IS an fkey (it is
- *  flagged ['fkey','file']) but answers `type: "file"`, and the write
- *  goes out with `autolink`, which rebuilds the links from what the
- *  record carries. Dropped, a read-only `file` column -- the one only
- *  a load fills -- was UNLINKED by every save of any other field.
- ************************************************************/
-function col_goes_back_to_treedb(gobj, col)
-{
-    let desc = gobj_read_attr(gobj, "desc");
-    let pkey = desc.pkey || "id";
-    const field_desc = treedb_get_field_desc(col);
-
-    if(field_desc.is_writable || field_desc.type === "fkey" ||
-            field_desc.is_file || col.id === pkey) {
-        return true;
-    }
-    return false;
-}
-
 /************************************************************
  *  The record the FORM hands over, without the columns that do
  *  not go back to treedb (see col_goes_back_to_treedb()). The
@@ -3251,7 +3275,7 @@ function strip_read_only_cols(gobj, record)
     let row = {};
     for(let field_name of Object.keys(record || {})) {
         let col = get_schema_col(gobj, field_name);
-        if(col && !col_goes_back_to_treedb(gobj, col)) {
+        if(col && !col_goes_back_to_treedb(gobj_read_attr(gobj, "desc"), col)) {
             continue;
         }
         row[field_name] = record[field_name];
@@ -3278,7 +3302,7 @@ function transform__form_record_2_treedb_record(gobj, kw, operation)
             continue;
         }
 
-        if(!col_goes_back_to_treedb(gobj, col)) {
+        if(!col_goes_back_to_treedb(gobj_read_attr(gobj, "desc"), col)) {
             continue;
         }
 
@@ -3940,50 +3964,81 @@ function ac_delete_rows(gobj, event, kw, src)
             return 0;
         }
 
-        yui_shell_confirm_yesnocancel(
-            yui_shell_of(gobj), build_delete_question(gobj, rows),
-            {t: t, yes_label: "yes", no_label: "no", cancel_label: "cancel"}
-        ).then(function(answer) {
-            if(answer === "yes") {
-                for(let row of rows) {
-                    // TODO why don't send once EV_DELETE_RECORD(S)
-                    gobj_publish_event(
-                        gobj,
-                        "EV_DELETE_RECORD",
-                        {
-                            topic_name: gobj_read_str_attr(gobj, "topic_name"),
-                            record: row
-                        }
-                    );
-                }
-            }
-        });
+        confirm_then(gobj, build_delete_question(gobj, rows),
+            {what: "delete_selection"});
 
     } else {
         /*----------------------------*
          *  Delete one row
          *  {index: , row: }
          *----------------------------*/
-        yui_shell_confirm_yesnocancel(
-            yui_shell_of(gobj), build_delete_question(gobj, kw.row),
-            {t: t, yes_label: "yes", no_label: "no", cancel_label: "cancel"}
-        ).then(function(answer) {
-            if(answer === "yes") {
-                gobj_publish_event(
-                    gobj,
-                    "EV_DELETE_RECORD",
-                    {
-                        topic_name: gobj_read_str_attr(gobj, "topic_name"),
-                        record: kw.row
-                    }
-                );
-            }
-        });
+        confirm_then(gobj, build_delete_question(gobj, kw.row),
+            {what: "delete_row", index: kw.index});
     }
 
     return 0;
 }
 
+/************************************************************
+ *  {what, ...} -- the person said yes to what confirm_then()
+ *  asked. The rows are read again HERE and not carried in the
+ *  kw: the kw is plain json, and a Tabulator row is not.
+ ************************************************************/
+function ac_confirmed(gobj, event, kw, src)
+{
+    let priv = gobj.priv;
+    let what = kw? kw.what : "";
+
+    if(what === "close_form") {
+        if(priv.form_modal) {
+            priv.form_modal.close();
+        }
+        return 0;
+    }
+
+    if(refuse_if_readonly(gobj, event)) {
+        return -1;      /*  Error already logged  */
+    }
+    let tabulator = gobj_read_attr(gobj, "tabulator");
+    let topic_name = gobj_read_str_attr(gobj, "topic_name");
+
+    if(what === "delete_selection") {
+        let rows = yui_selected_rows(tabulator);
+        if(!rows.length) {
+            log_error(`${gobj_short_name(gobj)}: ${event} with the selection gone`);
+            return -1;
+        }
+        for(let row of rows) {
+            // TODO why don't send once EV_DELETE_RECORD(S)
+            gobj_publish_event(
+                gobj,
+                "EV_DELETE_RECORD",
+                {topic_name: topic_name, record: row}
+            );
+        }
+        return 0;
+    }
+
+    if(what === "delete_row") {
+        let index = kw.index;
+        let row = (tabulator && typeof index === "number")?
+            tabulator.getRowFromPosition(index) : null;
+        if(!row) {
+            log_error(`${gobj_short_name(gobj)}: ${event} names no row: ${index}`);
+            return -1;
+        }
+        gobj_publish_event(
+            gobj,
+            "EV_DELETE_RECORD",
+            {topic_name: topic_name, record: row.getData()}
+        );
+        return 0;
+    }
+
+    log_error(`${gobj_short_name(gobj)}: ${event} of nothing this view asked about: ${what}`);
+    return -1;
+}
+
 /************************************************************
  *  From internal
  ************************************************************/
@@ -4085,12 +4140,15 @@ function ac_form_save_record(gobj, event, kw, src)
     if(cols.length === 0) {
         publish_treedb_write(gobj, mode, kw);
 
-        /*  we are INSIDE the form's gobj_publish_event stack — never
-         *  destroy the publisher synchronously from a subscriber
-         *  callback: defer the close  */
-        setTimeout(function() {
-            close_form_dialog(gobj);
-        }, 0);
+        /*  We are INSIDE the form child's gobj_publish_event stack, and
+         *  closing the dialog tears that child down -- never destroy the
+         *  publisher synchronously from a subscriber's callback. So the
+         *  close is DEFERRED, and a deferral is not a time:
+         *  gobj_post_event() delivers EV_CLOSE_FORM to us on the next
+         *  turn of the loop, it drops it if we are being destroyed
+         *  meanwhile, and it says so in the `machine` trace. A bare
+         *  setTimeout(…, 0) did none of the three.  */
+        gobj_post_event(gobj, "EV_CLOSE_FORM", {}, gobj);
         return 0;
     }
 
@@ -4197,6 +4255,16 @@ function publish_treedb_write(gobj, mode, record, jn_files)
     );
 }
 
+/************************************************************
+ *  The deferred close of the form dialog, posted by the save
+ *  from inside the form child's own publish stack.
+ ************************************************************/
+function ac_close_form(gobj, event, kw, src)
+{
+    close_form_dialog(gobj);
+    return 0;
+}
+
 /************************************************************
  *  {mode, record, picks} -- the bytes are here now
  ************************************************************/
@@ -4260,7 +4328,7 @@ function ac_unselect_rows(gobj, event, kw, src)
 
     // WARNING with radio, there is no unselect event.
 
-    if(gobj_read_bool_attr(gobj, "broadcast_select_rows_event")) {
+    if(gobj_read_bool_attr(gobj, "broadcast_unselect_rows_event")) {
         gobj_publish_event(gobj, event, kw);
     }
 
@@ -4809,6 +4877,31 @@ function ac_show_record(gobj, event, kw, src)
     return 0;
 }
 
+/************************************************************
+ *  {index} -- the pencil of the Op column. Same shape as
+ *  EV_SHOW_RECORD: the kw carries WHICH row, and the row itself
+ *  is resolved here, where the table is.
+ ************************************************************/
+function ac_edit_record(gobj, event, kw, src)
+{
+    let tabulator = gobj_read_attr(gobj, "tabulator");
+    let index = kw? kw.index : undefined;
+    if(!tabulator || typeof index !== "number") {
+        log_error(`${gobj_short_name(gobj)}: no row ${index} to edit`);
+        return -1;
+    }
+
+    let row = tabulator.getRowFromPosition(index);
+    if(!row) {
+        log_error(`${gobj_short_name(gobj)}: row ${index} is gone`);
+        return -1;
+    }
+
+    show_edit_form(gobj, row.getData());
+
+    return 0;
+}
+
 /************************************************************
  *  The reader picked another page size: remember it, so coming back to
  *  this topic opens where they left it instead of at 200.
@@ -4948,11 +5041,13 @@ function create_gclass(gclass_name)
 
             ["EV_EDITION_MODE",         ac_edition_mode,       null],
             ["EV_SAVE_RECORD",          ac_form_save_record,   null],
+            ["EV_CLOSE_FORM",           ac_close_form,         null],
             ["EV_FILES_READ",           ac_files_read,         null],
             ["EV_FILES_FAILED",         ac_files_failed,       null],
 
             ["EV_NEW_ROW",              ac_new_row,            null],
             ["EV_DELETE_ROWS",          ac_delete_rows,        null],
+            ["EV_CONFIRMED",            ac_confirmed,          null],
             ["EV_SELECT_ROWS",          ac_select_rows,        null],
             ["EV_CLEAR_SELECTION",      ac_clear_selection,    null],
             ["EV_UNSELECT_ROWS",        ac_unselect_rows,      null],
@@ -4978,6 +5073,7 @@ function create_gclass(gclass_name)
             ["EV_OPEN_COLUMNS",         ac_open_columns,       null],
             ["EV_PAGE_SIZE_CHANGED",    ac_page_size_changed,  null],
             ["EV_SHOW_RECORD",          ac_show_record,        null],
+            ["EV_EDIT_RECORD",          ac_edit_record,        null],
             ["EV_TOGGLE_COLUMN",        ac_toggle_column,      null],
             ["EV_EXPORT_TABLE",         ac_export_table,       null],
             ["EV_SHOW",                 ac_show,               null],
@@ -4997,10 +5093,12 @@ function create_gclass(gclass_name)
 
         ["EV_EDITION_MODE",         0],
         ["EV_SAVE_RECORD",          0],
+        ["EV_CLOSE_FORM",           0],
         ["EV_FILES_READ",           0],
         ["EV_FILES_FAILED",         0],
         ["EV_NEW_ROW",              0],
         ["EV_DELETE_ROWS",          0],
+        ["EV_CONFIRMED",            0],
         ["EV_COPY_ROWS",            0],
         ["EV_PASTE_ROWS",           0],
         ["EV_CLEAR_SELECTION",      0],
@@ -5030,6 +5128,7 @@ function create_gclass(gclass_name)
         ["EV_OPEN_COLUMNS",         0],
         ["EV_PAGE_SIZE_CHANGED",    0],
         ["EV_SHOW_RECORD",          0],
+        ["EV_EDIT_RECORD",          0],
         ["EV_TOGGLE_COLUMN",        0],
         ["EV_EXPORT_TABLE",         0],
 

package/src/treedb_write_plan.js

@@ -19,6 +19,9 @@
  *          All Rights Reserved.
  ***********************************************************************/
 
+import {treedb_get_field_desc} from "@yuneta/gobj-js";
+import {topic_pkey2s} from "./schema_model.js";
+
 /*  What a read-only form keeps: reading a record includes taking it with
  *  you, so `copy` stays and the write half goes.  */
 const READONLY_FORM_TOOLBAR = ["copy"];
@@ -70,4 +73,47 @@ function plan_treedb_writes(flags)
 }
 
 
-export {plan_treedb_writes, READONLY_FORM_TOOLBAR};
+/************************************************************
+ *  Does column `col` travel back to treedb on a write?
+ *
+ *  The form SHOWS every field and sends back only what the topic
+ *  accepts: the writable cols, the fkeys (a link is edited by
+ *  linking) and the pkey, which is not written but is what
+ *  ADDRESSES the record.
+ *
+ *  It matters because `treedb_update_node()` does not check
+ *  `writable` -- it writes any col it is handed -- so a read-only
+ *  field travelling back is written with whatever the form made of
+ *  it, and the fields that describe a record are exactly the ones
+ *  that do not survive a round trip through a widget: a `time` is an
+ *  integer rendered as a `datetime-local`, with no seconds, so every
+ *  save moved it back up to 59 s. Nothing looked wrong until the
+ *  stored timestamp had moved.
+ *
+ *  `is_file` and not the type: a `file` column IS an fkey (it is
+ *  flagged ['fkey','file']) but answers `type: "file"`, and the write
+ *  goes out with `autolink`, which rebuilds the links from what the
+ *  record carries. Dropped, a read-only `file` column -- the one only
+ *  a load fills -- was UNLINKED by every save of any other field.
+ *
+ *  The pkey2s go back for the same reason as the pkey: a secondary key
+ *  names the INSTANCE the update is for (`yunos.yuno_release` in the
+ *  agent), and it is `persistent, required`, not `writable`. Dropped,
+ *  the update reached the backend with no pkey2 and C_NODE resolved it
+ *  to the PRIMARY instance -- right by chance while the table lists
+ *  primaries, wrong from a form opened on a row of `instances`.
+ ************************************************************/
+function col_goes_back_to_treedb(desc, col)
+{
+    let d = desc || {};
+    let pkey = d.pkey || "id";
+    const field_desc = treedb_get_field_desc(col);
+
+    if(field_desc.is_writable || field_desc.type === "fkey" ||
+            field_desc.is_file || col.id === pkey) {
+        return true;
+    }
+    return topic_pkey2s(d).includes(col.id);
+}
+
+export {plan_treedb_writes, READONLY_FORM_TOOLBAR, col_goes_back_to_treedb};

package/src/treedb_write_plan.test.js

@@ -8,7 +8,9 @@
  *      affordance back by accident.
  ***********************************************************************/
 import { describe, test, expect } from "vitest";
-import { plan_treedb_writes, READONLY_FORM_TOOLBAR } from "./treedb_write_plan.js";
+import {
+    plan_treedb_writes, READONLY_FORM_TOOLBAR, col_goes_back_to_treedb
+} from "./treedb_write_plan.js";
 
 const WRITES = ["edition_mode", "new_button", "delete_button", "paste_button", "in_row_icons"];
 
@@ -81,3 +83,53 @@ describe("readonly beats every with_*", () => {
         expect(plan_treedb_writes({readonly: "yes"}).new_button).toBe(false);
     });
 });
+
+
+/***********************************************************************
+ *  Which columns of a form go back in the write. The shape is the
+ *  agent's `yunos`: a pkey, a secondary key that is required but not
+ *  writable, and the read-only columns that never survive a widget.
+ ***********************************************************************/
+const YUNOS_DESC = {
+    pkey: "id",
+    pkey2s: ["yuno_release"],
+};
+const COL = {
+    id:           {id: "id",           type: "string",  flag: ["persistent", "required", "rowid"]},
+    yuno_release: {id: "yuno_release", type: "string",  flag: ["persistent", "required"]},
+    yuno_name:    {id: "yuno_name",    type: "string",  flag: ["persistent", "writable"]},
+    date:         {id: "date",         type: "integer", flag: ["persistent", "time"]},
+    realm_id:     {id: "realm_id",     type: "string",  flag: ["persistent", "fkey"]},
+    photo:        {id: "photo",        type: "string",  flag: ["persistent", "fkey", "file"]},
+    yunos:        {id: "yunos",        type: "object",  flag: ["hook"], hook: {yunos: "realm_id"}},
+};
+
+describe("what goes back to treedb from a form", () => {
+    test("a writable column, an fkey and a file column go back", () => {
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.yuno_name)).toBe(true);
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.realm_id)).toBe(true);
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.photo)).toBe(true);
+    });
+
+    test("a read-only time and a hook stay: they do not survive the widget", () => {
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.date)).toBe(false);
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.yunos)).toBe(false);
+    });
+
+    test("the pkey goes back although it is not writable: it addresses the record", () => {
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.id)).toBe(true);
+    });
+
+    test("a pkey2 goes back although it is not writable: it names the INSTANCE", () => {
+        expect(col_goes_back_to_treedb(YUNOS_DESC, COL.yuno_release)).toBe(true);
+    });
+
+    test("a pkey2s declared as a bare string (the C literal) counts the same", () => {
+        expect(col_goes_back_to_treedb({pkey: "id", pkey2s: "yuno_release"}, COL.yuno_release)).toBe(true);
+    });
+
+    test("without pkey2s in the desc the same column stays read-only", () => {
+        expect(col_goes_back_to_treedb({pkey: "id"}, COL.yuno_release)).toBe(false);
+        expect(col_goes_back_to_treedb(null, COL.yuno_release)).toBe(false);
+    });
+});