@yuneta/gobj-ui 7.14.1 → 7.14.3

package/dist/gobj-ui.cjs.js

@@ -884,7 +884,7 @@ function mt_start$16(gobj) {
 				"C_YUI_SHELL: invalid config — see browser console for details"
 			]
 		]));
-		return;
+		return -1;
 	}
 	let shell_cfg = config.shell || {};
 	if (typeof shell_cfg.remember_section_position === "boolean") (0, _yuneta_gobj_js.gobj_write_attr)(gobj, "remember_section_position", shell_cfg.remember_section_position);
@@ -941,7 +941,7 @@ function mt_start$16(gobj) {
 ***************************************************************/
 function mt_stop$16(gobj) {
 	let priv = gobj.priv;
-	if (!priv) return;
+	if (!priv) return 0;
 	close_toolbar_dropdown(gobj);
 	if (priv.hash_handler) {
 		window.removeEventListener("hashchange", priv.hash_handler);
@@ -15656,7 +15656,7 @@ function ac_mt_command_answer$2(gobj, event, kw, src) {
 		data = webix_msg.data;
 	} catch (e) {
 		(0, _yuneta_gobj_js.log_error)(e);
-		return;
+		return -1;
 	}
 	let __command__ = (0, _yuneta_gobj_js.msg_iev_get_stack)(gobj, kw, "command_stack", true);
 	let command = (0, _yuneta_gobj_js.kw_get_str)(gobj, __command__, "command", "", _yuneta_gobj_js.kw_flag_t.KW_REQUIRED);
@@ -17139,6 +17139,30 @@ function build_ui$5(gobj) {
 	(0, _yuneta_gobj_js.refresh_language)($container, i18next.t);
 }
 /************************************************************
+*   What the SELECTION drives: the two toolbar buttons that act
+*   on it, and the bar that counts it.
+*
+*   Read from the table every time, never from a running tally:
+*   rows leave the selection by routes that do not announce it
+*   (deleting a selected row deselects it SILENTLY, see
+*   ac_node_deleted).
+************************************************************/
+function render_selection_state(gobj) {
+	let $container = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "$container");
+	let $delete = $container ? $container.querySelector(`.button-delete-record`) : null;
+	let $copy = $container ? $container.querySelector(`.button-copy-record`) : null;
+	if ($delete && $copy) {
+		if (yui_selected_rows((0, _yuneta_gobj_js.gobj_read_attr)(gobj, "tabulator")).length > 0 && (0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "editable")) {
+			$delete.removeAttribute("disabled");
+			$copy.removeAttribute("disabled");
+		} else {
+			$delete.setAttribute("disabled", true);
+			$copy.setAttribute("disabled", true);
+		}
+	}
+	render_selection_bar(gobj);
+}
+/************************************************************
 *   How many rows are ticked, on the bar.
 *
 *   Only while the table is EDITABLE: outside edition its checkbox
@@ -18418,6 +18442,7 @@ function ac_node_deleted$1(gobj, event, kw, src) {
 	let tabulator = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "tabulator");
 	if (tabulator) for (let record of data) if (tabulator.getRow(record.id)) tabulator.deleteRow(record.id);
 	else (0, _yuneta_gobj_js.log_error)("delete_data: record not found: " + record.id);
+	render_selection_state(gobj);
 	return 0;
 }
 /************************************************************
@@ -18594,20 +18619,7 @@ function ac_form_save_record(gobj, event, kw, src) {
 *  { rows: [row] }
 ************************************************************/
 function ac_select_rows(gobj, event, kw, src) {
-	let tabulator = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "tabulator");
-	let $container = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "$container");
-	let $button_delete_record = $container.querySelector(`.button-delete-record`);
-	let $button_copy_record = $container.querySelector(`.button-copy-record`);
-	if ($button_delete_record) {
-		if (yui_selected_rows(tabulator).length && (0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "editable")) {
-			$button_delete_record.removeAttribute("disabled");
-			$button_copy_record.removeAttribute("disabled");
-		} else {
-			$button_delete_record.setAttribute("disabled", true);
-			$button_copy_record.setAttribute("disabled", true);
-		}
-	}
-	render_selection_bar(gobj);
+	render_selection_state(gobj);
 	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "broadcast_select_rows_event")) (0, _yuneta_gobj_js.gobj_publish_event)(gobj, event, kw);
 	return 0;
 }
@@ -18615,20 +18627,7 @@ function ac_select_rows(gobj, event, kw, src) {
 *  { rows: [row] }
 ************************************************************/
 function ac_unselect_rows(gobj, event, kw, src) {
-	let tabulator = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "tabulator");
-	let $container = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "$container");
-	let $button_delete_record = $container.querySelector(`.button-delete-record`);
-	let $button_copy_record = $container.querySelector(`.button-copy-record`);
-	if ($button_delete_record) {
-		if (yui_selected_rows(tabulator).length && (0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "editable")) {
-			$button_delete_record.removeAttribute("disabled");
-			$button_copy_record.removeAttribute("disabled");
-		} else {
-			$button_delete_record.setAttribute("disabled", true);
-			$button_copy_record.setAttribute("disabled", true);
-		}
-	}
-	render_selection_bar(gobj);
+	render_selection_state(gobj);
 	if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "broadcast_select_rows_event")) (0, _yuneta_gobj_js.gobj_publish_event)(gobj, event, kw);
 	return 0;
 }
@@ -20325,7 +20324,7 @@ function ac_mt_command_answer$1(gobj, event, kw, src) {
 		data = kw.data;
 	} catch (e) {
 		(0, _yuneta_gobj_js.log_error)(e);
-		return;
+		return -1;
 	}
 	let __command__ = (0, _yuneta_gobj_js.msg_iev_get_stack)(gobj, kw, "command_stack", true);
 	let command = (0, _yuneta_gobj_js.kw_get_str)(gobj, __command__, "command", "", _yuneta_gobj_js.kw_flag_t.KW_REQUIRED);

package/dist/gobj-ui.es.js

@@ -879,7 +879,7 @@ function mt_start$16(gobj) {
 				"C_YUI_SHELL: invalid config — see browser console for details"
 			]
 		]));
-		return;
+		return -1;
 	}
 	let shell_cfg = config.shell || {};
 	if (typeof shell_cfg.remember_section_position === "boolean") gobj_write_attr(gobj, "remember_section_position", shell_cfg.remember_section_position);
@@ -936,7 +936,7 @@ function mt_start$16(gobj) {
 ***************************************************************/
 function mt_stop$16(gobj) {
 	let priv = gobj.priv;
-	if (!priv) return;
+	if (!priv) return 0;
 	close_toolbar_dropdown(gobj);
 	if (priv.hash_handler) {
 		window.removeEventListener("hashchange", priv.hash_handler);
@@ -15651,7 +15651,7 @@ function ac_mt_command_answer$2(gobj, event, kw, src) {
 		data = webix_msg.data;
 	} catch (e) {
 		log_error(e);
-		return;
+		return -1;
 	}
 	let __command__ = msg_iev_get_stack(gobj, kw, "command_stack", true);
 	let command = kw_get_str(gobj, __command__, "command", "", kw_flag_t.KW_REQUIRED);
@@ -17134,6 +17134,30 @@ function build_ui$5(gobj) {
 	refresh_language($container, t);
 }
 /************************************************************
+*   What the SELECTION drives: the two toolbar buttons that act
+*   on it, and the bar that counts it.
+*
+*   Read from the table every time, never from a running tally:
+*   rows leave the selection by routes that do not announce it
+*   (deleting a selected row deselects it SILENTLY, see
+*   ac_node_deleted).
+************************************************************/
+function render_selection_state(gobj) {
+	let $container = gobj_read_attr(gobj, "$container");
+	let $delete = $container ? $container.querySelector(`.button-delete-record`) : null;
+	let $copy = $container ? $container.querySelector(`.button-copy-record`) : null;
+	if ($delete && $copy) {
+		if (yui_selected_rows(gobj_read_attr(gobj, "tabulator")).length > 0 && gobj_read_bool_attr(gobj, "editable")) {
+			$delete.removeAttribute("disabled");
+			$copy.removeAttribute("disabled");
+		} else {
+			$delete.setAttribute("disabled", true);
+			$copy.setAttribute("disabled", true);
+		}
+	}
+	render_selection_bar(gobj);
+}
+/************************************************************
 *   How many rows are ticked, on the bar.
 *
 *   Only while the table is EDITABLE: outside edition its checkbox
@@ -18413,6 +18437,7 @@ function ac_node_deleted$1(gobj, event, kw, src) {
 	let tabulator = gobj_read_attr(gobj, "tabulator");
 	if (tabulator) for (let record of data) if (tabulator.getRow(record.id)) tabulator.deleteRow(record.id);
 	else log_error("delete_data: record not found: " + record.id);
+	render_selection_state(gobj);
 	return 0;
 }
 /************************************************************
@@ -18589,20 +18614,7 @@ function ac_form_save_record(gobj, event, kw, src) {
 *  { rows: [row] }
 ************************************************************/
 function ac_select_rows(gobj, event, kw, src) {
-	let tabulator = gobj_read_attr(gobj, "tabulator");
-	let $container = gobj_read_attr(gobj, "$container");
-	let $button_delete_record = $container.querySelector(`.button-delete-record`);
-	let $button_copy_record = $container.querySelector(`.button-copy-record`);
-	if ($button_delete_record) {
-		if (yui_selected_rows(tabulator).length && gobj_read_bool_attr(gobj, "editable")) {
-			$button_delete_record.removeAttribute("disabled");
-			$button_copy_record.removeAttribute("disabled");
-		} else {
-			$button_delete_record.setAttribute("disabled", true);
-			$button_copy_record.setAttribute("disabled", true);
-		}
-	}
-	render_selection_bar(gobj);
+	render_selection_state(gobj);
 	if (gobj_read_bool_attr(gobj, "broadcast_select_rows_event")) gobj_publish_event(gobj, event, kw);
 	return 0;
 }
@@ -18610,20 +18622,7 @@ function ac_select_rows(gobj, event, kw, src) {
 *  { rows: [row] }
 ************************************************************/
 function ac_unselect_rows(gobj, event, kw, src) {
-	let tabulator = gobj_read_attr(gobj, "tabulator");
-	let $container = gobj_read_attr(gobj, "$container");
-	let $button_delete_record = $container.querySelector(`.button-delete-record`);
-	let $button_copy_record = $container.querySelector(`.button-copy-record`);
-	if ($button_delete_record) {
-		if (yui_selected_rows(tabulator).length && gobj_read_bool_attr(gobj, "editable")) {
-			$button_delete_record.removeAttribute("disabled");
-			$button_copy_record.removeAttribute("disabled");
-		} else {
-			$button_delete_record.setAttribute("disabled", true);
-			$button_copy_record.setAttribute("disabled", true);
-		}
-	}
-	render_selection_bar(gobj);
+	render_selection_state(gobj);
 	if (gobj_read_bool_attr(gobj, "broadcast_select_rows_event")) gobj_publish_event(gobj, event, kw);
 	return 0;
 }
@@ -20312,7 +20311,7 @@ function ac_mt_command_answer$1(gobj, event, kw, src) {
 		data = kw.data;
 	} catch (e) {
 		log_error(e);
-		return;
+		return -1;
 	}
 	let __command__ = msg_iev_get_stack(gobj, kw, "command_stack", true);
 	let command = kw_get_str(gobj, __command__, "command", "", kw_flag_t.KW_REQUIRED);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yuneta/gobj-ui",
-  "version": "7.14.1",
+  "version": "7.14.3",
   "type": "module",
   "main": "dist/gobj-ui.cjs.js",
   "module": "dist/gobj-ui.es.js",

package/src/c_yui_node.js

@@ -275,7 +275,7 @@ function mt_start(gobj)
     }
 
     if(!priv.is_root) {
-        return;
+        return 0;
     }
 
     /*
@@ -287,7 +287,7 @@ function mt_start(gobj)
     let shell = yui_shell_of(gobj);
     if(!shell) {
         log_error(`${GCLASS_NAME}: no shell — the tree cannot route`);
-        return;
+        return -1;
     }
     gobj_subscribe_event(shell, "EV_ROUTE_CHANGED", {}, gobj);
     publish_sub_routes(gobj);

package/src/c_yui_shell.js

@@ -226,7 +226,7 @@ function mt_start(gobj)
                 ]
             ));
         }
-        return;
+        return -1;
     }
 
     /*  Declarative sugar over the attr, which stays the runtime truth:
@@ -364,7 +364,7 @@ function mt_stop(gobj)
 {
     let priv = gobj.priv;
     if(!priv) {
-        return;
+        return 0;
     }
 
     /*  Tear down any toolbar dropdown that was open at stop time so its

package/src/c_yui_treedb_graph.js

@@ -1495,7 +1495,7 @@ function ac_mt_command_answer(gobj, event, kw, src)
         data = kw.data;
     } catch (e) {
         log_error(e);
-        return;
+        return -1;
     }
     let __command__ = msg_iev_get_stack(gobj, kw, "command_stack", true);
     let command = kw_get_str(gobj, __command__, "command", "", kw_flag_t.KW_REQUIRED);

package/src/c_yui_treedb_topic_with_form.js

@@ -679,6 +679,35 @@ function build_ui(gobj)
     refresh_language($container, t);
 }
 
+/************************************************************
+ *   What the SELECTION drives: the two toolbar buttons that act
+ *   on it, and the bar that counts it.
+ *
+ *   Read from the table every time, never from a running tally:
+ *   rows leave the selection by routes that do not announce it
+ *   (deleting a selected row deselects it SILENTLY, see
+ *   ac_node_deleted).
+ ************************************************************/
+function render_selection_state(gobj)
+{
+    let $container = gobj_read_attr(gobj, "$container");
+    let $delete = $container ? $container.querySelector(`.button-delete-record`) : null;
+    let $copy = $container ? $container.querySelector(`.button-copy-record`) : null;
+
+    if($delete && $copy) {
+        let some = yui_selected_rows(gobj_read_attr(gobj, "tabulator")).length > 0;
+        if(some && gobj_read_bool_attr(gobj, "editable")) {
+            $delete.removeAttribute("disabled");
+            $copy.removeAttribute("disabled");
+        } else {
+            $delete.setAttribute("disabled", true);
+            $copy.setAttribute("disabled", true);
+        }
+    }
+
+    render_selection_bar(gobj);
+}
+
 /************************************************************
  *   How many rows are ticked, on the bar.
  *
@@ -2625,7 +2654,6 @@ function ac_node_deleted(gobj, event, kw, src)
     }
 
     let tabulator = gobj_read_attr(gobj, "tabulator");
-    //tabulator.deselectRow(); // unselectAll TODO ??? is necessary?
 
     if(tabulator) {
         for(let record of data) {
@@ -2639,6 +2667,18 @@ function ac_node_deleted(gobj, event, kw, src)
         }
     }
 
+    /*  There WAS a commented-out `deselectRow()` here, asking whether it was
+     *  needed. It is not: Tabulator's own SelectRow module subscribes to
+     *  `row-deleting` and deselects the row it is about to remove, so a
+     *  deleted row cannot stay in the selection.
+     *
+     *  What IS needed is this line. That deselect is SILENT
+     *  (`_deselectRow(row, true)`), so no `rowDeselected` arrives, no
+     *  EV_UNSELECT_ROWS is sent, and everything the selection drives would
+     *  keep describing rows that are gone: the bar saying "3 selected" over a
+     *  table with none, and Delete and Copy still enabled.  */
+    render_selection_state(gobj);
+
     return 0;
 }
 
@@ -2928,26 +2968,7 @@ function ac_form_save_record(gobj, event, kw, src)
  ************************************************************/
 function ac_select_rows(gobj, event, kw, src)
 {
-    let tabulator = gobj_read_attr(gobj, "tabulator");
-    let $container = gobj_read_attr(gobj, "$container");
-
-    /*
-     *  Update button DELETE, only enable if some row is selected
-     */
-    let $button_delete_record = $container.querySelector(`.button-delete-record`);
-    let $button_copy_record = $container.querySelector(`.button-copy-record`);
-    if($button_delete_record) {
-        let selectedRows = yui_selected_rows(tabulator);
-        if (selectedRows.length && gobj_read_bool_attr(gobj, "editable")) {
-            $button_delete_record.removeAttribute("disabled");
-            $button_copy_record.removeAttribute("disabled");
-        } else {
-            $button_delete_record.setAttribute("disabled", true);
-            $button_copy_record.setAttribute("disabled", true);
-        }
-    }
-
-    render_selection_bar(gobj);
+    render_selection_state(gobj);
 
     if(gobj_read_bool_attr(gobj, "broadcast_select_rows_event")) {
         gobj_publish_event(gobj, event, kw);
@@ -2961,26 +2982,7 @@ function ac_select_rows(gobj, event, kw, src)
  ************************************************************/
 function ac_unselect_rows(gobj, event, kw, src)
 {
-    let tabulator = gobj_read_attr(gobj, "tabulator");
-    let $container = gobj_read_attr(gobj, "$container");
-
-    /*
-     *  Update button DELETE, only enable if some row is selected
-     */
-    let $button_delete_record = $container.querySelector(`.button-delete-record`);
-    let $button_copy_record = $container.querySelector(`.button-copy-record`);
-    if($button_delete_record) {
-        let selectedRows = yui_selected_rows(tabulator);
-        if (selectedRows.length && gobj_read_bool_attr(gobj, "editable")) {
-            $button_delete_record.removeAttribute("disabled");
-            $button_copy_record.removeAttribute("disabled");
-        } else {
-            $button_delete_record.setAttribute("disabled", true);
-            $button_copy_record.setAttribute("disabled", true);
-        }
-    }
-
-    render_selection_bar(gobj);
+    render_selection_state(gobj);
 
     // WARNING with radio, there is no unselect event.
 

package/src/c_yui_treedb_topics.js

@@ -1721,7 +1721,7 @@ function ac_mt_command_answer(gobj, event, kw, src)
         data = webix_msg.data;
     } catch (e) {
         log_error(e);
-        return;
+        return -1;
     }
     let __command__  = msg_iev_get_stack(gobj, kw, "command_stack", true);
     let command = kw_get_str(gobj, __command__, "command", "", kw_flag_t.KW_REQUIRED);