@yuneta/gobj-ui 7.10.2 → 7.10.4

package/README.md

@@ -526,6 +526,45 @@ because the link can stay up and an answer still never land. A refresh
 re-pulls the page the reader is on rather than throwing them back to the
 first.
 
+### What a delete takes with it
+
+A treedb delete is not one thing, and these views delete with **`force`**.
+`force` on a node does not only remove it: its children are **UNLINKED** —
+they survive, loose — and it is cleaned off its parents. So "delete this row"
+can mean "detach eleven records from their only parent", and the question that
+used to be asked, `are you sure`, said none of it.
+
+The confirmation names what is going (the record's key, or how many) and adds
+a line per thing at stake, **each only when there is something at stake** — a
+loose record must not be dressed up as a dangerous one:
+
+- *N children will be UNLINKED, not deleted*
+- *It will be detached from M parents*
+
+Counted off the record the table already has (`list_dict` fills the hook and
+fkey columns), so asking costs no round trip. The counting is
+`delete_impact.js`, pure and tested, because the shapes are the fiddly part: a
+hook or fkey value arrives as a list of refs, a dict keyed by id, or a single
+ref string — and a column can be BOTH hook and fkey, which counts on both
+sides, because the delete does both things.
+
+In the graph the node-delete popover carries the same two lines, and the
+**unlink** popover carries the reassurance that is its whole point: *neither
+record is deleted*. Next to a delete button painted the same red, that is not
+obvious.
+
+Three things this cost, worth knowing before composing any message from keys:
+
+- `yui_shell_confirm_*` renders its message **as an i18n key**, so a composed
+  sentence can never be one. Pass DOM instead — the helper takes it.
+- `createElement2` **trims text nodes**, so a `["span", {}, " "]` separator
+  vanishes and the question reads "BorrarDeveloper". Space with CSS.
+- a **counted** word carries no `i18n` attribute: `yui_shell_show_modal` calls
+  `refresh_language()` on the dialog's content, which re-translates from the
+  key alone — without the count — and puts the plural back over the singular.
+  Nothing is lost, because a dialog with a backdrop never sees a language
+  change.
+
 ### Editing a topic table in place
 
 A writable scalar is editable in the table, in edition mode

package/dist/gobj-ui.cjs.js

@@ -8873,11 +8873,9 @@ function ac_map_on_load(gobj, event, kw, src) {
 function ac_refresh$6(gobj, event, kw, src) {
 	let priv = gobj.priv;
 	let devices = (0, _yuneta_gobj_js.gobj_read_attr)(gobj, "devices");
-	let map = priv.xmap;
-	if (map.isStyleLoaded()) {
-		const geojson_data = devices2geojson(gobj, devices);
-		map.getSource("devices").setData(geojson_data);
-	}
+	const source = priv.xmap.getSource("devices");
+	if (!source) return 0;
+	source.setData(devices2geojson(gobj, devices));
 	return 0;
 }
 /************************************************************
@@ -18539,7 +18537,7 @@ function build_delete_question(gobj, records) {
 			String(impact.children)
 		], [
 			"span",
-			{ i18n: "children will be unlinked, not deleted" },
+			{},
 			(0, i18next.t)("children will be unlinked, not deleted", { count: impact.children })
 		]]
 	]);
@@ -18562,7 +18560,7 @@ function build_delete_question(gobj, records) {
 			],
 			[
 				"span",
-				{ i18n: "parents" },
+				{},
 				(0, i18next.t)("parents", { count: impact.parents })
 			]
 		]

package/dist/gobj-ui.es.js

@@ -8868,11 +8868,9 @@ function ac_map_on_load(gobj, event, kw, src) {
 function ac_refresh$6(gobj, event, kw, src) {
 	let priv = gobj.priv;
 	let devices = gobj_read_attr(gobj, "devices");
-	let map = priv.xmap;
-	if (map.isStyleLoaded()) {
-		const geojson_data = devices2geojson(gobj, devices);
-		map.getSource("devices").setData(geojson_data);
-	}
+	const source = priv.xmap.getSource("devices");
+	if (!source) return 0;
+	source.setData(devices2geojson(gobj, devices));
 	return 0;
 }
 /************************************************************
@@ -18534,7 +18532,7 @@ function build_delete_question(gobj, records) {
 			String(impact.children)
 		], [
 			"span",
-			{ i18n: "children will be unlinked, not deleted" },
+			{},
 			t("children will be unlinked, not deleted", { count: impact.children })
 		]]
 	]);
@@ -18557,7 +18555,7 @@ function build_delete_question(gobj, records) {
 			],
 			[
 				"span",
-				{ i18n: "parents" },
+				{},
 				t("parents", { count: impact.parents })
 			]
 		]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yuneta/gobj-ui",
-  "version": "7.10.2",
+  "version": "7.10.4",
   "type": "module",
   "main": "dist/gobj-ui.cjs.js",
   "module": "dist/gobj-ui.es.js",

package/src/c_yui_map.js

@@ -782,10 +782,24 @@ function ac_refresh(gobj, event, kw, src)
     let devices = gobj_read_attr(gobj, "devices");
 
     let map = priv.xmap;
-    if (map.isStyleLoaded()) {
-        const geojson_data = devices2geojson(gobj, devices);
-        map.getSource('devices').setData(geojson_data);
+
+    /*
+     *  Ask for the source, do not infer it from the style. 'devices' is added
+     *  by load_devices() on the map 'load' event, which is a LATER milestone:
+     *  isStyleLoaded() is already true one render frame before 'load' fires,
+     *  and getSource() is undefined in that frame. Nothing is lost by
+     *  skipping, load_devices() reads the same attr.
+     *
+     *  Testing the style was also wrong the other way: it goes back to false
+     *  while new tiles load, so every refresh during a pan or a zoom was
+     *  silently dropped and the devices stopped moving.
+     */
+    const source = map.getSource('devices');
+    if(!source) {
+        return 0;
     }
+
+    source.setData(devices2geojson(gobj, devices));
     return 0;
 }
 

package/src/c_yui_treedb_topic_with_form.js

@@ -3071,11 +3071,16 @@ function build_delete_question(gobj, records)
                           style: ROW}, [
             ["strong", {}, String(impact.children)],
             /*  `count` picks the singular: i18next looks for the `_one`
-             *  variant and falls back to the base key for the plural, so
-             *  the validator still sees a key it can find. Safe against a
-             *  language switch because this is a MODAL — a dialog with a
-             *  backdrop never sees one; the language button is behind it. */
-            ["span", {i18n: "children will be unlinked, not deleted"},
+             *  variant and falls back to the base key for the plural, so the
+             *  validator still sees a key it can find.
+             *
+             *  And NO `i18n` attribute on a counted word: refresh_language()
+             *  re-translates whatever carries one, calling t() WITHOUT the
+             *  count — which put the plural straight back over the singular.
+             *  A counted word cannot be re-translated from its key alone.
+             *  Nothing is lost: this is a MODAL, and a dialog with a backdrop
+             *  never sees a language change — the button is behind it. */
+            ["span", {},
                 t("children will be unlinked, not deleted", {count: impact.children})]
         ]]);
     }
@@ -3083,7 +3088,7 @@ function build_delete_question(gobj, records)
         lines.push(["p", {class: "DELETE_ASK_PARENTS", style: ROW}, [
             ["span", {i18n: "it will be detached from"}, t("it will be detached from")],
             ["strong", {}, String(impact.parents)],
-            ["span", {i18n: "parents"}, t("parents", {count: impact.parents})]
+            ["span", {}, t("parents", {count: impact.parents})]
         ]]);
     }