@yuneta/gobj-ui 6.1.1 → 6.1.2

package/README.md

@@ -539,12 +539,15 @@ schema, so the drawing can be held against the ASCII one in its `.c`.
 - Events: `EV_SHOW`, `EV_REBUILD`, `EV_THEME` (restyle — it repaints the G6
   graph in place, preserving the user's zoom/pan), plus `EV_NODE_CLICK`, which
   a node click sends into the FSM. **With a `node_route` the click IS a
-  navigation** and this view makes it; **without one the click is published**
-  (`{topic}`) for whoever mounted the view — a host that draws the same picture
-  inside its own screens opens the topic in place, with no hash involved. A
-  host that subscribes must declare `EV_NODE_CLICK` in its own FSM, as with
-  every event a child publishes. Since 6.1.0; before that a click with no route
-  was dropped.
+  navigation** and this view makes it. **Without one the click is dropped,
+  unless the host asked for it with `with_node_click`** — then it is published
+  as `{topic}`, for a host that draws the same picture inside its own screens
+  and opens the topic in place, with no hash involved. That host must declare
+  `EV_NODE_CLICK` in its own FSM, as with every event a child publishes, which
+  is exactly why it is opt-in: the CHILD subscription model subscribes a host
+  to ALL of this view's events, so publishing one unasked turns a click into
+  "Event NOT DEFINED in state" underneath a host that never wanted it. Since
+  6.1.2 (6.1.0 and 6.1.1 published it unconditionally).
 
 Barrel-exported and public from 4.0.0. Renders with `@antv/g6`; the cards are
 HTML nodes carrying their own inline colours, so a theme switch repaints them in

package/dist/gobj-ui.cjs.js

@@ -19831,6 +19831,7 @@ var attrs_table$3 = [
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_POINTER, "subscriber", 0, null, "Subscriber of output events"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_JSON, "descs", 0, null, "Treedb schema: {topic_name: desc}"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_STRING, "node_route", 0, "", "Hash-route template with a {topic} placeholder: a node click opens that topic (e.g. '#/topics/db/<sel>/{topic}')"),
+	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_BOOLEAN, "with_node_click", 0, false, "With no `node_route`, PUBLISH a node click as EV_NODE_CLICK instead of dropping it. Opt-in, because a subscriber has to DECLARE the event: the hosts that route by hash, and the ones that want nothing, must not have it appear underneath them"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_BOOLEAN, "system", 0, false, "Include system topics (__*__) too"),
 	(0, _yuneta_gobj_js.SDATA)(_yuneta_gobj_js.data_type_t.DTP_POINTER, "$container", 0, null, "Root HTML element"),
 	(0, _yuneta_gobj_js.SDATA_END)()
@@ -20235,19 +20236,26 @@ function destroy_graph(gobj) {
 *   With a `node_route` the click IS a navigation and this view
 *   makes it: that is what the route was handed down for.
 *
-*   Without one it is still an action, and it belongs to whoever
-*   mounted this view — the schema editor draws the same picture
-*   inside its own screens, where a topic opens in place and no
-*   hash is involved. So the click is published rather than
-*   dropped. A host that subscribes must DECLARE EV_NODE_CLICK in
-*   its own FSM, as with every event a child publishes.
+*   Without one it is still an action, and it can belong to
+*   whoever mounted this view — the schema editor draws the same
+*   picture inside its own screens, where a topic opens in place
+*   and no hash is involved. That host asks for it with
+*   `with_node_click` and DECLARES EV_NODE_CLICK in its own FSM,
+*   as with every event a child publishes.
+*
+*   It is opt-in and not the default for exactly that reason: the
+*   CHILD subscription model subscribes the host to ALL of this
+*   view's events, so publishing one unasked turns a click into
+*   "Event NOT DEFINED in state" in every host that never wanted
+*   it — the topics view that mounts this as its schema landing,
+*   and the offline demo that mounts it against a json file.
 ************************************************************/
 function ac_node_click$2(gobj, event, kw, src) {
 	let topic = kw && kw.node_id;
 	let route = (0, _yuneta_gobj_js.gobj_read_str_attr)(gobj, "node_route");
 	if (!topic) return 0;
 	if (!route) {
-		(0, _yuneta_gobj_js.gobj_publish_event)(gobj, "EV_NODE_CLICK", { topic });
+		if ((0, _yuneta_gobj_js.gobj_read_bool_attr)(gobj, "with_node_click")) (0, _yuneta_gobj_js.gobj_publish_event)(gobj, "EV_NODE_CLICK", { topic });
 		return 0;
 	}
 	let href = route.replace("{topic}", topic);
@@ -23415,6 +23423,7 @@ function render_diagram(gobj) {
 		subscriber: gobj,
 		descs,
 		node_route: "",
+		with_node_click: true,
 		system: true
 	}, gobj);
 	if (!diagram) {

package/dist/gobj-ui.es.js

@@ -19818,6 +19818,7 @@ var attrs_table$3 = [
 	SDATA(data_type_t.DTP_POINTER, "subscriber", 0, null, "Subscriber of output events"),
 	SDATA(data_type_t.DTP_JSON, "descs", 0, null, "Treedb schema: {topic_name: desc}"),
 	SDATA(data_type_t.DTP_STRING, "node_route", 0, "", "Hash-route template with a {topic} placeholder: a node click opens that topic (e.g. '#/topics/db/<sel>/{topic}')"),
+	SDATA(data_type_t.DTP_BOOLEAN, "with_node_click", 0, false, "With no `node_route`, PUBLISH a node click as EV_NODE_CLICK instead of dropping it. Opt-in, because a subscriber has to DECLARE the event: the hosts that route by hash, and the ones that want nothing, must not have it appear underneath them"),
 	SDATA(data_type_t.DTP_BOOLEAN, "system", 0, false, "Include system topics (__*__) too"),
 	SDATA(data_type_t.DTP_POINTER, "$container", 0, null, "Root HTML element"),
 	SDATA_END()
@@ -20222,19 +20223,26 @@ function destroy_graph(gobj) {
 *   With a `node_route` the click IS a navigation and this view
 *   makes it: that is what the route was handed down for.
 *
-*   Without one it is still an action, and it belongs to whoever
-*   mounted this view — the schema editor draws the same picture
-*   inside its own screens, where a topic opens in place and no
-*   hash is involved. So the click is published rather than
-*   dropped. A host that subscribes must DECLARE EV_NODE_CLICK in
-*   its own FSM, as with every event a child publishes.
+*   Without one it is still an action, and it can belong to
+*   whoever mounted this view — the schema editor draws the same
+*   picture inside its own screens, where a topic opens in place
+*   and no hash is involved. That host asks for it with
+*   `with_node_click` and DECLARES EV_NODE_CLICK in its own FSM,
+*   as with every event a child publishes.
+*
+*   It is opt-in and not the default for exactly that reason: the
+*   CHILD subscription model subscribes the host to ALL of this
+*   view's events, so publishing one unasked turns a click into
+*   "Event NOT DEFINED in state" in every host that never wanted
+*   it — the topics view that mounts this as its schema landing,
+*   and the offline demo that mounts it against a json file.
 ************************************************************/
 function ac_node_click$2(gobj, event, kw, src) {
 	let topic = kw && kw.node_id;
 	let route = gobj_read_str_attr(gobj, "node_route");
 	if (!topic) return 0;
 	if (!route) {
-		gobj_publish_event(gobj, "EV_NODE_CLICK", { topic });
+		if (gobj_read_bool_attr(gobj, "with_node_click")) gobj_publish_event(gobj, "EV_NODE_CLICK", { topic });
 		return 0;
 	}
 	let href = route.replace("{topic}", topic);
@@ -23402,6 +23410,7 @@ function render_diagram(gobj) {
 		subscriber: gobj,
 		descs,
 		node_route: "",
+		with_node_click: true,
 		system: true
 	}, gobj);
 	if (!diagram) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yuneta/gobj-ui",
-  "version": "6.1.1",
+  "version": "6.1.2",
   "type": "module",
   "main": "dist/gobj-ui.cjs.js",
   "module": "dist/gobj-ui.es.js",

package/src/c_yui_schema_editor.js

@@ -1389,9 +1389,11 @@ function render_diagram(gobj)
             subscriber: gobj,
             descs:      descs,
             /*  No `node_route`: this diagram lives inside the editor and
-             *  a node click is answered here, not by a hash the shell
-             *  would have to own.  */
-            node_route: "",
+             *  a node click is answered HERE, not by a hash the shell
+             *  would have to own — which is what `with_node_click` asks
+             *  for, and why EV_NODE_CLICK is declared in this FSM.  */
+            node_route:      "",
+            with_node_click: true,
             system:     true
         },
         gobj

package/src/c_yui_treedb_schema.js

@@ -94,6 +94,7 @@ const attrs_table = [
 SDATA(data_type_t.DTP_POINTER,  "subscriber",   0,  null,   "Subscriber of output events"),
 SDATA(data_type_t.DTP_JSON,     "descs",        0,  null,   "Treedb schema: {topic_name: desc}"),
 SDATA(data_type_t.DTP_STRING,   "node_route",   0,  "",     "Hash-route template with a {topic} placeholder: a node click opens that topic (e.g. '#/topics/db/<sel>/{topic}')"),
+SDATA(data_type_t.DTP_BOOLEAN,  "with_node_click", 0, false, "With no `node_route`, PUBLISH a node click as EV_NODE_CLICK instead of dropping it. Opt-in, because a subscriber has to DECLARE the event: the hosts that route by hash, and the ones that want nothing, must not have it appear underneath them"),
 SDATA(data_type_t.DTP_BOOLEAN,  "system",       0,  false,  "Include system topics (__*__) too"),
 SDATA(data_type_t.DTP_POINTER,  "$container",   0,  null,   "Root HTML element"),
 SDATA_END()
@@ -622,12 +623,19 @@ function destroy_graph(gobj)
  *   With a `node_route` the click IS a navigation and this view
  *   makes it: that is what the route was handed down for.
  *
- *   Without one it is still an action, and it belongs to whoever
- *   mounted this view — the schema editor draws the same picture
- *   inside its own screens, where a topic opens in place and no
- *   hash is involved. So the click is published rather than
- *   dropped. A host that subscribes must DECLARE EV_NODE_CLICK in
- *   its own FSM, as with every event a child publishes.
+ *   Without one it is still an action, and it can belong to
+ *   whoever mounted this view — the schema editor draws the same
+ *   picture inside its own screens, where a topic opens in place
+ *   and no hash is involved. That host asks for it with
+ *   `with_node_click` and DECLARES EV_NODE_CLICK in its own FSM,
+ *   as with every event a child publishes.
+ *
+ *   It is opt-in and not the default for exactly that reason: the
+ *   CHILD subscription model subscribes the host to ALL of this
+ *   view's events, so publishing one unasked turns a click into
+ *   "Event NOT DEFINED in state" in every host that never wanted
+ *   it — the topics view that mounts this as its schema landing,
+ *   and the offline demo that mounts it against a json file.
  ************************************************************/
 function ac_node_click(gobj, event, kw, src)
 {
@@ -638,7 +646,9 @@ function ac_node_click(gobj, event, kw, src)
         return 0;
     }
     if(!route) {
-        gobj_publish_event(gobj, "EV_NODE_CLICK", {topic: topic});
+        if(gobj_read_bool_attr(gobj, "with_node_click")) {
+            gobj_publish_event(gobj, "EV_NODE_CLICK", {topic: topic});
+        }
         return 0;
     }
     let href = route.replace("{topic}", topic);