@yume-chan/adb 0.0.22 → 0.0.23

package/esm/server/transport.d.ts

@@ -1,7 +1,9 @@
 import type { ValueOrPromise } from "@yume-chan/struct";
 import type { AdbIncomingSocketHandler, AdbSocket, AdbTransport } from "../adb.js";
 import type { AdbBanner } from "../banner.js";
+import { AdbFeature } from "../features.js";
 import type { AdbServerClient } from "./client.js";
+export declare const ADB_SERVER_DEFAULT_FEATURES: AdbFeature[];
 export declare class AdbServerTransport implements AdbTransport {
     #private;
     readonly serial: string;
@@ -9,6 +11,7 @@ export declare class AdbServerTransport implements AdbTransport {
     readonly maxPayloadSize: number;
     readonly banner: AdbBanner;
     readonly disconnected: Promise<void>;
+    get clientFeatures(): AdbFeature[];
     constructor(client: AdbServerClient, serial: string, banner: AdbBanner, transportId: bigint);
     connect(service: string): Promise<AdbSocket>;
     addReverseTunnel(handler: AdbIncomingSocketHandler, address?: string): Promise<string>;

package/esm/server/transport.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"transport.d.ts","sourceRoot":"","sources":["../../src/server/transport.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AAExD,OAAO,KAAK,EACR,wBAAwB,EACxB,SAAS,EACT,YAAY,EACf,MAAM,WAAW,CAAC;AACnB,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAE9C,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,aAAa,CAAC;AAEnD,qBAAa,kBAAmB,YAAW,YAAY;;IAGnD,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;IAExB,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC;IAE7B,QAAQ,CAAC,cAAc,EAAE,MAAM,CAAmB;IAElD,QAAQ,CAAC,MAAM,EAAE,SAAS,CAAC;IAI3B,QAAQ,CAAC,YAAY,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC;gBAGjC,MAAM,EAAE,eAAe,EACvB,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,SAAS,EACjB,WAAW,EAAE,MAAM;IAgBjB,OAAO,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,SAAS,CAAC;IAS5C,gBAAgB,CAClB,OAAO,EAAE,wBAAwB,EACjC,OAAO,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,MAAM,CAAC;IAIZ,mBAAmB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAInD,mBAAmB,IAAI,OAAO,CAAC,IAAI,CAAC;IAI1C,KAAK,IAAI,cAAc,CAAC,IAAI,CAAC;CAIhC"}
+{"version":3,"file":"transport.d.ts","sourceRoot":"","sources":["../../src/server/transport.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,mBAAmB,CAAC;AAExD,OAAO,KAAK,EACR,wBAAwB,EACxB,SAAS,EACT,YAAY,EACf,MAAM,WAAW,CAAC;AACnB,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAC9C,OAAO,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAE5C,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,aAAa,CAAC;AAEnD,eAAO,MAAM,2BAA2B,cAmBvB,CAAC;AAElB,qBAAa,kBAAmB,YAAW,YAAY;;IAGnD,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;IAExB,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC;IAE7B,QAAQ,CAAC,cAAc,EAAE,MAAM,CAAmB;IAElD,QAAQ,CAAC,MAAM,EAAE,SAAS,CAAC;IAI3B,QAAQ,CAAC,YAAY,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IAErC,IAAI,cAAc,iBAIjB;gBAGG,MAAM,EAAE,eAAe,EACvB,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,SAAS,EACjB,WAAW,EAAE,MAAM;IAgBjB,OAAO,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,SAAS,CAAC;IAS5C,gBAAgB,CAClB,OAAO,EAAE,wBAAwB,EACjC,OAAO,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,MAAM,CAAC;IAIZ,mBAAmB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAInD,mBAAmB,IAAI,OAAO,CAAC,IAAI,CAAC;IAI1C,KAAK,IAAI,cAAc,CAAC,IAAI,CAAC;CAIhC"}

package/esm/server/transport.js

@@ -1,5 +1,26 @@
 import { PromiseResolver } from "@yume-chan/async";
 import { AbortController } from "@yume-chan/stream-extra";
+import { AdbFeature } from "../features.js";
+export const ADB_SERVER_DEFAULT_FEATURES = [
+    AdbFeature.ShellV2,
+    AdbFeature.Cmd,
+    AdbFeature.StatV2,
+    AdbFeature.ListV2,
+    AdbFeature.FixedPushMkdir,
+    "apex",
+    AdbFeature.Abb,
+    // only tells the client the symlink timestamp issue in `adb push --sync` has been fixed.
+    // No special handling required.
+    "fixed_push_symlink_timestamp",
+    AdbFeature.AbbExec,
+    "remount_shell",
+    "track_app",
+    AdbFeature.SendReceiveV2,
+    "sendrecv_v2_brotli",
+    "sendrecv_v2_lz4",
+    "sendrecv_v2_zstd",
+    "sendrecv_v2_dry_run_send",
+];
 export class AdbServerTransport {
     #client;
     serial;
@@ -9,6 +30,11 @@ export class AdbServerTransport {
     #closed = new PromiseResolver();
     #waitAbortController = new AbortController();
     disconnected;
+    get clientFeatures() {
+        // No need to get host features (features supported by ADB server)
+        // Because we create all ADB packets ourselves
+        return ADB_SERVER_DEFAULT_FEATURES;
+    }
     constructor(client, serial, banner, transportId) {
         this.#client = client;
         this.serial = serial;

package/esm/server/transport.js.map

@@ -1 +1 @@
-{"version":3,"file":"transport.js","sourceRoot":"","sources":["../../src/server/transport.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAY1D,MAAM,OAAO,kBAAkB;IAC3B,OAAO,CAAkB;IAEhB,MAAM,CAAS;IAEf,WAAW,CAAS;IAEpB,cAAc,GAAW,CAAC,GAAG,IAAI,GAAG,IAAI,CAAC;IAEzC,MAAM,CAAY;IAE3B,OAAO,GAAG,IAAI,eAAe,EAAQ,CAAC;IACtC,oBAAoB,GAAG,IAAI,eAAe,EAAE,CAAC;IACpC,YAAY,CAAgB;IAErC,YACI,MAAuB,EACvB,MAAc,EACd,MAAiB,EACjB,WAAmB;QAEnB,IAAI,CAAC,OAAO,GAAG,MAAM,CAAC;QACtB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAE/B,IAAI,CAAC,YAAY,GAAG,OAAO,CAAC,IAAI,CAAC;YAC7B,IAAI,CAAC,OAAO,CAAC,OAAO;YACpB,MAAM,CAAC,OAAO,CAAC,EAAE,WAAW,EAAE,EAAE,YAAY,EAAE;gBAC1C,MAAM,EAAE,IAAI,CAAC,oBAAoB,CAAC,MAAM;gBACxC,KAAK,EAAE,IAAI;aACd,CAAC;SACL,CAAC,CAAC;IACP,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,OAAe;QACzB,OAAO,MAAM,IAAI,CAAC,OAAO,CAAC,aAAa,CACnC;YACI,WAAW,EAAE,IAAI,CAAC,WAAW;SAChC,EACD,OAAO,CACV,CAAC;IACN,CAAC;IAED,KAAK,CAAC,gBAAgB,CAClB,OAAiC,EACjC,OAAgB;QAEhB,OAAO,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,gBAAgB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IAC5E,CAAC;IAED,KAAK,CAAC,mBAAmB,CAAC,OAAe;QACrC,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;IAC/D,CAAC;IAED,KAAK,CAAC,mBAAmB;QACrB,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,mBAAmB,EAAE,CAAC;IACxD,CAAC;IAED,KAAK;QACD,IAAI,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC;QACvB,IAAI,CAAC,oBAAoB,CAAC,KAAK,EAAE,CAAC;IACtC,CAAC;CACJ"}
+{"version":3,"file":"transport.js","sourceRoot":"","sources":["../../src/server/transport.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAC;AACnD,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAS1D,OAAO,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAI5C,MAAM,CAAC,MAAM,2BAA2B,GAAG;IACvC,UAAU,CAAC,OAAO;IAClB,UAAU,CAAC,GAAG;IACd,UAAU,CAAC,MAAM;IACjB,UAAU,CAAC,MAAM;IACjB,UAAU,CAAC,cAAc;IACzB,MAAM;IACN,UAAU,CAAC,GAAG;IACd,yFAAyF;IACzF,gCAAgC;IAChC,8BAA8B;IAC9B,UAAU,CAAC,OAAO;IAClB,eAAe;IACf,WAAW;IACX,UAAU,CAAC,aAAa;IACxB,oBAAoB;IACpB,iBAAiB;IACjB,kBAAkB;IAClB,0BAA0B;CACb,CAAC;AAElB,MAAM,OAAO,kBAAkB;IAC3B,OAAO,CAAkB;IAEhB,MAAM,CAAS;IAEf,WAAW,CAAS;IAEpB,cAAc,GAAW,CAAC,GAAG,IAAI,GAAG,IAAI,CAAC;IAEzC,MAAM,CAAY;IAE3B,OAAO,GAAG,IAAI,eAAe,EAAQ,CAAC;IACtC,oBAAoB,GAAG,IAAI,eAAe,EAAE,CAAC;IACpC,YAAY,CAAgB;IAErC,IAAI,cAAc;QACd,kEAAkE;QAClE,8CAA8C;QAC9C,OAAO,2BAA2B,CAAC;IACvC,CAAC;IAED,YACI,MAAuB,EACvB,MAAc,EACd,MAAiB,EACjB,WAAmB;QAEnB,IAAI,CAAC,OAAO,GAAG,MAAM,CAAC;QACtB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAC;QACrB,IAAI,CAAC,WAAW,GAAG,WAAW,CAAC;QAE/B,IAAI,CAAC,YAAY,GAAG,OAAO,CAAC,IAAI,CAAC;YAC7B,IAAI,CAAC,OAAO,CAAC,OAAO;YACpB,MAAM,CAAC,OAAO,CAAC,EAAE,WAAW,EAAE,EAAE,YAAY,EAAE;gBAC1C,MAAM,EAAE,IAAI,CAAC,oBAAoB,CAAC,MAAM;gBACxC,KAAK,EAAE,IAAI;aACd,CAAC;SACL,CAAC,CAAC;IACP,CAAC;IAED,KAAK,CAAC,OAAO,CAAC,OAAe;QACzB,OAAO,MAAM,IAAI,CAAC,OAAO,CAAC,aAAa,CACnC;YACI,WAAW,EAAE,IAAI,CAAC,WAAW;SAChC,EACD,OAAO,CACV,CAAC;IACN,CAAC;IAED,KAAK,CAAC,gBAAgB,CAClB,OAAiC,EACjC,OAAgB;QAEhB,OAAO,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,gBAAgB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IAC5E,CAAC;IAED,KAAK,CAAC,mBAAmB,CAAC,OAAe;QACrC,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;IAC/D,CAAC;IAED,KAAK,CAAC,mBAAmB;QACrB,MAAM,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,mBAAmB,EAAE,CAAC;IACxD,CAAC;IAED,KAAK;QACD,IAAI,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC;QACvB,IAAI,CAAC,oBAAoB,CAAC,KAAK,EAAE,CAAC;IACtC,CAAC;CACJ"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yume-chan/adb",
-  "version": "0.0.22",
+  "version": "0.0.23",
   "description": "TypeScript implementation of Android Debug Bridge (ADB) protocol.",
   "keywords": [
     "adb",
@@ -26,28 +26,28 @@
   "types": "esm/index.d.ts",
   "dependencies": {
     "@yume-chan/async": "^2.2.0",
-    "@yume-chan/dataview-bigint-polyfill": "^0.0.22",
-    "@yume-chan/event": "^0.0.22",
-    "@yume-chan/stream-extra": "^0.0.22",
-    "@yume-chan/struct": "^0.0.22",
+    "@yume-chan/dataview-bigint-polyfill": "^0.0.23",
+    "@yume-chan/event": "^0.0.23",
+    "@yume-chan/stream-extra": "^0.0.23",
+    "@yume-chan/struct": "^0.0.23",
     "tslib": "^2.6.2"
   },
   "devDependencies": {
-    "@jest/globals": "^29.7.0",
-    "@types/node": "^20.10.3",
+    "@jest/globals": "^30.0.0-alpha.3",
+    "@types/node": "^20.11.28",
     "@yume-chan/eslint-config": "^1.0.0",
     "@yume-chan/tsconfig": "^1.0.0",
     "cross-env": "^7.0.3",
-    "eslint": "^8.55.0",
-    "jest": "^29.7.0",
-    "prettier": "^3.1.0",
-    "ts-jest": "^29.1.1",
-    "typescript": "^5.3.2"
+    "eslint": "^8.57.0",
+    "jest": "^30.0.0-alpha.3",
+    "prettier": "^3.2.5",
+    "ts-jest": "^29.1.2",
+    "typescript": "^5.4.2"
   },
   "scripts": {
     "build": "tsc -b tsconfig.build.json",
     "build:watch": "tsc -b tsconfig.build.json",
-    "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage",
+    "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules --no-warnings\" TS_JEST_DISABLE_VER_CHECKER=true jest --coverage",
     "lint": "eslint src/**/*.ts --fix && prettier src/**/*.ts --write --tab-width 4"
   }
 }

package/src/adb.ts

@@ -40,6 +40,8 @@ export interface AdbTransport extends Closeable {
 
     readonly disconnected: Promise<void>;
 
+    readonly clientFeatures: readonly AdbFeature[];
+
     connect(service: string): ValueOrPromise<AdbSocket>;
 
     addReverseTunnel(
@@ -71,6 +73,14 @@ export class Adb implements Closeable {
         return this.transport.disconnected;
     }
 
+    public get clientFeatures() {
+        return this.transport.clientFeatures;
+    }
+
+    public get deviceFeatures() {
+        return this.banner.features;
+    }
+
     readonly subprocess: AdbSubprocess;
     readonly power: AdbPower;
     readonly reverse: AdbReverseCommand;
@@ -85,8 +95,11 @@ export class Adb implements Closeable {
         this.tcpip = new AdbTcpIpCommand(this);
     }
 
-    supportsFeature(feature: AdbFeature): boolean {
-        return this.banner.features.includes(feature);
+    canUseFeature(feature: AdbFeature): boolean {
+        return (
+            this.clientFeatures.includes(feature) &&
+            this.deviceFeatures.includes(feature)
+        );
     }
 
     async createSocket(service: string): Promise<AdbSocket> {

package/src/banner.ts

@@ -18,6 +18,7 @@ export class AdbBanner {
         if (pieces.length > 1) {
             const props = pieces[1]!;
             for (const prop of props.split(";")) {
+                // istanbul ignore if
                 if (!prop) {
                     continue;
                 }

package/src/commands/reverse.ts

@@ -38,7 +38,7 @@ const AdbReverseErrorResponse = new Struct()
     .concat(AdbReverseStringResponse)
     .postDeserialize((value) => {
         // https://issuetracker.google.com/issues/37066218
-        // ADB on Android <9 can't create reverse tunnels when connected wirelessly (ADB over WiFi),
+        // ADB on Android <9 can't create reverse tunnels when connected wirelessly (ADB over Wi-Fi),
         // and returns this confusing "more than one device/emulator" error.
         if (value.content === "more than one device/emulator") {
             throw new AdbReverseNotSupportedError();
@@ -81,7 +81,7 @@ export class AdbReverseCommand extends AutoDisposable {
         const stream = await this.createBufferedStream("reverse:list-forward");
 
         const response = await AdbReverseStringResponse.deserialize(stream);
-        return response.content!.split("\n").map((line) => {
+        return response.content.split("\n").map((line) => {
             const [deviceSerial, localName, remoteName] = line.split(" ") as [
                 string,
                 string,

package/src/commands/subprocess/protocols/shell.ts

@@ -6,12 +6,10 @@ import type {
     WritableStreamDefaultWriter,
 } from "@yume-chan/stream-extra";
 import {
-    ConsumableTransformStream,
     ConsumableWritableStream,
     PushReadableStream,
     StructDeserializeStream,
     WritableStream,
-    pipeFrom,
 } from "@yume-chan/stream-extra";
 import type { StructValueType } from "@yume-chan/struct";
 import Struct, { placeholder } from "@yume-chan/struct";
@@ -37,68 +35,8 @@ const AdbShellProtocolPacket = new Struct({ littleEndian: true })
     .uint32("length")
     .uint8Array("data", { lengthField: "length" });
 
-type AdbShellProtocolPacketInit = (typeof AdbShellProtocolPacket)["TInit"];
-
 type AdbShellProtocolPacket = StructValueType<typeof AdbShellProtocolPacket>;
 
-class StdinSerializeStream extends ConsumableTransformStream<
-    Uint8Array,
-    AdbShellProtocolPacketInit
-> {
-    constructor() {
-        super({
-            async transform(chunk, controller) {
-                await controller.enqueue({
-                    id: AdbShellProtocolId.Stdin,
-                    data: chunk,
-                });
-            },
-            flush() {
-                // TODO: AdbShellSubprocessProtocol: support closing stdin
-            },
-        });
-    }
-}
-
-class MultiplexStream<T> {
-    #readable: PushReadableStream<T>;
-    #readableController!: PushReadableStreamController<T>;
-    get readable() {
-        return this.#readable;
-    }
-
-    #activeCount = 0;
-
-    constructor() {
-        this.#readable = new PushReadableStream((controller) => {
-            this.#readableController = controller;
-        });
-    }
-
-    createWriteable() {
-        return new WritableStream<T>({
-            start: () => {
-                this.#activeCount += 1;
-            },
-            write: async (chunk) => {
-                await this.#readableController.enqueue(chunk);
-            },
-            abort: () => {
-                this.#activeCount -= 1;
-                if (this.#activeCount === 0) {
-                    this.#readableController.close();
-                }
-            },
-            close: () => {
-                this.#activeCount -= 1;
-                if (this.#activeCount === 0) {
-                    this.#readableController.close();
-                }
-            },
-        });
-    }
-}
-
 /**
  * Shell v2 a.k.a Shell Protocol
  *
@@ -109,7 +47,7 @@ class MultiplexStream<T> {
  */
 export class AdbSubprocessShellProtocol implements AdbSubprocessProtocol {
     static isSupported(adb: Adb) {
-        return adb.supportsFeature(AdbFeature.ShellV2);
+        return adb.canUseFeature(AdbFeature.ShellV2);
     }
 
     static async pty(adb: Adb, command: string) {
@@ -126,9 +64,7 @@ export class AdbSubprocessShellProtocol implements AdbSubprocessProtocol {
     }
 
     readonly #socket: AdbSocket;
-    #socketWriter: WritableStreamDefaultWriter<
-        Consumable<AdbShellProtocolPacketInit>
-    >;
+    #writer: WritableStreamDefaultWriter<Consumable<Uint8Array>>;
 
     #stdin: WritableStream<Consumable<Uint8Array>>;
     get stdin() {
@@ -153,13 +89,8 @@ export class AdbSubprocessShellProtocol implements AdbSubprocessProtocol {
     constructor(socket: AdbSocket) {
         this.#socket = socket;
 
-        // Check this image to help you understand the stream graph
-        // cspell: disable-next-line
-        // https://www.plantuml.com/plantuml/png/bL91QiCm4Bpx5SAdv90lb1JISmiw5XzaQKf5PIkiLZIqzEyLSg8ks13gYtOykpFhiOw93N6UGjVDqK7rZsxKqNw0U_NTgVAy4empOy2mm4_olC0VEVEE47GUpnGjKdgXoD76q4GIEpyFhOwP_m28hW0NNzxNUig1_JdW0bA7muFIJDco1daJ_1SAX9bgvoPJPyIkSekhNYctvIGXrCH6tIsPL5fs-s6J5yc9BpWXhKtNdF2LgVYPGM_6GlMwfhWUsIt4lbScANrwlgVVUifPSVi__t44qStnwPvZwobdSmHHlL57p2vFuHS0
-
         let stdoutController!: PushReadableStreamController<Uint8Array>;
         let stderrController!: PushReadableStreamController<Uint8Array>;
-
         this.#stdout = new PushReadableStream<Uint8Array>((controller) => {
             stdoutController = controller;
         });
@@ -207,39 +138,33 @@ export class AdbSubprocessShellProtocol implements AdbSubprocessProtocol {
                 },
             );
 
-        const multiplexer = new MultiplexStream<
-            Consumable<AdbShellProtocolPacketInit>
-        >();
-        void multiplexer.readable
-            .pipeThrough(
-                new ConsumableTransformStream({
-                    async transform(chunk, controller) {
-                        await controller.enqueue(
-                            AdbShellProtocolPacket.serialize(chunk),
-                        );
-                    },
-                }),
-            )
-            .pipeTo(socket.writable);
-
-        this.#stdin = pipeFrom(
-            multiplexer.createWriteable(),
-            new StdinSerializeStream(),
-        );
+        this.#writer = this.#socket.writable.getWriter();
 
-        this.#socketWriter = multiplexer.createWriteable().getWriter();
+        this.#stdin = new WritableStream<Consumable<Uint8Array>>({
+            write: async (chunk) => {
+                await ConsumableWritableStream.write(
+                    this.#writer,
+                    AdbShellProtocolPacket.serialize({
+                        id: AdbShellProtocolId.Stdin,
+                        data: chunk.value,
+                    }),
+                );
+                chunk.consume();
+            },
+        });
     }
 
     async resize(rows: number, cols: number) {
-        await ConsumableWritableStream.write(this.#socketWriter, {
-            id: AdbShellProtocolId.WindowSizeChange,
-            data: encodeUtf8(
+        await ConsumableWritableStream.write(
+            this.#writer,
+            AdbShellProtocolPacket.serialize({
+                id: AdbShellProtocolId.WindowSizeChange,
                 // The "correct" format is `${rows}x${cols},${x_pixels}x${y_pixels}`
                 // However, according to https://linux.die.net/man/4/tty_ioctl
                 // `x_pixels` and `y_pixels` are unused, so always sending `0` should be fine.
-                `${rows}x${cols},0x0\0`,
-            ),
-        });
+                data: encodeUtf8(`${rows}x${cols},0x0\0`),
+            }),
+        );
     }
 
     kill() {

package/src/commands/subprocess/utils.ts

@@ -10,7 +10,7 @@ export function escapeArg(s: string) {
             break;
         }
         result += s.substring(base, found);
-        // a'b becomes a'\'b
+        // a'b becomes a'\'b (the backslash is not a escape character)
         result += String.raw`'\''`;
         base = found + 1;
     }

package/src/commands/sync/sync.ts

@@ -74,16 +74,15 @@ export class AdbSync extends AutoDisposable {
         this._adb = adb;
         this._socket = new AdbSyncSocket(socket, adb.maxPayloadSize);
 
-        this.#supportsStat = adb.supportsFeature(AdbFeature.StatV2);
-        this.#supportsListV2 = adb.supportsFeature(AdbFeature.ListV2);
-        this.#fixedPushMkdir = adb.supportsFeature(AdbFeature.FixedPushMkdir);
-        this.#supportsSendReceiveV2 = adb.supportsFeature(
+        this.#supportsStat = adb.canUseFeature(AdbFeature.StatV2);
+        this.#supportsListV2 = adb.canUseFeature(AdbFeature.ListV2);
+        this.#fixedPushMkdir = adb.canUseFeature(AdbFeature.FixedPushMkdir);
+        this.#supportsSendReceiveV2 = adb.canUseFeature(
             AdbFeature.SendReceiveV2,
         );
         // https://android.googlesource.com/platform/packages/modules/adb/+/91768a57b7138166e0a3d11f79cd55909dda7014/client/file_sync_client.cpp#1361
         this.#needPushMkdirWorkaround =
-            this._adb.supportsFeature(AdbFeature.ShellV2) &&
-            !this.fixedPushMkdir;
+            this._adb.canUseFeature(AdbFeature.ShellV2) && !this.fixedPushMkdir;
     }
 
     /**

package/src/daemon/dispatcher.ts

@@ -13,7 +13,7 @@ import {
     ConsumableWritableStream,
     WritableStream,
 } from "@yume-chan/stream-extra";
-import { EMPTY_UINT8_ARRAY } from "@yume-chan/struct";
+import { EMPTY_UINT8_ARRAY, NumberFieldType } from "@yume-chan/struct";
 
 import type { AdbIncomingSocketHandler, AdbSocket, Closeable } from "../adb.js";
 import { decodeUtf8, encodeUtf8 } from "../utils/index.js";
@@ -32,6 +32,13 @@ export interface AdbPacketDispatcherOptions {
      */
     appendNullToServiceString: boolean;
     maxPayloadSize: number;
+    /**
+     * The number of bytes the device can send before receiving an ack packet.
+
+     * Set to 0 or any negative value to disable delayed ack.
+     * Otherwise the value must be in the range of unsigned 32-bit integer.
+     */
+    initialDelayedAckBytes: number;
     /**
      * Whether to preserve the connection open after the `AdbPacketDispatcher` is closed.
      */
@@ -39,6 +46,11 @@ export interface AdbPacketDispatcherOptions {
     debugSlowRead?: boolean | undefined;
 }
 
+interface SocketOpenResult {
+    remoteId: number;
+    availableWriteBytes: number;
+}
+
 /**
  * The dispatcher is the "dumb" part of the connection handling logic.
  *
@@ -79,6 +91,10 @@ export class AdbPacketDispatcher implements Closeable {
         options: AdbPacketDispatcherOptions,
     ) {
         this.options = options;
+        // Don't allow negative values in dispatcher
+        if (this.options.initialDelayedAckBytes < 0) {
+            this.options.initialDelayedAckBytes = 0;
+        }
 
         connection.readable
             .pipeTo(
@@ -169,15 +185,40 @@ export class AdbPacketDispatcher implements Closeable {
     }
 
     #handleOkay(packet: AdbPacketData) {
-        if (this.#initializers.resolve(packet.arg1, packet.arg0)) {
+        let ackBytes: number;
+        if (this.options.initialDelayedAckBytes !== 0) {
+            if (packet.payload.byteLength !== 4) {
+                throw new Error(
+                    "Invalid OKAY packet. Payload size should be 4",
+                );
+            }
+            ackBytes = NumberFieldType.Uint32.deserialize(packet.payload, true);
+        } else {
+            if (packet.payload.byteLength !== 0) {
+                throw new Error(
+                    "Invalid OKAY packet. Payload size should be 0",
+                );
+            }
+            ackBytes = Infinity;
+        }
+
+        if (
+            this.#initializers.resolve(packet.arg1, {
+                remoteId: packet.arg0,
+                availableWriteBytes: ackBytes,
+            } satisfies SocketOpenResult)
+        ) {
             // Device successfully created the socket
             return;
         }
 
         const socket = this.#sockets.get(packet.arg1);
         if (socket) {
-            // Device has received last `WRTE` to the socket
-            socket.ack();
+            // When delayed ack is enabled, `ackBytes` is a positive number represents
+            // how many bytes the device has received from this socket.
+            // When delayed ack is disabled, `ackBytes` is always `Infinity` represents
+            // the device has received last `WRTE` packet from the socket.
+            socket.ack(ackBytes);
             return;
         }
 
@@ -186,6 +227,18 @@ export class AdbPacketDispatcher implements Closeable {
         void this.sendPacket(AdbCommand.Close, packet.arg1, packet.arg0);
     }
 
+    #sendOkay(localId: number, remoteId: number, ackBytes: number) {
+        let payload: Uint8Array;
+        if (this.options.initialDelayedAckBytes !== 0) {
+            payload = new Uint8Array(4);
+            new DataView(payload.buffer).setUint32(0, ackBytes, true);
+        } else {
+            payload = EMPTY_UINT8_ARRAY;
+        }
+
+        return this.sendPacket(AdbCommand.Okay, localId, remoteId, payload);
+    }
+
     async #handleOpen(packet: AdbPacketData) {
         // `AsyncOperationManager` doesn't support skipping IDs
         // Use `add` + `resolve` to simulate this behavior
@@ -193,9 +246,20 @@ export class AdbPacketDispatcher implements Closeable {
         this.#initializers.resolve(localId, undefined);
 
         const remoteId = packet.arg0;
-        let service = decodeUtf8(packet.payload);
-        if (service.endsWith("\0")) {
-            service = service.substring(0, service.length - 1);
+        let initialDelayedAckBytes = packet.arg1;
+        const service = decodeUtf8(packet.payload);
+
+        if (this.options.initialDelayedAckBytes === 0) {
+            if (initialDelayedAckBytes !== 0) {
+                throw new Error("Invalid OPEN packet. arg1 should be 0");
+            }
+            initialDelayedAckBytes = Infinity;
+        } else {
+            if (initialDelayedAckBytes === 0) {
+                throw new Error(
+                    "Invalid OPEN packet. arg1 should be greater than 0",
+                );
+            }
         }
 
         const handler = this.#incomingSocketHandlers.get(service);
@@ -211,11 +275,16 @@ export class AdbPacketDispatcher implements Closeable {
             localCreated: false,
             service,
         });
+        controller.ack(initialDelayedAckBytes);
 
         try {
             await handler(controller.socket);
             this.#sockets.set(localId, controller);
-            await this.sendPacket(AdbCommand.Okay, localId, remoteId);
+            await this.#sendOkay(
+                localId,
+                remoteId,
+                this.options.initialDelayedAckBytes,
+            );
         } catch (e) {
             await this.sendPacket(AdbCommand.Close, 0, remoteId);
         }
@@ -238,10 +307,10 @@ export class AdbPacketDispatcher implements Closeable {
             }),
             (async () => {
                 await socket.enqueue(packet.payload);
-                await this.sendPacket(
-                    AdbCommand.Okay,
+                await this.#sendOkay(
                     packet.arg1,
                     packet.arg0,
+                    packet.payload.length,
                 );
                 handled = true;
             })(),
@@ -255,11 +324,17 @@ export class AdbPacketDispatcher implements Closeable {
             service += "\0";
         }
 
-        const [localId, initializer] = this.#initializers.add<number>();
-        await this.sendPacket(AdbCommand.Open, localId, 0, service);
+        const [localId, initializer] =
+            this.#initializers.add<SocketOpenResult>();
+        await this.sendPacket(
+            AdbCommand.Open,
+            localId,
+            this.options.initialDelayedAckBytes,
+            service,
+        );
 
-        // Fulfilled by `handleOk`
-        const remoteId = await initializer;
+        // Fulfilled by `handleOkay`
+        const { remoteId, availableWriteBytes } = await initializer;
         const controller = new AdbDaemonSocketController({
             dispatcher: this,
             localId,
@@ -267,6 +342,7 @@ export class AdbPacketDispatcher implements Closeable {
             localCreated: true,
             service,
         });
+        controller.ack(availableWriteBytes);
         this.#sockets.set(localId, controller);
 
         return controller.socket;