@yousolution/node-red-contrib-you-sap-service-layer 0.0.6 → 0.1.1

package/nodes/nextLink.html

@@ -1,85 +1,100 @@
 <script type="text/javascript">
-  RED.nodes.registerType('nextLink',{
+  RED.nodes.registerType('nextLink', {
     category: 'Sap',
     color: '#FFC300',
     defaults: {
-      name: {value: ''},
-      nextLink: {value: ''}
+      name: { value: '' },
+      nextLink: { value: '' },
     },
-    inputs:1,
-    outputs:1,
+    inputs: 1,
+    outputs: 2,
+    outputLabels: ['next', 'end'],
+    // outputLabels: function (index) {
+    //   if (index == 0) {
+    //     return 'next iteration';
+    //   }
+    //   return 'last iteration';
+    // },
     icon: 'font-awesome/fa-arrows-h',
-    label: function() {
-      return this.name||"Next link";
+    label: function () {
+      return this.name || 'Next link';
     },
-    oneditprepare: function() {
-      $("#node-input-nextLink").typedInput({
-        type:"msg",
-        types:["msg"],
-        typeField: "#node-input-nextLink-type",
-        value: 'nextLink'
+    oneditprepare: function () {
+      $('#node-input-nextLink').typedInput({
+        type: 'msg',
+        types: ['msg'],
+        typeField: '#node-input-nextLink-type',
+        value: 'nextLink',
       });
-    }
+    },
   });
 </script>
 
-
-
-  
 <script type="text/html" data-template-name="nextLink">
   <div class="form-row">
     <label for="node-input-name"><i class="fa fa-tag"></i> Name</label>
-    <input type="text" id="node-input-name" placeholder="Name">
+    <input type="text" id="node-input-name" placeholder="Name" />
   </div>
 
   <div class="form-row">
     <label for="node-input-type"><i class="fa fa-gears"></i> NextLink</label>
-    <input type="text" id="node-input-nextLink">
-    <input type="hidden" id="node-input-nextLink-type">
+    <input type="text" id="node-input-nextLink" />
+    <input type="hidden" id="node-input-nextLink-type" />
   </div>
 </script>
-  
+
 <!-- Documentation -->
 <script type="text/html" data-help-name="nextLink">
   <p>Next link</p>
-  
+
   <h3>Inputs</h3>
-    <dl class="message-properties">
-      <dt>Name
-        <span class="property-type">string</span>
-      </dt>
-      <dd> the node's name </dd>
-      <dt>NextLink
-        <span class="property-type">string</span>
-      </dt>
-      <dd> the url link to next Service Layer page </dd>
-    </dl>
-  
-   <h3>Outputs</h3>
-    <ol class="node-ports">
-      <li>Standard output
-        <dl class="message-properties">
-          <dt>payload <span class="property-type">string</span></dt>
-          <dd>the standard output of the command.</dd>
-        </dl>
-      </li>
-    </ol>
-  
+  <dl class="message-properties">
+    <dt>
+      Name
+      <span class="property-type">string</span>
+    </dt>
+    <dd>the node's name</dd>
+    <dt>
+      NextLink
+      <span class="property-type">string</span>
+    </dt>
+    <dd>the url link to next Service Layer page</dd>
+  </dl>
+
+  <h3>Outputs</h3>
+  <ol class="node-ports">
+    <li>
+      Standard output
+      <dl class="message-properties">
+        <dt>payload <span class="property-type">msg</span></dt>
+        <dd>It returns the message with next link to the next page.</dd>
+      </dl>
+    </li>
+    <li>
+      Standard output
+      <dl class="message-properties">
+        <dt>payload <span class="property-type">msg</span></dt>
+        <dd>It returns the message when the last page is reached.</dd>
+      </dl>
+    </li>
+  </ol>
+
   <h3>Details</h3>
-      <p>this node is used to get the next page of result of items from service layer.
-        See the examples to understand how to use it.
-      </p>
-      <!-- <p><code>msg.payload</code> is used as the payload of the published message.
+  <p>this node is used to get the next page of result of items from service layer. See the examples to understand how to use it.</p>
+  <!-- <p><code>msg.payload</code> is used as the payload of the published message.
       If it contains an Object it will be converted to a JSON string before being sent.
       If it contains a binary Buffer the message will be published as-is.</p>
       <p>The topic used can be configured in the node or, if left blank, can be set
       by <code>msg.topic</code>.</p>
       <p>Likewise the QoS and retain values can be configured in the node or, if left
       blank, set by <code>msg.qos</code> and <code>msg.retain</code> respectively.</p> -->
-  
+
   <h3>References</h3>
-      <ul>
-          <li><a href="https://sap-samples.github.io/smb-summit-hackathon/b1sl.html" target="_black">Service layer API docs</a> - for more details </li>
-          <li><a href="https://github.com/yousolution-cloud/node-red-contrib-you-sap-service-layer">@yousolution-cloud/node-red-contrib-you-sap-service-layer</a> - the nodes github repository</li>
-      </ul>
-</script>
+  <ul>
+    <li><a href="https://sap-samples.github.io/smb-summit-hackathon/b1sl.html" target="_black">Service layer API docs</a> - for more details</li>
+    <li>
+      <a href="https://github.com/yousolution-cloud/node-red-contrib-you-sap-service-layer">@yousolution-cloud/node-red-contrib-you-sap-service-layer</a> - the
+      nodes github repository
+    </li>
+  </ul>
+</script>

package/nodes/nextLink.js

@@ -7,12 +7,12 @@ module.exports = function (RED) {
       const nextLink = msg[config.nextLink];
 
       if (!nextLink) {
+        node.send([null, msg]);
         return;
       }
-      
-      node.send(msg);
+
+      node.send([msg, null]);
     });
   }
   RED.nodes.registerType('nextLink', NextLinkNode, {});
 };
-

package/nodes/patchSap.html

@@ -4,6 +4,7 @@
     color: '#FFC300',
     defaults: {
       name: {value: ''},
+      method: {value: 'PATCH'},
       entity: {value: ''},
       udo: {value: ''},
       udt: {value: ''},
@@ -84,6 +85,14 @@
     <input type="text" id="node-input-name" placeholder="Name">
   </div>
 
+  <div class="form-row">
+    <label for="node-input-type"><i class="fa fa-cog"></i> Method</label>
+    <select name="node-input-method" id="node-input-method">
+      <option value="PATCH">PATCH</option>
+      <option value="PUT">PUT</option>
+    </select>
+  </div>
+
   <div class="form-row">
     <label for="node-input-type"><i class="fa fa-cube"></i> Entity</label>
     <select name="node-input-entity" id="node-input-entity">

package/nodes/support.js

@@ -62,15 +62,15 @@ const thickIdApi = [
 ];
 
 async function login(node, idAuth) {
-  const flowContext = node.context().flow;
+  const globalContext = node.context().global;
 
-  const host = flowContext.get(`_YOU_SapServiceLayer_${idAuth}.host`);
-  const port = flowContext.get(`_YOU_SapServiceLayer_${idAuth}.port`);
-  const version = flowContext.get(`_YOU_SapServiceLayer_${idAuth}.version`);
+  const host = globalContext.get(`_YOU_SapServiceLayer_${idAuth}.host`);
+  const port = globalContext.get(`_YOU_SapServiceLayer_${idAuth}.port`);
+  const version = globalContext.get(`_YOU_SapServiceLayer_${idAuth}.version`);
 
   const url = `https://${host}:${port}/b1s/${version}/Login`;
 
-  const credentials = flowContext.get(`_YOU_SapServiceLayer_${idAuth}.credentials`);
+  const credentials = globalContext.get(`_YOU_SapServiceLayer_${idAuth}.credentials`);
   const dataString = JSON.stringify(credentials);
 
   const options = {
@@ -107,14 +107,14 @@ async function sendRequest({ node, msg, config, axios, login, options }) {
   } catch (error) {
     // Refresh headers re-login
     if (error.response && (error.response.status == 401 || error.response.status == 301)) {
-      const flowContext = node.context().flow;
+      const globalCotext = node.context().global;
       // try {
       // update cookies for session timeout
       const result = await login(node, requestOptions.idAuthNode);
-      flowContext.set(`_YOU_SapServiceLayer_${requestOptions.idAuthNode}.headers`, result.headers['set-cookie']);
+      globalCotext.set(`_YOU_SapServiceLayer_${requestOptions.idAuthNode}.headers`, result.headers['set-cookie']);
 
       try {
-        const headers = flowContext.get(`_YOU_SapServiceLayer_${requestOptions.idAuthNode}.headers`).join(';');
+        const headers = globalCotext.get(`_YOU_SapServiceLayer_${requestOptions.idAuthNode}.headers`).join(';');
 
         requestOptions.axiosOptions.headers.Cookie = headers;
 
@@ -164,6 +164,7 @@ function generateRequest(node, msg, config, options) {
   options.isCrossJoin = options.isCrossJoin || false;
   options.isManipulate = options.isManipulate || false;
   options.isService = options.isService || false;
+  options.isCreateSQLQuery = options.isCreateSQLQuery || false;
   options.service = options.service || null;
   options.manipulateMethod = options.manipulateMethod || null;
 
@@ -171,6 +172,7 @@ function generateRequest(node, msg, config, options) {
 
   let rawQuery = null;
   let url;
+
   if (options.hasRawQuery) {
     try {
       rawQuery = eval(config.query);
@@ -180,7 +182,7 @@ function generateRequest(node, msg, config, options) {
   }
 
   let entity = config.entity;
-  if (!entity && !options.isService) {
+  if (!entity && !options.isService && !options.isCreateSQLQuery && !options.isSQLQuery) {
     throw new Error('Missing entity');
   }
 
@@ -214,6 +216,13 @@ function generateRequest(node, msg, config, options) {
     url = `https://${host}:${port}/b1s/${version}/$crossjoin(${entity})`;
   }
 
+  if (options.isSQLQuery) {
+    if (!config.sqlCode) {
+      throw new Error('Missing sqlCode');
+    }
+    url = `https://${host}:${port}/b1s/${version}/SQLQueries('${msg[config.sqlCode]}')/List`;
+  }
+
   if (odataNextLink) {
     url = `https://${host}:${port}/b1s/${version}/${odataNextLink}`;
   }
@@ -268,6 +277,19 @@ function generateRequest(node, msg, config, options) {
     url = `https://${host}:${port}/b1s/${version}/${config.service}`;
   }
 
+  if (options.isCreateSQLQuery) {
+    if (!config.sqlCode) {
+      throw new Error('Missing sqlCode');
+    }
+    if (!config.sqlName) {
+      throw new Error('Missing sqlName');
+    }
+    if (!config.sqlText) {
+      throw new Error('Missing sqlText');
+    }
+    url = `https://${host}:${port}/b1s/${version}/SQLQueries`;
+  }
+
   if (rawQuery && !odataNextLink) {
     const urlOdata = buildQuery(rawQuery);
     msg.odata = urlOdata;
@@ -297,17 +319,17 @@ function generateRequest(node, msg, config, options) {
 
 function getSapParams(node, msg) {
   try {
-    const flowContext = node.context().flow;
+    const globalContext = node.context().global;
 
     const idAuthNode = msg._YOU_SapServiceLayer.idAuth;
-    const host = flowContext.get(`_YOU_SapServiceLayer_${idAuthNode}.host`);
-    const port = flowContext.get(`_YOU_SapServiceLayer_${idAuthNode}.port`);
-    const version = flowContext.get(`_YOU_SapServiceLayer_${idAuthNode}.version`);
+    const host = globalContext.get(`_YOU_SapServiceLayer_${idAuthNode}.host`);
+    const port = globalContext.get(`_YOU_SapServiceLayer_${idAuthNode}.port`);
+    const version = globalContext.get(`_YOU_SapServiceLayer_${idAuthNode}.version`);
 
     // if (!flowContext.get(`_YOU_SapServiceLayer_${idAuthNode}.headers`)) {
     //   throw new Error('Authentication failed');
     // }
-    const cookies = flowContext.get(`_YOU_SapServiceLayer_${idAuthNode}.headers`).join(';');
+    const cookies = globalContext.get(`_YOU_SapServiceLayer_${idAuthNode}.headers`).join(';');
 
     return { idAuthNode: idAuthNode, host: host, port: port, version: version, cookies: cookies };
   } catch (error) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yousolution/node-red-contrib-you-sap-service-layer",
-  "version": "0.0.6",
+  "version": "0.1.1",
   "description": "Unofficial module SAP Service Layer for NODE-RED",
   "license": "MIT",
   "scripts": {
@@ -19,6 +19,7 @@
   ],
   "author": "Andrea Trentin <andrea.trentin@yousolution.cloud>",
   "node-red": {
+    "version": ">=2.0.0",
     "nodes": {
       "authenticateSap": "/nodes/authenticateSap.js",
       "listSap": "/nodes/listSap.js",
@@ -30,7 +31,9 @@
       "crossJoinSap": "/nodes/crossJoinSap.js",
       "nextLink": "/nodes/nextLink.js",
       "serviceSap": "/nodes/serviceSap.js",
-      "manipulateEntitySap": "/nodes/manipulateEntitySap.js"
+      "manipulateEntitySap": "/nodes/manipulateEntitySap.js",
+      "createSQLQuery": "/nodes/createSQLQuery.js",
+      "SQLQuery": "/nodes/SQLQuery.js"
     }
   },
   "dependencies": {

package/test/authenticateSap.spec.js

@@ -144,6 +144,52 @@ describe('authenticateSap Node', () => {
     });
   });
 
+  it('should generic error ', (done) => {
+    const flow = [
+      {
+        id: 'n1',
+        type: 'authenticateSap',
+        name: 'authenticateSap',
+        wires: [['n2']],
+        z: 'flow',
+        rules: [{ t: 'set', p: 'payload', to: '#:(memory1)::flowValue', tot: 'flow' }],
+      },
+      { id: 'n2', type: 'helper' },
+    ];
+    helper.load(authenticateSap, flow, () => {
+      const n2 = helper.getNode('n2');
+      const n1 = helper.getNode('n1');
+      n1.credentials.user = 'user';
+      n1.credentials.password = 'password';
+      n1.credentials.company = 'company';
+
+      sinon.stub(Support, 'login').rejects(new Error('Custom error'));
+
+      // n1.context().flow.set(`_YOU_SapServiceLayer_${n1.id}.headers`, true, 'memory1', function (error) {
+      //   // console.log(error);
+      // });
+
+      n1.receive({});
+
+      n2.on('input', (msg) => {
+        try {
+          msg.should.have.property('payload', new Error('Custom error'));
+          done();
+        } catch (err) {
+          done(err);
+        }
+      });
+
+      n1.on('call:error', (error) => {
+        try {
+          error.should.have.property('firstArg', new Error('Custom error'));
+        } catch (err) {
+          done(err);
+        }
+      });
+    });
+  });
+
   it('should have without headers connected', (done) => {
     const flow = [
       {

package/test/createSQLQuery.spec.js

@@ -0,0 +1,174 @@
+const should = require('should');
+const helper = require('node-red-node-test-helper');
+const createSQLQuery = require('../nodes/createSQLQuery');
+const Context = require('../node_modules/./@node-red/runtime/lib/nodes/context/index');
+const sinon = require('sinon');
+const Support = require('../nodes/support');
+
+helper.init(require.resolve('node-red'));
+
+describe('createSQLQuery Node', () => {
+  beforeEach((done) => {
+    helper.startServer(done);
+  });
+
+  function initContext(done) {
+    Context.init({
+      contextStorage: {
+        memory0: {
+          module: 'memory',
+        },
+        memory1: {
+          module: 'memory',
+        },
+      },
+    });
+    Context.load().then(function () {
+      done();
+    });
+  }
+
+  afterEach((done) => {
+    helper
+      .unload()
+      .then(function () {
+        return Context.clean({ allNodes: {} });
+      })
+      .then(function () {
+        return Context.close();
+      })
+      .then(function () {
+        helper.stopServer(done);
+      });
+
+    // Restore the default sandbox here
+    sinon.restore();
+
+    // helper.unload();
+    // helper.stopServer(done);
+  });
+
+  it('should be loaded', (done) => {
+    const flow = [
+      {
+        id: 'n1',
+        type: 'createSQLQuery',
+        name: 'createSQLQuery',
+        wires: [['n2']],
+        z: 'flow',
+        rules: [{ t: 'set', p: 'payload', to: '#:(memory1)::flowValue', tot: 'flow' }],
+      },
+    ];
+
+    helper.load(createSQLQuery, flow, () => {
+      initContext(function () {
+        const n1 = helper.getNode('n1');
+        try {
+          n1.should.have.property('name', 'createSQLQuery');
+          done();
+        } catch (err) {
+          done(err);
+        }
+      });
+    });
+  });
+
+  it('should have correct request with data', (done) => {
+    const flow = [
+      {
+        id: 'n1',
+        type: 'createSQLQuery',
+        name: 'createSQLQuery',
+        wires: [['n2']],
+        z: 'flow',
+        sqlCode: 'sqlCode',
+        sqlName: 'sqlName',
+        sqlText: 'sqlText',
+        rules: [{ t: 'set', p: 'payload', to: '#:(memory1)::flowValue', tot: 'flow' }],
+      },
+      { id: 'n2', type: 'helper' },
+    ];
+    helper.load(createSQLQuery, flow, () => {
+      const n2 = helper.getNode('n2');
+      const n1 = helper.getNode('n1');
+
+      sinon.stub(Support, 'sendRequest').resolves('ok');
+
+      n1.receive({ sqlCode: 'code', sqlName: 'name', sqlText: 'text' });
+
+      n2.on('input', (msg) => {
+        try {
+          msg.should.have.property('_msgid');
+          msg.should.have.property('payload', 'ok');
+          done();
+        } catch (err) {
+          done(err);
+        }
+      });
+    });
+  });
+
+  // it('should have request without data', (done) => {
+  //   const flow = [
+  //     {
+  //       id: 'n1',
+  //       type: 'serviceSap',
+  //       name: 'serviceSap',
+  //       wires: [['n2']],
+  //       z: 'flow',
+  //       bodyPost: 'data',
+  //       rules: [{ t: 'set', p: 'payload', to: '#:(memory1)::flowValue', tot: 'flow' }],
+  //     },
+  //     { id: 'n2', type: 'helper' },
+  //   ];
+  //   helper.load(serviceSap, flow, () => {
+  //     const n2 = helper.getNode('n2');
+  //     const n1 = helper.getNode('n1');
+
+  //     sinon.stub(Support, 'sendRequest').resolves('ok');
+  //     n1.receive({});
+
+  //     n2.on('input', (msg) => {
+  //       try {
+  //         msg.should.have.property('_msgid');
+  //         msg.should.have.property('payload', 'ok');
+  //         done();
+  //       } catch (err) {
+  //         done(err);
+  //       }
+  //     });
+  //   });
+  // });
+
+  it('should handle the error', (done) => {
+    const flow = [
+      {
+        id: 'n1',
+        type: 'createSQLQuery',
+        name: 'createSQLQuery',
+        wires: [['n2']],
+        z: 'flow',
+        sqlCode: 'sqlCode',
+        sqlName: 'sqlName',
+        sqlText: 'sqlText',
+        rules: [{ t: 'set', p: 'payload', to: '#:(memory1)::flowValue', tot: 'flow' }],
+      },
+      { id: 'n2', type: 'helper' },
+    ];
+    helper.load(createSQLQuery, flow, () => {
+      const n2 = helper.getNode('n2');
+      const n1 = helper.getNode('n1');
+
+      const expected = new Error('Missing mandatory params: SqlCode.');
+
+      sinon.stub(Support, 'sendRequest').rejects(expected);
+
+      n1.receive({ sqlName: 'name', sqlText: 'text' });
+
+      n1.on('call:error', (error) => {
+        should.deepEqual(error.args[0], expected);
+        done();
+      });
+    });
+  });
+});