@yolo-labs/yolobridge 0.18.0 → 0.19.0

package/dist/approved-paths.js

@@ -0,0 +1,277 @@
+/**
+ * The approval list that bounds which paths the ATTACHED AGENT will send files
+ * from.
+ *
+ * ⚠️ READ THIS BEFORE RELYING ON IT: THIS IS NOT A SECURITY BOUNDARY.
+ *
+ * The attached agent runs as the SAME OS USER as this CLI and normally has
+ * shell access. It can therefore run `yolo-bridge allow /` itself, or simply
+ * edit `approved-paths.json`. The principal this list constrains can rewrite
+ * the list. No amount of care in the containment checks below changes that —
+ * they are checks against a mistake, not against an adversary who is already
+ * inside the same trust domain. (Found by codex review, gpt-5.6-sol, before
+ * this had any consumer; an earlier version of this comment claimed a
+ * "structural invariant" and was wrong.)
+ *
+ * The same reasoning cuts the other way and is why the feature is still worth
+ * having: an agent with a PTY can already `curl -T` any readable file to any
+ * host. Nothing here can stop a determined or injected agent from exfiltrating,
+ * because it never needed our upload path to do it.
+ *
+ * WHAT THIS ACTUALLY BUYS, stated so nobody over-trusts it:
+ *
+ *   - It stops ACCIDENTS. An agent casually sending `~/.aws/credentials`
+ *     because it seemed relevant is the common case, and this prevents it.
+ *   - It keeps the credentialed path deliberate. Sending through OUR upload,
+ *     with the operator's workspace credential, requires an explicit act rather
+ *     than being the path of least resistance.
+ *   - It is an AUDIT SURFACE. Approvals are visible in `yolo-bridge status`, so
+ *     a grant that was widened — by the operator or by an agent — is legible
+ *     rather than silent.
+ *
+ * WHAT IT DOES NOT BUY: protection against a cloud-originated prompt injection
+ * that instructs the agent to widen the list first. If that threat is the one
+ * that matters, the approval has to come from a channel the LOCAL AGENT cannot
+ * reach — the operator approving in their own authenticated webapp session
+ * would qualify, since an injected local agent cannot click it. That is a
+ * different design, deliberately not this one, and it still would not stop
+ * `curl`.
+ */
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import { configDir, loadAttachment as loadAttachmentDefault, defaultIO } from './config-store.js';
+function approvalsPath(env) {
+    return path.join(configDir(env), 'approved-paths.json');
+}
+export const defaultResolver = {
+    realpath(p) {
+        try {
+            return fs.realpathSync(p);
+        }
+        catch {
+            return undefined;
+        }
+    },
+    isDirectory(p) {
+        try {
+            return fs.statSync(p).isDirectory();
+        }
+        catch {
+            return false;
+        }
+    },
+};
+/**
+ * Is `candidate` inside `root`?
+ *
+ * ⚠️ BOTH SIDES MUST ALREADY BE REALPATHS. This function does no resolution —
+ * that is the caller's job — because the containment check is worthless on
+ * unresolved input: a symlink sitting inside an approved directory and pointing
+ * at `~/.ssh/id_rsa` passes a naive `startsWith` every time.
+ *
+ * The separator is not decoration either. Without it an approval of
+ * `/home/yolo/projA` also covers `/home/yolo/projA-secrets`.
+ */
+export function isWithinRoot(candidateRealpath, rootRealpath) {
+    if (candidateRealpath === rootRealpath)
+        return true;
+    const root = rootRealpath.endsWith(path.sep) ? rootRealpath : rootRealpath + path.sep;
+    return candidateRealpath.startsWith(root);
+}
+export function loadApprovals(env = process.env, io = defaultIO) {
+    const raw = io.readFile(approvalsPath(env));
+    if (!raw)
+        return [];
+    try {
+        const parsed = JSON.parse(raw);
+        if (!Array.isArray(parsed?.approvals))
+            return [];
+        return parsed.approvals.filter((a) => !!a && typeof a.path === 'string' && typeof a.workspaceId === 'string');
+    }
+    catch {
+        // A corrupt list must not be read as "everything is approved". Empty is the
+        // safe reading, and the operator can re-add.
+        return [];
+    }
+}
+function saveApprovals(approvals, env = process.env, io = defaultIO) {
+    io.writeFile(approvalsPath(env), `${JSON.stringify({ approvals }, null, 2)}\n`);
+}
+/**
+ * Approve a path for one workspace.
+ *
+ * Resolved and existence-checked HERE rather than at send time, so the operator
+ * finds out about a typo now instead of when a send mysteriously fails.
+ */
+export function approvePath(rawPath, workspaceId, env = process.env, io = defaultIO, resolver = defaultResolver, now = () => new Date()) {
+    const resolved = resolver.realpath(path.resolve(rawPath));
+    if (!resolved) {
+        return { ok: false, message: `No such path: ${rawPath}` };
+    }
+    const existing = loadApprovals(env, io);
+    if (existing.some((a) => a.workspaceId === workspaceId && a.path === resolved)) {
+        return {
+            ok: true,
+            alreadyPresent: true,
+            approved: existing.find((a) => a.workspaceId === workspaceId && a.path === resolved),
+        };
+    }
+    const approved = {
+        path: resolved,
+        raw: rawPath,
+        workspaceId,
+        approvedAt: now().toISOString(),
+    };
+    saveApprovals([...existing, approved], env, io);
+    return { ok: true, approved, alreadyPresent: false };
+}
+/** Remove one approval. Matches on the RESOLVED path, so removing by the same
+ *  spelling the operator approved with works even through a symlink. */
+export function revokePath(rawPath, workspaceId, env = process.env, io = defaultIO, resolver = defaultResolver) {
+    // Match on the RESOLVED path only. Matching the stored `raw` spelling as well
+    // looked convenient and was data loss: approving `output` from two different
+    // working directories stores two distinct resolved paths with the SAME raw
+    // spelling, so revoking either removed both. (codex P2, gpt-5.6-sol.)
+    //
+    // Two candidates, because an approved directory may since have been deleted —
+    // realpath then fails, and the operator must still be able to revoke the
+    // dangling grant by its absolute path.
+    const absolute = path.resolve(rawPath);
+    const resolved = resolver.realpath(absolute);
+    const before = loadApprovals(env, io);
+    const after = before.filter((a) => {
+        if (a.workspaceId !== workspaceId)
+            return true;
+        return !(a.path === absolute || (resolved !== undefined && a.path === resolved));
+    });
+    if (after.length !== before.length)
+        saveApprovals(after, env, io);
+    return { removed: before.length - after.length };
+}
+export function listApprovals(workspaceId, env = process.env, io = defaultIO) {
+    return loadApprovals(env, io).filter((a) => a.workspaceId === workspaceId);
+}
+/**
+ * May the AGENT send this path?
+ *
+ * A check against a MISTAKE, not against an adversary — see the module header.
+ * The agent can rewrite the list this consults.
+ *
+ * `implicitRoots` is the daemon's own working directory: the project the agent
+ * is already operating in, whose files it can read anyway. Everything else
+ * needs an explicit `yolo-bridge allow`.
+ *
+ * Fails closed on anything it cannot resolve — a path that does not exist, or a
+ * broken symlink, is not approved.
+ */
+export function checkPathApproved(rawPath, workspaceId, implicitRoots = [], env = process.env, io = defaultIO, resolver = defaultResolver) {
+    const resolved = resolver.realpath(path.resolve(rawPath));
+    if (!resolved)
+        return { approved: false, reason: `No such file: ${rawPath}` };
+    // Implicit roots are resolved too — the working directory can itself be
+    // reached through a symlink.
+    const roots = [];
+    for (const r of implicitRoots) {
+        const rr = resolver.realpath(path.resolve(r));
+        if (rr)
+            roots.push(rr);
+    }
+    for (const a of loadApprovals(env, io)) {
+        if (a.workspaceId === workspaceId)
+            roots.push(a.path);
+    }
+    for (const root of roots) {
+        if (isWithinRoot(resolved, root))
+            return { approved: true, root, resolvedPath: resolved };
+    }
+    return {
+        approved: false,
+        reason: `${path.basename(resolved)} is outside every approved path for this workspace. `
+            + 'Approve it from your own shell with `yolo-bridge allow <path>`.',
+    };
+}
+/**
+ * POSIX single-quoting for a path we print back as a COPYABLE command.
+ *
+ * Media directories routinely contain spaces (`~/My Footage/`), which alone
+ * makes an unquoted suggestion wrong. The sharper reason is that a path is
+ * attacker-influenceable in a way the operator would not expect — an agent can
+ * create a directory — and an unquoted `;` in a line the operator copies runs.
+ * Single quotes are literal in POSIX shells; the `'\''` dance closes, escapes
+ * one quote, and reopens. (codex P2, gpt-5.6-sol.)
+ */
+export function shellQuote(value) {
+    return `'${value.replace(/'/g, `'\\''`)}'`;
+}
+/**
+ * `yolo-bridge allow` — add, list or remove an approved path.
+ *
+ * Requires an attachment, because an approval is scoped to ONE workspace. A
+ * machine that attaches to several workspaces should not have a grant made for
+ * one silently apply to the others.
+ */
+export function runAllow(args, deps = {}) {
+    const { env, io, resolver } = deps;
+    const loadAttachmentFn = deps.loadAttachmentImpl
+        ?? ((e, i) => loadAttachmentDefault(e, i));
+    const attachment = loadAttachmentFn(env, io);
+    if (!attachment) {
+        return {
+            ok: false,
+            reason: 'not-attached',
+            message: 'No active attachment — run `yolo-bridge attach` first. Approvals are scoped to one workspace.',
+        };
+    }
+    const workspaceId = attachment.workspaceId;
+    if (args.includes('--list') || args.length === 0) {
+        const approvals = listApprovals(workspaceId, env, io);
+        if (!approvals.length) {
+            return {
+                ok: true,
+                lines: [
+                    'No approved paths for this workspace.',
+                    '',
+                    'The attached agent can send files from the daemon\'s working directory.',
+                    'To let it send from anywhere else:  yolo-bridge allow <path>',
+                ],
+            };
+        }
+        return {
+            ok: true,
+            lines: [
+                `Approved paths (${approvals.length}) — the attached agent may send files from these:`,
+                ...approvals.map((a) => `  ${a.path}${a.raw !== a.path ? `   (added as ${a.raw})` : ''}`),
+            ],
+        };
+    }
+    const removeIdx = args.indexOf('--remove');
+    if (removeIdx !== -1) {
+        const target = args[removeIdx + 1];
+        if (!target)
+            return { ok: false, reason: 'error', message: '`--remove` needs a path.' };
+        const { removed } = revokePath(target, workspaceId, env, io, resolver);
+        return removed
+            ? { ok: true, lines: [`Removed ${removed} approval(s) for ${target}.`] }
+            : { ok: false, reason: 'error', message: `${target} was not an approved path for this workspace.` };
+    }
+    const target = args.find((a) => !a.startsWith('-'));
+    if (!target)
+        return { ok: false, reason: 'error', message: 'A path is required.' };
+    const result = approvePath(target, workspaceId, env, io, resolver);
+    if (!result.ok)
+        return { ok: false, reason: 'error', message: result.message };
+    if (result.alreadyPresent) {
+        return { ok: true, lines: [`Already approved: ${result.approved.path}`] };
+    }
+    return {
+        ok: true,
+        lines: [
+            `Approved: ${result.approved.path}`,
+            'The attached agent may now send files from here. Remove it with:',
+            // The RESOLVED path, not what was typed: a relative spelling is ambiguous
+            // across working directories, and pasting it later could revoke a
+            // different grant than the one just made.
+            `  yolo-bridge allow --remove ${shellQuote(result.approved.path)}`,
+        ],
+    };
+}

package/dist/cli.js

@@ -23,6 +23,7 @@ import { hostname } from 'node:os';
 import { runLogin } from './login-cmd.js';
 import { runAttachFromDisk, pickWorkspaceFromDisk } from './attach-cmd.js';
 import { runShare } from './share-cmd.js';
+import { runAllow } from './approved-paths.js';
 import { runDetach } from './detach-cmd.js';
 import { getStatus, formatStatus } from './status-cmd.js';
 import { startLocalAgent, stopLocalAgent, DEFAULT_AGENT_BIN } from './local-agent.js';
@@ -100,6 +101,9 @@ function printHelp() {
         '                         RESUMES it (same tile) instead of adding a duplicate; --fresh skips',
         '                         that check entirely.',
         '  detach                 Detach the current workspace attachment.',
+        '  allow <path>           Let the ATTACHED AGENT send files from this path. You type',
+        '                         this; nothing in the cloud can. Also --list and --remove <path>.',
+        '                         The daemon\'s own working directory is always allowed.',
         '  share <path>           Share a local file with the attached workspace, so a cloud',
         '                         agent can see it. Push only — nothing reads your disk remotely.',
         '  status                 Print local login/attach state.',
@@ -550,6 +554,15 @@ function cmdStatus() {
     process.stdout.write(`${formatStatus(getStatus())}\n`);
     return 0;
 }
+function cmdAllow(args) {
+    const result = runAllow(args);
+    if (!result.ok) {
+        process.stderr.write(`yolo-bridge allow: ${result.message}\n`);
+        return 1;
+    }
+    process.stdout.write(`${result.lines.join('\n')}\n`);
+    return 0;
+}
 async function cmdShare(args) {
     const rawPath = args[0];
     if (!rawPath || rawPath.startsWith('-')) {
@@ -619,6 +632,8 @@ async function main() {
             return cmdAttach(rest);
         case 'detach':
             return cmdDetach();
+        case 'allow':
+            return cmdAllow(rest);
         case 'share':
             return cmdShare(rest);
         case 'status':

package/dist/status-cmd.js

@@ -22,6 +22,7 @@
  * longer invisible just because it can't be printed to the screen.
  */
 import { loadAuth, loadAttachment } from './config-store.js';
+import { listApprovals } from './approved-paths.js';
 import { loadConnectionState, formatConnectionEvent } from './connection-state.js';
 export function getStatus(deps = {}) {
     const now = deps.now ?? Date.now;
@@ -31,6 +32,11 @@ export function getStatus(deps = {}) {
         loggedIn: Boolean(auth),
         attached: Boolean(attachment),
     };
+    if (attachment) {
+        const approvals = listApprovals(attachment.workspaceId, deps.env, deps.io);
+        if (approvals.length)
+            report.approvedPaths = approvals.map((a) => a.path);
+    }
     if (auth) {
         report.tokenExpiresAtMs = auth.expiresAtMs;
         report.tokenExpired = auth.expiresAtMs <= now();
@@ -78,5 +84,11 @@ export function formatStatus(report) {
             }
         }
     }
+    if (report.approvedPaths?.length) {
+        lines.push(`Agent may send files from (${report.approvedPaths.length} approved path(s)):`);
+        for (const p of report.approvedPaths)
+            lines.push(`  ${p}`);
+        lines.push('(plus the daemon\'s working directory. Change with `yolo-bridge allow`.)');
+    }
     return lines.join('\n');
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yolo-labs/yolobridge",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "YoloBridge — local coding-agent daemon that attaches a user's own Claude Code/Codex session to a YOLO Studio workspace as a first-class tile (docs/YOLOBRIDGE_PLAN.md, build-order Phase 5).",
   "license": "MIT",
   "type": "module",