@yolo-croket-dev/amqp-access 0.7.257 → 0.7.258

package/manage-service/dto/exchange-rate/query/get-exchange-rate-by-country-code.dto.d.ts

@@ -10,8 +10,18 @@ export interface GetExchangeRateByCountryCodeResult {
     exchangeRate?: number;
     currencyCode?: string;
 }
-export type ExchangeRateBaseDate = string;
-export type ExchangeRateCurrencyCode = Uppercase<string>;
+type AsciiDigit = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
+type IsExactEightAsciiDigits<Value extends string, Digits extends unknown[] = []> = Value extends '' ? Digits['length'] extends 8 ? true : false : Digits['length'] extends 8 ? false : Value extends `${AsciiDigit}${infer Rest}` ? IsExactEightAsciiDigits<Rest, [...Digits, unknown]> : false;
+export type ExchangeRateBaseDateLiteral<Value extends string> = string extends Value ? Value : IsExactEightAsciiDigits<Value> extends true ? Value : never;
+type ExchangeRateBaseDateInput<Value extends string> = string extends Value ? unknown : ExchangeRateBaseDateLiteral<Value> extends never ? {
+    readonly exchangeRateBaseDateMustBeExactlyEightAsciiDigits: never;
+} : unknown;
+declare const exchangeRateBaseDateBrand: unique symbol;
+export type ExchangeRateBaseDate = string & {
+    readonly [exchangeRateBaseDateBrand]: 'ExchangeRateBaseDate';
+};
+type UppercaseAsciiLetter = 'A' | 'B' | 'C' | 'D' | 'E' | 'F' | 'G' | 'H' | 'I' | 'J' | 'K' | 'L' | 'M' | 'N' | 'O' | 'P' | 'Q' | 'R' | 'S' | 'T' | 'U' | 'V' | 'W' | 'X' | 'Y' | 'Z';
+export type ExchangeRateCurrencyCode = `${UppercaseAsciiLetter}${UppercaseAsciiLetter}${UppercaseAsciiLetter}`;
 export type GetExchangeRateByCountryCodeExactResult = {
     readonly isSupported: true;
     readonly baseDate: ExchangeRateBaseDate;
@@ -20,4 +30,7 @@ export type GetExchangeRateByCountryCodeExactResult = {
 } | {
     readonly isSupported: false;
 };
+export declare function isExchangeRateBaseDate(value: string): value is ExchangeRateBaseDate;
+export declare function toExchangeRateBaseDate<const Value extends string>(value: Value & ExchangeRateBaseDateInput<Value>): ExchangeRateBaseDate;
 export declare function isGetExchangeRateByCountryCodeExactResult(value: unknown): value is GetExchangeRateByCountryCodeExactResult;
+export {};

package/manage-service/dto/exchange-rate/query/get-exchange-rate-by-country-code.dto.js

@@ -9,7 +9,7 @@ var __metadata = (this && this.__metadata) || function (k, v) {
     if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isGetExchangeRateByCountryCodeExactResult = exports.GetExchangeRateByCountryCodePayload = void 0;
+exports.isGetExchangeRateByCountryCodeExactResult = exports.toExchangeRateBaseDate = exports.isExchangeRateBaseDate = exports.GetExchangeRateByCountryCodePayload = void 0;
 const class_validator_1 = require("class-validator");
 class GetExchangeRateByCountryCodePayload {
 }
@@ -26,6 +26,17 @@ __decorate([
 function isObjectRecord(value) {
     return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
+function isExchangeRateBaseDate(value) {
+    return /^\d{8}$/.test(value);
+}
+exports.isExchangeRateBaseDate = isExchangeRateBaseDate;
+function toExchangeRateBaseDate(value) {
+    if (!isExchangeRateBaseDate(value)) {
+        throw new TypeError('Exchange-rate baseDate must be exactly eight ASCII digits');
+    }
+    return value;
+}
+exports.toExchangeRateBaseDate = toExchangeRateBaseDate;
 function isGetExchangeRateByCountryCodeExactResult(value) {
     if (!isObjectRecord(value)) {
         return false;
@@ -37,7 +48,7 @@ function isGetExchangeRateByCountryCodeExactResult(value) {
     return value.isSupported === true
         && keys.join(',') === 'baseDate,currencyCode,exchangeRate,isSupported'
         && typeof value.baseDate === 'string'
-        && /^\d{8}$/.test(value.baseDate)
+        && isExchangeRateBaseDate(value.baseDate)
         && typeof value.currencyCode === 'string'
         && /^[A-Z]{3}$/.test(value.currencyCode)
         && typeof value.exchangeRate === 'number'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yolo-croket-dev/amqp-access",
-  "version": "0.7.257",
+  "version": "0.7.258",
   "main": "index.js",
   "author": "Yolo Co., Ltd.",
   "description": "크로켓 amqp-access npm",
@@ -9,7 +9,7 @@
   ],
   "scripts": {
     "build": "node ../../node_modules/typescript/bin/tsc",
-    "lint": "eslint \"manage-service/**/*.ts\" --ignore-pattern \"**/*.d.ts\"",
+    "lint": "eslint --no-error-on-unmatched-pattern src/**/*.ts",
     "fix": "eslint --fix src/**/*.ts",
     "clean": "node ../../node_modules/typescript/bin/tsc --build --clean",
     "prepublishOnly": "npm run build",
@@ -23,7 +23,7 @@
     "@yolo-croket-dev/domain": "0.2.40",
     "@yolo-croket-dev/dto-v2": "0.2.23",
     "@yolo-croket-dev/entity": "0.2.98",
-    "@yolo-croket-dev/entity-v2": "0.3.16",
+    "@yolo-croket-dev/entity-v2": "0.3.17",
     "class-transformer": "^0.5.1",
     "class-validator": "^0.13.2",
     "dotenv": "^16.3.1"

package/scripts/verify-exchange-rate-contract.mjs

@@ -22,8 +22,8 @@ const compileOptions = [
   '--resolveJsonModule',
 ];
 
-function runTypeFixture(name, expectedExitCode) {
-  const result = spawnSync(
+function compileTypeFixture(name) {
+  return spawnSync(
     process.execPath,
     [
       'node_modules/typescript/bin/tsc',
@@ -32,8 +32,23 @@ function runTypeFixture(name, expectedExitCode) {
     ],
     { cwd: resolve(packageRoot, '../..'), encoding: 'utf8' },
   );
-  if (result.status !== expectedExitCode) {
-    throw new Error(`${name}: expected tsc exit ${expectedExitCode}, got ${result.status}`);
+}
+
+function assertTypeFixturePasses(name) {
+  const result = compileTypeFixture(name);
+  if (result.status !== 0) {
+    throw new Error(`${name}: expected tsc exit 0, got ${result.status}`);
+  }
+}
+
+function assertTypeFixtureFails(name, expectedDiagnostic) {
+  const result = compileTypeFixture(name);
+  const output = `${result.stdout}${result.stderr}`;
+  if (result.status === 0) {
+    throw new Error(`${name}: expected tsc failure for ${expectedDiagnostic}`);
+  }
+  if (!expectedDiagnostic.test(output)) {
+    throw new Error(`${name}: missing expected diagnostic ${expectedDiagnostic}`);
   }
 }
 
@@ -42,22 +57,23 @@ function readJsonFixture(name) {
 }
 
 for (const name of ['legacy-compatibility', 'supported-usd', 'supported-cad', 'supported-jpy', 'unsupported-only']) {
-  runTypeFixture(name, 0);
+  assertTypeFixturePasses(name);
 }
 
-for (const name of ['missing-field', 'bad-currency', 'unsupported-extra-key']) {
-  const result = spawnSync(
-    process.execPath,
-    [
-      'node_modules/typescript/bin/tsc',
-      ...compileOptions,
-      resolve(fixtureRoot, `${name}.ts`),
-    ],
-    { cwd: resolve(packageRoot, '../..'), encoding: 'utf8' },
-  );
-  if (result.status === 0) {
-    throw new Error(`${name}: expected type fixture failure`);
-  }
+for (const [name, expectedDiagnostic] of [
+  ['missing-field', /Property 'currencyCode' is missing/],
+  ['bad-currency', /Type '"usd"' is not assignable/],
+  ['bad-currency-digit', /Type '"US1"' is not assignable/],
+  ['bad-currency-short', /Type '"US"' is not assignable/],
+  ['bad-currency-long', /Type '"USDX"' is not assignable/],
+  ['bad-date', /Argument of type '"2026-08-10"'[\s\S]*exchangeRateBaseDateMustBeExactlyEightAsciiDigits/],
+  ['bad-date-short', /Argument of type '"2026081"'[\s\S]*exchangeRateBaseDateMustBeExactlyEightAsciiDigits/],
+  ['bad-date-long', /Argument of type '"202608100"'[\s\S]*exchangeRateBaseDateMustBeExactlyEightAsciiDigits/],
+  ['bad-date-alpha', /Argument of type '"20260A10"'[\s\S]*exchangeRateBaseDateMustBeExactlyEightAsciiDigits/],
+  ['bad-date-fullwidth', /Argument of type '"２０２６０８１０"'[\s\S]*exchangeRateBaseDateMustBeExactlyEightAsciiDigits/],
+  ['unsupported-extra-key', /'baseDate' does not exist/],
+]) {
+  assertTypeFixtureFails(name, expectedDiagnostic);
 }
 
 const packageBuild = spawnSync(
@@ -83,15 +99,22 @@ for (const name of ['valid-usd', 'valid-cad', 'valid-jpy', 'unsupported-only'])
   }
 }
 
-for (const value of [
-  readJsonFixture('bad-rate'),
-  { isSupported: true, baseDate: '20260810', exchangeRate: Number.POSITIVE_INFINITY, currencyCode: 'USD' },
-  readJsonFixture('bad-date'),
-  readJsonFixture('bad-currency'),
-  readJsonFixture('unsupported-extra-key'),
+for (const [name, value, field] of [
+  ['bad-rate', readJsonFixture('bad-rate'), 'exchangeRate'],
+  ['bad-nonfinite-rate', { isSupported: true, baseDate: '20260810', exchangeRate: Number.POSITIVE_INFINITY, currencyCode: 'USD' }, 'exchangeRate'],
+  ['bad-date', readJsonFixture('bad-date'), 'baseDate'],
+  ['bad-date-short', { isSupported: true, baseDate: '2026081', exchangeRate: 10.25, currencyCode: 'USD' }, 'baseDate'],
+  ['bad-date-long', { isSupported: true, baseDate: '202608100', exchangeRate: 10.25, currencyCode: 'USD' }, 'baseDate'],
+  ['bad-date-alpha', { isSupported: true, baseDate: '20260A10', exchangeRate: 10.25, currencyCode: 'USD' }, 'baseDate'],
+  ['bad-date-fullwidth', { isSupported: true, baseDate: '２０２６０８１０', exchangeRate: 10.25, currencyCode: 'USD' }, 'baseDate'],
+  ['bad-currency', readJsonFixture('bad-currency'), 'currencyCode'],
+  ['bad-currency-digit', { isSupported: true, baseDate: '20260810', exchangeRate: 10.25, currencyCode: 'US1' }, 'currencyCode'],
+  ['bad-currency-short', { isSupported: true, baseDate: '20260810', exchangeRate: 10.25, currencyCode: 'US' }, 'currencyCode'],
+  ['bad-currency-long', { isSupported: true, baseDate: '20260810', exchangeRate: 10.25, currencyCode: 'USDX' }, 'currencyCode'],
+  ['unsupported-extra-key', readJsonFixture('unsupported-extra-key'), 'unsupported key set'],
 ]) {
   if (isGetExchangeRateByCountryCodeExactResult(value)) {
-    throw new Error(`invalid runtime fixture accepted: ${JSON.stringify(value)}`);
+    throw new Error(`${name}: runtime validation accepted invalid ${field}`);
   }
 }