@yolk-sdk/agent 0.1.0-canary.21 → 0.1.0-canary.23

package/src/providers/openai/codex-provider.ts

@@ -12,6 +12,7 @@ import {
   AgentUsage,
   ToolCall,
   attachmentSourceDataUrl,
+  attachmentSourceUrl,
   assistantContent,
   assistantHostToolCalls,
   contentParts,
@@ -43,6 +44,7 @@ import {
   providerFailureCause,
   providerFailureRetryable
 } from '../provider-error.ts'
+import { validateProviderTranscript } from '../transcript.ts'
 
 export type OpenAiCodexReasoningSummary = 'auto' | 'concise' | 'detailed'
 
@@ -263,7 +265,7 @@ const userPartToCodexInputPart = (
     case 'Text':
       return Effect.succeed({ type: 'input_text', text: part.text })
     case 'Image':
-      return Option.match(attachmentSourceDataUrl(part.source, part.mimeType), {
+      return Option.match(attachmentSourceUrl(part.source, part.mimeType), {
         onNone: () => Effect.fail(unsupportedContentError('Unresolved image source')),
         onSome: url => Effect.succeed({
           type: 'input_image',
@@ -377,6 +379,7 @@ export const toOpenAiCodexRequestBody = (
   }
 ): Effect.Effect<OpenAiCodexRequestBody, LLMError> =>
   Effect.gen(function* () {
+    yield* validateProviderTranscript(request.messages)
     const input = Arr.flatten(yield* Effect.forEach(request.messages, messageToCodexInput))
 
     const body: Omit<OpenAiCodexRequestBody, 'tools'> = {

package/src/providers/openai/provider.ts

@@ -12,8 +12,8 @@ import {
   AgentInputUsage,
   AgentOutputUsage,
   AgentUsage,
-  attachmentSourceDataUrl,
   attachmentSourceText,
+  attachmentSourceUrl,
   assistantContent,
   assistantHostToolCalls,
   isTextDocumentMimeType,
@@ -40,6 +40,7 @@ import {
   providerFailureCause,
   providerFailureRetryable
 } from '../provider-error.ts'
+import { validateProviderTranscript } from '../transcript.ts'
 
 export type OpenAiProviderConfig = {
   readonly chatCompletionsUrl?: string
@@ -228,7 +229,7 @@ const contentPartToUserPart = (
     case 'Text':
       return Effect.succeed({ type: 'text', text: part.text })
     case 'Image':
-      return Option.match(attachmentSourceDataUrl(part.source, part.mimeType), {
+      return Option.match(attachmentSourceUrl(part.source, part.mimeType), {
         onNone: () => Effect.fail(unsupportedContentError('Unresolved image source')),
         onSome: url => Effect.succeed({ type: 'image_url', image_url: { url } })
       })
@@ -340,6 +341,7 @@ export const toOpenAiRequestBody = (
   config?: { readonly maxCompletionTokens?: number }
 ): Effect.Effect<OpenAiRequestBody, LLMError> =>
   Effect.gen(function* () {
+    yield* validateProviderTranscript(request.messages)
     const systemMessage: OpenAiMessage = { role: 'system', content: request.systemPrompt }
     const requestMessages = yield* Effect.forEach(request.messages, toOpenAiMessage)
     const messages = [systemMessage, ...requestMessages]

package/src/providers/transcript.ts

@@ -0,0 +1,24 @@
+import { Effect } from 'effect'
+import {
+  validateNoDanglingHostToolCalls,
+  type AgentMessage
+} from '@yolk-sdk/agent/protocol'
+import { LLMError } from '@yolk-sdk/agent/loop'
+
+export const validateProviderTranscript = (
+  messages: ReadonlyArray<AgentMessage>
+): Effect.Effect<void, LLMError> => {
+  const validation = validateNoDanglingHostToolCalls(messages)
+
+  if (validation._tag === 'Valid') {
+    return Effect.void
+  }
+
+  return Effect.fail(
+    new LLMError({
+      cause: 'validation_error',
+      message: validation.message,
+      retryable: false
+    })
+  )
+}

package/src/tools/README.md

@@ -41,8 +41,9 @@ return Effect.fail(modelVisibleToolError({
 }))
 ```
 
-Use `ToolError` for fatal runtime/tool infrastructure failures such as broken wiring, auth/config,
-storage outages, or implementation bugs.
+Thrown `ToolError`s become model-visible failed tool results plus `ToolExecutionError` events,
+so keep messages safe and non-secret. Reserve stream failure for provider/runtime defects,
+aborts, and implementation bugs outside typed tool execution.
 
 ## Task subagents