@yiln-dsh/dsh-plugin-file-explorer 0.5.1 → 0.6.0

package/README.md

@@ -36,7 +36,7 @@ A DSH `dsh.bundle` that contributes a workspace file explorer page to the
 
 ## Install
 
-The package version is `@yiln-dsh/dsh-plugin-file-explorer@0.5.1`.
+The package version is `@yiln-dsh/dsh-plugin-file-explorer@0.6.0`.
 
 The right-panel package must be installed in the same `web` profile:
 
@@ -53,7 +53,7 @@ pnpm pack
 ```
 
 ```bash
-dsh plugin --profile web add ./yiln-dsh-dsh-plugin-file-explorer-0.5.1.tgz
+dsh plugin --profile web add ./yiln-dsh-dsh-plugin-file-explorer-0.6.0.tgz
 ```
 
 ### npm package
@@ -76,8 +76,10 @@ apply the new profile composition.
 - The Host falls back to `sandboxPolicy.workspaceRoot` when no path is passed,
   and returns `{ ok, path, parent, entries }` JSON — never live objects.
 - `read` previews up to 1 MiB of UTF-8 text or 16 MiB of recognized images;
-  image previews return a data URL for inline rendering. `download` returns a
-  base64 data URL (64 MiB cap) that the browser triggers with `<a download>`.
+  image previews return a data URL for inline rendering. `download` is a GET
+  route (`/_dsh/file-explorer/download?path=...`) that streams the file
+  natively (`Content-Disposition: attachment`) — no base64, no JSON body, no
+  size ceiling. The browser triggers it with a transient `<a download>` link.
 - `delete` removes regular files (`rm -f`) and directories recursively
   (`rm -rf`); both are called only after a second-click confirm in the UI.
 - Git routes are read-only. They resolve the repository root with

package/client.js

@@ -1515,25 +1515,21 @@ window.__ModuleLoader__.load({
 
 				const downloadFile = (entry) => {
 					setPendingDelete(null)
-					api('download', { path: entry.path })
-						.then((raw) => {
-							if (!raw || raw.ok !== true) {
-								const message = raw && typeof raw.error === 'string' ? raw.error : t('files.downloadFailed')
-								setError(message)
-								return
-							}
-							try {
-								const link = document.createElement('a')
-								link.href = raw.dataUrl
-								link.download = entry.name
-								document.body.appendChild(link)
-								link.click()
-								link.remove()
-							} catch (err) {
-								setError(err && typeof err.message === 'string' ? err.message : String(err))
-							}
-						})
-						.catch((err) => setError(err && typeof err.message === 'string' ? err.message : String(err)))
+					// Native streaming download: navigate to the Host route, which
+					// streams the file with `Content-Disposition: attachment`. The
+					// browser handles the download natively — no JSON data URL, no
+					// base64, no full-file buffering in page memory.
+					try {
+						const query = new URLSearchParams({ path: entry.path })
+						const link = document.createElement('a')
+						link.href = `/_dsh/file-explorer/download?${query.toString()}`
+						link.download = entry.name
+						document.body.appendChild(link)
+						link.click()
+						link.remove()
+					} catch (err) {
+						setError(err && typeof err.message === 'string' ? err.message : String(err))
+					}
 				}
 
 				const requestDelete = (entry) => {

package/index.js

@@ -1,9 +1,11 @@
+import { createReadStream } from 'node:fs'
+
 /**
  * dsh-plugin-file-explorer — Host half (static DSH bundle).
  *
  * Registers exact HTTP routes under /_dsh/file-explorer for the browser
- * bundle: list (with parent path), read (text/image preview), download (data URL),
- * and delete.
+ * bundle: list (with parent path), read (text/image preview), download
+ * (native streaming), and delete.
  */
 
 function parentOf(path) {
@@ -190,29 +192,52 @@ export function apply(ctx) {
   })
 
   addRoute('/_dsh/file-explorer/download', async (req, res) => {
-    if (req.method === 'POST') req = await readJson(req)
+    const url = new URL(req.url || '/', 'http://dsh.local')
+    const requestedPath = url.searchParams.get('path')
     const fs = ctx.get('fs')
     if (fs === undefined) {
       sendJson(res, 200, { ok: false, error: 'filesystem service unavailable' })
       return
     }
-    if (typeof req.path !== 'string') {
+    if (typeof requestedPath !== 'string' || requestedPath.trim() === '') {
       sendJson(res, 200, { ok: false, error: 'missing file path' })
       return
     }
 
     try {
-      const target = await fs.resolve(req.path)
+      const target = await fs.resolve(requestedPath)
       const info = await fs.stat(target)
-      const size = info && typeof info.size === 'number' ? info.size : null
-      const limit = 64 * 1024 * 1024
-      if (size !== null && size > limit) {
-        sendJson(res, 200, { ok: false, error: 'file too large for explorer download' })
+      if (info === undefined || info.type !== 'file') {
+        sendJson(res, 200, { ok: false, error: 'file does not exist' })
         return
       }
-      const bytes = await fs.readBytes(target, undefined, limit)
-      const name = target.displayPath.split('/').pop()
-      sendJson(res, 200, { ok: true, name, size, dataUrl: `data:${guessMime(name)};base64,${bytesToBase64(bytes)}` })
+      const size = typeof info.size === 'number' && Number.isFinite(info.size) && info.size >= 0 ? info.size : 0
+      const name = target.displayPath.split('/').pop() || 'download'
+      const safeName = String(name).replace(/[\r\n"\\]/gu, '_').replace(/[^\x20-\x7e]/gu, '_') || 'download'
+      const encodedName = encodeURIComponent(String(name)).replace(/['()]/gu, (value) => `%${value.charCodeAt(0).toString(16).toUpperCase()}`)
+
+      res.writeHead(200, {
+        'content-type': guessMime(name),
+        'content-disposition': `attachment; filename="${safeName}"; filename*=UTF-8''${encodedName}`,
+        'content-length': size,
+        'x-content-type-options': 'nosniff',
+        'cache-control': 'no-store',
+      })
+
+      // Native streaming download: pipe the resolved host path straight to the
+      // HTTP response. No full-file buffering, no base64, no 64 MiB ceiling.
+      const stream = createReadStream(fs.processPath(target))
+      stream.on('error', (error) => {
+        if (res.headersSent) res.destroy(error)
+        else {
+          try {
+            sendJson(res, 500, { ok: false, error: `failed to stream file: ${error && typeof error.message === 'string' ? error.message : String(error)}` })
+          } catch {
+            res.destroy(error)
+          }
+        }
+      })
+      stream.pipe(res)
     } catch (error) {
       sendJson(res, 200, { ok: false, error: error && typeof error.message === 'string' ? error.message : String(error) })
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yiln-dsh/dsh-plugin-file-explorer",
-  "version": "0.5.1",
+  "version": "0.6.0",
   "publishConfig": {
     "access": "public"
   },