@yemi33/squad 0.1.15 → 0.1.17

package/dashboard.js

@@ -1394,6 +1394,54 @@ server.listen(PORT, '127.0.0.1', () => {
     console.log(`  Could not auto-open browser: ${e.message}`);
     console.log(`  Please open http://localhost:${PORT} manually.`);
   }
+
+  // ─── Engine Watchdog ─────────────────────────────────────────────────────
+  // Every 30s, check if engine PID is alive. If dead but control.json says
+  // running, auto-restart it. Prevents silent engine death.
+  const { execSync, spawn: cpSpawn } = require('child_process');
+  setInterval(() => {
+    try {
+      const control = getEngineState();
+      if (control.state !== 'running' || !control.pid) return;
+
+      // Check if PID is alive
+      let alive = false;
+      try {
+        if (process.platform === 'win32') {
+          const out = execSync(`tasklist /FI "PID eq ${control.pid}" /NH`, { encoding: 'utf8', timeout: 3000 });
+          alive = out.includes(String(control.pid));
+        } else {
+          process.kill(control.pid, 0); // signal 0 = check existence
+          alive = true;
+        }
+      } catch { alive = false; }
+
+      if (!alive) {
+        console.log(`[watchdog] Engine PID ${control.pid} is dead — auto-restarting...`);
+
+        // Set state to stopped first
+        const controlPath = path.join(SQUAD_DIR, 'engine', 'control.json');
+        safeWrite(controlPath, { state: 'stopped', pid: null, crashed_at: new Date().toISOString() });
+
+        // Restart engine
+        const childEnv = { ...process.env };
+        for (const key of Object.keys(childEnv)) {
+          if (key === 'CLAUDECODE' || key.startsWith('CLAUDE_CODE') || key.startsWith('CLAUDECODE_')) delete childEnv[key];
+        }
+        const engineProc = cpSpawn(process.execPath, [path.join(SQUAD_DIR, 'engine.js'), 'start'], {
+          cwd: SQUAD_DIR,
+          stdio: 'ignore',
+          detached: true,
+          env: childEnv,
+        });
+        engineProc.unref();
+        console.log(`[watchdog] Engine restarted (new PID: ${engineProc.pid})`);
+      }
+    } catch (e) {
+      console.error(`[watchdog] Error: ${e.message}`);
+    }
+  }, 30000);
+  console.log(`  Engine watchdog: active (checks every 30s)`);
 });
 
 server.on('error', e => {

package/engine.js

@@ -797,8 +797,9 @@ function spawnAgent(dispatchItem, config) {
     }
 
     // Post-completion: scan output for PRs and sync to pull-requests.json
+    let prsCreatedCount = 0;
     if (code === 0) {
-      syncPrsFromOutput(stdout, agentId, meta, config);
+      prsCreatedCount = syncPrsFromOutput(stdout, agentId, meta, config) || 0;
     }
 
     // Post-completion: update PR status if relevant
@@ -817,7 +818,7 @@ function spawnAgent(dispatchItem, config) {
     updateAgentHistory(agentId, dispatchItem, code === 0 ? 'success' : 'error');
 
     // Update quality metrics
-    updateMetrics(agentId, dispatchItem, code === 0 ? 'success' : 'error', taskUsage);
+    updateMetrics(agentId, dispatchItem, code === 0 ? 'success' : 'error', taskUsage, prsCreatedCount);
 
     // Cleanup temp files
     try { fs.unlinkSync(sysPromptPath); } catch {}
@@ -1322,7 +1323,7 @@ function syncPrsFromOutput(output, agentId, meta, config) {
     while ((match = prHeaderPattern.exec(content)) !== null) prMatches.add(match[1] || match[2]);
   }
 
-  if (prMatches.size === 0) return;
+  if (prMatches.size === 0) return 0;
 
   // Determine which project to add PRs to
   const projects = getProjects(config);
@@ -1385,6 +1386,7 @@ function syncPrsFromOutput(output, agentId, meta, config) {
     safeWrite(prPath, prs);
     log('info', `Synced ${added} PR(s) from ${agentName}'s output to ${targetProject.name}/pull-requests.json`);
   }
+  return added;
 }
 
 // ─── Post-Completion Hooks ──────────────────────────────────────────────────
@@ -1411,14 +1413,23 @@ function updatePrAfterReview(agentId, pr, project) {
     note: agentStatus.task || ''
   };
 
-  // Update author metrics
+  // Update author metrics (deduplicated per PR — don't double-count re-reviews)
   const authorAgentId = (pr.agent || '').toLowerCase();
   if (authorAgentId && config.agents?.[authorAgentId]) {
     const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
     const metrics = safeJson(metricsPath) || {};
     if (!metrics[authorAgentId]) metrics[authorAgentId] = { tasksCompleted:0, tasksErrored:0, prsCreated:0, prsApproved:0, prsRejected:0, reviewsDone:0, lastTask:null, lastCompleted:null };
-    if (squadVerdict === 'approved') metrics[authorAgentId].prsApproved++;
-    else if (squadVerdict === 'changes-requested') metrics[authorAgentId].prsRejected++;
+    if (!metrics[authorAgentId]._reviewedPrs) metrics[authorAgentId]._reviewedPrs = {};
+    const prevVerdict = metrics[authorAgentId]._reviewedPrs[pr.id];
+    if (prevVerdict !== squadVerdict) {
+      // Undo previous count if verdict changed (e.g. approved → changes-requested)
+      if (prevVerdict === 'approved') metrics[authorAgentId].prsApproved = Math.max(0, (metrics[authorAgentId].prsApproved || 0) - 1);
+      else if (prevVerdict === 'changes-requested') metrics[authorAgentId].prsRejected = Math.max(0, (metrics[authorAgentId].prsRejected || 0) - 1);
+      // Apply new verdict
+      if (squadVerdict === 'approved') metrics[authorAgentId].prsApproved++;
+      else if (squadVerdict === 'changes-requested') metrics[authorAgentId].prsRejected++;
+      metrics[authorAgentId]._reviewedPrs[pr.id] = squadVerdict;
+    }
     safeWrite(metricsPath, metrics);
   }
 
@@ -2002,7 +2013,7 @@ function createReviewFeedbackForAuthor(reviewerAgentId, pr, config) {
   log('info', `Created review feedback for ${authorAgentId} from ${reviewerAgentId} on ${pr.id}`);
 }
 
-function updateMetrics(agentId, dispatchItem, result, taskUsage) {
+function updateMetrics(agentId, dispatchItem, result, taskUsage, prsCreatedCount) {
   const metricsPath = path.join(ENGINE_DIR, 'metrics.json');
   const metrics = safeJson(metricsPath) || {};
 
@@ -2029,7 +2040,7 @@ function updateMetrics(agentId, dispatchItem, result, taskUsage) {
 
   if (result === 'success') {
     m.tasksCompleted++;
-    if (dispatchItem.type === 'implement') m.prsCreated++;
+    if (prsCreatedCount > 0) m.prsCreated = (m.prsCreated || 0) + prsCreatedCount;
     if (dispatchItem.type === 'review') m.reviewsDone++;
   } else {
     m.tasksErrored++;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/squad",
-  "version": "0.1.15",
+  "version": "0.1.17",
   "description": "Multi-agent AI dev team that runs from ~/.squad/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "squad": "bin/squad.js"