@yemi33/minions 0.1.983 → 0.1.985

package/CHANGELOG.md

@@ -1,8 +1,11 @@
 # Changelog
 
-## 0.1.983 (2026-04-15)
+## 0.1.985 (2026-04-15)
 
 ### Features
+- complete watches management — new conditions, CC actions, PROJECTS fix (#1103)
+- fix misleading poll frequency field labels in settings modal (#1099)
+- add Auto-complete PRs toggle to settings modal (#1095)
 -  gate build failure auto-fix behind autoFixBuilds flag
 - free-form interval input + CC create-watch action
 -  flush queued CC messages as single combined request
@@ -20,11 +23,9 @@
 -  Update command-center.js to capture tool inputs and use formatted summaries
 - certificate-based auth for Teams integration (#1027)
 -  Create render-utils.js with shared formatting helpers
--  add adoPollEnabled/ghPollEnabled engine settings
--  doc-chat abort kills LLM process + queued messages auto-process
-- add /api/work-items/reopen endpoint and reopen-work-item CC action (#982)
 
 ### Fixes
+- fix syncPrsFromOutput skipping tool_result lines where PR URLs live (#1100)
 - Remove autoReview flag — consolidate into evalLoop (#1093)
 - link scheduled task notes back to originating item (#1090)
 -  restore rereview and human-fix dispatch
@@ -44,7 +45,6 @@
 -  skip orphaned LLM retry when client disconnected during CC stream
 -  restore queue flush after abort — queued messages are user intent
 -  CC stale lock auto-release + queue drain on abort
--  CC streaming 'tabId' TDZ error on new tab first message
 
 ### Other
 - refactor(watches): rename maxTriggers→stopAfter, add onNotMet per-poll action

package/dashboard/js/render-watches.js

@@ -22,6 +22,8 @@ const _WATCH_CONDITION_LABELS = {
   failed: 'Failed',
   'status-change': 'Status Change',
   any: 'Any Change',
+  'new-comments': 'New Comments',
+  'vote-change': 'Vote Change',
 };
 
 function _intervalToHuman(ms) {
@@ -222,6 +224,8 @@ function _watchFormHtml() {
     { value: 'failed', label: 'Failed' },
     { value: 'status-change', label: 'Status Change' },
     { value: 'any', label: 'Any Change' },
+    { value: 'new-comments', label: 'New Comments' },
+    { value: 'vote-change', label: 'Vote Change' },
   ];
   var ttOpts = targetTypes.map(function(t) { return '<option value="' + t.value + '">' + t.label + '</option>'; }).join('');
   var condOpts = conditions.map(function(c) { return '<option value="' + c.value + '">' + c.label + '</option>'; }).join('');

package/dashboard/js/settings.js

@@ -51,12 +51,13 @@ async function openSettings() {
       settingsToggle('Auto-archive Plans', 'set-autoArchive', !!e.autoArchive, 'Automatically archive plans after verify completes (off = manual archive via dashboard)') +
       settingsToggle('Auto-fix Builds', 'set-autoFixBuilds', e.autoFixBuilds !== false, 'Auto-dispatch fix agents when a PR build fails') +
       settingsToggle('Auto-fix Conflicts', 'set-autoFixConflicts', e.autoFixConflicts !== false, 'Auto-dispatch fix agents when a PR has merge conflicts') +
+      settingsToggle('Auto-complete PRs', 'set-autoCompletePrs', !!e.autoCompletePrs, 'Auto-merge PRs when builds pass and review is approved (opt-in)') +
       settingsToggle('ADO Polling', 'set-adoPollEnabled', e.adoPollEnabled !== false, 'Poll ADO PR status and comments each tick (reconciliation always runs)') +
       settingsToggle('GitHub Polling', 'set-ghPollEnabled', e.ghPollEnabled !== false, 'Poll GitHub PR status and comments each tick (reconciliation always runs)') +
     '</div>' +
     '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
-      settingsField('ADO Status Poll Frequency', 'set-adoPollStatusEvery', e.adoPollStatusEvery || 6, 'ticks', 'Poll ADO PR build/review/merge status every N ticks (~6 min at default tick rate)') +
-      settingsField('ADO Comments Poll Frequency', 'set-adoPollCommentsEvery', e.adoPollCommentsEvery || 12, 'ticks', 'Poll ADO PR human comments every N ticks (~12 min at default tick rate)') +
+      settingsField('PR Status Poll Frequency', 'set-adoPollStatusEvery', e.adoPollStatusEvery || 6, 'ticks', 'Poll PR build/review/merge status every N ticks for both ADO and GitHub (~6 min at default tick rate)') +
+      settingsField('PR Comments Poll Frequency', 'set-adoPollCommentsEvery', e.adoPollCommentsEvery || 12, 'ticks', 'Poll PR human comments every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
     '</div>' +
     '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
       settingsField('Eval Max Iterations', 'set-evalMaxIterations', e.evalMaxIterations || 3, '', 'Max review→fix cycles before escalating (1-10)') +
@@ -242,6 +243,7 @@ async function saveSettings() {
       autoArchive: document.getElementById('set-autoArchive').checked,
       autoFixBuilds: document.getElementById('set-autoFixBuilds').checked,
       autoFixConflicts: document.getElementById('set-autoFixConflicts').checked,
+      autoCompletePrs: document.getElementById('set-autoCompletePrs').checked,
       adoPollEnabled: document.getElementById('set-adoPollEnabled').checked,
       ghPollEnabled: document.getElementById('set-ghPollEnabled').checked,
       adoPollStatusEvery: document.getElementById('set-adoPollStatusEvery').value,

package/dashboard.js

@@ -709,6 +709,24 @@ async function executeCCActions(actions) {
           results.push({ type: 'create-watch', id: watch.id, ok: true });
           break;
         }
+        case 'delete-watch': {
+          const deleted = watchesMod.deleteWatch(action.id);
+          if (deleted) invalidateStatusCache();
+          results.push({ type: 'delete-watch', id: action.id, ok: deleted });
+          break;
+        }
+        case 'pause-watch': {
+          const paused = watchesMod.updateWatch(action.id, { status: shared.WATCH_STATUS.PAUSED });
+          if (paused) invalidateStatusCache();
+          results.push({ type: 'pause-watch', id: action.id, ok: !!paused });
+          break;
+        }
+        case 'resume-watch': {
+          const resumed = watchesMod.updateWatch(action.id, { status: shared.WATCH_STATUS.ACTIVE });
+          if (resumed) invalidateStatusCache();
+          results.push({ type: 'resume-watch', id: action.id, ok: !!resumed });
+          break;
+        }
         default:
           // Server didn't handle — frontend must execute
           results.push({ type: action.type });

package/engine/lifecycle.js

@@ -707,15 +707,14 @@ function syncPrsFromOutput(output, agentId, meta, config) {
     const lines = output.split('\n');
     for (const line of lines) {
       try {
-        if (!line.includes('"type":"assistant"') && !line.includes('"type":"result"')) continue;
+        if (!line.includes('"type":"assistant"') && !line.includes('"type":"result"') && !line.includes('"type":"user"')) continue;
         const parsed = JSON.parse(line);
         const content = parsed.message?.content || [];
         for (const block of content) {
+          // Scan tool_result blocks in user messages for PR URLs (gh pr create output lands here)
           if (block.type === 'tool_result' && block.content) {
             const text = typeof block.content === 'string' ? block.content : JSON.stringify(block.content);
-            if (text.includes('pullRequestId') || text.includes('create_pull_request')) {
-              while ((match = urlPattern.exec(text)) !== null) prMatches.add(match[1] || match[2]);
-            }
+            while ((match = urlPattern.exec(text)) !== null) prMatches.add(match[1] || match[2]);
           }
           // Also scan assistant text blocks for PR URLs and "PR created" patterns
           if (block.type === 'text' && block.text) {

package/engine/shared.js

@@ -620,7 +620,7 @@ const PR_POLLABLE_STATUSES = new Set([PR_STATUS.ACTIVE, PR_STATUS.LINKED]);
 // Watch statuses — engine-level persistent watches that survive restarts
 const WATCH_STATUS = { ACTIVE: 'active', PAUSED: 'paused', TRIGGERED: 'triggered', EXPIRED: 'expired' };
 const WATCH_TARGET_TYPE = { PR: 'pr', WORK_ITEM: 'work-item' };
-const WATCH_CONDITION = { MERGED: 'merged', BUILD_FAIL: 'build-fail', BUILD_PASS: 'build-pass', COMPLETED: 'completed', FAILED: 'failed', STATUS_CHANGE: 'status-change', ANY: 'any' };
+const WATCH_CONDITION = { MERGED: 'merged', BUILD_FAIL: 'build-fail', BUILD_PASS: 'build-pass', COMPLETED: 'completed', FAILED: 'failed', STATUS_CHANGE: 'status-change', ANY: 'any', NEW_COMMENTS: 'new-comments', VOTE_CHANGE: 'vote-change' };
 // Absolute conditions auto-expire on first trigger when stopAfter=0 (fire-once semantics).
 // Change-based conditions (status-change, any) run forever when stopAfter=0.
 const WATCH_ABSOLUTE_CONDITIONS = new Set([

package/engine/watches.js

@@ -11,7 +11,7 @@
 const path = require('path');
 const shared = require('./shared');
 const { safeJson, mutateJsonFileLocked, ts, uid, log, writeToInbox,
-  WATCH_STATUS, WATCH_TARGET_TYPE, WATCH_CONDITION, WATCH_ABSOLUTE_CONDITIONS } = shared;
+  WATCH_STATUS, WATCH_TARGET_TYPE, WATCH_CONDITION } = shared;
 
 // Dynamic path — respects MINIONS_TEST_DIR for test isolation
 function _watchesPath() { return path.join(shared.MINIONS_DIR, 'engine', 'watches.json'); }
@@ -158,6 +158,16 @@ function evaluateWatch(watch, state) {
         );
         return { triggered: anyChanged, message: anyChanged ? `PR ${target} changed` : '' };
       }
+      case WATCH_CONDITION.NEW_COMMENTS: {
+        const lastCommentDate = pr.humanFeedback?.lastProcessedCommentDate || null;
+        const prevCommentDate = prevState.lastCommentDate || null;
+        const hasNew = lastCommentDate && lastCommentDate !== prevCommentDate;
+        return { triggered: !!hasNew, message: hasNew ? `PR ${target} has a new comment (${lastCommentDate})` : '' };
+      }
+      case WATCH_CONDITION.VOTE_CHANGE: {
+        const changed = prevState.reviewStatus !== undefined && prevState.reviewStatus !== pr.reviewStatus;
+        return { triggered: changed, message: changed ? `PR ${target} vote changed: ${prevState.reviewStatus} → ${pr.reviewStatus}` : '' };
+      }
       default:
         return { triggered: false, message: `Unknown condition: ${condition}` };
     }
@@ -237,7 +247,8 @@ function checkWatches(config, state) {
           }
           log('info', `Watch triggered: ${watch.id} — ${result.message}`);
 
-          // Expire when stopAfter limit is reached. stopAfter=0 means run forever (no limit).
+          // Expire when stopAfter > 0 and trigger count reaches the limit.
+          // stopAfter: 0 means "run forever" for all condition types.
           if (watch.stopAfter > 0 && watch.triggerCount >= watch.stopAfter) {
             watch.status = WATCH_STATUS.EXPIRED;
             log('info', `Watch expired (stopAfter limit reached): ${watch.id}`);
@@ -279,7 +290,7 @@ function _captureState(watch, state) {
     const pr = (state.pullRequests || []).find(p =>
       String(p.prNumber) === String(watch.target) || p.id === watch.target
     );
-    if (pr) return { status: pr.status, buildStatus: pr.buildStatus, reviewStatus: pr.reviewStatus };
+    if (pr) return { status: pr.status, buildStatus: pr.buildStatus, reviewStatus: pr.reviewStatus, lastCommentDate: pr.humanFeedback?.lastProcessedCommentDate || null };
   }
   if (watch.targetType === WATCH_TARGET_TYPE.WORK_ITEM) {
     const wi = (state.workItems || []).find(w => w.id === watch.target);

package/engine.js

@@ -3188,11 +3188,12 @@ async function tickInner() {
   if (tickCount % 3 === 0) {
     safe('checkWatches', () => {
       const { checkWatches } = require('./engine/watches');
-      const pullRequests = PROJECTS.flatMap(p => {
+      const projects = getProjects(config);
+      const pullRequests = projects.flatMap(p => {
         const prPath = path.join(MINIONS_DIR, 'projects', p.name, 'pull-requests.json');
         return safeJson(prPath) || [];
       });
-      const workItems = PROJECTS.flatMap(p => {
+      const workItems = projects.flatMap(p => {
         const wiPath = path.join(MINIONS_DIR, 'projects', p.name, 'work-items.json');
         return safeJson(wiPath) || [];
       });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.983",
+  "version": "0.1.985",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/prompts/cc-system.md

@@ -82,9 +82,15 @@ Additional actions (all take `id` or `file` as primary key):
 - Meetings: add-meeting-note (id, note), advance-meeting (id), end-meeting (id), archive-meeting (id), unarchive-meeting (id), delete-meeting (id)
 - Work item ops: delete-work-item (id, source), archive-work-item (id), work-item-feedback (id, rating: up/down, comment), reopen-work-item (id, project[, description] — reopen a done/failed item back to pending)
 - PRD ops: edit-prd-item, remove-prd-item, reopen-prd-item (id, file — re-dispatches on existing branch)
-- **create-watch**: target, targetType (pr/work-item/branch), condition (merged/build-fail/build-pass/completed/failed/status-change/any), interval ("15m", "1h", "30s" — default "5m"), owner (agent id or "human"), description, project, stopAfter (0=run forever, 1=expire on first match, N=expire after N matches), onNotMet (null=do nothing, "notify"=write to inbox each poll while condition not met)
+- **create-watch**: target, targetType (pr/work-item), condition (merged/build-fail/build-pass/completed/failed/status-change/any/new-comments/vote-change), interval ("15m", "1h", "30s" — default "5m"), owner (agent id or "human"), description, project, stopAfter (0=run forever, 1=expire on first match, N=expire after N matches), onNotMet (null=do nothing, "notify"=write to inbox each poll while condition not met)
   Example: user says "check PR 1065 build every 15 min until green" → `{"type":"create-watch","target":"1065","targetType":"pr","condition":"build-pass","interval":"15m","stopAfter":1,"description":"Watch PR 1065 build until green"}`
   Example: user says "ping me every 15 min while build is still failing" → `{"type":"create-watch","target":"1065","targetType":"pr","condition":"build-pass","interval":"15m","stopAfter":1,"onNotMet":"notify","description":"Watch PR 1065 build — notify each poll"}`
+- **delete-watch**: id — remove a watch permanently
+  Example: user says "stop watching PR 1065" → `{"type":"delete-watch","id":"watch-abc123"}`
+- **pause-watch**: id — pause a watch without deleting it (can be resumed later)
+  Example: user says "pause the PR 1065 watch" → `{"type":"pause-watch","id":"watch-abc123"}`
+- **resume-watch**: id — resume a paused watch
+  Example: user says "resume watching PR 1065" → `{"type":"resume-watch","id":"watch-abc123"}`
 - KB/Inbox: promote-to-kb (file, category), kb-sweep, toggle-kb-pin (key)
 - Plan lifecycle: revise-plan (file, feedback — dispatches agent to revise)
 - Pipeline: continue-pipeline (id — resume past wait stage)