@yemi33/minions 0.1.977 → 0.1.978

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.977 (2026-04-14)
+## 0.1.978 (2026-04-15)
 
 ### Features
 - free-form interval input + CC create-watch action
@@ -25,6 +25,7 @@
 - CC tab unread dot + reopened badge on work items
 
 ### Fixes
+-  ENGINE_DEFAULTS undefined in tick + playbook empty-var false positives
 -  defer review setCooldown to post-gating in discoverWork
 -  move review verdict check before updateWorkItemStatus(DONE)
 -  address review feedback — move writeToInbox outside lock, add absolute condition auto-expire
@@ -44,7 +45,6 @@
 - defer setCooldown to post-gating in discoverWork
 - fix CC queued message 'already processing' and thinking UX stacking
 - enforce --timeout 1 on all azureauth calls to prevent agent orphans (#1063)
-- cancel steering kill watcher on resume spawn (#1052) (#1062)
 
 ### Other
 - refactor(watches): rename maxTriggers→stopAfter, add onNotMet per-poll action

package/dashboard/js/command-center.js

@@ -388,15 +388,14 @@ async function ccSend() {
   }
   var wasAborted = await _ccDoSend(message, false, originTabId);
 
-  // Flush all queued messages at once — combine into a single request.
-  // Loop in case user queues more messages while the combined flush is processing.
+  // Flush queued messages to the ORIGINAL tab, even if user switched tabs
   while (tab._queue && tab._queue.length > 0) {
     if (wasAborted) {
       await new Promise(function(r) { setTimeout(r, 1500); });
     }
-    var combined = tab._queue.splice(0);
+    var next = tab._queue.shift();
     _renderQueueIndicator();
-    wasAborted = await _ccDoSend(combined.join('\n\n'), false, originTabId);
+    wasAborted = await _ccDoSend(next, false, originTabId);
   }
 }
 

package/engine/playbook.js

@@ -268,10 +268,32 @@ function validatePlaybookVars(playbookName, vars) {
   return { valid: missing.length === 0, missing };
 }
 
+// ─── Playbook Path Resolution ───────────────────────────────────────────────
+
+/**
+ * Resolve playbook file path, checking project-local override first.
+ * If projects/<projectName>/playbooks/<playbookType>.md exists, use it.
+ * Otherwise fall back to the global playbooks/<playbookType>.md.
+ * @param {string|null|undefined} projectName — project name (directory under projects/)
+ * @param {string} playbookType — playbook type name (e.g. 'implement', 'review')
+ * @returns {string} absolute path to the playbook file
+ */
+function resolvePlaybookPath(projectName, playbookType) {
+  if (projectName) {
+    const localPath = path.join(MINIONS_DIR, 'projects', projectName, 'playbooks', `${playbookType}.md`);
+    try {
+      fs.accessSync(localPath, fs.constants.R_OK);
+      return localPath;
+    } catch { /* no local override — fall through to global */ }
+  }
+  return path.join(PLAYBOOKS_DIR, `${playbookType}.md`);
+}
+
 // ─── Playbook Renderer ──────────────────────────────────────────────────────
 
 function renderPlaybook(type, vars) {
-  const pbPath = path.join(PLAYBOOKS_DIR, `${type}.md`);
+  const projectName = vars.project_name || null;
+  const pbPath = resolvePlaybookPath(projectName, type);
   let content;
   try { content = fs.readFileSync(pbPath, 'utf8'); } catch {
     log('warn', `Playbook not found: ${type}`);
@@ -361,6 +383,9 @@ function renderPlaybook(type, vars) {
     return null;
   }
 
+  // Capture which vars are actually referenced in the template before substitution
+  const referencedVars = new Set((content.match(/\{\{(\w+)\}\}/g) || []).map(m => m.slice(2, -2)));
+
   // Process conditional blocks: {{#key}}...{{/key}} — include block only if key is truthy
   content = content.replace(/\{\{#(\w+)\}\}([\s\S]*?)\{\{\/\1\}\}/g, (_, key, block) => {
     const val = allVars[key];
@@ -380,9 +405,9 @@ function renderPlaybook(type, vars) {
     log('warn', `Playbook "${type}": substituted values contain unresolved {{...}} patterns (potential self-reference): ${selfRefVars.join(', ')}`);
   }
 
-  // Warn on variables that resolved to empty string (skip known-optional vars)
+  // Warn on variables that resolved to empty string — only for vars actually used in the template
   const emptyVars = Object.entries(allVars)
-    .filter(([key, val]) => String(val) === '' && !PLAYBOOK_OPTIONAL_VARS.has(key))
+    .filter(([key, val]) => String(val) === '' && referencedVars.has(key) && !PLAYBOOK_OPTIONAL_VARS.has(key))
     .map(([key]) => key);
   if (emptyVars.length > 0) {
     log('warn', `Playbook "${type}": template variables resolved to empty string: ${emptyVars.join(', ')}`);
@@ -565,6 +590,7 @@ function buildPrDispatch(agentId, config, project, pr, type, extraVars, taskLabe
 
 module.exports = {
   renderPlaybook,
+  resolvePlaybookPath,
   validatePlaybookVars,
   PLAYBOOK_REQUIRED_VARS,
   PLAYBOOK_OPTIONAL_VARS,

package/engine/shared.js

@@ -617,8 +617,6 @@ const PR_POLLABLE_STATUSES = new Set([PR_STATUS.ACTIVE, PR_STATUS.LINKED]);
 const WATCH_STATUS = { ACTIVE: 'active', PAUSED: 'paused', TRIGGERED: 'triggered', EXPIRED: 'expired' };
 const WATCH_TARGET_TYPE = { PR: 'pr', WORK_ITEM: 'work-item' };
 const WATCH_CONDITION = { MERGED: 'merged', BUILD_FAIL: 'build-fail', BUILD_PASS: 'build-pass', COMPLETED: 'completed', FAILED: 'failed', STATUS_CHANGE: 'status-change', ANY: 'any' };
-// Absolute conditions check point-in-time state, not transitions — auto-expire after first trigger when stopAfter is 0
-const WATCH_ABSOLUTE_CONDITIONS = new Set([WATCH_CONDITION.MERGED, WATCH_CONDITION.BUILD_FAIL, WATCH_CONDITION.BUILD_PASS, WATCH_CONDITION.COMPLETED, WATCH_CONDITION.FAILED]);
 
 /** Update per-agent review metrics (prsApproved/prsRejected). Only writes for configured agents. */
 function trackReviewMetric(pr, newReviewStatus, config) {
@@ -1145,7 +1143,7 @@ module.exports = {
   classifyInboxItem,
   ENGINE_DEFAULTS,
   WI_STATUS, DONE_STATUSES, PLAN_TERMINAL_STATUSES, WORK_TYPE, PLAN_STATUS, PRD_ITEM_STATUS, PRD_MATERIALIZABLE, PR_STATUS, PR_POLLABLE_STATUSES, DISPATCH_RESULT, trackReviewMetric, queuePlanToPrd,
-  WATCH_STATUS, WATCH_TARGET_TYPE, WATCH_CONDITION, WATCH_ABSOLUTE_CONDITIONS,
+  WATCH_STATUS, WATCH_TARGET_TYPE, WATCH_CONDITION,
   PIPELINE_STATUS, STAGE_TYPE, MEETING_STATUS, AGENT_STATUS,
   FAILURE_CLASS, ESCALATION_POLICY, COMPLETION_FIELDS,
   DEFAULT_AGENT_METRICS,

package/engine.js

@@ -1984,46 +1984,6 @@ async function discoverFromPrs(config, project) {
       if (item) { newWork.push(item); }
     }
 
-    // Re-review after fix: only trigger when fixedAt > lastReviewedAt (not a broad !alreadyReviewed
-    // fallback — that caused infinite re-review loops on GitHub where self-approval is blocked)
-    const fixedAfterReview = !!(pr.minionsReview?.fixedAt &&
-      pr.lastReviewedAt && pr.minionsReview.fixedAt > pr.lastReviewedAt);
-    const needsReReview = autoReview && reviewStatus === 'waiting' &&
-      fixedAfterReview && !evalEscalated;
-    if (needsReReview) {
-      const key = `review-${project?.name || 'default'}-${pr.id}`;
-      // Skip isAlreadyDispatched — fixedAfterReview/alreadyReviewed already dedup; the 1hr
-      // completed-dispatch window would block legitimate re-reviews within the hour after a fix
-      if (isOnCooldown(key, cooldownMs)) continue;
-
-      // Pre-dispatch live vote check — cached 'waiting' may be stale if reviewer already acted
-      try {
-        const checkFn = project.repoHost === 'github' ? ghCheckLiveReview : adoCheckLiveReview;
-        const liveStatus = await checkFn(pr, project);
-        if (liveStatus && liveStatus !== 'waiting') {
-          log('info', `Pre-dispatch vote check: ${pr.id} is ${liveStatus} (cached was waiting) — skipping re-review`);
-          if (pr.reviewStatus !== 'approved') pr.reviewStatus = liveStatus;
-          try {
-            mutateJsonFileLocked(projectPrPath(project), data => {
-              if (!Array.isArray(data)) return data;
-              const target = data.find(p => p.id === pr.id);
-              if (target && target.reviewStatus !== 'approved') target.reviewStatus = liveStatus;
-              return data;
-            });
-          } catch {}
-          continue;
-        }
-      } catch (e) { log('warn', `Pre-dispatch vote check for ${pr.id}: ${e.message}`); }
-
-      const agentId = resolveAgent('review', config);
-      if (!agentId) continue;
-      const item = buildPrDispatch(agentId, config, project, pr, 'review', {
-        pr_id: pr.id, pr_number: prNumber, pr_title: pr.title || '', pr_branch: pr.branch || '',
-        pr_author: pr.agent || '', pr_url: pr.url || '',
-      }, `Review ${pr.id}: ${pr.title}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
-      if (item) { newWork.push(item); }
-    }
-
     // PRs with changes requested → route back to author for fix
     let fixDispatched = false;
     if (reviewStatus === 'changes-requested' && !awaitingReReview && !evalEscalated) {
@@ -2037,7 +1997,7 @@ async function discoverFromPrs(config, project) {
         review_note: pr.minionsReview?.note || pr.reviewNote || 'See PR thread comments',
       }, `Fix ${pr.id}: ${pr.title || ''} — review feedback`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
       if (item) {
-        newWork.push(item); fixDispatched = true;
+        newWork.push(item); setCooldown(key); fixDispatched = true;
         // Increment review→fix cycle counter
         try {
           mutatePullRequests(projectPrPath(project), prs => {
@@ -2075,7 +2035,7 @@ async function discoverFromPrs(config, project) {
         reviewer: 'Human Reviewer',
         review_note: reviewNote,
       }, `Fix ${pr.id}: ${pr.title || ''} — human feedback`, { dispatchKey: key, source: 'pr-human-feedback', pr, branch: pr.branch, project: projMeta });
-      if (item) { newWork.push(item); fixDispatched = true; }
+      if (item) { newWork.push(item); setCooldown(key); fixDispatched = true; }
     }
 
     // PRs with build failures — route to author (has session context from implementing)
@@ -2124,7 +2084,7 @@ async function discoverFromPrs(config, project) {
         review_note: reviewNote,
       }, `Fix build failure on ${pr.id}: ${pr.title || ''}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
       if (item) {
-        newWork.push(item);
+        newWork.push(item); setCooldown(key);
         // Increment build fix attempts counter
         try {
           const prPath = projectPrPath(project);
@@ -2181,6 +2141,7 @@ async function discoverFromPrs(config, project) {
           }, `Fix merge conflicts on ${pr.id}: ${pr.title || ''}`, { dispatchKey: key, source: 'pr', pr, branch: pr.branch, project: projMeta });
           if (item) {
             newWork.push(item);
+            setCooldown(key);
             // Record dispatch timestamp so re-dispatch is suppressed during ADO lag window
             try {
               mutatePullRequests(projectPrPath(project), prs => {
@@ -3390,7 +3351,7 @@ async function tickInner() {
     if (busyAgents.has(item.agent)) {
       // Agent busy reassignment: if item has been waiting on a busy agent past the threshold,
       // try to find an alternative agent via routing. Skip explicitly assigned items.
-      const reassignMs = config.engine?.agentBusyReassignMs ?? ENGINE_DEFAULTS.agentBusyReassignMs;
+      const reassignMs = config.engine?.agentBusyReassignMs ?? DEFAULTS.agentBusyReassignMs;
       const isExplicitReassign = !!item.meta?.item?.agent;
       if (!isExplicitReassign && reassignMs > 0 && item._agentBusySince) {
         const busySinceMs = new Date(item._agentBusySince).getTime();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.977",
+  "version": "0.1.978",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"